Title: build,tools: make addons tests work with GN by zcbenz · Pull Request #50737 · nodejs/node · GitHub
Open Graph Title: build,tools: make addons tests work with GN by zcbenz · Pull Request #50737 · nodejs/node
X Title: build,tools: make addons tests work with GN by zcbenz · Pull Request #50737 · nodejs/node
Description: This PR refactors the install and build_addons scripts so they can be reused by node-ci and electron projects to build the addons tests. In detail, this PR does following things: Minor modifications of the GN configurations to fix loading native modules. Add some flags to tools/install.py script to allow customize locations of config.gypi, v8, etc. With some refactoring to remove global variables. Rewrite the tools/build_addons.py script: Rewrite it from js to python, because implementing cmd args handling with vanilla Node.js would take much longer time than a simple rewrite. Add a few more flags to make it easier to use for embedders. Modify the Makefile to generate headers in out dir first, and then calls build_addons.py --headers-dir=out_dir/headers (which calls node-gyp --nodedir=out_dir/headers) to build addons. Previously the build system was just calling node-gyp --nodedir=., which relied on quirky behavior of node-gyp and did not really test whether the generated headers work. Users that rely on make or vcbuild.bat to work on Node are not affected.
Open Graph Description: This PR refactors the install and build_addons scripts so they can be reused by node-ci and electron projects to build the addons tests. In detail, this PR does following things: Minor modificatio...
X Description: This PR refactors the install and build_addons scripts so they can be reused by node-ci and electron projects to build the addons tests. In detail, this PR does following things: Minor modificatio...
Opengraph URL: https://github.com/nodejs/node/pull/50737
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:620da34e-2a1c-98f5-7765-765290acfae3 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | E76C:1C01B5:1CEF06:28C5F5:6969FF51 |
| html-safe-nonce | fc673db031610c15a63aaf6ee274385f4fc90a00120c130556ce1287d3f2cb9f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzZDOjFDMDFCNToxQ0VGMDY6MjhDNUY1OjY5NjlGRjUxIiwidmlzaXRvcl9pZCI6IjI3NDgzNzc0MTQ0NTY5NjY5OTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c40e64b3d5606ab1d74c3aee8ed6101f7a08bde64cc1177bd318a9a2a0f56bbe |
| hovercard-subject-tag | pull_request:1602108652 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/50737/checks |
| twitter:image | https://avatars.githubusercontent.com/u/639601?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/639601?s=400&v=4 |
| og:image:alt | This PR refactors the install and build_addons scripts so they can be reused by node-ci and electron projects to build the addons tests. In detail, this PR does following things: Minor modificatio... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width