| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3afd2b6c-ddfb-e325-62d6-45db92f15da8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9A94:A4D20:76769C:A249F9:6969E211 |
| html-safe-nonce | f918130ebbce060078469033cf671681add6d3f28d81c30721c3bea5c04ac7e3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTk0OkE0RDIwOjc2NzY5QzpBMjQ5Rjk6Njk2OUUyMTEiLCJ2aXNpdG9yX2lkIjoiNTM1NzQ5NzU1NTA1NTk4OTkzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ba6feccb360953f8b1f4edd78a56edb6bb4172d7131b85b19201978eaca02436 |
| hovercard-subject-tag | pull_request:1602108652 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/50737/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/40b005702bfdca2c47a003eaf31bc580839ee1816f4031c6cc31fa3d6eddc8b4/nodejs/node/pull/50737 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/40b005702bfdca2c47a003eaf31bc580839ee1816f4031c6cc31fa3d6eddc8b4/nodejs/node/pull/50737 |
| og:image:alt | This PR refactors the install and build_addons scripts so they can be reused by node-ci and electron projects to build the addons tests.
In detail, this PR does following things:
Minor modificatio... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | zcbenz |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/50737#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50737 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50737 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/50737 |
| Reload | https://github.com/nodejs/node/pull/50737 |
| Reload | https://github.com/nodejs/node/pull/50737 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/50737 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/50737 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/50737#issue-comment-box |
| zcbenz | https://github.com/zcbenz |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| zcbenz:build-addons-gn | https://github.com/zcbenz/node/tree/build-addons-gn |
|
build,tools: make addons tests work with GN
| https://github.com/nodejs/node/pull/50737#top |
| zcbenz | https://github.com/zcbenz |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| zcbenz:build-addons-gn | https://github.com/zcbenz/node/tree/build-addons-gn |
|
Conversation
30
| https://github.com/nodejs/node/pull/50737 |
|
Commits
3
| https://github.com/nodejs/node/pull/50737/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/50737/checks |
|
Files changed
| https://github.com/nodejs/node/pull/50737/files |
| Please reload this page | https://github.com/nodejs/node/pull/50737 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
| Nov 15, 2023 | https://github.com/nodejs/node/pull/50737#issue-1994289759 |
| Please reload this page | https://github.com/nodejs/node/pull/50737 |
| node-ci | https://chromium.googlesource.com/v8/node-ci/ |
| Please reload this page | https://github.com/nodejs/node/pull/50737 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 15, 2023 | https://github.com/nodejs/node/pull/50737#issuecomment-1812008406 |
| Please reload this page | https://github.com/nodejs/node/pull/50737 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
dependencies
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adependencies |
|
libuv
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alibuv |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
openssl
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aopenssl |
|
python
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apython |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
|
windows
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows |
| Nov 15, 2023 | https://github.com/nodejs/node/pull/50737#event-10964388734 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
| force-pushed | https://github.com/nodejs/node/compare/507f7ab9887f79909b96bd9f6620b16f6be62f8e..353afc9888e3a545a191d777d0b08f7ee759f4a8 |
| 507f7ab | https://github.com/nodejs/node/commit/507f7ab9887f79909b96bd9f6620b16f6be62f8e |
| 353afc9 | https://github.com/nodejs/node/commit/353afc9888e3a545a191d777d0b08f7ee759f4a8 |
|
Compare
| https://github.com/nodejs/node/compare/507f7ab9887f79909b96bd9f6620b16f6be62f8e..353afc9888e3a545a191d777d0b08f7ee759f4a8 |
| November 15, 2023 11:06 | https://github.com/nodejs/node/pull/50737#event-10966050662 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
|
Nov 15, 2023
| https://github.com/nodejs/node/pull/50737#ref-issue-1991709228 |
|
Things blocking a full-featured GN build of upstream Node.js
photoionization/node_with_gn#1
| https://github.com/photoionization/node_with_gn/issues/1 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
| force-pushed | https://github.com/nodejs/node/compare/094086440202d63221c057acb68c239c00d811da..13f87fcbcf7a68e86f35660ff3601bc7a5218fac |
| 0940864 | https://github.com/nodejs/node/commit/094086440202d63221c057acb68c239c00d811da |
| 13f87fc | https://github.com/nodejs/node/commit/13f87fcbcf7a68e86f35660ff3601bc7a5218fac |
|
Compare
| https://github.com/nodejs/node/compare/094086440202d63221c057acb68c239c00d811da..13f87fcbcf7a68e86f35660ff3601bc7a5218fac |
| November 16, 2023 07:32 | https://github.com/nodejs/node/pull/50737#event-10976829171 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
| Nov 16, 2023 | https://github.com/nodejs/node/pull/50737#issuecomment-1813938800 |
| @joyeecheung | https://github.com/joyeecheung |
| @richardlau | https://github.com/richardlau |
| Please reload this page | https://github.com/nodejs/node/pull/50737 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Nov 16, 2023
| https://github.com/nodejs/node/pull/50737#pullrequestreview-1735158749 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/50737/files |
| tools/build_addons.py | https://github.com/nodejs/node/pull/50737/files#diff-27ca119fcaf394ebbc6d2061fba9e577aea278c4ac4ca8d6b52a377c60f79e03 |
| Please reload this page | https://github.com/nodejs/node/pull/50737 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 17, 2023 | https://github.com/nodejs/node/pull/50737#event-10988747226 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 17, 2023 | https://github.com/nodejs/node/pull/50737#event-10988835176 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 17, 2023 | https://github.com/nodejs/node/pull/50737#issuecomment-1815655665 |
| https://ci.nodejs.org/job/node-test-pull-request/55698/ | https://ci.nodejs.org/job/node-test-pull-request/55698/ |
| Please reload this page | https://github.com/nodejs/node/pull/50737 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
| Nov 28, 2023 | https://github.com/nodejs/node/pull/50737#issuecomment-1828894866 |
| @joyeecheung | https://github.com/joyeecheung |
| @anonrig | https://github.com/anonrig |
| Please reload this page | https://github.com/nodejs/node/pull/50737 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Nov 28, 2023
| https://github.com/nodejs/node/pull/50737#pullrequestreview-1754139805 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/50737/files |
| joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/50737 |
| https://github.com/nodejs/node/pull/50737#pullrequestreview-1754139805 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/50737 |
| Makefile | https://github.com/nodejs/node/pull/50737/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52 |
| Please reload this page | https://github.com/nodejs/node/pull/50737 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
| force-pushed | https://github.com/nodejs/node/compare/118f73800eebd1cb6d98fea7e1067e3d0f01dcb5..5348591c867c18741fb0c85a218879cdbea250aa |
| 118f738 | https://github.com/nodejs/node/commit/118f73800eebd1cb6d98fea7e1067e3d0f01dcb5 |
| 5348591 | https://github.com/nodejs/node/commit/5348591c867c18741fb0c85a218879cdbea250aa |
|
Compare
| https://github.com/nodejs/node/compare/118f73800eebd1cb6d98fea7e1067e3d0f01dcb5..5348591c867c18741fb0c85a218879cdbea250aa |
| November 29, 2023 00:09 | https://github.com/nodejs/node/pull/50737#event-11090089726 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Nov 29, 2023
| https://github.com/nodejs/node/pull/50737#pullrequestreview-1756204771 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/50737/files |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
|
Dec 1, 2023
| https://github.com/nodejs/node/pull/50737#ref-issue-2020364885 |
|
Create a branch on latest main
v8/node#172
| https://github.com/v8/node/issues/172 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Dec 4, 2023 | https://github.com/nodejs/node/pull/50737#event-11135054451 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Dec 4, 2023 | https://github.com/nodejs/node/pull/50737#event-11135065180 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 4, 2023 | https://github.com/nodejs/node/pull/50737#issuecomment-1837980221 |
| https://ci.nodejs.org/job/node-test-pull-request/56066/ | https://ci.nodejs.org/job/node-test-pull-request/56066/ |
| Please reload this page | https://github.com/nodejs/node/pull/50737 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
| force-pushed | https://github.com/nodejs/node/compare/974401b53db0659cf6488fed5f6ff85b14e8673a..3be1111eb7d741dbaa1637b510f3318e72670ca3 |
| 974401b | https://github.com/nodejs/node/commit/974401b53db0659cf6488fed5f6ff85b14e8673a |
| 3be1111 | https://github.com/nodejs/node/commit/3be1111eb7d741dbaa1637b510f3318e72670ca3 |
|
Compare
| https://github.com/nodejs/node/compare/974401b53db0659cf6488fed5f6ff85b14e8673a..3be1111eb7d741dbaa1637b510f3318e72670ca3 |
| January 4, 2024 02:28 | https://github.com/nodejs/node/pull/50737#event-11384742795 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
| February 23, 2024 07:17 | https://github.com/nodejs/node/pull/50737#event-11900102786 |
| marco-ippolito | https://github.com/marco-ippolito |
|
Feb 26, 2024
| https://github.com/nodejs/node/pull/50737#ref-commit-2982ab1 |
|
| https://github.com/zcbenz |
|
| https://github.com/marco-ippolito |
| build,tools: make addons tests work with GN | https://github.com/nodejs/node/commit/2982ab11c732a2928de6b5637c39a6e96f7bf559 |
| 2982ab1 | https://github.com/nodejs/node/commit/2982ab11c732a2928de6b5637c39a6e96f7bf559 |
| #50737 | https://github.com/nodejs/node/pull/50737 |
| marco-ippolito | https://github.com/marco-ippolito |
|
Feb 26, 2024
| https://github.com/nodejs/node/pull/50737#ref-commit-0f1bbea |
|
| https://github.com/zcbenz |
|
| https://github.com/marco-ippolito |
| build,tools: make addons tests work with GN | https://github.com/nodejs/node/commit/0f1bbeaf7e00228506c075a49c3e74c410c8164a |
| 0f1bbea | https://github.com/nodejs/node/commit/0f1bbeaf7e00228506c075a49c3e74c410c8164a |
| #50737 | https://github.com/nodejs/node/pull/50737 |
| marco-ippolito | https://github.com/marco-ippolito |
|
Feb 27, 2024
| https://github.com/nodejs/node/pull/50737#ref-commit-5911731 |
|
| https://github.com/zcbenz |
|
| https://github.com/marco-ippolito |
| build,tools: make addons tests work with GN | https://github.com/nodejs/node/commit/59117317f3a08a10484a933918171cd725707cd7 |
| 5911731 | https://github.com/nodejs/node/commit/59117317f3a08a10484a933918171cd725707cd7 |
| #50737 | https://github.com/nodejs/node/pull/50737 |
| https://github.com/batrla |
| batrla | https://github.com/batrla |
| Feb 28, 2024 | https://github.com/nodejs/node/pull/50737#issuecomment-1968696720 |
| Please reload this page | https://github.com/nodejs/node/pull/50737 |
| Please reload this page | https://github.com/nodejs/node/pull/50737 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
| Feb 28, 2024 | https://github.com/nodejs/node/pull/50737#issuecomment-1968734152 |
| Please reload this page | https://github.com/nodejs/node/pull/50737 |
| zcbenz | https://github.com/zcbenz |
|
Feb 28, 2024
| https://github.com/nodejs/node/pull/50737#ref-commit-a0e52cb |
|
| https://github.com/zcbenz |
| tools: fix installing node with shared mode | https://github.com/zcbenz/node/commit/a0e52cbc91e68c29a2827ca1e84e3d9b6c15fcb5 |
| a0e52cb | https://github.com/zcbenz/node/commit/a0e52cbc91e68c29a2827ca1e84e3d9b6c15fcb5 |
| nodejs#50737 | https://github.com/nodejs/node/pull/50737 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
|
Feb 28, 2024
| https://github.com/nodejs/node/pull/50737#ref-pullrequest-2158812106 |
|
tools: fix installing node with shared mode
#51910
| https://github.com/nodejs/node/pull/51910 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
|
Mar 1, 2024
| https://github.com/nodejs/node/pull/50737#ref-pullrequest-2162891978 |
|
v21.7.0 proposal
#51932
| https://github.com/nodejs/node/pull/51932 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Mar 1, 2024
| https://github.com/nodejs/node/pull/50737#ref-commit-6aa1d98 |
|
| https://github.com/zcbenz |
| tools: fix installing node with shared mode | https://github.com/nodejs/node/commit/6aa1d98fa53773cecafd54b925703ae8a9f1c63b |
| 6aa1d98 | https://github.com/nodejs/node/commit/6aa1d98fa53773cecafd54b925703ae8a9f1c63b |
| #50737 | https://github.com/nodejs/node/pull/50737 |
| #51910 | https://github.com/nodejs/node/pull/51910 |
| marco-ippolito | https://github.com/marco-ippolito |
|
Mar 1, 2024
| https://github.com/nodejs/node/pull/50737#ref-commit-0711e3b |
|
| https://github.com/zcbenz |
|
| https://github.com/marco-ippolito |
| tools: fix installing node with shared mode | https://github.com/nodejs/node/commit/0711e3ba29ea33a43f1561c68e11e1caf396668d |
| 0711e3b | https://github.com/nodejs/node/commit/0711e3ba29ea33a43f1561c68e11e1caf396668d |
| #50737 | https://github.com/nodejs/node/pull/50737 |
| #51910 | https://github.com/nodejs/node/pull/51910 |
| marco-ippolito | https://github.com/marco-ippolito |
|
Mar 1, 2024
| https://github.com/nodejs/node/pull/50737#ref-commit-27f8549 |
|
| https://github.com/zcbenz |
|
| https://github.com/marco-ippolito |
| tools: fix installing node with shared mode | https://github.com/nodejs/node/commit/27f85499033465f6b9f94e9e978733c7e4b12997 |
| 27f8549 | https://github.com/nodejs/node/commit/27f85499033465f6b9f94e9e978733c7e4b12997 |
| #50737 | https://github.com/nodejs/node/pull/50737 |
| #51910 | https://github.com/nodejs/node/pull/51910 |
| zcbenz | https://github.com/zcbenz |
|
Mar 6, 2024
| https://github.com/nodejs/node/pull/50737#ref-commit-625aecc |
| Update node | https://github.com/photoionization/node_ci/commit/625aeccf77fbf32feb645646e1fda1e60e0d5d11 |
| 625aecc | https://github.com/photoionization/node_ci/commit/625aeccf77fbf32feb645646e1fda1e60e0d5d11 |
| nodejs/node#50737 | https://github.com/nodejs/node/pull/50737 |
| https://chromium-review.googlesource.com/c/v8/node-ci/+/5203209 | https://chromium-review.googlesource.com/c/v8/node-ci/+/5203209 |
| richardlau | https://github.com/richardlau |
|
Mar 25, 2024
| https://github.com/nodejs/node/pull/50737#ref-commit-602e491 |
|
| https://github.com/zcbenz |
|
| https://github.com/richardlau |
| build,tools: make addons tests work with GN | https://github.com/nodejs/node/commit/602e4912ad8fa3b6bd2ec11b11e7f9736795c4f6 |
| 602e491 | https://github.com/nodejs/node/commit/602e4912ad8fa3b6bd2ec11b11e7f9736795c4f6 |
| #50737 | https://github.com/nodejs/node/pull/50737 |
| richardlau | https://github.com/richardlau |
|
Mar 25, 2024
| https://github.com/nodejs/node/pull/50737#ref-commit-818afbd |
|
| https://github.com/zcbenz |
|
| https://github.com/richardlau |
| tools: fix installing node with shared mode | https://github.com/nodejs/node/commit/818afbd407163d0fcd1d43992b137fb369fbcd3c |
| 818afbd | https://github.com/nodejs/node/commit/818afbd407163d0fcd1d43992b137fb369fbcd3c |
| #50737 | https://github.com/nodejs/node/pull/50737 |
| #51910 | https://github.com/nodejs/node/pull/51910 |
| richardlau | https://github.com/richardlau |
|
Mar 25, 2024
| https://github.com/nodejs/node/pull/50737#ref-commit-ffe467b |
|
| https://github.com/zcbenz |
|
| https://github.com/richardlau |
| build,tools: make addons tests work with GN | https://github.com/nodejs/node/commit/ffe467b062fa09675745f2b6a9d00f8f53796bad |
| ffe467b | https://github.com/nodejs/node/commit/ffe467b062fa09675745f2b6a9d00f8f53796bad |
| #50737 | https://github.com/nodejs/node/pull/50737 |
| richardlau | https://github.com/richardlau |
|
Mar 25, 2024
| https://github.com/nodejs/node/pull/50737#ref-commit-f4ac7ba |
|
| https://github.com/zcbenz |
|
| https://github.com/richardlau |
| tools: fix installing node with shared mode | https://github.com/nodejs/node/commit/f4ac7baf85ddcc3f793dae051376a69f8eb80fe4 |
| f4ac7ba | https://github.com/nodejs/node/commit/f4ac7baf85ddcc3f793dae051376a69f8eb80fe4 |
| #50737 | https://github.com/nodejs/node/pull/50737 |
| #51910 | https://github.com/nodejs/node/pull/51910 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Mar 25, 2024
| https://github.com/nodejs/node/pull/50737#ref-pullrequest-2206634908 |
|
v20.12.0 proposal
#52212
| https://github.com/nodejs/node/pull/52212 |
| rdw-msft | https://github.com/rdw-msft |
|
Mar 26, 2024
| https://github.com/nodejs/node/pull/50737#ref-commit-3da1bbc |
|
| https://github.com/zcbenz |
|
| https://github.com/rdw-msft |
| build,tools: make addons tests work with GN | https://github.com/rdw-msft/node/commit/3da1bbc3543bb4d52ff8d3d7ed07c44f89ea64c5 |
| 3da1bbc | https://github.com/rdw-msft/node/commit/3da1bbc3543bb4d52ff8d3d7ed07c44f89ea64c5 |
| nodejs#50737 | https://github.com/nodejs/node/pull/50737 |
| rdw-msft | https://github.com/rdw-msft |
|
Mar 26, 2024
| https://github.com/nodejs/node/pull/50737#ref-commit-7e6614b |
|
| https://github.com/zcbenz |
|
| https://github.com/rdw-msft |
| tools: fix installing node with shared mode | https://github.com/rdw-msft/node/commit/7e6614bc2ef264d70a2baaa5668763f4d1cc5059 |
| 7e6614b | https://github.com/rdw-msft/node/commit/7e6614bc2ef264d70a2baaa5668763f4d1cc5059 |
| nodejs#50737 | https://github.com/nodejs/node/pull/50737 |
| nodejs#51910 | https://github.com/nodejs/node/pull/51910 |
| https://github.com/vmoroz |
| vmoroz | https://github.com/vmoroz |
|
Apr 22, 2024
| https://github.com/nodejs/node/pull/50737#ref-pullrequest-2255439753 |
|
build,tools,node-api: fix building node-api tests for Windows Debug
#52632
| https://github.com/nodejs/node/pull/52632 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Jun 6, 2024
| https://github.com/nodejs/node/pull/50737#ref-pullrequest-2339077785 |
|
build: fix generate_gn_filenames_json.py
electron/electron#42389
| https://github.com/electron/electron/pull/42389 |
| codebytere | https://github.com/codebytere |
|
Oct 16, 2024
| https://github.com/nodejs/node/pull/50737#ref-commit-5ee874b |
|
| https://github.com/codebytere |
| build,tools: make addons tests work with GN | https://github.com/electron/electron/commit/5ee874b9e59ab6892cdbfc6c854cde753912e82e |
| 5ee874b | https://github.com/electron/electron/commit/5ee874b9e59ab6892cdbfc6c854cde753912e82e |
| nodejs/node#50737 | https://github.com/nodejs/node/pull/50737 |
| codebytere | https://github.com/codebytere |
|
Oct 21, 2024
| https://github.com/nodejs/node/pull/50737#ref-commit-e4038c5 |
|
| https://github.com/codebytere |
| build,tools: make addons tests work with GN | https://github.com/electron/electron/commit/e4038c5e4923b5a16c17bb0e69496dffdc421675 |
| e4038c5 | https://github.com/electron/electron/commit/e4038c5e4923b5a16c17bb0e69496dffdc421675 |
| nodejs/node#50737 | https://github.com/nodejs/node/pull/50737 |
| codebytere | https://github.com/codebytere |
|
Oct 21, 2024
| https://github.com/nodejs/node/pull/50737#ref-commit-527b190 |
|
| https://github.com/codebytere |
| build,tools: make addons tests work with GN | https://github.com/electron/electron/commit/527b190e1f41840644168f416b570d63938a7672 |
| 527b190 | https://github.com/electron/electron/commit/527b190e1f41840644168f416b570d63938a7672 |
| nodejs/node#50737 | https://github.com/nodejs/node/pull/50737 |
| codebytere | https://github.com/codebytere |
|
Oct 22, 2024
| https://github.com/nodejs/node/pull/50737#ref-commit-2cea186 |
|
| https://github.com/codebytere |
| build,tools: make addons tests work with GN | https://github.com/electron/electron/commit/2cea1860ee5a84bf0489fd7dc2904a81c1c2ec4e |
| 2cea186 | https://github.com/electron/electron/commit/2cea1860ee5a84bf0489fd7dc2904a81c1c2ec4e |
| nodejs/node#50737 | https://github.com/nodejs/node/pull/50737 |
| codebytere | https://github.com/codebytere |
|
Oct 28, 2024
| https://github.com/nodejs/node/pull/50737#ref-commit-3785fdc |
|
| https://github.com/codebytere |
| build,tools: make addons tests work with GN | https://github.com/electron/electron/commit/3785fdc8b592448ed567ebf59bd06d46640098f7 |
| 3785fdc | https://github.com/electron/electron/commit/3785fdc8b592448ed567ebf59bd06d46640098f7 |
| nodejs/node#50737 | https://github.com/nodejs/node/pull/50737 |
| codebytere | https://github.com/codebytere |
|
Oct 29, 2024
| https://github.com/nodejs/node/pull/50737#ref-commit-4d357a8 |
|
| https://github.com/codebytere |
| build,tools: make addons tests work with GN | https://github.com/electron/electron/commit/4d357a8110377f0acf85aef3c98c8c6a6dbfd5b2 |
| 4d357a8 | https://github.com/electron/electron/commit/4d357a8110377f0acf85aef3c98c8c6a6dbfd5b2 |
| nodejs/node#50737 | https://github.com/nodejs/node/pull/50737 |
| codebytere | https://github.com/codebytere |
|
Oct 31, 2024
| https://github.com/nodejs/node/pull/50737#ref-commit-7ae4c77 |
|
| https://github.com/codebytere |
| build,tools: make addons tests work with GN | https://github.com/electron/electron/commit/7ae4c77525e84d5d77100567151862c26aedb2ac |
| 7ae4c77 | https://github.com/electron/electron/commit/7ae4c77525e84d5d77100567151862c26aedb2ac |
| nodejs/node#50737 | https://github.com/nodejs/node/pull/50737 |
| jkleinsc | https://github.com/jkleinsc |
|
Nov 4, 2024
| https://github.com/nodejs/node/pull/50737#ref-commit-c63d0d6 |
|
| https://github.com/codebytere |
| chore: bump Node.js to v22.9.0 ( | https://github.com/electron/electron/commit/c63d0d61e71f12d29efb1df885a0883ae76bb164 |
| #44281 | https://github.com/electron/electron/pull/44281 |
| ) | https://github.com/electron/electron/commit/c63d0d61e71f12d29efb1df885a0883ae76bb164 |
| c63d0d6 | https://github.com/electron/electron/commit/c63d0d61e71f12d29efb1df885a0883ae76bb164 |
| nodejs/node#52856 | https://github.com/nodejs/node/pull/52856 |
| nodejs/node#50737 | https://github.com/nodejs/node/pull/50737 |
| nodejs/node#51344 | https://github.com/nodejs/node/pull/51344 |
| nodejs/node#50322 | https://github.com/nodejs/node/pull/50322 |
| nodejs-private/node-private#525 | https://github.com/nodejs-private/node-private/pull/525 |
| nodejs/node#54320 | https://github.com/nodejs/node/pull/54320 |
| nodejs/node#50234 | https://github.com/nodejs/node/pull/50234 |
| nodejs/node#54028 | https://github.com/nodejs/node/pull/54028 |
| nodejs/node#54775 | https://github.com/nodejs/node/pull/54775 |
| nodejs/node#47182 | https://github.com/nodejs/node/pull/47182 |
| nodejs/node#50650 | https://github.com/nodejs/node/pull/50650 |
| nodejs/node#53605 | https://github.com/nodejs/node/pull/53605 |
| nodejs/node#53822 | https://github.com/nodejs/node/pull/53822 |
| nodejs/node#49152 | https://github.com/nodejs/node/pull/49152 |
| nodejs/node#53656 | https://github.com/nodejs/node/pull/53656 |
| nodejs/node#52413 | https://github.com/nodejs/node/pull/52413 |
| nodejs/node#49639 | https://github.com/nodejs/node/pull/49639 |
| nodejs/node#49639 | https://github.com/nodejs/node/pull/49639 |
| nodejs/node#49639 | https://github.com/nodejs/node/pull/49639 |
| nodejs/node#50115 | https://github.com/nodejs/node/pull/50115 |
| nodejs/node#50650 | https://github.com/nodejs/node/pull/50650 |
| nodejs/node#50115 | https://github.com/nodejs/node/pull/50115 |
| nodejs/node#51362 | https://github.com/nodejs/node/pull/51362 |
| nodejs/node#51362 | https://github.com/nodejs/node/pull/51362 |
| nodejs/node#51362 | https://github.com/nodejs/node/pull/51362 |
| nodejs/node#50115 | https://github.com/nodejs/node/pull/50115 |
| nodejs/node#52996 | https://github.com/nodejs/node/pull/52996 |
| nodejs/node#53084 | https://github.com/nodejs/node/pull/53084 |
| nodejs/node#53084 | https://github.com/nodejs/node/pull/53084 |
| nodejs/node#53174 | https://github.com/nodejs/node/pull/53174 |
| nodejs/node#52745 | https://github.com/nodejs/node/pull/52745 |
| nodejs/node#51362 | https://github.com/nodejs/node/pull/51362 |
| nodejs/node#51999 | https://github.com/nodejs/node/pull/51999 |
| nodejs/node#54375 | https://github.com/nodejs/node/pull/54375 |
| nodejs/node#52177 | https://github.com/nodejs/node/pull/52177 |
| nodejs/node#53540 | https://github.com/nodejs/node/pull/53540 |
| nodejs/node#50115 | https://github.com/nodejs/node/pull/50115 |
| nodejs/node#52870 | https://github.com/nodejs/node/pull/52870 |
| nodejs/node#54890 | https://github.com/nodejs/node/pull/54890 |
| nodejs/node#52838 | https://github.com/nodejs/node/pull/52838 |
| nodejs/node#52966 | https://github.com/nodejs/node/pull/52966 |
| nodejs/node#51783 | https://github.com/nodejs/node/pull/51783 |
| nodejs/node#47637 | https://github.com/nodejs/node/pull/47637 |
| nodejs/node#52435 | https://github.com/nodejs/node/pull/52435 |
| nodejs/node#52609 | https://github.com/nodejs/node/pull/52609 |
| nodejs/node#54077 | https://github.com/nodejs/node/pull/54077 |
| nodejs/node#48325 | https://github.com/nodejs/node/pull/48325 |
| nodejs/node#54459 | https://github.com/nodejs/node/pull/54459 |
| nodejs/node#54320 | https://github.com/nodejs/node/pull/54320 |
| https://chromium-review.googlesource.com/c/v8/v8/+/5507047 | https://chromium-review.googlesource.com/c/v8/v8/+/5507047 |
| nodejs/node#54459 | https://github.com/nodejs/node/pull/54459 |
| nodejs/node#53656 | https://github.com/nodejs/node/pull/53656 |
| nodejs/node#54553 | https://github.com/nodejs/node/pull/54553 |
| nodejs/node#48528 | https://github.com/nodejs/node/pull/48528 |
| nodejs/node#52213 | https://github.com/nodejs/node/pull/52213 |
| nodejs/node#53592 | https://github.com/nodejs/node/pull/53592 |
| nodejs/node#50322 | https://github.com/nodejs/node/pull/50322 |
| nodejs/node#55584 | https://github.com/nodejs/node/issues/55584 |
| libuv/libuv#4341 | https://github.com/libuv/libuv/pull/4341 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50737 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/50737/files/3be1111eb7d741dbaa1637b510f3318e72670ca3 |
|
| https://github.com/benjamingr |
|
benjamingr
| https://github.com/benjamingr |
|
| https://github.com/nodejs/node/pull/50737/files/5348591c867c18741fb0c85a218879cdbea250aa |
|
| https://github.com/anonrig |
|
anonrig
| https://github.com/anonrig |
|
| https://github.com/nodejs/node/pull/50737/files/3be1111eb7d741dbaa1637b510f3318e72670ca3 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
commit-queue-failed
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed |
|
commit-queue-squash
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash |
|
dependencies
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adependencies |
|
libuv
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alibuv |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
openssl
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aopenssl |
|
python
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Apython |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
|
windows
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows |
| Please reload this page | https://github.com/nodejs/node/pull/50737 |
|
| https://github.com/zcbenz |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/joyeecheung |
|
| https://github.com/batrla |
|
| https://github.com/benjamingr |
|
| https://github.com/anonrig |
|
| https://github.com/gengjiawen |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |