| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b1afa1c2-22b0-7490-21a4-356db4bb3647 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C0E6:1E0146:134157E:19CACD4:69699D0F |
| html-safe-nonce | a2721e112bed6eb72e7bc991097fe2023992e1e298a6d11d51f7ea68c5fca2aa |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMEU2OjFFMDE0NjoxMzQxNTdFOjE5Q0FDRDQ6Njk2OTlEMEYiLCJ2aXNpdG9yX2lkIjoiNzExMTQxMDU2MTg4OTk2NzM3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 01d60d9860b95a7fc7b3ccc403549ad673c45f134dca502b7fff4d385f4f461c |
| hovercard-subject-tag | pull_request:1598401953 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/50698/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/fd18b8230c6015dd7e50b425ea3bf9a20ad260b3689cd2c9a03236c715ab1432/nodejs/node/pull/50698 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fd18b8230c6015dd7e50b425ea3bf9a20ad260b3689cd2c9a03236c715ab1432/nodejs/node/pull/50698 |
| og:image:alt | Refs: #50571
In case util/splice-one.js, when only pos=end I found that the performance gap between node-21.x and node-20.x increased from -15% to 5% after I changed iterations from default 1e5 to ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Septa2112 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 24c4c97a2d520cb286b35e1a4c22d7a4df3c26a2fa28dd7cdf0e65db327b4de7 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 124667f43168afb6c9c03b7c02eb5b1d2e1be3d9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/50698#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50698 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50698 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/50698 |
| Reload | https://github.com/nodejs/node/pull/50698 |
| Reload | https://github.com/nodejs/node/pull/50698 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/50698 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/50698 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/50698#issue-comment-box |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| Septa2112:test-branch | https://github.com/Septa2112/node/tree/test-branch |
|
benchmark: update iterations in benchmark/util/splice-one.js
| https://github.com/nodejs/node/pull/50698#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| Septa2112:test-branch | https://github.com/Septa2112/node/tree/test-branch |
|
Conversation
3
| https://github.com/nodejs/node/pull/50698 |
|
Commits
1
| https://github.com/nodejs/node/pull/50698/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/50698/checks |
|
Files changed
| https://github.com/nodejs/node/pull/50698/files |
| Please reload this page | https://github.com/nodejs/node/pull/50698 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Septa2112 |
| Septa2112 | https://github.com/Septa2112 |
| Nov 13, 2023 | https://github.com/nodejs/node/pull/50698#issue-1990137537 |
| #50571 | https://github.com/nodejs/node/issues/50571 |
| Please reload this page | https://github.com/nodejs/node/pull/50698 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
benchmark
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark |
|
util
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil |
| Nov 13, 2023 | https://github.com/nodejs/node/pull/50698#event-10938548240 |
|
| https://github.com/Septa2112 |
| benchmark: update iterations in benchmark/util/splice-one.js | https://github.com/nodejs/node/pull/50698/commits/a13bb226400aa1af134b09f75bed814369d4ddd6 |
| a13bb22 | https://github.com/nodejs/node/pull/50698/commits/a13bb226400aa1af134b09f75bed814369d4ddd6 |
| nodejs#50571 | https://github.com/nodejs/node/issues/50571 |
| https://github.com/Septa2112 |
| Septa2112 | https://github.com/Septa2112 |
|
Nov 17, 2023
| https://github.com/nodejs/node/pull/50698#ref-issue-1978577906 |
|
The performance gap between node16 and node21 changes as the n of the benchmark changes
#50571
| https://github.com/nodejs/node/issues/50571 |
| https://github.com/H4ad |
| H4ad | https://github.com/H4ad |
|
Nov 17, 2023
| https://github.com/nodejs/node/pull/50698#pullrequestreview-1736756411 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/50698/files/a13bb226400aa1af134b09f75bed814369d4ddd6 |
| https://github.com/H4ad |
| H4ad | https://github.com/H4ad |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 17, 2023 | https://github.com/nodejs/node/pull/50698#event-10993349746 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 17, 2023 | https://github.com/nodejs/node/pull/50698#event-10993394133 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 17, 2023 | https://github.com/nodejs/node/pull/50698#issuecomment-1816263301 |
| https://ci.nodejs.org/job/node-test-pull-request/55701/ | https://ci.nodejs.org/job/node-test-pull-request/55701/ |
| Please reload this page | https://github.com/nodejs/node/pull/50698 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 21, 2023 | https://github.com/nodejs/node/pull/50698#issuecomment-1820820862 |
| https://ci.nodejs.org/job/node-test-pull-request/55816/ | https://ci.nodejs.org/job/node-test-pull-request/55816/ |
| Please reload this page | https://github.com/nodejs/node/pull/50698 |
| https://github.com/H4ad |
| H4ad | https://github.com/H4ad |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Nov 26, 2023 | https://github.com/nodejs/node/pull/50698#event-11062953370 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Nov 26, 2023 | https://github.com/nodejs/node/pull/50698#event-11062964860 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| f8c27e6 | https://github.com/nodejs/node/commit/f8c27e61761deffe1a20425c88d74afb830c33e4 |
| Nov 26, 2023 | https://github.com/nodejs/node/pull/50698#event-11062965047 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 26, 2023 | https://github.com/nodejs/node/pull/50698#issuecomment-1826788178 |
| f8c27e6 | https://github.com/nodejs/node/commit/f8c27e61761deffe1a20425c88d74afb830c33e4 |
| Please reload this page | https://github.com/nodejs/node/pull/50698 |
| https://github.com/H4ad |
| H4ad | https://github.com/H4ad |
|
Nov 26, 2023
| https://github.com/nodejs/node/pull/50698#ref-pullrequest-2007401491 |
|
benchmark: increase iteration number to appropriate one
#50861
| https://github.com/nodejs/node/pull/50861 |
| martenrichter | https://github.com/martenrichter |
|
Nov 26, 2023
| https://github.com/nodejs/node/pull/50698#ref-commit-66d98c2 |
|
| https://github.com/Septa2112 |
|
| https://github.com/martenrichter |
| benchmark: update iterations in benchmark/util/splice-one.js | https://github.com/martenrichter/node/commit/66d98c27c17b2926e3e48bd9e5d57c5970eabf82 |
| 66d98c2 | https://github.com/martenrichter/node/commit/66d98c27c17b2926e3e48bd9e5d57c5970eabf82 |
| nodejs#50571 | https://github.com/nodejs/node/issues/50571 |
| nodejs#50698 | https://github.com/nodejs/node/pull/50698 |
| lucshi | https://github.com/lucshi |
|
Nov 27, 2023
| https://github.com/nodejs/node/pull/50698#ref-commit-6d2e379 |
|
| https://github.com/Septa2112 |
| benchmark: update iterations in benchmark/util/splice-one.js | https://github.com/lucshi/node/commit/6d2e3790d39fe159d96061e0b406b5aaf54547b1 |
| 6d2e379 | https://github.com/lucshi/node/commit/6d2e3790d39fe159d96061e0b406b5aaf54547b1 |
| nodejs#50571 | https://github.com/nodejs/node/issues/50571 |
| nodejs#50698 | https://github.com/nodejs/node/pull/50698 |
| RafaelGSS | https://github.com/RafaelGSS |
|
Nov 27, 2023
| https://github.com/nodejs/node/pull/50698#ref-commit-8f4258d |
|
| https://github.com/Septa2112 |
|
| https://github.com/RafaelGSS |
| benchmark: update iterations in benchmark/util/splice-one.js | https://github.com/nodejs/node/commit/8f4258d0ddfaca536973f451fccc1a4507f1ce1e |
| 8f4258d | https://github.com/nodejs/node/commit/8f4258d0ddfaca536973f451fccc1a4507f1ce1e |
| #50571 | https://github.com/nodejs/node/issues/50571 |
| #50698 | https://github.com/nodejs/node/pull/50698 |
| https://github.com/lucshi |
| lucshi | https://github.com/lucshi |
|
Nov 28, 2023
| https://github.com/nodejs/node/pull/50698#ref-pullrequest-2011503870 |
|
benchmark: update iterations in benchmark/util/splice-one.js
#50935
| https://github.com/nodejs/node/pull/50935 |
| https://github.com/RafaelGSS |
| RafaelGSS | https://github.com/RafaelGSS |
|
Nov 28, 2023
| https://github.com/nodejs/node/pull/50698#ref-pullrequest-2014290477 |
|
v21.3.0 proposal
#50954
| https://github.com/nodejs/node/pull/50954 |
| RafaelGSS | https://github.com/RafaelGSS |
|
Nov 29, 2023
| https://github.com/nodejs/node/pull/50698#ref-commit-4a20912 |
|
| https://github.com/Septa2112 |
|
| https://github.com/RafaelGSS |
| benchmark: update iterations in benchmark/util/splice-one.js | https://github.com/nodejs/node/commit/4a20912279999939b5498d79ea792b73f9807d85 |
| 4a20912 | https://github.com/nodejs/node/commit/4a20912279999939b5498d79ea792b73f9807d85 |
| #50571 | https://github.com/nodejs/node/issues/50571 |
| #50698 | https://github.com/nodejs/node/pull/50698 |
| RafaelGSS | https://github.com/RafaelGSS |
|
Nov 30, 2023
| https://github.com/nodejs/node/pull/50698#ref-commit-9bdb830 |
|
| https://github.com/Septa2112 |
|
| https://github.com/RafaelGSS |
| benchmark: update iterations in benchmark/util/splice-one.js | https://github.com/nodejs/node/commit/9bdb83038acff2b226bf45e2c123a8dd2c911e9c |
| 9bdb830 | https://github.com/nodejs/node/commit/9bdb83038acff2b226bf45e2c123a8dd2c911e9c |
| #50571 | https://github.com/nodejs/node/issues/50571 |
| #50698 | https://github.com/nodejs/node/pull/50698 |
| UlisesGascon | https://github.com/UlisesGascon |
|
Dec 11, 2023
| https://github.com/nodejs/node/pull/50698#ref-commit-3648dab |
|
| https://github.com/Septa2112 |
|
| https://github.com/UlisesGascon |
| benchmark: update iterations in benchmark/util/splice-one.js | https://github.com/nodejs/node/commit/3648dab4c67dd884a6a0df5a64948c94751923cf |
| 3648dab | https://github.com/nodejs/node/commit/3648dab4c67dd884a6a0df5a64948c94751923cf |
| #50571 | https://github.com/nodejs/node/issues/50571 |
| #50698 | https://github.com/nodejs/node/pull/50698 |
| https://github.com/UlisesGascon |
| UlisesGascon | https://github.com/UlisesGascon |
|
Dec 12, 2023
| https://github.com/nodejs/node/pull/50698#ref-pullrequest-2036750657 |
|
v20.11.0 proposal
#51124
| https://github.com/nodejs/node/pull/51124 |
| UlisesGascon | https://github.com/UlisesGascon |
|
Dec 13, 2023
| https://github.com/nodejs/node/pull/50698#ref-commit-95481dc |
|
| https://github.com/Septa2112 |
|
| https://github.com/UlisesGascon |
| benchmark: update iterations in benchmark/util/splice-one.js | https://github.com/nodejs/node/commit/95481dce4ce7d5f5bac27f806a9c817751fc985b |
| 95481dc | https://github.com/nodejs/node/commit/95481dce4ce7d5f5bac27f806a9c817751fc985b |
| #50571 | https://github.com/nodejs/node/issues/50571 |
| #50698 | https://github.com/nodejs/node/pull/50698 |
| UlisesGascon | https://github.com/UlisesGascon |
|
Dec 15, 2023
| https://github.com/nodejs/node/pull/50698#ref-commit-73b188b |
|
| https://github.com/Septa2112 |
|
| https://github.com/UlisesGascon |
| benchmark: update iterations in benchmark/util/splice-one.js | https://github.com/nodejs/node/commit/73b188bf6ee947befb9a13e1339466f47b0f563a |
| 73b188b | https://github.com/nodejs/node/commit/73b188bf6ee947befb9a13e1339466f47b0f563a |
| #50571 | https://github.com/nodejs/node/issues/50571 |
| #50698 | https://github.com/nodejs/node/pull/50698 |
| UlisesGascon | https://github.com/UlisesGascon |
|
Dec 19, 2023
| https://github.com/nodejs/node/pull/50698#ref-commit-e40a559 |
|
| https://github.com/Septa2112 |
|
| https://github.com/UlisesGascon |
| benchmark: update iterations in benchmark/util/splice-one.js | https://github.com/nodejs/node/commit/e40a559ab1c3a5e5a95610fb808064c6bef386d7 |
| e40a559 | https://github.com/nodejs/node/commit/e40a559ab1c3a5e5a95610fb808064c6bef386d7 |
| #50571 | https://github.com/nodejs/node/issues/50571 |
| #50698 | https://github.com/nodejs/node/pull/50698 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50698 |
|
| https://github.com/H4ad |
|
H4ad
| https://github.com/H4ad |
|
| https://github.com/nodejs/node/pull/50698/files/a13bb226400aa1af134b09f75bed814369d4ddd6 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
benchmark
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark |
|
util
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil |
| Please reload this page | https://github.com/nodejs/node/pull/50698 |
|
| https://github.com/Septa2112 |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/H4ad |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |