René's URL Explorer Experiment


Title: src: fix JSONParser leaking internal V8 scopes by kvakil · Pull Request #50688 · nodejs/node · GitHub

Open Graph Title: src: fix JSONParser leaking internal V8 scopes by kvakil · Pull Request #50688 · nodejs/node

X Title: src: fix JSONParser leaking internal V8 scopes by kvakil · Pull Request #50688 · nodejs/node

Description: JSONParser uses V8's JSON.parse (for now), meaning that its uses handles and contexts. JSONParser was leaking its internal HandleScope and Context::Scope. Move the scope construction to the member ...

Open Graph Description: JSONParser uses V8's JSON.parse (for now), meaning that its uses handles and contexts. JSONParser was leaking its internal HandleScope and Context::Scope. Move the scope construction to the mem...

X Description: JSONParser uses V8's JSON.parse (for now), meaning that its uses handles and contexts. JSONParser was leaking its internal HandleScope and Context::Scope. Move the scope construction to the...

Opengraph URL: https://github.com/nodejs/node/pull/50688

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:aeb689f0-64a9-01a6-78fe-9876137da8c0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idABD4:18B65E:2AA5C3:399D96:6969D1DF
html-safe-nonce8c31a847d5288eb0905e4d1da7a1f3aa63d61c9498952af4791de674d296df7d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkQ0OjE4QjY1RToyQUE1QzM6Mzk5RDk2OjY5NjlEMURGIiwidmlzaXRvcl9pZCI6IjM1MTEzMjM5ODc2MzIzMzc1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac66535c8c8f1b02db0d3bbc24ae68571ab05acb92a3e5866fce48d1e025ec203d
hovercard-subject-tagpull_request:1597816371
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/50688/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cb63f67d5410d5f089cf603856a5fd1a250772c69fc4a8412747e9cd71af8503/nodejs/node/pull/50688
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cb63f67d5410d5f089cf603856a5fd1a250772c69fc4a8412747e9cd71af8503/nodejs/node/pull/50688
og:image:altJSONParser uses V8's JSON.parse (for now), meaning that its uses handles and contexts. JSONParser was leaking its internal HandleScope and Context::Scope. Move the scope construction to the mem...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekvakil
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/50688#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50688
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50688
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/50688
Reloadhttps://github.com/nodejs/node/pull/50688
Reloadhttps://github.com/nodejs/node/pull/50688
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/50688
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/50688
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/50688#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
kvakil:refactor-json-parserhttps://github.com/kvakil/node/tree/refactor-json-parser
src: fix JSONParser leaking internal V8 scopes https://github.com/nodejs/node/pull/50688#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
kvakil:refactor-json-parserhttps://github.com/kvakil/node/tree/refactor-json-parser
Conversation 7 https://github.com/nodejs/node/pull/50688
Commits 1 https://github.com/nodejs/node/pull/50688/commits
Checks 0 https://github.com/nodejs/node/pull/50688/checks
Files changed https://github.com/nodejs/node/pull/50688/files
Please reload this pagehttps://github.com/nodejs/node/pull/50688
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/kvakil
kvakilhttps://github.com/kvakil
Nov 12, 2023https://github.com/nodejs/node/pull/50688#issue-1989467295
Please reload this pagehttps://github.com/nodejs/node/pull/50688
#50680 (comment)https://github.com/nodejs/node/pull/50680#discussion_r1390363367
Please reload this pagehttps://github.com/nodejs/node/pull/50688
https://github.com/kvakil
kvakilhttps://github.com/kvakil
bnoordhuishttps://github.com/bnoordhuis
November 12, 2023 16:08https://github.com/nodejs/node/pull/50688#event-10934832833
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Nov 12, 2023https://github.com/nodejs/node/pull/50688#event-10934832871
https://github.com/legendecas
legendecashttps://github.com/legendecas
Nov 12, 2023 https://github.com/nodejs/node/pull/50688#pullrequestreview-1726292048
View reviewed changes https://github.com/nodejs/node/pull/50688/files
src/json_parser.cchttps://github.com/nodejs/node/pull/50688/files#diff-4adea6b0de9fcc11e86285927cf44fdc42c8b48862a42e6fe2abd703a3a2f0c4
Please reload this pagehttps://github.com/nodejs/node/pull/50688
https://github.com/kvakil
src: fix JSONParser leaking internal V8 scopeshttps://github.com/nodejs/node/pull/50688/commits/bc466e6be79eeca3a5d250fd0f8bf7a6fb5dbbf3
bc466e6https://github.com/nodejs/node/pull/50688/commits/bc466e6be79eeca3a5d250fd0f8bf7a6fb5dbbf3
nodejs#50680 (comment)https://github.com/nodejs/node/pull/50680#discussion_r1390363367
https://github.com/kvakil
kvakilhttps://github.com/kvakil
force-pushedhttps://github.com/nodejs/node/compare/8eabb5b5c3e45fdbbac2edcd2a11e435420be084..bc466e6be79eeca3a5d250fd0f8bf7a6fb5dbbf3
8eabb5bhttps://github.com/nodejs/node/commit/8eabb5b5c3e45fdbbac2edcd2a11e435420be084
bc466e6https://github.com/nodejs/node/commit/bc466e6be79eeca3a5d250fd0f8bf7a6fb5dbbf3
Compare https://github.com/nodejs/node/compare/8eabb5b5c3e45fdbbac2edcd2a11e435420be084..bc466e6be79eeca3a5d250fd0f8bf7a6fb5dbbf3
November 12, 2023 17:10https://github.com/nodejs/node/pull/50688#event-10934946127
https://github.com/kvakil
kvakilhttps://github.com/kvakil
legendecashttps://github.com/legendecas
November 12, 2023 17:11https://github.com/nodejs/node/pull/50688#event-10934948241
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 12, 2023 https://github.com/nodejs/node/pull/50688#pullrequestreview-1726299019
View reviewed changes https://github.com/nodejs/node/pull/50688/files/bc466e6be79eeca3a5d250fd0f8bf7a6fb5dbbf3
https://github.com/kvakil
kvakilhttps://github.com/kvakil
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 12, 2023https://github.com/nodejs/node/pull/50688#event-10935018590
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 12, 2023https://github.com/nodejs/node/pull/50688#event-10935029044
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 12, 2023https://github.com/nodejs/node/pull/50688#issuecomment-1807198592
https://ci.nodejs.org/job/node-test-pull-request/55599/https://ci.nodejs.org/job/node-test-pull-request/55599/
Please reload this pagehttps://github.com/nodejs/node/pull/50688
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 12, 2023 https://github.com/nodejs/node/pull/50688#pullrequestreview-1726357216
View reviewed changes https://github.com/nodejs/node/pull/50688/files/bc466e6be79eeca3a5d250fd0f8bf7a6fb5dbbf3
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/50688#pullrequestreview-1726357216
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/50688
https://github.com/kvakil
kvakilhttps://github.com/kvakil
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 12, 2023https://github.com/nodejs/node/pull/50688#event-10935665290
https://github.com/legendecas
legendecashttps://github.com/legendecas
Nov 13, 2023 https://github.com/nodejs/node/pull/50688#pullrequestreview-1726514643
View reviewed changes https://github.com/nodejs/node/pull/50688/files/bc466e6be79eeca3a5d250fd0f8bf7a6fb5dbbf3
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 14, 2023 https://github.com/nodejs/node/pull/50688#ref-issue-1991692085
CI Reliability 2023-11-14 nodejs/reliability#717 https://github.com/nodejs/reliability/issues/717
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 14, 2023https://github.com/nodejs/node/pull/50688#issuecomment-1809377075
https://ci.nodejs.org/job/node-test-pull-request/55627/https://ci.nodejs.org/job/node-test-pull-request/55627/
Please reload this pagehttps://github.com/nodejs/node/pull/50688
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 14, 2023https://github.com/nodejs/node/pull/50688#issuecomment-1809650273
https://ci.nodejs.org/job/node-test-pull-request/55631/https://ci.nodejs.org/job/node-test-pull-request/55631/
Please reload this pagehttps://github.com/nodejs/node/pull/50688
https://github.com/kvakil
kvakilhttps://github.com/kvakil
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Nov 14, 2023https://github.com/nodejs/node/pull/50688#event-10956819592
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Nov 14, 2023https://github.com/nodejs/node/pull/50688#event-10956863946
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
09f4aa9https://github.com/nodejs/node/commit/09f4aa948918bb43a45a29d89515f568336b4531
Nov 14, 2023https://github.com/nodejs/node/pull/50688#event-10956864999
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 14, 2023https://github.com/nodejs/node/pull/50688#issuecomment-1810597449
09f4aa9https://github.com/nodejs/node/commit/09f4aa948918bb43a45a29d89515f568336b4531
Please reload this pagehttps://github.com/nodejs/node/pull/50688
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 15, 2023 https://github.com/nodejs/node/pull/50688#ref-issue-1993795584
CI Reliability 2023-11-15 nodejs/reliability#718 https://github.com/nodejs/reliability/issues/718
targoshttps://github.com/targos
Nov 23, 2023 https://github.com/nodejs/node/pull/50688#ref-commit-2e8e237
https://github.com/kvakil
https://github.com/targos
src: fix JSONParser leaking internal V8 scopeshttps://github.com/nodejs/node/commit/2e8e237ce21f05519b3a964ccb24a8382ccc2f02
2e8e237https://github.com/nodejs/node/commit/2e8e237ce21f05519b3a964ccb24a8382ccc2f02
#50680 (comment)https://github.com/nodejs/node/pull/50680#discussion_r1390363367
#50688https://github.com/nodejs/node/pull/50688
martenrichterhttps://github.com/martenrichter
Nov 26, 2023 https://github.com/nodejs/node/pull/50688#ref-commit-e9c6d17
https://github.com/kvakil
https://github.com/martenrichter
src: fix JSONParser leaking internal V8 scopeshttps://github.com/martenrichter/node/commit/e9c6d1791453addb95eba33ef4b48fb412a816fd
e9c6d17https://github.com/martenrichter/node/commit/e9c6d1791453addb95eba33ef4b48fb412a816fd
nodejs#50680 (comment)https://github.com/nodejs/node/pull/50680#discussion_r1390363367
nodejs#50688https://github.com/nodejs/node/pull/50688
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Nov 28, 2023 https://github.com/nodejs/node/pull/50688#ref-pullrequest-2014290477
v21.3.0 proposal #50954 https://github.com/nodejs/node/pull/50954
UlisesGasconhttps://github.com/UlisesGascon
Dec 11, 2023 https://github.com/nodejs/node/pull/50688#ref-commit-19c8da5
https://github.com/kvakil
https://github.com/UlisesGascon
src: fix JSONParser leaking internal V8 scopeshttps://github.com/nodejs/node/commit/19c8da595f64320f50bb4aa798a6f6cd1d2de8d0
19c8da5https://github.com/nodejs/node/commit/19c8da595f64320f50bb4aa798a6f6cd1d2de8d0
#50680 (comment)https://github.com/nodejs/node/pull/50680#discussion_r1390363367
#50688https://github.com/nodejs/node/pull/50688
https://github.com/UlisesGascon
UlisesGasconhttps://github.com/UlisesGascon
Dec 12, 2023 https://github.com/nodejs/node/pull/50688#ref-pullrequest-2036750657
v20.11.0 proposal #51124 https://github.com/nodejs/node/pull/51124
UlisesGasconhttps://github.com/UlisesGascon
Dec 19, 2023 https://github.com/nodejs/node/pull/50688#ref-commit-436c3ae
https://github.com/kvakil
https://github.com/UlisesGascon
src: fix JSONParser leaking internal V8 scopeshttps://github.com/nodejs/node/commit/436c3aef15c821d18790f862ab120fe7b8f99edc
436c3aehttps://github.com/nodejs/node/commit/436c3aef15c821d18790f862ab120fe7b8f99edc
#50680 (comment)https://github.com/nodejs/node/pull/50680#discussion_r1390363367
#50688https://github.com/nodejs/node/pull/50688
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50688
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/50688/files/bc466e6be79eeca3a5d250fd0f8bf7a6fb5dbbf3
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/50688/files/bc466e6be79eeca3a5d250fd0f8bf7a6fb5dbbf3
https://github.com/legendecas
legendecas https://github.com/legendecas
https://github.com/nodejs/node/pull/50688/files/bc466e6be79eeca3a5d250fd0f8bf7a6fb5dbbf3
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/50688
https://github.com/kvakil
https://github.com/nodejs-github-bot
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/legendecas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.