René's URL Explorer Experiment


Title: src: fix pointer compression build by kvakil · Pull Request #50680 · nodejs/node · GitHub

Open Graph Title: src: fix pointer compression build by kvakil · Pull Request #50680 · nodejs/node

X Title: src: fix pointer compression build by kvakil · Pull Request #50680 · nodejs/node

Description: These two commits combined fix the pointer compression build. The build was broken starting in Node v21.0.0 due to upgrading past a regression first introduced in V8 11.4. See the refs for more inf...

Open Graph Description: These two commits combined fix the pointer compression build. The build was broken starting in Node v21.0.0 due to upgrading past a regression first introduced in V8 11.4. See the refs for more inf...

X Description: These two commits combined fix the pointer compression build. The build was broken starting in Node v21.0.0 due to upgrading past a regression first introduced in V8 11.4. See the refs for more inf...

Opengraph URL: https://github.com/nodejs/node/pull/50680

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fd556252-bd10-1e86-a57d-3b4630bad5b8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB056:2B9199:19AB2DD:227DB7C:6969B2DE
html-safe-nonce4b65b2ebe967159b114cd405375912c37100c069b17db1b5118de1155f9791de
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDU2OjJCOTE5OToxOUFCMkREOjIyN0RCN0M6Njk2OUIyREUiLCJ2aXNpdG9yX2lkIjoiMjk4MTM0MDE2ODYyMzYwMDM1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdb5c6151fbe299c3e8bddb6521439c86cbdfd8bfbdde7649cb486594a912ea73
hovercard-subject-tagpull_request:1597600735
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/50680/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b455b1114a151f9c0feac92da20e550231bc04aa643fb4009c12aa98a7a5f780/nodejs/node/pull/50680
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b455b1114a151f9c0feac92da20e550231bc04aa643fb4009c12aa98a7a5f780/nodejs/node/pull/50680
og:image:altThese two commits combined fix the pointer compression build. The build was broken starting in Node v21.0.0 due to upgrading past a regression first introduced in V8 11.4. See the refs for more inf...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekvakil
hostnamegithub.com
expected-hostnamegithub.com
Noneb23b8fcc855cd29bb04d6c94aafa62d336bf44eefa8229444eecc968cad03aee
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release0672399d88424758731ec07fe24509e23bb17fb5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/50680#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50680
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50680
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/50680
Reloadhttps://github.com/nodejs/node/pull/50680
Reloadhttps://github.com/nodejs/node/pull/50680
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/50680
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/50680
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/50680#issue-comment-box
kvakilhttps://github.com/kvakil
nodejs:mainhttps://github.com/nodejs/node/tree/main
kvakil:fix-ptrcomp-buildhttps://github.com/kvakil/node/tree/fix-ptrcomp-build
src: fix pointer compression build https://github.com/nodejs/node/pull/50680#top
kvakilhttps://github.com/kvakil
nodejs:mainhttps://github.com/nodejs/node/tree/main
kvakil:fix-ptrcomp-buildhttps://github.com/kvakil/node/tree/fix-ptrcomp-build
Conversation 26 https://github.com/nodejs/node/pull/50680
Commits 2 https://github.com/nodejs/node/pull/50680/commits
Checks 0 https://github.com/nodejs/node/pull/50680/checks
Files changed https://github.com/nodejs/node/pull/50680/files
Please reload this pagehttps://github.com/nodejs/node/pull/50680
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/kvakil
kvakilhttps://github.com/kvakil
Nov 12, 2023https://github.com/nodejs/node/pull/50680#issue-1989204414
v8/v8@475c8cdhttps://github.com/v8/v8/commit/475c8cdf9a951bb06da3084794a0f659f8ef36c2
nodejs/build#3204 (comment)https://github.com/nodejs/build/issues/3204#issuecomment-1790213488
https://bugs.chromium.org/p/v8/issues/detail?id=14292https://bugs.chromium.org/p/v8/issues/detail?id=14292
Please reload this pagehttps://github.com/nodejs/node/pull/50680
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 12, 2023https://github.com/nodejs/node/pull/50680#issuecomment-1806978566
Please reload this pagehttps://github.com/nodejs/node/pull/50680
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Nov 12, 2023https://github.com/nodejs/node/pull/50680#event-10933560254
https://github.com/kvakil
kvakilhttps://github.com/kvakil
Nov 12, 2023 https://github.com/nodejs/node/pull/50680#ref-issue-1595441830
Path to adding a Tier 2 build with pointer compression enabled nodejs/build#3204 https://github.com/nodejs/build/issues/3204
https://github.com/kvakil
kvakilhttps://github.com/kvakil
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 12, 2023https://github.com/nodejs/node/pull/50680#event-10933562232
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 12, 2023https://github.com/nodejs/node/pull/50680#event-10933572035
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 12, 2023https://github.com/nodejs/node/pull/50680#issuecomment-1806980327
https://ci.nodejs.org/job/node-test-pull-request/55584/https://ci.nodejs.org/job/node-test-pull-request/55584/
Please reload this pagehttps://github.com/nodejs/node/pull/50680
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Nov 12, 2023 https://github.com/nodejs/node/pull/50680#pullrequestreview-1726181483
View reviewed changes https://github.com/nodejs/node/pull/50680/files
src/node_sea.cchttps://github.com/nodejs/node/pull/50680/files#diff-5afaf7eae42f44a543b411784037654c21ba0dc69870c7a5351bc219f0bfce64
Please reload this pagehttps://github.com/nodejs/node/pull/50680
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 12, 2023 https://github.com/nodejs/node/pull/50680#pullrequestreview-1726202819
View reviewed changes https://github.com/nodejs/node/pull/50680/files
src/json_parser.hhttps://github.com/nodejs/node/pull/50680/files#diff-0b96fbe71d5ae4aa3a30eb6c6ef541a7b7991be713dbee14bb8108e0f9123c64
Please reload this pagehttps://github.com/nodejs/node/pull/50680
https://github.com/kvakil
kvakilhttps://github.com/kvakil
Nov 12, 2023 https://github.com/nodejs/node/pull/50680#pullrequestreview-1726276668
View reviewed changes https://github.com/nodejs/node/pull/50680/files
kvakilhttps://github.com/kvakil
https://github.com/nodejs/node/pull/50680#pullrequestreview-1726276668
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@RaisinTenhttps://github.com/RaisinTen
@bnoordhuishttps://github.com/bnoordhuis
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/50680
src/json_parser.hhttps://github.com/nodejs/node/pull/50680/files#diff-0b96fbe71d5ae4aa3a30eb6c6ef541a7b7991be713dbee14bb8108e0f9123c64
Please reload this pagehttps://github.com/nodejs/node/pull/50680
src/node_sea.cchttps://github.com/nodejs/node/pull/50680/files#diff-5afaf7eae42f44a543b411784037654c21ba0dc69870c7a5351bc219f0bfce64
Please reload this pagehttps://github.com/nodejs/node/pull/50680
https://github.com/kvakil
kvakilhttps://github.com/kvakil
RaisinTenhttps://github.com/RaisinTen
bnoordhuishttps://github.com/bnoordhuis
November 12, 2023 15:12https://github.com/nodejs/node/pull/50680#event-10934726809
kvakilhttps://github.com/kvakil
Nov 12, 2023 https://github.com/nodejs/node/pull/50680#ref-commit-8eabb5b
https://github.com/kvakil
src: fix JSONParser leaking internal V8 scopeshttps://github.com/kvakil/node/commit/8eabb5b5c3e45fdbbac2edcd2a11e435420be084
8eabb5bhttps://github.com/kvakil/node/commit/8eabb5b5c3e45fdbbac2edcd2a11e435420be084
nodejs#50680 (comment)https://github.com/nodejs/node/pull/50680#discussion_r1390363367
https://github.com/kvakil
kvakilhttps://github.com/kvakil
Nov 12, 2023 https://github.com/nodejs/node/pull/50680#ref-pullrequest-1989467295
src: fix JSONParser leaking internal V8 scopes #50688 https://github.com/nodejs/node/pull/50688
kvakilhttps://github.com/kvakil
Nov 12, 2023 https://github.com/nodejs/node/pull/50680#ref-commit-bc466e6
https://github.com/kvakil
src: fix JSONParser leaking internal V8 scopeshttps://github.com/kvakil/node/commit/bc466e6be79eeca3a5d250fd0f8bf7a6fb5dbbf3
bc466e6https://github.com/kvakil/node/commit/bc466e6be79eeca3a5d250fd0f8bf7a6fb5dbbf3
nodejs#50680 (comment)https://github.com/nodejs/node/pull/50680#discussion_r1390363367
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 12, 2023 https://github.com/nodejs/node/pull/50680#pullrequestreview-1726356800
View reviewed changes https://github.com/nodejs/node/pull/50680/files
src/json_parser.hhttps://github.com/nodejs/node/pull/50680/files#diff-0b96fbe71d5ae4aa3a30eb6c6ef541a7b7991be713dbee14bb8108e0f9123c64
Please reload this pagehttps://github.com/nodejs/node/pull/50680
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 12, 2023https://github.com/nodejs/node/pull/50680#issuecomment-1807269644
Please reload this pagehttps://github.com/nodejs/node/pull/50680
CI Reliability 2023-11-13 nodejs/reliability#716 https://github.com/nodejs/reliability/issues/716
CI Reliability 2023-11-14 nodejs/reliability#717 https://github.com/nodejs/reliability/issues/717
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Nov 14, 2023 https://github.com/nodejs/node/pull/50680#pullrequestreview-1729108303
View reviewed changes https://github.com/nodejs/node/pull/50680/files
RaisinTenhttps://github.com/RaisinTen
https://github.com/nodejs/node/pull/50680#pullrequestreview-1729108303
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/50680
src/node_sea.cchttps://github.com/nodejs/node/pull/50680/files#diff-5afaf7eae42f44a543b411784037654c21ba0dc69870c7a5351bc219f0bfce64
Please reload this pagehttps://github.com/nodejs/node/pull/50680
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 14, 2023 https://github.com/nodejs/node/pull/50680#ref-commit-09f4aa9
https://github.com/kvakil
src: fix JSONParser leaking internal V8 scopeshttps://github.com/nodejs/node/commit/09f4aa948918bb43a45a29d89515f568336b4531
09f4aa9https://github.com/nodejs/node/commit/09f4aa948918bb43a45a29d89515f568336b4531
#50680 (comment)https://github.com/nodejs/node/pull/50680#discussion_r1390363367
#50688https://github.com/nodejs/node/pull/50688
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 15, 2023 https://github.com/nodejs/node/pull/50680#ref-issue-1993795584
CI Reliability 2023-11-15 nodejs/reliability#718 https://github.com/nodejs/reliability/issues/718
https://github.com/kvakil
deps: V8: cherry-pick 475c8cdf9a95https://github.com/nodejs/node/pull/50680/commits/79231033f52807cfc3760c66c7e07abbf4387cc3
7923103https://github.com/nodejs/node/pull/50680/commits/79231033f52807cfc3760c66c7e07abbf4387cc3
https://chromium-review.googlesource.com/c/v8/v8/+/4846592https://chromium-review.googlesource.com/c/v8/v8/+/4846592
v8/v8@475c8cdhttps://github.com/v8/v8/commit/475c8cdf9a951bb06da3084794a0f659f8ef36c2
https://github.com/kvakil
kvakilhttps://github.com/kvakil
force-pushedhttps://github.com/nodejs/node/compare/9dc6d7cfccc466659d96eb9e1aa9fd07f37aa9e8..c815b7f5fdd86210ecc09f147b203b3a24aaa1c4
9dc6d7chttps://github.com/nodejs/node/commit/9dc6d7cfccc466659d96eb9e1aa9fd07f37aa9e8
c815b7fhttps://github.com/nodejs/node/commit/c815b7f5fdd86210ecc09f147b203b3a24aaa1c4
Compare https://github.com/nodejs/node/compare/9dc6d7cfccc466659d96eb9e1aa9fd07f37aa9e8..c815b7f5fdd86210ecc09f147b203b3a24aaa1c4
November 16, 2023 02:48https://github.com/nodejs/node/pull/50680#event-10974776905
https://github.com/kvakil
src: add IsolateScopes before using isolateshttps://github.com/nodejs/node/pull/50680/commits/b2b9acb6f9770e88bc0ec3865e5a95cd08b25842
b2b9acbhttps://github.com/nodejs/node/pull/50680/commits/b2b9acb6f9770e88bc0ec3865e5a95cd08b25842
nodejs/build#3204 (comment)https://github.com/nodejs/build/issues/3204#issuecomment-1790213488
https://bugs.chromium.org/p/v8/issues/detail?id=14292https://bugs.chromium.org/p/v8/issues/detail?id=14292
https://github.com/kvakil
kvakilhttps://github.com/kvakil
force-pushedhttps://github.com/nodejs/node/compare/c815b7f5fdd86210ecc09f147b203b3a24aaa1c4..b2b9acb6f9770e88bc0ec3865e5a95cd08b25842
c815b7fhttps://github.com/nodejs/node/commit/c815b7f5fdd86210ecc09f147b203b3a24aaa1c4
b2b9acbhttps://github.com/nodejs/node/commit/b2b9acb6f9770e88bc0ec3865e5a95cd08b25842
Compare https://github.com/nodejs/node/compare/c815b7f5fdd86210ecc09f147b203b3a24aaa1c4..b2b9acb6f9770e88bc0ec3865e5a95cd08b25842
November 16, 2023 02:49https://github.com/nodejs/node/pull/50680#event-10974785700
https://github.com/kvakil
kvakilhttps://github.com/kvakil
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 16, 2023https://github.com/nodejs/node/pull/50680#event-10976493836
https://github.com/kvakil
kvakilhttps://github.com/kvakil
RaisinTenhttps://github.com/RaisinTen
bnoordhuishttps://github.com/bnoordhuis
November 16, 2023 06:56https://github.com/nodejs/node/pull/50680#event-10976494704
https://github.com/kvakil
kvakilhttps://github.com/kvakil
Nov 16, 2023 https://github.com/nodejs/node/pull/50680#pullrequestreview-1733411291
View reviewed changes https://github.com/nodejs/node/pull/50680/files/b2b9acb6f9770e88bc0ec3865e5a95cd08b25842
kvakilhttps://github.com/kvakil
https://github.com/nodejs/node/pull/50680#pullrequestreview-1733411291
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@bnoordhuishttps://github.com/bnoordhuis
@RaisinTenhttps://github.com/RaisinTen
Please reload this pagehttps://github.com/nodejs/node/pull/50680
src/node_sea.cchttps://github.com/nodejs/node/pull/50680/files#diff-5afaf7eae42f44a543b411784037654c21ba0dc69870c7a5351bc219f0bfce64
Please reload this pagehttps://github.com/nodejs/node/pull/50680
src/util.cchttps://github.com/nodejs/node/pull/50680/files/79231033f52807cfc3760c66c7e07abbf4387cc3..b2b9acb6f9770e88bc0ec3865e5a95cd08b25842#diff-26743ee03d8e643c058f9cfa835705beadaa579c3b6220cb728940b11ab6e56f
kvakilhttps://github.com/kvakil
Nov 16, 2023https://github.com/nodejs/node/pull/50680#discussion_r1395094344
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/50680
joyeecheunghttps://github.com/joyeecheung
Nov 18, 2023https://github.com/nodejs/node/pull/50680#discussion_r1398021726
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/50680
joyeecheunghttps://github.com/joyeecheung
Nov 18, 2023https://github.com/nodejs/node/pull/50680#discussion_r1398022818
Please reload this pagehttps://github.com/nodejs/node/pull/50680
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/50680
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Nov 18, 2023 https://github.com/nodejs/node/pull/50680#pullrequestreview-1738147472
View reviewed changes https://github.com/nodejs/node/pull/50680/files/b2b9acb6f9770e88bc0ec3865e5a95cd08b25842
joyeecheunghttps://github.com/joyeecheung
https://github.com/nodejs/node/pull/50680#pullrequestreview-1738147472
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/50680
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Nov 18, 2023 https://github.com/nodejs/node/pull/50680#pullrequestreview-1738229890
View reviewed changes https://github.com/nodejs/node/pull/50680/files/b2b9acb6f9770e88bc0ec3865e5a95cd08b25842
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 19, 2023 https://github.com/nodejs/node/pull/50680#pullrequestreview-1738723546
View reviewed changes https://github.com/nodejs/node/pull/50680/files/b2b9acb6f9770e88bc0ec3865e5a95cd08b25842
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 20, 2023https://github.com/nodejs/node/pull/50680#issuecomment-1818191774
https://ci.nodejs.org/job/node-test-pull-request/55776/https://ci.nodejs.org/job/node-test-pull-request/55776/
Please reload this pagehttps://github.com/nodejs/node/pull/50680
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 20, 2023https://github.com/nodejs/node/pull/50680#issuecomment-1818274715
https://ci.nodejs.org/job/node-test-pull-request/55777/https://ci.nodejs.org/job/node-test-pull-request/55777/
Please reload this pagehttps://github.com/nodejs/node/pull/50680
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 20, 2023https://github.com/nodejs/node/pull/50680#issuecomment-1819312843
https://ci.nodejs.org/job/node-test-pull-request/55786/https://ci.nodejs.org/job/node-test-pull-request/55786/
Please reload this pagehttps://github.com/nodejs/node/pull/50680
kvakilhttps://github.com/kvakil
Nov 20, 2023 https://github.com/nodejs/node/pull/50680#ref-commit-ec023a7
https://github.com/kvakil
deps: V8: cherry-pick 475c8cdf9a95https://github.com/nodejs/node/commit/ec023a7a793f2e2e457e811e4c6ab9e81d5feeb0
ec023a7https://github.com/nodejs/node/commit/ec023a7a793f2e2e457e811e4c6ab9e81d5feeb0
v8:13788https://bugs.chromium.org/p/v8/issues/detail?id=13788
v8:14292https://bugs.chromium.org/p/v8/issues/detail?id=14292
https://chromium-review.googlesource.com/c/v8/v8/+/4846592https://chromium-review.googlesource.com/c/v8/v8/+/4846592
v8/v8@475c8cdhttps://github.com/v8/v8/commit/475c8cdf9a951bb06da3084794a0f659f8ef36c2
#50680https://github.com/nodejs/node/pull/50680
https://bugs.chromium.org/p/v8/issues/detail?id=14292https://bugs.chromium.org/p/v8/issues/detail?id=14292
kvakilhttps://github.com/kvakil
Nov 20, 2023 https://github.com/nodejs/node/pull/50680#ref-commit-8e60189
https://github.com/kvakil
src: add IsolateScopes before using isolateshttps://github.com/nodejs/node/commit/8e60189585dce0327eca38aef8e72ed5d58e7b6f
8e60189https://github.com/nodejs/node/commit/8e60189585dce0327eca38aef8e72ed5d58e7b6f
nodejs/build#3204 (comment)https://github.com/nodejs/build/issues/3204#issuecomment-1790213488
https://bugs.chromium.org/p/v8/issues/detail?id=14292https://bugs.chromium.org/p/v8/issues/detail?id=14292
#50680https://github.com/nodejs/node/pull/50680
v8/v8@475c8cdhttps://github.com/v8/v8/commit/475c8cdf9a951bb06da3084794a0f659f8ef36c2
https://github.com/kvakil
kvakilhttps://github.com/kvakil
Nov 20, 2023https://github.com/nodejs/node/pull/50680#issuecomment-1819954561
ec023a7...8e60189https://github.com/nodejs/node/compare/ec023a7a793f2e2e457e811e4c6ab9e81d5feeb0...8e60189585dce0327eca38aef8e72ed5d58e7b6f
Please reload this pagehttps://github.com/nodejs/node/pull/50680
https://github.com/kvakil
kvakilhttps://github.com/kvakil
Nov 20, 2023https://github.com/nodejs/node/pull/50680#event-11017639925
targoshttps://github.com/targos
Nov 23, 2023 https://github.com/nodejs/node/pull/50680#ref-commit-2e8e237
https://github.com/kvakil
https://github.com/targos
src: fix JSONParser leaking internal V8 scopeshttps://github.com/nodejs/node/commit/2e8e237ce21f05519b3a964ccb24a8382ccc2f02
2e8e237https://github.com/nodejs/node/commit/2e8e237ce21f05519b3a964ccb24a8382ccc2f02
#50680 (comment)https://github.com/nodejs/node/pull/50680#discussion_r1390363367
#50688https://github.com/nodejs/node/pull/50688
targoshttps://github.com/targos
Nov 23, 2023 https://github.com/nodejs/node/pull/50680#ref-commit-6caf72c
https://github.com/kvakil
https://github.com/targos
deps: V8: cherry-pick 475c8cdf9a95https://github.com/nodejs/node/commit/6caf72c7b2cfa83b2a6724c66eb44651f06ec676
6caf72chttps://github.com/nodejs/node/commit/6caf72c7b2cfa83b2a6724c66eb44651f06ec676
v8:13788https://bugs.chromium.org/p/v8/issues/detail?id=13788
v8:14292https://bugs.chromium.org/p/v8/issues/detail?id=14292
https://chromium-review.googlesource.com/c/v8/v8/+/4846592https://chromium-review.googlesource.com/c/v8/v8/+/4846592
v8/v8@475c8cdhttps://github.com/v8/v8/commit/475c8cdf9a951bb06da3084794a0f659f8ef36c2
#50680https://github.com/nodejs/node/pull/50680
https://bugs.chromium.org/p/v8/issues/detail?id=14292https://bugs.chromium.org/p/v8/issues/detail?id=14292
targoshttps://github.com/targos
Nov 23, 2023 https://github.com/nodejs/node/pull/50680#ref-commit-d4bfa39
https://github.com/kvakil
https://github.com/targos
src: add IsolateScopes before using isolateshttps://github.com/nodejs/node/commit/d4bfa39a29db46acdc5bc49ff01ad75a026ce921
d4bfa39https://github.com/nodejs/node/commit/d4bfa39a29db46acdc5bc49ff01ad75a026ce921
nodejs/build#3204 (comment)https://github.com/nodejs/build/issues/3204#issuecomment-1790213488
https://bugs.chromium.org/p/v8/issues/detail?id=14292https://bugs.chromium.org/p/v8/issues/detail?id=14292
#50680https://github.com/nodejs/node/pull/50680
v8/v8@475c8cdhttps://github.com/v8/v8/commit/475c8cdf9a951bb06da3084794a0f659f8ef36c2
martenrichterhttps://github.com/martenrichter
Nov 26, 2023 https://github.com/nodejs/node/pull/50680#ref-commit-e9c6d17
https://github.com/kvakil
https://github.com/martenrichter
src: fix JSONParser leaking internal V8 scopeshttps://github.com/martenrichter/node/commit/e9c6d1791453addb95eba33ef4b48fb412a816fd
e9c6d17https://github.com/martenrichter/node/commit/e9c6d1791453addb95eba33ef4b48fb412a816fd
nodejs#50680 (comment)https://github.com/nodejs/node/pull/50680#discussion_r1390363367
nodejs#50688https://github.com/nodejs/node/pull/50688
martenrichterhttps://github.com/martenrichter
Nov 26, 2023 https://github.com/nodejs/node/pull/50680#ref-commit-9770ddb
https://github.com/kvakil
https://github.com/martenrichter
deps: V8: cherry-pick 475c8cdf9a95https://github.com/martenrichter/node/commit/9770ddbe594227cdd12d8679324cc793e504557c
9770ddbhttps://github.com/martenrichter/node/commit/9770ddbe594227cdd12d8679324cc793e504557c
https://chromium-review.googlesource.com/c/v8/v8/+/4846592https://chromium-review.googlesource.com/c/v8/v8/+/4846592
v8/v8@475c8cdhttps://github.com/v8/v8/commit/475c8cdf9a951bb06da3084794a0f659f8ef36c2
nodejs#50680https://github.com/nodejs/node/pull/50680
https://bugs.chromium.org/p/v8/issues/detail?id=14292https://bugs.chromium.org/p/v8/issues/detail?id=14292
martenrichterhttps://github.com/martenrichter
Nov 26, 2023 https://github.com/nodejs/node/pull/50680#ref-commit-7a9d2c8
https://github.com/kvakil
https://github.com/martenrichter
src: add IsolateScopes before using isolateshttps://github.com/martenrichter/node/commit/7a9d2c8e167c90f4b2583e92d51d7aee33394935
7a9d2c8https://github.com/martenrichter/node/commit/7a9d2c8e167c90f4b2583e92d51d7aee33394935
nodejs/build#3204 (comment)https://github.com/nodejs/build/issues/3204#issuecomment-1790213488
https://bugs.chromium.org/p/v8/issues/detail?id=14292https://bugs.chromium.org/p/v8/issues/detail?id=14292
nodejs#50680https://github.com/nodejs/node/pull/50680
v8/v8@475c8cdhttps://github.com/v8/v8/commit/475c8cdf9a951bb06da3084794a0f659f8ef36c2
lucshihttps://github.com/lucshi
Nov 27, 2023 https://github.com/nodejs/node/pull/50680#ref-commit-e91566f
https://github.com/kvakil
deps: V8: cherry-pick 475c8cdf9a95https://github.com/lucshi/node/commit/e91566f19fbe6298fc03cece66f43591e0bc1e9b
e91566fhttps://github.com/lucshi/node/commit/e91566f19fbe6298fc03cece66f43591e0bc1e9b
https://chromium-review.googlesource.com/c/v8/v8/+/4846592https://chromium-review.googlesource.com/c/v8/v8/+/4846592
v8/v8@475c8cdhttps://github.com/v8/v8/commit/475c8cdf9a951bb06da3084794a0f659f8ef36c2
nodejs#50680https://github.com/nodejs/node/pull/50680
https://bugs.chromium.org/p/v8/issues/detail?id=14292https://bugs.chromium.org/p/v8/issues/detail?id=14292
lucshihttps://github.com/lucshi
Nov 27, 2023 https://github.com/nodejs/node/pull/50680#ref-commit-f4da4ab
https://github.com/kvakil
src: add IsolateScopes before using isolateshttps://github.com/lucshi/node/commit/f4da4ab4cc956610d0dc9c21da619cbeef79ae95
f4da4abhttps://github.com/lucshi/node/commit/f4da4ab4cc956610d0dc9c21da619cbeef79ae95
nodejs/build#3204 (comment)https://github.com/nodejs/build/issues/3204#issuecomment-1790213488
https://bugs.chromium.org/p/v8/issues/detail?id=14292https://bugs.chromium.org/p/v8/issues/detail?id=14292
nodejs#50680https://github.com/nodejs/node/pull/50680
v8/v8@475c8cdhttps://github.com/v8/v8/commit/475c8cdf9a951bb06da3084794a0f659f8ef36c2
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Nov 28, 2023 https://github.com/nodejs/node/pull/50680#ref-pullrequest-2014290477
v21.3.0 proposal #50954 https://github.com/nodejs/node/pull/50954
RafaelGSShttps://github.com/RafaelGSS
Nov 29, 2023 https://github.com/nodejs/node/pull/50680#ref-commit-00dab30
https://github.com/kvakil
https://github.com/RafaelGSS
deps: V8: cherry-pick 475c8cdf9a95https://github.com/nodejs/node/commit/00dab30fd2a834c2900b7a36e4d5e81e48cbd185
00dab30https://github.com/nodejs/node/commit/00dab30fd2a834c2900b7a36e4d5e81e48cbd185
v8:13788https://bugs.chromium.org/p/v8/issues/detail?id=13788
v8:14292https://bugs.chromium.org/p/v8/issues/detail?id=14292
https://chromium-review.googlesource.com/c/v8/v8/+/4846592https://chromium-review.googlesource.com/c/v8/v8/+/4846592
v8/v8@475c8cdhttps://github.com/v8/v8/commit/475c8cdf9a951bb06da3084794a0f659f8ef36c2
#50680https://github.com/nodejs/node/pull/50680
https://bugs.chromium.org/p/v8/issues/detail?id=14292https://bugs.chromium.org/p/v8/issues/detail?id=14292
RafaelGSShttps://github.com/RafaelGSS
Nov 29, 2023 https://github.com/nodejs/node/pull/50680#ref-commit-faf6a04
https://github.com/kvakil
https://github.com/RafaelGSS
src: add IsolateScopes before using isolateshttps://github.com/nodejs/node/commit/faf6a04ba62bf057eb2c381f8079e8d68e73a378
faf6a04https://github.com/nodejs/node/commit/faf6a04ba62bf057eb2c381f8079e8d68e73a378
nodejs/build#3204 (comment)https://github.com/nodejs/build/issues/3204#issuecomment-1790213488
https://bugs.chromium.org/p/v8/issues/detail?id=14292https://bugs.chromium.org/p/v8/issues/detail?id=14292
#50680https://github.com/nodejs/node/pull/50680
v8/v8@475c8cdhttps://github.com/v8/v8/commit/475c8cdf9a951bb06da3084794a0f659f8ef36c2
RafaelGSShttps://github.com/RafaelGSS
Nov 30, 2023 https://github.com/nodejs/node/pull/50680#ref-commit-9aee38f
https://github.com/kvakil
https://github.com/RafaelGSS
deps: V8: cherry-pick 475c8cdf9a95https://github.com/nodejs/node/commit/9aee38f38ed8c4109d58d81d73639bf4ebf34ba6
9aee38fhttps://github.com/nodejs/node/commit/9aee38f38ed8c4109d58d81d73639bf4ebf34ba6
v8:13788https://bugs.chromium.org/p/v8/issues/detail?id=13788
v8:14292https://bugs.chromium.org/p/v8/issues/detail?id=14292
https://chromium-review.googlesource.com/c/v8/v8/+/4846592https://chromium-review.googlesource.com/c/v8/v8/+/4846592
v8/v8@475c8cdhttps://github.com/v8/v8/commit/475c8cdf9a951bb06da3084794a0f659f8ef36c2
#50680https://github.com/nodejs/node/pull/50680
https://bugs.chromium.org/p/v8/issues/detail?id=14292https://bugs.chromium.org/p/v8/issues/detail?id=14292
RafaelGSShttps://github.com/RafaelGSS
Nov 30, 2023 https://github.com/nodejs/node/pull/50680#ref-commit-080f23e
https://github.com/kvakil
https://github.com/RafaelGSS
src: add IsolateScopes before using isolateshttps://github.com/nodejs/node/commit/080f23eaac63d4991a1506faa7dd8c697db2ce1c
080f23ehttps://github.com/nodejs/node/commit/080f23eaac63d4991a1506faa7dd8c697db2ce1c
nodejs/build#3204 (comment)https://github.com/nodejs/build/issues/3204#issuecomment-1790213488
https://bugs.chromium.org/p/v8/issues/detail?id=14292https://bugs.chromium.org/p/v8/issues/detail?id=14292
#50680https://github.com/nodejs/node/pull/50680
v8/v8@475c8cdhttps://github.com/v8/v8/commit/475c8cdf9a951bb06da3084794a0f659f8ef36c2
UlisesGasconhttps://github.com/UlisesGascon
Dec 11, 2023 https://github.com/nodejs/node/pull/50680#ref-commit-19c8da5
https://github.com/kvakil
https://github.com/UlisesGascon
src: fix JSONParser leaking internal V8 scopeshttps://github.com/nodejs/node/commit/19c8da595f64320f50bb4aa798a6f6cd1d2de8d0
19c8da5https://github.com/nodejs/node/commit/19c8da595f64320f50bb4aa798a6f6cd1d2de8d0
#50680 (comment)https://github.com/nodejs/node/pull/50680#discussion_r1390363367
#50688https://github.com/nodejs/node/pull/50688
UlisesGasconhttps://github.com/UlisesGascon
Dec 11, 2023 https://github.com/nodejs/node/pull/50680#ref-commit-f804b3a
https://github.com/kvakil
https://github.com/UlisesGascon
src: add IsolateScopes before using isolateshttps://github.com/nodejs/node/commit/f804b3a8f866d13c64e640f728d96a306faab1e2
f804b3ahttps://github.com/nodejs/node/commit/f804b3a8f866d13c64e640f728d96a306faab1e2
nodejs/build#3204 (comment)https://github.com/nodejs/build/issues/3204#issuecomment-1790213488
https://bugs.chromium.org/p/v8/issues/detail?id=14292https://bugs.chromium.org/p/v8/issues/detail?id=14292
#50680https://github.com/nodejs/node/pull/50680
v8/v8@475c8cdhttps://github.com/v8/v8/commit/475c8cdf9a951bb06da3084794a0f659f8ef36c2
https://github.com/UlisesGascon
UlisesGasconhttps://github.com/UlisesGascon
Dec 12, 2023 https://github.com/nodejs/node/pull/50680#ref-pullrequest-2036750657
v20.11.0 proposal #51124 https://github.com/nodejs/node/pull/51124
UlisesGasconhttps://github.com/UlisesGascon
Dec 19, 2023 https://github.com/nodejs/node/pull/50680#ref-commit-436c3ae
https://github.com/kvakil
https://github.com/UlisesGascon
src: fix JSONParser leaking internal V8 scopeshttps://github.com/nodejs/node/commit/436c3aef15c821d18790f862ab120fe7b8f99edc
436c3aehttps://github.com/nodejs/node/commit/436c3aef15c821d18790f862ab120fe7b8f99edc
#50680 (comment)https://github.com/nodejs/node/pull/50680#discussion_r1390363367
#50688https://github.com/nodejs/node/pull/50688
UlisesGasconhttps://github.com/UlisesGascon
Dec 19, 2023 https://github.com/nodejs/node/pull/50680#ref-commit-f054c33
https://github.com/kvakil
https://github.com/UlisesGascon
src: add IsolateScopes before using isolateshttps://github.com/nodejs/node/commit/f054c337f8c5c1756a2df77ac7215a1f75377d1d
f054c33https://github.com/nodejs/node/commit/f054c337f8c5c1756a2df77ac7215a1f75377d1d
nodejs/build#3204 (comment)https://github.com/nodejs/build/issues/3204#issuecomment-1790213488
https://bugs.chromium.org/p/v8/issues/detail?id=14292https://bugs.chromium.org/p/v8/issues/detail?id=14292
#50680https://github.com/nodejs/node/pull/50680
v8/v8@475c8cdhttps://github.com/v8/v8/commit/475c8cdf9a951bb06da3084794a0f659f8ef36c2
https://github.com/kvakil
kvakilhttps://github.com/kvakil
Jan 24, 2024 https://github.com/nodejs/node/pull/50680#ref-issue-2062447641
--experimental-enable-pointer-compression causes build failure #51339 https://github.com/nodejs/node/issues/51339
https://github.com/richardlau
richardlauhttps://github.com/richardlau
dont-land-on-v20.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v20.x
Mar 25, 2024https://github.com/nodejs/node/pull/50680#event-12233359993
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50680
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/50680/files/b2b9acb6f9770e88bc0ec3865e5a95cd08b25842
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/50680/files/b2b9acb6f9770e88bc0ec3865e5a95cd08b25842
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/50680/files/b2b9acb6f9770e88bc0ec3865e5a95cd08b25842
https://github.com/RaisinTen
RaisinTen https://github.com/RaisinTen
https://github.com/nodejs/node/pull/50680/files/b2b9acb6f9770e88bc0ec3865e5a95cd08b25842
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
dont-land-on-v20.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v20.x
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/50680
https://github.com/kvakil
https://github.com/nodejs-github-bot
https://github.com/bnoordhuis
https://github.com/mcollina
https://github.com/jasnell
https://github.com/joyeecheung
https://github.com/RaisinTen
https://github.com/richardlau
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.