René's URL Explorer Experiment


Title: test: relax version check with shared OpenSSL by lpinca · Pull Request #50505 · nodejs/node · GitHub

Open Graph Title: test: relax version check with shared OpenSSL by lpinca · Pull Request #50505 · nodejs/node

X Title: test: relax version check with shared OpenSSL by lpinca · Pull Request #50505 · nodejs/node

Description: Relax the OpenSSL version check when Node.js is built with the --shared-openssl option. Verify only that process.versions.openssl is truthy. Fixes: #43078

Open Graph Description: Relax the OpenSSL version check when Node.js is built with the --shared-openssl option. Verify only that process.versions.openssl is truthy. Fixes: #43078

X Description: Relax the OpenSSL version check when Node.js is built with the --shared-openssl option. Verify only that process.versions.openssl is truthy. Fixes: #43078

Opengraph URL: https://github.com/nodejs/node/pull/50505

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:95ebdee2-904a-caad-6051-5d4ecd07328c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA7C2:341673:5FECF8:80D5F4:6969B61B
html-safe-nonce289219f68edc29fa570a234dfbedc48c2b3eecbace8bd4a3f1c5272a7d36fcbe
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBN0MyOjM0MTY3Mzo1RkVDRjg6ODBENUY0OjY5NjlCNjFCIiwidmlzaXRvcl9pZCI6IjcxNzQ0MjE2NDA1NDI1MzMxNDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacbc18cbacc7c8a02ba1606e80935af4b3ea940b08697923ce03ae91fbe10abb94
hovercard-subject-tagpull_request:1582810130
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/50505/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a5292bc08d2a6d1778bae008e654e9ffcd0966096e01c904c193a6cbbc0d5c0e/nodejs/node/pull/50505
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a5292bc08d2a6d1778bae008e654e9ffcd0966096e01c904c193a6cbbc0d5c0e/nodejs/node/pull/50505
og:image:altRelax the OpenSSL version check when Node.js is built with the --shared-openssl option. Verify only that process.versions.openssl is truthy. Fixes: #43078
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelpinca
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/50505#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50505
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50505
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/50505
Reloadhttps://github.com/nodejs/node/pull/50505
Reloadhttps://github.com/nodejs/node/pull/50505
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/50505
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/50505
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/50505#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
lpinca:relax/openssl-version-checkhttps://github.com/lpinca/node/tree/relax/openssl-version-check
test: relax version check with shared OpenSSL https://github.com/nodejs/node/pull/50505#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
lpinca:relax/openssl-version-checkhttps://github.com/lpinca/node/tree/relax/openssl-version-check
Conversation 4 https://github.com/nodejs/node/pull/50505
Commits 1 https://github.com/nodejs/node/pull/50505/commits
Checks 0 https://github.com/nodejs/node/pull/50505/checks
Files changed https://github.com/nodejs/node/pull/50505/files
Please reload this pagehttps://github.com/nodejs/node/pull/50505
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/lpinca
lpincahttps://github.com/lpinca
Nov 1, 2023https://github.com/nodejs/node/pull/50505#issue-1972538521
#43078https://github.com/nodejs/node/issues/43078
Please reload this pagehttps://github.com/nodejs/node/pull/50505
https://github.com/lpinca
test: relax version check with shared OpenSSLhttps://github.com/nodejs/node/pull/50505/commits/8738a7f6a73c39e9979ac5a22f9bf34a5128a522
8738a7fhttps://github.com/nodejs/node/pull/50505/commits/8738a7f6a73c39e9979ac5a22f9bf34a5128a522
nodejs#43078https://github.com/nodejs/node/issues/43078
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Nov 1, 2023https://github.com/nodejs/node/pull/50505#event-10833402324
https://github.com/lpinca
lpincahttps://github.com/lpinca
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 1, 2023https://github.com/nodejs/node/pull/50505#event-10833461177
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Nov 1, 2023 https://github.com/nodejs/node/pull/50505#pullrequestreview-1708413990
View reviewed changes https://github.com/nodejs/node/pull/50505/files/8738a7f6a73c39e9979ac5a22f9bf34a5128a522
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 1, 2023https://github.com/nodejs/node/pull/50505#event-10833541130
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 1, 2023https://github.com/nodejs/node/pull/50505#issuecomment-1789122590
https://ci.nodejs.org/job/node-test-pull-request/55389/https://ci.nodejs.org/job/node-test-pull-request/55389/
Please reload this pagehttps://github.com/nodejs/node/pull/50505
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 2, 2023 https://github.com/nodejs/node/pull/50505#ref-issue-1973289075
CI Reliability 2023-11-02 nodejs/reliability#705 https://github.com/nodejs/reliability/issues/705
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 2, 2023https://github.com/nodejs/node/pull/50505#issuecomment-1790141996
https://ci.nodejs.org/job/node-test-pull-request/55406/https://ci.nodejs.org/job/node-test-pull-request/55406/
Please reload this pagehttps://github.com/nodejs/node/pull/50505
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 2, 2023https://github.com/nodejs/node/pull/50505#issuecomment-1790499681
https://ci.nodejs.org/job/node-test-pull-request/55417/https://ci.nodejs.org/job/node-test-pull-request/55417/
Please reload this pagehttps://github.com/nodejs/node/pull/50505
CI Reliability 2023-11-03 nodejs/reliability#706 https://github.com/nodejs/reliability/issues/706
CI Reliability 2023-11-04 nodejs/reliability#707 https://github.com/nodejs/reliability/issues/707
CI Reliability 2023-11-05 nodejs/reliability#708 https://github.com/nodejs/reliability/issues/708
CI Reliability 2023-11-06 nodejs/reliability#709 https://github.com/nodejs/reliability/issues/709
CI Reliability 2023-11-07 nodejs/reliability#710 https://github.com/nodejs/reliability/issues/710
CI Reliability 2023-11-08 nodejs/reliability#711 https://github.com/nodejs/reliability/issues/711
https://github.com/lpinca
lpincahttps://github.com/lpinca
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Nov 8, 2023https://github.com/nodejs/node/pull/50505#event-10905379438
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Nov 8, 2023https://github.com/nodejs/node/pull/50505#event-10905446913
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
3e3467ehttps://github.com/nodejs/node/commit/3e3467e77a7af9bbafb9d50524125cfc9e1c3559
Nov 8, 2023https://github.com/nodejs/node/pull/50505#event-10905447594
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 8, 2023https://github.com/nodejs/node/pull/50505#issuecomment-1802592817
3e3467ehttps://github.com/nodejs/node/commit/3e3467e77a7af9bbafb9d50524125cfc9e1c3559
Please reload this pagehttps://github.com/nodejs/node/pull/50505
https://github.com/richardlau
richardlauhttps://github.com/richardlau
lts-watch-v18.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v18.x
lts-watch-v20.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v20.x
Nov 8, 2023https://github.com/nodejs/node/pull/50505#event-10905518377
https://github.com/lpinca
lpincahttps://github.com/lpinca
November 8, 2023 20:59https://github.com/nodejs/node/pull/50505#event-10905784251
targoshttps://github.com/targos
Nov 11, 2023 https://github.com/nodejs/node/pull/50505#ref-commit-6005672
https://github.com/lpinca
https://github.com/targos
test: relax version check with shared OpenSSLhttps://github.com/nodejs/node/commit/600567284cbd4545fcdcb69a3604986f718813db
6005672https://github.com/nodejs/node/commit/600567284cbd4545fcdcb69a3604986f718813db
#43078https://github.com/nodejs/node/issues/43078
#50505https://github.com/nodejs/node/pull/50505
https://github.com/targos
targoshttps://github.com/targos
Nov 12, 2023 https://github.com/nodejs/node/pull/50505#ref-pullrequest-1989278421
v21.2.0 release proposal #50681 https://github.com/nodejs/node/pull/50681
targoshttps://github.com/targos
Nov 14, 2023 https://github.com/nodejs/node/pull/50505#ref-commit-931e1e7
https://github.com/lpinca
https://github.com/targos
test: relax version check with shared OpenSSLhttps://github.com/nodejs/node/commit/931e1e756a6a839cd1b69afcf400e849e921d640
931e1e7https://github.com/nodejs/node/commit/931e1e756a6a839cd1b69afcf400e849e921d640
#43078https://github.com/nodejs/node/issues/43078
#50505https://github.com/nodejs/node/pull/50505
https://github.com/targos
targoshttps://github.com/targos
backported-to-v20.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v20.x
lts-watch-v20.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v20.x
Nov 15, 2023https://github.com/nodejs/node/pull/50505#event-10964219203
targoshttps://github.com/targos
Nov 15, 2023 https://github.com/nodejs/node/pull/50505#ref-commit-4e34f9a
https://github.com/lpinca
https://github.com/targos
test: relax version check with shared OpenSSLhttps://github.com/nodejs/node/commit/4e34f9a26e2dc57c1b54c66bf40fe8e075c02ca4
4e34f9ahttps://github.com/nodejs/node/commit/4e34f9a26e2dc57c1b54c66bf40fe8e075c02ca4
#43078https://github.com/nodejs/node/issues/43078
#50505https://github.com/nodejs/node/pull/50505
https://github.com/targos
targoshttps://github.com/targos
lts-watch-v18.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v18.x
Nov 15, 2023https://github.com/nodejs/node/pull/50505#event-10965527750
https://github.com/targos
targoshttps://github.com/targos
backported-to-v18.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v18.x
Nov 15, 2023https://github.com/nodejs/node/pull/50505#event-10965527753
targoshttps://github.com/targos
Nov 15, 2023 https://github.com/nodejs/node/pull/50505#ref-commit-8c918e5
https://github.com/lpinca
https://github.com/targos
test: relax version check with shared OpenSSLhttps://github.com/nodejs/node/commit/8c918e5e59c749a9fa711f3ed436aeeede549536
8c918e5https://github.com/nodejs/node/commit/8c918e5e59c749a9fa711f3ed436aeeede549536
#43078https://github.com/nodejs/node/issues/43078
#50505https://github.com/nodejs/node/pull/50505
https://github.com/targos
targoshttps://github.com/targos
Nov 21, 2023 https://github.com/nodejs/node/pull/50505#ref-pullrequest-1989293723
v20.10.0 release proposal #50682 https://github.com/nodejs/node/pull/50682
https://github.com/targos
targoshttps://github.com/targos
Nov 28, 2023 https://github.com/nodejs/node/pull/50505#ref-pullrequest-2014162105
v18.19.0 release proposal #50953 https://github.com/nodejs/node/pull/50953
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Dec 6, 2023 https://github.com/nodejs/node/pull/50505#ref-pullrequest-2029497346
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41 https://github.com/nodesource/nsolid/pull/41
sercherhttps://github.com/sercher
Apr 25, 2024 https://github.com/nodejs/node/pull/50505#ref-commit-2daf5a8
https://github.com/sercher
test: relax version check with shared OpenSSLhttps://github.com/sercher/graaljs/commit/2daf5a8b97a6a681e9525ed35f699681fb916b2b
2daf5a8https://github.com/sercher/graaljs/commit/2daf5a8b97a6a681e9525ed35f699681fb916b2b
nodejs/node#43078https://github.com/nodejs/node/issues/43078
nodejs/node#50505https://github.com/nodejs/node/pull/50505
sercherhttps://github.com/sercher
Apr 25, 2024 https://github.com/nodejs/node/pull/50505#ref-commit-fb7058b
https://github.com/sercher
test: relax version check with shared OpenSSLhttps://github.com/sercher/graaljs/commit/fb7058b53efdd8e0f0296ec19c7b2ea01a172451
fb7058bhttps://github.com/sercher/graaljs/commit/fb7058b53efdd8e0f0296ec19c7b2ea01a172451
nodejs/node#43078https://github.com/nodejs/node/issues/43078
nodejs/node#50505https://github.com/nodejs/node/pull/50505
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50505
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/50505/files/8738a7f6a73c39e9979ac5a22f9bf34a5128a522
backported-to-v20.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v20.x
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
FreeBSD openssl version string doesn't match regex test https://github.com/nodejs/node/issues/43078
Please reload this pagehttps://github.com/nodejs/node/pull/50505
https://github.com/lpinca
https://github.com/nodejs-github-bot
https://github.com/richardlau
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.