René's URL Explorer Experiment


Title: esm: do not call `getSource` when format is `commonjs` by fasttime · Pull Request #50465 · nodejs/node · GitHub

Open Graph Title: esm: do not call `getSource` when format is `commonjs` by fasttime · Pull Request #50465 · nodejs/node

X Title: esm: do not call `getSource` when format is `commonjs` by fasttime · Pull Request #50465 · nodejs/node

Description: This PR ensures that defaultLoad does not access the file system to read the source of modules that are known in advance to be in CommonJS format. This is not necessary, since the CommonJS loader c...

Open Graph Description: This PR ensures that defaultLoad does not access the file system to read the source of modules that are known in advance to be in CommonJS format. This is not necessary, since the CommonJS loader c...

X Description: This PR ensures that defaultLoad does not access the file system to read the source of modules that are known in advance to be in CommonJS format. This is not necessary, since the CommonJS loader c...

Opengraph URL: https://github.com/nodejs/node/pull/50465

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:847253d3-9a27-6fc8-5be9-b9ecd03826f8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9F2A:1F0995:40398:54C81:6969CEC0
html-safe-nonce1fd799b34461c4131552ca8f99e1212eb88d4d38eaa21271bf68bc4d62de1c8b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjJBOjFGMDk5NTo0MDM5ODo1NEM4MTo2OTY5Q0VDMCIsInZpc2l0b3JfaWQiOiI4MTc5NTkzMjcyMjc5ODEzODI0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac466cb3f1badd51d1f1c83d34f6a7e05aa0a3d9a90c72cae24c667ab4f3043c13
hovercard-subject-tagpull_request:1577785364
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/50465/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4634cd8a37d6036ed55b2e8253a5f67b9b588b1d9953fdc0be95f2498676c765/nodejs/node/pull/50465
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4634cd8a37d6036ed55b2e8253a5f67b9b588b1d9953fdc0be95f2498676c765/nodejs/node/pull/50465
og:image:altThis PR ensures that defaultLoad does not access the file system to read the source of modules that are known in advance to be in CommonJS format. This is not necessary, since the CommonJS loader c...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamefasttime
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/50465#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50465
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50465
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/50465
Reloadhttps://github.com/nodejs/node/pull/50465
Reloadhttps://github.com/nodejs/node/pull/50465
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/50465
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/50465
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/50465#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
esm: do not call getSource when format is commonjs https://github.com/nodejs/node/pull/50465#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
Conversation 33 https://github.com/nodejs/node/pull/50465
Commits 6 https://github.com/nodejs/node/pull/50465/commits
Checks 0 https://github.com/nodejs/node/pull/50465/checks
Files changed https://github.com/nodejs/node/pull/50465/files
Please reload this pagehttps://github.com/nodejs/node/pull/50465
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/fasttime
fasttimehttps://github.com/fasttime
Oct 29, 2023https://github.com/nodejs/node/pull/50465#issue-1966893742
Please reload this pagehttps://github.com/nodejs/node/pull/50465
this commithttps://github.com/nodejs/node/commit/02926d3c6aaf70eba6d80423beb2d5df97e1ebc7#diff-bdab80c290d22162f748d1a80a5a2a5211460e5ab3fca7a42af0e8ca128e316dR130-L140
eslint/eslint#17683https://github.com/eslint/eslint/pull/17683
Please reload this pagehttps://github.com/nodejs/node/pull/50465
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 29, 2023https://github.com/nodejs/node/pull/50465#issuecomment-1784032672
Please reload this pagehttps://github.com/nodejs/node/pull/50465
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Oct 29, 2023https://github.com/nodejs/node/pull/50465#event-10799339654
https://github.com/fasttime
fasttimehttps://github.com/fasttime
October 29, 2023 10:27https://github.com/nodejs/node/pull/50465#event-10799546798
https://github.com/ljharb
ljharbhttps://github.com/ljharb
Oct 29, 2023https://github.com/nodejs/node/pull/50465#issuecomment-1784125919
Please reload this pagehttps://github.com/nodejs/node/pull/50465
https://github.com/aduh95
aduh95https://github.com/aduh95
Oct 29, 2023 https://github.com/nodejs/node/pull/50465#pullrequestreview-1702977547
View reviewed changes https://github.com/nodejs/node/pull/50465/files
aduh95https://github.com/aduh95
https://github.com/nodejs/node/pull/50465#pullrequestreview-1702977547
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/50465
test/es-module/test-esm-dynamic-import-commonjs.jshttps://github.com/nodejs/node/pull/50465/files#diff-21055bdcc4a306a82f498e8057c21e3f868facd1e1a4b6b5f9fc88657a8cdecb
Please reload this pagehttps://github.com/nodejs/node/pull/50465
test/es-module/test-esm-dynamic-import-commonjs.jshttps://github.com/nodejs/node/pull/50465/files#diff-21055bdcc4a306a82f498e8057c21e3f868facd1e1a4b6b5f9fc88657a8cdecb
Please reload this pagehttps://github.com/nodejs/node/pull/50465
test/es-module/test-esm-dynamic-import-commonjs.mjshttps://github.com/nodejs/node/pull/50465/files#diff-e7fb4d950e7be13197a5da12baf325f5a9bc41362984c0e83b5b91e48a536c26
Please reload this pagehttps://github.com/nodejs/node/pull/50465
test/es-module/test-esm-dynamic-import-commonjs.mjshttps://github.com/nodejs/node/pull/50465/files#diff-e7fb4d950e7be13197a5da12baf325f5a9bc41362984c0e83b5b91e48a536c26
Please reload this pagehttps://github.com/nodejs/node/pull/50465
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 29, 2023 https://github.com/nodejs/node/pull/50465#pullrequestreview-1702982183
View reviewed changes https://github.com/nodejs/node/pull/50465/files
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Oct 30, 2023https://github.com/nodejs/node/pull/50465#issuecomment-1784460191
Please reload this pagehttps://github.com/nodejs/node/pull/50465
https://github.com/fasttime
fasttimehttps://github.com/fasttime
Nov 1, 2023https://github.com/nodejs/node/pull/50465#issuecomment-1788601849
@GeoffreyBoothhttps://github.com/GeoffreyBooth
new branchhttps://github.com/nodejs/node/compare/main...fasttime:node:async-cjs-source?expand=1
observable behaviorhttps://github.com/nodejs/node/pull/50465#issuecomment-1784125919
Please reload this pagehttps://github.com/nodejs/node/pull/50465
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 1, 2023https://github.com/nodejs/node/pull/50465#issuecomment-1788659052
Please reload this pagehttps://github.com/nodejs/node/pull/50465
https://github.com/fasttime
fasttimehttps://github.com/fasttime
Nov 1, 2023https://github.com/nodejs/node/pull/50465#issuecomment-1788664007
Please reload this pagehttps://github.com/nodejs/node/pull/50465
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 1, 2023https://github.com/nodejs/node/pull/50465#issuecomment-1788700530
Please reload this pagehttps://github.com/nodejs/node/pull/50465
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 1, 2023https://github.com/nodejs/node/pull/50465#issuecomment-1788707001
Please reload this pagehttps://github.com/nodejs/node/pull/50465
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Nov 1, 2023https://github.com/nodejs/node/pull/50465#issuecomment-1788992147
Please reload this pagehttps://github.com/nodejs/node/pull/50465
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 1, 2023https://github.com/nodejs/node/pull/50465#issuecomment-1789004565
Please reload this pagehttps://github.com/nodejs/node/pull/50465
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Nov 1, 2023https://github.com/nodejs/node/pull/50465#issuecomment-1789020167
Please reload this pagehttps://github.com/nodejs/node/pull/50465
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 1, 2023https://github.com/nodejs/node/pull/50465#issuecomment-1789027531
Please reload this pagehttps://github.com/nodejs/node/pull/50465
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Nov 1, 2023https://github.com/nodejs/node/pull/50465#issuecomment-1789190301
Please reload this pagehttps://github.com/nodejs/node/pull/50465
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 1, 2023https://github.com/nodejs/node/pull/50465#issuecomment-1789484132
#50465 (comment)https://github.com/nodejs/node/pull/50465#issuecomment-1789004565
Please reload this pagehttps://github.com/nodejs/node/pull/50465
https://github.com/ljharb
ljharbhttps://github.com/ljharb
Nov 1, 2023https://github.com/nodejs/node/pull/50465#issuecomment-1789493610
Please reload this pagehttps://github.com/nodejs/node/pull/50465
https://github.com/fasttime
fasttimehttps://github.com/fasttime
Nov 6, 2023https://github.com/nodejs/node/pull/50465#issuecomment-1795200608
Please reload this pagehttps://github.com/nodejs/node/pull/50465
https://github.com/fasttime
fasttimehttps://github.com/fasttime
Nov 7, 2023https://github.com/nodejs/node/pull/50465#issuecomment-1798481936
@GeoffreyBoothhttps://github.com/GeoffreyBooth
wrapped in a try-catch statementhttps://github.com/nodejs/node/blob/a9b25356c0d651965b71ccd7802dfa373304deb8/lib/internal/modules/esm/translators.js#L352-L357
c93377fhttps://github.com/nodejs/node/commit/c93377f61f8d95360e5b596d48ba7d4e290cda2e
Please reload this pagehttps://github.com/nodejs/node/pull/50465
https://github.com/fasttime
fasttimehttps://github.com/fasttime
aduh95https://github.com/aduh95
November 7, 2023 13:14https://github.com/nodejs/node/pull/50465#event-10886643386
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 7, 2023 https://github.com/nodejs/node/pull/50465#pullrequestreview-1717674442
View reviewed changes https://github.com/nodejs/node/pull/50465/files
test/es-module/test-esm-loader-with-source.mjshttps://github.com/nodejs/node/pull/50465/files#diff-39b8f9e7cc4cd1c8ed55047b89fb5c8b0fd4420032b20e4461e0dc001ad3909c
aduh95https://github.com/aduh95
Nov 7, 2023https://github.com/nodejs/node/pull/50465#discussion_r1384908592
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/50465
fasttimehttps://github.com/fasttime
Nov 8, 2023https://github.com/nodejs/node/pull/50465#discussion_r1386765205
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
resolve hookhttps://github.com/nodejs/node/blob/c93377f61f8d95360e5b596d48ba7d4e290cda2e/test/fixtures/es-module-loaders/preset-cjs-source.mjs#L3-L7
Please reload this pagehttps://github.com/nodejs/node/pull/50465
aduh95https://github.com/aduh95
Nov 8, 2023https://github.com/nodejs/node/pull/50465#discussion_r1386810837
Please reload this pagehttps://github.com/nodejs/node/pull/50465
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/50465
fasttimehttps://github.com/fasttime
Nov 8, 2023https://github.com/nodejs/node/pull/50465#discussion_r1387148676
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
4dcbec5https://github.com/nodejs/node/commit/4dcbec57f99975322ca236b441e800647e5acfdf
Please reload this pagehttps://github.com/nodejs/node/pull/50465
https://github.com/aduh95
aduh95https://github.com/aduh95
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 8, 2023https://github.com/nodejs/node/pull/50465#event-10902507644
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 8, 2023https://github.com/nodejs/node/pull/50465#event-10902612146
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 8, 2023https://github.com/nodejs/node/pull/50465#issuecomment-1802157094
https://ci.nodejs.org/job/node-test-pull-request/55501/https://ci.nodejs.org/job/node-test-pull-request/55501/
Please reload this pagehttps://github.com/nodejs/node/pull/50465
CI Reliability 2023-11-09 nodejs/reliability#712 https://github.com/nodejs/reliability/issues/712
CI Reliability 2023-11-10 nodejs/reliability#713 https://github.com/nodejs/reliability/issues/713
https://github.com/aduh95
aduh95https://github.com/aduh95
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
Nov 29, 2023https://github.com/nodejs/node/pull/50465#event-11093597926
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Nov 29, 2023https://github.com/nodejs/node/pull/50465#event-11093691520
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
2602c46https://github.com/nodejs/node/commit/2602c4642b79eae464822d03b473936661f5af14
Nov 29, 2023https://github.com/nodejs/node/pull/50465#event-11093692365
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 29, 2023https://github.com/nodejs/node/pull/50465#issuecomment-1831516785
2602c46https://github.com/nodejs/node/commit/2602c4642b79eae464822d03b473936661f5af14
Please reload this pagehttps://github.com/nodejs/node/pull/50465
RafaelGSShttps://github.com/RafaelGSS
Nov 29, 2023 https://github.com/nodejs/node/pull/50465#ref-commit-bd58870
https://github.com/fasttime
https://github.com/RafaelGSS
esm: do not call getSource when format is commonjshttps://github.com/nodejs/node/commit/bd58870556c5974e79f50819d8290d4e5230682e
bd58870https://github.com/nodejs/node/commit/bd58870556c5974e79f50819d8290d4e5230682e
eslint/eslint#17683https://github.com/eslint/eslint/pull/17683
#50465https://github.com/nodejs/node/pull/50465
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Nov 29, 2023 https://github.com/nodejs/node/pull/50465#ref-pullrequest-2014290477
v21.3.0 proposal #50954 https://github.com/nodejs/node/pull/50954
UlisesGasconhttps://github.com/UlisesGascon
Dec 11, 2023 https://github.com/nodejs/node/pull/50465#ref-commit-8feb2db
https://github.com/fasttime
https://github.com/UlisesGascon
esm: do not call getSource when format is commonjshttps://github.com/nodejs/node/commit/8feb2dbaa4d53ab2d0d9c6592ef4495b6115ddc9
8feb2dbhttps://github.com/nodejs/node/commit/8feb2dbaa4d53ab2d0d9c6592ef4495b6115ddc9
eslint/eslint#17683https://github.com/eslint/eslint/pull/17683
#50465https://github.com/nodejs/node/pull/50465
https://github.com/UlisesGascon
UlisesGasconhttps://github.com/UlisesGascon
Dec 12, 2023 https://github.com/nodejs/node/pull/50465#ref-pullrequest-2036750657
v20.11.0 proposal #51124 https://github.com/nodejs/node/pull/51124
UlisesGasconhttps://github.com/UlisesGascon
Dec 13, 2023 https://github.com/nodejs/node/pull/50465#ref-commit-7c386fa
https://github.com/fasttime
https://github.com/UlisesGascon
esm: do not call getSource when format is commonjshttps://github.com/nodejs/node/commit/7c386fa460246f9cb237b8ab6d13920b1d1a42ef
7c386fahttps://github.com/nodejs/node/commit/7c386fa460246f9cb237b8ab6d13920b1d1a42ef
eslint/eslint#17683https://github.com/eslint/eslint/pull/17683
#50465https://github.com/nodejs/node/pull/50465
UlisesGasconhttps://github.com/UlisesGascon
Dec 15, 2023 https://github.com/nodejs/node/pull/50465#ref-commit-2239d66
https://github.com/fasttime
https://github.com/UlisesGascon
esm: do not call getSource when format is commonjshttps://github.com/nodejs/node/commit/2239d667861005b2c8935c2931f450e167830743
2239d66https://github.com/nodejs/node/commit/2239d667861005b2c8935c2931f450e167830743
eslint/eslint#17683https://github.com/eslint/eslint/pull/17683
#50465https://github.com/nodejs/node/pull/50465
UlisesGasconhttps://github.com/UlisesGascon
Dec 19, 2023 https://github.com/nodejs/node/pull/50465#ref-commit-8d5469c
https://github.com/fasttime
https://github.com/UlisesGascon
esm: do not call getSource when format is commonjshttps://github.com/nodejs/node/commit/8d5469c84bda957d4fc7cbdbcfd93b289cfd1a6f
8d5469chttps://github.com/nodejs/node/commit/8d5469c84bda957d4fc7cbdbcfd93b289cfd1a6f
eslint/eslint#17683https://github.com/eslint/eslint/pull/17683
#50465https://github.com/nodejs/node/pull/50465
codebyterehttps://github.com/codebytere
Jan 10, 2024 https://github.com/nodejs/node/pull/50465#ref-commit-b9e5303
https://github.com/codebytere
esm: do not call getSource when format is commonjshttps://github.com/electron/electron/commit/b9e53035a13ee3779f68887a51eb82d1c75ac279
b9e5303https://github.com/electron/electron/commit/b9e53035a13ee3779f68887a51eb82d1c75ac279
nodejs/node#50465https://github.com/nodejs/node/pull/50465
codebyterehttps://github.com/codebytere
Jan 10, 2024 https://github.com/nodejs/node/pull/50465#ref-commit-4472819
https://github.com/codebytere
esm: do not call getSource when format is commonjshttps://github.com/electron/electron/commit/4472819fd8ab130f3270e3374ee081e60bbfc2ed
4472819https://github.com/electron/electron/commit/4472819fd8ab130f3270e3374ee081e60bbfc2ed
nodejs/node#50465https://github.com/nodejs/node/pull/50465
zcbenzhttps://github.com/zcbenz
Jan 12, 2024 https://github.com/nodejs/node/pull/50465#ref-commit-b538ef4
https://github.com/codebytere
https://github.com/zcbenz
esm: do not call getSource when format is commonjshttps://github.com/electron/electron/commit/b538ef4ba3069869d6526039df236dff96ff2b85
b538ef4https://github.com/electron/electron/commit/b538ef4ba3069869d6526039df236dff96ff2b85
nodejs/node#50465https://github.com/nodejs/node/pull/50465
zcbenzhttps://github.com/zcbenz
Jan 12, 2024 https://github.com/nodejs/node/pull/50465#ref-commit-1ccffa5
https://github.com/codebytere
https://github.com/zcbenz
esm: do not call getSource when format is commonjshttps://github.com/electron/electron/commit/1ccffa5b9bda075119d594b06ea3203da612ba69
1ccffa5https://github.com/electron/electron/commit/1ccffa5b9bda075119d594b06ea3203da612ba69
nodejs/node#50465https://github.com/nodejs/node/pull/50465
zcbenzhttps://github.com/zcbenz
Jan 12, 2024 https://github.com/nodejs/node/pull/50465#ref-commit-585c4d0
https://github.com/codebytere
https://github.com/zcbenz
esm: do not call getSource when format is commonjshttps://github.com/electron/electron/commit/585c4d06dfa824acbb909b28a42388a417259812
585c4d0https://github.com/electron/electron/commit/585c4d06dfa824acbb909b28a42388a417259812
nodejs/node#50465https://github.com/nodejs/node/pull/50465
zcbenzhttps://github.com/zcbenz
Jan 12, 2024 https://github.com/nodejs/node/pull/50465#ref-commit-f7d5537
https://github.com/codebytere
https://github.com/zcbenz
esm: do not call getSource when format is commonjshttps://github.com/electron/electron/commit/f7d5537e3cfcffa0f56804b28b2faa3cdd339544
f7d5537https://github.com/electron/electron/commit/f7d5537e3cfcffa0f56804b28b2faa3cdd339544
nodejs/node#50465https://github.com/nodejs/node/pull/50465
codebyterehttps://github.com/codebytere
Jan 15, 2024 https://github.com/nodejs/node/pull/50465#ref-commit-1417e3b
https://github.com/codebytere
esm: do not call getSource when format is commonjshttps://github.com/electron/electron/commit/1417e3bdd8bbeeacb65558bfe31867e9eaf0f668
1417e3bhttps://github.com/electron/electron/commit/1417e3bdd8bbeeacb65558bfe31867e9eaf0f668
nodejs/node#50465https://github.com/nodejs/node/pull/50465
codebyterehttps://github.com/codebytere
Jan 15, 2024 https://github.com/nodejs/node/pull/50465#ref-commit-5c96ca9
https://github.com/codebytere
esm: do not call getSource when format is commonjshttps://github.com/electron/electron/commit/5c96ca984bea79692fcc1dbed90316f7f78d6131
5c96ca9https://github.com/electron/electron/commit/5c96ca984bea79692fcc1dbed90316f7f78d6131
nodejs/node#50465https://github.com/nodejs/node/pull/50465
codebyterehttps://github.com/codebytere
Jan 15, 2024 https://github.com/nodejs/node/pull/50465#ref-commit-ef46db8
https://github.com/codebytere
esm: do not call getSource when format is commonjshttps://github.com/electron/electron/commit/ef46db8d8275f9791733feed7f056d4c6de4968b
ef46db8https://github.com/electron/electron/commit/ef46db8d8275f9791733feed7f056d4c6de4968b
nodejs/node#50465https://github.com/nodejs/node/pull/50465
codebyterehttps://github.com/codebytere
Jan 15, 2024 https://github.com/nodejs/node/pull/50465#ref-commit-86a18fe
https://github.com/codebytere
esm: do not call getSource when format is commonjshttps://github.com/electron/electron/commit/86a18fe370e2511e445e3358d422cc2074c092c4
86a18fehttps://github.com/electron/electron/commit/86a18fe370e2511e445e3358d422cc2074c092c4
nodejs/node#50465https://github.com/nodejs/node/pull/50465
codebyterehttps://github.com/codebytere
Jan 16, 2024 https://github.com/nodejs/node/pull/50465#ref-commit-e190b35
https://github.com/codebytere
esm: do not call getSource when format is commonjshttps://github.com/electron/electron/commit/e190b35afb4eb96d95be2a82f7c7a30257345276
e190b35https://github.com/electron/electron/commit/e190b35afb4eb96d95be2a82f7c7a30257345276
nodejs/node#50465https://github.com/nodejs/node/pull/50465
codebyterehttps://github.com/codebytere
Jan 16, 2024 https://github.com/nodejs/node/pull/50465#ref-commit-cbb3631
https://github.com/codebytere
esm: do not call getSource when format is commonjshttps://github.com/electron/electron/commit/cbb3631687553ffc3e67cdd997c95e6a1f8be4d8
cbb3631https://github.com/electron/electron/commit/cbb3631687553ffc3e67cdd997c95e6a1f8be4d8
nodejs/node#50465https://github.com/nodejs/node/pull/50465
codebyterehttps://github.com/codebytere
Jan 18, 2024 https://github.com/nodejs/node/pull/50465#ref-commit-460ee2c
https://github.com/codebytere
esm: do not call getSource when format is commonjshttps://github.com/electron/electron/commit/460ee2cecb83ec1931ca8012d419dc9a182d0109
460ee2chttps://github.com/electron/electron/commit/460ee2cecb83ec1931ca8012d419dc9a182d0109
nodejs/node#50465https://github.com/nodejs/node/pull/50465
codebyterehttps://github.com/codebytere
Jan 18, 2024 https://github.com/nodejs/node/pull/50465#ref-commit-7bbad41
https://github.com/codebytere
esm: do not call getSource when format is commonjshttps://github.com/electron/electron/commit/7bbad413862e5a13e24030176205a90ba69ef5dc
7bbad41https://github.com/electron/electron/commit/7bbad413862e5a13e24030176205a90ba69ef5dc
nodejs/node#50465https://github.com/nodejs/node/pull/50465
jkleinschttps://github.com/jkleinsc
Jan 18, 2024 https://github.com/nodejs/node/pull/50465#ref-commit-847b034
https://github.com/codebytere
https://github.com/jkleinsc
esm: do not call getSource when format is commonjshttps://github.com/electron/electron/commit/847b034969acaa6506f3a9f2a37e8ba112c71663
847b034https://github.com/electron/electron/commit/847b034969acaa6506f3a9f2a37e8ba112c71663
nodejs/node#50465https://github.com/nodejs/node/pull/50465
jkleinschttps://github.com/jkleinsc
Jan 18, 2024 https://github.com/nodejs/node/pull/50465#ref-commit-b3bfca7
https://github.com/codebytere
https://github.com/jkleinsc
esm: do not call getSource when format is commonjshttps://github.com/electron/electron/commit/b3bfca7eb8c35260e9ae72f78c1cf60201f34b81
b3bfca7https://github.com/electron/electron/commit/b3bfca7eb8c35260e9ae72f78c1cf60201f34b81
nodejs/node#50465https://github.com/nodejs/node/pull/50465
codebyterehttps://github.com/codebytere
Jan 18, 2024 https://github.com/nodejs/node/pull/50465#ref-commit-6752888
https://github.com/codebytere
esm: do not call getSource when format is commonjshttps://github.com/electron/electron/commit/6752888c70ee49be3c50a7e2f2f8b2eceec53311
6752888https://github.com/electron/electron/commit/6752888c70ee49be3c50a7e2f2f8b2eceec53311
nodejs/node#50465https://github.com/nodejs/node/pull/50465
codebyterehttps://github.com/codebytere
Jan 18, 2024 https://github.com/nodejs/node/pull/50465#ref-commit-cda0cb4
https://github.com/codebytere
esm: do not call getSource when format is commonjshttps://github.com/electron/electron/commit/cda0cb473066ed9607dbc9c4cf4a16b2589914d3
cda0cb4https://github.com/electron/electron/commit/cda0cb473066ed9607dbc9c4cf4a16b2589914d3
nodejs/node#50465https://github.com/nodejs/node/pull/50465
jkleinschttps://github.com/jkleinsc
Jan 18, 2024 https://github.com/nodejs/node/pull/50465#ref-commit-f4ee3c1
https://github.com/apps/electron-roller
https://github.com/codebytere
https://github.com/zcbenz
chore: bump node to v20.11.0 (main) (https://github.com/electron/electron/commit/f4ee3c1b2a4a2c0ae69140a04cc76d0ffbaab320
#40941https://github.com/electron/electron/pull/40941
)https://github.com/electron/electron/commit/f4ee3c1b2a4a2c0ae69140a04cc76d0ffbaab320
f4ee3c1https://github.com/electron/electron/commit/f4ee3c1b2a4a2c0ae69140a04cc76d0ffbaab320
nodejs/node#48655https://github.com/nodejs/node/pull/48655
nodejs/node#50158https://github.com/nodejs/node/pull/50158
nodejs/node#50820https://github.com/nodejs/node/pull/50820
nodejs/node#50465https://github.com/nodejs/node/pull/50465
nodejs/node#50825https://github.com/nodejs/node/pull/50825
nodejs/node#50360https://github.com/nodejs/node/pull/50360
nodejs/node#50327https://github.com/nodejs/node/pull/50327
nodejs/node#50465https://github.com/nodejs/node/pull/50465
nodejs/node#50634https://github.com/nodejs/node/pull/50634
nodejs/node#50709https://github.com/nodejs/node/pull/50709
nodejs/node#50629https://github.com/nodejs/node/pull/50629
nodejs/node#50663https://github.com/nodejs/node/pull/50663
nodejs/node#50709https://github.com/nodejs/node/pull/50709
nodejs/node#50186https://github.com/nodejs/node/pull/50186
nodejs/node#51239https://github.com/nodejs/node/pull/51239
nodejs/node#50421https://github.com/nodejs/node/pull/50421
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50465
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/50465/files/a6bbad53631c2eada6f946e623a34a9ef50b3243
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/50465/files/45c9a4af2b94b7fd6cf298623c6a3e8b5dd4fadd
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/50465
https://github.com/fasttime
https://github.com/nodejs-github-bot
https://github.com/ljharb
https://github.com/GeoffreyBooth
https://github.com/aduh95
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.