René's URL Explorer Experiment


Title: test: ensure never settling promises are detected by aduh95 · Pull Request #50318 · nodejs/node · GitHub

Open Graph Title: test: ensure never settling promises are detected by aduh95 · Pull Request #50318 · nodejs/node

X Title: test: ensure never settling promises are detected by aduh95 · Pull Request #50318 · nodejs/node

Description: It won't detect all possible cases where we forget about never-settling promises, but it should catch the most common ones.

Open Graph Description: It won't detect all possible cases where we forget about never-settling promises, but it should catch the most common ones.

X Description: It won't detect all possible cases where we forget about never-settling promises, but it should catch the most common ones.

Opengraph URL: https://github.com/nodejs/node/pull/50318

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:09b5012f-34b7-1f9f-bc4a-2a32371afe4d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD3C:31EA40:93B133:C943FD:6969E841
html-safe-nonce231b7853614ab58030c7eb7def10f605e83211ab746d9658fadfd728f7baadee
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDNDOjMxRUE0MDo5M0IxMzM6Qzk0M0ZEOjY5NjlFODQxIiwidmlzaXRvcl9pZCI6IjQwODM5NDc4NTc5MzQ2NzM5ODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaccec2f92f30c2dc77f3f562ab4fc83c8c2c75715d0e509586b18769a2b620f0ab
hovercard-subject-tagpull_request:1567838481
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/50318/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/521989903596da0d22a78e098e8479117413a6306222a3e05fa95c93d6eab605/nodejs/node/pull/50318
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/521989903596da0d22a78e098e8479117413a6306222a3e05fa95c93d6eab605/nodejs/node/pull/50318
og:image:altIt won't detect all possible cases where we forget about never-settling promises, but it should catch the most common ones.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaduh95
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/50318#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50318
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50318
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/50318
Reloadhttps://github.com/nodejs/node/pull/50318
Reloadhttps://github.com/nodejs/node/pull/50318
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/50318
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/50318
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/50318#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
aduh95:never-settling-rejecthttps://github.com/aduh95/node/tree/never-settling-reject
test: ensure never settling promises are detected https://github.com/nodejs/node/pull/50318#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
aduh95:never-settling-rejecthttps://github.com/aduh95/node/tree/never-settling-reject
Conversation 5 https://github.com/nodejs/node/pull/50318
Commits 2 https://github.com/nodejs/node/pull/50318/commits
Checks 0 https://github.com/nodejs/node/pull/50318/checks
Files changed https://github.com/nodejs/node/pull/50318/files
Please reload this pagehttps://github.com/nodejs/node/pull/50318
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/aduh95
aduh95https://github.com/aduh95
Oct 21, 2023https://github.com/nodejs/node/pull/50318#issue-1955600022
Please reload this pagehttps://github.com/nodejs/node/pull/50318
https://github.com/aduh95
test: ensure never settling promises are detectedhttps://github.com/nodejs/node/pull/50318/commits/8b3d6494b6ecbc1b4d25b706e6c74b454090bc27
8b3d649https://github.com/nodejs/node/pull/50318/commits/8b3d6494b6ecbc1b4d25b706e6c74b454090bc27
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Oct 21, 2023https://github.com/nodejs/node/pull/50318#event-10731813780
https://github.com/targos
targoshttps://github.com/targos
Oct 21, 2023 https://github.com/nodejs/node/pull/50318#pullrequestreview-1691320376
View reviewed changes https://github.com/nodejs/node/pull/50318/files/8b3d6494b6ecbc1b4d25b706e6c74b454090bc27
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 21, 2023 https://github.com/nodejs/node/pull/50318#pullrequestreview-1691320721
View reviewed changes https://github.com/nodejs/node/pull/50318/files/8b3d6494b6ecbc1b4d25b706e6c74b454090bc27
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Oct 21, 2023 https://github.com/nodejs/node/pull/50318#pullrequestreview-1691321285
View reviewed changes https://github.com/nodejs/node/pull/50318/files/8b3d6494b6ecbc1b4d25b706e6c74b454090bc27
https://github.com/anonrig
anonrighttps://github.com/anonrig
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 21, 2023https://github.com/nodejs/node/pull/50318#event-10732024177
https://github.com/anonrig
anonrighttps://github.com/anonrig
Oct 21, 2023 https://github.com/nodejs/node/pull/50318#pullrequestreview-1691329034
View reviewed changes https://github.com/nodejs/node/pull/50318/files/8b3d6494b6ecbc1b4d25b706e6c74b454090bc27
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 21, 2023https://github.com/nodejs/node/pull/50318#event-10732033964
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 21, 2023https://github.com/nodejs/node/pull/50318#issuecomment-1773909421
https://ci.nodejs.org/job/node-test-pull-request/55105/https://ci.nodejs.org/job/node-test-pull-request/55105/
Please reload this pagehttps://github.com/nodejs/node/pull/50318
https://github.com/aduh95
fixup! test: ensure never settling promises are detectedhttps://github.com/nodejs/node/pull/50318/commits/d172c1b7f6226f2174aab2d2ff3db331eb72d465
d172c1bhttps://github.com/nodejs/node/pull/50318/commits/d172c1b7f6226f2174aab2d2ff3db331eb72d465
https://github.com/panva
panvahttps://github.com/panva
Oct 21, 2023 https://github.com/nodejs/node/pull/50318#pullrequestreview-1691346439
View reviewed changes https://github.com/nodejs/node/pull/50318/files/d172c1b7f6226f2174aab2d2ff3db331eb72d465
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 22, 2023 https://github.com/nodejs/node/pull/50318#ref-issue-1955705755
CI Reliability 2023-10-22 nodejs/reliability#694 https://github.com/nodejs/reliability/issues/694
https://github.com/aduh95
aduh95https://github.com/aduh95
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 22, 2023https://github.com/nodejs/node/pull/50318#event-10733090686
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 22, 2023https://github.com/nodejs/node/pull/50318#event-10733102135
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 22, 2023https://github.com/nodejs/node/pull/50318#issuecomment-1774077694
https://ci.nodejs.org/job/node-test-pull-request/55117/https://ci.nodejs.org/job/node-test-pull-request/55117/
Please reload this pagehttps://github.com/nodejs/node/pull/50318
https://github.com/lpinca
lpincahttps://github.com/lpinca
Oct 22, 2023 https://github.com/nodejs/node/pull/50318#pullrequestreview-1691485277
View reviewed changes https://github.com/nodejs/node/pull/50318/files/d172c1b7f6226f2174aab2d2ff3db331eb72d465
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 22, 2023https://github.com/nodejs/node/pull/50318#issuecomment-1774187538
https://ci.nodejs.org/job/node-test-pull-request/55133/https://ci.nodejs.org/job/node-test-pull-request/55133/
Please reload this pagehttps://github.com/nodejs/node/pull/50318
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 23, 2023 https://github.com/nodejs/node/pull/50318#ref-issue-1956113915
CI Reliability 2023-10-23 nodejs/reliability#695 https://github.com/nodejs/reliability/issues/695
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 23, 2023https://github.com/nodejs/node/pull/50318#issuecomment-1775616091
https://ci.nodejs.org/job/node-test-pull-request/55156/https://ci.nodejs.org/job/node-test-pull-request/55156/
Please reload this pagehttps://github.com/nodejs/node/pull/50318
https://github.com/aduh95
aduh95https://github.com/aduh95
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 23, 2023https://github.com/nodejs/node/pull/50318#event-10744126197
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 23, 2023https://github.com/nodejs/node/pull/50318#event-10744283422
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
8f742bbhttps://github.com/nodejs/node/commit/8f742bb13fabae976f7dea475bf64adb327fb2d5
Oct 23, 2023https://github.com/nodejs/node/pull/50318#event-10744284589
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 23, 2023https://github.com/nodejs/node/pull/50318#issuecomment-1775722897
8f742bbhttps://github.com/nodejs/node/commit/8f742bb13fabae976f7dea475bf64adb327fb2d5
Please reload this pagehttps://github.com/nodejs/node/pull/50318
https://github.com/aduh95
aduh95https://github.com/aduh95
October 23, 2023 18:29https://github.com/nodejs/node/pull/50318#event-10744658476
CI Reliability 2023-10-24 nodejs/reliability#696 https://github.com/nodejs/reliability/issues/696
CI Reliability 2023-10-25 nodejs/reliability#697 https://github.com/nodejs/reliability/issues/697
alexfernandezhttps://github.com/alexfernandez
Nov 1, 2023 https://github.com/nodejs/node/pull/50318#ref-commit-583ef77
https://github.com/aduh95
https://github.com/alexfernandez
test: ensure never settling promises are detectedhttps://github.com/alexfernandez/node/commit/583ef772eb303a41d5c413bac7d46cde9dd3dc55
583ef77https://github.com/alexfernandez/node/commit/583ef772eb303a41d5c413bac7d46cde9dd3dc55
nodejs#50318https://github.com/nodejs/node/pull/50318
targoshttps://github.com/targos
Nov 11, 2023 https://github.com/nodejs/node/pull/50318#ref-commit-31cd05c
https://github.com/aduh95
https://github.com/targos
test: ensure never settling promises are detectedhttps://github.com/nodejs/node/commit/31cd05c39fe42c0bf0c0671068585efa4e764dda
31cd05chttps://github.com/nodejs/node/commit/31cd05c39fe42c0bf0c0671068585efa4e764dda
#50318https://github.com/nodejs/node/pull/50318
https://github.com/targos
targoshttps://github.com/targos
Nov 12, 2023 https://github.com/nodejs/node/pull/50318#ref-pullrequest-1989278421
v21.2.0 release proposal #50681 https://github.com/nodejs/node/pull/50681
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Nov 21, 2023 https://github.com/nodejs/node/pull/50318#ref-pullrequest-1848777495
permission: do not create symlinks if target is relative #49156 https://github.com/nodejs/node/pull/49156
UlisesGasconhttps://github.com/UlisesGascon
Dec 11, 2023 https://github.com/nodejs/node/pull/50318#ref-commit-6c59114
https://github.com/aduh95
https://github.com/UlisesGascon
test: ensure never settling promises are detectedhttps://github.com/nodejs/node/commit/6c5911494710f9b24ca88089819ddda3b80e3afb
6c59114https://github.com/nodejs/node/commit/6c5911494710f9b24ca88089819ddda3b80e3afb
#50318https://github.com/nodejs/node/pull/50318
https://github.com/UlisesGascon
UlisesGasconhttps://github.com/UlisesGascon
Dec 12, 2023 https://github.com/nodejs/node/pull/50318#ref-pullrequest-2036750657
v20.11.0 proposal #51124 https://github.com/nodejs/node/pull/51124
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50318
https://github.com/panva
panva https://github.com/panva
https://github.com/nodejs/node/pull/50318/files/d172c1b7f6226f2174aab2d2ff3db331eb72d465
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/50318/files/d172c1b7f6226f2174aab2d2ff3db331eb72d465
https://github.com/anonrig
anonrig https://github.com/anonrig
https://github.com/nodejs/node/pull/50318/files/8b3d6494b6ecbc1b4d25b706e6c74b454090bc27
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/50318/files/8b3d6494b6ecbc1b4d25b706e6c74b454090bc27
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/50318/files/8b3d6494b6ecbc1b4d25b706e6c74b454090bc27
https://github.com/MoLow
MoLow https://github.com/MoLow
https://github.com/nodejs/node/pull/50318/files/8b3d6494b6ecbc1b4d25b706e6c74b454090bc27
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/50318
https://github.com/aduh95
https://github.com/nodejs-github-bot
https://github.com/panva
https://github.com/lpinca
https://github.com/anonrig
https://github.com/targos
https://github.com/cjihrig
https://github.com/MoLow
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.