René's URL Explorer Experiment


Title: src: use find instead of char-by-char in FromFilePath() by lemire · Pull Request #50288 · nodejs/node · GitHub

Open Graph Title: src: use find instead of char-by-char in FromFilePath() by lemire · Pull Request #50288 · nodejs/node

X Title: src: use find instead of char-by-char in FromFilePath() by lemire · Pull Request #50288 · nodejs/node

Description: In PR https://github.com/nodejs/node/pull/50253/files, an optimization was proposed for the FromFilePath() function. This function replaces every occurence of the '%' character by the string '%'....

Open Graph Description: In PR https://github.com/nodejs/node/pull/50253/files, an optimization was proposed for the FromFilePath() function. This function replaces every occurence of the '%' character by the strin...

X Description: In PR https://github.com/nodejs/node/pull/50253/files, an optimization was proposed for the FromFilePath() function. This function replaces every occurence of the '%' character by t...

Mail addresses
daniel@lemire.me

Opengraph URL: https://github.com/nodejs/node/pull/50288

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2863abaf-7387-6ddb-db68-826a3b0c6146
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEACE:6FDD1:645F74:864723:6969B658
html-safe-nonce3bd6c395fd03f88ab0cd38c403b81cd847aa0b27fa7996803db41939d54881ce
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQUNFOjZGREQxOjY0NUY3NDo4NjQ3MjM6Njk2OUI2NTgiLCJ2aXNpdG9yX2lkIjoiNDczMDc4NDU3ODU1MDc0MDU2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3e3fffce082579ce57302d85ef0536d39c016b077d8bf4ba94e38b3648f4008e
hovercard-subject-tagpull_request:1565060246
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/50288/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b22464ac336f808d313bef7ea09cd087084c81769c470a26e9717e76c61c12e0/nodejs/node/pull/50288
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b22464ac336f808d313bef7ea09cd087084c81769c470a26e9717e76c61c12e0/nodejs/node/pull/50288
og:image:altIn PR https://github.com/nodejs/node/pull/50253/files, an optimization was proposed for the FromFilePath() function. This function replaces every occurence of the '%' character by the strin...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelemire
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/50288#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50288
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50288
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/50288
Reloadhttps://github.com/nodejs/node/pull/50288
Reloadhttps://github.com/nodejs/node/pull/50288
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/50288
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/50288
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/50288#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
lemire:src_fromfilepathhttps://github.com/lemire/node/tree/src_fromfilepath
src: use find instead of char-by-char in FromFilePath() https://github.com/nodejs/node/pull/50288#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
lemire:src_fromfilepathhttps://github.com/lemire/node/tree/src_fromfilepath
Conversation 24 https://github.com/nodejs/node/pull/50288
Commits 6 https://github.com/nodejs/node/pull/50288/commits
Checks 0 https://github.com/nodejs/node/pull/50288/checks
Files changed https://github.com/nodejs/node/pull/50288/files
Please reload this pagehttps://github.com/nodejs/node/pull/50288
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/lemire
lemirehttps://github.com/lemire
Oct 19, 2023https://github.com/nodejs/node/pull/50288#issue-1952448270
Please reload this pagehttps://github.com/nodejs/node/pull/50288
https://github.com/nodejs/node/pull/50253/fileshttps://github.com/nodejs/node/pull/50253/files
For processing strings, streams in C++ can be slowhttps://lemire.me/blog/2023/10/19/for-processing-strings-streams-in-c-can-be-slow/
If you use my benchmarking codehttps://github.com/lemire/Code-used-on-Daniel-Lemire-s-blog/tree/master/2023/10/18
you can run your own benchmarkshttps://github.com/lemire/Code-used-on-Daniel-Lemire-s-blog/tree/master/2023/10/18
https://private-user-images.githubusercontent.com/391987/277179977-f93a880d-8465-4164-a11d-ac124fe43831.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njg1MzU5NDAsIm5iZiI6MTc2ODUzNTY0MCwicGF0aCI6Ii8zOTE5ODcvMjc3MTc5OTc3LWY5M2E4ODBkLTg0NjUtNDE2NC1hMTFkLWFjMTI0ZmU0MzgzMS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwMTE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDExNlQwMzU0MDBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mOWY5NThmNTk0MTEyOWFlMzBhZWNiZGY0YTVkNThmYjkyZDg5NjIwZDBmZmYwN2ZlYzNmYmI3MDE1NTUyNmM1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.ZJcunC1KEYkglKTsSyaIicxhVxbNPIF7l5bNLVqVjnU
You can benchmark this case using my codehttps://github.com/lemire/Code-used-on-Daniel-Lemire-s-blog/tree/master/2023/10/18
run your own benchmarkshttps://github.com/lemire/Code-used-on-Daniel-Lemire-s-blog/tree/master/2023/10/18
https://private-user-images.githubusercontent.com/391987/277180013-34c959fb-539b-4844-8e67-1f59f44fd188.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njg1MzU5NDAsIm5iZiI6MTc2ODUzNTY0MCwicGF0aCI6Ii8zOTE5ODcvMjc3MTgwMDEzLTM0Yzk1OWZiLTUzOWItNDg0NC04ZTY3LTFmNTlmNDRmZDE4OC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwMTE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDExNlQwMzU0MDBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03ZGZiYjRlOGM3MTFlMTViMDM4OTBjNTExZmMwMTM0MDE1OGVmMTE0MTBjNGNhOTY0YjgzYmU4ZDE0MTU5YjU1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.ZyUH-UUQ0z8xvb9pM3QH_E4RbwbyfUhCVHHrtwcE8xI
appending to an std::string, even character by character, has linear complexityhttps://lemire.me/blog/2023/10/23/appending-to-an-stdstring-character-by-character-how-does-the-capacity-grow/
Please reload this pagehttps://github.com/nodejs/node/pull/50288
lemirehttps://github.com/lemire
October 19, 2023 10:05https://github.com/nodejs/node/pull/50288#commits-pushed-3f4deaa
https://github.com/lemire
src: use find instead of char-by-char in FromFilePath()https://github.com/nodejs/node/pull/50288/commits/3f4deaae48fe9878cab682d3e7214eb3c2069f5c
3f4deaahttps://github.com/nodejs/node/pull/50288/commits/3f4deaae48fe9878cab682d3e7214eb3c2069f5c
https://github.com/lemire
fix typohttps://github.com/nodejs/node/pull/50288/commits/95e9f4c5f328b3c55d5ddc9b74dc5f77fb51a5b4
95e9f4chttps://github.com/nodejs/node/pull/50288/commits/95e9f4c5f328b3c55d5ddc9b74dc5f77fb51a5b4
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 19, 2023https://github.com/nodejs/node/pull/50288#issuecomment-1771146914
Please reload this pagehttps://github.com/nodejs/node/pull/50288
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
whatwg-url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awhatwg-url
Oct 19, 2023https://github.com/nodejs/node/pull/50288#event-10713212110
https://github.com/lemire
adding spacehttps://github.com/nodejs/node/pull/50288/commits/a61db5d18144802229e75c4e9e56ffa78809f9d4
a61db5dhttps://github.com/nodejs/node/pull/50288/commits/a61db5d18144802229e75c4e9e56ffa78809f9d4
https://github.com/anonrig
anonrighttps://github.com/anonrig
Oct 19, 2023 https://github.com/nodejs/node/pull/50288#pullrequestreview-1687989602
View reviewed changes https://github.com/nodejs/node/pull/50288/files/a61db5d18144802229e75c4e9e56ffa78809f9d4
https://github.com/anonrig
anonrighttps://github.com/anonrig
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
Oct 19, 2023https://github.com/nodejs/node/pull/50288#event-10713381184
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 19, 2023https://github.com/nodejs/node/pull/50288#event-10713481018
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 19, 2023https://github.com/nodejs/node/pull/50288#issuecomment-1771184545
https://ci.nodejs.org/job/node-test-pull-request/55004/https://ci.nodejs.org/job/node-test-pull-request/55004/
Please reload this pagehttps://github.com/nodejs/node/pull/50288
https://github.com/H4ad
H4adhttps://github.com/H4ad
Oct 19, 2023 https://github.com/nodejs/node/pull/50288#pullrequestreview-1688072007
View reviewed changes https://github.com/nodejs/node/pull/50288/files/a61db5d18144802229e75c4e9e56ffa78809f9d4
https://github.com/H4ad
H4adhttps://github.com/H4ad
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 19, 2023https://github.com/nodejs/node/pull/50288#event-10713873692
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 19, 2023https://github.com/nodejs/node/pull/50288#issuecomment-1771471858
https://ci.nodejs.org/job/node-test-pull-request/55020/https://ci.nodejs.org/job/node-test-pull-request/55020/
Please reload this pagehttps://github.com/nodejs/node/pull/50288
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Oct 19, 2023 https://github.com/nodejs/node/pull/50288#pullrequestreview-1688677236
View reviewed changes https://github.com/nodejs/node/pull/50288/files/a61db5d18144802229e75c4e9e56ffa78809f9d4
src/node_url.cchttps://github.com/nodejs/node/pull/50288/files/a61db5d18144802229e75c4e9e56ffa78809f9d4#diff-3ea8ea727fd1024465c848244a01d422fa4647b640ef6c91ee536bf5de6c86b7
Please reload this pagehttps://github.com/nodejs/node/pull/50288
src/node_url.cchttps://github.com/nodejs/node/pull/50288/files/a61db5d18144802229e75c4e9e56ffa78809f9d4#diff-3ea8ea727fd1024465c848244a01d422fa4647b640ef6c91ee536bf5de6c86b7
Please reload this pagehttps://github.com/nodejs/node/pull/50288
src/node_url.cchttps://github.com/nodejs/node/pull/50288/files/a61db5d18144802229e75c4e9e56ffa78809f9d4#diff-3ea8ea727fd1024465c848244a01d422fa4647b640ef6c91ee536bf5de6c86b7
Please reload this pagehttps://github.com/nodejs/node/pull/50288
lemirehttps://github.com/lemire
October 19, 2023 18:33https://github.com/nodejs/node/pull/50288#commits-pushed-8c6a185
https://github.com/lemire
https://github.com/tniessen
Update src/node_url.cchttps://github.com/nodejs/node/pull/50288/commits/8c6a185dc42b43daeb2b55e1af0e8b0165da628f
8c6a185https://github.com/nodejs/node/pull/50288/commits/8c6a185dc42b43daeb2b55e1af0e8b0165da628f
https://github.com/lemire
https://github.com/tniessen
Update src/node_url.cchttps://github.com/nodejs/node/pull/50288/commits/11d038f2243590da50a886ed4b43a781e919e0de
11d038fhttps://github.com/nodejs/node/pull/50288/commits/11d038f2243590da50a886ed4b43a781e919e0de
https://github.com/lemire
lemirehttps://github.com/lemire
Oct 19, 2023https://github.com/nodejs/node/pull/50288#issuecomment-1771801647
@tniessenhttps://github.com/tniessen
Please reload this pagehttps://github.com/nodejs/node/pull/50288
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Oct 19, 2023 https://github.com/nodejs/node/pull/50288#pullrequestreview-1688807848
View reviewed changes https://github.com/nodejs/node/pull/50288/files/11d038f2243590da50a886ed4b43a781e919e0de
https://github.com/anonrig
anonrighttps://github.com/anonrig
Oct 19, 2023 https://github.com/nodejs/node/pull/50288#pullrequestreview-1688817684
View reviewed changes https://github.com/nodejs/node/pull/50288/files/11d038f2243590da50a886ed4b43a781e919e0de
https://github.com/anonrig
anonrighttps://github.com/anonrig
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 19, 2023https://github.com/nodejs/node/pull/50288#event-10717722905
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 19, 2023https://github.com/nodejs/node/pull/50288#event-10717738850
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 19, 2023https://github.com/nodejs/node/pull/50288#issuecomment-1771816184
https://ci.nodejs.org/job/node-test-pull-request/55028/https://ci.nodejs.org/job/node-test-pull-request/55028/
Please reload this pagehttps://github.com/nodejs/node/pull/50288
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 20, 2023 https://github.com/nodejs/node/pull/50288#ref-issue-1953246911
CI Reliability 2023-10-20 nodejs/reliability#692 https://github.com/nodejs/reliability/issues/692
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 20, 2023https://github.com/nodejs/node/pull/50288#issuecomment-1773175499
https://ci.nodejs.org/job/node-test-pull-request/55066/https://ci.nodejs.org/job/node-test-pull-request/55066/
Please reload this pagehttps://github.com/nodejs/node/pull/50288
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 20, 2023https://github.com/nodejs/node/pull/50288#issuecomment-1773517049
https://ci.nodejs.org/job/node-test-pull-request/55069/https://ci.nodejs.org/job/node-test-pull-request/55069/
Please reload this pagehttps://github.com/nodejs/node/pull/50288
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 21, 2023 https://github.com/nodejs/node/pull/50288#ref-issue-1955151124
CI Reliability 2023-10-21 nodejs/reliability#693 https://github.com/nodejs/reliability/issues/693
https://github.com/eugeneo
eugeneohttps://github.com/eugeneo
Oct 21, 2023 https://github.com/nodejs/node/pull/50288#pullrequestreview-1691028466
View reviewed changes https://github.com/nodejs/node/pull/50288/files/11d038f2243590da50a886ed4b43a781e919e0de
src/node_url.cchttps://github.com/nodejs/node/pull/50288/files/11d038f2243590da50a886ed4b43a781e919e0de#diff-3ea8ea727fd1024465c848244a01d422fa4647b640ef6c91ee536bf5de6c86b7
Please reload this pagehttps://github.com/nodejs/node/pull/50288
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 21, 2023https://github.com/nodejs/node/pull/50288#issuecomment-1773601086
https://ci.nodejs.org/job/node-test-pull-request/55075/https://ci.nodejs.org/job/node-test-pull-request/55075/
Please reload this pagehttps://github.com/nodejs/node/pull/50288
https://github.com/lemire
simplifying by not setting pos to zero.https://github.com/nodejs/node/pull/50288/commits/ba7f31d180b5730deab0898d1239fa24d098c0d1
ba7f31dhttps://github.com/nodejs/node/pull/50288/commits/ba7f31d180b5730deab0898d1239fa24d098c0d1
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 22, 2023 https://github.com/nodejs/node/pull/50288#ref-issue-1955705755
CI Reliability 2023-10-22 nodejs/reliability#694 https://github.com/nodejs/reliability/issues/694
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Oct 22, 2023 https://github.com/nodejs/node/pull/50288#pullrequestreview-1691401960
View reviewed changes https://github.com/nodejs/node/pull/50288/files/ba7f31d180b5730deab0898d1239fa24d098c0d1
src/node_url.cchttps://github.com/nodejs/node/pull/50288/files/ba7f31d180b5730deab0898d1239fa24d098c0d1#diff-3ea8ea727fd1024465c848244a01d422fa4647b640ef6c91ee536bf5de6c86b7
bnoordhuishttps://github.com/bnoordhuis
Oct 22, 2023https://github.com/nodejs/node/pull/50288#discussion_r1367871439
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/50288
lemirehttps://github.com/lemire
Oct 22, 2023https://github.com/nodejs/node/pull/50288#discussion_r1367933312
Please reload this pagehttps://github.com/nodejs/node/pull/50288
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
You can benchmark this case using my codehttps://github.com/lemire/Code-used-on-Daniel-Lemire-s-blog/tree/master/2023/10/18
run your own benchmarkshttps://github.com/lemire/Code-used-on-Daniel-Lemire-s-blog/tree/master/2023/10/18
https://private-user-images.githubusercontent.com/391987/277178406-aced3e48-96fe-44ee-a5c6-2ebbb316d217.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njg1MzU5NDMsIm5iZiI6MTc2ODUzNTY0MywicGF0aCI6Ii8zOTE5ODcvMjc3MTc4NDA2LWFjZWQzZTQ4LTk2ZmUtNDRlZS1hNWM2LTJlYmJiMzE2ZDIxNy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwMTE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDExNlQwMzU0MDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0zNDYxMWJmMjM1ZTVkMmI0OGE2N2VkNDZmYTc0ZDA2OGNjZGFlZjQ0YzgyZDkzYjA5NzhhYWFmOTY4ZDIxMmY1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.Yl0hE8Cxs21nxEuB1jQTwJUpPJ1rxFQKf7NOzeAsxpY
Please reload this pagehttps://github.com/nodejs/node/pull/50288
lemirehttps://github.com/lemire
Oct 22, 2023https://github.com/nodejs/node/pull/50288#discussion_r1367936017
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/50288
bnoordhuishttps://github.com/bnoordhuis
Oct 24, 2023https://github.com/nodejs/node/pull/50288#discussion_r1369987496
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/50288
anonrighttps://github.com/anonrig
Oct 24, 2023https://github.com/nodejs/node/pull/50288#discussion_r1370147293
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/50288
lemirehttps://github.com/lemire
Oct 24, 2023https://github.com/nodejs/node/pull/50288#discussion_r1370245734
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://lemire.me/blog/2023/10/23/appending-to-an-stdstring-character-by-character-how-does-the-capacity-grow/https://lemire.me/blog/2023/10/23/appending-to-an-stdstring-character-by-character-how-does-the-capacity-grow/
@anonrighttps://github.com/anonrig
Please reload this pagehttps://github.com/nodejs/node/pull/50288
bnoordhuishttps://github.com/bnoordhuis
Oct 24, 2023https://github.com/nodejs/node/pull/50288#discussion_r1370468117
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/50288
lemirehttps://github.com/lemire
Oct 24, 2023https://github.com/nodejs/node/pull/50288#discussion_r1370587832
Please reload this pagehttps://github.com/nodejs/node/pull/50288
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
My blog post has an analysis, and even a benchmarkhttps://lemire.me/blog/2023/10/23/appending-to-an-stdstring-character-by-character-how-does-the-capacity-grow/
which is how C++ runtime libraries do ithttps://lemire.me/blog/2023/10/23/appending-to-an-stdstring-character-by-character-how-does-the-capacity-grow/
Please reload this pagehttps://github.com/nodejs/node/pull/50288
https://github.com/H4ad
H4adhttps://github.com/H4ad
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 22, 2023https://github.com/nodejs/node/pull/50288#event-10733636372
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 22, 2023https://github.com/nodejs/node/pull/50288#event-10733642269
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 22, 2023https://github.com/nodejs/node/pull/50288#issuecomment-1774143615
https://ci.nodejs.org/job/node-test-pull-request/55124/https://ci.nodejs.org/job/node-test-pull-request/55124/
Please reload this pagehttps://github.com/nodejs/node/pull/50288
CI Reliability 2023-10-23 nodejs/reliability#695 https://github.com/nodejs/reliability/issues/695
CI Reliability 2023-10-24 nodejs/reliability#696 https://github.com/nodejs/reliability/issues/696
https://github.com/anonrig
anonrighttps://github.com/anonrig
Oct 24, 2023 https://github.com/nodejs/node/pull/50288#pullrequestreview-1694824668
View reviewed changes https://github.com/nodejs/node/pull/50288/files/ba7f31d180b5730deab0898d1239fa24d098c0d1
https://github.com/anonrig
anonrighttps://github.com/anonrig
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 24, 2023https://github.com/nodejs/node/pull/50288#event-10757519485
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 24, 2023https://github.com/nodejs/node/pull/50288#event-10757608932
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c89bae1https://github.com/nodejs/node/commit/c89bae161b0e36c83ab07f09ed18b5da97285fec
Oct 24, 2023https://github.com/nodejs/node/pull/50288#event-10757610219
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 24, 2023https://github.com/nodejs/node/pull/50288#issuecomment-1777764154
c89bae1https://github.com/nodejs/node/commit/c89bae161b0e36c83ab07f09ed18b5da97285fec
Please reload this pagehttps://github.com/nodejs/node/pull/50288
alexfernandezhttps://github.com/alexfernandez
Nov 1, 2023 https://github.com/nodejs/node/pull/50288#ref-commit-a15e77a
https://github.com/lemire
https://github.com/alexfernandez
src: use find instead of char-by-char in FromFilePath()https://github.com/alexfernandez/node/commit/a15e77ab66755865483ed2f83da5900acaf96048
a15e77ahttps://github.com/alexfernandez/node/commit/a15e77ab66755865483ed2f83da5900acaf96048
nodejs#50288https://github.com/nodejs/node/pull/50288
targoshttps://github.com/targos
Nov 11, 2023 https://github.com/nodejs/node/pull/50288#ref-commit-f1d79b3
https://github.com/lemire
https://github.com/targos
src: use find instead of char-by-char in FromFilePath()https://github.com/nodejs/node/commit/f1d79b3cbbc4d7e4c691e04917dceb6e09f9c6ef
f1d79b3https://github.com/nodejs/node/commit/f1d79b3cbbc4d7e4c691e04917dceb6e09f9c6ef
#50288https://github.com/nodejs/node/pull/50288
https://github.com/targos
targoshttps://github.com/targos
Nov 12, 2023 https://github.com/nodejs/node/pull/50288#ref-pullrequest-1989278421
v21.2.0 release proposal #50681 https://github.com/nodejs/node/pull/50681
UlisesGasconhttps://github.com/UlisesGascon
Dec 11, 2023 https://github.com/nodejs/node/pull/50288#ref-commit-9346f15
https://github.com/lemire
https://github.com/UlisesGascon
src: use find instead of char-by-char in FromFilePath()https://github.com/nodejs/node/commit/9346f151380f2ad720f5283a56a3f51de6c6ed5c
9346f15https://github.com/nodejs/node/commit/9346f151380f2ad720f5283a56a3f51de6c6ed5c
#50288https://github.com/nodejs/node/pull/50288
https://github.com/UlisesGascon
UlisesGasconhttps://github.com/UlisesGascon
Dec 12, 2023 https://github.com/nodejs/node/pull/50288#ref-pullrequest-2036750657
v20.11.0 proposal #51124 https://github.com/nodejs/node/pull/51124
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50288
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/50288/files/ba7f31d180b5730deab0898d1239fa24d098c0d1
https://github.com/anonrig
anonrig https://github.com/anonrig
https://github.com/nodejs/node/pull/50288/files/ba7f31d180b5730deab0898d1239fa24d098c0d1
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/50288/files/11d038f2243590da50a886ed4b43a781e919e0de
https://github.com/H4ad
H4ad https://github.com/H4ad
https://github.com/nodejs/node/pull/50288/files/a61db5d18144802229e75c4e9e56ffa78809f9d4
https://github.com/eugeneo
eugeneo https://github.com/eugeneo
https://github.com/nodejs/node/pull/50288/files/11d038f2243590da50a886ed4b43a781e919e0de
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
whatwg-url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awhatwg-url
Please reload this pagehttps://github.com/nodejs/node/pull/50288
https://github.com/lemire
https://github.com/nodejs-github-bot
https://github.com/bnoordhuis
https://github.com/eugeneo
https://github.com/anonrig
https://github.com/tniessen
https://github.com/H4ad
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.