| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a2981a88-ade2-5ac1-576c-3f9ea8ee9bc1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B190:6114D:C1E434:109DFCF:6969EFBF |
| html-safe-nonce | 18abc2c04820ccff42d1767bd431877362ec08cc755f26eaf494862b87f5aa79 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTkwOjYxMTREOkMxRTQzNDoxMDlERkNGOjY5NjlFRkJGIiwidmlzaXRvcl9pZCI6IjU3NDM3NjY2MDgzMTU4MDU2MzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1647a56113c677653de58d396d3b2b0b21d9d1cd6ad0cf6fb1ceb641fd455d6b |
| hovercard-subject-tag | pull_request:1564832951 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/50282/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0bf5ae44b9bad18959302347914c1023a473d511651fc44f3d4e57890cff347c/nodejs/node/pull/50282 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0bf5ae44b9bad18959302347914c1023a473d511651fc44f3d4e57890cff347c/nodejs/node/pull/50282 |
| og:image:alt | Node.js PR #50282 - N-API Performance Improvement
This pull request aims to optimize the napi_set_property function to enhance the overall performance of Node-API. The changes include:
The signatu... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mertcanaltin |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/50282#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50282 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50282 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/50282 |
| Reload | https://github.com/nodejs/node/pull/50282 |
| Reload | https://github.com/nodejs/node/pull/50282 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/50282#issue-comment-box |
| mertcanaltin | https://github.com/mertcanaltin |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| mertcanaltin:49922-dev | https://github.com/mertcanaltin/node/tree/49922-dev |
|
node-api: refactor napi_set_property function for improved performance
| https://github.com/nodejs/node/pull/50282#top |
| mertcanaltin | https://github.com/mertcanaltin |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| mertcanaltin:49922-dev | https://github.com/mertcanaltin/node/tree/49922-dev |
|
Conversation
63
| https://github.com/nodejs/node/pull/50282 |
|
Commits
1
| https://github.com/nodejs/node/pull/50282/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/50282/checks |
|
Files changed
| https://github.com/nodejs/node/pull/50282/files |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| Oct 19, 2023 | https://github.com/nodejs/node/pull/50282#issue-1952190925 |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| #50282 | https://github.com/nodejs/node/pull/50282 |
| @vmoroz | https://github.com/vmoroz |
| #49922 | https://github.com/nodejs/node/issues/49922 |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 19, 2023 | https://github.com/nodejs/node/pull/50282#issuecomment-1770930497 |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Oct 19, 2023 | https://github.com/nodejs/node/pull/50282#event-10711610279 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
|
Oct 19, 2023
| https://github.com/nodejs/node/pull/50282#ref-issue-1917019375 |
|
Node-API performance
#49922
| https://github.com/nodejs/node/issues/49922 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| Oct 19, 2023 | https://github.com/nodejs/node/pull/50282#event-10715961344 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| force-pushed | https://github.com/nodejs/node/compare/c8f6bdb7b77126afd6c1ca30782a4f11ca84c1a4..3b5302d3683f0d796b7fa64f6e5362c10f42e07b |
| c8f6bdb | https://github.com/nodejs/node/commit/c8f6bdb7b77126afd6c1ca30782a4f11ca84c1a4 |
| 3b5302d | https://github.com/nodejs/node/commit/3b5302d3683f0d796b7fa64f6e5362c10f42e07b |
|
Compare
| https://github.com/nodejs/node/compare/c8f6bdb7b77126afd6c1ca30782a4f11ca84c1a4..3b5302d3683f0d796b7fa64f6e5362c10f42e07b |
| October 19, 2023 19:07 | https://github.com/nodejs/node/pull/50282#event-10715988617 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| RaisinTen | https://github.com/RaisinTen |
| Trott | https://github.com/Trott |
| October 19, 2023 19:08 | https://github.com/nodejs/node/pull/50282#event-10715991966 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| Oct 19, 2023 | https://github.com/nodejs/node/pull/50282#event-10716041580 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| force-pushed | https://github.com/nodejs/node/compare/1047cc3bc6bbb8649bffdd56183a51dd31de8f9c..f686b2ef1d91815c7391a1199294971a4c2a1fd0 |
| 1047cc3 | https://github.com/nodejs/node/commit/1047cc3bc6bbb8649bffdd56183a51dd31de8f9c |
| f686b2e | https://github.com/nodejs/node/commit/f686b2ef1d91815c7391a1199294971a4c2a1fd0 |
|
Compare
| https://github.com/nodejs/node/compare/1047cc3bc6bbb8649bffdd56183a51dd31de8f9c..f686b2ef1d91815c7391a1199294971a4c2a1fd0 |
| October 19, 2023 19:21 | https://github.com/nodejs/node/pull/50282#event-10716109500 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| Oct 19, 2023 | https://github.com/nodejs/node/pull/50282#event-10716110691 |
| https://github.com/vmoroz |
| vmoroz | https://github.com/vmoroz |
| Oct 27, 2023 | https://github.com/nodejs/node/pull/50282#issuecomment-1782978293 |
| @mertcanaltin | https://github.com/mertcanaltin |
| #45905 | https://github.com/nodejs/node/issues/45905 |
| #45905 (comment) | https://github.com/nodejs/node/issues/45905#issuecomment-1410822267 |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| Nov 3, 2023 | https://github.com/nodejs/node/pull/50282#issuecomment-1792875208 |
| @mertcanaltin | https://github.com/mertcanaltin |
| #45905 | https://github.com/nodejs/node/issues/45905 |
| #45905 (comment) | https://github.com/nodejs/node/issues/45905#issuecomment-1410822267 |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| vmoroz | https://github.com/vmoroz |
| November 6, 2023 15:26 | https://github.com/nodejs/node/pull/50282#event-10874665855 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| Nov 6, 2023 | https://github.com/nodejs/node/pull/50282#issuecomment-1795130251 |
| @vmoroz | https://github.com/vmoroz |
| #45905 | https://github.com/nodejs/node/issues/45905 |
| #50282 | https://github.com/nodejs/node/pull/50282 |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| https://github.com/vmoroz |
| vmoroz | https://github.com/vmoroz |
| Nov 6, 2023 | https://github.com/nodejs/node/pull/50282#issuecomment-1795317668 |
| @vmoroz | https://github.com/vmoroz |
| #45905 | https://github.com/nodejs/node/issues/45905 |
| #50282 | https://github.com/nodejs/node/pull/50282 |
| @mertcanaltin | https://github.com/mertcanaltin |
| #48339 | https://github.com/nodejs/node/pull/48339 |
| #48339 | https://github.com/nodejs/node/pull/48339 |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| Nov 6, 2023 | https://github.com/nodejs/node/pull/50282#issuecomment-1795500790 |
| @vmoroz | https://github.com/vmoroz |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| https://github.com/vmoroz |
| vmoroz | https://github.com/vmoroz |
| Nov 6, 2023 | https://github.com/nodejs/node/pull/50282#issuecomment-1795959780 |
| @vmoroz | https://github.com/vmoroz |
| #48339 | https://github.com/nodejs/node/pull/48339 |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| Nov 7, 2023 | https://github.com/nodejs/node/pull/50282#issuecomment-1798145973 |
| @vmoroz | https://github.com/vmoroz |
| #48339 | https://github.com/nodejs/node/pull/48339 |
| @vmoroz | https://github.com/vmoroz |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| https://github.com/vmoroz |
| vmoroz | https://github.com/vmoroz |
| Nov 10, 2023 | https://github.com/nodejs/node/pull/50282#issuecomment-1805912829 |
| @mertcanaltin | https://github.com/mertcanaltin |
| #48339 | https://github.com/nodejs/node/pull/48339 |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| Nov 12, 2023 | https://github.com/nodejs/node/pull/50282#issuecomment-1807128801 |
| @vmoroz | https://github.com/vmoroz |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| Nov 12, 2023 | https://github.com/nodejs/node/pull/50282#issuecomment-1807133100 |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| https://github.com/vmoroz |
| vmoroz | https://github.com/vmoroz |
| Nov 12, 2023 | https://github.com/nodejs/node/pull/50282#issuecomment-1807203932 |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| @mertcanaltin | https://github.com/mertcanaltin |
| #48339 | https://github.com/nodejs/node/pull/48339 |
| #48339 | https://github.com/nodejs/node/pull/48339 |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| Nov 13, 2023 | https://github.com/nodejs/node/pull/50282#issuecomment-1807954803 |
| @vmoroz | https://github.com/vmoroz |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
|
Nov 17, 2023
| https://github.com/nodejs/node/pull/50282#pullrequestreview-1737296893 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/50282/files |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/50282/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| test/js-native-api/test_string/test_string.c | https://github.com/nodejs/node/pull/50282/files#diff-d1a86fd46d37d89cfe11d51263e297286650db4b94f68e435d0b6b521912e9f1 |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| test/js-native-api/test_string/test_string.c | https://github.com/nodejs/node/pull/50282/files#diff-d1a86fd46d37d89cfe11d51263e297286650db4b94f68e435d0b6b521912e9f1 |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| test/js-native-api/test_string/test.js | https://github.com/nodejs/node/pull/50282/files#diff-f656b4412c8d0d5c30037b961599450a8975fefb888d8ccfe78fbca34ad7ba84 |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/50282/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| https://github.com/vmoroz |
| vmoroz | https://github.com/vmoroz |
|
Nov 17, 2023
| https://github.com/nodejs/node/pull/50282#pullrequestreview-1737342128 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/50282/files |
| test/js-native-api/test_string/test_string.c | https://github.com/nodejs/node/pull/50282/files#diff-d1a86fd46d37d89cfe11d51263e297286650db4b94f68e435d0b6b521912e9f1 |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| https://github.com/vmoroz |
| vmoroz | https://github.com/vmoroz |
|
Nov 17, 2023
| https://github.com/nodejs/node/pull/50282#pullrequestreview-1737356861 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/50282/files |
| test/js-native-api/test_string/test_string.c | https://github.com/nodejs/node/pull/50282/files#diff-d1a86fd46d37d89cfe11d51263e297286650db4b94f68e435d0b6b521912e9f1 |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| legendecas | https://github.com/legendecas |
| November 19, 2023 11:59 | https://github.com/nodejs/node/pull/50282#event-11003625712 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Dec 20, 2023 | https://github.com/nodejs/node/pull/50282#event-11304712968 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 20, 2023 | https://github.com/nodejs/node/pull/50282#issuecomment-1864758354 |
| https://ci.nodejs.org/job/node-test-pull-request/56411/ | https://ci.nodejs.org/job/node-test-pull-request/56411/ |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Dec 22, 2023
| https://github.com/nodejs/node/pull/50282#pullrequestreview-1794064095 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/50282/files |
| src/js_native_api_v8.cc | https://github.com/nodejs/node/pull/50282/files#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1 |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Dec 22, 2023 | https://github.com/nodejs/node/pull/50282#discussion_r1434787252 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| regular version | https://github.com/nodejs/node/blob/ba957a61f83365d9df7126c23a1c78c320061414/src/js_native_api_v8.cc#L1591-L1594 |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| mertcanaltin | https://github.com/mertcanaltin |
| Dec 22, 2023 | https://github.com/nodejs/node/pull/50282#discussion_r1434942578 |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @vmoroz | https://github.com/vmoroz |
| #48339 | https://github.com/nodejs/node/pull/48339 |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| vmoroz | https://github.com/vmoroz |
| Dec 22, 2023 | https://github.com/nodejs/node/pull/50282#discussion_r1435205781 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| test/js-native-api/test_string/test_string.c | https://github.com/nodejs/node/pull/50282/files#diff-d1a86fd46d37d89cfe11d51263e297286650db4b94f68e435d0b6b521912e9f1 |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| https://github.com/vmoroz |
| vmoroz | https://github.com/vmoroz |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Dec 22, 2023 | https://github.com/nodejs/node/pull/50282#event-11328056373 |
|
| https://github.com/mertcanaltin |
| node-api: optimize napi_set_property for improved performance | https://github.com/nodejs/node/pull/50282/commits/6a2792980c8e1207906f199235ae7b196f762aac |
| 6a27929 | https://github.com/nodejs/node/pull/50282/commits/6a2792980c8e1207906f199235ae7b196f762aac |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| force-pushed | https://github.com/nodejs/node/compare/70f4be54f3bd0f94eafed1dbbde5d6cbc723702b..6a2792980c8e1207906f199235ae7b196f762aac |
| 70f4be5 | https://github.com/nodejs/node/commit/70f4be54f3bd0f94eafed1dbbde5d6cbc723702b |
| 6a27929 | https://github.com/nodejs/node/commit/6a2792980c8e1207906f199235ae7b196f762aac |
|
Compare
| https://github.com/nodejs/node/compare/70f4be54f3bd0f94eafed1dbbde5d6cbc723702b..6a2792980c8e1207906f199235ae7b196f762aac |
| December 22, 2023 18:19 | https://github.com/nodejs/node/pull/50282#event-11328642445 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Dec 22, 2023 | https://github.com/nodejs/node/pull/50282#event-11328677087 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| Dec 22, 2023 | https://github.com/nodejs/node/pull/50282#issuecomment-1867964913 |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| https://github.com/vmoroz |
| vmoroz | https://github.com/vmoroz |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Dec 23, 2023 | https://github.com/nodejs/node/pull/50282#event-11331148296 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Dec 23, 2023 | https://github.com/nodejs/node/pull/50282#event-11331150545 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 23, 2023 | https://github.com/nodejs/node/pull/50282#issuecomment-1868325172 |
| https://ci.nodejs.org/job/node-test-pull-request/56483/ | https://ci.nodejs.org/job/node-test-pull-request/56483/ |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| Dec 30, 2023 | https://github.com/nodejs/node/pull/50282#issuecomment-1872526090 |
| @vmoroz | https://github.com/vmoroz |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| https://github.com/vmoroz |
| vmoroz | https://github.com/vmoroz |
| Dec 31, 2023 | https://github.com/nodejs/node/pull/50282#issuecomment-1873008854 |
| @vmoroz | https://github.com/vmoroz |
| @mertcanaltin | https://github.com/mertcanaltin |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 31, 2023 | https://github.com/nodejs/node/pull/50282#issuecomment-1873009151 |
| https://ci.nodejs.org/job/node-test-pull-request/56612/ | https://ci.nodejs.org/job/node-test-pull-request/56612/ |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 2, 2024 | https://github.com/nodejs/node/pull/50282#issuecomment-1874596368 |
| https://ci.nodejs.org/job/node-test-pull-request/56633/ | https://ci.nodejs.org/job/node-test-pull-request/56633/ |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 5, 2024 | https://github.com/nodejs/node/pull/50282#issuecomment-1878926859 |
| https://ci.nodejs.org/job/node-test-pull-request/56688/ | https://ci.nodejs.org/job/node-test-pull-request/56688/ |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| mhdawson | https://github.com/mhdawson |
|
Jan 5, 2024
| https://github.com/nodejs/node/pull/50282#ref-commit-59e7444 |
|
| https://github.com/mertcanaltin |
|
| https://github.com/mhdawson |
| node-api: optimize napi_set_property for perf | https://github.com/nodejs/node/commit/59e7444766c31db75a1a989872c369cfd86c822f |
| 59e7444 | https://github.com/nodejs/node/commit/59e7444766c31db75a1a989872c369cfd86c822f |
| #50282 | https://github.com/nodejs/node/pull/50282 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jan 5, 2024 | https://github.com/nodejs/node/pull/50282#issuecomment-1879181232 |
| 59e7444 | https://github.com/nodejs/node/commit/59e7444766c31db75a1a989872c369cfd86c822f |
| @mertcanaltin | https://github.com/mertcanaltin |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jan 5, 2024 | https://github.com/nodejs/node/pull/50282#event-11404643404 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| Jan 5, 2024 | https://github.com/nodejs/node/pull/50282#issuecomment-1879321462 |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
| marco-ippolito | https://github.com/marco-ippolito |
|
Jan 12, 2024
| https://github.com/nodejs/node/pull/50282#ref-commit-7ca2672 |
|
| https://github.com/mertcanaltin |
|
| https://github.com/marco-ippolito |
| node-api: optimize napi_set_property for perf | https://github.com/marco-ippolito/node/commit/7ca2672c30539b6fd3cafb7427c29e118a1011be |
| 7ca2672 | https://github.com/marco-ippolito/node/commit/7ca2672c30539b6fd3cafb7427c29e118a1011be |
| nodejs#50282 | https://github.com/nodejs/node/pull/50282 |
| Medhansh404 | https://github.com/Medhansh404 |
|
Jan 19, 2024
| https://github.com/nodejs/node/pull/50282#ref-commit-1340463 |
|
| https://github.com/mertcanaltin |
|
| https://github.com/Medhansh404 |
| node-api: optimize napi_set_property for perf | https://github.com/Medhansh404/node/commit/1340463e4cc8aa8f3b539a1284f85860de5d2ba5 |
| 1340463 | https://github.com/Medhansh404/node/commit/1340463e4cc8aa8f3b539a1284f85860de5d2ba5 |
| nodejs#50282 | https://github.com/nodejs/node/pull/50282 |
| targos | https://github.com/targos |
|
Feb 15, 2024
| https://github.com/nodejs/node/pull/50282#ref-commit-66c11f3 |
|
| https://github.com/mertcanaltin |
|
| https://github.com/targos |
| node-api: optimize napi_set_property for perf | https://github.com/nodejs/node/commit/66c11f31c31979987c0ccb1a36d774e443f046b2 |
| 66c11f3 | https://github.com/nodejs/node/commit/66c11f31c31979987c0ccb1a36d774e443f046b2 |
| #50282 | https://github.com/nodejs/node/pull/50282 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
|
Mar 1, 2024
| https://github.com/nodejs/node/pull/50282#ref-pullrequest-2162891978 |
|
v21.7.0 proposal
#51932
| https://github.com/nodejs/node/pull/51932 |
| richardlau | https://github.com/richardlau |
|
Mar 25, 2024
| https://github.com/nodejs/node/pull/50282#ref-commit-4e53feb |
|
| https://github.com/mertcanaltin |
|
| https://github.com/richardlau |
| node-api: optimize napi_set_property for perf | https://github.com/nodejs/node/commit/4e53feb9543b6cf2d89a3449e033a2833c682b4c |
| 4e53feb | https://github.com/nodejs/node/commit/4e53feb9543b6cf2d89a3449e033a2833c682b4c |
| #50282 | https://github.com/nodejs/node/pull/50282 |
| richardlau | https://github.com/richardlau |
|
Mar 25, 2024
| https://github.com/nodejs/node/pull/50282#ref-commit-242139f |
|
| https://github.com/mertcanaltin |
|
| https://github.com/richardlau |
| node-api: optimize napi_set_property for perf | https://github.com/nodejs/node/commit/242139fb98da1fa3ca7a21c23c5ad6e3698217be |
| 242139f | https://github.com/nodejs/node/commit/242139fb98da1fa3ca7a21c23c5ad6e3698217be |
| #50282 | https://github.com/nodejs/node/pull/50282 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Mar 25, 2024
| https://github.com/nodejs/node/pull/50282#ref-pullrequest-2206634908 |
|
v20.12.0 proposal
#52212
| https://github.com/nodejs/node/pull/52212 |
| https://github.com/vmoroz |
| vmoroz | https://github.com/vmoroz |
|
Jul 1, 2024
| https://github.com/nodejs/node/pull/50282#ref-pullrequest-2296157850 |
|
node-api: add support for UTF-8 and Latin-1 property keys
#52984
| https://github.com/nodejs/node/pull/52984 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50282 |
|
| https://github.com/vmoroz |
|
vmoroz
| https://github.com/vmoroz |
|
| https://github.com/nodejs/node/pull/50282/files/70f4be54f3bd0f94eafed1dbbde5d6cbc723702b |
|
| https://github.com/gabrielschulhof |
|
gabrielschulhof
| https://github.com/gabrielschulhof |
|
| https://github.com/nodejs/node/pull/50282/files/70f4be54f3bd0f94eafed1dbbde5d6cbc723702b |
|
| https://github.com/legendecas |
|
legendecas
| https://github.com/legendecas |
|
| https://github.com/nodejs/node/pull/50282/files/59b89fd872d6ea9dd633eb9eed80959b620205c6 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/50282/files/70e02d8bdf6ecf008c03e776b3438b02230496b9 |
|
| https://github.com/RaisinTen |
|
RaisinTen
| https://github.com/RaisinTen |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Please reload this page | https://github.com/nodejs/node/pull/50282 |
|
| https://github.com/mertcanaltin |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/vmoroz |
|
| https://github.com/mhdawson |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/legendecas |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |