| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:472315e1-e670-00d0-8325-47141120e16c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B444:34FA38:8ABE1:BAA76:6969B562 |
| html-safe-nonce | fb59f4bb00a88f3842fabea50072e276f0037132f38859f4f49e79685a4adc9b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDQ0OjM0RkEzODo4QUJFMTpCQUE3Njo2OTY5QjU2MiIsInZpc2l0b3JfaWQiOiI5NjM0NzU5Mjc3ODc0ODQ1MTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 0c9006c92b25b80fefbeab9a32807a0ea9ab636a3e1da118aa7095a3d4b9ab78 |
| hovercard-subject-tag | pull_request:1563918532 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/50268/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/8699a3d0bd1778950c884c845e3837173434615f47a92b96af7d418640597188/nodejs/node/pull/50268 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8699a3d0bd1778950c884c845e3837173434615f47a92b96af7d418640597188/nodejs/node/pull/50268 |
| og:image:alt | This backports:
esm: require braces for modules code #49657
Resolves #49657 (comment). |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | GeoffreyBooth |
| hostname | github.com |
| expected-hostname | github.com |
| None | b23b8fcc855cd29bb04d6c94aafa62d336bf44eefa8229444eecc968cad03aee |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 0672399d88424758731ec07fe24509e23bb17fb5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/50268#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50268 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50268 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/50268 |
| Reload | https://github.com/nodejs/node/pull/50268 |
| Reload | https://github.com/nodejs/node/pull/50268 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/50268 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/50268 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/50268#issue-comment-box |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| nodejs:v20.x-staging | https://github.com/nodejs/node/tree/v20.x-staging |
| GeoffreyBooth:backport-49657-to-20 | https://github.com/GeoffreyBooth/node/tree/backport-49657-to-20 |
|
[v20.x backport] backport: esm: require braces for modules code
| https://github.com/nodejs/node/pull/50268#top |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| nodejs:v20.x-staging | https://github.com/nodejs/node/tree/v20.x-staging |
| GeoffreyBooth:backport-49657-to-20 | https://github.com/GeoffreyBooth/node/tree/backport-49657-to-20 |
|
Conversation
6
| https://github.com/nodejs/node/pull/50268 |
|
Commits
1
| https://github.com/nodejs/node/pull/50268/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/50268/checks |
|
Files changed
| https://github.com/nodejs/node/pull/50268/files |
| Please reload this page | https://github.com/nodejs/node/pull/50268 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| Oct 19, 2023 | https://github.com/nodejs/node/pull/50268#issue-1951163798 |
| Please reload this page | https://github.com/nodejs/node/pull/50268 |
| esm: require braces for modules code #49657 | https://github.com/nodejs/node/pull/49657 |
| #49657 (comment) | https://github.com/nodejs/node/pull/49657#issuecomment-1738356257 |
| Please reload this page | https://github.com/nodejs/node/pull/50268 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| ruyadorno | https://github.com/ruyadorno |
| October 19, 2023 04:12 | https://github.com/nodejs/node/pull/50268#event-10703246096 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 19, 2023 | https://github.com/nodejs/node/pull/50268#issuecomment-1769860995 |
| Please reload this page | https://github.com/nodejs/node/pull/50268 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
v20.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av20.x |
| Oct 19, 2023 | https://github.com/nodejs/node/pull/50268#event-10703247275 |
|
| https://github.com/GeoffreyBooth |
| esm: require braces for modules code | https://github.com/nodejs/node/pull/50268/commits/83e582a205655bb64f25c22b54584e5c9b0e9bb7 |
| 83e582a | https://github.com/nodejs/node/pull/50268/commits/83e582a205655bb64f25c22b54584e5c9b0e9bb7 |
| nodejs#49657 | https://github.com/nodejs/node/pull/49657 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| force-pushed | https://github.com/nodejs/node/compare/fc934ada9067d36af04b960bc7eb566382b5656d..83e582a205655bb64f25c22b54584e5c9b0e9bb7 |
| fc934ad | https://github.com/nodejs/node/commit/fc934ada9067d36af04b960bc7eb566382b5656d |
| 83e582a | https://github.com/nodejs/node/commit/83e582a205655bb64f25c22b54584e5c9b0e9bb7 |
|
Compare
| https://github.com/nodejs/node/compare/fc934ada9067d36af04b960bc7eb566382b5656d..83e582a205655bb64f25c22b54584e5c9b0e9bb7 |
| October 19, 2023 04:18 | https://github.com/nodejs/node/pull/50268#event-10703272726 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| Oct 19, 2023 | https://github.com/nodejs/node/pull/50268#event-10703274142 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Oct 19, 2023 | https://github.com/nodejs/node/pull/50268#event-10703274814 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 19, 2023 | https://github.com/nodejs/node/pull/50268#issuecomment-1769865268 |
| https://ci.nodejs.org/job/node-test-pull-request/54990/ | https://ci.nodejs.org/job/node-test-pull-request/54990/ |
| Please reload this page | https://github.com/nodejs/node/pull/50268 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| Oct 19, 2023 | https://github.com/nodejs/node/pull/50268#event-10703298267 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Oct 19, 2023
| https://github.com/nodejs/node/pull/50268#pullrequestreview-1686847703 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/50268/files/83e582a205655bb64f25c22b54584e5c9b0e9bb7 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
|
Oct 19, 2023
| https://github.com/nodejs/node/pull/50268#pullrequestreview-1686950647 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/50268/files/83e582a205655bb64f25c22b54584e5c9b0e9bb7 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Oct 19, 2023
| https://github.com/nodejs/node/pull/50268#pullrequestreview-1687097031 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/50268/files/83e582a205655bb64f25c22b54584e5c9b0e9bb7 |
| .eslintrc.js | https://github.com/nodejs/node/pull/50268/files/83e582a205655bb64f25c22b54584e5c9b0e9bb7#diff-e2954b558f2aa82baff0e30964490d12942e0e251c1aa56c3294de6ec67b7cf5 |
| aduh95 | https://github.com/aduh95 |
| Oct 19, 2023 | https://github.com/nodejs/node/pull/50268#discussion_r1365150335 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/50268 |
| targos | https://github.com/targos |
| Oct 19, 2023 | https://github.com/nodejs/node/pull/50268#discussion_r1365234392 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/50268 |
| aduh95 | https://github.com/aduh95 |
| Oct 19, 2023 | https://github.com/nodejs/node/pull/50268#discussion_r1365560780 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/50268 |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| Oct 19, 2023 | https://github.com/nodejs/node/pull/50268#discussion_r1365792499 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| src: throw DataCloneError on transfering untransferable objects #47604 | https://github.com/nodejs/node/pull/47604 |
| esm: remove globalPreload hook (superseded by initialize) #49144 | https://github.com/nodejs/node/pull/49144 |
| @aduh95 | https://github.com/aduh95 |
| Please reload this page | https://github.com/nodejs/node/pull/50268 |
|
CI Reliability 2023-10-20
nodejs/reliability#692
| https://github.com/nodejs/reliability/issues/692 |
|
CI Reliability 2023-10-21
nodejs/reliability#693
| https://github.com/nodejs/reliability/issues/693 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Nov 11, 2023 | https://github.com/nodejs/node/pull/50268#issuecomment-1806871198 |
| 0103979 | https://github.com/nodejs/node/commit/01039795a2aaa4e59e83160ab728b53375e8aab0 |
| Please reload this page | https://github.com/nodejs/node/pull/50268 |
| targos | https://github.com/targos |
|
Nov 11, 2023
| https://github.com/nodejs/node/pull/50268#ref-commit-0103979 |
|
| https://github.com/GeoffreyBooth |
|
| https://github.com/targos |
| esm: require braces for modules code | https://github.com/nodejs/node/commit/01039795a2aaa4e59e83160ab728b53375e8aab0 |
| 0103979 | https://github.com/nodejs/node/commit/01039795a2aaa4e59e83160ab728b53375e8aab0 |
| #49657 | https://github.com/nodejs/node/pull/49657 |
| #50268 | https://github.com/nodejs/node/pull/50268 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Nov 11, 2023 | https://github.com/nodejs/node/pull/50268#event-10932840450 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50268 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/50268/files/83e582a205655bb64f25c22b54584e5c9b0e9bb7 |
|
| https://github.com/aduh95 |
|
aduh95
| https://github.com/aduh95 |
|
| https://github.com/nodejs/node/pull/50268/files/83e582a205655bb64f25c22b54584e5c9b0e9bb7 |
|
| https://github.com/JakobJingleheimer |
|
JakobJingleheimer
| https://github.com/JakobJingleheimer |
|
| https://github.com/nodejs/node/pull/50268/files/83e582a205655bb64f25c22b54584e5c9b0e9bb7 |
|
| https://github.com/ruyadorno |
|
ruyadorno
| https://github.com/ruyadorno |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
v20.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av20.x |
| Please reload this page | https://github.com/nodejs/node/pull/50268 |
|
| https://github.com/GeoffreyBooth |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/targos |
|
| https://github.com/JakobJingleheimer |
|
| https://github.com/aduh95 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |