| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ba2a4606-b572-c7c3-671f-0cad881d1052 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B200:3463DE:26E407C:35CF48D:6A4F51C7 |
| html-safe-nonce | 1e50f1e4321f99ea1bd0c22d78044e111fd593c68f85a17655efa22ecdd791cc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjAwOjM0NjNERToyNkU0MDdDOjM1Q0Y0OEQ6NkE0RjUxQzciLCJ2aXNpdG9yX2lkIjoiODA1MTc5NTQ4OTYxMDIyNDA3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 39701a6312f515d5e9c2f222b25cc4f18b5a5f5045e01efbc8dd8a0ba4aab335 |
| hovercard-subject-tag | pull_request:57822817 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/5023/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b280eea4b9f0a244d857c12704337aab6e3abc1976ae10bee99b9dea94b045e9/nodejs/node/pull/5023 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b280eea4b9f0a244d857c12704337aab6e3abc1976ae10bee99b9dea94b045e9/nodejs/node/pull/5023 |
| og:image:alt | Ref: #4640.
As mentioned in the above issue, some of the files have TODO, FIXME and XXX comments which should be removed. This is one of them. The comment(which is to be removed) says, "a libu... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | aayn |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/5023#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5023 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5023 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/5023 |
| Reload | https://github.com/nodejs/node/pull/5023 |
| Reload | https://github.com/nodejs/node/pull/5023 |
| Please reload this page | https://github.com/nodejs/node/pull/5023 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/5023 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
970
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| aayn | https://github.com/aayn |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| aayn:master | https://github.com/aayn/node/tree/master |
| Conversation | https://github.com/nodejs/node/pull/5023 |
| Commits1 (1) | https://github.com/nodejs/node/pull/5023/commits |
| Checks | https://github.com/nodejs/node/pull/5023/checks |
| Files changed | https://github.com/nodejs/node/pull/5023/files |
| test: remove an unnecessary call to bind and related comments | https://github.com/nodejs/node/pull/5023#top |
| aayn | https://github.com/aayn |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| aayn:master | https://github.com/aayn/node/tree/master |
|
| https://github.com/aayn |
| aayn | https://github.com/aayn |
| Feb 1, 2016 | https://github.com/nodejs/node/pull/5023#issue-130326338 |
| #4640 | https://github.com/nodejs/node/issues/4640 |
| @Trott | https://github.com/Trott |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/5023 |
|
| https://github.com/aayn |
| test: remove an unnecessary call to bind and related comments | https://github.com/nodejs/node/pull/5023/commits/7063d19d866dfe14fa57b5eb3dfcdc0a4520dea9 |
| 7063d19 | https://github.com/nodejs/node/pull/5023/commits/7063d19d866dfe14fa57b5eb3dfcdc0a4520dea9 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Feb 1, 2016 | https://github.com/nodejs/node/pull/5023#event-534164044 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
dgram
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adgram |
| Feb 1, 2016 | https://github.com/nodejs/node/pull/5023#event-534378974 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Feb 1, 2016 | https://github.com/nodejs/node/pull/5023#issuecomment-178085889 |
| @saghul | https://github.com/saghul |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/5023 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Feb 1, 2016 | https://github.com/nodejs/node/pull/5023#event-534527449 |
| https://github.com/saghul |
| saghul | https://github.com/saghul |
| Feb 2, 2016 | https://github.com/nodejs/node/pull/5023#issuecomment-178438608 |
| https://github.com/nodejs/node/blob/master/src/udp_wrap.cc#L70 | https://github.com/nodejs/node/blob/master/src/udp_wrap.cc#L70 |
| https://github.com/nodejs/node/blob/master/lib/dgram.js#L41 | https://github.com/nodejs/node/blob/master/lib/dgram.js#L41 |
| https://github.com/nodejs/node/blob/master/src/udp_wrap.cc#L71 | https://github.com/nodejs/node/blob/master/src/udp_wrap.cc#L71 |
| Please reload this page | https://github.com/nodejs/node/pull/5023 |
| https://github.com/aayn |
| aayn | https://github.com/aayn |
| Feb 2, 2016 | https://github.com/nodejs/node/pull/5023#issuecomment-178582828 |
| @saghul | https://github.com/saghul |
| Please reload this page | https://github.com/nodejs/node/pull/5023 |
| https://github.com/saghul |
| saghul | https://github.com/saghul |
| Feb 2, 2016 | https://github.com/nodejs/node/pull/5023#issuecomment-178613980 |
| here | https://github.com/nodejs/node/blob/master/src/udp_wrap.cc#L71 |
| this line | https://github.com/nodejs/node/blob/master/lib/dgram.js#L43 |
| Please reload this page | https://github.com/nodejs/node/pull/5023 |
| https://github.com/aayn |
| aayn | https://github.com/aayn |
| Feb 2, 2016 | https://github.com/nodejs/node/pull/5023#issuecomment-178636871 |
| @saghul | https://github.com/saghul |
| here | https://github.com/nodejs/node/blob/master/src/udp_wrap.cc#L70 |
| here | http://docs.libuv.org/en/v1.x/tcp.html#c.uv_tcp_init_ex |
| here | https://github.com/nodejs/node/blob/master/src/udp_wrap.cc#L71 |
| Please reload this page | https://github.com/nodejs/node/pull/5023 |
| https://github.com/saghul |
| saghul | https://github.com/saghul |
| Feb 2, 2016 | https://github.com/nodejs/node/pull/5023#issuecomment-178641502 |
| Please reload this page | https://github.com/nodejs/node/pull/5023 |
| https://github.com/aayn |
| aayn | https://github.com/aayn |
| Feb 3, 2016 | https://github.com/nodejs/node/pull/5023#issuecomment-179010873 |
| Please reload this page | https://github.com/nodejs/node/pull/5023 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Feb 27, 2016 | https://github.com/nodejs/node/pull/5023#issuecomment-189750471 |
| @saghul | https://github.com/saghul |
| Please reload this page | https://github.com/nodejs/node/pull/5023 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Feb 27, 2016
| https://github.com/nodejs/node/pull/5023#ref-issue-126102325 |
|
TODO/XXX/FIXME comments in tests
#4640
| https://github.com/nodejs/node/issues/4640 |
| https://github.com/saghul |
| saghul | https://github.com/saghul |
| Feb 28, 2016 | https://github.com/nodejs/node/pull/5023#issuecomment-189848318 |
| @Trott | https://github.com/Trott |
| here | https://github.com/nodejs/node/pull/5023#issuecomment-178438608 |
| Please reload this page | https://github.com/nodejs/node/pull/5023 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Feb 28, 2016 | https://github.com/nodejs/node/pull/5023#issuecomment-189955914 |
| @saghul | https://github.com/saghul |
| Please reload this page | https://github.com/nodejs/node/pull/5023 |
| https://github.com/saghul |
| saghul | https://github.com/saghul |
| Feb 29, 2016 | https://github.com/nodejs/node/pull/5023#issuecomment-190077661 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/5023 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Feb 29, 2016 | https://github.com/nodejs/node/pull/5023#issuecomment-190407311 |
| @saghul | https://github.com/saghul |
| Please reload this page | https://github.com/nodejs/node/pull/5023 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Feb 29, 2016
| https://github.com/nodejs/node/pull/5023#ref-issue-137385926 |
|
dgram: instantiate socket on creation
#5496
| https://github.com/nodejs/node/issues/5496 |
| https://github.com/saghul |
| saghul | https://github.com/saghul |
| Feb 29, 2016 | https://github.com/nodejs/node/pull/5023#issuecomment-190415787 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/5023 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Feb 29, 2016 | https://github.com/nodejs/node/pull/5023#issuecomment-190417478 |
| @saghul | https://github.com/saghul |
| the subsequent .send() | https://github.com/aayn/node/blob/master/test/internet/test-dgram-multicast-multi-process.js#L156-L169 |
| Please reload this page | https://github.com/nodejs/node/pull/5023 |
| https://github.com/saghul |
| saghul | https://github.com/saghul |
| Feb 29, 2016 | https://github.com/nodejs/node/pull/5023#issuecomment-190438526 |
| @saghul | https://github.com/saghul |
| https://github.com/saghul | https://github.com/saghul |
| https://github.com/aayn/node/blob/master/test/internet/test-dgram-multicast-multi-process.js#L156-L169 | https://github.com/aayn/node/blob/master/test/internet/test-dgram-multicast-multi-process.js#L156-L169 |
| #5023 (comment) | https://github.com/nodejs/node/pull/5023#issuecomment-190417478 |
| Please reload this page | https://github.com/nodejs/node/pull/5023 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Feb 29, 2016 | https://github.com/nodejs/node/pull/5023#issuecomment-190450195 |
| https://ci.nodejs.org/job/node-test-pull-request/1784/ | https://ci.nodejs.org/job/node-test-pull-request/1784/ |
| Please reload this page | https://github.com/nodejs/node/pull/5023 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5023#issuecomment-190457700 |
| Please reload this page | https://github.com/nodejs/node/pull/5023 |
| Trott | https://github.com/Trott |
|
Mar 1, 2016
| https://github.com/nodejs/node/pull/5023#ref-commit-93bacfd |
|
| https://github.com/aayn |
|
| https://github.com/Trott |
| test: remove unneeded bind() and related comments | https://github.com/Trott/io.js/commit/93bacfd00fd04d5c219fb392382250d96bb3a7be |
| 93bacfd | https://github.com/Trott/io.js/commit/93bacfd00fd04d5c219fb392382250d96bb3a7be |
| nodejs#5023 | https://github.com/nodejs/node/pull/5023 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5023#issuecomment-190459782 |
| 93bacfd | https://github.com/nodejs/node/commit/93bacfd00fd04d5c219fb392382250d96bb3a7be |
| @aayn | https://github.com/aayn |
| Please reload this page | https://github.com/nodejs/node/pull/5023 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5023#event-572137471 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Mar 1, 2016
| https://github.com/nodejs/node/pull/5023#ref-pullrequest-136885682 |
|
Release proposal: v5.7.1
#5464
| https://github.com/nodejs/node/pull/5464 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Mar 2, 2016
| https://github.com/nodejs/node/pull/5023#ref-commit-c7f8a13 |
|
| https://github.com/aayn |
|
| https://github.com/Fishrock123 |
| test: remove unneeded bind() and related comments | https://github.com/nodejs/node/commit/c7f8a130431e85cb498f3181019477f0be8fc482 |
| c7f8a13 | https://github.com/nodejs/node/commit/c7f8a130431e85cb498f3181019477f0be8fc482 |
| #5023 | https://github.com/nodejs/node/pull/5023 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 17, 2016
| https://github.com/nodejs/node/pull/5023#ref-commit-12eae07 |
|
| https://github.com/aayn |
| test: remove unneeded bind() and related comments | https://github.com/nodejs/node/commit/12eae0721ebf34032aac7c2336b84917db1c9a73 |
| 12eae07 | https://github.com/nodejs/node/commit/12eae0721ebf34032aac7c2336b84917db1c9a73 |
| #5023 | https://github.com/nodejs/node/pull/5023 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x |
| Mar 17, 2016 | https://github.com/nodejs/node/pull/5023#event-593790064 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Mar 17, 2016 | https://github.com/nodejs/node/pull/5023#event-593790065 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 21, 2016
| https://github.com/nodejs/node/pull/5023#ref-commit-6386f62 |
|
| https://github.com/aayn |
| test: remove unneeded bind() and related comments | https://github.com/nodejs/node/commit/6386f6222172267eef9426d4d73ea489e17158e7 |
| 6386f62 | https://github.com/nodejs/node/commit/6386f6222172267eef9426d4d73ea489e17158e7 |
| #5023 | https://github.com/nodejs/node/pull/5023 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5023 |
|
dgram
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adgram |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/5023 |
|
| https://github.com/aayn |
|
| https://github.com/jasnell |
|
| https://github.com/saghul |
|
| https://github.com/Trott |
|
| https://github.com/mscdex |
|
| https://github.com/ChALkeR |
|
| https://github.com/MylesBorins |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |