René's URL Explorer Experiment


Title: Adding Core support for Promises by chrisdickinson · Pull Request #5020 · nodejs/node · GitHub

Open Graph Title: Adding Core support for Promises by chrisdickinson · Pull Request #5020 · nodejs/node

X Title: Adding Core support for Promises by chrisdickinson · Pull Request #5020 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Update 02/02/16 15:07:00 PST: Current state of the PR. Update 02/01/16 14:10:00 PST: Current state of the PR. Newcomers: As a heads up, GitHub has started clipping the thread down. I'm going to...

X Description: Update 02/02/16 15:07:00 PST: Current state of the PR. Update 02/01/16 14:10:00 PST: Current state of the PR. Newcomers: As a heads up, GitHub has started clipping the thread down. I'm goin...

Opengraph URL: https://github.com/nodejs/node/pull/5020

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:bf6deb6b-d0e2-28cd-776a-4d87b62cc83d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB8C4:1516D2:30C74:421C8:6A4D2826
html-safe-nonced272d214c2033acfeafc9ef3b9b1ae4bb8a407e58e313f62ad9064cfda24492e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOEM0OjE1MTZEMjozMEM3NDo0MjFDODo2QTREMjgyNiIsInZpc2l0b3JfaWQiOiIyODIzNDA4ODY1MzQwMzY4OTM0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacceb398b31e19b717576c99030cfdfaddd869c4e913b1253002c7e987dc2ea797
hovercard-subject-tagpull_request:57815240
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/5020/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/37f04b49fd93233efdebb0e57f4a754f820b2ce3f2f219a7c7e8ace13cb43d64/nodejs/node/pull/5020
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/37f04b49fd93233efdebb0e57f4a754f820b2ce3f2f219a7c7e8ace13cb43d64/nodejs/node/pull/5020
og:image:altUpdate 02/02/16 15:07:00 PST: Current state of the PR. Update 02/01/16 14:10:00 PST: Current state of the PR. Newcomers: As a heads up, GitHub has started clipping the thread down. I'm going to...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamechrisdickinson
hostnamegithub.com
expected-hostnamegithub.com
None92571a8944142227b7e19cd10918b1ddd06e5066c1ad5bc7e4769cf6140a87e6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release93f17a978ee60bc4668e1d7b90e6bd2d622261fd
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/5020#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5020
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5020
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/5020
Reloadhttps://github.com/nodejs/node/pull/5020
Reloadhttps://github.com/nodejs/node/pull/5020
Please reload this pagehttps://github.com/nodejs/node/pull/5020
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/5020
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 956 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
chrisdickinsonhttps://github.com/chrisdickinson
nodejs:masterhttps://github.com/nodejs/node/tree/master
chrisdickinson:promiseshttps://github.com/chrisdickinson/node-1/tree/promises
Conversationhttps://github.com/nodejs/node/pull/5020
Commits33 (33)https://github.com/nodejs/node/pull/5020/commits
Checkshttps://github.com/nodejs/node/pull/5020/checks
Files changedhttps://github.com/nodejs/node/pull/5020/files
Adding Core support for Promiseshttps://github.com/nodejs/node/pull/5020#top
chrisdickinsonhttps://github.com/chrisdickinson
nodejs:masterhttps://github.com/nodejs/node/tree/master
chrisdickinson:promiseshttps://github.com/chrisdickinson/node-1/tree/promises
https://github.com/chrisdickinson
chrisdickinsonhttps://github.com/chrisdickinson
Feb 1, 2016https://github.com/nodejs/node/pull/5020#issue-130309320
Current state of the PR.https://github.com/nodejs/node/pull/5020#issuecomment-178876755
Current state of the PR.https://github.com/nodejs/node/pull/5020#issuecomment-178223110
started clipping the thread downhttps://cloud.githubusercontent.com/assets/37303/12769711/ea7538ce-c9ce-11e5-8762-d24798047a48.png
summed up herehttps://github.com/nodejs/node/pull/5020#issuecomment-178112150
@phpnodehttps://github.com/phpnode
that it could break existing users of bluebird.promisifyAllhttps://github.com/nodejs/node/pull/5020#issuecomment-178236803
contentioushttps://github.com/nodejs/node/pull/5020#issuecomment-177889777
@jasnellhttps://github.com/jasnell
deep discomforthttps://github.com/nodejs/node/pull/5020#discussion_r51464838
herehttps://github.com/nodejs/node/pull/5020#issuecomment-178189824
@rvagghttps://github.com/rvagg
What are the killer arguments for including this, what is the value in adding this vs. leaving it userland?https://github.com/nodejs/node/pull/5020#issuecomment-178361191
@domenichttps://github.com/domenic
async/await is spec'd and roadmappedhttps://github.com/nodejs/node/pull/5020#issuecomment-178367909
My responsehttps://github.com/nodejs/node/pull/5020#issuecomment-178402443
@mikealhttps://github.com/mikeal
that promises are part of the platform already, and that adding support increases the base of folks willing to help fix bugs with in interoperation with themhttps://github.com/nodejs/node/pull/5020#issuecomment-178727217
@rvagghttps://github.com/rvagg
asks for clarification on the valuehttps://github.com/nodejs/node/pull/5020#issuecomment-179146506
My (wordy, sorry) responsehttps://github.com/nodejs/node/pull/5020#issuecomment-179186510
@yoshuawuytshttps://github.com/yoshuawuyts
@rvagghttps://github.com/rvagg
@DonutEspressohttps://github.com/DonutEspresso
@yoshuawuytshttps://github.com/yoshuawuyts
askshttps://github.com/nodejs/node/pull/5020#issuecomment-178887233
@mikealhttps://github.com/mikeal
respondshttps://github.com/nodejs/node/pull/5020#issuecomment-178891923
@brianlerouxhttps://github.com/brianleroux
respondshttps://github.com/nodejs/node/pull/5020#issuecomment-178892671
My responsehttps://github.com/nodejs/node/pull/5020#issuecomment-178894842
@DonutEspressohttps://github.com/DonutEspresso
raises concernshttps://github.com/nodejs/node/pull/5020#issuecomment-178926163
My responsehttps://github.com/nodejs/node/pull/5020#issuecomment-178942306
@rvagghttps://github.com/rvagg
askshttps://github.com/nodejs/node/pull/5020#issuecomment-179146506
My (wordy, sorry) responsehttps://github.com/nodejs/node/pull/5020#issuecomment-179186510
@phpnodehttps://github.com/phpnode
@RReverserhttps://github.com/RReverser
@mikealhttps://github.com/mikeal
@ktrotthttps://github.com/ktrott
@ktrotthttps://github.com/ktrott
excellent job of summing up the concernhttps://github.com/nodejs/node/pull/5020#issuecomment-179452337
(again wordy, sorry!) responsehttps://github.com/nodejs/node/pull/5020#issuecomment-179505468
bluebirdhttp://bluebirdjs.com/
promisifyAllhttp://bluebirdjs.com/docs/api/promise.promisifyall.html
Please reload this pagehttps://github.com/nodejs/node/pull/5020
chrisdickinsonhttps://github.com/chrisdickinson
January 31, 2016 17:18https://github.com/nodejs/node/pull/5020#commits-pushed-c1613c0
https://github.com/chrisdickinson
internal: add {callback,promis}ify.jshttps://github.com/nodejs/node/pull/5020/commits/c1613c01a0808b246e333fb846bb0d297e8622db
c1613c0https://github.com/nodejs/node/pull/5020/commits/c1613c01a0808b246e333fb846bb0d297e8622db
https://github.com/chrisdickinson
zlib: promisifyhttps://github.com/nodejs/node/pull/5020/commits/a8efd4fcc875d7548bdf84d281b0975dc3ea5173
a8efd4fhttps://github.com/nodejs/node/pull/5020/commits/a8efd4fcc875d7548bdf84d281b0975dc3ea5173
https://github.com/chrisdickinson
repl: promisifyhttps://github.com/nodejs/node/pull/5020/commits/4af7ec24e92cc667faf45db0b7574919eb52330d
4af7ec2https://github.com/nodejs/node/pull/5020/commits/4af7ec24e92cc667faf45db0b7574919eb52330d
https://github.com/chrisdickinson
readline: promisify .question + callbackify completerhttps://github.com/nodejs/node/pull/5020/commits/0e0a2d9554299c1ee96a866d86b3bfe8b55f1c3a
0e0a2d9https://github.com/nodejs/node/pull/5020/commits/0e0a2d9554299c1ee96a866d86b3bfe8b55f1c3a
https://github.com/chrisdickinson
build: add callbackify and promisify to node.gyphttps://github.com/nodejs/node/pull/5020/commits/8798a26f9843bd5fd57b6a3434789c9af1846e4c
8798a26https://github.com/nodejs/node/pull/5020/commits/8798a26f9843bd5fd57b6a3434789c9af1846e4c
https://github.com/chrisdickinson
net: promisify socket.setTimeout; add connectAsynchttps://github.com/nodejs/node/pull/5020/commits/355205b36de46c1bdfa9ababe98ce497c4607b31
355205bhttps://github.com/nodejs/node/pull/5020/commits/355205b36de46c1bdfa9ababe98ce497c4607b31
https://github.com/chrisdickinson
internal: fixup promisifyhttps://github.com/nodejs/node/pull/5020/commits/7b8e57dd07d8f468c3cac6d75aaa84d72e90a2c8
7b8e57dhttps://github.com/nodejs/node/pull/5020/commits/7b8e57dd07d8f468c3cac6d75aaa84d72e90a2c8
https://github.com/chrisdickinson
http,https: add {request,get}Asynchttps://github.com/nodejs/node/pull/5020/commits/3f2b0d8a12a9ab3f58b13442c7610ca099725a17
3f2b0d8https://github.com/nodejs/node/pull/5020/commits/3f2b0d8a12a9ab3f58b13442c7610ca099725a17
https://github.com/chrisdickinson
fs: no callback -> return promisehttps://github.com/nodejs/node/pull/5020/commits/23ba07370d19e40b0548088e3d9b096c1227aebd
23ba073https://github.com/nodejs/node/pull/5020/commits/23ba07370d19e40b0548088e3d9b096c1227aebd
https://github.com/chrisdickinson
dns: promisifyhttps://github.com/nodejs/node/pull/5020/commits/68837b87097d3ca814ecb38e4226d38b9324a957
68837b8https://github.com/nodejs/node/pull/5020/commits/68837b87097d3ca814ecb38e4226d38b9324a957
https://github.com/chrisdickinson
dgram: promisify .{bind,close,send}https://github.com/nodejs/node/pull/5020/commits/3317652505017eca3346500e57c4804a528f536e
3317652https://github.com/nodejs/node/pull/5020/commits/3317652505017eca3346500e57c4804a528f536e
https://github.com/chrisdickinson
doc,dgram: add promise notes to dgram docshttps://github.com/nodejs/node/pull/5020/commits/846bd493bcb0e611b9dc10c2145457d84764c071
846bd49https://github.com/nodejs/node/pull/5020/commits/846bd493bcb0e611b9dc10c2145457d84764c071
https://github.com/chrisdickinson
internal: add hooks for specifying different promise resolverhttps://github.com/nodejs/node/pull/5020/commits/d90b42c69fc0bad866f5f5e435b2dcbc5d7c7054
d90b42chttps://github.com/nodejs/node/pull/5020/commits/d90b42c69fc0bad866f5f5e435b2dcbc5d7c7054
https://github.com/chrisdickinson
crypto: promisify pbkdf2, add randomBytesAsynchttps://github.com/nodejs/node/pull/5020/commits/adbe35210cd9bd82011a5eab65c615b66295b83d
adbe352https://github.com/nodejs/node/pull/5020/commits/adbe35210cd9bd82011a5eab65c615b66295b83d
https://github.com/chrisdickinson
child_process,cluster: promisify .send(), add exec{File,}Asynchttps://github.com/nodejs/node/pull/5020/commits/697ce018bb1b73872b4f48872c7fec3b4fd71060
697ce01https://github.com/nodejs/node/pull/5020/commits/697ce018bb1b73872b4f48872c7fec3b4fd71060
https://github.com/chrisdickinson
add process.setPromiseImplementationhttps://github.com/nodejs/node/pull/5020/commits/f36b62d848b864f172d31d02dfcf585ce47e003a
f36b62dhttps://github.com/nodejs/node/pull/5020/commits/f36b62d848b864f172d31d02dfcf585ce47e003a
https://github.com/chrisdickinson
process: add setPromiseImplementation APIhttps://github.com/nodejs/node/pull/5020/commits/082fa0801032e98650f8c67e113b701f8195508d
082fa08https://github.com/nodejs/node/pull/5020/commits/082fa0801032e98650f8c67e113b701f8195508d
https://github.com/chrisdickinson
tls,net: connectAsync should resolve to Sockethttps://github.com/nodejs/node/pull/5020/commits/54e30012a579a434f3f1c474dc7b818c30d48ab8
54e3001https://github.com/nodejs/node/pull/5020/commits/54e30012a579a434f3f1c474dc7b818c30d48ab8
https://github.com/chrisdickinson
chrisdickinsonhttps://github.com/chrisdickinson
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Feb 1, 2016https://github.com/nodejs/node/pull/5020#event-533903348
https://github.com/chrisdickinson
chrisdickinsonhttps://github.com/chrisdickinson
Feb 1, 2016https://github.com/nodejs/node/pull/5020#event-533903362
chrisdickinsonhttps://github.com/chrisdickinson
Feb 1, 2016 https://github.com/nodejs/node/pull/5020#discussion-diff-51395940
View reviewed changes https://github.com/nodejs/node/pull/5020/files/54e30012a579a434f3f1c474dc7b818c30d48ab8#diff-7342100b0e5bd01caf5357172758b90d11c91ca042bc24b77d8aa8442126b088
lib/internal/promisify.jshttps://github.com/nodejs/node/pull/5020/files#diff-7342100b0e5bd01caf5357172758b90d11c91ca042bc24b77d8aa8442126b088
chrisdickinsonhttps://github.com/chrisdickinson
Feb 1, 2016https://github.com/nodejs/node/pull/5020#discussion_r51395940
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5020
targoshttps://github.com/targos
Feb 1, 2016https://github.com/nodejs/node/pull/5020#discussion_r51396408
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5020
sebmckhttps://github.com/sebmck
Feb 1, 2016https://github.com/nodejs/node/pull/5020#discussion_r51396894
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@chrisdickinsonhttps://github.com/chrisdickinson
.eslintrchttps://github.com/nodejs/node/blob/master/.eslintrc#L5
Please reload this pagehttps://github.com/nodejs/node/pull/5020
sebmckhttps://github.com/sebmck
Feb 1, 2016https://github.com/nodejs/node/pull/5020#discussion_r51396974
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@chrisdickinsonhttps://github.com/chrisdickinson
Please reload this pagehttps://github.com/nodejs/node/pull/5020
Fishrock123https://github.com/Fishrock123
Feb 1, 2016https://github.com/nodejs/node/pull/5020#discussion_r51426172
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5020
https://github.com/gergelyke
gergelykehttps://github.com/gergelyke
Feb 1, 2016https://github.com/nodejs/node/pull/5020#issuecomment-177878400
Please reload this pagehttps://github.com/nodejs/node/pull/5020
https://github.com/chrisdickinson
chrisdickinsonhttps://github.com/chrisdickinson
Feb 1, 2016https://github.com/nodejs/node/pull/5020#issuecomment-177880183
@gergelykehttps://github.com/gergelyke
Please reload this pagehttps://github.com/nodejs/node/pull/5020
https://github.com/sebmck
sebmckhttps://github.com/sebmck
Feb 1, 2016https://github.com/nodejs/node/pull/5020#issuecomment-177882379
Please reload this pagehttps://github.com/nodejs/node/pull/5020
https://github.com/chrisdickinson
chrisdickinsonhttps://github.com/chrisdickinson
Feb 1, 2016https://github.com/nodejs/node/pull/5020#issuecomment-177886366
@timoxleyhttps://github.com/timoxley
@kittenshttps://github.com/kittens
Please reload this pagehttps://github.com/nodejs/node/pull/5020
https://github.com/ChALkeR
ChALkeRhttps://github.com/ChALkeR
Feb 1, 2016https://github.com/nodejs/node/pull/5020#issuecomment-177886513
@gergelykehttps://github.com/gergelyke
https://github.com/petkaantonov/bluebird/tree/master/benchmarkhttps://github.com/petkaantonov/bluebird/tree/master/benchmark
Please reload this pagehttps://github.com/nodejs/node/pull/5020
https://github.com/madbence
madbencehttps://github.com/madbence
Feb 1, 2016https://github.com/nodejs/node/pull/5020#issuecomment-177886835
@timoxleyhttps://github.com/timoxley
Please reload this pagehttps://github.com/nodejs/node/pull/5020
https://github.com/chrisdickinson
chrisdickinsonhttps://github.com/chrisdickinson
Feb 1, 2016https://github.com/nodejs/node/pull/5020#issuecomment-177887060
@madbencehttps://github.com/madbence
Please reload this pagehttps://github.com/nodejs/node/pull/5020
https://github.com/timoxley
timoxleyhttps://github.com/timoxley
Feb 1, 2016https://github.com/nodejs/node/pull/5020#issuecomment-177888134
@chrisdickinsonhttps://github.com/chrisdickinson
Please reload this pagehttps://github.com/nodejs/node/pull/5020
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Feb 1, 2016https://github.com/nodejs/node/pull/5020#issuecomment-177889777
Please reload this pagehttps://github.com/nodejs/node/pull/5020
https://github.com/estliberitas
estliberitashttps://github.com/estliberitas
force-pushedhttps://github.com/nodejs/node/compare/7da4fd41dbf4516a6cdd9041cabfa75f9ee926af..c7066fb853c58b4eaee2dcb2e633541bb1189aa6
7da4fd4https://github.com/nodejs/node/commit/7da4fd41dbf4516a6cdd9041cabfa75f9ee926af
c7066fbhttps://github.com/nodejs/node/commit/c7066fb853c58b4eaee2dcb2e633541bb1189aa6
Compare https://github.com/nodejs/node/compare/7da4fd41dbf4516a6cdd9041cabfa75f9ee926af..c7066fb853c58b4eaee2dcb2e633541bb1189aa6
April 26, 2016 05:22https://github.com/nodejs/node/pull/5020#event-640983036
https://github.com/yosuke-furukawa
yosuke-furukawahttps://github.com/yosuke-furukawa
Apr 30, 2016 https://github.com/nodejs/node/pull/5020#ref-issue-136188250
Default Unhandled Rejection Behavior nodejs/promises#26 https://github.com/nodejs/promises/issues/26
https://github.com/saadq
saadqhttps://github.com/saadq
May 1, 2016 https://github.com/nodejs/node/pull/5020#ref-issue-152047393
Question about promises nodejs/help#158 https://github.com/nodejs/help/issues/158
https://github.com/forivall
forivallhttps://github.com/forivall
May 17, 2016 https://github.com/nodejs/node/pull/5020#ref-pullrequest-155386490
Allow setting a custom promise implementation amacneil/fetch-test-server#3 https://github.com/amacneil/fetch-test-server/pull/3
https://github.com/syrnick
syrnickhttps://github.com/syrnick
May 19, 2016 https://github.com/nodejs/node/pull/5020#ref-issue-47191590
promises prevent domain propagation nodejs/node-v0.x-archive#8648 https://github.com/nodejs/node-v0.x-archive/issues/8648
https://github.com/chrisdickinson
chrisdickinsonhttps://github.com/chrisdickinson
May 28, 2016https://github.com/nodejs/node/pull/5020#event-675254220
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Jun 9, 2016 https://github.com/nodejs/node/pull/5020#ref-issue-159464971
async/await and Node nodejs/CTC#7 https://github.com/nodejs/CTC/issues/7
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
stalled https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
Jun 29, 2016https://github.com/nodejs/node/pull/5020#event-707660394
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Sep 14, 2016 https://github.com/nodejs/node/pull/5020#ref-issue-116709190
Provide promise based API for core libraries nodejs/NG#25 https://github.com/nodejs/NG/issues/25
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/b0df363eda7d8a4314efaee5245b5073476c7362..c5ce7f4d9e36fc9f06547de1e41cdf4b2ac02720
b0df363https://github.com/nodejs/node/commit/b0df363eda7d8a4314efaee5245b5073476c7362
c5ce7f4https://github.com/nodejs/node/commit/c5ce7f4d9e36fc9f06547de1e41cdf4b2ac02720
Compare https://github.com/nodejs/node/compare/b0df363eda7d8a4314efaee5245b5073476c7362..c5ce7f4d9e36fc9f06547de1e41cdf4b2ac02720
September 21, 2016 00:09https://github.com/nodejs/node/pull/5020#event-796538902
https://github.com/fhemberger
fhembergerhttps://github.com/fhemberger
Sep 25, 2016 https://github.com/nodejs/node/pull/5020#ref-issue-179023443
Abort trap 6. when dns servers are invalid nodejs/nodejs.org#918 https://github.com/nodejs/nodejs.org/issues/918
https://github.com/rvagg
rvagghttps://github.com/rvagg
force-pushedhttps://github.com/nodejs/node/compare/c13399980463b0a8691ea2cff9191aa5aede8d0e..83c7a8897c644e1eadeaaace4863a822c73359a0
c133999https://github.com/nodejs/node/commit/c13399980463b0a8691ea2cff9191aa5aede8d0e
83c7a88https://github.com/nodejs/node/commit/83c7a8897c644e1eadeaaace4863a822c73359a0
Compare https://github.com/nodejs/node/compare/c13399980463b0a8691ea2cff9191aa5aede8d0e..83c7a8897c644e1eadeaaace4863a822c73359a0
October 18, 2016 17:01https://github.com/nodejs/node/pull/5020#event-827819618
https://github.com/danbucholtz
danbucholtzhttps://github.com/danbucholtz
Oct 26, 2016https://github.com/nodejs/node/pull/5020#issuecomment-256255010
@chrisdickinsonhttps://github.com/chrisdickinson
Please reload this pagehttps://github.com/nodejs/node/pull/5020
https://github.com/reconbot
reconbothttps://github.com/reconbot
Nov 6, 2016 https://github.com/nodejs/node/pull/5020#ref-issue-187192180
Explore Promises in addition to callbacks serialport/node-serialport#991 https://github.com/serialport/node-serialport/issues/991
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jan 14, 2017 https://github.com/nodejs/node/pull/5020#ref-issue-172333799
Fix or Mark apis in the documentation that cannot be try/catch/promised #8211 https://github.com/nodejs/node/issues/8211
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
force-pushedhttps://github.com/nodejs/node/compare/8df7ee082c924315b9780ae81aca6db90a9c4d4a..54fef6761ef1c8f2ad82afbe49b2090561cb7b82
8df7ee0https://github.com/nodejs/node/commit/8df7ee082c924315b9780ae81aca6db90a9c4d4a
54fef67https://github.com/nodejs/node/commit/54fef6761ef1c8f2ad82afbe49b2090561cb7b82
Compare https://github.com/nodejs/node/compare/8df7ee082c924315b9780ae81aca6db90a9c4d4a..54fef6761ef1c8f2ad82afbe49b2090561cb7b82
February 1, 2017 01:00https://github.com/nodejs/node/pull/5020#event-944072128
https://github.com/smashwilson
smashwilsonhttps://github.com/smashwilson
Feb 2, 2017 https://github.com/nodejs/node/pull/5020#ref-pullrequest-203311248
Discard lines in file diff atom/github#487 https://github.com/atom/github/pull/487
https://github.com/azu
azuhttps://github.com/azu
Feb 24, 2017 https://github.com/nodejs/node/pull/5020#ref-issue-209981437
2017-02-24 ミーティングアジェンダ js-primer/js-primer#191 https://github.com/js-primer/js-primer/issues/191
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Feb 28, 2017https://github.com/nodejs/node/pull/5020#issuecomment-283191346
Please reload this pagehttps://github.com/nodejs/node/pull/5020
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Feb 28, 2017https://github.com/nodejs/node/pull/5020#event-980972143
https://github.com/TimothyGu
TimothyGuhttps://github.com/TimothyGu
Mar 23, 2017 https://github.com/nodejs/node/pull/5020#ref-issue-216279320
Question: Use ES6 Promises? #12000 https://github.com/nodejs/node/issues/12000
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Apr 16, 2017 https://github.com/nodejs/node/pull/5020#ref-pullrequest-222019201
util: add util.promisify() #12442 https://github.com/nodejs/node/pull/12442
https://github.com/misterdjules
misterdjuleshttps://github.com/misterdjules
Apr 19, 2017 https://github.com/nodejs/node/pull/5020#ref-issue-173758640
Support awaiting values through util.awaitable nodejs/CTC#12 https://github.com/nodejs/CTC/issues/12
https://github.com/misterdjules
misterdjuleshttps://github.com/misterdjules
Jun 6, 2017 https://github.com/nodejs/node/pull/5020#ref-issue-233947471
Investigation of post-mortem debugging with Promises. nodejs/post-mortem#45 https://github.com/nodejs/post-mortem/issues/45
https://github.com/zkat
zkathttps://github.com/zkat
Sep 1, 2017 https://github.com/nodejs/node/pull/5020#ref-issue-254443741
Request for disclosure of details behind decision to fork ayojs/ayo#36 https://github.com/ayojs/ayo/issues/36
https://github.com/seishun
seishunhttps://github.com/seishun
Sep 14, 2017 https://github.com/nodejs/node/pull/5020#ref-issue-257804569
meta: planning for promisified fs and crypto #15413 https://github.com/nodejs/node/issues/15413
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Sep 21, 2017 https://github.com/nodejs/node/pull/5020#ref-issue-257578178
ES6 Promises Instead of Deprecation Warning ayojs/ayo#54 https://github.com/ayojs/ayo/issues/54
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5020
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
stalled https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled
Please reload this pagehttps://github.com/nodejs/node/pull/5020
https://github.com/chrisdickinson
https://github.com/gergelyke
https://github.com/sebmck
https://github.com/ChALkeR
https://github.com/madbence
https://github.com/timoxley
https://github.com/trevnorris
https://github.com/seidtgeist
https://github.com/targos
https://github.com/vkurchatkin
https://github.com/mcollina
https://github.com/eljefedelrodeodeljefe
https://github.com/YurySolovyov
https://github.com/thefourtheye
https://github.com/dscape
https://github.com/petkaantonov
https://github.com/remy
https://github.com/domenic
https://github.com/mattdesl
https://github.com/RReverser
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.