René's URL Explorer Experiment


Title: esm: improve check for ESM syntax by GeoffreyBooth · Pull Request #50127 · nodejs/node · GitHub

Open Graph Title: esm: improve check for ESM syntax by GeoffreyBooth · Pull Request #50127 · nodejs/node

X Title: esm: improve check for ESM syntax by GeoffreyBooth · Pull Request #50127 · nodejs/node

Description: This PR speeds up and simplifies the error path for when users require ES modules. In particular, the previous hasEsmSyntax helper used Acorn to parse the required module’s source code to find ESM ...

Open Graph Description: This PR speeds up and simplifies the error path for when users require ES modules. In particular, the previous hasEsmSyntax helper used Acorn to parse the required module’s source code to find ESM ...

X Description: This PR speeds up and simplifies the error path for when users require ES modules. In particular, the previous hasEsmSyntax helper used Acorn to parse the required module’s source code to find ESM ...

Opengraph URL: https://github.com/nodejs/node/pull/50127

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b47e40dd-4bc2-d59a-bc76-8a84da3aaa29
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA5BC:5FEAE:13C8BD:1B1B3A:696A0417
html-safe-nonce5a02db236ad335407c26c04ca430c5ae8c81ac0fba8db992c8c123e8e0027d5b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNUJDOjVGRUFFOjEzQzhCRDoxQjFCM0E6Njk2QTA0MTciLCJ2aXNpdG9yX2lkIjoiODMwMjI5MzQxNDExNTQxMDk2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf729ae002a06c52d27c14bbfc2eab5ecfeb3e9f6450d75a5a9f0254a3ae0cb64
hovercard-subject-tagpull_request:1550507380
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/50127/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/46b2dc32faf29b160e45207e9320edbc0ad916f79c97a1db448e42430168483b/nodejs/node/pull/50127
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/46b2dc32faf29b160e45207e9320edbc0ad916f79c97a1db448e42430168483b/nodejs/node/pull/50127
og:image:altThis PR speeds up and simplifies the error path for when users require ES modules. In particular, the previous hasEsmSyntax helper used Acorn to parse the required module’s source code to find ESM ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameGeoffreyBooth
hostnamegithub.com
expected-hostnamegithub.com
None578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release671c2f67171dbced24284331f3133a613d08c366
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/50127#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50127
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50127
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/50127
Reloadhttps://github.com/nodejs/node/pull/50127
Reloadhttps://github.com/nodejs/node/pull/50127
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/50127
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/50127
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/50127#issue-comment-box
aduh95https://github.com/aduh95
nodejs:mainhttps://github.com/nodejs/node/tree/main
GeoffreyBooth:better-esm-checkhttps://github.com/GeoffreyBooth/node/tree/better-esm-check
esm: improve check for ESM syntax https://github.com/nodejs/node/pull/50127#top
aduh95https://github.com/aduh95
nodejs:mainhttps://github.com/nodejs/node/tree/main
GeoffreyBooth:better-esm-checkhttps://github.com/GeoffreyBooth/node/tree/better-esm-check
Conversation 33 https://github.com/nodejs/node/pull/50127
Commits 5 https://github.com/nodejs/node/pull/50127/commits
Checks 0 https://github.com/nodejs/node/pull/50127/checks
Files changed https://github.com/nodejs/node/pull/50127/files
Please reload this pagehttps://github.com/nodejs/node/pull/50127
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Oct 10, 2023https://github.com/nodejs/node/pull/50127#issue-1935969556
Please reload this pagehttps://github.com/nodejs/node/pull/50127
#50096https://github.com/nodejs/node/pull/50096
Please reload this pagehttps://github.com/nodejs/node/pull/50127
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
module https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodule
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
Oct 10, 2023https://github.com/nodejs/node/pull/50127#event-10608166772
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 10, 2023https://github.com/nodejs/node/pull/50127#issuecomment-1756008032
Please reload this pagehttps://github.com/nodejs/node/pull/50127
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Oct 10, 2023https://github.com/nodejs/node/pull/50127#event-10608169245
https://github.com/ljharb
ljharbhttps://github.com/ljharb
Oct 10, 2023 https://github.com/nodejs/node/pull/50127#pullrequestreview-1668674841
View reviewed changes https://github.com/nodejs/node/pull/50127/files
lib/internal/modules/helpers.jshttps://github.com/nodejs/node/pull/50127/files#diff-fddf8a06747f8c9e83cd2a3ebee0f53dbd790567ce018044e70bd0ffbbcc815e
Please reload this pagehttps://github.com/nodejs/node/pull/50127
https://github.com/aduh95
aduh95https://github.com/aduh95
Oct 10, 2023 https://github.com/nodejs/node/pull/50127#pullrequestreview-1668701427
View reviewed changes https://github.com/nodejs/node/pull/50127/files
lib/internal/modules/helpers.jshttps://github.com/nodejs/node/pull/50127/files#diff-fddf8a06747f8c9e83cd2a3ebee0f53dbd790567ce018044e70bd0ffbbcc815e
Please reload this pagehttps://github.com/nodejs/node/pull/50127
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Oct 10, 2023https://github.com/nodejs/node/pull/50127#issuecomment-1756110806
@anonrighttps://github.com/anonrig
6c1c2f5 (#50096)https://github.com/nodejs/node/pull/50096/commits/6c1c2f5e42f6a053831f5c0bac4f0db3960215dc
Please reload this pagehttps://github.com/nodejs/node/pull/50127
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Oct 11, 2023 https://github.com/nodejs/node/pull/50127#ref-pullrequest-1932342110
esm: detect ESM syntax in ambiguous JavaScript #50096 https://github.com/nodejs/node/pull/50096
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
force-pushedhttps://github.com/nodejs/node/compare/cc356ff42de5ae9527c114ad0cf616546fbb00be..c4a8c7d3e51370bee4747a17571722fa2252cb0c
cc356ffhttps://github.com/nodejs/node/commit/cc356ff42de5ae9527c114ad0cf616546fbb00be
c4a8c7dhttps://github.com/nodejs/node/commit/c4a8c7d3e51370bee4747a17571722fa2252cb0c
Compare https://github.com/nodejs/node/compare/cc356ff42de5ae9527c114ad0cf616546fbb00be..c4a8c7d3e51370bee4747a17571722fa2252cb0c
October 14, 2023 19:31https://github.com/nodejs/node/pull/50127#event-10655568502
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Oct 14, 2023https://github.com/nodejs/node/pull/50127#event-10655570153
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Oct 14, 2023https://github.com/nodejs/node/pull/50127#issuecomment-1763157869
Please reload this pagehttps://github.com/nodejs/node/pull/50127
@joyeecheunghttps://github.com/joyeecheung
#50137https://github.com/nodejs/node/pull/50137
https://github.com/GeoffreyBooth/node/compare/vm-flag-callback-2…GeoffreyBooth:node:better-esm-checkhttps://github.com/GeoffreyBooth/node/compare/vm-flag-callback-2%E2%80%A6GeoffreyBooth:node:better-esm-check
Please reload this pagehttps://github.com/nodejs/node/pull/50127
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
force-pushedhttps://github.com/nodejs/node/compare/c4a8c7d3e51370bee4747a17571722fa2252cb0c..723025c5d33760281b319f4e2bbd6846eada4d6f
c4a8c7dhttps://github.com/nodejs/node/commit/c4a8c7d3e51370bee4747a17571722fa2252cb0c
723025chttps://github.com/nodejs/node/commit/723025c5d33760281b319f4e2bbd6846eada4d6f
Compare https://github.com/nodejs/node/compare/c4a8c7d3e51370bee4747a17571722fa2252cb0c..723025c5d33760281b319f4e2bbd6846eada4d6f
October 14, 2023 20:06https://github.com/nodejs/node/pull/50127#event-10655754882
https://github.com/ljharb
ljharbhttps://github.com/ljharb
Oct 14, 2023 https://github.com/nodejs/node/pull/50127#pullrequestreview-1678458379
View reviewed changes https://github.com/nodejs/node/pull/50127/files
lib/internal/process/execution.jshttps://github.com/nodejs/node/pull/50127/files#diff-478b97c524c636c5f933715388b6dc59c5c24c3e05e139188d3f480b28bda03c
Please reload this pagehttps://github.com/nodejs/node/pull/50127
lib/internal/vm.jshttps://github.com/nodejs/node/pull/50127/files#diff-1a0f97af60ebbe2562e263e5da6847238eced2957c099fae2c79838141b82f58
Please reload this pagehttps://github.com/nodejs/node/pull/50127
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
force-pushedhttps://github.com/nodejs/node/compare/651bfde7654687f373fc7870a7148bb6bc3236af..cb86df839369c89437698b0fb6c345c42df89224
651bfdehttps://github.com/nodejs/node/commit/651bfde7654687f373fc7870a7148bb6bc3236af
cb86df8https://github.com/nodejs/node/commit/cb86df839369c89437698b0fb6c345c42df89224
Compare https://github.com/nodejs/node/compare/651bfde7654687f373fc7870a7148bb6bc3236af..cb86df839369c89437698b0fb6c345c42df89224
October 14, 2023 22:28https://github.com/nodejs/node/pull/50127#event-10656043509
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Oct 14, 2023 https://github.com/nodejs/node/pull/50127#pullrequestreview-1678506390
View reviewed changes https://github.com/nodejs/node/pull/50127/files
guybedfordhttps://github.com/guybedford
https://github.com/nodejs/node/pull/50127#pullrequestreview-1678506390
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/50127
https://github.com/anonrig
anonrighttps://github.com/anonrig
Oct 15, 2023 https://github.com/nodejs/node/pull/50127#pullrequestreview-1678882965
View reviewed changes https://github.com/nodejs/node/pull/50127/files
src/node_contextify.cchttps://github.com/nodejs/node/pull/50127/files#diff-d194c6f9fca3e3c031ecc5b7bd91a53c8881641cd4d1df1ff169312971955c50
Please reload this pagehttps://github.com/nodejs/node/pull/50127
lib/internal/modules/esm/translators.jshttps://github.com/nodejs/node/pull/50127/files#diff-b1de5e9ce1e9b411001c63d11a5092dbba32e1586269a20dc11408375eb2f16c
Please reload this pagehttps://github.com/nodejs/node/pull/50127
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
force-pushedhttps://github.com/nodejs/node/compare/9b456ba375eeff9a6faa93ada0c17d23eae4f633..1836cb2b8ae4e55bdce8904ae52f6ece2f63d0e6
9b456bahttps://github.com/nodejs/node/commit/9b456ba375eeff9a6faa93ada0c17d23eae4f633
1836cb2https://github.com/nodejs/node/commit/1836cb2b8ae4e55bdce8904ae52f6ece2f63d0e6
Compare https://github.com/nodejs/node/compare/9b456ba375eeff9a6faa93ada0c17d23eae4f633..1836cb2b8ae4e55bdce8904ae52f6ece2f63d0e6
October 17, 2023 02:48https://github.com/nodejs/node/pull/50127#event-10672562915
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 17, 2023https://github.com/nodejs/node/pull/50127#issuecomment-1765574241
https://ci.nodejs.org/job/node-test-pull-request/54867/https://ci.nodejs.org/job/node-test-pull-request/54867/
Please reload this pagehttps://github.com/nodejs/node/pull/50127
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 17, 2023https://github.com/nodejs/node/pull/50127#issuecomment-1765630413
https://ci.nodejs.org/job/node-test-pull-request/54869/https://ci.nodejs.org/job/node-test-pull-request/54869/
Please reload this pagehttps://github.com/nodejs/node/pull/50127
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 17, 2023https://github.com/nodejs/node/pull/50127#issuecomment-1765660593
https://ci.nodejs.org/job/node-test-pull-request/54870/https://ci.nodejs.org/job/node-test-pull-request/54870/
Please reload this pagehttps://github.com/nodejs/node/pull/50127
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 17, 2023https://github.com/nodejs/node/pull/50127#issuecomment-1766331897
https://ci.nodejs.org/job/node-test-pull-request/54880/https://ci.nodejs.org/job/node-test-pull-request/54880/
Please reload this pagehttps://github.com/nodejs/node/pull/50127
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
force-pushedhttps://github.com/nodejs/node/compare/1836cb2b8ae4e55bdce8904ae52f6ece2f63d0e6..ed954adf5bd4bed3e38984a9f370cd5be7da1941
1836cb2https://github.com/nodejs/node/commit/1836cb2b8ae4e55bdce8904ae52f6ece2f63d0e6
ed954adhttps://github.com/nodejs/node/commit/ed954adf5bd4bed3e38984a9f370cd5be7da1941
Compare https://github.com/nodejs/node/compare/1836cb2b8ae4e55bdce8904ae52f6ece2f63d0e6..ed954adf5bd4bed3e38984a9f370cd5be7da1941
October 17, 2023 14:04https://github.com/nodejs/node/pull/50127#event-10679109017
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 17, 2023https://github.com/nodejs/node/pull/50127#issuecomment-1766491880
https://ci.nodejs.org/job/node-test-pull-request/54884/https://ci.nodejs.org/job/node-test-pull-request/54884/
Please reload this pagehttps://github.com/nodejs/node/pull/50127
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 17, 2023https://github.com/nodejs/node/pull/50127#event-10679117512
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 17, 2023https://github.com/nodejs/node/pull/50127#issuecomment-1766703287
https://ci.nodejs.org/job/node-test-pull-request/54887/https://ci.nodejs.org/job/node-test-pull-request/54887/
Please reload this pagehttps://github.com/nodejs/node/pull/50127
https://github.com/anonrig
anonrighttps://github.com/anonrig
Oct 17, 2023 https://github.com/nodejs/node/pull/50127#pullrequestreview-1682765670
View reviewed changes https://github.com/nodejs/node/pull/50127/files
https://github.com/anonrig
anonrighttps://github.com/anonrig
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
Oct 17, 2023https://github.com/nodejs/node/pull/50127#event-10680725690
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 17, 2023https://github.com/nodejs/node/pull/50127#issuecomment-1766820177
https://ci.nodejs.org/job/node-test-pull-request/54890/https://ci.nodejs.org/job/node-test-pull-request/54890/
Please reload this pagehttps://github.com/nodejs/node/pull/50127
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
force-pushedhttps://github.com/nodejs/node/compare/40ac2ffdff07cd532eb4df371049eae8f7e847cc..034f8c6f8dc5cac37c58d24d1d1846dbbc7c8835
40ac2ffhttps://github.com/nodejs/node/commit/40ac2ffdff07cd532eb4df371049eae8f7e847cc
034f8c6https://github.com/nodejs/node/commit/034f8c6f8dc5cac37c58d24d1d1846dbbc7c8835
Compare https://github.com/nodejs/node/compare/40ac2ffdff07cd532eb4df371049eae8f7e847cc..034f8c6f8dc5cac37c58d24d1d1846dbbc7c8835
October 17, 2023 22:38https://github.com/nodejs/node/pull/50127#event-10684704499
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 17, 2023https://github.com/nodejs/node/pull/50127#issuecomment-1767304621
https://ci.nodejs.org/job/node-test-pull-request/54909/https://ci.nodejs.org/job/node-test-pull-request/54909/
Please reload this pagehttps://github.com/nodejs/node/pull/50127
https://github.com/anonrig
anonrighttps://github.com/anonrig
Oct 17, 2023 https://github.com/nodejs/node/pull/50127#pullrequestreview-1683590138
View reviewed changes https://github.com/nodejs/node/pull/50127/files
https://github.com/anonrig
anonrighttps://github.com/anonrig
Oct 17, 2023 https://github.com/nodejs/node/pull/50127#pullrequestreview-1683590267
View reviewed changes https://github.com/nodejs/node/pull/50127/files
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
force-pushedhttps://github.com/nodejs/node/compare/034f8c6f8dc5cac37c58d24d1d1846dbbc7c8835..a0f58b4c520ae3267c4814a2c3f69c1501406ba1
034f8c6https://github.com/nodejs/node/commit/034f8c6f8dc5cac37c58d24d1d1846dbbc7c8835
a0f58b4https://github.com/nodejs/node/commit/a0f58b4c520ae3267c4814a2c3f69c1501406ba1
Compare https://github.com/nodejs/node/compare/034f8c6f8dc5cac37c58d24d1d1846dbbc7c8835..a0f58b4c520ae3267c4814a2c3f69c1501406ba1
October 17, 2023 22:46https://github.com/nodejs/node/pull/50127#event-10684759876
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 17, 2023https://github.com/nodejs/node/pull/50127#issuecomment-1767312691
https://ci.nodejs.org/job/node-test-pull-request/54910/https://ci.nodejs.org/job/node-test-pull-request/54910/
Please reload this pagehttps://github.com/nodejs/node/pull/50127
https://github.com/anonrig
anonrighttps://github.com/anonrig
Oct 17, 2023 https://github.com/nodejs/node/pull/50127#pullrequestreview-1683592290
View reviewed changes https://github.com/nodejs/node/pull/50127/files
https://github.com/GeoffreyBooth
Fix compilation for arm-debughttps://github.com/nodejs/node/pull/50127/commits/6db5d4707fa341069700e1fcf0ad8830d0b4c71c
6db5d47https://github.com/nodejs/node/pull/50127/commits/6db5d4707fa341069700e1fcf0ad8830d0b4c71c
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
force-pushedhttps://github.com/nodejs/node/compare/a0f58b4c520ae3267c4814a2c3f69c1501406ba1..6db5d4707fa341069700e1fcf0ad8830d0b4c71c
a0f58b4https://github.com/nodejs/node/commit/a0f58b4c520ae3267c4814a2c3f69c1501406ba1
6db5d47https://github.com/nodejs/node/commit/6db5d4707fa341069700e1fcf0ad8830d0b4c71c
Compare https://github.com/nodejs/node/compare/a0f58b4c520ae3267c4814a2c3f69c1501406ba1..6db5d4707fa341069700e1fcf0ad8830d0b4c71c
October 18, 2023 02:01https://github.com/nodejs/node/pull/50127#event-10685974481
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 18, 2023https://github.com/nodejs/node/pull/50127#issuecomment-1767498806
https://ci.nodejs.org/job/node-test-pull-request/54917/https://ci.nodejs.org/job/node-test-pull-request/54917/
Please reload this pagehttps://github.com/nodejs/node/pull/50127
https://github.com/anonrig
anonrighttps://github.com/anonrig
Oct 18, 2023 https://github.com/nodejs/node/pull/50127#pullrequestreview-1683777828
View reviewed changes https://github.com/nodejs/node/pull/50127/files/6db5d4707fa341069700e1fcf0ad8830d0b4c71c
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 18, 2023https://github.com/nodejs/node/pull/50127#issuecomment-1767659697
https://ci.nodejs.org/job/node-test-pull-request/54923/https://ci.nodejs.org/job/node-test-pull-request/54923/
Please reload this pagehttps://github.com/nodejs/node/pull/50127
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 18, 2023https://github.com/nodejs/node/pull/50127#event-10691883600
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 18, 2023https://github.com/nodejs/node/pull/50127#event-10691929561
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 18, 2023https://github.com/nodejs/node/pull/50127#issuecomment-1768303466
https://github.com/nodejs/node/actions/runs/6560512702https://github.com/nodejs/node/actions/runs/6560512702
Please reload this pagehttps://github.com/nodejs/node/pull/50127
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
Oct 18, 2023https://github.com/nodejs/node/pull/50127#event-10691930578
https://github.com/aduh95
aduh95https://github.com/aduh95
Oct 18, 2023 https://github.com/nodejs/node/pull/50127#pullrequestreview-1685258468
View reviewed changes https://github.com/nodejs/node/pull/50127/files/6db5d4707fa341069700e1fcf0ad8830d0b4c71c
https://github.com/aduh95
aduh95https://github.com/aduh95
a9b2535https://github.com/nodejs/node/commit/a9b25356c0d651965b71ccd7802dfa373304deb8
Oct 18, 2023https://github.com/nodejs/node/pull/50127#event-10694013210
https://github.com/aduh95
aduh95https://github.com/aduh95
Oct 18, 2023https://github.com/nodejs/node/pull/50127#issuecomment-1768598513
Please reload this pagehttps://github.com/nodejs/node/pull/50127
a9b2535https://github.com/nodejs/node/commit/a9b25356c0d651965b71ccd7802dfa373304deb8
Please reload this pagehttps://github.com/nodejs/node/pull/50127
aduh95https://github.com/aduh95
Oct 18, 2023 https://github.com/nodejs/node/pull/50127#ref-commit-e9844fe
https://github.com/GeoffreyBooth
https://github.com/aduh95
esm: improve check for ESM syntaxhttps://github.com/aduh95/node/commit/e9844fe47ea585f6cc1f94da4f5bbc54fdff1d09
e9844fehttps://github.com/aduh95/node/commit/e9844fe47ea585f6cc1f94da4f5bbc54fdff1d09
nodejs#50127https://github.com/nodejs/node/pull/50127
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
October 18, 2023 21:19https://github.com/nodejs/node/pull/50127#event-10699230786
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 19, 2023 https://github.com/nodejs/node/pull/50127#ref-issue-1950936303
CI Reliability 2023-10-19 nodejs/reliability#691 https://github.com/nodejs/reliability/issues/691
targoshttps://github.com/targos
Oct 23, 2023 https://github.com/nodejs/node/pull/50127#ref-commit-c76eb27
https://github.com/GeoffreyBooth
https://github.com/targos
esm: improve check for ESM syntaxhttps://github.com/nodejs/node/commit/c76eb279712457d0ee6273195a04df2e879decae
c76eb27https://github.com/nodejs/node/commit/c76eb279712457d0ee6273195a04df2e879decae
#50127https://github.com/nodejs/node/pull/50127
https://github.com/targos
targoshttps://github.com/targos
Oct 23, 2023 https://github.com/nodejs/node/pull/50127#ref-pullrequest-1956752636
v21.1.0 release proposal #50335 https://github.com/nodejs/node/pull/50335
alexfernandezhttps://github.com/alexfernandez
Nov 1, 2023 https://github.com/nodejs/node/pull/50127#ref-commit-fddb8ac
https://github.com/GeoffreyBooth
https://github.com/alexfernandez
esm: improve check for ESM syntaxhttps://github.com/alexfernandez/node/commit/fddb8ac509d34cdc6ab53a63047c8930cc3efc25
fddb8achttps://github.com/alexfernandez/node/commit/fddb8ac509d34cdc6ab53a63047c8930cc3efc25
nodejs#50127https://github.com/nodejs/node/pull/50127
targoshttps://github.com/targos
Nov 11, 2023 https://github.com/nodejs/node/pull/50127#ref-commit-c64490e
https://github.com/GeoffreyBooth
https://github.com/targos
esm: improve check for ESM syntaxhttps://github.com/nodejs/node/commit/c64490e9aa46a19cc83fbfd57702660ae67dc9fb
c64490ehttps://github.com/nodejs/node/commit/c64490e9aa46a19cc83fbfd57702660ae67dc9fb
#50127https://github.com/nodejs/node/pull/50127
https://github.com/targos
targoshttps://github.com/targos
Nov 12, 2023 https://github.com/nodejs/node/pull/50127#ref-pullrequest-1989293723
v20.10.0 release proposal #50682 https://github.com/nodejs/node/pull/50682
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Dec 6, 2023 https://github.com/nodejs/node/pull/50127#ref-pullrequest-2029497346
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41 https://github.com/nodesource/nsolid/pull/41
codebyterehttps://github.com/codebytere
Dec 8, 2023 https://github.com/nodejs/node/pull/50127#ref-commit-f0bf3ef
https://github.com/codebytere
fix: lazyload fs in esm loaders to apply asar patcheshttps://github.com/electron/electron/commit/f0bf3efe1e9b0357e5412d5c83bbc099f4424aee
f0bf3efhttps://github.com/electron/electron/commit/f0bf3efe1e9b0357e5412d5c83bbc099f4424aee
nodejs/node#50127https://github.com/nodejs/node/pull/50127
nodejs/node#50096https://github.com/nodejs/node/pull/50096
codebyterehttps://github.com/codebytere
Dec 11, 2023 https://github.com/nodejs/node/pull/50127#ref-commit-890a557
https://github.com/apps/electron-roller
https://github.com/ckerr
https://github.com/codebytere
chore: bump node to v20.10.0 (main) (https://github.com/electron/electron/commit/890a557eed6a6917e7854b76e5a691eff1f5e9ae
#40675https://github.com/electron/electron/pull/40675
)https://github.com/electron/electron/commit/890a557eed6a6917e7854b76e5a691eff1f5e9ae
890a557https://github.com/electron/electron/commit/890a557eed6a6917e7854b76e5a691eff1f5e9ae
nodejs/node#49986https://github.com/nodejs/node/pull/49986
nodejs/node#49657https://github.com/nodejs/node/pull/49657
nodejs/node#49912https://github.com/nodejs/node/pull/49912
nodejs/node#49986https://github.com/nodejs/node/pull/49986
nodejs/node#50096https://github.com/nodejs/node/pull/50096
nodejs/node#50314https://github.com/nodejs/node/pull/50314
nodejs/node#49657https://github.com/nodejs/node/pull/49657
nodejs/node#50127https://github.com/nodejs/node/pull/50127
nodejs/node#50096https://github.com/nodejs/node/pull/50096
nodejs/node#49523https://github.com/nodejs/node/pull/49523
nodejs/node#50296https://github.com/nodejs/node/pull/50296
nodejs/node#50082https://github.com/nodejs/node/pull/50082
nodejs/node#49986https://github.com/nodejs/node/pull/49986
nodejs/node#49908https://github.com/nodejs/node/pull/49908
nodejs/node#49876https://github.com/nodejs/node/pull/49876
nodejs/node#50034https://github.com/nodejs/node/pull/50034
nodejs/node#49659https://github.com/nodejs/node/pull/49659
nodejs/node#48749https://github.com/nodejs/node/pull/48749
nodejs/node#49913https://github.com/nodejs/node/pull/49913
nodejs/node#50234https://github.com/nodejs/node/pull/50234
nodejs/node#50096https://github.com/nodejs/node/pull/50096
nodejs/node#49974https://github.com/nodejs/node/pull/49974
https://chromium-review.googlesource.com/c/v8/v8/+/4705331https://chromium-review.googlesource.com/c/v8/v8/+/4705331
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50127
https://github.com/ljharb
ljharb https://github.com/ljharb
https://github.com/nodejs/node/pull/50127/files/723025c5d33760281b319f4e2bbd6846eada4d6f
https://github.com/guybedford
guybedford https://github.com/guybedford
https://github.com/nodejs/node/pull/50127/files/651bfde7654687f373fc7870a7148bb6bc3236af
https://github.com/anonrig
anonrig https://github.com/anonrig
https://github.com/nodejs/node/pull/50127/files/6db5d4707fa341069700e1fcf0ad8830d0b4c71c
https://github.com/JakobJingleheimer
JakobJingleheimer https://github.com/JakobJingleheimer
https://github.com/nodejs/node/pull/50127/files/ed954adf5bd4bed3e38984a9f370cd5be7da1941
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/50127/files/6db5d4707fa341069700e1fcf0ad8830d0b4c71c
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
module https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodule
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/50127
https://github.com/GeoffreyBooth
https://github.com/nodejs-github-bot
https://github.com/aduh95
https://github.com/ljharb
https://github.com/guybedford
https://github.com/anonrig
https://github.com/JakobJingleheimer
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.