| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:04b575ab-f137-44f0-b472-531f3775a334 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8EAA:3FFE1:E2C23A:1344E68:6969F067 |
| html-safe-nonce | 2c73365ed9d532c982d58ee261f239c8a1028b78c585afdcbc254c9f0e869c93 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RUFBOjNGRkUxOkUyQzIzQToxMzQ0RTY4OjY5NjlGMDY3IiwidmlzaXRvcl9pZCI6IjgxMTQ5ODc2MzU0NzkwMTU1MjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e02b0d221df9f775cffc0a735b4280a7b5c37ac30536d7feaa76503428f436a0 |
| hovercard-subject-tag | pull_request:1549644856 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/50118/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7bcc13845f63773586f7e9fa8fd56cb3b0e03f6f68c8dc8eb5fbc45b87a8520d/nodejs/node/pull/50118 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7bcc13845f63773586f7e9fa8fd56cb3b0e03f6f68c8dc8eb5fbc45b87a8520d/nodejs/node/pull/50118 |
| og:image:alt | no-return-await rule was deprecated in ESLint 8.46.0. According to the ESLint docs removing await can make the code slower.
Refs: https://eslint.org/docs/latest/rules/no-return-await
This rule was ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sapphi-red |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/50118#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50118 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50118 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/50118 |
| Reload | https://github.com/nodejs/node/pull/50118 |
| Reload | https://github.com/nodejs/node/pull/50118 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/50118 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/50118 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/50118#issue-comment-box |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| sapphi-red:tools/remove-no-return-await-rule | https://github.com/sapphi-red/node/tree/tools/remove-no-return-await-rule |
|
tools: remove no-return-await lint rule
| https://github.com/nodejs/node/pull/50118#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| sapphi-red:tools/remove-no-return-await-rule | https://github.com/sapphi-red/node/tree/tools/remove-no-return-await-rule |
|
Conversation
1
| https://github.com/nodejs/node/pull/50118 |
|
Commits
1
| https://github.com/nodejs/node/pull/50118/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/50118/checks |
|
Files changed
| https://github.com/nodejs/node/pull/50118/files |
| Please reload this page | https://github.com/nodejs/node/pull/50118 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/sapphi-red |
| sapphi-red | https://github.com/sapphi-red |
| Oct 10, 2023 | https://github.com/nodejs/node/pull/50118#issue-1935022675 |
| Please reload this page | https://github.com/nodejs/node/pull/50118 |
| https://eslint.org/docs/latest/rules/no-return-await | https://eslint.org/docs/latest/rules/no-return-await |
| #17265 | https://github.com/nodejs/node/pull/17265 |
| #49849 (comment) | https://github.com/nodejs/node/pull/49849#discussion_r1348357793 |
| Please reload this page | https://github.com/nodejs/node/pull/50118 |
|
| https://github.com/sapphi-red |
| tools: remove no-return-await lint rule | https://github.com/nodejs/node/pull/50118/commits/0d4caee2d689923a10cb03aff4aa47608c15d0e8 |
| 0d4caee | https://github.com/nodejs/node/pull/50118/commits/0d4caee2d689923a10cb03aff4aa47608c15d0e8 |
| https://eslint.org/docs/latest/rules/no-return-await | https://eslint.org/docs/latest/rules/no-return-await |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Oct 10, 2023 | https://github.com/nodejs/node/pull/50118#event-10602470270 |
| https://github.com/sapphi-red |
| sapphi-red | https://github.com/sapphi-red |
| force-pushed | https://github.com/nodejs/node/compare/a503145cd9c790beceb4b80eecc0a57ca6b42c5f..0d4caee2d689923a10cb03aff4aa47608c15d0e8 |
| a503145 | https://github.com/nodejs/node/commit/a503145cd9c790beceb4b80eecc0a57ca6b42c5f |
| 0d4caee | https://github.com/nodejs/node/commit/0d4caee2d689923a10cb03aff4aa47608c15d0e8 |
|
Compare
| https://github.com/nodejs/node/compare/a503145cd9c790beceb4b80eecc0a57ca6b42c5f..0d4caee2d689923a10cb03aff4aa47608c15d0e8 |
| October 10, 2023 10:38 | https://github.com/nodejs/node/pull/50118#event-10602482932 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Oct 10, 2023
| https://github.com/nodejs/node/pull/50118#pullrequestreview-1667512429 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/50118/files/0d4caee2d689923a10cb03aff4aa47608c15d0e8 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Oct 10, 2023 | https://github.com/nodejs/node/pull/50118#event-10603785615 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Oct 10, 2023
| https://github.com/nodejs/node/pull/50118#pullrequestreview-1668787111 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/50118/files/0d4caee2d689923a10cb03aff4aa47608c15d0e8 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Oct 11, 2023 | https://github.com/nodejs/node/pull/50118#event-10617201588 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Oct 12, 2023 | https://github.com/nodejs/node/pull/50118#event-10629955391 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| 760b5dd | https://github.com/nodejs/node/commit/760b5dd259122884adff834bbfb7194f48ecb79a |
| Oct 12, 2023 | https://github.com/nodejs/node/pull/50118#event-10629956104 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 12, 2023 | https://github.com/nodejs/node/pull/50118#issuecomment-1759363547 |
| 760b5dd | https://github.com/nodejs/node/commit/760b5dd259122884adff834bbfb7194f48ecb79a |
| Please reload this page | https://github.com/nodejs/node/pull/50118 |
| https://github.com/sapphi-red |
| sapphi-red | https://github.com/sapphi-red |
| October 12, 2023 11:30 | https://github.com/nodejs/node/pull/50118#event-10630419069 |
| https://github.com/sapphi-red |
| sapphi-red | https://github.com/sapphi-red |
|
Oct 12, 2023
| https://github.com/nodejs/node/pull/50118#ref-pullrequest-1910706947 |
|
fs: add stacktrace to fs/promises
#49849
| https://github.com/nodejs/node/pull/49849 |
| https://github.com/RafaelGSS |
| RafaelGSS | https://github.com/RafaelGSS |
|
Oct 15, 2023
| https://github.com/nodejs/node/pull/50118#ref-pullrequest-1912846720 |
|
2023-10-17, Version 21.0.0 (Current)
#49870
| https://github.com/nodejs/node/pull/49870 |
| alexfernandez | https://github.com/alexfernandez |
|
Nov 1, 2023
| https://github.com/nodejs/node/pull/50118#ref-commit-93f690a |
|
| https://github.com/sapphi-red |
|
| https://github.com/alexfernandez |
| tools: remove no-return-await lint rule | https://github.com/alexfernandez/node/commit/93f690a7c1fc4dca3932adb4fd60a54fbe393608 |
| 93f690a | https://github.com/alexfernandez/node/commit/93f690a7c1fc4dca3932adb4fd60a54fbe393608 |
| https://eslint.org/docs/latest/rules/no-return-await | https://eslint.org/docs/latest/rules/no-return-await |
| nodejs#50118 | https://github.com/nodejs/node/pull/50118 |
| targos | https://github.com/targos |
|
Nov 11, 2023
| https://github.com/nodejs/node/pull/50118#ref-commit-bd5d533 |
|
| https://github.com/sapphi-red |
|
| https://github.com/targos |
| tools: remove no-return-await lint rule | https://github.com/nodejs/node/commit/bd5d5331b058f646cec457e61a47a249bfa36994 |
| bd5d533 | https://github.com/nodejs/node/commit/bd5d5331b058f646cec457e61a47a249bfa36994 |
| https://eslint.org/docs/latest/rules/no-return-await | https://eslint.org/docs/latest/rules/no-return-await |
| #50118 | https://github.com/nodejs/node/pull/50118 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Nov 12, 2023
| https://github.com/nodejs/node/pull/50118#ref-pullrequest-1989293723 |
|
v20.10.0 release proposal
#50682
| https://github.com/nodejs/node/pull/50682 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
|
Dec 6, 2023
| https://github.com/nodejs/node/pull/50118#ref-pullrequest-2029497346 |
|
2023-12-06, N|Solid v5.0.1 Iron Release
nodesource/nsolid#41
| https://github.com/nodesource/nsolid/pull/41 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F50118 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/50118/files/0d4caee2d689923a10cb03aff4aa47608c15d0e8 |
|
| https://github.com/anonrig |
|
anonrig
| https://github.com/anonrig |
|
| https://github.com/nodejs/node/pull/50118/files/0d4caee2d689923a10cb03aff4aa47608c15d0e8 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Please reload this page | https://github.com/nodejs/node/pull/50118 |
|
| https://github.com/sapphi-red |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/lpinca |
|
| https://github.com/anonrig |
|
| https://github.com/aduh95 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |