René's URL Explorer Experiment


Title: test_runner: replace spurious if with else by cjihrig · Pull Request #49943 · nodejs/node · GitHub

Open Graph Title: test_runner: replace spurious if with else by cjihrig · Pull Request #49943 · nodejs/node

X Title: test_runner: replace spurious if with else by cjihrig · Pull Request #49943 · nodejs/node

Description: There is an if statement that likely should have been an else in the original PR. Refs: #48915

Open Graph Description: There is an if statement that likely should have been an else in the original PR. Refs: #48915

X Description: There is an if statement that likely should have been an else in the original PR. Refs: #48915

Opengraph URL: https://github.com/nodejs/node/pull/49943

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:880b604c-93f7-5a9e-7cce-12e337e909ee
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9C64:393FCF:ACCD:D3A2:6969B671
html-safe-nonce03aca4d237699503688de4c63882d7d4ab9461542d7f6dcad59c587f0f36b059
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzY0OjM5M0ZDRjpBQ0NEOkQzQTI6Njk2OUI2NzEiLCJ2aXNpdG9yX2lkIjoiMzAxNzQ0MDM3Mzc2ODgyODUyOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf79703bdcc42bc95fba4f3b4a3bb98813d374768a9820b058cfc38e52ca14170
hovercard-subject-tagpull_request:1534969325
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/49943/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/de167e49e2947015a1f3854ba64fb66f240380732ab20f9e624a701b7b3f4be9/nodejs/node/pull/49943
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/de167e49e2947015a1f3854ba64fb66f240380732ab20f9e624a701b7b3f4be9/nodejs/node/pull/49943
og:image:altThere is an if statement that likely should have been an else in the original PR. Refs: #48915
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/49943#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49943
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49943
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/49943
Reloadhttps://github.com/nodejs/node/pull/49943
Reloadhttps://github.com/nodejs/node/pull/49943
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/49943
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/49943
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/49943#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
cjihrig:cleanuphttps://github.com/cjihrig/node/tree/cleanup
test_runner: replace spurious if with else https://github.com/nodejs/node/pull/49943#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
cjihrig:cleanuphttps://github.com/cjihrig/node/tree/cleanup
Conversation 5 https://github.com/nodejs/node/pull/49943
Commits 1 https://github.com/nodejs/node/pull/49943/commits
Checks 0 https://github.com/nodejs/node/pull/49943/checks
Files changed https://github.com/nodejs/node/pull/49943/files
Please reload this pagehttps://github.com/nodejs/node/pull/49943
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Sep 28, 2023https://github.com/nodejs/node/pull/49943#issue-1918399572
#48915https://github.com/nodejs/node/pull/48915
Please reload this pagehttps://github.com/nodejs/node/pull/49943
https://github.com/cjihrig
test_runner: replace spurious if with elsehttps://github.com/nodejs/node/pull/49943/commits/1bb2d08aed98af4f0531814f303ecf43407d7539
1bb2d08https://github.com/nodejs/node/pull/49943/commits/1bb2d08aed98af4f0531814f303ecf43407d7539
nodejs#48915https://github.com/nodejs/node/pull/48915
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 28, 2023https://github.com/nodejs/node/pull/49943#issuecomment-1740126059
Please reload this pagehttps://github.com/nodejs/node/pull/49943
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test_runner https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner
Sep 28, 2023https://github.com/nodejs/node/pull/49943#event-10505244076
https://github.com/ljharb
ljharbhttps://github.com/ljharb
Sep 29, 2023 https://github.com/nodejs/node/pull/49943#pullrequestreview-1649859100
View reviewed changes https://github.com/nodejs/node/pull/49943/files/1bb2d08aed98af4f0531814f303ecf43407d7539
https://github.com/atlowChemi
atlowChemihttps://github.com/atlowChemi
Sep 29, 2023 https://github.com/nodejs/node/pull/49943#pullrequestreview-1650000588
View reviewed changes https://github.com/nodejs/node/pull/49943/files/1bb2d08aed98af4f0531814f303ecf43407d7539
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Sep 29, 2023 https://github.com/nodejs/node/pull/49943#pullrequestreview-1650011993
View reviewed changes https://github.com/nodejs/node/pull/49943/files/1bb2d08aed98af4f0531814f303ecf43407d7539
https://github.com/rluvaton
rluvatonhttps://github.com/rluvaton
Sep 29, 2023 https://github.com/nodejs/node/pull/49943#pullrequestreview-1650115499
View reviewed changes https://github.com/nodejs/node/pull/49943/files/1bb2d08aed98af4f0531814f303ecf43407d7539
https://github.com/rluvaton
rluvatonhttps://github.com/rluvaton
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 29, 2023https://github.com/nodejs/node/pull/49943#event-10507287275
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 29, 2023https://github.com/nodejs/node/pull/49943#event-10507293623
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 29, 2023https://github.com/nodejs/node/pull/49943#issuecomment-1740366467
https://ci.nodejs.org/job/node-test-pull-request/54352/https://ci.nodejs.org/job/node-test-pull-request/54352/
Please reload this pagehttps://github.com/nodejs/node/pull/49943
https://github.com/aduh95
aduh95https://github.com/aduh95
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 29, 2023https://github.com/nodejs/node/pull/49943#event-10508731136
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Sep 29, 2023 https://github.com/nodejs/node/pull/49943#pullrequestreview-1650402297
View reviewed changes https://github.com/nodejs/node/pull/49943/files/1bb2d08aed98af4f0531814f303ecf43407d7539
benjamingrhttps://github.com/benjamingr
https://github.com/nodejs/node/pull/49943#pullrequestreview-1650402297
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/49943
https://github.com/aduh95
aduh95https://github.com/aduh95
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 29, 2023https://github.com/nodejs/node/pull/49943#event-10509246970
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 29, 2023https://github.com/nodejs/node/pull/49943#issuecomment-1740603363
@aduh95https://github.com/aduh95
Please reload this pagehttps://github.com/nodejs/node/pull/49943
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
Sep 29, 2023 https://github.com/nodejs/node/pull/49943#pullrequestreview-1650551613
View reviewed changes https://github.com/nodejs/node/pull/49943/files/1bb2d08aed98af4f0531814f303ecf43407d7539
https://github.com/aduh95
aduh95https://github.com/aduh95
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 29, 2023https://github.com/nodejs/node/pull/49943#event-10510046420
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 29, 2023https://github.com/nodejs/node/pull/49943#event-10510076440
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c935d4chttps://github.com/nodejs/node/commit/c935d4c8fa4fb2f59445285fbf7a2e09776ff6de
Sep 29, 2023https://github.com/nodejs/node/pull/49943#event-10510077312
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 29, 2023https://github.com/nodejs/node/pull/49943#issuecomment-1740714252
c935d4chttps://github.com/nodejs/node/commit/c935d4c8fa4fb2f59445285fbf7a2e09776ff6de
Please reload this pagehttps://github.com/nodejs/node/pull/49943
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
September 29, 2023 13:25https://github.com/nodejs/node/pull/49943#event-10511432671
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Oct 9, 2023 https://github.com/nodejs/node/pull/49943#ref-pullrequest-1912846720
2023-10-17, Version 21.0.0 (Current) #49870 https://github.com/nodejs/node/pull/49870
alexfernandezhttps://github.com/alexfernandez
Nov 1, 2023 https://github.com/nodejs/node/pull/49943#ref-commit-fade0f4
https://github.com/cjihrig
https://github.com/alexfernandez
test_runner: replace spurious if with elsehttps://github.com/alexfernandez/node/commit/fade0f4d97e3853ca1e6685d1ef35fd23445540e
fade0f4https://github.com/alexfernandez/node/commit/fade0f4d97e3853ca1e6685d1ef35fd23445540e
nodejs#48915https://github.com/nodejs/node/pull/48915
nodejs#49943https://github.com/nodejs/node/pull/49943
targoshttps://github.com/targos
Nov 11, 2023 https://github.com/nodejs/node/pull/49943#ref-commit-10b35cf
https://github.com/cjihrig
https://github.com/targos
test_runner: replace spurious if with elsehttps://github.com/nodejs/node/commit/10b35cfb6e94b523e200f87253719d09c8f837b0
10b35cfhttps://github.com/nodejs/node/commit/10b35cfb6e94b523e200f87253719d09c8f837b0
#48915https://github.com/nodejs/node/pull/48915
#49943https://github.com/nodejs/node/pull/49943
https://github.com/targos
targoshttps://github.com/targos
Nov 12, 2023 https://github.com/nodejs/node/pull/49943#ref-pullrequest-1989293723
v20.10.0 release proposal #50682 https://github.com/nodejs/node/pull/50682
targoshttps://github.com/targos
Nov 27, 2023 https://github.com/nodejs/node/pull/49943#ref-commit-1d9c371
https://github.com/cjihrig
https://github.com/targos
test_runner: replace spurious if with elsehttps://github.com/nodejs/node/commit/1d9c37161df279da1e10ceb58009b9c20990d7f3
1d9c371https://github.com/nodejs/node/commit/1d9c37161df279da1e10ceb58009b9c20990d7f3
#48915https://github.com/nodejs/node/pull/48915
#49943https://github.com/nodejs/node/pull/49943
https://github.com/targos
targoshttps://github.com/targos
Nov 28, 2023 https://github.com/nodejs/node/pull/49943#ref-pullrequest-2014162105
v18.19.0 release proposal #50953 https://github.com/nodejs/node/pull/50953
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Dec 6, 2023 https://github.com/nodejs/node/pull/49943#ref-pullrequest-2029497346
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41 https://github.com/nodesource/nsolid/pull/41
debadree25https://github.com/debadree25
Apr 15, 2024 https://github.com/nodejs/node/pull/49943#ref-commit-0025722
https://github.com/cjihrig
https://github.com/debadree25
test_runner: replace spurious if with elsehttps://github.com/debadree25/node/commit/0025722eb9b5b0fb44883844d3268189608c828d
0025722https://github.com/debadree25/node/commit/0025722eb9b5b0fb44883844d3268189608c828d
nodejs#48915https://github.com/nodejs/node/pull/48915
nodejs#49943https://github.com/nodejs/node/pull/49943
sercherhttps://github.com/sercher
Apr 25, 2024 https://github.com/nodejs/node/pull/49943#ref-commit-ad9cae4
https://github.com/sercher
test_runner: replace spurious if with elsehttps://github.com/sercher/graaljs/commit/ad9cae493fab4f63df9a87fd475dfa350f7875c0
ad9cae4https://github.com/sercher/graaljs/commit/ad9cae493fab4f63df9a87fd475dfa350f7875c0
nodejs/node#48915https://github.com/nodejs/node/pull/48915
nodejs/node#49943https://github.com/nodejs/node/pull/49943
sercherhttps://github.com/sercher
Apr 25, 2024 https://github.com/nodejs/node/pull/49943#ref-commit-f0691a1
https://github.com/sercher
test_runner: replace spurious if with elsehttps://github.com/sercher/graaljs/commit/f0691a1312350acf1b110478e64f0f020963c60a
f0691a1https://github.com/sercher/graaljs/commit/f0691a1312350acf1b110478e64f0f020963c60a
nodejs/node#48915https://github.com/nodejs/node/pull/48915
nodejs/node#49943https://github.com/nodejs/node/pull/49943
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49943
https://github.com/ljharb
ljharb https://github.com/ljharb
https://github.com/nodejs/node/pull/49943/files/1bb2d08aed98af4f0531814f303ecf43407d7539
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/49943/files/1bb2d08aed98af4f0531814f303ecf43407d7539
https://github.com/MoLow
MoLow https://github.com/MoLow
https://github.com/nodejs/node/pull/49943/files/1bb2d08aed98af4f0531814f303ecf43407d7539
https://github.com/rluvaton
rluvaton https://github.com/rluvaton
https://github.com/nodejs/node/pull/49943/files/1bb2d08aed98af4f0531814f303ecf43407d7539
https://github.com/atlowChemi
atlowChemi https://github.com/atlowChemi
https://github.com/nodejs/node/pull/49943/files/1bb2d08aed98af4f0531814f303ecf43407d7539
https://github.com/LiviaMedeiros
LiviaMedeiros https://github.com/LiviaMedeiros
https://github.com/nodejs/node/pull/49943/files/1bb2d08aed98af4f0531814f303ecf43407d7539
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test_runner https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner
Please reload this pagehttps://github.com/nodejs/node/pull/49943
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com/ljharb
https://github.com/benjamingr
https://github.com/MoLow
https://github.com/rluvaton
https://github.com/atlowChemi
https://github.com/LiviaMedeiros
https://github.com/aduh95
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.