| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:195edcdd-e8dc-d37c-ff68-ef9094a684b4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BAC4:2265AE:C5B44D:1116461:696A8C28 |
| html-safe-nonce | c86b6dd5dedf0a2c7af41738434212b539e9585e67cd285dbbd76d9a9e14e58b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQUM0OjIyNjVBRTpDNUI0NEQ6MTExNjQ2MTo2OTZBOEMyOCIsInZpc2l0b3JfaWQiOiI3NzY1NDcyNjAyOTA4OTUzNjQwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | f7085a88bbcb46ea87d5bdb7c2cdb9266ba06b74d29d9dd14d221a0cc23ab6aa |
| hovercard-subject-tag | pull_request:1532301705 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/49893/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a96486e08e897aff4700369498b26e95f1b1a60288ad6545f5b15a55347e91aa/nodejs/node/pull/49893 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a96486e08e897aff4700369498b26e95f1b1a60288ad6545f5b15a55347e91aa/nodejs/node/pull/49893 |
| og:image:alt | Currently, It takes the fast route when path string is represented as a OneByteString in V8.
confidence improvement accuracy (*) (**) (*... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | littledivy |
| hostname | github.com |
| expected-hostname | github.com |
| None | d2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c1dbca8981c5e3d6a69bce2f1d289e732b86241d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/49893#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49893 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49893 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/49893 |
| Reload | https://github.com/nodejs/node/pull/49893 |
| Reload | https://github.com/nodejs/node/pull/49893 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/49893#issue-comment-box |
| littledivy | https://github.com/littledivy |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| littledivy:perf-existsSync | https://github.com/littledivy/node/tree/perf-existsSync |
|
fs: use fast api calls for existsSync
| https://github.com/nodejs/node/pull/49893#top |
| littledivy | https://github.com/littledivy |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| littledivy:perf-existsSync | https://github.com/littledivy/node/tree/perf-existsSync |
|
Conversation
30
| https://github.com/nodejs/node/pull/49893 |
|
Commits
8
| https://github.com/nodejs/node/pull/49893/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/49893/checks |
|
Files changed
| https://github.com/nodejs/node/pull/49893/files |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/littledivy |
| littledivy | https://github.com/littledivy |
| Sep 27, 2023 | https://github.com/nodejs/node/pull/49893#issue-1915425231 |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Sep 27, 2023 | https://github.com/nodejs/node/pull/49893#event-10486622265 |
| littledivy | https://github.com/littledivy |
| September 27, 2023 17:46 | https://github.com/nodejs/node/pull/49893#commits-pushed-f413971 |
|
| https://github.com/littledivy |
| fs: improve performance of existsSync | https://github.com/nodejs/node/pull/49893/commits/f413971a2bb2c529d155e1e41399d916efa1558c |
| f413971 | https://github.com/nodejs/node/pull/49893/commits/f413971a2bb2c529d155e1e41399d916efa1558c |
|
| https://github.com/littledivy |
| Format | https://github.com/nodejs/node/pull/49893/commits/dd08af96f25a78cdbd1bae8f231ae85b1ffdc2be |
| dd08af9 | https://github.com/nodejs/node/pull/49893/commits/dd08af96f25a78cdbd1bae8f231ae85b1ffdc2be |
| https://github.com/littledivy |
| littledivy | https://github.com/littledivy |
| force-pushed | https://github.com/nodejs/node/compare/e5014d5a4ca16e78700118c5ede8dfdafb128d80..dd08af96f25a78cdbd1bae8f231ae85b1ffdc2be |
| e5014d5 | https://github.com/nodejs/node/commit/e5014d5a4ca16e78700118c5ede8dfdafb128d80 |
| dd08af9 | https://github.com/nodejs/node/commit/dd08af96f25a78cdbd1bae8f231ae85b1ffdc2be |
|
Compare
| https://github.com/nodejs/node/compare/e5014d5a4ca16e78700118c5ede8dfdafb128d80..dd08af96f25a78cdbd1bae8f231ae85b1ffdc2be |
| September 27, 2023 12:17 | https://github.com/nodejs/node/pull/49893#event-10486695878 |
| https://github.com/panva |
| panva | https://github.com/panva |
|
performance
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 27, 2023 | https://github.com/nodejs/node/pull/49893#event-10486854370 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 27, 2023 | https://github.com/nodejs/node/pull/49893#event-10487018247 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 27, 2023 | https://github.com/nodejs/node/pull/49893#issuecomment-1737324918 |
| https://ci.nodejs.org/job/node-test-pull-request/54279/ | https://ci.nodejs.org/job/node-test-pull-request/54279/ |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Sep 27, 2023
| https://github.com/nodejs/node/pull/49893#pullrequestreview-1646396264 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/49893/files/dd08af96f25a78cdbd1bae8f231ae85b1ffdc2be |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Sep 27, 2023 | https://github.com/nodejs/node/pull/49893#event-10487117071 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| Sep 27, 2023 | https://github.com/nodejs/node/pull/49893#issuecomment-1737380093 |
| @littledivy | https://github.com/littledivy |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
| https://github.com/debadree25 |
| debadree25 | https://github.com/debadree25 |
|
Sep 27, 2023
| https://github.com/nodejs/node/pull/49893#pullrequestreview-1646513547 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/49893/files/dd08af96f25a78cdbd1bae8f231ae85b1ffdc2be |
| debadree25 | https://github.com/debadree25 |
| https://github.com/nodejs/node/pull/49893#pullrequestreview-1646513547 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
needs-benchmark-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-benchmark-ci |
| Sep 27, 2023 | https://github.com/nodejs/node/pull/49893#event-10487781623 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Sep 27, 2023
| https://github.com/nodejs/node/pull/49893#pullrequestreview-1646618478 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/49893/files/dd08af96f25a78cdbd1bae8f231ae85b1ffdc2be |
| src/node_file.cc | https://github.com/nodejs/node/pull/49893/files/dd08af96f25a78cdbd1bae8f231ae85b1ffdc2be#diff-70e3325bd2115867617ae2a16321c5de53c070ff2841976fe5b849675a5111e6 |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Sep 27, 2023 | https://github.com/nodejs/node/pull/49893#event-10487873105 |
|
| https://github.com/littledivy |
| Merge branch 'main' into perf-existsSync | https://github.com/nodejs/node/pull/49893/commits/ac4be44354e96f05cd94df31b3823b2929547f2a |
| ac4be44 | https://github.com/nodejs/node/pull/49893/commits/ac4be44354e96f05cd94df31b3823b2929547f2a |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
commit-queue-squash
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash |
| Sep 27, 2023 | https://github.com/nodejs/node/pull/49893#event-10487936941 |
| littledivy | https://github.com/littledivy |
| September 27, 2023 19:33 | https://github.com/nodejs/node/pull/49893#commits-pushed-69736c2 |
|
| https://github.com/littledivy |
| Add test for fast call | https://github.com/nodejs/node/pull/49893/commits/69736c27795ba73243b1a1ed89cf1f8f5416b5c5 |
| 69736c2 | https://github.com/nodejs/node/pull/49893/commits/69736c27795ba73243b1a1ed89cf1f8f5416b5c5 |
|
| https://github.com/littledivy |
| Fix lint js | https://github.com/nodejs/node/pull/49893/commits/176cbdc6abc2b3c8b655359f656ec0e36cd32d03 |
| 176cbdc | https://github.com/nodejs/node/pull/49893/commits/176cbdc6abc2b3c8b655359f656ec0e36cd32d03 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Sep 27, 2023
| https://github.com/nodejs/node/pull/49893#pullrequestreview-1646698574 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/49893/files/69736c27795ba73243b1a1ed89cf1f8f5416b5c5 |
| test/parallel/test-fs-exists.js | https://github.com/nodejs/node/pull/49893/files/ac4be44354e96f05cd94df31b3823b2929547f2a..69736c27795ba73243b1a1ed89cf1f8f5416b5c5#diff-035255a7bae04bfe1e15a68fcbb5fb183838294d0dd69c04ccb01e8211c18703 |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
|
| https://github.com/littledivy |
| Add test for true existsSync | https://github.com/nodejs/node/pull/49893/commits/8d331edfd506e44c64c1dbbbee4c9507a740fb94 |
| 8d331ed | https://github.com/nodejs/node/pull/49893/commits/8d331edfd506e44c64c1dbbbee4c9507a740fb94 |
| https://github.com/CanadaHonk |
| CanadaHonk | https://github.com/CanadaHonk |
|
Sep 27, 2023
| https://github.com/nodejs/node/pull/49893#pullrequestreview-1646722524 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/49893/files/8d331edfd506e44c64c1dbbbee4c9507a740fb94 |
| src/node_file.cc | https://github.com/nodejs/node/pull/49893/files/8d331edfd506e44c64c1dbbbee4c9507a740fb94#diff-70e3325bd2115867617ae2a16321c5de53c070ff2841976fe5b849675a5111e6 |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Sep 27, 2023
| https://github.com/nodejs/node/pull/49893#pullrequestreview-1646728987 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/49893/files/8d331edfd506e44c64c1dbbbee4c9507a740fb94 |
| src/node_file.cc | https://github.com/nodejs/node/pull/49893/files/8d331edfd506e44c64c1dbbbee4c9507a740fb94#diff-70e3325bd2115867617ae2a16321c5de53c070ff2841976fe5b849675a5111e6 |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
| littledivy | https://github.com/littledivy |
| September 27, 2023 21:14 | https://github.com/nodejs/node/pull/49893#commits-pushed-7a37e48 |
|
| https://github.com/littledivy |
| Use SetFastMethod | https://github.com/nodejs/node/pull/49893/commits/7a37e48b220ba85bcc1cc09a1ca6184e684f4ae7 |
| 7a37e48 | https://github.com/nodejs/node/pull/49893/commits/7a37e48b220ba85bcc1cc09a1ca6184e684f4ae7 |
|
| https://github.com/littledivy |
| Format | https://github.com/nodejs/node/pull/49893/commits/e2e734196b4a46f3ef132ec0242afb1c5830bac9 |
| e2e7341 | https://github.com/nodejs/node/pull/49893/commits/e2e734196b4a46f3ef132ec0242afb1c5830bac9 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 27, 2023 | https://github.com/nodejs/node/pull/49893#event-10490167805 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 27, 2023 | https://github.com/nodejs/node/pull/49893#event-10490182504 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 27, 2023 | https://github.com/nodejs/node/pull/49893#issuecomment-1737778442 |
| https://ci.nodejs.org/job/node-test-pull-request/54301/ | https://ci.nodejs.org/job/node-test-pull-request/54301/ |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 27, 2023 | https://github.com/nodejs/node/pull/49893#event-10490194583 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 27, 2023 | https://github.com/nodejs/node/pull/49893#event-10490253525 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 27, 2023 | https://github.com/nodejs/node/pull/49893#issuecomment-1737789357 |
| https://ci.nodejs.org/job/node-test-pull-request/54303/ | https://ci.nodejs.org/job/node-test-pull-request/54303/ |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Sep 27, 2023
| https://github.com/nodejs/node/pull/49893#pullrequestreview-1647360659 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/49893/files/e2e734196b4a46f3ef132ec0242afb1c5830bac9 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Sep 27, 2023
| https://github.com/nodejs/node/pull/49893#pullrequestreview-1647674871 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/49893/files/e2e734196b4a46f3ef132ec0242afb1c5830bac9 |
| src/node_file.cc | https://github.com/nodejs/node/pull/49893/files/e2e734196b4a46f3ef132ec0242afb1c5830bac9#diff-70e3325bd2115867617ae2a16321c5de53c070ff2841976fe5b849675a5111e6 |
| joyeecheung | https://github.com/joyeecheung |
| Sep 27, 2023 | https://github.com/nodejs/node/pull/49893#discussion_r1339312259 |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Sep 27, 2023
| https://github.com/nodejs/node/pull/49893#pullrequestreview-1647683786 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/49893/files/e2e734196b4a46f3ef132ec0242afb1c5830bac9 |
| test/parallel/test-fs-exists.js | https://github.com/nodejs/node/pull/49893/files/e2e734196b4a46f3ef132ec0242afb1c5830bac9#diff-035255a7bae04bfe1e15a68fcbb5fb183838294d0dd69c04ccb01e8211c18703 |
| joyeecheung | https://github.com/joyeecheung |
| Sep 27, 2023 | https://github.com/nodejs/node/pull/49893#discussion_r1339321451 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
| targos | https://github.com/targos |
| Sep 28, 2023 | https://github.com/nodejs/node/pull/49893#discussion_r1339534826 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
| targos | https://github.com/targos |
| Sep 29, 2023 | https://github.com/nodejs/node/pull/49893#discussion_r1340925175 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
| joyeecheung | https://github.com/joyeecheung |
| Oct 2, 2023 | https://github.com/nodejs/node/pull/49893#discussion_r1342714408 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
| joyeecheung | https://github.com/joyeecheung |
| Oct 2, 2023 | https://github.com/nodejs/node/pull/49893#discussion_r1342716584 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Sep 28, 2023
| https://github.com/nodejs/node/pull/49893#ref-issue-1916518203 |
|
CI Reliability 2023-09-28
nodejs/reliability#677
| https://github.com/nodejs/reliability/issues/677 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Sep 29, 2023
| https://github.com/nodejs/node/pull/49893#pullrequestreview-1651421711 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/49893/files/e2e734196b4a46f3ef132ec0242afb1c5830bac9 |
| src/node_file.cc | https://github.com/nodejs/node/pull/49893/files/e2e734196b4a46f3ef132ec0242afb1c5830bac9#diff-70e3325bd2115867617ae2a16321c5de53c070ff2841976fe5b849675a5111e6 |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Oct 3, 2023
| https://github.com/nodejs/node/pull/49893#ref-pullrequest-1924979761 |
|
fix: use fs.existsSync to avoid race condition
vercel/next.js#56387
| https://github.com/vercel/next.js/pull/56387 |
| huozhi | https://github.com/huozhi |
|
Oct 3, 2023
| https://github.com/nodejs/node/pull/49893#ref-commit-a46c5af |
|
| https://github.com/anonrig |
|
| https://github.com/marketplace/kodiakhq |
| fix: use | https://github.com/vercel/next.js/commit/a46c5afa608b88fed85d152530b22383b51bf416 |
| fs.existsSync | https://github.com/vercel/next.js/commit/a46c5afa608b88fed85d152530b22383b51bf416 |
| to avoid race condition ( | https://github.com/vercel/next.js/commit/a46c5afa608b88fed85d152530b22383b51bf416 |
| #56387 | https://github.com/vercel/next.js/pull/56387 |
| ) | https://github.com/vercel/next.js/commit/a46c5afa608b88fed85d152530b22383b51bf416 |
| a46c5af | https://github.com/vercel/next.js/commit/a46c5afa608b88fed85d152530b22383b51bf416 |
| nodejs/node#49893 | https://github.com/nodejs/node/pull/49893 |
| nodejs/node#49593 | https://github.com/nodejs/node/pull/49593 |
| https://github.com/fhinkel |
| fhinkel | https://github.com/fhinkel |
|
Jan 28, 2024
| https://github.com/nodejs/node/pull/49893#pullrequestreview-1847586243 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/49893/files/e2e734196b4a46f3ef132ec0242afb1c5830bac9 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| May 11, 2024 | https://github.com/nodejs/node/pull/49893#issuecomment-2105886334 |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
| https://github.com/avivkeller |
| avivkeller | https://github.com/avivkeller |
| Aug 9, 2024 | https://github.com/nodejs/node/pull/49893#issuecomment-2278815985 |
| @aduh95 | https://github.com/aduh95 |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
| https://github.com/avivkeller |
| avivkeller | https://github.com/avivkeller |
|
stalled
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled |
| Aug 9, 2024 | https://github.com/nodejs/node/pull/49893#event-13826000491 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Aug 9, 2024 | https://github.com/nodejs/node/pull/49893#issuecomment-2278816225 |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
| https://github.com/avivkeller |
| avivkeller | https://github.com/avivkeller |
| Oct 15, 2024 | https://github.com/nodejs/node/pull/49893#event-14655241392 |
| https://github.com/littledivy |
| littledivy | https://github.com/littledivy |
| Oct 15, 2024 | https://github.com/nodejs/node/pull/49893#issuecomment-2413830607 |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
| https://github.com/avivkeller |
| avivkeller | https://github.com/avivkeller |
| Oct 15, 2024 | https://github.com/nodejs/node/pull/49893#issuecomment-2414530909 |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49893 |
|
| https://github.com/anonrig |
|
anonrig
| https://github.com/anonrig |
|
| https://github.com/nodejs/node/pull/49893/files/e2e734196b4a46f3ef132ec0242afb1c5830bac9 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/49893/files/e2e734196b4a46f3ef132ec0242afb1c5830bac9 |
|
| https://github.com/tniessen |
|
tniessen
| https://github.com/tniessen |
|
| https://github.com/nodejs/node/pull/49893/files/e2e734196b4a46f3ef132ec0242afb1c5830bac9 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/49893/files/e2e734196b4a46f3ef132ec0242afb1c5830bac9 |
|
| https://github.com/debadree25 |
|
debadree25
| https://github.com/debadree25 |
|
| https://github.com/nodejs/node/pull/49893/files/dd08af96f25a78cdbd1bae8f231ae85b1ffdc2be |
|
| https://github.com/fhinkel |
|
fhinkel
| https://github.com/fhinkel |
|
| https://github.com/nodejs/node/pull/49893/files/e2e734196b4a46f3ef132ec0242afb1c5830bac9 |
|
| https://github.com/mscdex |
|
mscdex
| https://github.com/mscdex |
|
| https://github.com/nodejs/node/pull/49893/files/dd08af96f25a78cdbd1bae8f231ae85b1ffdc2be |
|
| https://github.com/CanadaHonk |
|
CanadaHonk
| https://github.com/CanadaHonk |
|
| https://github.com/nodejs/node/pull/49893/files/8d331edfd506e44c64c1dbbbee4c9507a740fb94 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
commit-queue-squash
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
needs-benchmark-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-benchmark-ci |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
performance
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance |
|
stalled
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled |
| Please reload this page | https://github.com/nodejs/node/pull/49893 |
|
| https://github.com/littledivy |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/anonrig |
|
| https://github.com/aduh95 |
|
| https://github.com/avivkeller |
|
| https://github.com/mscdex |
|
| https://github.com/fhinkel |
|
| https://github.com/targos |
|
| https://github.com/tniessen |
|
| https://github.com/joyeecheung |
|
| https://github.com/CanadaHonk |
|
| https://github.com/debadree25 |
|
| https://github.com/panva |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |