René's URL Explorer Experiment


Title: fs: replace `SetMethodNoSideEffect` in `node_file.cc` by CanadaHonk · Pull Request #49857 · nodejs/node · GitHub

Open Graph Title: fs: replace `SetMethodNoSideEffect` in `node_file.cc` by CanadaHonk · Pull Request #49857 · nodejs/node

X Title: fs: replace `SetMethodNoSideEffect` in `node_file.cc` by CanadaHonk · Pull Request #49857 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: All FS methods should not use it since FS operations will have side effects (suggested by @anonrig)

X Description: All FS methods should not use it since FS operations will have side effects (suggested by @anonrig)

Opengraph URL: https://github.com/nodejs/node/pull/49857

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5f5e3252-c57e-1d91-7b29-92865721730a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB3F8:1DCD:E846F3:13E90C3:6992F439
html-safe-nonce78db1e5938dadcd5c3089edfa35009943d89133e434042ae00c080415ea4d044
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCM0Y4OjFEQ0Q6RTg0NkYzOjEzRTkwQzM6Njk5MkY0MzkiLCJ2aXNpdG9yX2lkIjoiNzI5MjE5OTQxNzkwODM5ODY1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac448a3b631e65a7d817d1fb9e020acefaedc52b43e5420f91046ec2b87c9a5407
hovercard-subject-tagpull_request:1528773874
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/49857/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bd6690b68bfa367f3901ceb237df24661cd8ef0b0786501674feb03ea70ec9fc/nodejs/node/pull/49857
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bd6690b68bfa367f3901ceb237df24661cd8ef0b0786501674feb03ea70ec9fc/nodejs/node/pull/49857
og:image:altAll FS methods should not use it since FS operations will have side effects (suggested by @anonrig)
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameCanadaHonk
hostnamegithub.com
expected-hostnamegithub.com
None348cc0594c4976eb4050dc9547ecf65057ee89a2b7ed0652b983b9b539f57145
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasece72317238c729e85014e1d867fd30d09b7f94ba
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/49857#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49857
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49857
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/49857
Reloadhttps://github.com/nodejs/node/pull/49857
Reloadhttps://github.com/nodejs/node/pull/49857
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/49857
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.7k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 714 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
CanadaHonk:fs-replace-nosideeffecthttps://github.com/CanadaHonk/node/tree/fs-replace-nosideeffect
Conversationhttps://github.com/nodejs/node/pull/49857
Commits1 (1)https://github.com/nodejs/node/pull/49857/commits
Checkshttps://github.com/nodejs/node/pull/49857/checks
Files changedhttps://github.com/nodejs/node/pull/49857/files
fs: replace SetMethodNoSideEffect in node_file.cchttps://github.com/nodejs/node/pull/49857#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
CanadaHonk:fs-replace-nosideeffecthttps://github.com/CanadaHonk/node/tree/fs-replace-nosideeffect
https://github.com/CanadaHonk
CanadaHonkhttps://github.com/CanadaHonk
Sep 25, 2023https://github.com/nodejs/node/pull/49857#issue-1911457549
@anonrighttps://github.com/anonrig
Please reload this pagehttps://github.com/nodejs/node/pull/49857
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Sep 25, 2023https://github.com/nodejs/node/pull/49857#event-10462362893
https://github.com/anonrig
anonrighttps://github.com/anonrig
Sep 25, 2023https://github.com/nodejs/node/pull/49857#issuecomment-1733681219
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/49857
https://github.com/anonrig
anonrighttps://github.com/anonrig
Sep 25, 2023 https://github.com/nodejs/node/pull/49857#pullrequestreview-1642130054
View reviewed changes https://github.com/nodejs/node/pull/49857/files/bf379eff9ed6344bfce810acc8486c0b67e7000e
https://github.com/anonrig
anonrighttps://github.com/anonrig
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 25, 2023https://github.com/nodejs/node/pull/49857#event-10462519012
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49857
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 25, 2023https://github.com/nodejs/node/pull/49857#event-10462562020
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 25, 2023https://github.com/nodejs/node/pull/49857#issuecomment-1733689046
https://ci.nodejs.org/job/node-test-pull-request/54214/https://ci.nodejs.org/job/node-test-pull-request/54214/
Please reload this pagehttps://github.com/nodejs/node/pull/49857
https://github.com/CanadaHonk
fs: replace SetMethodNoSideEffect in node_filehttps://github.com/nodejs/node/pull/49857/commits/bf379eff9ed6344bfce810acc8486c0b67e7000e
bf379efhttps://github.com/nodejs/node/pull/49857/commits/bf379eff9ed6344bfce810acc8486c0b67e7000e
https://github.com/CanadaHonk
CanadaHonkhttps://github.com/CanadaHonk
force-pushedhttps://github.com/nodejs/node/compare/2cf762ef2c41eb53c6c4ba0092eec4a3562ddc3d..bf379eff9ed6344bfce810acc8486c0b67e7000e
2cf762ehttps://github.com/nodejs/node/commit/2cf762ef2c41eb53c6c4ba0092eec4a3562ddc3d
bf379efhttps://github.com/nodejs/node/commit/bf379eff9ed6344bfce810acc8486c0b67e7000e
Compare https://github.com/nodejs/node/compare/2cf762ef2c41eb53c6c4ba0092eec4a3562ddc3d..bf379eff9ed6344bfce810acc8486c0b67e7000e
September 25, 2023 13:19https://github.com/nodejs/node/pull/49857#event-10462632761
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Sep 25, 2023https://github.com/nodejs/node/pull/49857#issuecomment-1733700119
Please reload this pagehttps://github.com/nodejs/node/pull/49857
https://github.com/CanadaHonk
CanadaHonkhttps://github.com/CanadaHonk
Sep 25, 2023https://github.com/nodejs/node/pull/49857#issuecomment-1733707779
Please reload this pagehttps://github.com/nodejs/node/pull/49857
https://github.com/anonrig
anonrighttps://github.com/anonrig
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 25, 2023https://github.com/nodejs/node/pull/49857#event-10462764705
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 25, 2023https://github.com/nodejs/node/pull/49857#event-10462829756
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 25, 2023https://github.com/nodejs/node/pull/49857#issuecomment-1733728555
https://ci.nodejs.org/job/node-test-pull-request/54217/https://ci.nodejs.org/job/node-test-pull-request/54217/
Please reload this pagehttps://github.com/nodejs/node/pull/49857
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 25, 2023https://github.com/nodejs/node/pull/49857#issuecomment-1734097188
https://ci.nodejs.org/job/node-test-pull-request/54221/https://ci.nodejs.org/job/node-test-pull-request/54221/
Please reload this pagehttps://github.com/nodejs/node/pull/49857
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Sep 25, 2023https://github.com/nodejs/node/pull/49857#issuecomment-1734125684
Please reload this pagehttps://github.com/nodejs/node/pull/49857
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Sep 25, 2023https://github.com/nodejs/node/pull/49857#event-10465455606
https://github.com/targos
targoshttps://github.com/targos
Sep 25, 2023https://github.com/nodejs/node/pull/49857#issuecomment-1734278721
Please reload this pagehttps://github.com/nodejs/node/pull/49857
Please reload this pagehttps://github.com/nodejs/node/pull/49857
https://github.com/anonrig
anonrighttps://github.com/anonrig
Sep 25, 2023https://github.com/nodejs/node/pull/49857#issuecomment-1734296201
@joyeecheunghttps://github.com/joyeecheung
#49748 (comment)https://github.com/nodejs/node/pull/49748#discussion_r1334851749
Please reload this pagehttps://github.com/nodejs/node/pull/49857
https://github.com/targos
targoshttps://github.com/targos
Sep 25, 2023 https://github.com/nodejs/node/pull/49857#pullrequestreview-1642822078
View reviewed changes https://github.com/nodejs/node/pull/49857/files/bf379eff9ed6344bfce810acc8486c0b67e7000e
https://github.com/anonrig
anonrighttps://github.com/anonrig
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 25, 2023https://github.com/nodejs/node/pull/49857#event-10466542945
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Sep 26, 2023https://github.com/nodejs/node/pull/49857#issuecomment-1735819605
@joyeecheunghttps://github.com/joyeecheung
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/49857
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 27, 2023 https://github.com/nodejs/node/pull/49857#ref-issue-1914465046
CI Reliability 2023-09-27 nodejs/reliability#676 https://github.com/nodejs/reliability/issues/676
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 27, 2023https://github.com/nodejs/node/pull/49857#event-10487311007
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
783f64bhttps://github.com/nodejs/node/commit/783f64bd981a10dae7dc4ce297843ce4a0a26f5c
Sep 27, 2023https://github.com/nodejs/node/pull/49857#event-10487312020
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 27, 2023https://github.com/nodejs/node/pull/49857#issuecomment-1737365204
783f64bhttps://github.com/nodejs/node/commit/783f64bd981a10dae7dc4ce297843ce4a0a26f5c
Please reload this pagehttps://github.com/nodejs/node/pull/49857
https://github.com/CanadaHonk
CanadaHonkhttps://github.com/CanadaHonk
Sep 27, 2023 https://github.com/nodejs/node/pull/49857#ref-pullrequest-1915425231
fs: use fast api calls for existsSync #49893 https://github.com/nodejs/node/pull/49893
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 28, 2023 https://github.com/nodejs/node/pull/49857#ref-issue-1916518203
CI Reliability 2023-09-28 nodejs/reliability#677 https://github.com/nodejs/reliability/issues/677
ruyadornohttps://github.com/ruyadorno
Sep 28, 2023 https://github.com/nodejs/node/pull/49857#ref-commit-9363179
https://github.com/CanadaHonk
https://github.com/ruyadorno
fs: replace SetMethodNoSideEffect in node_filehttps://github.com/nodejs/node/commit/9363179b39f45a4c762bd6962918b65c01523779
9363179https://github.com/nodejs/node/commit/9363179b39f45a4c762bd6962918b65c01523779
#49857https://github.com/nodejs/node/pull/49857
https://github.com/ruyadorno
ruyadornohttps://github.com/ruyadorno
Sep 28, 2023 https://github.com/nodejs/node/pull/49857#ref-pullrequest-1916668996
v20.7.1 proposal #49917 https://github.com/nodejs/node/pull/49917
ruyadornohttps://github.com/ruyadorno
Sep 28, 2023 https://github.com/nodejs/node/pull/49857#ref-commit-ec323bb
https://github.com/CanadaHonk
https://github.com/ruyadorno
fs: replace SetMethodNoSideEffect in node_filehttps://github.com/nodejs/node/commit/ec323bbd998202d6ad27124158ce532f80c13472
ec323bbhttps://github.com/nodejs/node/commit/ec323bbd998202d6ad27124158ce532f80c13472
#49857https://github.com/nodejs/node/pull/49857
https://github.com/ruyadorno
ruyadornohttps://github.com/ruyadorno
Sep 28, 2023 https://github.com/nodejs/node/pull/49857#ref-pullrequest-1917715735
v20.8.0 proposal #49932 https://github.com/nodejs/node/pull/49932
alexfernandezhttps://github.com/alexfernandez
Nov 1, 2023 https://github.com/nodejs/node/pull/49857#ref-commit-c7f1635
https://github.com/CanadaHonk
https://github.com/alexfernandez
fs: replace SetMethodNoSideEffect in node_filehttps://github.com/alexfernandez/node/commit/c7f1635e0de1de15134819728ad589e07a3fb5d8
c7f1635https://github.com/alexfernandez/node/commit/c7f1635e0de1de15134819728ad589e07a3fb5d8
nodejs#49857https://github.com/nodejs/node/pull/49857
debadree25https://github.com/debadree25
Apr 15, 2024 https://github.com/nodejs/node/pull/49857#ref-commit-554bc6e
https://github.com/CanadaHonk
https://github.com/debadree25
fs: replace SetMethodNoSideEffect in node_filehttps://github.com/debadree25/node/commit/554bc6e3cc0c32b26bd0065767cad169edd57c67
554bc6ehttps://github.com/debadree25/node/commit/554bc6e3cc0c32b26bd0065767cad169edd57c67
nodejs#49857https://github.com/nodejs/node/pull/49857
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49857
https://github.com/anonrig
anonrig https://github.com/anonrig
https://github.com/nodejs/node/pull/49857/files/bf379eff9ed6344bfce810acc8486c0b67e7000e
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/49857/files/bf379eff9ed6344bfce810acc8486c0b67e7000e
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/49857
https://github.com/CanadaHonk
https://github.com/anonrig
https://github.com/nodejs-github-bot
https://github.com/benjamingr
https://github.com/cjihrig
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.