René's URL Explorer Experiment


Title: esm: require braces for modules code by GeoffreyBooth · Pull Request #49657 · nodejs/node · GitHub

Open Graph Title: esm: require braces for modules code by GeoffreyBooth · Pull Request #49657 · nodejs/node

X Title: esm: require braces for modules code by GeoffreyBooth · Pull Request #49657 · nodejs/node

Description: Split out from #49523 per #49523 (comment). This PR adds a lint rule to formalize our informal rule for modules code, where we try to always use braces to enclose blocks (so no implicit blocks aft...

Open Graph Description: Split out from #49523 per #49523 (comment). This PR adds a lint rule to formalize our informal rule for modules code, where we try to always use braces to enclose blocks (so no implicit blocks aft...

X Description: Split out from #49523 per #49523 (comment). This PR adds a lint rule to formalize our informal rule for modules code, where we try to always use braces to enclose blocks (so no implicit blocks aft...

Opengraph URL: https://github.com/nodejs/node/pull/49657

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c337fa29-a0d8-c0d7-c6c0-969e99373f0e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB4A4:250A02:1324CB6:1989DE2:69699C9C
html-safe-nonceb14fc93c706705633d09dadc34b3241e0b815aab1934994bf42e7655297da274
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEE0OjI1MEEwMjoxMzI0Q0I2OjE5ODlERTI6Njk2OTlDOUMiLCJ2aXNpdG9yX2lkIjoiMTg5OTIxNTM1MDE0NTg1MDUyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7478081cb9965113764ccdb92001d46a98b8e7d221ab96d604dc2e3dfe42244b
hovercard-subject-tagpull_request:1516430989
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/49657/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1a1850ccc4d0e10eac377f4ff57b1fc77f21fa6c20a511681c4981eae38c7feb/nodejs/node/pull/49657
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1a1850ccc4d0e10eac377f4ff57b1fc77f21fa6c20a511681c4981eae38c7feb/nodejs/node/pull/49657
og:image:altSplit out from #49523 per #49523 (comment). This PR adds a lint rule to formalize our informal rule for modules code, where we try to always use braces to enclose blocks (so no implicit blocks aft...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameGeoffreyBooth
hostnamegithub.com
expected-hostnamegithub.com
None24c4c97a2d520cb286b35e1a4c22d7a4df3c26a2fa28dd7cdf0e65db327b4de7
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release124667f43168afb6c9c03b7c02eb5b1d2e1be3d9
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/49657#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49657
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49657
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/49657
Reloadhttps://github.com/nodejs/node/pull/49657
Reloadhttps://github.com/nodejs/node/pull/49657
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/49657
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/49657
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/49657#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
GeoffreyBooth:modules-code-add-braceshttps://github.com/GeoffreyBooth/node/tree/modules-code-add-braces
esm: require braces for modules code https://github.com/nodejs/node/pull/49657#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
GeoffreyBooth:modules-code-add-braceshttps://github.com/GeoffreyBooth/node/tree/modules-code-add-braces
Conversation 39 https://github.com/nodejs/node/pull/49657
Commits 5 https://github.com/nodejs/node/pull/49657/commits
Checks 0 https://github.com/nodejs/node/pull/49657/checks
Files changed https://github.com/nodejs/node/pull/49657/files
Please reload this pagehttps://github.com/nodejs/node/pull/49657
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Sep 14, 2023https://github.com/nodejs/node/pull/49657#issue-1897387242
#49523https://github.com/nodejs/node/pull/49523
#49523 (comment)https://github.com/nodejs/node/pull/49523#discussion_r1326244760
Please reload this pagehttps://github.com/nodejs/node/pull/49657
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Sep 14, 2023https://github.com/nodejs/node/pull/49657#event-10377283635
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
aduh95https://github.com/aduh95
September 14, 2023 22:08https://github.com/nodejs/node/pull/49657#event-10377283645
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 14, 2023https://github.com/nodejs/node/pull/49657#issuecomment-1720218970
Please reload this pagehttps://github.com/nodejs/node/pull/49657
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 14, 2023https://github.com/nodejs/node/pull/49657#issuecomment-1720219065
@GeoffreyBoothhttps://github.com/GeoffreyBooth
Please reload this pagehttps://github.com/nodejs/node/pull/49657
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Sep 14, 2023https://github.com/nodejs/node/pull/49657#event-10377285623
https://github.com/ljharb
ljharbhttps://github.com/ljharb
Sep 14, 2023 https://github.com/nodejs/node/pull/49657#pullrequestreview-1627844513
View reviewed changes https://github.com/nodejs/node/pull/49657/files
https://github.com/aduh95
aduh95https://github.com/aduh95
Sep 14, 2023 https://github.com/nodejs/node/pull/49657#pullrequestreview-1627855080
View reviewed changes https://github.com/nodejs/node/pull/49657/files
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/49657/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/49657
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
force-pushedhttps://github.com/nodejs/node/compare/9a8027e9fa11aaac32495d55513b266a652d9777..83342a5cb2001f5cee92cd6e9486f8f4bde96eb3
9a8027ehttps://github.com/nodejs/node/commit/9a8027e9fa11aaac32495d55513b266a652d9777
83342a5https://github.com/nodejs/node/commit/83342a5cb2001f5cee92cd6e9486f8f4bde96eb3
Compare https://github.com/nodejs/node/compare/9a8027e9fa11aaac32495d55513b266a652d9777..83342a5cb2001f5cee92cd6e9486f8f4bde96eb3
September 15, 2023 04:59https://github.com/nodejs/node/pull/49657#event-10379017669
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Sep 15, 2023 https://github.com/nodejs/node/pull/49657#ref-pullrequest-1897715678
test: fix edge snapshot stack traces #49659 https://github.com/nodejs/node/pull/49659
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
force-pushedhttps://github.com/nodejs/node/compare/83342a5cb2001f5cee92cd6e9486f8f4bde96eb3..6557d267a5d7b866792fde84739fd12e69a4a494
83342a5https://github.com/nodejs/node/commit/83342a5cb2001f5cee92cd6e9486f8f4bde96eb3
6557d26https://github.com/nodejs/node/commit/6557d267a5d7b866792fde84739fd12e69a4a494
Compare https://github.com/nodejs/node/compare/83342a5cb2001f5cee92cd6e9486f8f4bde96eb3..6557d267a5d7b866792fde84739fd12e69a4a494
September 15, 2023 05:09https://github.com/nodejs/node/pull/49657#event-10379072057
https://github.com/aduh95
aduh95https://github.com/aduh95
Sep 15, 2023 https://github.com/nodejs/node/pull/49657#pullrequestreview-1628394175
View reviewed changes https://github.com/nodejs/node/pull/49657/files
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/49657/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/49657
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/49657/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/49657
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/49657/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/49657
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/49657/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/49657
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/49657/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/49657
lib/internal/modules/esm/translators.jshttps://github.com/nodejs/node/pull/49657/files#diff-b1de5e9ce1e9b411001c63d11a5092dbba32e1586269a20dc11408375eb2f16c
Please reload this pagehttps://github.com/nodejs/node/pull/49657
lib/internal/modules/esm/translators.jshttps://github.com/nodejs/node/pull/49657/files#diff-b1de5e9ce1e9b411001c63d11a5092dbba32e1586269a20dc11408375eb2f16c
Please reload this pagehttps://github.com/nodejs/node/pull/49657
lib/internal/modules/esm/translators.jshttps://github.com/nodejs/node/pull/49657/files#diff-b1de5e9ce1e9b411001c63d11a5092dbba32e1586269a20dc11408375eb2f16c
Please reload this pagehttps://github.com/nodejs/node/pull/49657
lib/internal/modules/run_main.jshttps://github.com/nodejs/node/pull/49657/files#diff-9cdd961b23c4d25cc188f6b0beb3bf0228e3696a5f830cef198b1673b547bed3
Please reload this pagehttps://github.com/nodejs/node/pull/49657
test/common/assertSnapshot.jshttps://github.com/nodejs/node/pull/49657/files#diff-158c9c6c4cdf219f003e60fcb2e193d3502e00dcfbdcf7f04b18ce739a982fec
Please reload this pagehttps://github.com/nodejs/node/pull/49657
GeoffreyBoothhttps://github.com/GeoffreyBooth
September 15, 2023 10:10https://github.com/nodejs/node/pull/49657#commits-pushed-0a1b3ee
https://github.com/GeoffreyBooth
https://github.com/aduh95
esm: require braces for modules codehttps://github.com/nodejs/node/pull/49657/commits/0a1b3ee9c6fbc79e768fda343acc855267a0c3e3
0a1b3eehttps://github.com/nodejs/node/pull/49657/commits/0a1b3ee9c6fbc79e768fda343acc855267a0c3e3
https://github.com/GeoffreyBooth
https://github.com/aduh95
Add missing braceshttps://github.com/nodejs/node/pull/49657/commits/024a2c1dde67d6b21f69b0770f598aa9c45bc5a3
024a2c1https://github.com/nodejs/node/pull/49657/commits/024a2c1dde67d6b21f69b0770f598aa9c45bc5a3
https://github.com/aduh95
Apply suggestions from code reviewhttps://github.com/nodejs/node/pull/49657/commits/a9a976e219a9301ad5e6615271c0234be6eab440
a9a976ehttps://github.com/nodejs/node/pull/49657/commits/a9a976e219a9301ad5e6615271c0234be6eab440
https://github.com/aduh95
fix linthttps://github.com/nodejs/node/pull/49657/commits/17b4d9888bc7f8a6edc896370e939f6d949bba24
17b4d98https://github.com/nodejs/node/pull/49657/commits/17b4d9888bc7f8a6edc896370e939f6d949bba24
https://github.com/aduh95
fix testshttps://github.com/nodejs/node/pull/49657/commits/9e3e794bcb9c514e2826fbe602be660a90d7c791
9e3e794https://github.com/nodejs/node/pull/49657/commits/9e3e794bcb9c514e2826fbe602be660a90d7c791
https://github.com/aduh95
aduh95https://github.com/aduh95
force-pushedhttps://github.com/nodejs/node/compare/3be827653a7b9bec7f884195d2d3b312cefcb225..9e3e794bcb9c514e2826fbe602be660a90d7c791
3be8276https://github.com/nodejs/node/commit/3be827653a7b9bec7f884195d2d3b312cefcb225
9e3e794https://github.com/nodejs/node/commit/9e3e794bcb9c514e2826fbe602be660a90d7c791
Compare https://github.com/nodejs/node/compare/3be827653a7b9bec7f884195d2d3b312cefcb225..9e3e794bcb9c514e2826fbe602be660a90d7c791
September 15, 2023 08:14https://github.com/nodejs/node/pull/49657#event-10380491328
https://github.com/aduh95
aduh95https://github.com/aduh95
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 15, 2023https://github.com/nodejs/node/pull/49657#event-10380528010
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 15, 2023https://github.com/nodejs/node/pull/49657#event-10380588646
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 15, 2023https://github.com/nodejs/node/pull/49657#issuecomment-1720877757
https://ci.nodejs.org/job/node-test-pull-request/53959/https://ci.nodejs.org/job/node-test-pull-request/53959/
Please reload this pagehttps://github.com/nodejs/node/pull/49657
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 15, 2023https://github.com/nodejs/node/pull/49657#issuecomment-1720950017
https://ci.nodejs.org/job/node-test-pull-request/53960/https://ci.nodejs.org/job/node-test-pull-request/53960/
Please reload this pagehttps://github.com/nodejs/node/pull/49657
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
Sep 15, 2023 https://github.com/nodejs/node/pull/49657#pullrequestreview-1629264151
View reviewed changes https://github.com/nodejs/node/pull/49657/files/9e3e794bcb9c514e2826fbe602be660a90d7c791
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 15, 2023https://github.com/nodejs/node/pull/49657#issuecomment-1721590181
https://ci.nodejs.org/job/node-test-pull-request/53969/https://ci.nodejs.org/job/node-test-pull-request/53969/
Please reload this pagehttps://github.com/nodejs/node/pull/49657
https://github.com/aduh95
aduh95https://github.com/aduh95
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 15, 2023https://github.com/nodejs/node/pull/49657#event-10386680477
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
Sep 15, 2023https://github.com/nodejs/node/pull/49657#event-10386680833
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 15, 2023https://github.com/nodejs/node/pull/49657#event-10386706842
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
f42a103https://github.com/nodejs/node/commit/f42a1039917ae4432078c1288b8dc54081eed131
Sep 15, 2023https://github.com/nodejs/node/pull/49657#event-10386707410
CI Reliability 2023-09-17 nodejs/reliability#668 https://github.com/nodejs/reliability/issues/668
CI Reliability 2023-09-18 nodejs/reliability#669 https://github.com/nodejs/reliability/issues/669
CI Reliability 2023-09-19 nodejs/reliability#670 https://github.com/nodejs/reliability/issues/670
https://github.com/ruyadorno
ruyadornohttps://github.com/ruyadorno
Sep 28, 2023https://github.com/nodejs/node/pull/49657#issuecomment-1738356257
Please reload this pagehttps://github.com/nodejs/node/pull/49657
https://github.com/ruyadorno
ruyadornohttps://github.com/ruyadorno
backport-requested-v20.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v20.x
Sep 28, 2023https://github.com/nodejs/node/pull/49657#event-10493859097
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Oct 9, 2023 https://github.com/nodejs/node/pull/49657#ref-pullrequest-1912846720
2023-10-17, Version 21.0.0 (Current) #49870 https://github.com/nodejs/node/pull/49870
GeoffreyBoothhttps://github.com/GeoffreyBooth
Oct 19, 2023 https://github.com/nodejs/node/pull/49657#ref-commit-fc934ad
https://github.com/GeoffreyBooth
esm: require braces for modules codehttps://github.com/GeoffreyBooth/node/commit/fc934ada9067d36af04b960bc7eb566382b5656d
fc934adhttps://github.com/GeoffreyBooth/node/commit/fc934ada9067d36af04b960bc7eb566382b5656d
nodejs#49657https://github.com/nodejs/node/pull/49657
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Oct 19, 2023 https://github.com/nodejs/node/pull/49657#ref-pullrequest-1951163798
[v20.x backport] backport: esm: require braces for modules code #50268 https://github.com/nodejs/node/pull/50268
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
backport-open-v20.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-open-v20.x
backport-requested-v20.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v20.x
Oct 19, 2023https://github.com/nodejs/node/pull/49657#event-10703247803
GeoffreyBoothhttps://github.com/GeoffreyBooth
Oct 19, 2023 https://github.com/nodejs/node/pull/49657#ref-commit-83e582a
https://github.com/GeoffreyBooth
esm: require braces for modules codehttps://github.com/GeoffreyBooth/node/commit/83e582a205655bb64f25c22b54584e5c9b0e9bb7
83e582ahttps://github.com/GeoffreyBooth/node/commit/83e582a205655bb64f25c22b54584e5c9b0e9bb7
nodejs#49657https://github.com/nodejs/node/pull/49657
alexfernandezhttps://github.com/alexfernandez
Nov 1, 2023 https://github.com/nodejs/node/pull/49657#ref-commit-f143c29
https://github.com/GeoffreyBooth
https://github.com/alexfernandez
esm: require braces for modules codehttps://github.com/alexfernandez/node/commit/f143c29616abd79897a80273e9ed29f869c6c383
f143c29https://github.com/alexfernandez/node/commit/f143c29616abd79897a80273e9ed29f869c6c383
nodejs#49657https://github.com/nodejs/node/pull/49657
targoshttps://github.com/targos
Nov 11, 2023 https://github.com/nodejs/node/pull/49657#ref-commit-f306158
https://github.com/GeoffreyBooth
https://github.com/targos
esm: require braces for modules codehttps://github.com/targos/node/commit/f306158237e8bd56842be99eb921507168d97215
f306158https://github.com/targos/node/commit/f306158237e8bd56842be99eb921507168d97215
nodejs#49657https://github.com/nodejs/node/pull/49657
https://github.com/targos
targoshttps://github.com/targos
Nov 11, 2023 https://github.com/nodejs/node/pull/49657#ref-pullrequest-1989043303
[v18.x] Backport most ESM and customization hook changes #50669 https://github.com/nodejs/node/pull/50669
https://github.com/targos
targoshttps://github.com/targos
backported-to-v20.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v20.x
backport-open-v20.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-open-v20.x
Nov 11, 2023https://github.com/nodejs/node/pull/49657#event-10932836637
targoshttps://github.com/targos
Nov 11, 2023 https://github.com/nodejs/node/pull/49657#ref-commit-0103979
https://github.com/GeoffreyBooth
https://github.com/targos
esm: require braces for modules codehttps://github.com/nodejs/node/commit/01039795a2aaa4e59e83160ab728b53375e8aab0
0103979https://github.com/nodejs/node/commit/01039795a2aaa4e59e83160ab728b53375e8aab0
#49657https://github.com/nodejs/node/pull/49657
#50268https://github.com/nodejs/node/pull/50268
targoshttps://github.com/targos
Nov 11, 2023 https://github.com/nodejs/node/pull/49657#ref-commit-c262d3b
https://github.com/GeoffreyBooth
https://github.com/targos
esm: require braces for modules codehttps://github.com/targos/node/commit/c262d3bc3db3fd1c6510651a5710a3cd8d235989
c262d3bhttps://github.com/targos/node/commit/c262d3bc3db3fd1c6510651a5710a3cd8d235989
nodejs#49657https://github.com/nodejs/node/pull/49657
https://github.com/targos
targoshttps://github.com/targos
Nov 12, 2023 https://github.com/nodejs/node/pull/49657#ref-pullrequest-1989293723
v20.10.0 release proposal #50682 https://github.com/nodejs/node/pull/50682
https://github.com/targos
targoshttps://github.com/targos
backported-to-v18.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v18.x
Nov 23, 2023https://github.com/nodejs/node/pull/49657#event-11045336445
targoshttps://github.com/targos
Nov 23, 2023 https://github.com/nodejs/node/pull/49657#ref-commit-957725f
https://github.com/GeoffreyBooth
https://github.com/targos
esm: require braces for modules codehttps://github.com/nodejs/node/commit/957725f6012cf13e2a0665c9a9268198ba59812e
957725fhttps://github.com/nodejs/node/commit/957725f6012cf13e2a0665c9a9268198ba59812e
#49657https://github.com/nodejs/node/pull/49657
#50669https://github.com/nodejs/node/pull/50669
https://github.com/targos
targoshttps://github.com/targos
Nov 28, 2023 https://github.com/nodejs/node/pull/49657#ref-pullrequest-2014162105
v18.19.0 release proposal #50953 https://github.com/nodejs/node/pull/50953
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Dec 6, 2023 https://github.com/nodejs/node/pull/49657#ref-pullrequest-2029497346
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41 https://github.com/nodesource/nsolid/pull/41
ckerrhttps://github.com/ckerr
Dec 7, 2023 https://github.com/nodejs/node/pull/49657#ref-commit-2d3c55f
https://github.com/ckerr
chore: update pass_all_globals_through_require.patchhttps://github.com/electron/electron/commit/2d3c55fce85917342718a0420839738928e8bf59
2d3c55fhttps://github.com/electron/electron/commit/2d3c55fce85917342718a0420839738928e8bf59
nodejs/node#49657https://github.com/nodejs/node/pull/49657
ckerrhttps://github.com/ckerr
Dec 7, 2023 https://github.com/nodejs/node/pull/49657#ref-commit-d44b426
https://github.com/ckerr
update fix_expose_the_built-in_electron_module_via_the_esm_loader.patchhttps://github.com/electron/electron/commit/d44b4260ac89fdd9225ab0fd81d315afffd32fba
d44b426https://github.com/electron/electron/commit/d44b4260ac89fdd9225ab0fd81d315afffd32fba
nodejs/node#50096https://github.com/nodejs/node/pull/50096
nodejs/node#50314https://github.com/nodejs/node/pull/50314
nodejs/node#49657https://github.com/nodejs/node/pull/49657
codebyterehttps://github.com/codebytere
Dec 8, 2023 https://github.com/nodejs/node/pull/49657#ref-commit-9e47ee7
https://github.com/ckerr
https://github.com/codebytere
chore: update pass_all_globals_through_require.patchhttps://github.com/electron/electron/commit/9e47ee767e3dbfbdf4b1821413b87caf7dc0051a
9e47ee7https://github.com/electron/electron/commit/9e47ee767e3dbfbdf4b1821413b87caf7dc0051a
nodejs/node#49657https://github.com/nodejs/node/pull/49657
codebyterehttps://github.com/codebytere
Dec 8, 2023 https://github.com/nodejs/node/pull/49657#ref-commit-077c8e4
https://github.com/ckerr
https://github.com/codebytere
update fix_expose_the_built-in_electron_module_via_the_esm_loader.patchhttps://github.com/electron/electron/commit/077c8e499910e396efc1e72aa3d4e84214e61e74
077c8e4https://github.com/electron/electron/commit/077c8e499910e396efc1e72aa3d4e84214e61e74
nodejs/node#50096https://github.com/nodejs/node/pull/50096
nodejs/node#50314https://github.com/nodejs/node/pull/50314
nodejs/node#49657https://github.com/nodejs/node/pull/49657
codebyterehttps://github.com/codebytere
Dec 11, 2023 https://github.com/nodejs/node/pull/49657#ref-commit-890a557
https://github.com/apps/electron-roller
https://github.com/ckerr
https://github.com/codebytere
chore: bump node to v20.10.0 (main) (https://github.com/electron/electron/commit/890a557eed6a6917e7854b76e5a691eff1f5e9ae
#40675https://github.com/electron/electron/pull/40675
)https://github.com/electron/electron/commit/890a557eed6a6917e7854b76e5a691eff1f5e9ae
890a557https://github.com/electron/electron/commit/890a557eed6a6917e7854b76e5a691eff1f5e9ae
nodejs/node#49986https://github.com/nodejs/node/pull/49986
nodejs/node#49657https://github.com/nodejs/node/pull/49657
nodejs/node#49912https://github.com/nodejs/node/pull/49912
nodejs/node#49986https://github.com/nodejs/node/pull/49986
nodejs/node#50096https://github.com/nodejs/node/pull/50096
nodejs/node#50314https://github.com/nodejs/node/pull/50314
nodejs/node#49657https://github.com/nodejs/node/pull/49657
nodejs/node#50127https://github.com/nodejs/node/pull/50127
nodejs/node#50096https://github.com/nodejs/node/pull/50096
nodejs/node#49523https://github.com/nodejs/node/pull/49523
nodejs/node#50296https://github.com/nodejs/node/pull/50296
nodejs/node#50082https://github.com/nodejs/node/pull/50082
nodejs/node#49986https://github.com/nodejs/node/pull/49986
nodejs/node#49908https://github.com/nodejs/node/pull/49908
nodejs/node#49876https://github.com/nodejs/node/pull/49876
nodejs/node#50034https://github.com/nodejs/node/pull/50034
nodejs/node#49659https://github.com/nodejs/node/pull/49659
nodejs/node#48749https://github.com/nodejs/node/pull/48749
nodejs/node#49913https://github.com/nodejs/node/pull/49913
nodejs/node#50234https://github.com/nodejs/node/pull/50234
nodejs/node#50096https://github.com/nodejs/node/pull/50096
nodejs/node#49974https://github.com/nodejs/node/pull/49974
https://chromium-review.googlesource.com/c/v8/v8/+/4705331https://chromium-review.googlesource.com/c/v8/v8/+/4705331
sercherhttps://github.com/sercher
Apr 25, 2024 https://github.com/nodejs/node/pull/49657#ref-commit-009f613
https://github.com/sercher
esm: require braces for modules codehttps://github.com/sercher/graaljs/commit/009f613e6505a57f29c5d266ab858c6776f5cc0f
009f613https://github.com/sercher/graaljs/commit/009f613e6505a57f29c5d266ab858c6776f5cc0f
nodejs/node#49657https://github.com/nodejs/node/pull/49657
nodejs/node#50669https://github.com/nodejs/node/pull/50669
sercherhttps://github.com/sercher
Apr 25, 2024 https://github.com/nodejs/node/pull/49657#ref-commit-4dc712f
https://github.com/sercher
esm: require braces for modules codehttps://github.com/sercher/graaljs/commit/4dc712f933c57c313b09e01ac9ceb1eabd193cef
4dc712fhttps://github.com/sercher/graaljs/commit/4dc712f933c57c313b09e01ac9ceb1eabd193cef
nodejs/node#49657https://github.com/nodejs/node/pull/49657
nodejs/node#50669https://github.com/nodejs/node/pull/50669
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49657
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/49657/files/6557d267a5d7b866792fde84739fd12e69a4a494
https://github.com/ljharb
ljharb https://github.com/ljharb
https://github.com/nodejs/node/pull/49657/files/83342a5cb2001f5cee92cd6e9486f8f4bde96eb3
https://github.com/JakobJingleheimer
JakobJingleheimer https://github.com/JakobJingleheimer
https://github.com/nodejs/node/pull/49657/files/9e3e794bcb9c514e2826fbe602be660a90d7c791
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
backported-to-v20.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v20.x
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/49657
https://github.com/GeoffreyBooth
https://github.com/nodejs-github-bot
https://github.com/ruyadorno
https://github.com/ljharb
https://github.com/JakobJingleheimer
https://github.com/aduh95
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.