| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3586f5b4-c3a1-7964-b658-a2c0059ae7f2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A9A0:37ACD:12D7495:19FF44D:6969FF78 |
| html-safe-nonce | fbd3c2e952fccd6d5298a0e446ae2b4c12f7e0123acd2c6964382394bac11fbd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOUEwOjM3QUNEOjEyRDc0OTU6MTlGRjQ0RDo2OTY5RkY3OCIsInZpc2l0b3JfaWQiOiIxNTQ0OTcwOTk1OTQyMTYyMjk2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | b9b78ca04f858ca2e0cfbe5d40c4631da57532d140d4d78d221734c706133659 |
| hovercard-subject-tag | pull_request:1509252720 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/49593/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/61e6373235d170e08a4ff9714fc7ef5a51b58288ceaf35181b4735f36306ca36/nodejs/node/pull/49593 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/61e6373235d170e08a4ff9714fc7ef5a51b58288ceaf35181b4735f36306ca36/nodejs/node/pull/49593 |
| og:image:alt | This is a work-in-progress pull request. Opened to receive feedback while I navigate through the issues.
It includes some interesting performance improvements. I'll update the following list wh... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | anonrig |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/49593#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49593 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49593 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/49593 |
| Reload | https://github.com/nodejs/node/pull/49593 |
| Reload | https://github.com/nodejs/node/pull/49593 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/49593#issue-comment-box |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| anonrig:node-fs-sync-rewrite | https://github.com/anonrig/node/tree/node-fs-sync-rewrite |
|
fs: improve error performance of sync methods
| https://github.com/nodejs/node/pull/49593#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| anonrig:node-fs-sync-rewrite | https://github.com/anonrig/node/tree/node-fs-sync-rewrite |
|
Conversation
54
| https://github.com/nodejs/node/pull/49593 |
|
Commits
1
| https://github.com/nodejs/node/pull/49593/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/49593/checks |
|
Files changed
| https://github.com/nodejs/node/pull/49593/files |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| Sep 10, 2023 | https://github.com/nodejs/node/pull/49593#issue-1889285418 |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| nodejs/performance#106 | https://github.com/nodejs/performance/issues/106 |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 10, 2023 | https://github.com/nodejs/node/pull/49593#issuecomment-1712910077 |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Sep 10, 2023 | https://github.com/nodejs/node/pull/49593#event-10327086397 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| force-pushed | https://github.com/nodejs/node/compare/0afabd504b8d3565f669793f289a867e37865fa0..80c845bec06ab8de8ea695e11900bce0e3f556b3 |
| 0afabd5 | https://github.com/nodejs/node/commit/0afabd504b8d3565f669793f289a867e37865fa0 |
| 80c845b | https://github.com/nodejs/node/commit/80c845bec06ab8de8ea695e11900bce0e3f556b3 |
|
Compare
| https://github.com/nodejs/node/compare/0afabd504b8d3565f669793f289a867e37865fa0..80c845bec06ab8de8ea695e11900bce0e3f556b3 |
| September 10, 2023 19:10 | https://github.com/nodejs/node/pull/49593#event-10327111484 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
performance
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance |
| Sep 10, 2023 | https://github.com/nodejs/node/pull/49593#event-10327120523 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| force-pushed | https://github.com/nodejs/node/compare/10cb7e5a020a55e926b726c24d55d8d07dbfa212..8a748c4425a217876f1039eb42b2df6c0188594a |
| 10cb7e5 | https://github.com/nodejs/node/commit/10cb7e5a020a55e926b726c24d55d8d07dbfa212 |
| 8a748c4 | https://github.com/nodejs/node/commit/8a748c4425a217876f1039eb42b2df6c0188594a |
|
Compare
| https://github.com/nodejs/node/compare/10cb7e5a020a55e926b726c24d55d8d07dbfa212..8a748c4425a217876f1039eb42b2df6c0188594a |
| September 10, 2023 19:17 | https://github.com/nodejs/node/pull/49593#event-10327122246 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Sep 10, 2023
| https://github.com/nodejs/node/pull/49593#pullrequestreview-1618903550 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/49593/files |
| src/node_file_sync.cc | https://github.com/nodejs/node/pull/49593/files#diff-48e6f0031e18eae562752d2e24b7054e4af4bc0bab0faa27afaf8fb51733efa4 |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| force-pushed | https://github.com/nodejs/node/compare/4351a5e5aefd8ec7ef46325f41908f60ac2dc575..6de6974d2d71b6076abbca657619b67194d9b4da |
| 4351a5e | https://github.com/nodejs/node/commit/4351a5e5aefd8ec7ef46325f41908f60ac2dc575 |
| 6de6974 | https://github.com/nodejs/node/commit/6de6974d2d71b6076abbca657619b67194d9b4da |
|
Compare
| https://github.com/nodejs/node/compare/4351a5e5aefd8ec7ef46325f41908f60ac2dc575..6de6974d2d71b6076abbca657619b67194d9b4da |
| September 10, 2023 22:13 | https://github.com/nodejs/node/pull/49593#event-10327412783 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Sep 10, 2023
| https://github.com/nodejs/node/pull/49593#pullrequestreview-1618931430 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/49593/files |
| src/node_file_sync.cc | https://github.com/nodejs/node/pull/49593/files#diff-48e6f0031e18eae562752d2e24b7054e4af4bc0bab0faa27afaf8fb51733efa4 |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| force-pushed | https://github.com/nodejs/node/compare/6de6974d2d71b6076abbca657619b67194d9b4da..6ff6a52845c384bb0e130003c268b8657aa34d62 |
| 6de6974 | https://github.com/nodejs/node/commit/6de6974d2d71b6076abbca657619b67194d9b4da |
| 6ff6a52 | https://github.com/nodejs/node/commit/6ff6a52845c384bb0e130003c268b8657aa34d62 |
|
Compare
| https://github.com/nodejs/node/compare/6de6974d2d71b6076abbca657619b67194d9b4da..6ff6a52845c384bb0e130003c268b8657aa34d62 |
| September 10, 2023 22:21 | https://github.com/nodejs/node/pull/49593#event-10327426911 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Sep 11, 2023
| https://github.com/nodejs/node/pull/49593#pullrequestreview-1619481984 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/49593/files |
| benchmark/fs/bench-existsSync.js | https://github.com/nodejs/node/pull/49593/files#diff-bdaeddca169b9d4ef083370b34f9b6f3f6e7d0ee37db055337757027bdb25637 |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.com/lemire |
| lemire | https://github.com/lemire |
| Sep 11, 2023 | https://github.com/nodejs/node/pull/49593#issuecomment-1714522592 |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.com/lemire/js-file-loading-benchmark | https://github.com/lemire/js-file-loading-benchmark |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.com/lemire |
| lemire | https://github.com/lemire |
| Sep 11, 2023 | https://github.com/nodejs/node/pull/49593#issuecomment-1714534947 |
| https://github.com/lemire/js-file-loading-benchmark | https://github.com/lemire/js-file-loading-benchmark |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.com/billywhizz |
| billywhizz | https://github.com/billywhizz |
| Sep 11, 2023 | https://github.com/nodejs/node/pull/49593#issuecomment-1714620286 |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| @lemire | https://github.com/lemire |
| gist | https://gist.github.com/billywhizz/6592c0489e030bc52941c8b933ce2dcd |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.com/lemire |
| lemire | https://github.com/lemire |
| Sep 11, 2023 | https://github.com/nodejs/node/pull/49593#issuecomment-1714654268 |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| @billywhizz | https://github.com/billywhizz |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| Sep 11, 2023 | https://github.com/nodejs/node/pull/49593#issuecomment-1714662661 |
| @lemire | https://github.com/lemire |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.com/billywhizz |
| billywhizz | https://github.com/billywhizz |
| Sep 11, 2023 | https://github.com/nodejs/node/pull/49593#issuecomment-1714663888 |
| @lemire | https://github.com/lemire |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| Sep 11, 2023 | https://github.com/nodejs/node/pull/49593#issuecomment-1714665629 |
| @lemire | https://github.com/lemire |
| @billywhizz | https://github.com/billywhizz |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.com/lemire |
| lemire | https://github.com/lemire |
| Sep 11, 2023 | https://github.com/nodejs/node/pull/49593#issuecomment-1714674538 |
| @billywhizz | https://github.com/billywhizz |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.com/billywhizz |
| billywhizz | https://github.com/billywhizz |
| Sep 11, 2023 | https://github.com/nodejs/node/pull/49593#issuecomment-1714674614 |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| @anonrig | https://github.com/anonrig |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.com/billywhizz |
| billywhizz | https://github.com/billywhizz |
| Sep 11, 2023 | https://github.com/nodejs/node/pull/49593#issuecomment-1714676876 |
| @lemire | https://github.com/lemire |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.com/billywhizz |
| billywhizz | https://github.com/billywhizz |
| Sep 11, 2023 | https://github.com/nodejs/node/pull/49593#issuecomment-1714690311 |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| @anonrig | https://github.com/anonrig |
| @lemire | https://github.com/lemire |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.com/lemire |
| lemire | https://github.com/lemire |
| Sep 11, 2023 | https://github.com/nodejs/node/pull/49593#issuecomment-1714732371 |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| @billywhizz | https://github.com/billywhizz |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.com/billywhizz |
| billywhizz | https://github.com/billywhizz |
| Sep 11, 2023 | https://github.com/nodejs/node/pull/49593#issuecomment-1714757498 |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| @lemire | https://github.com/lemire |
| https://twitter.com/jarredsumner/status/1496455856224972808?lang=en | https://twitter.com/jarredsumner/status/1496455856224972808?lang=en |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.com/billywhizz |
| billywhizz | https://github.com/billywhizz |
| Sep 12, 2023 | https://github.com/nodejs/node/pull/49593#issuecomment-1714820211 |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| @anonrig | https://github.com/anonrig |
| @lemire | https://github.com/lemire |
| @joyeecheung | https://github.com/joyeecheung |
| my gist | https://gist.github.com/billywhizz/6592c0489e030bc52941c8b933ce2dcd#file-decode-mjs |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.com/lemire |
| lemire | https://github.com/lemire |
| Sep 12, 2023 | https://github.com/nodejs/node/pull/49593#issuecomment-1715837035 |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.com/lemire |
| lemire | https://github.com/lemire |
| Sep 12, 2023 | https://github.com/nodejs/node/pull/49593#issuecomment-1715846660 |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.com/lemire |
| lemire | https://github.com/lemire |
| Sep 12, 2023 | https://github.com/nodejs/node/pull/49593#issuecomment-1716256410 |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| Sep 12, 2023 | https://github.com/nodejs/node/pull/49593#issuecomment-1716420524 |
| @billywhizz | https://github.com/billywhizz |
| https://gist.github.com/billywhizz/6592c0489e030bc52941c8b933ce2dcd#file-files-mjs-L5 | https://gist.github.com/billywhizz/6592c0489e030bc52941c8b933ce2dcd#file-files-mjs-L5 |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| Qard | https://github.com/Qard |
| September 17, 2023 03:12 | https://github.com/nodejs/node/pull/49593#event-10390681760 |
| https://github.com/RafaelGSS |
| RafaelGSS | https://github.com/RafaelGSS |
|
Sep 17, 2023
| https://github.com/nodejs/node/pull/49593#pullrequestreview-1630046184 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/49593/files/63f42a8e87dca07ab33260f7256365223c612e4a |
| RafaelGSS | https://github.com/RafaelGSS |
| https://github.com/nodejs/node/pull/49593#pullrequestreview-1630046184 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| benchmark/fs/bench-accessSync.js | https://github.com/nodejs/node/pull/49593/files/63f42a8e87dca07ab33260f7256365223c612e4a#diff-b809b30458bb9f2066d032f36861f548c4bf6e29ac8c5de12379cfc04b30602a |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| benchmark/fs/bench-accessSync.js | https://github.com/nodejs/node/pull/49593/files/63f42a8e87dca07ab33260f7256365223c612e4a#diff-b809b30458bb9f2066d032f36861f548c4bf6e29ac8c5de12379cfc04b30602a |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| benchmark/fs/bench-copyFileSync.js | https://github.com/nodejs/node/pull/49593/files/63f42a8e87dca07ab33260f7256365223c612e4a#diff-2f213093ea32896b8d2a6cfce8bc3a3d973176b4056b259bfc5630d123aa63e8 |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| benchmark/fs/bench-copyFileSync.js | https://github.com/nodejs/node/pull/49593/files/63f42a8e87dca07ab33260f7256365223c612e4a#diff-2f213093ea32896b8d2a6cfce8bc3a3d973176b4056b259bfc5630d123aa63e8 |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| Sep 17, 2023 | https://github.com/nodejs/node/pull/49593#issuecomment-1722518454 |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Sep 17, 2023
| https://github.com/nodejs/node/pull/49593#pullrequestreview-1630122664 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/49593/files/63f42a8e87dca07ab33260f7256365223c612e4a |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Sep 17, 2023 | https://github.com/nodejs/node/pull/49593#event-10391969867 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Sep 17, 2023 | https://github.com/nodejs/node/pull/49593#event-10391980859 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| 7e12d0e | https://github.com/nodejs/node/commit/7e12d0e16db7bc7247b34bc52fabd420277a819f |
| Sep 17, 2023 | https://github.com/nodejs/node/pull/49593#event-10391980947 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 17, 2023 | https://github.com/nodejs/node/pull/49593#issuecomment-1722564408 |
| 7e12d0e | https://github.com/nodejs/node/commit/7e12d0e16db7bc7247b34bc52fabd420277a819f |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Sep 17, 2023
| https://github.com/nodejs/node/pull/49593#ref-issue-1857276288 |
|
Performance of node:fs
nodejs/performance#106
| https://github.com/nodejs/performance/issues/106 |
|
CI Reliability 2023-09-18
nodejs/reliability#669
| https://github.com/nodejs/reliability/issues/669 |
|
CI Reliability 2023-09-19
nodejs/reliability#670
| https://github.com/nodejs/reliability/issues/670 |
|
CI Reliability 2023-09-20
nodejs/reliability#671
| https://github.com/nodejs/reliability/issues/671 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Sep 27, 2023 | https://github.com/nodejs/node/pull/49593#issuecomment-1738089943 |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
|
fs: improve error performance for fdatasyncSync
#49898
| https://github.com/nodejs/node/pull/49898 |
|
fs: improve error performance of chownSync
#49748
| https://github.com/nodejs/node/pull/49748 |
|
fs: improve error perf of sync *times
#49864
| https://github.com/nodejs/node/pull/49864 |
|
fs: improve error performance for rmdirSync
#49846
| https://github.com/nodejs/node/pull/49846 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Sep 28, 2023 | https://github.com/nodejs/node/pull/49593#issuecomment-1738304346 |
| #49913 | https://github.com/nodejs/node/pull/49913 |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
| ruyadorno | https://github.com/ruyadorno |
|
Sep 28, 2023
| https://github.com/nodejs/node/pull/49593#ref-commit-938471e |
|
| https://github.com/anonrig |
|
| https://github.com/ruyadorno |
| fs: improve error performance of sync methods | https://github.com/nodejs/node/commit/938471ef556f2d64257059b60889a8c84621eea6 |
| 938471e | https://github.com/nodejs/node/commit/938471ef556f2d64257059b60889a8c84621eea6 |
| #49593 | https://github.com/nodejs/node/pull/49593 |
|
v20.7.1 proposal
#49917
| https://github.com/nodejs/node/pull/49917 |
|
v20.8.0 proposal
#49932
| https://github.com/nodejs/node/pull/49932 |
|
binding: mock readFileSync
tschaub/mock-fs#378
| https://github.com/tschaub/mock-fs/pull/378 |
|
Fix tests on Node 20.8.0+
getgauge/gauge-js#603
| https://github.com/getgauge/gauge-js/pull/603 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Oct 3, 2023
| https://github.com/nodejs/node/pull/49593#ref-pullrequest-1924979761 |
|
fix: use fs.existsSync to avoid race condition
vercel/next.js#56387
| https://github.com/vercel/next.js/pull/56387 |
| huozhi | https://github.com/huozhi |
|
Oct 3, 2023
| https://github.com/nodejs/node/pull/49593#ref-commit-a46c5af |
|
| https://github.com/anonrig |
|
| https://github.com/marketplace/kodiakhq |
| fix: use | https://github.com/vercel/next.js/commit/a46c5afa608b88fed85d152530b22383b51bf416 |
| fs.existsSync | https://github.com/vercel/next.js/commit/a46c5afa608b88fed85d152530b22383b51bf416 |
| to avoid race condition ( | https://github.com/vercel/next.js/commit/a46c5afa608b88fed85d152530b22383b51bf416 |
| #56387 | https://github.com/vercel/next.js/pull/56387 |
| ) | https://github.com/vercel/next.js/commit/a46c5afa608b88fed85d152530b22383b51bf416 |
| a46c5af | https://github.com/vercel/next.js/commit/a46c5afa608b88fed85d152530b22383b51bf416 |
| nodejs/node#49893 | https://github.com/nodejs/node/pull/49893 |
| nodejs/node#49593 | https://github.com/nodejs/node/pull/49593 |
| https://github.com/RafaelGSS |
| RafaelGSS | https://github.com/RafaelGSS |
|
Oct 7, 2023
| https://github.com/nodejs/node/pull/49593#ref-pullrequest-1931077137 |
|
benchmark: add warmup to accessSync bench
#50073
| https://github.com/nodejs/node/pull/50073 |
| alexfernandez | https://github.com/alexfernandez |
|
Nov 1, 2023
| https://github.com/nodejs/node/pull/49593#ref-commit-76a820e |
|
| https://github.com/anonrig |
|
| https://github.com/alexfernandez |
| fs: improve error performance of sync methods | https://github.com/alexfernandez/node/commit/76a820e2aa51e13fdfeed564298fd6b6f204e413 |
| 76a820e | https://github.com/alexfernandez/node/commit/76a820e2aa51e13fdfeed564298fd6b6f204e413 |
| nodejs#49593 | https://github.com/nodejs/node/pull/49593 |
| https://github.com/arcanis |
| arcanis | https://github.com/arcanis |
|
Nov 14, 2023
| https://github.com/nodejs/node/pull/49593#ref-issue-1992365215 |
|
Official fs overlay
nodejs/loaders#172
| https://github.com/nodejs/loaders/issues/172 |
| https://github.com/ryanblock |
| ryanblock | https://github.com/ryanblock |
|
Dec 4, 2023
| https://github.com/nodejs/node/pull/49593#ref-issue-2022232439 |
|
Is this project maintained?
tschaub/mock-fs#383
| https://github.com/tschaub/mock-fs/issues/383 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
|
Mar 11, 2024
| https://github.com/nodejs/node/pull/49593#ref-pullrequest-2162143734 |
|
bump base images to use Node.js 20
redhat-developer/rhdh#1048
| https://github.com/redhat-developer/rhdh/pull/1048 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49593 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/49593/files/8a748c4425a217876f1039eb42b2df6c0188594a |
|
| https://github.com/H4ad |
|
H4ad
| https://github.com/H4ad |
|
| https://github.com/nodejs/node/pull/49593/files/db510b3f4004350f0254a662a4df5feb290c79c0 |
|
| https://github.com/RafaelGSS |
|
RafaelGSS
| https://github.com/RafaelGSS |
|
| https://github.com/nodejs/node/pull/49593/files/63f42a8e87dca07ab33260f7256365223c612e4a |
|
| https://github.com/RaisinTen |
|
RaisinTen
| https://github.com/RaisinTen |
|
| https://github.com/nodejs/node/pull/49593/files/db510b3f4004350f0254a662a4df5feb290c79c0 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/49593/files/e57cbbd4cee96a0164b4b415493c6797b4bd8f01 |
|
| https://github.com/ronag |
|
ronag
| https://github.com/ronag |
|
| https://github.com/nodejs/node/pull/49593/files/63f42a8e87dca07ab33260f7256365223c612e4a |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/Qard |
|
Qard
| https://github.com/Qard |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-benchmark-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-benchmark-ci |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
performance
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance |
|
review wanted
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22 |
|
Performance of node:fs
| https://github.com/nodejs/performance/issues/106 |
| Please reload this page | https://github.com/nodejs/node/pull/49593 |
|
| https://github.com/anonrig |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/lemire |
|
| https://github.com/billywhizz |
|
| https://github.com/tniessen |
|
| https://github.com/joyeecheung |
|
| https://github.com/mcollina |
|
| https://github.com/jasnell |
|
| https://github.com/ronag |
|
| https://github.com/H4ad |
|
| https://github.com/RafaelGSS |
|
| https://github.com/RaisinTen |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |