René's URL Explorer Experiment


Title: crypto: return clear errors when loading invalid PFX data by pimterry · Pull Request #49566 · nodejs/node · GitHub

Open Graph Title: crypto: return clear errors when loading invalid PFX data by pimterry · Pull Request #49566 · nodejs/node

X Title: crypto: return clear errors when loading invalid PFX data by pimterry · Pull Request #49566 · nodejs/node

Description: This fixes #49562 Without this change, the provided test fails with 'passed a null parameter', telling you nothing about what's actually wrong (since no nulls are present in this test code). With t...

Open Graph Description: This fixes #49562 Without this change, the provided test fails with 'passed a null parameter', telling you nothing about what's actually wrong (since no nulls are present in this test c...

X Description: This fixes #49562 Without this change, the provided test fails with 'passed a null parameter', telling you nothing about what's actually wrong (since no nulls are present in...

Opengraph URL: https://github.com/nodejs/node/pull/49566

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1c1555f2-d275-191e-3af1-8e331b3e4d8d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD58:9D4F4:42C2BA:5ABB4E:6969D161
html-safe-nonce919518205d578dbb1d213d632bb6217b651409ecc060b70917c3d3fc68162a98
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDU4OjlENEY0OjQyQzJCQTo1QUJCNEU6Njk2OUQxNjEiLCJ2aXNpdG9yX2lkIjoiNjgzMjMzNDQxNDYwODQ1Mzk4NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7f656f414d4a61b64e262a32025ac8619a9383a5137f5d48c660a1ba5e6a1f04
hovercard-subject-tagpull_request:1508391422
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/49566/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3bc51db5ddcdf1039e14b6856aa27cc879f63db6988427180049c3f8339665da/nodejs/node/pull/49566
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3bc51db5ddcdf1039e14b6856aa27cc879f63db6988427180049c3f8339665da/nodejs/node/pull/49566
og:image:altThis fixes #49562 Without this change, the provided test fails with 'passed a null parameter', telling you nothing about what's actually wrong (since no nulls are present in this test c...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepimterry
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/49566#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49566
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49566
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/49566
Reloadhttps://github.com/nodejs/node/pull/49566
Reloadhttps://github.com/nodejs/node/pull/49566
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/49566
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/49566
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/49566#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
pimterry:fix-pfx-missing-key-errorhttps://github.com/pimterry/node/tree/fix-pfx-missing-key-error
crypto: return clear errors when loading invalid PFX data https://github.com/nodejs/node/pull/49566#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
pimterry:fix-pfx-missing-key-errorhttps://github.com/pimterry/node/tree/fix-pfx-missing-key-error
Conversation 12 https://github.com/nodejs/node/pull/49566
Commits 2 https://github.com/nodejs/node/pull/49566/commits
Checks 0 https://github.com/nodejs/node/pull/49566/checks
Files changed https://github.com/nodejs/node/pull/49566/files
Please reload this pagehttps://github.com/nodejs/node/pull/49566
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Sep 8, 2023https://github.com/nodejs/node/pull/49566#issue-1888235375
#49562https://github.com/nodejs/node/issues/49562
Please reload this pagehttps://github.com/nodejs/node/pull/49566
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 8, 2023https://github.com/nodejs/node/pull/49566#issuecomment-1712153978
Please reload this pagehttps://github.com/nodejs/node/pull/49566
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Sep 8, 2023https://github.com/nodejs/node/pull/49566#event-10321691446
https://github.com/pimterry
crypto: return clear errors when loading invalid PFX datahttps://github.com/nodejs/node/pull/49566/commits/2ad8af640ae421598923cdba3faeb6db85cbe118
2ad8af6https://github.com/nodejs/node/pull/49566/commits/2ad8af640ae421598923cdba3faeb6db85cbe118
https://github.com/pimterry
pimterryhttps://github.com/pimterry
force-pushedhttps://github.com/nodejs/node/compare/e3bebf32d46f0320b24a8ce279e3e5d4a5c89fca..2ad8af640ae421598923cdba3faeb6db85cbe118
e3bebf3https://github.com/nodejs/node/commit/e3bebf32d46f0320b24a8ce279e3e5d4a5c89fca
2ad8af6https://github.com/nodejs/node/commit/2ad8af640ae421598923cdba3faeb6db85cbe118
Compare https://github.com/nodejs/node/compare/e3bebf32d46f0320b24a8ce279e3e5d4a5c89fca..2ad8af640ae421598923cdba3faeb6db85cbe118
September 8, 2023 19:58https://github.com/nodejs/node/pull/49566#event-10321734324
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Sep 9, 2023 https://github.com/nodejs/node/pull/49566#pullrequestreview-1618592330
View reviewed changes https://github.com/nodejs/node/pull/49566/files/2ad8af640ae421598923cdba3faeb6db85cbe118
src/crypto/crypto_context.cchttps://github.com/nodejs/node/pull/49566/files/2ad8af640ae421598923cdba3faeb6db85cbe118#diff-3a010f7fadf05b30c9e223628e2bacd54df3404fa83a8d280158fe639494bb5a
Please reload this pagehttps://github.com/nodejs/node/pull/49566
src/crypto/crypto_context.cchttps://github.com/nodejs/node/pull/49566/files/2ad8af640ae421598923cdba3faeb6db85cbe118#diff-3a010f7fadf05b30c9e223628e2bacd54df3404fa83a8d280158fe639494bb5a
Please reload this pagehttps://github.com/nodejs/node/pull/49566
src/crypto/crypto_context.cchttps://github.com/nodejs/node/pull/49566/files/2ad8af640ae421598923cdba3faeb6db85cbe118#diff-3a010f7fadf05b30c9e223628e2bacd54df3404fa83a8d280158fe639494bb5a
Please reload this pagehttps://github.com/nodejs/node/pull/49566
https://github.com/pimterry
Refactor LoadPKCS12 after reviewhttps://github.com/nodejs/node/pull/49566/commits/dbc7ee0a662ab332cfc7f67d0fac9501927d3f07
dbc7ee0https://github.com/nodejs/node/pull/49566/commits/dbc7ee0a662ab332cfc7f67d0fac9501927d3f07
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Sep 11, 2023 https://github.com/nodejs/node/pull/49566#pullrequestreview-1620545460
View reviewed changes https://github.com/nodejs/node/pull/49566/files/dbc7ee0a662ab332cfc7f67d0fac9501927d3f07
https://github.com/debadree25
debadree25https://github.com/debadree25
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 12, 2023https://github.com/nodejs/node/pull/49566#event-10345359441
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 12, 2023https://github.com/nodejs/node/pull/49566#event-10345421247
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 12, 2023https://github.com/nodejs/node/pull/49566#issuecomment-1715521190
https://ci.nodejs.org/job/node-test-pull-request/53909/https://ci.nodejs.org/job/node-test-pull-request/53909/
Please reload this pagehttps://github.com/nodejs/node/pull/49566
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 12, 2023https://github.com/nodejs/node/pull/49566#issuecomment-1716213192
https://ci.nodejs.org/job/node-test-pull-request/53919/https://ci.nodejs.org/job/node-test-pull-request/53919/
Please reload this pagehttps://github.com/nodejs/node/pull/49566
CI Reliability 2023-09-16 nodejs/reliability#667 https://github.com/nodejs/reliability/issues/667
CI Reliability 2023-09-17 nodejs/reliability#668 https://github.com/nodejs/reliability/issues/668
https://github.com/aymen94
aymen94https://github.com/aymen94
Sep 18, 2023 https://github.com/nodejs/node/pull/49566#pullrequestreview-1630388700
View reviewed changes https://github.com/nodejs/node/pull/49566/files/dbc7ee0a662ab332cfc7f67d0fac9501927d3f07
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Sep 21, 2023https://github.com/nodejs/node/pull/49566#issuecomment-1729083788
Please reload this pagehttps://github.com/nodejs/node/pull/49566
https://github.com/aduh95
aduh95https://github.com/aduh95
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
Sep 29, 2023https://github.com/nodejs/node/pull/49566#event-10509943072
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 29, 2023https://github.com/nodejs/node/pull/49566#event-10509986428
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
17b9925https://github.com/nodejs/node/commit/17b9925393a925fd5b3e52db74e8d512878a041a
Sep 29, 2023https://github.com/nodejs/node/pull/49566#event-10509987667
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 29, 2023https://github.com/nodejs/node/pull/49566#issuecomment-1740702567
17b9925https://github.com/nodejs/node/commit/17b9925393a925fd5b3e52db74e8d512878a041a
Please reload this pagehttps://github.com/nodejs/node/pull/49566
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Sep 29, 2023https://github.com/nodejs/node/pull/49566#issuecomment-1740707448
@aduh95https://github.com/aduh95
Please reload this pagehttps://github.com/nodejs/node/pull/49566
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Oct 9, 2023 https://github.com/nodejs/node/pull/49566#ref-pullrequest-1912846720
2023-10-17, Version 21.0.0 (Current) #49870 https://github.com/nodejs/node/pull/49870
alexfernandezhttps://github.com/alexfernandez
Nov 1, 2023 https://github.com/nodejs/node/pull/49566#ref-commit-f4676a3
https://github.com/pimterry
https://github.com/alexfernandez
crypto: return clear errors when loading invalid PFX datahttps://github.com/alexfernandez/node/commit/f4676a305b6a88b9a8f2b7444fd11889790ea77d
f4676a3https://github.com/alexfernandez/node/commit/f4676a305b6a88b9a8f2b7444fd11889790ea77d
nodejs#49566https://github.com/nodejs/node/pull/49566
targoshttps://github.com/targos
Nov 11, 2023 https://github.com/nodejs/node/pull/49566#ref-commit-55485ff
https://github.com/pimterry
https://github.com/targos
crypto: return clear errors when loading invalid PFX datahttps://github.com/nodejs/node/commit/55485ff1cc4caec867e460d8b0c26e140178ded5
55485ffhttps://github.com/nodejs/node/commit/55485ff1cc4caec867e460d8b0c26e140178ded5
#49566https://github.com/nodejs/node/pull/49566
https://github.com/targos
targoshttps://github.com/targos
Nov 12, 2023 https://github.com/nodejs/node/pull/49566#ref-pullrequest-1989293723
v20.10.0 release proposal #50682 https://github.com/nodejs/node/pull/50682
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Dec 6, 2023 https://github.com/nodejs/node/pull/49566#ref-pullrequest-2029497346
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41 https://github.com/nodesource/nsolid/pull/41
debadree25https://github.com/debadree25
Apr 15, 2024 https://github.com/nodejs/node/pull/49566#ref-commit-9f848d2
https://github.com/pimterry
https://github.com/debadree25
crypto: return clear errors when loading invalid PFX datahttps://github.com/debadree25/node/commit/9f848d238f4d382959e94de64e56ab12e2ddbbd4
9f848d2https://github.com/debadree25/node/commit/9f848d238f4d382959e94de64e56ab12e2ddbbd4
nodejs#49566https://github.com/nodejs/node/pull/49566
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49566
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/49566/files/dbc7ee0a662ab332cfc7f67d0fac9501927d3f07
https://github.com/aymen94
aymen94 https://github.com/aymen94
https://github.com/nodejs/node/pull/49566/files/dbc7ee0a662ab332cfc7f67d0fac9501927d3f07
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Provide clearer error messages when a TLS pfx does not contain a private key https://github.com/nodejs/node/issues/49562
Please reload this pagehttps://github.com/nodejs/node/pull/49566
https://github.com/pimterry
https://github.com/nodejs-github-bot
https://github.com/bnoordhuis
https://github.com/aymen94
https://github.com/aduh95
https://github.com/debadree25
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.