| route-pattern | /:user_id/:repository/pull/:id/files/:range(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:bbf30121-8e06-7c7c-8489-e6d393f29a5e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8F1E:D1974:81641D:B2CA93:6997594A |
| html-safe-nonce | 8c6a48faecab93ae48458370a59f410eedbe464f8a29a0f2124db7498f4e98c2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjFFOkQxOTc0OjgxNjQxRDpCMkNBOTM6Njk5NzU5NEEiLCJ2aXNpdG9yX2lkIjoiNTA1MTA5NzExOTE2MTAxNDYwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3a8f9183176521ecb095968632c404e66477f87dda776926745b3f15db762fd0 |
| hovercard-subject-tag | pull_request:1505630752 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e |
| twitter:image | https://avatars.githubusercontent.com/u/456802?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/456802?s=400&v=4 |
| og:image:alt | This PR adds JSDoc annotations for all the files in lib/internal/modules/* as well as a lint rule to enforce keeping that code annotated. |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | c2f6b9675e9141deef3eda21e5cb896d461bd4d25aeaeeba804502ef0e8d01f2 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 06ceed63f0d4941788d6c52a00d38ad77b6eaf89 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49523%2Ffiles%2F51755422f0aef3d04ca5be9ac08cc3a7c21f722e |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49523%2Ffiles%2F51755422f0aef3d04ca5be9ac08cc3a7c21f722e |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e |
| Reload | https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e |
| Reload | https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
116k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.8k
| https://github.com/nodejs/node/issues |
|
Pull requests
713
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| GeoffreyBooth:tidy-modules-code | https://github.com/GeoffreyBooth/node/tree/tidy-modules-code |
|
Conversation
43
| https://github.com/nodejs/node/pull/49523 |
|
Commits
15
| https://github.com/nodejs/node/pull/49523/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/49523/checks |
|
Files changed
| https://github.com/nodejs/node/pull/49523/files |
| Please reload this page | https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e |
|
esm: jsdoc for modules code
| https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e#top |
|
Show all changes
15 commits
| https://github.com/nodejs/node/pull/49523/files |
|
921c63c
module, esm: jsdoc for modules files
GeoffreyBooth Sep 6, 2023
| https://github.com/nodejs/node/pull/49523/commits/921c63c47a0f11cbbd6e7dfb3bb27238b101952b |
|
b47083e
cjs/loader.js
GeoffreyBooth Sep 8, 2023
| https://github.com/nodejs/node/pull/49523/commits/b47083e38fab323f45a64582e73af8b101262fef |
|
1f2ecf2
doc: `esm/fetchModule` (and `DNS.lookup`)
JakobJingleheimer Sep 10, 2023
| https://github.com/nodejs/node/pull/49523/commits/1f2ecf2e347002d30899605e90e80f772ad76c6d |
|
0cf7ac4
doc: esm/Loader
JakobJingleheimer Sep 10, 2023
| https://github.com/nodejs/node/pull/49523/commits/0cf7ac4ee3b006855f559992851ae082b63a89e8 |
|
6a14a29
create_dynamic_module.js
GeoffreyBooth Sep 12, 2023
| https://github.com/nodejs/node/pull/49523/commits/6a14a2916464eaf4e47eb47f4d92fbc5300ae766 |
|
47aac83
handle_process_exit.js
GeoffreyBooth Sep 12, 2023
| https://github.com/nodejs/node/pull/49523/commits/47aac83607f1f0ebc7385a7738ceef5f72700ab3 |
|
b2272ec
esm/resolve.js, esm/package_config.js
GeoffreyBooth Sep 13, 2023
| https://github.com/nodejs/node/pull/49523/commits/b2272ec7411c60230280d0ee2a79723635b4b7ad |
|
28e75ca
esm/translators.js
GeoffreyBooth Sep 14, 2023
| https://github.com/nodejs/node/pull/49523/commits/28e75caa3a7e9688bdf0378b2f38853e1e358778 |
|
d1222d4
esm/utils.js
GeoffreyBooth Sep 14, 2023
| https://github.com/nodejs/node/pull/49523/commits/d1222d468e4b942dd6b910cf84f4b08c2226e1f8 |
|
9b3f8cc
esm/worker.js
GeoffreyBooth Sep 14, 2023
| https://github.com/nodejs/node/pull/49523/commits/9b3f8cc1b3a94c0203fc27009757679a7a8c592b |
|
6621451
Update lib/internal/modules/esm/loader.js
GeoffreyBooth Sep 14, 2023
| https://github.com/nodejs/node/pull/49523/commits/6621451bcb05fa98b4715812bfff400e70e92fb7 |
|
5e158dd
Apply suggestions from code review
GeoffreyBooth Sep 14, 2023
| https://github.com/nodejs/node/pull/49523/commits/5e158dd3de706b283cc10abc65ba8d8c0b2cdb36 |
|
21833b1
fixup! module, esm: jsdoc for modules files
GeoffreyBooth Sep 17, 2023
| https://github.com/nodejs/node/pull/49523/commits/21833b1a50cb850440228561e97de337d49b9a7d |
|
2b22e30
Update lib/internal/modules/helpers.js
GeoffreyBooth Sep 18, 2023
| https://github.com/nodejs/node/pull/49523/commits/2b22e3036bd3a01dc43f6822f7a8eb5c1af475f2 |
|
5175542
Review notes
GeoffreyBooth Sep 18, 2023
| https://github.com/nodejs/node/pull/49523/commits/51755422f0aef3d04ca5be9ac08cc3a7c21f722e |
|
Clear filters
| https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e |
| Please reload this page | https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e |
| Please reload this page | https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e |
|
promises.js
| https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e#diff-5139fb07d9975e15fbf14e8ed02ac44f57b774ddf1de093631305218242c0978 |
|
loader.js
| https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142 |
|
create_dynamic_module.js
| https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e#diff-532b675a8256bbde0c05fc33879730cd1e8177d9288423bfc8d0e6bf2851beed |
|
fetch_module.js
| https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e#diff-90074cf1270f0cf5c7c280398d290c54eaac7c9f99f7d130fa4beb5548e015a9 |
|
handle_process_exit.js
| https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e#diff-9405d0ac60e4b95d4cf0e55c0c2c7c86cc2bb16f3a7ccd94ba8fc3a8ba93a432 |
|
loader.js
| https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b |
|
package_config.js
| https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e#diff-64eb12e93dee42d6759dd940c53ad4027f944724937a24285c28305e0b26f436 |
|
resolve.js
| https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e#diff-b4c24f634e3741e5ad9e8c29864a48f2bd284a9d66d8fed3d077ccee0c44087b |
|
translators.js
| https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e#diff-b1de5e9ce1e9b411001c63d11a5092dbba32e1586269a20dc11408375eb2f16c |
|
utils.js
| https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e#diff-1831d1a1c94734d1167c7283fc5bedcce59011985d583a956e7abc16e1fb00c2 |
|
worker.js
| https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e#diff-b38c96b1c95d7c90430c8ea8f248ad3d49098a2e000bac8b4ee91cdde79cb25b |
|
helpers.js
| https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e#diff-fddf8a06747f8c9e83cd2a3ebee0f53dbd790567ce018044e70bd0ffbbcc815e |
|
run_main.js
| https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e#diff-9cdd961b23c4d25cc188f6b0beb3bf0228e3696a5f830cef198b1673b547bed3 |
| lib/internal/dns/promises.js | https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e#diff-5139fb07d9975e15fbf14e8ed02ac44f57b774ddf1de093631305218242c0978 |
|
View file
| https://github.com/GeoffreyBooth/node/blob/51755422f0aef3d04ca5be9ac08cc3a7c21f722e/lib/internal/dns/promises.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/49523/files/{{ revealButtonHref }} |
|
| https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e#diff-5139fb07d9975e15fbf14e8ed02ac44f57b774ddf1de093631305218242c0978 |
|
| https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e#diff-5139fb07d9975e15fbf14e8ed02ac44f57b774ddf1de093631305218242c0978 |
|
| https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e#diff-5139fb07d9975e15fbf14e8ed02ac44f57b774ddf1de093631305218242c0978 |
|
| https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e#diff-5139fb07d9975e15fbf14e8ed02ac44f57b774ddf1de093631305218242c0978 |
| Please reload this page | https://github.com/nodejs/node/pull/49523/files/51755422f0aef3d04ca5be9ac08cc3a7c21f722e |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |