| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4aeb603d-5b03-01d8-d31c-eb6d627ba94c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E6CE:27157C:12B098E:18F6AC7:69699CD3 |
| html-safe-nonce | 76f7a9116aec09c3197f41902901e8045342e2eb46f74c34161c484f1fb7eec5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkNFOjI3MTU3QzoxMkIwOThFOjE4RjZBQzc6Njk2OTlDRDMiLCJ2aXNpdG9yX2lkIjoiODMxMDI3MjczNzUwMTg3OTUwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 007b691dad837861841e7c75715bfb84103d5ae7630c6c7c6ce68fabc26d223d |
| hovercard-subject-tag | pull_request:1492505876 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/49396/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1ff3832ecca584bac1f65b8aa1e49273f212a3feeac31737e6941ad492e83c0e/nodejs/node/pull/49396 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1ff3832ecca584bac1f65b8aa1e49273f212a3feeac31737e6941ad492e83c0e/nodejs/node/pull/49396 |
| og:image:alt | The original PR by @Xstoudi seems abandoned (ref: #49087)
Fixes: #48759 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | anonrig |
| hostname | github.com |
| expected-hostname | github.com |
| None | 24c4c97a2d520cb286b35e1a4c22d7a4df3c26a2fa28dd7cdf0e65db327b4de7 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 124667f43168afb6c9c03b7c02eb5b1d2e1be3d9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/49396#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49396 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49396 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/49396 |
| Reload | https://github.com/nodejs/node/pull/49396 |
| Reload | https://github.com/nodejs/node/pull/49396 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/49396 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/49396 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/49396#issue-comment-box |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| anonrig:url-append-slash | https://github.com/anonrig/node/tree/url-append-slash |
|
url: handle unicode hostname if empty
| https://github.com/nodejs/node/pull/49396#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| anonrig:url-append-slash | https://github.com/anonrig/node/tree/url-append-slash |
|
Conversation
5
| https://github.com/nodejs/node/pull/49396 |
|
Commits
1
| https://github.com/nodejs/node/pull/49396/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/49396/checks |
|
Files changed
| https://github.com/nodejs/node/pull/49396/files |
| Please reload this page | https://github.com/nodejs/node/pull/49396 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| Aug 28, 2023 | https://github.com/nodejs/node/pull/49396#issue-1870233701 |
| @Xstoudi | https://github.com/Xstoudi |
| #49087 | https://github.com/nodejs/node/pull/49087 |
| #48759 | https://github.com/nodejs/node/issues/48759 |
| Please reload this page | https://github.com/nodejs/node/pull/49396 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 28, 2023 | https://github.com/nodejs/node/pull/49396#issuecomment-1696142606 |
| Please reload this page | https://github.com/nodejs/node/pull/49396 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
whatwg-url
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awhatwg-url |
| Aug 28, 2023 | https://github.com/nodejs/node/pull/49396#event-10212227038 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Aug 28, 2023 | https://github.com/nodejs/node/pull/49396#issuecomment-1696220888 |
| @Xstoudi | https://github.com/Xstoudi |
| Please reload this page | https://github.com/nodejs/node/pull/49396 |
|
| https://github.com/anonrig |
| url: handle unicode hostname if empty | https://github.com/nodejs/node/pull/49396/commits/4bee90eccc51643c470eae528a6bd3366ef43b43 |
| 4bee90e | https://github.com/nodejs/node/pull/49396/commits/4bee90eccc51643c470eae528a6bd3366ef43b43 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| force-pushed | https://github.com/nodejs/node/compare/159c92c6b990cf9973d003fe660bb95d6b67d7f5..4bee90eccc51643c470eae528a6bd3366ef43b43 |
| 159c92c | https://github.com/nodejs/node/commit/159c92c6b990cf9973d003fe660bb95d6b67d7f5 |
| 4bee90e | https://github.com/nodejs/node/commit/4bee90eccc51643c470eae528a6bd3366ef43b43 |
|
Compare
| https://github.com/nodejs/node/compare/159c92c6b990cf9973d003fe660bb95d6b67d7f5..4bee90eccc51643c470eae528a6bd3366ef43b43 |
| August 29, 2023 18:41 | https://github.com/nodejs/node/pull/49396#event-10224624827 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Aug 29, 2023 | https://github.com/nodejs/node/pull/49396#event-10224627564 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| cjihrig | https://github.com/cjihrig |
| August 29, 2023 18:41 | https://github.com/nodejs/node/pull/49396#event-10224628080 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
review wanted
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22 |
| Aug 29, 2023 | https://github.com/nodejs/node/pull/49396#event-10224628688 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Aug 29, 2023 | https://github.com/nodejs/node/pull/49396#event-10224676616 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 29, 2023 | https://github.com/nodejs/node/pull/49396#issuecomment-1697960389 |
| https://ci.nodejs.org/job/node-test-pull-request/53621/ | https://ci.nodejs.org/job/node-test-pull-request/53621/ |
| Please reload this page | https://github.com/nodejs/node/pull/49396 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Aug 29, 2023
| https://github.com/nodejs/node/pull/49396#pullrequestreview-1601123369 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/49396/files/4bee90eccc51643c470eae528a6bd3366ef43b43 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Aug 29, 2023 | https://github.com/nodejs/node/pull/49396#event-10224967519 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Aug 30, 2023
| https://github.com/nodejs/node/pull/49396#pullrequestreview-1603369497 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/49396/files/4bee90eccc51643c470eae528a6bd3366ef43b43 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 30, 2023 | https://github.com/nodejs/node/pull/49396#issuecomment-1699746619 |
| https://ci.nodejs.org/job/node-test-pull-request/53651/ | https://ci.nodejs.org/job/node-test-pull-request/53651/ |
| Please reload this page | https://github.com/nodejs/node/pull/49396 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Aug 31, 2023 | https://github.com/nodejs/node/pull/49396#event-10242837013 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Aug 31, 2023 | https://github.com/nodejs/node/pull/49396#event-10242925555 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| f863117 | https://github.com/nodejs/node/commit/f863117ba35c28e3c8ab7b7a8567be623195f33f |
| Aug 31, 2023 | https://github.com/nodejs/node/pull/49396#event-10242926474 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 31, 2023 | https://github.com/nodejs/node/pull/49396#issuecomment-1700775547 |
| f863117 | https://github.com/nodejs/node/commit/f863117ba35c28e3c8ab7b7a8567be623195f33f |
| Please reload this page | https://github.com/nodejs/node/pull/49396 |
| UlisesGascon | https://github.com/UlisesGascon |
|
Sep 10, 2023
| https://github.com/nodejs/node/pull/49396#ref-commit-e787673 |
|
| https://github.com/anonrig |
|
| https://github.com/UlisesGascon |
| url: handle unicode hostname if empty | https://github.com/nodejs/node/commit/e787673dcf528e4564c2f48feab8741ddc048f04 |
| e787673 | https://github.com/nodejs/node/commit/e787673dcf528e4564c2f48feab8741ddc048f04 |
| #49396 | https://github.com/nodejs/node/pull/49396 |
| #48759 | https://github.com/nodejs/node/issues/48759 |
| https://github.com/UlisesGascon |
| UlisesGascon | https://github.com/UlisesGascon |
|
Sep 10, 2023
| https://github.com/nodejs/node/pull/49396#ref-pullrequest-1889284210 |
|
v20.7.0 proposal
#49592
| https://github.com/nodejs/node/pull/49592 |
| alexfernandez | https://github.com/alexfernandez |
|
Nov 1, 2023
| https://github.com/nodejs/node/pull/49396#ref-commit-e58fb61 |
|
| https://github.com/anonrig |
|
| https://github.com/alexfernandez |
| url: handle unicode hostname if empty | https://github.com/alexfernandez/node/commit/e58fb61f85003c8083040c3cb2c9a075cc4d4e2d |
| e58fb61 | https://github.com/alexfernandez/node/commit/e58fb61f85003c8083040c3cb2c9a075cc4d4e2d |
| nodejs#49396 | https://github.com/nodejs/node/pull/49396 |
| nodejs#48759 | https://github.com/nodejs/node/issues/48759 |
| targos | https://github.com/targos |
|
Nov 27, 2023
| https://github.com/nodejs/node/pull/49396#ref-commit-f256b16 |
|
| https://github.com/anonrig |
|
| https://github.com/targos |
| url: handle unicode hostname if empty | https://github.com/nodejs/node/commit/f256b160bfdc1aed20d7917f03b2c26b980a06de |
| f256b16 | https://github.com/nodejs/node/commit/f256b160bfdc1aed20d7917f03b2c26b980a06de |
| #49396 | https://github.com/nodejs/node/pull/49396 |
| #48759 | https://github.com/nodejs/node/issues/48759 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Nov 28, 2023
| https://github.com/nodejs/node/pull/49396#ref-pullrequest-2014162105 |
|
v18.19.0 release proposal
#50953
| https://github.com/nodejs/node/pull/50953 |
| sercher | https://github.com/sercher |
|
Apr 25, 2024
| https://github.com/nodejs/node/pull/49396#ref-commit-3486a1e |
|
| https://github.com/sercher |
| url: handle unicode hostname if empty | https://github.com/sercher/graaljs/commit/3486a1eab6f31a48bad069bdfb589843b55d8663 |
| 3486a1e | https://github.com/sercher/graaljs/commit/3486a1eab6f31a48bad069bdfb589843b55d8663 |
| nodejs/node#49396 | https://github.com/nodejs/node/pull/49396 |
| nodejs/node#48759 | https://github.com/nodejs/node/issues/48759 |
| sercher | https://github.com/sercher |
|
Apr 25, 2024
| https://github.com/nodejs/node/pull/49396#ref-commit-ae94700 |
|
| https://github.com/sercher |
| url: handle unicode hostname if empty | https://github.com/sercher/graaljs/commit/ae94700636bd247bfd48e0c4ef22a0a49e1bca13 |
| ae94700 | https://github.com/sercher/graaljs/commit/ae94700636bd247bfd48e0c4ef22a0a49e1bca13 |
| nodejs/node#49396 | https://github.com/nodejs/node/pull/49396 |
| nodejs/node#48759 | https://github.com/nodejs/node/issues/48759 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49396 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/49396/files/4bee90eccc51643c470eae528a6bd3366ef43b43 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/49396/files/4bee90eccc51643c470eae528a6bd3366ef43b43 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
review wanted
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22 |
|
whatwg-url
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awhatwg-url |
|
WHATWG URL API format() function inserts '//' wrongly when 'unicode' is set
| https://github.com/nodejs/node/issues/48759 |
| Please reload this page | https://github.com/nodejs/node/pull/49396 |
|
| https://github.com/anonrig |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/cjihrig |
|
| https://github.com/lpinca |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |