René's URL Explorer Experiment


Title: Fix a segfault by ensuring TLS Sockets are closed if the underlying stream closes by pimterry · Pull Request #49327 · nodejs/node · GitHub

Open Graph Title: Fix a segfault by ensuring TLS Sockets are closed if the underlying stream closes by pimterry · Pull Request #49327 · nodejs/node

X Title: Fix a segfault by ensuring TLS Sockets are closed if the underlying stream closes by pimterry · Pull Request #49327 · nodejs/node

Description: This fixes a potential HTTP/2 segfault (#49307, #48567) caused by underlying TLS behaviour, and likely fixes various other apparently related issues (#46094, #35695). I found this while investigati...

Open Graph Description: This fixes a potential HTTP/2 segfault (#49307, #48567) caused by underlying TLS behaviour, and likely fixes various other apparently related issues (#46094, #35695). I found this while investigati...

X Description: This fixes a potential HTTP/2 segfault (#49307, #48567) caused by underlying TLS behaviour, and likely fixes various other apparently related issues (#46094, #35695). I found this while investigati...

Opengraph URL: https://github.com/nodejs/node/pull/49327

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0e8e9e8b-29e4-6c09-4dde-d90c59433ab8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBCE4:15B54C:311B631:409D3BD:6964A72E
html-safe-nonce0fe16228ea7e6f4eea828b69204777a8e5fdd5c86dfacd3ff099eb5312349850
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQ0U0OjE1QjU0QzozMTFCNjMxOjQwOUQzQkQ6Njk2NEE3MkUiLCJ2aXNpdG9yX2lkIjoiMTQ0NjM5NDE3MzU3OTM3MjMzNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac66a5c352b2fa6c8b82e77c381ab424dbe1eb014f47e6cfeba7c9e5d6ccdbe964
hovercard-subject-tagpull_request:1489986899
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/49327/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/676385c9805b40cb8a9e047054ab84300b23daa7851c4da339822cf70deee70c/nodejs/node/pull/49327
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/676385c9805b40cb8a9e047054ab84300b23daa7851c4da339822cf70deee70c/nodejs/node/pull/49327
og:image:altThis fixes a potential HTTP/2 segfault (#49307, #48567) caused by underlying TLS behaviour, and likely fixes various other apparently related issues (#46094, #35695). I found this while investigati...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepimterry
hostnamegithub.com
expected-hostnamegithub.com
None15579c46431b7fd25941c3b09010f74fd1890c7a35226839bbbf40ce70fb3057
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release499abb347cb197601d399c346cfeb4b3fa135d5c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/49327#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49327
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49327
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/49327
Reloadhttps://github.com/nodejs/node/pull/49327
Reloadhttps://github.com/nodejs/node/pull/49327
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/49327
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.3k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 687 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/49327
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/49327#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
pimterry:fix-tls-shutdownhttps://github.com/pimterry/node/tree/fix-tls-shutdown
Fix a segfault by ensuring TLS Sockets are closed if the underlying stream closes https://github.com/nodejs/node/pull/49327#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
pimterry:fix-tls-shutdownhttps://github.com/pimterry/node/tree/fix-tls-shutdown
Conversation 14 https://github.com/nodejs/node/pull/49327
Commits 2 https://github.com/nodejs/node/pull/49327/commits
Checks 0 https://github.com/nodejs/node/pull/49327/checks
Files changed https://github.com/nodejs/node/pull/49327/files
Please reload this pagehttps://github.com/nodejs/node/pull/49327
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Aug 25, 2023https://github.com/nodejs/node/pull/49327#issue-1867326703
Please reload this pagehttps://github.com/nodejs/node/pull/49327
#49307https://github.com/nodejs/node/issues/49307
#48567https://github.com/nodejs/node/issues/48567
#46094https://github.com/nodejs/node/issues/46094
#35695https://github.com/nodejs/node/issues/35695
#48519https://github.com/nodejs/node/issues/48519
herehttps://github.com/nodejs/node/commit/4cdb0e89d8daf7e1371c3b8d3f057940aa327d4a
herehttps://github.com/nodejs/node/commit/595efd8b9a463886c20fb04103c508bd9c3630e7
herehttps://github.com/nodejs/node/pull/11947#pullrequestreview-27980092
herehttps://github.com/nodejs/node/pull/24290
herehttps://github.com/nodejs/node/pull/34105
@addaleaxhttps://github.com/addaleax
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/49327
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Aug 25, 2023https://github.com/nodejs/node/pull/49327#event-10194717516
https://github.com/pimterry
tls: ensure TLS Sockets are closed if the underlying wrap closeshttps://github.com/nodejs/node/pull/49327/commits/06fc0795cdf53e9239ad25ea779d18bd3ac00ff8
06fc079https://github.com/nodejs/node/pull/49327/commits/06fc0795cdf53e9239ad25ea779d18bd3ac00ff8
https://github.com/pimterry
pimterryhttps://github.com/pimterry
force-pushedhttps://github.com/nodejs/node/compare/e068064c48bfd2dee25b6451e431e3ead546189c..06fc0795cdf53e9239ad25ea779d18bd3ac00ff8
e068064https://github.com/nodejs/node/commit/e068064c48bfd2dee25b6451e431e3ead546189c
06fc079https://github.com/nodejs/node/commit/06fc0795cdf53e9239ad25ea779d18bd3ac00ff8
Compare https://github.com/nodejs/node/compare/e068064c48bfd2dee25b6451e431e3ead546189c..06fc0795cdf53e9239ad25ea779d18bd3ac00ff8
August 25, 2023 16:20https://github.com/nodejs/node/pull/49327#event-10194803710
https://github.com/aduh95
aduh95https://github.com/aduh95
Aug 26, 2023https://github.com/nodejs/node/pull/49327#issuecomment-1694182092
Please reload this pagehttps://github.com/nodejs/node/pull/49327
https://github.com/pimterry
Tweak new H2 shutdown test towards reliable ordering & client shutdownhttps://github.com/nodejs/node/pull/49327/commits/87ceb7eeea01dc52542236241fe613f4961aabf8
87ceb7ehttps://github.com/nodejs/node/pull/49327/commits/87ceb7eeea01dc52542236241fe613f4961aabf8
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Aug 28, 2023https://github.com/nodejs/node/pull/49327#issuecomment-1695441587
@aduh95https://github.com/aduh95
Please reload this pagehttps://github.com/nodejs/node/pull/49327
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Aug 28, 2023https://github.com/nodejs/node/pull/49327#issuecomment-1695718604
Please reload this pagehttps://github.com/nodejs/node/pull/49327
Uncaught exception in socket code: "Cannot read properties of null (reading 'finishWrite')" #46094 https://github.com/nodejs/node/issues/46094
Fix JS Stream Socket finishShutdown crash #49400 https://github.com/nodejs/node/pull/49400
https://github.com/lpinca
lpincahttps://github.com/lpinca
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 29, 2023https://github.com/nodejs/node/pull/49327#event-10220024646
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 29, 2023https://github.com/nodejs/node/pull/49327#event-10220033589
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 29, 2023https://github.com/nodejs/node/pull/49327#issuecomment-1697269860
https://ci.nodejs.org/job/node-test-pull-request/53608/https://ci.nodejs.org/job/node-test-pull-request/53608/
Please reload this pagehttps://github.com/nodejs/node/pull/49327
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Aug 29, 2023 https://github.com/nodejs/node/pull/49327#pullrequestreview-1600235070
View reviewed changes https://github.com/nodejs/node/pull/49327/files/87ceb7eeea01dc52542236241fe613f4961aabf8
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/49327#pullrequestreview-1600235070
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/49327
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 30, 2023 https://github.com/nodejs/node/pull/49327#ref-issue-1872669980
CI Reliability 2023-08-30 nodejs/reliability#650 https://github.com/nodejs/reliability/issues/650
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Aug 30, 2023https://github.com/nodejs/node/pull/49327#issuecomment-1698919942
win-v2019-arm64https://ci.nodejs.org/job/node-compile-windows/nodes=win-vs2019-arm64/52140/
node-test-commit-osx on osx 10.15https://ci.nodejs.org/job/node-test-commit-osx/54001/nodes=osx1015
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/49327
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 30, 2023https://github.com/nodejs/node/pull/49327#issuecomment-1699724011
https://ci.nodejs.org/job/node-test-pull-request/53650/https://ci.nodejs.org/job/node-test-pull-request/53650/
Please reload this pagehttps://github.com/nodejs/node/pull/49327
https://github.com/mcollina
mcollinahttps://github.com/mcollina
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Aug 30, 2023https://github.com/nodejs/node/pull/49327#event-10238064254
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 30, 2023https://github.com/nodejs/node/pull/49327#event-10238113116
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 30, 2023https://github.com/nodejs/node/pull/49327#issuecomment-1699965242
https://github.com/nodejs/node/actions/runs/6030922076https://github.com/nodejs/node/actions/runs/6030922076
Please reload this pagehttps://github.com/nodejs/node/pull/49327
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 31, 2023 https://github.com/nodejs/node/pull/49327#ref-issue-1874544009
CI Reliability 2023-08-31 nodejs/reliability#651 https://github.com/nodejs/reliability/issues/651
https://github.com/mcollina
mcollinahttps://github.com/mcollina
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
Aug 31, 2023https://github.com/nodejs/node/pull/49327#event-10244327293
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 31, 2023https://github.com/nodejs/node/pull/49327#event-10244473716
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 31, 2023https://github.com/nodejs/node/pull/49327#issuecomment-1700987582
https://github.com/nodejs/node/actions/runs/6037572193https://github.com/nodejs/node/actions/runs/6037572193
Please reload this pagehttps://github.com/nodejs/node/pull/49327
https://github.com/debadree25
debadree25https://github.com/debadree25
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 1, 2023https://github.com/nodejs/node/pull/49327#event-10253808175
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 1, 2023https://github.com/nodejs/node/pull/49327#event-10253859472
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
048e0behttps://github.com/nodejs/node/commit/048e0bec51475e62663b45ad744f4e02a6eaf2af
Sep 1, 2023https://github.com/nodejs/node/pull/49327#event-10253860268
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 1, 2023https://github.com/nodejs/node/pull/49327#issuecomment-1702266571
048e0behttps://github.com/nodejs/node/commit/048e0bec51475e62663b45ad744f4e02a6eaf2af
Please reload this pagehttps://github.com/nodejs/node/pull/49327
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Sep 1, 2023 https://github.com/nodejs/node/pull/49327#ref-issue-1775831618
Reproducible Segfault in HTTP2 module #48567 https://github.com/nodejs/node/issues/48567
CI Reliability 2023-09-02 nodejs/reliability#653 https://github.com/nodejs/reliability/issues/653
CI Reliability 2023-09-03 nodejs/reliability#654 https://github.com/nodejs/reliability/issues/654
https://github.com/lpinca
lpincahttps://github.com/lpinca
Sep 9, 2023https://github.com/nodejs/node/pull/49327#issuecomment-1712522739
Please reload this pagehttps://github.com/nodejs/node/pull/49327
@pimterryhttps://github.com/pimterry
Please reload this pagehttps://github.com/nodejs/node/pull/49327
https://github.com/lpinca
lpincahttps://github.com/lpinca
Sep 9, 2023https://github.com/nodejs/node/pull/49327#issuecomment-1712523425
Please reload this pagehttps://github.com/nodejs/node/pull/49327
Please reload this pagehttps://github.com/nodejs/node/pull/49327
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Sep 9, 2023https://github.com/nodejs/node/pull/49327#issuecomment-1712525257
Please reload this pagehttps://github.com/nodejs/node/pull/49327
lpincahttps://github.com/lpinca
Sep 9, 2023 https://github.com/nodejs/node/pull/49327#ref-commit-03a2d48
https://github.com/lpinca
test: deflake test-tls-socket-closehttps://github.com/lpinca/node/commit/03a2d4849f03b3d0922d2b6d0c324a1e886e95e7
03a2d48https://github.com/lpinca/node/commit/03a2d4849f03b3d0922d2b6d0c324a1e886e95e7
nodejs#49327 (comment)https://github.com/nodejs/node/pull/49327#issuecomment-1712525257
https://github.com/lpinca
lpincahttps://github.com/lpinca
Sep 9, 2023 https://github.com/nodejs/node/pull/49327#ref-pullrequest-1888773286
test: deflake test-tls-socket-close #49575 https://github.com/nodejs/node/pull/49575
https://github.com/lpinca
lpincahttps://github.com/lpinca
Sep 9, 2023https://github.com/nodejs/node/pull/49327#issuecomment-1712530319
Please reload this pagehttps://github.com/nodejs/node/pull/49327
UlisesGasconhttps://github.com/UlisesGascon
Sep 10, 2023 https://github.com/nodejs/node/pull/49327#ref-commit-8949cc7
https://github.com/pimterry
https://github.com/UlisesGascon
tls: ensure TLS Sockets are closed if the underlying wrap closeshttps://github.com/nodejs/node/commit/8949cc79ddd0441495a1375044a3472740e7507d
8949cc7https://github.com/nodejs/node/commit/8949cc79ddd0441495a1375044a3472740e7507d
#49327https://github.com/nodejs/node/pull/49327
https://github.com/UlisesGascon
UlisesGasconhttps://github.com/UlisesGascon
Sep 10, 2023 https://github.com/nodejs/node/pull/49327#ref-pullrequest-1889284210
v20.7.0 proposal #49592 https://github.com/nodejs/node/pull/49592
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 13, 2023 https://github.com/nodejs/node/pull/49327#ref-commit-ccf46ba
https://github.com/lpinca
test: deflake test-tls-socket-closehttps://github.com/nodejs/node/commit/ccf46ba0f5ce02ae85b8bdb5e29acfc376caf9fc
ccf46bahttps://github.com/nodejs/node/commit/ccf46ba0f5ce02ae85b8bdb5e29acfc376caf9fc
#49327 (comment)https://github.com/nodejs/node/pull/49327#issuecomment-1712525257
#49575https://github.com/nodejs/node/pull/49575
ruyadornohttps://github.com/ruyadorno
Sep 28, 2023 https://github.com/nodejs/node/pull/49327#ref-commit-185d9b5
https://github.com/lpinca
https://github.com/ruyadorno
test: deflake test-tls-socket-closehttps://github.com/nodejs/node/commit/185d9b50dbfb027c010cebff2307163a5a80089e
185d9b5https://github.com/nodejs/node/commit/185d9b50dbfb027c010cebff2307163a5a80089e
#49327 (comment)https://github.com/nodejs/node/pull/49327#issuecomment-1712525257
#49575https://github.com/nodejs/node/pull/49575
alexfernandezhttps://github.com/alexfernandez
Nov 1, 2023 https://github.com/nodejs/node/pull/49327#ref-commit-c8377cc
https://github.com/pimterry
https://github.com/alexfernandez
tls: ensure TLS Sockets are closed if the underlying wrap closeshttps://github.com/alexfernandez/node/commit/c8377ccde47eace39b2c5c66ae08573bb396e911
c8377cchttps://github.com/alexfernandez/node/commit/c8377ccde47eace39b2c5c66ae08573bb396e911
nodejs#49327https://github.com/nodejs/node/pull/49327
alexfernandezhttps://github.com/alexfernandez
Nov 1, 2023 https://github.com/nodejs/node/pull/49327#ref-commit-d05e6bc
https://github.com/lpinca
https://github.com/alexfernandez
test: deflake test-tls-socket-closehttps://github.com/alexfernandez/node/commit/d05e6bc970cb27c6ad335cff5519e6ff2af130fc
d05e6bchttps://github.com/alexfernandez/node/commit/d05e6bc970cb27c6ad335cff5519e6ff2af130fc
nodejs#49327 (comment)https://github.com/nodejs/node/pull/49327#issuecomment-1712525257
nodejs#49575https://github.com/nodejs/node/pull/49575
codebyterehttps://github.com/codebytere
Nov 6, 2023 https://github.com/nodejs/node/pull/49327#ref-commit-27c228d
https://github.com/codebytere
tls: ensure TLS Sockets are closed if the underlying wrap closeshttps://github.com/electron/electron/commit/27c228db57420ff97969307ee973874ca64e16e4
27c228dhttps://github.com/electron/electron/commit/27c228db57420ff97969307ee973874ca64e16e4
nodejs/node#49327https://github.com/nodejs/node/pull/49327
codebyterehttps://github.com/codebytere
Nov 14, 2023 https://github.com/nodejs/node/pull/49327#ref-commit-57e6248
https://github.com/codebytere
tls: ensure TLS Sockets are closed if the underlying wrap closeshttps://github.com/electron/electron/commit/57e624848185d355006853c8568a423b1f6b099d
57e6248https://github.com/electron/electron/commit/57e624848185d355006853c8568a423b1f6b099d
nodejs/node#49327https://github.com/nodejs/node/pull/49327
codebyterehttps://github.com/codebytere
Nov 15, 2023 https://github.com/nodejs/node/pull/49327#ref-commit-7e776ce
https://github.com/codebytere
tls: ensure TLS Sockets are closed if the underlying wrap closeshttps://github.com/electron/electron/commit/7e776cea423f2a976a4d42777359e885b2909206
7e776cehttps://github.com/electron/electron/commit/7e776cea423f2a976a4d42777359e885b2909206
nodejs/node#49327https://github.com/nodejs/node/pull/49327
codebyterehttps://github.com/codebytere
Nov 16, 2023 https://github.com/nodejs/node/pull/49327#ref-commit-5f881ea
https://github.com/codebytere
tls: ensure TLS Sockets are closed if the underlying wrap closeshttps://github.com/electron/electron/commit/5f881ea1143dba1d138db904ce3acf7027c61c9b
5f881eahttps://github.com/electron/electron/commit/5f881ea1143dba1d138db904ce3acf7027c61c9b
nodejs/node#49327https://github.com/nodejs/node/pull/49327
codebyterehttps://github.com/codebytere
Nov 21, 2023 https://github.com/nodejs/node/pull/49327#ref-commit-e645d89
https://github.com/codebytere
tls: ensure TLS Sockets are closed if the underlying wrap closeshttps://github.com/electron/electron/commit/e645d891d411ad935d3279a3c23e4d38f8cbd419
e645d89https://github.com/electron/electron/commit/e645d891d411ad935d3279a3c23e4d38f8cbd419
nodejs/node#49327https://github.com/nodejs/node/pull/49327
codebyterehttps://github.com/codebytere
Nov 22, 2023 https://github.com/nodejs/node/pull/49327#ref-commit-26fa4b2
https://github.com/codebytere
tls: ensure TLS Sockets are closed if the underlying wrap closeshttps://github.com/electron/electron/commit/26fa4b2077474929c71e560ef746723980f644d2
26fa4b2https://github.com/electron/electron/commit/26fa4b2077474929c71e560ef746723980f644d2
nodejs/node#49327https://github.com/nodejs/node/pull/49327
codebyterehttps://github.com/codebytere
Nov 28, 2023 https://github.com/nodejs/node/pull/49327#ref-commit-7a0c9b2
https://github.com/codebytere
tls: ensure TLS Sockets are closed if the underlying wrap closeshttps://github.com/electron/electron/commit/7a0c9b27db5dd0e118f0127caf0376f558da3c01
7a0c9b2https://github.com/electron/electron/commit/7a0c9b27db5dd0e118f0127caf0376f558da3c01
nodejs/node#49327https://github.com/nodejs/node/pull/49327
codebyterehttps://github.com/codebytere
Nov 29, 2023 https://github.com/nodejs/node/pull/49327#ref-commit-a80becc
https://github.com/codebytere
tls: ensure TLS Sockets are closed if the underlying wrap closeshttps://github.com/electron/electron/commit/a80becc0bca23afca70a97b10bc88276b8e45b1e
a80becchttps://github.com/electron/electron/commit/a80becc0bca23afca70a97b10bc88276b8e45b1e
nodejs/node#49327https://github.com/nodejs/node/pull/49327
jkleinschttps://github.com/jkleinsc
Nov 30, 2023 https://github.com/nodejs/node/pull/49327#ref-commit-9c94fd7
https://github.com/codebytere
https://github.com/VerteDinde
https://github.com/MarshallOfSound
chore: upgrade to Node.js v20 (https://github.com/electron/electron/commit/9c94fd7afb4706c2d2228a455f0874a0370cfe1d
#40545https://github.com/electron/electron/pull/40545
)https://github.com/electron/electron/commit/9c94fd7afb4706c2d2228a455f0874a0370cfe1d
9c94fd7https://github.com/electron/electron/commit/9c94fd7afb4706c2d2228a455f0874a0370cfe1d
nodejs/node#49279https://github.com/nodejs/node/pull/49279
nodejs/node#46909https://github.com/nodejs/node/pull/46909
nodejs/node#45704https://github.com/nodejs/node/pull/45704
nodejs/node#49162https://github.com/nodejs/node/pull/49162
nodejs/node#46997https://github.com/nodejs/node/pull/46997
nodejs/node#45673https://github.com/nodejs/node/pull/45673
nodejs/node#49492https://github.com/nodejs/node/pull/49492
nodejs/node#44498https://github.com/nodejs/node/pull/44498
nodejs/node#48078https://github.com/nodejs/node/pull/48078
nodejs/node#44741https://github.com/nodejs/node/pull/44741
nodejs/node#49168https://github.com/nodejs/node/pull/49168
nodejs/node#47999https://github.com/nodejs/node/pull/47999
nodejs/node#45942https://github.com/nodejs/node/pull/45942
nodejs/node#47999https://github.com/nodejs/node/pull/47999
nodejs/node#46652https://github.com/nodejs/node/pull/46652
nodejs/node#45849https://github.com/nodejs/node/pull/45849
nodejs/node#49854https://github.com/nodejs/node/pull/49854
nodejs/node#45849https://github.com/nodejs/node/pull/45849
nodejs/node#46904https://github.com/nodejs/node/pull/46904
nodejs/node#48992https://github.com/nodejs/node/pull/48992
nodejs/node#47740https://github.com/nodejs/node/pull/47740
nodejs/node#48943https://github.com/nodejs/node/pull/48943
nodejs/node#45230https://github.com/nodejs/node/pull/45230
nodejs/node#49327https://github.com/nodejs/node/pull/49327
nodejs/node#49575https://github.com/nodejs/node/pull/49575
nodejs/node#49400https://github.com/nodejs/node/pull/49400
nodejs/node#49400https://github.com/nodejs/node/pull/49400
nodejs/node#46864https://github.com/nodejs/node/pull/46864
nodejs/node#44348https://github.com/nodejs/node/pull/44348
nodejs/node#45258https://github.com/nodejs/node/pull/45258
nodejs/node#48191https://github.com/nodejs/node/pull/48191
nodejs/node#46965https://github.com/nodejs/node/pull/46965
nodejs/node#49874https://github.com/nodejs/node/pull/49874
nodejs/node#45942https://github.com/nodejs/node/pull/45942
nodejs/node#47746https://github.com/nodejs/node/pull/47746
https://chromium-review.googlesource.com/c/v8/v8/+/5006387https://chromium-review.googlesource.com/c/v8/v8/+/5006387
nodejs/node#46965https://github.com/nodejs/node/pull/46965
nodejs/node#44031https://github.com/nodejs/node/pull/44031
nodejs/node#47887https://github.com/nodejs/node/pull/47887
nodejs/node#49684https://github.com/nodejs/node/pull/49684
nodejs/node#44193https://github.com/nodejs/node/pull/44193
nodejs/node#49659https://github.com/nodejs/node/pull/49659
nodejs/node#50709https://github.com/nodejs/node/pull/50709
MrHuangJserhttps://github.com/MrHuangJser
Dec 11, 2023 https://github.com/nodejs/node/pull/49327#ref-commit-34651d1
https://github.com/codebytere
https://github.com/VerteDinde
https://github.com/MarshallOfSound
chore: upgrade to Node.js v20 (https://github.com/MrHuangJser/electron/commit/34651d1b1c47f50fee7c26d552bc52a7bd9e70c4
electron#40545https://github.com/electron/electron/pull/40545
)https://github.com/MrHuangJser/electron/commit/34651d1b1c47f50fee7c26d552bc52a7bd9e70c4
34651d1https://github.com/MrHuangJser/electron/commit/34651d1b1c47f50fee7c26d552bc52a7bd9e70c4
nodejs/node#49279https://github.com/nodejs/node/pull/49279
nodejs/node#46909https://github.com/nodejs/node/pull/46909
nodejs/node#45704https://github.com/nodejs/node/pull/45704
nodejs/node#49162https://github.com/nodejs/node/pull/49162
nodejs/node#46997https://github.com/nodejs/node/pull/46997
nodejs/node#45673https://github.com/nodejs/node/pull/45673
nodejs/node#49492https://github.com/nodejs/node/pull/49492
nodejs/node#44498https://github.com/nodejs/node/pull/44498
nodejs/node#48078https://github.com/nodejs/node/pull/48078
nodejs/node#44741https://github.com/nodejs/node/pull/44741
nodejs/node#49168https://github.com/nodejs/node/pull/49168
nodejs/node#47999https://github.com/nodejs/node/pull/47999
nodejs/node#45942https://github.com/nodejs/node/pull/45942
nodejs/node#47999https://github.com/nodejs/node/pull/47999
nodejs/node#46652https://github.com/nodejs/node/pull/46652
nodejs/node#45849https://github.com/nodejs/node/pull/45849
nodejs/node#49854https://github.com/nodejs/node/pull/49854
nodejs/node#45849https://github.com/nodejs/node/pull/45849
nodejs/node#46904https://github.com/nodejs/node/pull/46904
nodejs/node#48992https://github.com/nodejs/node/pull/48992
nodejs/node#47740https://github.com/nodejs/node/pull/47740
nodejs/node#48943https://github.com/nodejs/node/pull/48943
nodejs/node#45230https://github.com/nodejs/node/pull/45230
nodejs/node#49327https://github.com/nodejs/node/pull/49327
nodejs/node#49575https://github.com/nodejs/node/pull/49575
nodejs/node#49400https://github.com/nodejs/node/pull/49400
nodejs/node#49400https://github.com/nodejs/node/pull/49400
nodejs/node#46864https://github.com/nodejs/node/pull/46864
nodejs/node#44348https://github.com/nodejs/node/pull/44348
nodejs/node#45258https://github.com/nodejs/node/pull/45258
nodejs/node#48191https://github.com/nodejs/node/pull/48191
nodejs/node#46965https://github.com/nodejs/node/pull/46965
nodejs/node#49874https://github.com/nodejs/node/pull/49874
nodejs/node#45942https://github.com/nodejs/node/pull/45942
nodejs/node#47746https://github.com/nodejs/node/pull/47746
https://chromium-review.googlesource.com/c/v8/v8/+/5006387https://chromium-review.googlesource.com/c/v8/v8/+/5006387
nodejs/node#46965https://github.com/nodejs/node/pull/46965
nodejs/node#44031https://github.com/nodejs/node/pull/44031
nodejs/node#47887https://github.com/nodejs/node/pull/47887
nodejs/node#49684https://github.com/nodejs/node/pull/49684
nodejs/node#44193https://github.com/nodejs/node/pull/44193
nodejs/node#49659https://github.com/nodejs/node/pull/49659
nodejs/node#50709https://github.com/nodejs/node/pull/50709
https://github.com/dglittle
dglittlehttps://github.com/dglittle
Jan 7, 2026 https://github.com/nodejs/node/pull/49327#ref-issue-3787716236
Assertion failure crash in TLSWrap::DoWrite with zombie HTTP/2 session (close event not propagated from OS-level CLOSED socket) #61304 https://github.com/nodejs/node/issues/61304
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49327
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/49327/files/87ceb7eeea01dc52542236241fe613f4961aabf8
https://github.com/debadree25
debadree25 https://github.com/debadree25
https://github.com/nodejs/node/pull/49327/files/87ceb7eeea01dc52542236241fe613f4961aabf8
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Please reload this pagehttps://github.com/nodejs/node/pull/49327
https://github.com/pimterry
https://github.com/aduh95
https://github.com/nodejs-github-bot
https://github.com/lpinca
https://github.com/mcollina
https://github.com/debadree25
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.