René's URL Explorer Experiment


Title: src,lib: fix assert when `Error.prepareStackTrace` not overridden by codebytere · Pull Request #49212 · nodejs/node · GitHub

Open Graph Title: src,lib: fix assert when `Error.prepareStackTrace` not overridden by codebytere · Pull Request #49212 · nodejs/node

X Title: src,lib: fix assert when `Error.prepareStackTrace` not overridden by codebytere · Pull Request #49212 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Refs #23926 Fixes an issue caused when embedders choose to set up the v8::Isolate without a prepareStackTrace callback. In this event, several assert methods stop working because stack trace format...

X Description: Refs #23926 Fixes an issue caused when embedders choose to set up the v8::Isolate without a prepareStackTrace callback. In this event, several assert methods stop working because stack trace format...

Opengraph URL: https://github.com/nodejs/node/pull/49212

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7304cfae-4506-82dc-6f16-de4fb2c3ceb6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idABE2:100AB9:1537E19:1D6BB95:6A4DEFC9
html-safe-nonce8a578b50e5e0cae47ce8e43254eb53fb5a3e70335c2db69bd0fa847d40c455e5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkUyOjEwMEFCOToxNTM3RTE5OjFENkJCOTU6NkE0REVGQzkiLCJ2aXNpdG9yX2lkIjoiNTMyMjIwNzI2NjA1NjU2NDY4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac715ce01c3459412aaa569c9bed83354ed787c56da3cb1fe2261433b15b47db40
hovercard-subject-tagpull_request:1478688099
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/49212/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3a05550c4c5df958638913ce8546769aaccc521ab1c63ac32a64ed35dad49aed/nodejs/node/pull/49212
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3a05550c4c5df958638913ce8546769aaccc521ab1c63ac32a64ed35dad49aed/nodejs/node/pull/49212
og:image:altRefs #23926 Fixes an issue caused when embedders choose to set up the v8::Isolate without a prepareStackTrace callback. In this event, several assert methods stop working because stack trace format...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecodebytere
hostnamegithub.com
expected-hostnamegithub.com
None5818716c93c6a2925b815402541a32814e43a7b1261c322b0c2df75224289566
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef4bb89367ca678f057d79b1abc45d6675b1bd5b2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/49212#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49212
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49212
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/49212
Reloadhttps://github.com/nodejs/node/pull/49212
Reloadhttps://github.com/nodejs/node/pull/49212
Please reload this pagehttps://github.com/nodejs/node/pull/49212
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/49212
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
codebyterehttps://github.com/codebytere
nodejs:mainhttps://github.com/nodejs/node/tree/main
codebytere:fix-handle-no-override-preparestacktracehttps://github.com/codebytere/node/tree/fix-handle-no-override-preparestacktrace
Conversationhttps://github.com/nodejs/node/pull/49212
Commits1 (1)https://github.com/nodejs/node/pull/49212/commits
Checkshttps://github.com/nodejs/node/pull/49212/checks
Files changedhttps://github.com/nodejs/node/pull/49212/files
src,lib: fix assert when Error.prepareStackTrace not overriddenhttps://github.com/nodejs/node/pull/49212#top
codebyterehttps://github.com/codebytere
nodejs:mainhttps://github.com/nodejs/node/tree/main
codebytere:fix-handle-no-override-preparestacktracehttps://github.com/codebytere/node/tree/fix-handle-no-override-preparestacktrace
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Aug 17, 2023https://github.com/nodejs/node/pull/49212#issue-1854606226
Please reload this pagehttps://github.com/nodejs/node/pull/49212
#23926https://github.com/nodejs/node/pull/23926
stack trace formattinghttps://github.com/nodejs/node/blob/189d584244610063dfe3dd5cb8ffd439b0c17855/lib/assert.js#L292-L293
Please reload this pagehttps://github.com/nodejs/node/pull/49212
https://github.com/codebytere
codebyterehttps://github.com/codebytere
embedding https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aembedding
Aug 17, 2023https://github.com/nodejs/node/pull/49212#event-10117009337
https://github.com/codebytere
codebyterehttps://github.com/codebytere
devsnekhttps://github.com/devsnek
August 17, 2023 09:23https://github.com/nodejs/node/pull/49212#event-10117009347
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Aug 17, 2023https://github.com/nodejs/node/pull/49212#event-10117011653
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Aug 17, 2023 https://github.com/nodejs/node/pull/49212#ref-pullrequest-1853633086
fix: assert module in the renderer process electron/electron#39540 https://github.com/electron/electron/pull/39540
https://github.com/codebytere
codebyterehttps://github.com/codebytere
force-pushedhttps://github.com/nodejs/node/compare/40a5d30f59641d066f667858c203df8f8ae8a983..661bc353f56d1a9f9122ecc0898c02fb9a481d57
40a5d30https://github.com/nodejs/node/commit/40a5d30f59641d066f667858c203df8f8ae8a983
661bc35https://github.com/nodejs/node/commit/661bc353f56d1a9f9122ecc0898c02fb9a481d57
Compare https://github.com/nodejs/node/compare/40a5d30f59641d066f667858c203df8f8ae8a983..661bc353f56d1a9f9122ecc0898c02fb9a481d57
August 17, 2023 10:34https://github.com/nodejs/node/pull/49212#event-10117836597
https://github.com/codebytere
src,lib: fix assert when Error.prepareStackTrace not overriddenhttps://github.com/nodejs/node/pull/49212/commits/151654e5e9ac9d234f44294bb6b20be82a1d215e
151654ehttps://github.com/nodejs/node/pull/49212/commits/151654e5e9ac9d234f44294bb6b20be82a1d215e
https://github.com/codebytere
codebyterehttps://github.com/codebytere
force-pushedhttps://github.com/nodejs/node/compare/661bc353f56d1a9f9122ecc0898c02fb9a481d57..151654e5e9ac9d234f44294bb6b20be82a1d215e
661bc35https://github.com/nodejs/node/commit/661bc353f56d1a9f9122ecc0898c02fb9a481d57
151654ehttps://github.com/nodejs/node/commit/151654e5e9ac9d234f44294bb6b20be82a1d215e
Compare https://github.com/nodejs/node/compare/661bc353f56d1a9f9122ecc0898c02fb9a481d57..151654e5e9ac9d234f44294bb6b20be82a1d215e
August 17, 2023 10:36https://github.com/nodejs/node/pull/49212#event-10117854975
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Aug 17, 2023 https://github.com/nodejs/node/pull/49212#pullrequestreview-1583160384
View reviewed changes https://github.com/nodejs/node/pull/49212/files/151654e5e9ac9d234f44294bb6b20be82a1d215e
src/node_options.cchttps://github.com/nodejs/node/pull/49212/files/151654e5e9ac9d234f44294bb6b20be82a1d215e#diff-d0b7433f8ca620eba56fc39f79429c73e2b3f061ca6d27583132a37b788b8aa8
joyeecheunghttps://github.com/joyeecheung
Aug 17, 2023https://github.com/nodejs/node/pull/49212#discussion_r1297547837
Please reload this pagehttps://github.com/nodejs/node/pull/49212
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
node/lib/internal/bootstrap/realm.jshttps://github.com/nodejs/node/blob/fe219e043827f5885d9c764a95324ded14ea94bf/lib/internal/bootstrap/realm.js#L449
fe219e0https://github.com/nodejs/node/commit/fe219e043827f5885d9c764a95324ded14ea94bf
Please reload this pagehttps://github.com/nodejs/node/pull/49212
codebyterehttps://github.com/codebytere
Aug 17, 2023https://github.com/nodejs/node/pull/49212#discussion_r1297605114
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/49212
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Aug 17, 2023 https://github.com/nodejs/node/pull/49212#pullrequestreview-1583224860
View reviewed changes https://github.com/nodejs/node/pull/49212/files/151654e5e9ac9d234f44294bb6b20be82a1d215e
lib/assert.jshttps://github.com/nodejs/node/pull/49212/files/151654e5e9ac9d234f44294bb6b20be82a1d215e#diff-4354d778aaf56c7c9558812b2f108f001388ef2a6ae846dda4e08f16a5edb20f
joyeecheunghttps://github.com/joyeecheung
Aug 17, 2023https://github.com/nodejs/node/pull/49212#discussion_r1297588025
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/49212
devsnekhttps://github.com/devsnek
Aug 17, 2023https://github.com/nodejs/node/pull/49212#discussion_r1297616852
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/v8/v8/blob/main/src/execution/messages.cc#L325-L335https://github.com/v8/v8/blob/main/src/execution/messages.cc#L325-L335
Please reload this pagehttps://github.com/nodejs/node/pull/49212
joyeecheunghttps://github.com/joyeecheung
Aug 18, 2023https://github.com/nodejs/node/pull/49212#discussion_r1298526092
Please reload this pagehttps://github.com/nodejs/node/pull/49212
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/49212
https://github.com/aduh95
aduh95https://github.com/aduh95
Aug 17, 2023 https://github.com/nodejs/node/pull/49212#pullrequestreview-1583269161
View reviewed changes https://github.com/nodejs/node/pull/49212/files/151654e5e9ac9d234f44294bb6b20be82a1d215e
lib/assert.jshttps://github.com/nodejs/node/pull/49212/files/151654e5e9ac9d234f44294bb6b20be82a1d215e#diff-4354d778aaf56c7c9558812b2f108f001388ef2a6ae846dda4e08f16a5edb20f
aduh95https://github.com/aduh95
Aug 17, 2023https://github.com/nodejs/node/pull/49212#discussion_r1297616131
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/49212
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Aug 17, 2023 https://github.com/nodejs/node/pull/49212#pullrequestreview-1583265942
View reviewed changes https://github.com/nodejs/node/pull/49212/files/151654e5e9ac9d234f44294bb6b20be82a1d215e
lib/.eslintrc.yamlhttps://github.com/nodejs/node/pull/49212/files/151654e5e9ac9d234f44294bb6b20be82a1d215e#diff-a36322e55dc4faed79296547f0da2740f29391f0305b82d7c788f8e6e8a46c00
devsnekhttps://github.com/devsnek
Aug 17, 2023https://github.com/nodejs/node/pull/49212#discussion_r1297614148
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/49212
lib/assert.jshttps://github.com/nodejs/node/pull/49212/files/151654e5e9ac9d234f44294bb6b20be82a1d215e#diff-4354d778aaf56c7c9558812b2f108f001388ef2a6ae846dda4e08f16a5edb20f
devsnekhttps://github.com/devsnek
Aug 17, 2023https://github.com/nodejs/node/pull/49212#discussion_r1297616852
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/v8/v8/blob/main/src/execution/messages.cc#L325-L335https://github.com/v8/v8/blob/main/src/execution/messages.cc#L325-L335
Please reload this pagehttps://github.com/nodejs/node/pull/49212
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Apr 5, 2025https://github.com/nodejs/node/pull/49212#event-17141073095
https://github.com/codebytere
codebyterehttps://github.com/codebytere
April 5, 2025 18:58https://github.com/nodejs/node/pull/49212#event-17141074835
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49212
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/49212/files/151654e5e9ac9d234f44294bb6b20be82a1d215e
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/49212/files/151654e5e9ac9d234f44294bb6b20be82a1d215e
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/49212/files/151654e5e9ac9d234f44294bb6b20be82a1d215e
assert https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aassert
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
embedding https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aembedding
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/49212
https://github.com/codebytere
https://github.com/joyeecheung
https://github.com/devsnek
https://github.com/aduh95
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.