| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:918c6c9c-c891-2bcd-e43a-1448544fc115 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BD2C:13A77B:9DD30D:D6E75A:6969E6F0 |
| html-safe-nonce | 6858edb6b2dba1fd93a93c4a6e0557c83911df8a0844422c50fe82ddb8d0095b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDJDOjEzQTc3Qjo5REQzMEQ6RDZFNzVBOjY5NjlFNkYwIiwidmlzaXRvcl9pZCI6IjYwNzQzMzEwNDI1ODUxMTAyNTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f2568a821eb2be1e10ef9b37ce3d9f234dba3ff41a2f279c313dd9ba15081982 |
| hovercard-subject-tag | pull_request:1475527769 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/49178/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7bfd8c45a78f430bb427c11fb99c19abe8e31f79baa5ea74f2bcb5a2e0608f7d/nodejs/node/pull/49178 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7bfd8c45a78f430bb427c11fb99c19abe8e31f79baa5ea74f2bcb5a2e0608f7d/nodejs/node/pull/49178 |
| og:image:alt | This is a followup to #46965, which will be very helpful for #47637. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | zcbenz |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/49178#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49178 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49178 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/49178 |
| Reload | https://github.com/nodejs/node/pull/49178 |
| Reload | https://github.com/nodejs/node/pull/49178 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/49178 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/49178 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/49178#issue-comment-box |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| zcbenz:patch-10 | https://github.com/zcbenz/node/tree/patch-10 |
|
gyp: put cctest filenames in variables
| https://github.com/nodejs/node/pull/49178#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| zcbenz:patch-10 | https://github.com/zcbenz/node/tree/patch-10 |
|
Conversation
5
| https://github.com/nodejs/node/pull/49178 |
|
Commits
1
| https://github.com/nodejs/node/pull/49178/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/49178/checks |
|
Files changed
| https://github.com/nodejs/node/pull/49178/files |
| Please reload this page | https://github.com/nodejs/node/pull/49178 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
| Aug 15, 2023 | https://github.com/nodejs/node/pull/49178#issue-1851025071 |
| #46965 | https://github.com/nodejs/node/pull/46965 |
| #47637 | https://github.com/nodejs/node/pull/47637 |
| Please reload this page | https://github.com/nodejs/node/pull/49178 |
|
| https://github.com/zcbenz |
| gyp: put cctest filenames in variables | https://github.com/nodejs/node/pull/49178/commits/219b4d2b6399a1f3c370a2d9db0716b88f8862c0 |
| 219b4d2 | https://github.com/nodejs/node/pull/49178/commits/219b4d2b6399a1f3c370a2d9db0716b88f8862c0 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 15, 2023 | https://github.com/nodejs/node/pull/49178#issuecomment-1678535632 |
| Please reload this page | https://github.com/nodejs/node/pull/49178 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Aug 15, 2023 | https://github.com/nodejs/node/pull/49178#event-10094528509 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Aug 15, 2023
| https://github.com/nodejs/node/pull/49178#pullrequestreview-1578112112 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/49178/files/219b4d2b6399a1f3c370a2d9db0716b88f8862c0 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
Aug 15, 2023
| https://github.com/nodejs/node/pull/49178#pullrequestreview-1578124407 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/49178/files/219b4d2b6399a1f3c370a2d9db0716b88f8862c0 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Aug 15, 2023 | https://github.com/nodejs/node/pull/49178#event-10098820233 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Aug 15, 2023
| https://github.com/nodejs/node/pull/49178#pullrequestreview-1578942116 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/49178/files/219b4d2b6399a1f3c370a2d9db0716b88f8862c0 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Aug 15, 2023 | https://github.com/nodejs/node/pull/49178#event-10098841793 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 15, 2023 | https://github.com/nodejs/node/pull/49178#issuecomment-1679230411 |
| https://ci.nodejs.org/job/node-test-pull-request/53344/ | https://ci.nodejs.org/job/node-test-pull-request/53344/ |
| Please reload this page | https://github.com/nodejs/node/pull/49178 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Aug 15, 2023
| https://github.com/nodejs/node/pull/49178#pullrequestreview-1578948745 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/49178/files/219b4d2b6399a1f3c370a2d9db0716b88f8862c0 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Aug 18, 2023
| https://github.com/nodejs/node/pull/49178#ref-issue-1855861714 |
|
CI Reliability 2023-08-18
nodejs/reliability#640
| https://github.com/nodejs/reliability/issues/640 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Aug 21, 2023 | https://github.com/nodejs/node/pull/49178#event-10145213505 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Aug 21, 2023 | https://github.com/nodejs/node/pull/49178#event-10145254644 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 21, 2023 | https://github.com/nodejs/node/pull/49178#issuecomment-1686292740 |
| https://ci.nodejs.org/job/node-test-pull-request/53475/ | https://ci.nodejs.org/job/node-test-pull-request/53475/ |
| Please reload this page | https://github.com/nodejs/node/pull/49178 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Aug 21, 2023
| https://github.com/nodejs/node/pull/49178#pullrequestreview-1587420269 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/49178/files/219b4d2b6399a1f3c370a2d9db0716b88f8862c0 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Aug 22, 2023
| https://github.com/nodejs/node/pull/49178#ref-issue-1860346076 |
|
CI Reliability 2023-08-22
nodejs/reliability#642
| https://github.com/nodejs/reliability/issues/642 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 22, 2023 | https://github.com/nodejs/node/pull/49178#issuecomment-1688077229 |
| https://ci.nodejs.org/job/node-test-pull-request/53491/ | https://ci.nodejs.org/job/node-test-pull-request/53491/ |
| Please reload this page | https://github.com/nodejs/node/pull/49178 |
|
CI Reliability 2023-08-23
nodejs/reliability#643
| https://github.com/nodejs/reliability/issues/643 |
|
CI Reliability 2023-08-24
nodejs/reliability#644
| https://github.com/nodejs/reliability/issues/644 |
|
CI Reliability 2023-08-25
nodejs/reliability#645
| https://github.com/nodejs/reliability/issues/645 |
|
CI Reliability 2023-08-26
nodejs/reliability#646
| https://github.com/nodejs/reliability/issues/646 |
|
CI Reliability 2023-08-27
nodejs/reliability#647
| https://github.com/nodejs/reliability/issues/647 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
|
Sep 8, 2023
| https://github.com/nodejs/node/pull/49178#ref-pullrequest-1676447802 |
|
build: add GN build files
#47637
| https://github.com/nodejs/node/pull/47637 |
| https://github.com/Qard |
| Qard | https://github.com/Qard |
|
Sep 8, 2023
| https://github.com/nodejs/node/pull/49178#pullrequestreview-1617254939 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/49178/files/219b4d2b6399a1f3c370a2d9db0716b88f8862c0 |
| https://github.com/Qard |
| Qard | https://github.com/Qard |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Sep 8, 2023 | https://github.com/nodejs/node/pull/49178#event-10316983841 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Sep 8, 2023 | https://github.com/nodejs/node/pull/49178#event-10317030650 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| 3163f8d | https://github.com/nodejs/node/commit/3163f8d680a43eefa925e8c52ee48ddfb56414b1 |
| Sep 8, 2023 | https://github.com/nodejs/node/pull/49178#event-10317031361 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 8, 2023 | https://github.com/nodejs/node/pull/49178#issuecomment-1711515519 |
| 3163f8d | https://github.com/nodejs/node/commit/3163f8d680a43eefa925e8c52ee48ddfb56414b1 |
| Please reload this page | https://github.com/nodejs/node/pull/49178 |
| ruyadorno | https://github.com/ruyadorno |
|
Sep 28, 2023
| https://github.com/nodejs/node/pull/49178#ref-commit-0f020ed |
|
| https://github.com/zcbenz |
|
| https://github.com/ruyadorno |
| gyp: put cctest filenames in variables | https://github.com/nodejs/node/commit/0f020ed22daabdd85bd356d7a13dd1fcfe63cd3b |
| 0f020ed | https://github.com/nodejs/node/commit/0f020ed22daabdd85bd356d7a13dd1fcfe63cd3b |
| #49178 | https://github.com/nodejs/node/pull/49178 |
|
v20.7.1 proposal
#49917
| https://github.com/nodejs/node/pull/49917 |
|
v20.8.0 proposal
#49932
| https://github.com/nodejs/node/pull/49932 |
| alexfernandez | https://github.com/alexfernandez |
|
Nov 1, 2023
| https://github.com/nodejs/node/pull/49178#ref-commit-9aaec89 |
|
| https://github.com/zcbenz |
|
| https://github.com/alexfernandez |
| gyp: put cctest filenames in variables | https://github.com/alexfernandez/node/commit/9aaec89b80579962c1cea9bcaa570b80d9948d97 |
| 9aaec89 | https://github.com/alexfernandez/node/commit/9aaec89b80579962c1cea9bcaa570b80d9948d97 |
| nodejs#49178 | https://github.com/nodejs/node/pull/49178 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
|
Nov 28, 2023
| https://github.com/nodejs/node/pull/49178#ref-issue-1991709228 |
|
Things blocking a full-featured GN build of upstream Node.js
photoionization/node_with_gn#1
| https://github.com/photoionization/node_with_gn/issues/1 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49178 |
|
| https://github.com/Qard |
|
Qard
| https://github.com/Qard |
|
| https://github.com/nodejs/node/pull/49178/files/219b4d2b6399a1f3c370a2d9db0716b88f8862c0 |
|
| https://github.com/anonrig |
|
anonrig
| https://github.com/anonrig |
|
| https://github.com/nodejs/node/pull/49178/files/219b4d2b6399a1f3c370a2d9db0716b88f8862c0 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/49178/files/219b4d2b6399a1f3c370a2d9db0716b88f8862c0 |
|
| https://github.com/gengjiawen |
|
gengjiawen
| https://github.com/gengjiawen |
|
| https://github.com/nodejs/node/pull/49178/files/219b4d2b6399a1f3c370a2d9db0716b88f8862c0 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/49178/files/219b4d2b6399a1f3c370a2d9db0716b88f8862c0 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/49178/files/219b4d2b6399a1f3c370a2d9db0716b88f8862c0 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Please reload this page | https://github.com/nodejs/node/pull/49178 |
|
| https://github.com/zcbenz |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/Qard |
|
| https://github.com/anonrig |
|
| https://github.com/targos |
|
| https://github.com/gengjiawen |
|
| https://github.com/joyeecheung |
|
| https://github.com/richardlau |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |