René's URL Explorer Experiment


Title: crypto: remove default encoding from DiffieHellman by tniessen · Pull Request #49169 · nodejs/node · GitHub

Open Graph Title: crypto: remove default encoding from DiffieHellman by tniessen · Pull Request #49169 · nodejs/node

X Title: crypto: remove default encoding from DiffieHellman by tniessen · Pull Request #49169 · nodejs/node

Description: getDefaultEncoding() always returns 'buffer' in Node.js 20. In diffiehellman.js, this value is always used as input to either toBuf(), encode(), or getArrayBufferOrView(). All of these functions tr...

Open Graph Description: getDefaultEncoding() always returns 'buffer' in Node.js 20. In diffiehellman.js, this value is always used as input to either toBuf(), encode(), or getArrayBufferOrView(). All of these func...

X Description: getDefaultEncoding() always returns 'buffer' in Node.js 20. In diffiehellman.js, this value is always used as input to either toBuf(), encode(), or getArrayBufferOrView(). All of th...

Opengraph URL: https://github.com/nodejs/node/pull/49169

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:be9f8096-7255-0a25-efe7-4519badee782
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCEA4:84862:70C0F3:9EB8B6:696A1D73
html-safe-noncef929c4afc7551130084bd5e0a38fd796b5989b1e5b81ba2a503cd59ea9bff80d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUE0Ojg0ODYyOjcwQzBGMzo5RUI4QjY6Njk2QTFENzMiLCJ2aXNpdG9yX2lkIjoiNDI1ODQwMDIyNTM4MzI5MjI3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac68978fb0b967788d7fd2204bb63dcc2b1bed4c9b59c55d8615d91a5ce2781e86
hovercard-subject-tagpull_request:1474617254
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/49169/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/620633393b4d99094027a37f598d1bbebb7c5a7ed409b503e1237f72871ce033/nodejs/node/pull/49169
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/620633393b4d99094027a37f598d1bbebb7c5a7ed409b503e1237f72871ce033/nodejs/node/pull/49169
og:image:altgetDefaultEncoding() always returns 'buffer' in Node.js 20. In diffiehellman.js, this value is always used as input to either toBuf(), encode(), or getArrayBufferOrView(). All of these func...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
None014f3d193f36b7d393f88ca22d06fbacd370800b40a547c1ea67291e02dc8ea3
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released515f6f09fa57a93bf90355cb894eb84ca4f458f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/49169#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49169
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49169
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/49169
Reloadhttps://github.com/nodejs/node/pull/49169
Reloadhttps://github.com/nodejs/node/pull/49169
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/49169
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 698 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/49169
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/49169#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
tniessen:crypto-dh-default-encodinghttps://github.com/tniessen/node/tree/crypto-dh-default-encoding
crypto: remove default encoding from DiffieHellman https://github.com/nodejs/node/pull/49169#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
tniessen:crypto-dh-default-encodinghttps://github.com/tniessen/node/tree/crypto-dh-default-encoding
Conversation 7 https://github.com/nodejs/node/pull/49169
Commits 1 https://github.com/nodejs/node/pull/49169/commits
Checks 0 https://github.com/nodejs/node/pull/49169/checks
Files changed https://github.com/nodejs/node/pull/49169/files
Please reload this pagehttps://github.com/nodejs/node/pull/49169
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Aug 14, 2023https://github.com/nodejs/node/pull/49169#issue-1849994969
node/lib/internal/crypto/util.jshttps://github.com/nodejs/node/blob/af9b48a2f17b11b66a8b81beeaba3c408b863795/lib/internal/crypto/util.js#L77-L80
af9b48ahttps://github.com/nodejs/node/commit/af9b48a2f17b11b66a8b81beeaba3c408b863795
#47182https://github.com/nodejs/node/pull/47182
Please reload this pagehttps://github.com/nodejs/node/pull/49169
https://github.com/tniessen
crypto: remove default encoding from DiffieHellmanhttps://github.com/nodejs/node/pull/49169/commits/3bd16c3cc6988263e55a70d12b09c62a815937cf
3bd16c3https://github.com/nodejs/node/pull/49169/commits/3bd16c3cc6988263e55a70d12b09c62a815937cf
nodejs#47182https://github.com/nodejs/node/pull/47182
https://github.com/tniessen
tniessenhttps://github.com/tniessen
dont-land-on-v16.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v16.x
Aug 14, 2023https://github.com/nodejs/node/pull/49169#event-10088082037
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 14, 2023https://github.com/nodejs/node/pull/49169#issuecomment-1677530338
Please reload this pagehttps://github.com/nodejs/node/pull/49169
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Aug 14, 2023https://github.com/nodejs/node/pull/49169#event-10088084904
tniessenhttps://github.com/tniessen
Aug 14, 2023 https://github.com/nodejs/node/pull/49169#ref-commit-d66373c
https://github.com/tniessen
crypto: remove getDefaultEncoding()https://github.com/tniessen/node/commit/d66373ce0e825be0fe31aa91d247622d06c36baa
d66373chttps://github.com/tniessen/node/commit/d66373ce0e825be0fe31aa91d247622d06c36baa
nodejs#47182https://github.com/nodejs/node/pull/47182
nodejs#47869https://github.com/nodejs/node/pull/47869
nodejs#47943https://github.com/nodejs/node/pull/47943
nodejs#47998https://github.com/nodejs/node/pull/47998
nodejs#49140https://github.com/nodejs/node/pull/49140
nodejs#49145https://github.com/nodejs/node/pull/49145
nodejs#49167https://github.com/nodejs/node/pull/49167
nodejs#49169https://github.com/nodejs/node/pull/49169
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 14, 2023 https://github.com/nodejs/node/pull/49169#pullrequestreview-1577110238
View reviewed changes https://github.com/nodejs/node/pull/49169/files/3bd16c3cc6988263e55a70d12b09c62a815937cf
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Aug 14, 2023 https://github.com/nodejs/node/pull/49169#ref-pullrequest-1850030440
crypto: remove getDefaultEncoding() #49170 https://github.com/nodejs/node/pull/49170
https://github.com/tniessen
tniessenhttps://github.com/tniessen
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 14, 2023https://github.com/nodejs/node/pull/49169#event-10088327187
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 14, 2023https://github.com/nodejs/node/pull/49169#event-10088341550
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49169
https://github.com/panva
panvahttps://github.com/panva
Aug 14, 2023 https://github.com/nodejs/node/pull/49169#pullrequestreview-1577154999
View reviewed changes https://github.com/nodejs/node/pull/49169/files/3bd16c3cc6988263e55a70d12b09c62a815937cf
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49169
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 15, 2023 https://github.com/nodejs/node/pull/49169#ref-issue-1850736726
CI Reliability 2023-08-15 nodejs/reliability#637 https://github.com/nodejs/reliability/issues/637
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49169
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49169
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 15, 2023https://github.com/nodejs/node/pull/49169#issuecomment-1679287135
https://ci.nodejs.org/job/node-test-pull-request/53348/https://ci.nodejs.org/job/node-test-pull-request/53348/
Please reload this pagehttps://github.com/nodejs/node/pull/49169
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 16, 2023 https://github.com/nodejs/node/pull/49169#ref-issue-1852311357
CI Reliability 2023-08-16 nodejs/reliability#638 https://github.com/nodejs/reliability/issues/638
https://github.com/tniessen
tniessenhttps://github.com/tniessen
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 16, 2023https://github.com/nodejs/node/pull/49169#event-10109808435
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 16, 2023https://github.com/nodejs/node/pull/49169#event-10109904433
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
7215176https://github.com/nodejs/node/commit/72151769b872f76be795cd95b964c3a5c33b9460
Aug 16, 2023https://github.com/nodejs/node/pull/49169#event-10109905290
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 16, 2023https://github.com/nodejs/node/pull/49169#issuecomment-1680820523
7215176https://github.com/nodejs/node/commit/72151769b872f76be795cd95b964c3a5c33b9460
Please reload this pagehttps://github.com/nodejs/node/pull/49169
tniessenhttps://github.com/tniessen
Aug 16, 2023 https://github.com/nodejs/node/pull/49169#ref-commit-d4a91a8
https://github.com/tniessen
crypto: remove getDefaultEncoding()https://github.com/tniessen/node/commit/d4a91a8fcc67b8edaf3d3e17acdcddaad66f54cd
d4a91a8https://github.com/tniessen/node/commit/d4a91a8fcc67b8edaf3d3e17acdcddaad66f54cd
nodejs#47182https://github.com/nodejs/node/pull/47182
nodejs#47869https://github.com/nodejs/node/pull/47869
nodejs#47943https://github.com/nodejs/node/pull/47943
nodejs#47998https://github.com/nodejs/node/pull/47998
nodejs#49140https://github.com/nodejs/node/pull/49140
nodejs#49145https://github.com/nodejs/node/pull/49145
nodejs#49167https://github.com/nodejs/node/pull/49167
nodejs#49169https://github.com/nodejs/node/pull/49169
CI Reliability 2023-08-17 nodejs/reliability#639 https://github.com/nodejs/reliability/issues/639
CI Reliability 2023-08-18 nodejs/reliability#640 https://github.com/nodejs/reliability/issues/640
debadree25https://github.com/debadree25
Aug 19, 2023 https://github.com/nodejs/node/pull/49169#ref-commit-78842cf
https://github.com/tniessen
https://github.com/debadree25
crypto: remove getDefaultEncoding()https://github.com/nodejs/node/commit/78842cf213aea95a64119b18b036d0255507438c
78842cfhttps://github.com/nodejs/node/commit/78842cf213aea95a64119b18b036d0255507438c
#47182https://github.com/nodejs/node/pull/47182
#47869https://github.com/nodejs/node/pull/47869
#47943https://github.com/nodejs/node/pull/47943
#47998https://github.com/nodejs/node/pull/47998
#49140https://github.com/nodejs/node/pull/49140
#49145https://github.com/nodejs/node/pull/49145
#49167https://github.com/nodejs/node/pull/49167
#49169https://github.com/nodejs/node/pull/49169
#49170https://github.com/nodejs/node/pull/49170
UlisesGasconhttps://github.com/UlisesGascon
Sep 10, 2023 https://github.com/nodejs/node/pull/49169#ref-commit-772496c
https://github.com/tniessen
https://github.com/UlisesGascon
crypto: remove default encoding from DiffieHellmanhttps://github.com/nodejs/node/commit/772496c030fa2f7026d47dcbd59587c01d735e61
772496chttps://github.com/nodejs/node/commit/772496c030fa2f7026d47dcbd59587c01d735e61
#47182https://github.com/nodejs/node/pull/47182
#49169https://github.com/nodejs/node/pull/49169
UlisesGasconhttps://github.com/UlisesGascon
Sep 10, 2023 https://github.com/nodejs/node/pull/49169#ref-commit-7eb10a3
https://github.com/tniessen
https://github.com/UlisesGascon
crypto: remove getDefaultEncoding()https://github.com/nodejs/node/commit/7eb10a38ea3d8c0f132ab0817fa184a76961559f
7eb10a3https://github.com/nodejs/node/commit/7eb10a38ea3d8c0f132ab0817fa184a76961559f
#47182https://github.com/nodejs/node/pull/47182
#47869https://github.com/nodejs/node/pull/47869
#47943https://github.com/nodejs/node/pull/47943
#47998https://github.com/nodejs/node/pull/47998
#49140https://github.com/nodejs/node/pull/49140
#49145https://github.com/nodejs/node/pull/49145
#49167https://github.com/nodejs/node/pull/49167
#49169https://github.com/nodejs/node/pull/49169
#49170https://github.com/nodejs/node/pull/49170
https://github.com/UlisesGascon
UlisesGasconhttps://github.com/UlisesGascon
Sep 10, 2023 https://github.com/nodejs/node/pull/49169#ref-pullrequest-1889284210
v20.7.0 proposal #49592 https://github.com/nodejs/node/pull/49592
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49169
https://github.com/panva
panva https://github.com/panva
https://github.com/nodejs/node/pull/49169/files/3bd16c3cc6988263e55a70d12b09c62a815937cf
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/49169/files/3bd16c3cc6988263e55a70d12b09c62a815937cf
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/49169
https://github.com/tniessen
https://github.com/nodejs-github-bot
https://github.com/panva
https://github.com/benjamingr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.