René's URL Explorer Experiment


Title: bootstrap: do not generate code cache in an unfinalized isolate by joyeecheung · Pull Request #49108 · nodejs/node · GitHub

Open Graph Title: bootstrap: do not generate code cache in an unfinalized isolate by joyeecheung · Pull Request #49108 · nodejs/node

X Title: bootstrap: do not generate code cache in an unfinalized isolate by joyeecheung · Pull Request #49108 · nodejs/node

Description: V8 now no longer supports serializing code cache in an isolate with unfinalized read-only space. So guard the code cache regeneration with the is_building_snapshot() flag. When the isolate is creat...

Open Graph Description: V8 now no longer supports serializing code cache in an isolate with unfinalized read-only space. So guard the code cache regeneration with the is_building_snapshot() flag. When the isolate is creat...

X Description: V8 now no longer supports serializing code cache in an isolate with unfinalized read-only space. So guard the code cache regeneration with the is_building_snapshot() flag. When the isolate is creat...

Opengraph URL: https://github.com/nodejs/node/pull/49108

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b2ccfe7a-6f57-960f-1070-596243526d1a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB056:2E6239:0ECE:1391:6969F879
html-safe-nonce79e0f7feb8cfc9ab93cbfc64cd8519717fc7a3ad6ead9280572f66b52b5a82e0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDU2OjJFNjIzOTowRUNFOjEzOTE6Njk2OUY4NzkiLCJ2aXNpdG9yX2lkIjoiNTEyNjE1NzUzNTI4NTk5OTczNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac52c275a1ebedc444494d474bc96379e7724280658f168b1cae5c51ae56200ae9
hovercard-subject-tagpull_request:1471903997
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/49108/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4960a8ae45e034f22807e7e41974887caa02ae73fe56c436ac039bb6a78b27fd/nodejs/node/pull/49108
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4960a8ae45e034f22807e7e41974887caa02ae73fe56c436ac039bb6a78b27fd/nodejs/node/pull/49108
og:image:altV8 now no longer supports serializing code cache in an isolate with unfinalized read-only space. So guard the code cache regeneration with the is_building_snapshot() flag. When the isolate is creat...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/49108#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49108
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49108
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/49108
Reloadhttps://github.com/nodejs/node/pull/49108
Reloadhttps://github.com/nodejs/node/pull/49108
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/49108
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/49108
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/49108#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
joyeecheung:unfinalized-isolatehttps://github.com/joyeecheung/node/tree/unfinalized-isolate
bootstrap: do not generate code cache in an unfinalized isolate https://github.com/nodejs/node/pull/49108#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
joyeecheung:unfinalized-isolatehttps://github.com/joyeecheung/node/tree/unfinalized-isolate
Conversation 10 https://github.com/nodejs/node/pull/49108
Commits 1 https://github.com/nodejs/node/pull/49108/commits
Checks 0 https://github.com/nodejs/node/pull/49108/checks
Files changed https://github.com/nodejs/node/pull/49108/files
Please reload this pagehttps://github.com/nodejs/node/pull/49108
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Aug 11, 2023https://github.com/nodejs/node/pull/49108#issue-1846931679
Please reload this pagehttps://github.com/nodejs/node/pull/49108
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 11, 2023https://github.com/nodejs/node/pull/49108#issuecomment-1674891084
Please reload this pagehttps://github.com/nodejs/node/pull/49108
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
August 11, 2023 14:31https://github.com/nodejs/node/pull/49108#event-10070444335
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Aug 11, 2023https://github.com/nodejs/node/pull/49108#event-10070446370
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 11, 2023https://github.com/nodejs/node/pull/49108#issuecomment-1674891710
https://ci.nodejs.org/job/node-test-pull-request/53195/https://ci.nodejs.org/job/node-test-pull-request/53195/
Please reload this pagehttps://github.com/nodejs/node/pull/49108
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Aug 11, 2023 https://github.com/nodejs/node/pull/49108#ref-issue-1843545771
Debug build is broken (node_mksnapshot) nodejs/node-v8#252 https://github.com/nodejs/node-v8/issues/252
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
force-pushedhttps://github.com/nodejs/node/compare/d480c3a743d9ae44ce4eee737b1c6c83af267317..2537a874f96abee998c86516ebe8ca761e3f76c8
d480c3ahttps://github.com/nodejs/node/commit/d480c3a743d9ae44ce4eee737b1c6c83af267317
2537a87https://github.com/nodejs/node/commit/2537a874f96abee998c86516ebe8ca761e3f76c8
Compare https://github.com/nodejs/node/compare/d480c3a743d9ae44ce4eee737b1c6c83af267317..2537a874f96abee998c86516ebe8ca761e3f76c8
August 11, 2023 16:58https://github.com/nodejs/node/pull/49108#event-10072015172
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 11, 2023 https://github.com/nodejs/node/pull/49108#pullrequestreview-1574301155
View reviewed changes https://github.com/nodejs/node/pull/49108/files/c35a69a0db71ea038599cd3daa1408b5faac3552
CI Reliability 2023-08-13 nodejs/reliability#635 https://github.com/nodejs/reliability/issues/635
CI Reliability 2023-08-14 nodejs/reliability#636 https://github.com/nodejs/reliability/issues/636
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 15, 2023https://github.com/nodejs/node/pull/49108#event-10098806869
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 15, 2023https://github.com/nodejs/node/pull/49108#event-10098843144
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 15, 2023https://github.com/nodejs/node/pull/49108#issuecomment-1679230765
https://ci.nodejs.org/job/node-test-pull-request/53346/https://ci.nodejs.org/job/node-test-pull-request/53346/
Please reload this pagehttps://github.com/nodejs/node/pull/49108
https://github.com/anonrig
anonrighttps://github.com/anonrig
Aug 15, 2023 https://github.com/nodejs/node/pull/49108#pullrequestreview-1578955217
View reviewed changes https://github.com/nodejs/node/pull/49108/files/c35a69a0db71ea038599cd3daa1408b5faac3552
https://github.com/joyeecheung
bootstrap: do not generate code cache in an unfinalized isolatehttps://github.com/nodejs/node/pull/49108/commits/c35a69a0db71ea038599cd3daa1408b5faac3552
c35a69ahttps://github.com/nodejs/node/pull/49108/commits/c35a69a0db71ea038599cd3daa1408b5faac3552
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
force-pushedhttps://github.com/nodejs/node/compare/2537a874f96abee998c86516ebe8ca761e3f76c8..c35a69a0db71ea038599cd3daa1408b5faac3552
2537a87https://github.com/nodejs/node/commit/2537a874f96abee998c86516ebe8ca761e3f76c8
c35a69ahttps://github.com/nodejs/node/commit/c35a69a0db71ea038599cd3daa1408b5faac3552
Compare https://github.com/nodejs/node/compare/2537a874f96abee998c86516ebe8ca761e3f76c8..c35a69a0db71ea038599cd3daa1408b5faac3552
August 15, 2023 18:38https://github.com/nodejs/node/pull/49108#event-10100248803
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Aug 15, 2023https://github.com/nodejs/node/pull/49108#issuecomment-1679417350
#49110https://github.com/nodejs/node/pull/49110
Please reload this pagehttps://github.com/nodejs/node/pull/49108
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 15, 2023https://github.com/nodejs/node/pull/49108#event-10100252533
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 15, 2023https://github.com/nodejs/node/pull/49108#event-10100294066
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 15, 2023https://github.com/nodejs/node/pull/49108#issuecomment-1679422239
https://ci.nodejs.org/job/node-test-pull-request/53356/https://ci.nodejs.org/job/node-test-pull-request/53356/
Please reload this pagehttps://github.com/nodejs/node/pull/49108
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 15, 2023https://github.com/nodejs/node/pull/49108#event-10100311970
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Aug 15, 2023https://github.com/nodejs/node/pull/49108#issuecomment-1679424483
Please reload this pagehttps://github.com/nodejs/node/pull/49108
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 15, 2023https://github.com/nodejs/node/pull/49108#event-10100338456
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 15, 2023https://github.com/nodejs/node/pull/49108#issuecomment-1679428550
https://ci.nodejs.org/job/node-test-pull-request/53358/https://ci.nodejs.org/job/node-test-pull-request/53358/
Please reload this pagehttps://github.com/nodejs/node/pull/49108
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 16, 2023https://github.com/nodejs/node/pull/49108#issuecomment-1680971727
https://ci.nodejs.org/job/node-test-pull-request/53385/https://ci.nodejs.org/job/node-test-pull-request/53385/
Please reload this pagehttps://github.com/nodejs/node/pull/49108
https://github.com/anonrig
anonrighttps://github.com/anonrig
Aug 16, 2023 https://github.com/nodejs/node/pull/49108#pullrequestreview-1581083540
View reviewed changes https://github.com/nodejs/node/pull/49108/files/c35a69a0db71ea038599cd3daa1408b5faac3552
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 16, 2023https://github.com/nodejs/node/pull/49108#issuecomment-1681214852
https://ci.nodejs.org/job/node-test-pull-request/53389/https://ci.nodejs.org/job/node-test-pull-request/53389/
Please reload this pagehttps://github.com/nodejs/node/pull/49108
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 17, 2023 https://github.com/nodejs/node/pull/49108#ref-issue-1854051960
CI Reliability 2023-08-17 nodejs/reliability#639 https://github.com/nodejs/reliability/issues/639
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 17, 2023https://github.com/nodejs/node/pull/49108#event-10121915509
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 17, 2023https://github.com/nodejs/node/pull/49108#event-10122012108
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fe219e0https://github.com/nodejs/node/commit/fe219e043827f5885d9c764a95324ded14ea94bf
Aug 17, 2023https://github.com/nodejs/node/pull/49108#event-10122012872
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 17, 2023https://github.com/nodejs/node/pull/49108#issuecomment-1682681289
fe219e0https://github.com/nodejs/node/commit/fe219e043827f5885d9c764a95324ded14ea94bf
Please reload this pagehttps://github.com/nodejs/node/pull/49108
CI Reliability 2023-08-18 nodejs/reliability#640 https://github.com/nodejs/reliability/issues/640
CI Reliability 2023-08-21 nodejs/reliability#641 https://github.com/nodejs/reliability/issues/641
UlisesGasconhttps://github.com/UlisesGascon
Sep 10, 2023 https://github.com/nodejs/node/pull/49108#ref-commit-af6dc17
https://github.com/joyeecheung
https://github.com/UlisesGascon
bootstrap: do not generate code cache in an unfinalized isolatehttps://github.com/nodejs/node/commit/af6dc1754d4abe9656f7111bee464ac5465430e0
af6dc17https://github.com/nodejs/node/commit/af6dc1754d4abe9656f7111bee464ac5465430e0
#49108https://github.com/nodejs/node/pull/49108
https://github.com/UlisesGascon
UlisesGasconhttps://github.com/UlisesGascon
Sep 10, 2023 https://github.com/nodejs/node/pull/49108#ref-pullrequest-1889284210
v20.7.0 proposal #49592 https://github.com/nodejs/node/pull/49592
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49108
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/49108/files/c35a69a0db71ea038599cd3daa1408b5faac3552
https://github.com/anonrig
anonrig https://github.com/anonrig
https://github.com/nodejs/node/pull/49108/files/c35a69a0db71ea038599cd3daa1408b5faac3552
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/49108
https://github.com/joyeecheung
https://github.com/nodejs-github-bot
https://github.com/benjamingr
https://github.com/anonrig
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.