René's URL Explorer Experiment


Title: test_runner: run global after() hook earlier by cjihrig · Pull Request #49059 · nodejs/node · GitHub

Open Graph Title: test_runner: run global after() hook earlier by cjihrig · Pull Request #49059 · nodejs/node

X Title: test_runner: run global after() hook earlier by cjihrig · Pull Request #49059 · nodejs/node

Description: This commit moves the global after() hook execution from the 'beforeExit' event to the point where all tests have finished running. This gives the global after() a chance to clean up handles that w...

Open Graph Description: This commit moves the global after() hook execution from the 'beforeExit' event to the point where all tests have finished running. This gives the global after() a chance to clean up handle...

X Description: This commit moves the global after() hook execution from the 'beforeExit' event to the point where all tests have finished running. This gives the global after() a chance to clean u...

Opengraph URL: https://github.com/nodejs/node/pull/49059

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ef7b6e8a-d739-ae8a-3671-6e3e0161e1d2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD66C:359457:67B759:91C143:696A1C21
html-safe-noncec2a7d349d41f2bca3161f3279dc3cf5d8d986f64b361fae9353fea4952ca1424
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjZDOjM1OTQ1Nzo2N0I3NTk6OTFDMTQzOjY5NkExQzIxIiwidmlzaXRvcl9pZCI6IjQ4OTgyMzc3NDcwMzQ3MjU0MDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac40e48e36d2917b034d66e841dadbd243e93b6066119ef62f3ad2e9f10ac422a3
hovercard-subject-tagpull_request:1465968337
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/49059/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f1cfd1271a3da64df5b97890550838c66d0731e09452440effdbaa31c72b572c/nodejs/node/pull/49059
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f1cfd1271a3da64df5b97890550838c66d0731e09452440effdbaa31c72b572c/nodejs/node/pull/49059
og:image:altThis commit moves the global after() hook execution from the 'beforeExit' event to the point where all tests have finished running. This gives the global after() a chance to clean up handle...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecjihrig
hostnamegithub.com
expected-hostnamegithub.com
None34a52bd10bd674f68e5c1b6b74413b79bf2ca20c551055ace3f7cdd112803923
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee8bd37502700f365b18a4d39acf7cb7947e11b1a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/49059#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49059
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49059
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/49059
Reloadhttps://github.com/nodejs/node/pull/49059
Reloadhttps://github.com/nodejs/node/pull/49059
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/49059
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 698 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/49059
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/49059#issue-comment-box
cjihrighttps://github.com/cjihrig
nodejs:mainhttps://github.com/nodejs/node/tree/main
cjihrig:after-handleshttps://github.com/cjihrig/node/tree/after-handles
test_runner: run global after() hook earlier https://github.com/nodejs/node/pull/49059#top
cjihrighttps://github.com/cjihrig
nodejs:mainhttps://github.com/nodejs/node/tree/main
cjihrig:after-handleshttps://github.com/cjihrig/node/tree/after-handles
Conversation 17 https://github.com/nodejs/node/pull/49059
Commits 1 https://github.com/nodejs/node/pull/49059/commits
Checks 0 https://github.com/nodejs/node/pull/49059/checks
Files changed https://github.com/nodejs/node/pull/49059/files
Please reload this pagehttps://github.com/nodejs/node/pull/49059
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 7, 2023https://github.com/nodejs/node/pull/49059#issue-1840267355
Please reload this pagehttps://github.com/nodejs/node/pull/49059
#49056https://github.com/nodejs/node/issues/49056
Please reload this pagehttps://github.com/nodejs/node/pull/49059
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 7, 2023https://github.com/nodejs/node/pull/49059#issuecomment-1668635575
Please reload this pagehttps://github.com/nodejs/node/pull/49059
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
mcollinahttps://github.com/mcollina
August 7, 2023 22:03https://github.com/nodejs/node/pull/49059#event-10029076676
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test_runner https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner
Aug 7, 2023https://github.com/nodejs/node/pull/49059#event-10029077309
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Aug 10, 2023https://github.com/nodejs/node/pull/49059#issuecomment-1673455125
https://github.com/MoLow/node/blob/test-runner-only/test/fixtures/test-runner/output/async-test-scheduling.mjshttps://github.com/MoLow/node/blob/test-runner-only/test/fixtures/test-runner/output/async-test-scheduling.mjs
Please reload this pagehttps://github.com/nodejs/node/pull/49059
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Aug 10, 2023 https://github.com/nodejs/node/pull/49059#pullrequestreview-1572192920
View reviewed changes https://github.com/nodejs/node/pull/49059/files
lib/internal/test_runner/harness.jshttps://github.com/nodejs/node/pull/49059/files#diff-b05fccdd396676d2cafa05396439532ca4ccf77723384065cca8eaac5dec239c
Please reload this pagehttps://github.com/nodejs/node/pull/49059
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Aug 10, 2023 https://github.com/nodejs/node/pull/49059#pullrequestreview-1572195827
View reviewed changes https://github.com/nodejs/node/pull/49059/files
lib/internal/test_runner/test.jshttps://github.com/nodejs/node/pull/49059/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb
Please reload this pagehttps://github.com/nodejs/node/pull/49059
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/9b607858b7cffafeb34fa3879b63d5aa8beab593..60c0edce775a742b63442e81e1002f34cd717ed7
9b60785https://github.com/nodejs/node/commit/9b607858b7cffafeb34fa3879b63d5aa8beab593
60c0edchttps://github.com/nodejs/node/commit/60c0edce775a742b63442e81e1002f34cd717ed7
Compare https://github.com/nodejs/node/compare/9b607858b7cffafeb34fa3879b63d5aa8beab593..60c0edce775a742b63442e81e1002f34cd717ed7
August 10, 2023 22:56https://github.com/nodejs/node/pull/49059#event-10064627933
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
August 10, 2023 22:56https://github.com/nodejs/node/pull/49059#event-10064628503
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 10, 2023https://github.com/nodejs/node/pull/49059#issuecomment-1674035383
https://ci.nodejs.org/job/node-test-pull-request/53154/https://ci.nodejs.org/job/node-test-pull-request/53154/
Please reload this pagehttps://github.com/nodejs/node/pull/49059
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 11, 2023https://github.com/nodejs/node/pull/49059#issuecomment-1674124510
https://ci.nodejs.org/job/node-test-pull-request/53159/https://ci.nodejs.org/job/node-test-pull-request/53159/
Please reload this pagehttps://github.com/nodejs/node/pull/49059
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 11, 2023https://github.com/nodejs/node/pull/49059#issuecomment-1674160616
https://ci.nodejs.org/job/node-test-pull-request/53164/https://ci.nodejs.org/job/node-test-pull-request/53164/
Please reload this pagehttps://github.com/nodejs/node/pull/49059
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 11, 2023https://github.com/nodejs/node/pull/49059#issuecomment-1674169552
Please reload this pagehttps://github.com/nodejs/node/pull/49059
https://ci.nodejs.org/job/node-test-pull-request/53165/https://ci.nodejs.org/job/node-test-pull-request/53165/
Please reload this pagehttps://github.com/nodejs/node/pull/49059
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Aug 11, 2023https://github.com/nodejs/node/pull/49059#event-10065596945
https://github.com/atlowChemi
atlowChemihttps://github.com/atlowChemi
Aug 11, 2023 https://github.com/nodejs/node/pull/49059#pullrequestreview-1573038073
View reviewed changes https://github.com/nodejs/node/pull/49059/files
test/parallel/test-runner-root-after-with-refed-handles.jshttps://github.com/nodejs/node/pull/49059/files#diff-e681e2c3d2fec29b4cc415a58d661e16d62446b6e5a0f1991b7bb37621c891c0
atlowChemihttps://github.com/atlowChemi
Aug 11, 2023https://github.com/nodejs/node/pull/49059#discussion_r1290923432
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@cjihrighttps://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/49059
cjihrighttps://github.com/cjihrig
Aug 11, 2023https://github.com/nodejs/node/pull/49059#discussion_r1291315103
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/49059
https://github.com/atlowChemi
atlowChemihttps://github.com/atlowChemi
Aug 11, 2023 https://github.com/nodejs/node/pull/49059#pullrequestreview-1573038132
View reviewed changes https://github.com/nodejs/node/pull/49059/files/6346bdc526eddefea72ed32e9ec9755cba3fa706
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Aug 11, 2023 https://github.com/nodejs/node/pull/49059#pullrequestreview-1573061500
View reviewed changes https://github.com/nodejs/node/pull/49059/files/6346bdc526eddefea72ed32e9ec9755cba3fa706
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Aug 11, 2023 https://github.com/nodejs/node/pull/49059#pullrequestreview-1573130592
View reviewed changes https://github.com/nodejs/node/pull/49059/files/6346bdc526eddefea72ed32e9ec9755cba3fa706
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/49059#pullrequestreview-1573130592
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/49059
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 11, 2023 https://github.com/nodejs/node/pull/49059#pullrequestreview-1573170558
View reviewed changes https://github.com/nodejs/node/pull/49059/files/6346bdc526eddefea72ed32e9ec9755cba3fa706
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 11, 2023https://github.com/nodejs/node/pull/49059#event-10069473003
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 11, 2023https://github.com/nodejs/node/pull/49059#event-10069552105
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 11, 2023https://github.com/nodejs/node/pull/49059#issuecomment-1674774907
https://github.com/nodejs/node/actions/runs/5832906334https://github.com/nodejs/node/actions/runs/5832906334
Please reload this pagehttps://github.com/nodejs/node/pull/49059
https://github.com/cjihrig
test_runner: run global after() hook earlierhttps://github.com/nodejs/node/pull/49059/commits/6346bdc526eddefea72ed32e9ec9755cba3fa706
6346bdchttps://github.com/nodejs/node/pull/49059/commits/6346bdc526eddefea72ed32e9ec9755cba3fa706
nodejs#49059https://github.com/nodejs/node/pull/49059
nodejs#49056https://github.com/nodejs/node/issues/49056
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
force-pushedhttps://github.com/nodejs/node/compare/60c0edce775a742b63442e81e1002f34cd717ed7..6346bdc526eddefea72ed32e9ec9755cba3fa706
60c0edchttps://github.com/nodejs/node/commit/60c0edce775a742b63442e81e1002f34cd717ed7
6346bdchttps://github.com/nodejs/node/commit/6346bdc526eddefea72ed32e9ec9755cba3fa706
Compare https://github.com/nodejs/node/compare/60c0edce775a742b63442e81e1002f34cd717ed7..6346bdc526eddefea72ed32e9ec9755cba3fa706
August 11, 2023 13:17https://github.com/nodejs/node/pull/49059#event-10069612922
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
6346bdchttps://github.com/nodejs/node/commit/6346bdc526eddefea72ed32e9ec9755cba3fa706
Aug 11, 2023https://github.com/nodejs/node/pull/49059#event-10069616311
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
August 11, 2023 13:17https://github.com/nodejs/node/pull/49059#event-10069618224
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 11, 2023https://github.com/nodejs/node/pull/49059#issuecomment-1674783474
6346bdchttps://github.com/nodejs/node/commit/6346bdc526eddefea72ed32e9ec9755cba3fa706
Please reload this pagehttps://github.com/nodejs/node/pull/49059
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Aug 11, 2023https://github.com/nodejs/node/pull/49059#issuecomment-1675085355
Please reload this pagehttps://github.com/nodejs/node/pull/49059
Please reload this pagehttps://github.com/nodejs/node/pull/49059
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Aug 11, 2023 https://github.com/nodejs/node/pull/49059#ref-pullrequest-1847144215
Revert "test_runner: run global after() hook earlier" #49110 https://github.com/nodejs/node/pull/49110
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Aug 11, 2023 https://github.com/nodejs/node/pull/49059#ref-pullrequest-1846694871
build: fix typo libray -> library (configure.py) #49106 https://github.com/nodejs/node/pull/49106
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 11, 2023https://github.com/nodejs/node/pull/49059#issuecomment-1675171959
Please reload this pagehttps://github.com/nodejs/node/pull/49059
cjihrighttps://github.com/cjihrig
Aug 12, 2023 https://github.com/nodejs/node/pull/49059#ref-commit-6796570
https://github.com/cjihrig
test_runner: reland run global after() hook earlierhttps://github.com/cjihrig/node/commit/67965708b84bddb4694c85108d8708671b1f1a2a
6796570https://github.com/cjihrig/node/commit/67965708b84bddb4694c85108d8708671b1f1a2a
bb52656https://github.com/cjihrig/node/commit/bb52656fc627e4f48a0f706756873b593d81372a
nodejs#49059 (comment)https://github.com/nodejs/node/pull/49059#issuecomment-1675171959
nodejs#49059https://github.com/nodejs/node/pull/49059
nodejs#49110https://github.com/nodejs/node/pull/49110
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 12, 2023 https://github.com/nodejs/node/pull/49059#ref-pullrequest-1848039298
test_runner: reland run global after() hook earlier #49116 https://github.com/nodejs/node/pull/49116
https://github.com/atlowChemi
atlowChemihttps://github.com/atlowChemi
Aug 12, 2023 https://github.com/nodejs/node/pull/49059#ref-pullrequest-1844147271
stream: improve WebStreams creation performance #49089 https://github.com/nodejs/node/pull/49089
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 13, 2023 https://github.com/nodejs/node/pull/49059#ref-issue-1848312005
CI Reliability 2023-08-13 nodejs/reliability#635 https://github.com/nodejs/reliability/issues/635
martenrichterhttps://github.com/martenrichter
Aug 13, 2023 https://github.com/nodejs/node/pull/49059#ref-commit-a962e73
https://github.com/cjihrig
https://github.com/martenrichter
test_runner: run global after() hook earlierhttps://github.com/martenrichter/node/commit/a962e732140c31ac2e85a1180a66d07d050c6519
a962e73https://github.com/martenrichter/node/commit/a962e732140c31ac2e85a1180a66d07d050c6519
nodejs#49059https://github.com/nodejs/node/pull/49059
nodejs#49056https://github.com/nodejs/node/issues/49056
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 14, 2023 https://github.com/nodejs/node/pull/49059#ref-commit-b574075
https://github.com/cjihrig
test_runner: reland run global after() hook earlierhttps://github.com/nodejs/node/commit/b5740756ca67b5477803cb55921535042e301c9d
b574075https://github.com/nodejs/node/commit/b5740756ca67b5477803cb55921535042e301c9d
bb52656https://github.com/nodejs/node/commit/bb52656fc627e4f48a0f706756873b593d81372a
#49059 (comment)https://github.com/nodejs/node/pull/49059#issuecomment-1675171959
#49059https://github.com/nodejs/node/pull/49059
#49110https://github.com/nodejs/node/pull/49110
#49116https://github.com/nodejs/node/pull/49116
Ceres6https://github.com/Ceres6
Aug 14, 2023 https://github.com/nodejs/node/pull/49059#ref-commit-7e81628
https://github.com/cjihrig
https://github.com/Ceres6
test_runner: run global after() hook earlierhttps://github.com/Ceres6/node/commit/7e816284560d8d6d662398d259be9d99b8ef339d
7e81628https://github.com/Ceres6/node/commit/7e816284560d8d6d662398d259be9d99b8ef339d
nodejs#49059https://github.com/nodejs/node/pull/49059
nodejs#49056https://github.com/nodejs/node/issues/49056
Ceres6https://github.com/Ceres6
Aug 14, 2023 https://github.com/nodejs/node/pull/49059#ref-commit-489984c
https://github.com/cjihrig
https://github.com/Ceres6
test_runner: run global after() hook earlierhttps://github.com/Ceres6/node/commit/489984ccdd0d96cc8853db92cf6f549d13144d43
489984chttps://github.com/Ceres6/node/commit/489984ccdd0d96cc8853db92cf6f549d13144d43
nodejs#49059https://github.com/nodejs/node/pull/49059
nodejs#49056https://github.com/nodejs/node/issues/49056
Ceres6https://github.com/Ceres6
Aug 14, 2023 https://github.com/nodejs/node/pull/49059#ref-commit-1373b69
https://github.com/cjihrig
https://github.com/Ceres6
test_runner: reland run global after() hook earlierhttps://github.com/Ceres6/node/commit/1373b69a49547bf24673353bdc8990c936c27a82
1373b69https://github.com/Ceres6/node/commit/1373b69a49547bf24673353bdc8990c936c27a82
bb52656https://github.com/Ceres6/node/commit/bb52656fc627e4f48a0f706756873b593d81372a
nodejs#49059 (comment)https://github.com/nodejs/node/pull/49059#issuecomment-1675171959
nodejs#49059https://github.com/nodejs/node/pull/49059
nodejs#49110https://github.com/nodejs/node/pull/49110
nodejs#49116https://github.com/nodejs/node/pull/49116
RafaelGSShttps://github.com/RafaelGSS
Aug 15, 2023 https://github.com/nodejs/node/pull/49059#ref-commit-b58688b
https://github.com/cjihrig
https://github.com/RafaelGSS
test_runner: run global after() hook earlierhttps://github.com/nodejs/node/commit/b58688ba1dab5e68313acf8b02b7d42a7b9082b7
b58688bhttps://github.com/nodejs/node/commit/b58688ba1dab5e68313acf8b02b7d42a7b9082b7
#49059https://github.com/nodejs/node/pull/49059
#49056https://github.com/nodejs/node/issues/49056
RafaelGSShttps://github.com/RafaelGSS
Aug 15, 2023 https://github.com/nodejs/node/pull/49059#ref-commit-adab698
https://github.com/cjihrig
https://github.com/RafaelGSS
test_runner: reland run global after() hook earlierhttps://github.com/nodejs/node/commit/adab69801d96ffb061692713f662644515133117
adab698https://github.com/nodejs/node/commit/adab69801d96ffb061692713f662644515133117
bb52656https://github.com/nodejs/node/commit/bb52656fc627e4f48a0f706756873b593d81372a
#49059 (comment)https://github.com/nodejs/node/pull/49059#issuecomment-1675171959
#49059https://github.com/nodejs/node/pull/49059
#49110https://github.com/nodejs/node/pull/49110
#49116https://github.com/nodejs/node/pull/49116
https://github.com/UlisesGascon
UlisesGasconhttps://github.com/UlisesGascon
Aug 15, 2023 https://github.com/nodejs/node/pull/49059#ref-pullrequest-1851901207
v20.6.0 proposal #49185 https://github.com/nodejs/node/pull/49185
RafaelGSShttps://github.com/RafaelGSS
Aug 15, 2023 https://github.com/nodejs/node/pull/49059#ref-commit-280b735
https://github.com/cjihrig
https://github.com/RafaelGSS
test_runner: run global after() hook earlierhttps://github.com/RafaelGSS/node/commit/280b735a26076d6ff637f8b59af74db788cc3261
280b735https://github.com/RafaelGSS/node/commit/280b735a26076d6ff637f8b59af74db788cc3261
nodejs#49059https://github.com/nodejs/node/pull/49059
nodejs#49056https://github.com/nodejs/node/issues/49056
RafaelGSShttps://github.com/RafaelGSS
Aug 15, 2023 https://github.com/nodejs/node/pull/49059#ref-commit-b9407ff
https://github.com/cjihrig
https://github.com/RafaelGSS
test_runner: reland run global after() hook earlierhttps://github.com/RafaelGSS/node/commit/b9407ff57cfe053a3b6bdf82589a1be6e193dd2d
b9407ffhttps://github.com/RafaelGSS/node/commit/b9407ff57cfe053a3b6bdf82589a1be6e193dd2d
bb52656https://github.com/RafaelGSS/node/commit/bb52656fc627e4f48a0f706756873b593d81372a
nodejs#49059 (comment)https://github.com/nodejs/node/pull/49059#issuecomment-1675171959
nodejs#49059https://github.com/nodejs/node/pull/49059
nodejs#49110https://github.com/nodejs/node/pull/49110
nodejs#49116https://github.com/nodejs/node/pull/49116
rluvatonhttps://github.com/rluvaton
Aug 15, 2023 https://github.com/nodejs/node/pull/49059#ref-commit-efa10f5
https://github.com/cjihrig
https://github.com/rluvaton
test_runner: run global after() hook earlierhttps://github.com/rluvaton/node/commit/efa10f5f1fe266d3d6ea55482fc159a5c38fa777
efa10f5https://github.com/rluvaton/node/commit/efa10f5f1fe266d3d6ea55482fc159a5c38fa777
nodejs#49059https://github.com/nodejs/node/pull/49059
nodejs#49056https://github.com/nodejs/node/issues/49056
rluvatonhttps://github.com/rluvaton
Aug 15, 2023 https://github.com/nodejs/node/pull/49059#ref-commit-23fce71
https://github.com/cjihrig
https://github.com/rluvaton
test_runner: reland run global after() hook earlierhttps://github.com/rluvaton/node/commit/23fce71aede7b8bd16bf04b98a637a7838fdf58a
23fce71https://github.com/rluvaton/node/commit/23fce71aede7b8bd16bf04b98a637a7838fdf58a
bb52656https://github.com/rluvaton/node/commit/bb52656fc627e4f48a0f706756873b593d81372a
nodejs#49059 (comment)https://github.com/nodejs/node/pull/49059#issuecomment-1675171959
nodejs#49059https://github.com/nodejs/node/pull/49059
nodejs#49110https://github.com/nodejs/node/pull/49110
nodejs#49116https://github.com/nodejs/node/pull/49116
https://github.com/aduh95
aduh95https://github.com/aduh95
dont-land-on-v16.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v16.x
dont-land-on-v20.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v20.x
Aug 16, 2023https://github.com/nodejs/node/pull/49059#event-10105014775
RafaelGSShttps://github.com/RafaelGSS
Aug 16, 2023 https://github.com/nodejs/node/pull/49059#ref-commit-324c8a1
https://github.com/cjihrig
https://github.com/RafaelGSS
test_runner: reland run global after() hook earlierhttps://github.com/nodejs/node/commit/324c8a16d780b707c0205e94f9e6ff0dcf99c3eb
324c8a1https://github.com/nodejs/node/commit/324c8a16d780b707c0205e94f9e6ff0dcf99c3eb
bb52656https://github.com/nodejs/node/commit/bb52656fc627e4f48a0f706756873b593d81372a
#49059 (comment)https://github.com/nodejs/node/pull/49059#issuecomment-1675171959
#49059https://github.com/nodejs/node/pull/49059
#49110https://github.com/nodejs/node/pull/49110
#49116https://github.com/nodejs/node/pull/49116
rluvatonhttps://github.com/rluvaton
Aug 18, 2023 https://github.com/nodejs/node/pull/49059#ref-commit-5f893ac
https://github.com/cjihrig
https://github.com/rluvaton
test_runner: reland run global after() hook earlierhttps://github.com/rluvaton/node/commit/5f893aca21c11c780ca94157a908ca539d211da1
5f893achttps://github.com/rluvaton/node/commit/5f893aca21c11c780ca94157a908ca539d211da1
bb52656https://github.com/rluvaton/node/commit/bb52656fc627e4f48a0f706756873b593d81372a
nodejs#49059 (comment)https://github.com/nodejs/node/pull/49059#issuecomment-1675171959
nodejs#49059https://github.com/nodejs/node/pull/49059
nodejs#49110https://github.com/nodejs/node/pull/49110
nodejs#49116https://github.com/nodejs/node/pull/49116
rluvatonhttps://github.com/rluvaton
Sep 4, 2023 https://github.com/nodejs/node/pull/49059#ref-commit-2ad1bbc
https://github.com/cjihrig
https://github.com/rluvaton
test_runner: reland run global after() hook earlierhttps://github.com/rluvaton/node/commit/2ad1bbc56f5372ee8b39bf4b6453f84aca677254
2ad1bbchttps://github.com/rluvaton/node/commit/2ad1bbc56f5372ee8b39bf4b6453f84aca677254
bb52656https://github.com/rluvaton/node/commit/bb52656fc627e4f48a0f706756873b593d81372a
nodejs#49059 (comment)https://github.com/nodejs/node/pull/49059#issuecomment-1675171959
nodejs#49059https://github.com/nodejs/node/pull/49059
nodejs#49110https://github.com/nodejs/node/pull/49110
nodejs#49116https://github.com/nodejs/node/pull/49116
UlisesGasconhttps://github.com/UlisesGascon
Sep 10, 2023 https://github.com/nodejs/node/pull/49059#ref-commit-546ad5f
https://github.com/cjihrig
https://github.com/UlisesGascon
test_runner: reland run global after() hook earlierhttps://github.com/nodejs/node/commit/546ad5f77082e2eb55eae0d440d973aec6f52b3f
546ad5fhttps://github.com/nodejs/node/commit/546ad5f77082e2eb55eae0d440d973aec6f52b3f
bb52656https://github.com/nodejs/node/commit/bb52656fc627e4f48a0f706756873b593d81372a
#49059 (comment)https://github.com/nodejs/node/pull/49059#issuecomment-1675171959
#49059https://github.com/nodejs/node/pull/49059
#49110https://github.com/nodejs/node/pull/49110
#49116https://github.com/nodejs/node/pull/49116
#49225https://github.com/nodejs/node/pull/49225
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Oct 9, 2023 https://github.com/nodejs/node/pull/49059#ref-pullrequest-1912846720
2023-10-17, Version 21.0.0 (Current) #49870 https://github.com/nodejs/node/pull/49870
targoshttps://github.com/targos
Nov 27, 2023 https://github.com/nodejs/node/pull/49059#ref-commit-d839640
https://github.com/cjihrig
https://github.com/targos
test_runner: reland run global after() hook earlierhttps://github.com/nodejs/node/commit/d83964031b5f9ca9c46c343cc4d65598144b9d75
d839640https://github.com/nodejs/node/commit/d83964031b5f9ca9c46c343cc4d65598144b9d75
bb52656https://github.com/nodejs/node/commit/bb52656fc627e4f48a0f706756873b593d81372a
#49059 (comment)https://github.com/nodejs/node/pull/49059#issuecomment-1675171959
#49059https://github.com/nodejs/node/pull/49059
#49110https://github.com/nodejs/node/pull/49110
#49116https://github.com/nodejs/node/pull/49116
sercherhttps://github.com/sercher
Apr 25, 2024 https://github.com/nodejs/node/pull/49059#ref-commit-7b5134a
https://github.com/sercher
test_runner: reland run global after() hook earlierhttps://github.com/sercher/graaljs/commit/7b5134a278addb68f4e6116489bd18925acccaa8
7b5134ahttps://github.com/sercher/graaljs/commit/7b5134a278addb68f4e6116489bd18925acccaa8
bb52656https://github.com/sercher/graaljs/commit/bb52656fc627e4f48a0f706756873b593d81372a
nodejs/node#49059 (comment)https://github.com/nodejs/node/pull/49059#issuecomment-1675171959
nodejs/node#49059https://github.com/nodejs/node/pull/49059
nodejs/node#49110https://github.com/nodejs/node/pull/49110
nodejs/node#49116https://github.com/nodejs/node/pull/49116
sercherhttps://github.com/sercher
Apr 25, 2024 https://github.com/nodejs/node/pull/49059#ref-commit-b4224c7
https://github.com/sercher
test_runner: reland run global after() hook earlierhttps://github.com/sercher/graaljs/commit/b4224c76fd14a8465659c86f915e4c27a1a5fd50
b4224c7https://github.com/sercher/graaljs/commit/b4224c76fd14a8465659c86f915e4c27a1a5fd50
bb52656https://github.com/sercher/graaljs/commit/bb52656fc627e4f48a0f706756873b593d81372a
nodejs/node#49059 (comment)https://github.com/nodejs/node/pull/49059#issuecomment-1675171959
nodejs/node#49059https://github.com/nodejs/node/pull/49059
nodejs/node#49110https://github.com/nodejs/node/pull/49110
nodejs/node#49116https://github.com/nodejs/node/pull/49116
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F49059
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/49059/files/6346bdc526eddefea72ed32e9ec9755cba3fa706
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/49059/files/6346bdc526eddefea72ed32e9ec9755cba3fa706
https://github.com/MoLow
MoLow https://github.com/MoLow
https://github.com/nodejs/node/pull/49059/files/6346bdc526eddefea72ed32e9ec9755cba3fa706
https://github.com/atlowChemi
atlowChemi https://github.com/atlowChemi
https://github.com/nodejs/node/pull/49059/files/6346bdc526eddefea72ed32e9ec9755cba3fa706
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
dont-land-on-v20.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v20.x
test_runner https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner
test_runner: global after not run if handles are open https://github.com/nodejs/node/issues/49056
Please reload this pagehttps://github.com/nodejs/node/pull/49059
https://github.com/cjihrig
https://github.com/nodejs-github-bot
https://github.com/MoLow
https://github.com/joyeecheung
https://github.com/mcollina
https://github.com/benjamingr
https://github.com/atlowChemi
https://github.com/aduh95
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.