René's URL Explorer Experiment


Title: src: do not pass user input to format string by aduh95 · Pull Request #48973 · nodejs/node · GitHub

Open Graph Title: src: do not pass user input to format string by aduh95 · Pull Request #48973 · nodejs/node

X Title: src: do not pass user input to format string by aduh95 · Pull Request #48973 · nodejs/node

Description: When passing a URL that contains a %, the following assertion is likely to fail: node/src/debug_utils-inl.h Line 70 in 1773b2a ...

Open Graph Description: When passing a URL that contains a %, the following assertion is likely to fail: node/src/debug_utils-inl.h Line 70 in 1773b2a ...

X Description: When passing a URL that contains a %, the following assertion is likely to fail: node/src/debug_utils-inl.h Line 70 in 1773b2a ...

Opengraph URL: https://github.com/nodejs/node/pull/48973

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8896a3d9-f2eb-0a0e-5d5a-d14d1fce1ab1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD942:26A5A1:ACC204:ECA2A7:6969E9E7
html-safe-nonced35709df9b131cb9c555a953b9f34de8952655dadd49530100ec682d65a92ea2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTQyOjI2QTVBMTpBQ0MyMDQ6RUNBMkE3OjY5NjlFOUU3IiwidmlzaXRvcl9pZCI6Ijg1MDkyNjkwMzQ4NjU5MTIyOTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac254025f7073812d6be97db8935ab83ead9914cb2ae119930f3e8c2962937d15a
hovercard-subject-tagpull_request:1455234914
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/48973/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/884aeed62ac88044bacb022fe32bbf284e440d30e0cb7ad222f7fe51fbb8823c/nodejs/node/pull/48973
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/884aeed62ac88044bacb022fe32bbf284e440d30e0cb7ad222f7fe51fbb8823c/nodejs/node/pull/48973
og:image:altWhen passing a URL that contains a %, the following assertion is likely to fail: node/src/debug_utils-inl.h Line 70 in 1773b2a ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaduh95
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/48973#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48973
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48973
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/48973
Reloadhttps://github.com/nodejs/node/pull/48973
Reloadhttps://github.com/nodejs/node/pull/48973
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/48973
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/48973
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/48973#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
aduh95:never-trust-user-inputhttps://github.com/aduh95/node/tree/never-trust-user-input
src: do not pass user input to format string https://github.com/nodejs/node/pull/48973#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
aduh95:never-trust-user-inputhttps://github.com/aduh95/node/tree/never-trust-user-input
Conversation 3 https://github.com/nodejs/node/pull/48973
Commits 3 https://github.com/nodejs/node/pull/48973/commits
Checks 0 https://github.com/nodejs/node/pull/48973/checks
Files changed https://github.com/nodejs/node/pull/48973/files
Please reload this pagehttps://github.com/nodejs/node/pull/48973
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/aduh95
aduh95https://github.com/aduh95
Jul 30, 2023https://github.com/nodejs/node/pull/48973#issue-1828051447
node/src/debug_utils-inl.hhttps://github.com/nodejs/node/blob/1773b2ada4b2b5ce9ad9f526808360fd5faf0282/src/debug_utils-inl.h#L70
1773b2ahttps://github.com/nodejs/node/commit/1773b2ada4b2b5ce9ad9f526808360fd5faf0282
Please reload this pagehttps://github.com/nodejs/node/pull/48973
https://github.com/aduh95
src: do not pass user input to format stringhttps://github.com/nodejs/node/pull/48973/commits/0d75eb76c97d93972ed2ae539668e841fcbca58a
0d75eb7https://github.com/nodejs/node/pull/48973/commits/0d75eb76c97d93972ed2ae539668e841fcbca58a
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jul 30, 2023https://github.com/nodejs/node/pull/48973#event-9957314007
aduh95https://github.com/aduh95
July 30, 2023 22:07https://github.com/nodejs/node/pull/48973#commits-pushed-f08deb3
https://github.com/aduh95
fixup! src: do not pass user input to format stringhttps://github.com/nodejs/node/pull/48973/commits/f08deb393a1c1f8e525a845616d7c6c2babf2327
f08deb3https://github.com/nodejs/node/pull/48973/commits/f08deb393a1c1f8e525a845616d7c6c2babf2327
https://github.com/aduh95
fixup! src: do not pass user input to format stringhttps://github.com/nodejs/node/pull/48973/commits/c617d92216eb940051a728230f93af8905bff63d
c617d92https://github.com/nodejs/node/pull/48973/commits/c617d92216eb940051a728230f93af8905bff63d
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Jul 31, 2023 https://github.com/nodejs/node/pull/48973#pullrequestreview-1554018494
View reviewed changes https://github.com/nodejs/node/pull/48973/files/c617d92216eb940051a728230f93af8905bff63d
https://github.com/debadree25
debadree25https://github.com/debadree25
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 31, 2023https://github.com/nodejs/node/pull/48973#event-9961712260
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 31, 2023https://github.com/nodejs/node/pull/48973#event-9961742207
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 31, 2023https://github.com/nodejs/node/pull/48973#issuecomment-1658044445
https://ci.nodejs.org/job/node-test-pull-request/53016/https://ci.nodejs.org/job/node-test-pull-request/53016/
Please reload this pagehttps://github.com/nodejs/node/pull/48973
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 31, 2023https://github.com/nodejs/node/pull/48973#issuecomment-1658334385
https://ci.nodejs.org/job/node-test-pull-request/53021/https://ci.nodejs.org/job/node-test-pull-request/53021/
Please reload this pagehttps://github.com/nodejs/node/pull/48973
https://github.com/aduh95
aduh95https://github.com/aduh95
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jul 31, 2023https://github.com/nodejs/node/pull/48973#event-9964331604
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jul 31, 2023 https://github.com/nodejs/node/pull/48973#pullrequestreview-1555472606
View reviewed changes https://github.com/nodejs/node/pull/48973/files/c617d92216eb940051a728230f93af8905bff63d
https://github.com/anonrig
anonrighttps://github.com/anonrig
Aug 1, 2023 https://github.com/nodejs/node/pull/48973#pullrequestreview-1555982885
View reviewed changes https://github.com/nodejs/node/pull/48973/files/c617d92216eb940051a728230f93af8905bff63d
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 1, 2023 https://github.com/nodejs/node/pull/48973#ref-issue-1830249092
CI Reliability 2023-08-01 nodejs/reliability#630 https://github.com/nodejs/reliability/issues/630
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 1, 2023 https://github.com/nodejs/node/pull/48973#pullrequestreview-1557678116
View reviewed changes https://github.com/nodejs/node/pull/48973/files/c617d92216eb940051a728230f93af8905bff63d
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 1, 2023https://github.com/nodejs/node/pull/48973#event-9980695241
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
af4cdcdhttps://github.com/nodejs/node/commit/af4cdcde154be58fc47b389670efbe10da489923
Aug 1, 2023https://github.com/nodejs/node/pull/48973#event-9980695902
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 1, 2023https://github.com/nodejs/node/pull/48973#issuecomment-1661003762
af4cdcdhttps://github.com/nodejs/node/commit/af4cdcde154be58fc47b389670efbe10da489923
Please reload this pagehttps://github.com/nodejs/node/pull/48973
https://github.com/aduh95
aduh95https://github.com/aduh95
August 1, 2023 21:08https://github.com/nodejs/node/pull/48973#event-9981183147
CI Reliability 2023-08-02 nodejs/reliability#631 https://github.com/nodejs/reliability/issues/631
CI Reliability 2023-08-03 nodejs/reliability#632 https://github.com/nodejs/reliability/issues/632
CI Reliability 2023-08-04 nodejs/reliability#633 https://github.com/nodejs/reliability/issues/633
plurishttps://github.com/pluris
Aug 6, 2023 https://github.com/nodejs/node/pull/48973#ref-commit-ded01d8
https://github.com/aduh95
src: do not pass user input to format stringhttps://github.com/pluris/node/commit/ded01d8e0b812c52c3717e4534f63f7fbdb67b9d
ded01d8https://github.com/pluris/node/commit/ded01d8e0b812c52c3717e4534f63f7fbdb67b9d
nodejs#48973https://github.com/nodejs/node/pull/48973
plurishttps://github.com/pluris
Aug 7, 2023 https://github.com/nodejs/node/pull/48973#ref-commit-19ba2a9
https://github.com/aduh95
src: do not pass user input to format stringhttps://github.com/pluris/node/commit/19ba2a9a100e40d884e531ffed3d93846d916d43
19ba2a9https://github.com/pluris/node/commit/19ba2a9a100e40d884e531ffed3d93846d916d43
nodejs#48973https://github.com/nodejs/node/pull/48973
Ceres6https://github.com/Ceres6
Aug 14, 2023 https://github.com/nodejs/node/pull/48973#ref-commit-0149e2b
https://github.com/aduh95
https://github.com/Ceres6
src: do not pass user input to format stringhttps://github.com/Ceres6/node/commit/0149e2bf9cf280272a1e470218e5cdd466e0b69f
0149e2bhttps://github.com/Ceres6/node/commit/0149e2bf9cf280272a1e470218e5cdd466e0b69f
nodejs#48973https://github.com/nodejs/node/pull/48973
Ceres6https://github.com/Ceres6
Aug 14, 2023 https://github.com/nodejs/node/pull/48973#ref-commit-3eee719
https://github.com/aduh95
https://github.com/Ceres6
src: do not pass user input to format stringhttps://github.com/Ceres6/node/commit/3eee719e532740e31a3bd75f3b71b624c25db8d3
3eee719https://github.com/Ceres6/node/commit/3eee719e532740e31a3bd75f3b71b624c25db8d3
nodejs#48973https://github.com/nodejs/node/pull/48973
UlisesGasconhttps://github.com/UlisesGascon
Aug 14, 2023 https://github.com/nodejs/node/pull/48973#ref-commit-6b88295
https://github.com/aduh95
https://github.com/UlisesGascon
src: do not pass user input to format stringhttps://github.com/UlisesGascon/node/commit/6b882953a589f96771cc292cf7cf99fe0ba1e07e
6b88295https://github.com/UlisesGascon/node/commit/6b882953a589f96771cc292cf7cf99fe0ba1e07e
nodejs#48973https://github.com/nodejs/node/pull/48973
RafaelGSShttps://github.com/RafaelGSS
Aug 15, 2023 https://github.com/nodejs/node/pull/48973#ref-commit-170a482
https://github.com/aduh95
https://github.com/RafaelGSS
src: do not pass user input to format stringhttps://github.com/nodejs/node/commit/170a482936133bcdc3eb804000d75d7ad590e95d
170a482https://github.com/nodejs/node/commit/170a482936133bcdc3eb804000d75d7ad590e95d
#48973https://github.com/nodejs/node/pull/48973
https://github.com/UlisesGascon
UlisesGasconhttps://github.com/UlisesGascon
Aug 15, 2023 https://github.com/nodejs/node/pull/48973#ref-pullrequest-1851901207
v20.6.0 proposal #49185 https://github.com/nodejs/node/pull/49185
RafaelGSShttps://github.com/RafaelGSS
Aug 15, 2023 https://github.com/nodejs/node/pull/48973#ref-commit-a6cdf09
https://github.com/aduh95
https://github.com/RafaelGSS
src: do not pass user input to format stringhttps://github.com/RafaelGSS/node/commit/a6cdf090a30d90b54bd3e8269251f038178ed25d
a6cdf09https://github.com/RafaelGSS/node/commit/a6cdf090a30d90b54bd3e8269251f038178ed25d
nodejs#48973https://github.com/nodejs/node/pull/48973
RafaelGSShttps://github.com/RafaelGSS
Aug 17, 2023 https://github.com/nodejs/node/pull/48973#ref-commit-7b9adff
https://github.com/aduh95
https://github.com/RafaelGSS
src: do not pass user input to format stringhttps://github.com/nodejs/node/commit/7b9adff0be92f13d72c67152bc3385f2b9bbfc9e
7b9adffhttps://github.com/nodejs/node/commit/7b9adff0be92f13d72c67152bc3385f2b9bbfc9e
#48973https://github.com/nodejs/node/pull/48973
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48973
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/48973/files/c617d92216eb940051a728230f93af8905bff63d
https://github.com/anonrig
anonrig https://github.com/anonrig
https://github.com/nodejs/node/pull/48973/files/c617d92216eb940051a728230f93af8905bff63d
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/48973/files/c617d92216eb940051a728230f93af8905bff63d
https://github.com/RaisinTen
RaisinTen https://github.com/RaisinTen
https://github.com/nodejs/node/pull/48973/files/c617d92216eb940051a728230f93af8905bff63d
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/48973
https://github.com/aduh95
https://github.com/nodejs-github-bot
https://github.com/lpinca
https://github.com/anonrig
https://github.com/tniessen
https://github.com/RaisinTen
https://github.com/debadree25
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.