René's URL Explorer Experiment


Title: test_runner: propagate only to test ancestors by MoLow · Pull Request #48932 · nodejs/node · GitHub

Open Graph Title: test_runner: propagate only to test ancestors by MoLow · Pull Request #48932 · nodejs/node

X Title: test_runner: propagate only to test ancestors by MoLow · Pull Request #48932 · nodejs/node

Description: Fixes: #47945 this PR is broken into smaller commits that are intended to be logically independent and easier to review. some limitations/todos: compare benchmarks (#48931) This only works for a single file. meaning test.only will skip all tests in that file, but not in other files. solving this is much less trivial since it requires some kind of two-way communication between the test file and the parent process, in between the enqueue and the dequeue phases. we should consider if this solution is a big enough improvement compared to the current behavior for it to be released, or if we should solve multiple files as well need to update documentation? need to document deprecation of --run-only add a test for --test-only with multiple files

Open Graph Description: Fixes: #47945 this PR is broken into smaller commits that are intended to be logically independent and easier to review. some limitations/todos: compare benchmarks (#48931) This only works for a...

X Description: Fixes: #47945 this PR is broken into smaller commits that are intended to be logically independent and easier to review. some limitations/todos: compare benchmarks (#48931) This only works for a...

Opengraph URL: https://github.com/nodejs/node/pull/48932

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.114.3

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6f275e4b-d695-a406-0749-9ee9a738263b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDF26:180D24:838BCC:A6904E:6B035D63
html-safe-noncee664bcfaf7e34872f6cc09a2ef0794c7960dababc3513b0a51d7acdb655219d5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjI2OjE4MEQyNDo4MzhCQ0M6QTY5MDRFOjZCMDM1RDYzIiwidmlzaXRvcl9pZCI6IjE5OTE2Nzk5OTE2OTEzMDQyOTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac42d5e37b84a749987053ab4927b82211a060024602cecd7cbaea84aae8c5fe1d
hovercard-subject-tagpull_request:1450883102
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/48932/files
twitter:imagehttps://avatars.githubusercontent.com/u/8221854?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8221854?s=400&v=4
og:image:altFixes: #47945 this PR is broken into smaller commits that are intended to be logically independent and easier to review. some limitations/todos: compare benchmarks (#48931) This only works for a...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/48932/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48932%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48932%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/48932/files
Reloadhttps://github.com/nodejs/node/pull/48932/files
Reloadhttps://github.com/nodejs/node/pull/48932/files
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues639 (639)https://github.com/nodejs/node/issues
Pull requests667 (667)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
MoLowhttps://github.com/MoLow
nodejs:mainhttps://github.com/nodejs/node/tree/main
MoLow:test-runner-onlyhttps://github.com/MoLow/node/tree/test-runner-only
Conversation 13 https://github.com/nodejs/node/pull/48932
Commits 5 https://github.com/nodejs/node/pull/48932/commits
Checks 0 https://github.com/nodejs/node/pull/48932/checks
Files changed https://github.com/nodejs/node/pull/48932/files
Please reload this pagehttps://github.com/nodejs/node/pull/48932/files
test_runner: propagate only to test ancestors https://github.com/nodejs/node/pull/48932/files#top
Show all changes 5 commits https://github.com/nodejs/node/pull/48932/files
378ded5 test_runner: add multiple files benchmark MoLow Aug 3, 2023 https://github.com/nodejs/node/pull/48932/commits/378ded51e8b6edcba456f6625da571604f21b178
cf10097 test_runner: dequeue concurrently MoLow Jul 26, 2023 https://github.com/nodejs/node/pull/48932/commits/cf10097c9dd8127759862cdf3802a991ba3c3104
610e408 test_runner: allways enqueue suite subtests MoLow Jul 26, 2023 https://github.com/nodejs/node/pull/48932/commits/610e4083a425daa24dc48d995b39273071317bf3
a88ec28 test_runner: change root test to be a suite MoLow Jul 26, 2023 https://github.com/nodejs/node/pull/48932/commits/a88ec2877b8a989c7008d07409ae1980556fd332
a08c687 test_runner: propagate only to test ancestors MoLow Jul 26, 2023 https://github.com/nodejs/node/pull/48932/commits/a08c687963b30ed6a3fbed3caa276dfb29519d0b
Clear filters https://github.com/nodejs/node/pull/48932/files
Please reload this pagehttps://github.com/nodejs/node/pull/48932/files
Please reload this pagehttps://github.com/nodejs/node/pull/48932/files
multi-files.js https://github.com/nodejs/node/pull/48932/files#diff-fe7440a7baa3d9d9bfc902ff83c88216793adefe41361b1114c878481fefe12e
suite-tests.js https://github.com/nodejs/node/pull/48932/files#diff-8c510a5bf90014c1e43068739579c52877c5b03067daec2497a532070662ce33
harness.js https://github.com/nodejs/node/pull/48932/files#diff-b05fccdd396676d2cafa05396439532ca4ccf77723384065cca8eaac5dec239c
runner.js https://github.com/nodejs/node/pull/48932/files#diff-840cee72cdda14be90e6c5607ffa844eaf73be966607ddc834cc667bd142fb21
test.js https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb
abort.js https://github.com/nodejs/node/pull/48932/files#diff-fea13091005c3824ade32aa6f84a37f189365a958f27861c271299887ed5246d
abort.snapshot https://github.com/nodejs/node/pull/48932/files#diff-ad34eb6819b676378e42f51465a25669134b948f54de86aa749328dc51f69489
abort_hooks.snapshot https://github.com/nodejs/node/pull/48932/files#diff-bbb02bfc363ed4fe1fa06dd6f73502f8dfff9dda3809527dd100e0b22366bb6e
abort_suite.js https://github.com/nodejs/node/pull/48932/files#diff-9cfa4e710ccccc29db57941bb3dbcb672c4fc406bdbd6ca92efb72be4017961f
abort_suite.snapshot https://github.com/nodejs/node/pull/48932/files#diff-ea75e7f073096151ac86ea3d4f8d4979c611d7c7696c3e6ce040f6c9884eb3f0
default_output.snapshot https://github.com/nodejs/node/pull/48932/files#diff-ad4f81ff654b3240ba7f6429e0d62fa509caaf5cacf0ed9c86a86b576c5b9d4c
describe_it.snapshot https://github.com/nodejs/node/pull/48932/files#diff-a03178f8c2071448c918f33d4c96bd6ad21a0f8ecfacd04d19ad74cc4691f276
global_after_should_fail_the_test.snapshot https://github.com/nodejs/node/pull/48932/files#diff-fc2b2b6b12dbc2b7e02f06e9920230cf2f8325feb32dc6259240d6173d989888
hooks.snapshot https://github.com/nodejs/node/pull/48932/files#diff-3f71e36e825a4d6dc181881e11a94de58d4e4681c34375dc508f1703b0fc218b
only_tests.js https://github.com/nodejs/node/pull/48932/files#diff-4ba45de480ccc253e218050f46c1de3aac1d364b35e96859917e656ebb0a8e21
only_tests.snapshot https://github.com/nodejs/node/pull/48932/files#diff-9292fc9b00bb218d62fd0f47adeebb9ec768fa71abe7c0f3d7962b613791b34a
output.js https://github.com/nodejs/node/pull/48932/files#diff-3897293bce7b65eee2226e6fda4881cb1d89100f1e8dfef3fa9c6909abb1f254
output.snapshot https://github.com/nodejs/node/pull/48932/files#diff-65d1a26816d2cb19fcd1efacf758ee4e2afa6fdd9a6ea88615c31947e9225988
output_cli.snapshot https://github.com/nodejs/node/pull/48932/files#diff-e4cf5d0778007c287c6f764f14c888c0f50a72af5ccc755abf28dfa260deeadf
spec_reporter.snapshot https://github.com/nodejs/node/pull/48932/files#diff-60fb6aa64bd4e1f975ffa0b5a5078aa6efc97762cf6a18b1e7c6c06930ef0d88
spec_reporter_cli.snapshot https://github.com/nodejs/node/pull/48932/files#diff-b3a507e60ce0c8f9421fa5ee9c7c2b11e569d3c074218f253c40ce087f5356b9
timeout_in_before_each_should_not_affect_further_tests.snapshot https://github.com/nodejs/node/pull/48932/files#diff-c15c756c9112cfcc63f22f04db233f3bbd62d0c7f2c1f47783d403cfbbf23b97
benchmark/test_runner/multi-files.jshttps://github.com/nodejs/node/pull/48932/files#diff-fe7440a7baa3d9d9bfc902ff83c88216793adefe41361b1114c878481fefe12e
View file https://github.com/MoLow/node/blob/a08c687963b30ed6a3fbed3caa276dfb29519d0b/benchmark/test_runner/multi-files.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/48932/{{ revealButtonHref }}
Please reload this pagehttps://github.com/nodejs/node/pull/48932/files
benchmark/test_runner/suite-tests.jshttps://github.com/nodejs/node/pull/48932/files#diff-8c510a5bf90014c1e43068739579c52877c5b03067daec2497a532070662ce33
View file https://github.com/MoLow/node/blob/a08c687963b30ed6a3fbed3caa276dfb29519d0b/benchmark/test_runner/suite-tests.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/48932/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/48932/files#diff-8c510a5bf90014c1e43068739579c52877c5b03067daec2497a532070662ce33
https://github.com/nodejs/node/pull/48932/files#diff-8c510a5bf90014c1e43068739579c52877c5b03067daec2497a532070662ce33
https://github.com/nodejs/node/pull/48932/files#diff-8c510a5bf90014c1e43068739579c52877c5b03067daec2497a532070662ce33
lib/internal/test_runner/harness.jshttps://github.com/nodejs/node/pull/48932/files#diff-b05fccdd396676d2cafa05396439532ca4ccf77723384065cca8eaac5dec239c
View file https://github.com/MoLow/node/blob/a08c687963b30ed6a3fbed3caa276dfb29519d0b/lib/internal/test_runner/harness.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/48932/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/48932/files#diff-b05fccdd396676d2cafa05396439532ca4ccf77723384065cca8eaac5dec239c
https://github.com/nodejs/node/pull/48932/files#diff-b05fccdd396676d2cafa05396439532ca4ccf77723384065cca8eaac5dec239c
Please reload this pagehttps://github.com/nodejs/node/pull/48932/files
https://github.com/nodejs/node/pull/48932/files#diff-b05fccdd396676d2cafa05396439532ca4ccf77723384065cca8eaac5dec239c
https://github.com/nodejs/node/pull/48932/files#diff-b05fccdd396676d2cafa05396439532ca4ccf77723384065cca8eaac5dec239c
https://github.com/nodejs/node/pull/48932/files#diff-b05fccdd396676d2cafa05396439532ca4ccf77723384065cca8eaac5dec239c
lib/internal/test_runner/runner.jshttps://github.com/nodejs/node/pull/48932/files#diff-840cee72cdda14be90e6c5607ffa844eaf73be966607ddc834cc667bd142fb21
View file https://github.com/MoLow/node/blob/a08c687963b30ed6a3fbed3caa276dfb29519d0b/lib/internal/test_runner/runner.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/48932/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/48932/files#diff-840cee72cdda14be90e6c5607ffa844eaf73be966607ddc834cc667bd142fb21
https://github.com/nodejs/node/pull/48932/files#diff-840cee72cdda14be90e6c5607ffa844eaf73be966607ddc834cc667bd142fb21
https://github.com/nodejs/node/pull/48932/files#diff-840cee72cdda14be90e6c5607ffa844eaf73be966607ddc834cc667bd142fb21
https://github.com/nodejs/node/pull/48932/files#diff-840cee72cdda14be90e6c5607ffa844eaf73be966607ddc834cc667bd142fb21
https://github.com/nodejs/node/pull/48932/files#diff-840cee72cdda14be90e6c5607ffa844eaf73be966607ddc834cc667bd142fb21
https://github.com/nodejs/node/pull/48932/files#diff-840cee72cdda14be90e6c5607ffa844eaf73be966607ddc834cc667bd142fb21
lib/internal/test_runner/test.jshttps://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb
View file https://github.com/MoLow/node/blob/a08c687963b30ed6a3fbed3caa276dfb29519d0b/lib/internal/test_runner/test.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/48932/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb
https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb
https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb
https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb
https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb
https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb
https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb
https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb
https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb
https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb
https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb
https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb
https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb
https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb
https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb
https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb
https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb
https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb
https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb
https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb
https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb
https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb
https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb
Please reload this pagehttps://github.com/nodejs/node/pull/48932/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.