| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:6f275e4b-d695-a406-0749-9ee9a738263b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DF26:180D24:838BCC:A6904E:6B035D63 |
| html-safe-nonce | e664bcfaf7e34872f6cc09a2ef0794c7960dababc3513b0a51d7acdb655219d5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjI2OjE4MEQyNDo4MzhCQ0M6QTY5MDRFOjZCMDM1RDYzIiwidmlzaXRvcl9pZCI6IjE5OTE2Nzk5OTE2OTEzMDQyOTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 42d5e37b84a749987053ab4927b82211a060024602cecd7cbaea84aae8c5fe1d |
| hovercard-subject-tag | pull_request:1450883102 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/48932/files |
| twitter:image | https://avatars.githubusercontent.com/u/8221854?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/8221854?s=400&v=4 |
| og:image:alt | Fixes: #47945
this PR is broken into smaller commits that are intended to be logically independent and easier to review.
some limitations/todos:
compare benchmarks (#48931)
This only works for a... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/48932/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48932%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48932%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/48932/files |
| Reload | https://github.com/nodejs/node/pull/48932/files |
| Reload | https://github.com/nodejs/node/pull/48932/files |
| nodejs | https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Code | https://github.com/nodejs/node |
| Issues639 (639) | https://github.com/nodejs/node/issues |
| Pull requests667 (667) | https://github.com/nodejs/node/pulls |
| Actions | https://github.com/nodejs/node/actions |
| Projects | https://github.com/nodejs/node/projects |
| Security and quality | https://github.com/nodejs/node/security |
| Insights | https://github.com/nodejs/node/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| MoLow | https://github.com/MoLow |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| MoLow:test-runner-only | https://github.com/MoLow/node/tree/test-runner-only |
|
Conversation
13
| https://github.com/nodejs/node/pull/48932 |
|
Commits
5
| https://github.com/nodejs/node/pull/48932/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/48932/checks |
|
Files changed
| https://github.com/nodejs/node/pull/48932/files |
| Please reload this page | https://github.com/nodejs/node/pull/48932/files |
|
test_runner: propagate only to test ancestors
| https://github.com/nodejs/node/pull/48932/files#top |
|
Show all changes
5 commits
| https://github.com/nodejs/node/pull/48932/files |
|
378ded5
test_runner: add multiple files benchmark
MoLow Aug 3, 2023
| https://github.com/nodejs/node/pull/48932/commits/378ded51e8b6edcba456f6625da571604f21b178 |
|
cf10097
test_runner: dequeue concurrently
MoLow Jul 26, 2023
| https://github.com/nodejs/node/pull/48932/commits/cf10097c9dd8127759862cdf3802a991ba3c3104 |
|
610e408
test_runner: allways enqueue suite subtests
MoLow Jul 26, 2023
| https://github.com/nodejs/node/pull/48932/commits/610e4083a425daa24dc48d995b39273071317bf3 |
|
a88ec28
test_runner: change root test to be a suite
MoLow Jul 26, 2023
| https://github.com/nodejs/node/pull/48932/commits/a88ec2877b8a989c7008d07409ae1980556fd332 |
|
a08c687
test_runner: propagate only to test ancestors
MoLow Jul 26, 2023
| https://github.com/nodejs/node/pull/48932/commits/a08c687963b30ed6a3fbed3caa276dfb29519d0b |
|
Clear filters
| https://github.com/nodejs/node/pull/48932/files |
| Please reload this page | https://github.com/nodejs/node/pull/48932/files |
| Please reload this page | https://github.com/nodejs/node/pull/48932/files |
|
multi-files.js
| https://github.com/nodejs/node/pull/48932/files#diff-fe7440a7baa3d9d9bfc902ff83c88216793adefe41361b1114c878481fefe12e |
|
suite-tests.js
| https://github.com/nodejs/node/pull/48932/files#diff-8c510a5bf90014c1e43068739579c52877c5b03067daec2497a532070662ce33 |
|
harness.js
| https://github.com/nodejs/node/pull/48932/files#diff-b05fccdd396676d2cafa05396439532ca4ccf77723384065cca8eaac5dec239c |
|
runner.js
| https://github.com/nodejs/node/pull/48932/files#diff-840cee72cdda14be90e6c5607ffa844eaf73be966607ddc834cc667bd142fb21 |
|
test.js
| https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb |
|
abort.js
| https://github.com/nodejs/node/pull/48932/files#diff-fea13091005c3824ade32aa6f84a37f189365a958f27861c271299887ed5246d |
|
abort.snapshot
| https://github.com/nodejs/node/pull/48932/files#diff-ad34eb6819b676378e42f51465a25669134b948f54de86aa749328dc51f69489 |
|
abort_hooks.snapshot
| https://github.com/nodejs/node/pull/48932/files#diff-bbb02bfc363ed4fe1fa06dd6f73502f8dfff9dda3809527dd100e0b22366bb6e |
|
abort_suite.js
| https://github.com/nodejs/node/pull/48932/files#diff-9cfa4e710ccccc29db57941bb3dbcb672c4fc406bdbd6ca92efb72be4017961f |
|
abort_suite.snapshot
| https://github.com/nodejs/node/pull/48932/files#diff-ea75e7f073096151ac86ea3d4f8d4979c611d7c7696c3e6ce040f6c9884eb3f0 |
|
default_output.snapshot
| https://github.com/nodejs/node/pull/48932/files#diff-ad4f81ff654b3240ba7f6429e0d62fa509caaf5cacf0ed9c86a86b576c5b9d4c |
|
describe_it.snapshot
| https://github.com/nodejs/node/pull/48932/files#diff-a03178f8c2071448c918f33d4c96bd6ad21a0f8ecfacd04d19ad74cc4691f276 |
|
global_after_should_fail_the_test.snapshot
| https://github.com/nodejs/node/pull/48932/files#diff-fc2b2b6b12dbc2b7e02f06e9920230cf2f8325feb32dc6259240d6173d989888 |
|
hooks.snapshot
| https://github.com/nodejs/node/pull/48932/files#diff-3f71e36e825a4d6dc181881e11a94de58d4e4681c34375dc508f1703b0fc218b |
|
only_tests.js
| https://github.com/nodejs/node/pull/48932/files#diff-4ba45de480ccc253e218050f46c1de3aac1d364b35e96859917e656ebb0a8e21 |
|
only_tests.snapshot
| https://github.com/nodejs/node/pull/48932/files#diff-9292fc9b00bb218d62fd0f47adeebb9ec768fa71abe7c0f3d7962b613791b34a |
|
output.js
| https://github.com/nodejs/node/pull/48932/files#diff-3897293bce7b65eee2226e6fda4881cb1d89100f1e8dfef3fa9c6909abb1f254 |
|
output.snapshot
| https://github.com/nodejs/node/pull/48932/files#diff-65d1a26816d2cb19fcd1efacf758ee4e2afa6fdd9a6ea88615c31947e9225988 |
|
output_cli.snapshot
| https://github.com/nodejs/node/pull/48932/files#diff-e4cf5d0778007c287c6f764f14c888c0f50a72af5ccc755abf28dfa260deeadf |
|
spec_reporter.snapshot
| https://github.com/nodejs/node/pull/48932/files#diff-60fb6aa64bd4e1f975ffa0b5a5078aa6efc97762cf6a18b1e7c6c06930ef0d88 |
|
spec_reporter_cli.snapshot
| https://github.com/nodejs/node/pull/48932/files#diff-b3a507e60ce0c8f9421fa5ee9c7c2b11e569d3c074218f253c40ce087f5356b9 |
|
timeout_in_before_each_should_not_affect_further_tests.snapshot
| https://github.com/nodejs/node/pull/48932/files#diff-c15c756c9112cfcc63f22f04db233f3bbd62d0c7f2c1f47783d403cfbbf23b97 |
| benchmark/test_runner/multi-files.js | https://github.com/nodejs/node/pull/48932/files#diff-fe7440a7baa3d9d9bfc902ff83c88216793adefe41361b1114c878481fefe12e |
|
View file
| https://github.com/MoLow/node/blob/a08c687963b30ed6a3fbed3caa276dfb29519d0b/benchmark/test_runner/multi-files.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/48932/{{ revealButtonHref }} |
| Please reload this page | https://github.com/nodejs/node/pull/48932/files |
| benchmark/test_runner/suite-tests.js | https://github.com/nodejs/node/pull/48932/files#diff-8c510a5bf90014c1e43068739579c52877c5b03067daec2497a532070662ce33 |
|
View file
| https://github.com/MoLow/node/blob/a08c687963b30ed6a3fbed3caa276dfb29519d0b/benchmark/test_runner/suite-tests.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/48932/{{ revealButtonHref }} |
|
| https://github.com/nodejs/node/pull/48932/files#diff-8c510a5bf90014c1e43068739579c52877c5b03067daec2497a532070662ce33 |
|
| https://github.com/nodejs/node/pull/48932/files#diff-8c510a5bf90014c1e43068739579c52877c5b03067daec2497a532070662ce33 |
|
| https://github.com/nodejs/node/pull/48932/files#diff-8c510a5bf90014c1e43068739579c52877c5b03067daec2497a532070662ce33 |
| lib/internal/test_runner/harness.js | https://github.com/nodejs/node/pull/48932/files#diff-b05fccdd396676d2cafa05396439532ca4ccf77723384065cca8eaac5dec239c |
|
View file
| https://github.com/MoLow/node/blob/a08c687963b30ed6a3fbed3caa276dfb29519d0b/lib/internal/test_runner/harness.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/48932/{{ revealButtonHref }} |
|
| https://github.com/nodejs/node/pull/48932/files#diff-b05fccdd396676d2cafa05396439532ca4ccf77723384065cca8eaac5dec239c |
|
| https://github.com/nodejs/node/pull/48932/files#diff-b05fccdd396676d2cafa05396439532ca4ccf77723384065cca8eaac5dec239c |
| Please reload this page | https://github.com/nodejs/node/pull/48932/files |
|
| https://github.com/nodejs/node/pull/48932/files#diff-b05fccdd396676d2cafa05396439532ca4ccf77723384065cca8eaac5dec239c |
|
| https://github.com/nodejs/node/pull/48932/files#diff-b05fccdd396676d2cafa05396439532ca4ccf77723384065cca8eaac5dec239c |
|
| https://github.com/nodejs/node/pull/48932/files#diff-b05fccdd396676d2cafa05396439532ca4ccf77723384065cca8eaac5dec239c |
| lib/internal/test_runner/runner.js | https://github.com/nodejs/node/pull/48932/files#diff-840cee72cdda14be90e6c5607ffa844eaf73be966607ddc834cc667bd142fb21 |
|
View file
| https://github.com/MoLow/node/blob/a08c687963b30ed6a3fbed3caa276dfb29519d0b/lib/internal/test_runner/runner.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/48932/{{ revealButtonHref }} |
|
| https://github.com/nodejs/node/pull/48932/files#diff-840cee72cdda14be90e6c5607ffa844eaf73be966607ddc834cc667bd142fb21 |
|
| https://github.com/nodejs/node/pull/48932/files#diff-840cee72cdda14be90e6c5607ffa844eaf73be966607ddc834cc667bd142fb21 |
|
| https://github.com/nodejs/node/pull/48932/files#diff-840cee72cdda14be90e6c5607ffa844eaf73be966607ddc834cc667bd142fb21 |
|
| https://github.com/nodejs/node/pull/48932/files#diff-840cee72cdda14be90e6c5607ffa844eaf73be966607ddc834cc667bd142fb21 |
|
| https://github.com/nodejs/node/pull/48932/files#diff-840cee72cdda14be90e6c5607ffa844eaf73be966607ddc834cc667bd142fb21 |
|
| https://github.com/nodejs/node/pull/48932/files#diff-840cee72cdda14be90e6c5607ffa844eaf73be966607ddc834cc667bd142fb21 |
| lib/internal/test_runner/test.js | https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb |
|
View file
| https://github.com/MoLow/node/blob/a08c687963b30ed6a3fbed3caa276dfb29519d0b/lib/internal/test_runner/test.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/48932/{{ revealButtonHref }} |
|
| https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb |
|
| https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb |
|
| https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb |
|
| https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb |
|
| https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb |
|
| https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb |
|
| https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb |
|
| https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb |
|
| https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb |
|
| https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb |
|
| https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb |
|
| https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb |
|
| https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb |
|
| https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb |
|
| https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb |
|
| https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb |
|
| https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb |
|
| https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb |
|
| https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb |
|
| https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb |
|
| https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb |
|
| https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb |
|
| https://github.com/nodejs/node/pull/48932/files#diff-42583d1c2fb89ce93a6c2922840a13f8026995468ffe8b0ac8319d1749de6acb |
| Please reload this page | https://github.com/nodejs/node/pull/48932/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |