René's URL Explorer Experiment


Title: test_runner: propagate only to test ancestors by MoLow · Pull Request #48932 · nodejs/node · GitHub

Open Graph Title: test_runner: propagate only to test ancestors by MoLow · Pull Request #48932 · nodejs/node

X Title: test_runner: propagate only to test ancestors by MoLow · Pull Request #48932 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #47945 this PR is broken into smaller commits that are intended to be logically independent and easier to review. some limitations/todos: compare benchmarks (benchmark: add benchmarks for ...

X Description: Fixes: #47945 this PR is broken into smaller commits that are intended to be logically independent and easier to review. some limitations/todos: compare benchmarks (benchmark: add benchmarks for ...

Opengraph URL: https://github.com/nodejs/node/pull/48932

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.114.4

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0375dcba-3818-3e72-65f7-907ee0b4417f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id82AE:DB09F:71917AB:9090DD7:6B0341F5
html-safe-nonce02493aefc1faf253378fc0e1de902f76cc23a8041dfd6db6983d1d6d93d1e356
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MkFFOkRCMDlGOjcxOTE3QUI6OTA5MERENzo2QjAzNDFGNSIsInZpc2l0b3JfaWQiOiI0OTQ1NDkzNzUxODAxMDA0NTMzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac20153bbb204def06d4d472cd4cbcd9ac868ffb91e61e617813c4cd962a395d2e
hovercard-subject-tagpull_request:1450883102
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/48932/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5a9bcadfd52457d747c5489245ae4cdcc9e62fec9427b75eada3fef5c356361f/nodejs/node/pull/48932
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5a9bcadfd52457d747c5489245ae4cdcc9e62fec9427b75eada3fef5c356361f/nodejs/node/pull/48932
og:image:altFixes: #47945 this PR is broken into smaller commits that are intended to be logically independent and easier to review. some limitations/todos: compare benchmarks (benchmark: add benchmarks for ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMoLow
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/48932#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48932
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48932
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/48932
Reloadhttps://github.com/nodejs/node/pull/48932
Reloadhttps://github.com/nodejs/node/pull/48932
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
https://github.com/nodejs/node
MoLowhttps://github.com/MoLow
nodejs:mainhttps://github.com/nodejs/node/tree/main
MoLow:test-runner-onlyhttps://github.com/MoLow/node/tree/test-runner-only
Conversationhttps://github.com/nodejs/node/pull/48932
Commits5 (5)https://github.com/nodejs/node/pull/48932/commits
Checkshttps://github.com/nodejs/node/pull/48932/checks
Files changedhttps://github.com/nodejs/node/pull/48932/files
test_runner: propagate only to test ancestorshttps://github.com/nodejs/node/pull/48932#top
MoLowhttps://github.com/MoLow
nodejs:mainhttps://github.com/nodejs/node/tree/main
MoLow:test-runner-onlyhttps://github.com/MoLow/node/tree/test-runner-only
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Jul 26, 2023https://github.com/nodejs/node/pull/48932#issue-1823108308
Please reload this pagehttps://github.com/nodejs/node/pull/48932
#47945https://github.com/nodejs/node/issues/47945
benchmark: add benchmarks for the test_runner #48931https://github.com/nodejs/node/pull/48931
Please reload this pagehttps://github.com/nodejs/node/pull/48932
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 26, 2023https://github.com/nodejs/node/pull/48932#issuecomment-1652443506
Please reload this pagehttps://github.com/nodejs/node/pull/48932
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test_runner https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner
Jul 26, 2023https://github.com/nodejs/node/pull/48932#event-9928402860
https://github.com/rluvaton
rluvatonhttps://github.com/rluvaton
Jul 26, 2023 https://github.com/nodejs/node/pull/48932#pullrequestreview-1548550040
View reviewed changes https://github.com/nodejs/node/pull/48932/files
lib/internal/test_runner/harness.jshttps://github.com/nodejs/node/pull/48932/files#diff-b05fccdd396676d2cafa05396439532ca4ccf77723384065cca8eaac5dec239c
Please reload this pagehttps://github.com/nodejs/node/pull/48932
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jul 26, 2023https://github.com/nodejs/node/pull/48932#issuecomment-1652502668
#46728https://github.com/nodejs/node/issues/46728
Please reload this pagehttps://github.com/nodejs/node/pull/48932
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Jul 27, 2023https://github.com/nodejs/node/pull/48932#issuecomment-1653024368
Please reload this pagehttps://github.com/nodejs/node/pull/48932
https://github.com/MoLow
MoLowhttps://github.com/MoLow
force-pushedhttps://github.com/nodejs/node/compare/b03a86651225d50ac2841358ad14eb6381890c4c..6d4f6411d631f031002968e8cac78bf27a297dbb
b03a866https://github.com/nodejs/node/commit/b03a86651225d50ac2841358ad14eb6381890c4c
6d4f641https://github.com/nodejs/node/commit/6d4f6411d631f031002968e8cac78bf27a297dbb
Compare https://github.com/nodejs/node/compare/b03a86651225d50ac2841358ad14eb6381890c4c..6d4f6411d631f031002968e8cac78bf27a297dbb
July 28, 2023 05:37https://github.com/nodejs/node/pull/48932#event-9943990852
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Jul 28, 2023https://github.com/nodejs/node/pull/48932#event-9943992777
https://github.com/MoLow
MoLowhttps://github.com/MoLow
force-pushedhttps://github.com/nodejs/node/compare/6d4f6411d631f031002968e8cac78bf27a297dbb..8e6435c2e61ca6bb774b02c05385c6255dff9f5f
6d4f641https://github.com/nodejs/node/commit/6d4f6411d631f031002968e8cac78bf27a297dbb
8e6435chttps://github.com/nodejs/node/commit/8e6435c2e61ca6bb774b02c05385c6255dff9f5f
Compare https://github.com/nodejs/node/compare/6d4f6411d631f031002968e8cac78bf27a297dbb..8e6435c2e61ca6bb774b02c05385c6255dff9f5f
July 28, 2023 05:37https://github.com/nodejs/node/pull/48932#event-9943994435
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Jul 28, 2023https://github.com/nodejs/node/pull/48932#issuecomment-1655052844
@cjihrighttps://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/48932
https://github.com/MoLow
MoLowhttps://github.com/MoLow
force-pushedhttps://github.com/nodejs/node/compare/f71a3eda82a56987f1558ffdd242a4ebc880fcc6..e82455f18358f94c0f133da5f277faa575dc8291
f71a3edhttps://github.com/nodejs/node/commit/f71a3eda82a56987f1558ffdd242a4ebc880fcc6
e82455fhttps://github.com/nodejs/node/commit/e82455f18358f94c0f133da5f277faa575dc8291
Compare https://github.com/nodejs/node/compare/f71a3eda82a56987f1558ffdd242a4ebc880fcc6..e82455f18358f94c0f133da5f277faa575dc8291
August 3, 2023 19:57https://github.com/nodejs/node/pull/48932#event-10002698557
https://github.com/MoLow
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48932
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Aug 3, 2023https://github.com/nodejs/node/pull/48932#issuecomment-1664588938
Please reload this pagehttps://github.com/nodejs/node/pull/48932
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 4, 2023 https://github.com/nodejs/node/pull/48932#ref-issue-1836440244
test_runner: only not working properly in subtests #49015 https://github.com/nodejs/node/issues/49015
https://github.com/MoLow
MoLowhttps://github.com/MoLow
force-pushedhttps://github.com/nodejs/node/compare/d3c285344505e1564b7b73cff7489ac8bb88cbb9..c818aab3521d02d9e4984ef7b4d937baace83a56
d3c2853https://github.com/nodejs/node/commit/d3c285344505e1564b7b73cff7489ac8bb88cbb9
c818aabhttps://github.com/nodejs/node/commit/c818aab3521d02d9e4984ef7b4d937baace83a56
Compare https://github.com/nodejs/node/compare/d3c285344505e1564b7b73cff7489ac8bb88cbb9..c818aab3521d02d9e4984ef7b4d937baace83a56
August 15, 2023 17:42https://github.com/nodejs/node/pull/48932#event-10099711712
https://github.com/rluvaton
rluvatonhttps://github.com/rluvaton
Aug 15, 2023 https://github.com/nodejs/node/pull/48932#pullrequestreview-1579260923
View reviewed changes https://github.com/nodejs/node/pull/48932/files
benchmark/test_runner/multi-files.jshttps://github.com/nodejs/node/pull/48932/files#diff-fe7440a7baa3d9d9bfc902ff83c88216793adefe41361b1114c878481fefe12e
Please reload this pagehttps://github.com/nodejs/node/pull/48932
https://github.com/MoLow
MoLowhttps://github.com/MoLow
force-pushedhttps://github.com/nodejs/node/compare/0e09ada3327c9f1d77d468e16a8c38d209359158..00171812b2c45c1a2c16f06544698fa80a826f8c
0e09adahttps://github.com/nodejs/node/commit/0e09ada3327c9f1d77d468e16a8c38d209359158
0017181https://github.com/nodejs/node/commit/00171812b2c45c1a2c16f06544698fa80a826f8c
Compare https://github.com/nodejs/node/compare/0e09ada3327c9f1d77d468e16a8c38d209359158..00171812b2c45c1a2c16f06544698fa80a826f8c
August 16, 2023 11:38https://github.com/nodejs/node/pull/48932#event-10107357293
MoLowhttps://github.com/MoLow
August 16, 2023 17:37https://github.com/nodejs/node/pull/48932#commits-pushed-378ded5
https://github.com/MoLow
test_runner: add multiple files benchmarkhttps://github.com/nodejs/node/pull/48932/commits/378ded51e8b6edcba456f6625da571604f21b178
378ded5https://github.com/nodejs/node/pull/48932/commits/378ded51e8b6edcba456f6625da571604f21b178
https://github.com/MoLow
test_runner: dequeue concurrentlyhttps://github.com/nodejs/node/pull/48932/commits/cf10097c9dd8127759862cdf3802a991ba3c3104
cf10097https://github.com/nodejs/node/pull/48932/commits/cf10097c9dd8127759862cdf3802a991ba3c3104
https://github.com/MoLow
test_runner: allways enqueue suite subtestshttps://github.com/nodejs/node/pull/48932/commits/610e4083a425daa24dc48d995b39273071317bf3
610e408https://github.com/nodejs/node/pull/48932/commits/610e4083a425daa24dc48d995b39273071317bf3
https://github.com/MoLow
test_runner: change root test to be a suitehttps://github.com/nodejs/node/pull/48932/commits/a88ec2877b8a989c7008d07409ae1980556fd332
a88ec28https://github.com/nodejs/node/pull/48932/commits/a88ec2877b8a989c7008d07409ae1980556fd332
https://github.com/MoLow
test_runner: propagate only to test ancestorshttps://github.com/nodejs/node/pull/48932/commits/a08c687963b30ed6a3fbed3caa276dfb29519d0b
a08c687https://github.com/nodejs/node/pull/48932/commits/a08c687963b30ed6a3fbed3caa276dfb29519d0b
https://github.com/MoLow
MoLowhttps://github.com/MoLow
force-pushedhttps://github.com/nodejs/node/compare/00171812b2c45c1a2c16f06544698fa80a826f8c..a08c687963b30ed6a3fbed3caa276dfb29519d0b
0017181https://github.com/nodejs/node/commit/00171812b2c45c1a2c16f06544698fa80a826f8c
a08c687https://github.com/nodejs/node/commit/a08c687963b30ed6a3fbed3caa276dfb29519d0b
Compare https://github.com/nodejs/node/compare/00171812b2c45c1a2c16f06544698fa80a826f8c..a08c687963b30ed6a3fbed3caa276dfb29519d0b
August 16, 2023 14:37https://github.com/nodejs/node/pull/48932#event-10109390148
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Sep 21, 2023 https://github.com/nodejs/node/pull/48932#ref-pullrequest-1907569479
test_runner: improve enqueue and dequeue #49751 https://github.com/nodejs/node/pull/49751
https://github.com/rluvaton
rluvatonhttps://github.com/rluvaton
Nov 15, 2023 https://github.com/nodejs/node/pull/48932#ref-pullrequest-1989120063
test_runner: fix #50665 .skip, .todo and .only missing in subtests #50673 https://github.com/nodejs/node/pull/50673
https://github.com/bakkot
bakkothttps://github.com/bakkot
Dec 23, 2023 https://github.com/nodejs/node/pull/48932#ref-issue-2054104269
run subtests flagged as only also when parent is not flagged #51261 https://github.com/nodejs/node/issues/51261
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Jan 6, 2024 https://github.com/nodejs/node/pull/48932#ref-issue-2067403781
Some way of not displaying skipped or filtered tests in the spec test reporter #51383 https://github.com/nodejs/node/issues/51383
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Mar 29, 2024https://github.com/nodejs/node/pull/48932#issuecomment-2027268598
@MoLowhttps://github.com/MoLow
Please reload this pagehttps://github.com/nodejs/node/pull/48932
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Mar 31, 2024https://github.com/nodejs/node/pull/48932#issuecomment-2028871685
@MoLowhttps://github.com/MoLow
Please reload this pagehttps://github.com/nodejs/node/pull/48932
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Mar 31, 2024 https://github.com/nodejs/node/pull/48932#ref-pullrequest-2217231032
test_runner: improve describe.only behavior #52296 https://github.com/nodejs/node/pull/52296
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Mar 31, 2024https://github.com/nodejs/node/pull/48932#event-12304986625
https://github.com/MoLow
MoLowhttps://github.com/MoLow
March 31, 2024 22:49https://github.com/nodejs/node/pull/48932#event-12304986737
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Aug 23, 2026 https://github.com/nodejs/node/pull/48932#ref-pullrequest-5225774695
fix(node:test): complete runner parity PerryTS/perry#8638 https://github.com/PerryTS/perry/pull/8638
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48932
https://github.com/rluvaton
rluvaton https://github.com/rluvaton
https://github.com/nodejs/node/pull/48932/files/c818aab3521d02d9e4984ef7b4d937baace83a56
Please reload this pagehttps://github.com/nodejs/node/pull/48932
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test_runner https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner
having --test and --test-only flags increase prototyping time https://github.com/nodejs/node/issues/47945
Please reload this pagehttps://github.com/nodejs/node/pull/48932
https://github.com/MoLow
https://github.com/nodejs-github-bot
https://github.com/cjihrig
https://github.com/rluvaton
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.