| route-pattern | /:user_id/:repository/pull/*id(.:format) |
| route-controller | pull_requests |
| route-action | show |
| fetch-nonce | v2:22bee4a7-5b35-4267-d097-bbe76ac67301 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 917A:13BD30:24C6F8:33BA12:696A008A |
| html-safe-nonce | dbe106a197210f483b6df39c78a80c620adf5f719ce80b954127c1b550c6dd94 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTdBOjEzQkQzMDoyNEM2Rjg6MzNCQTEyOjY5NkEwMDhBIiwidmlzaXRvcl9pZCI6IjQ2MDk0OTY5NDQwODQ2NDgwNzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 33a57d2c5544ef132b55e4a4bcdd757f8ebc7ad9e44f44b61d163a8ffd718c98 |
| hovercard-subject-tag | pull_request:1444936694 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/48879 |
| twitter:image | https://opengraph.githubassets.com/fc3ea7de74aa68e14db2d30394f523b67ae8b0490d19f5a05be49eba01b057eb/nodejs/node/pull/48879 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fc3ea7de74aa68e14db2d30394f523b67ae8b0490d19f5a05be49eba01b057eb/nodejs/node/pull/48879 |
| og:image:alt | Even though the redefinition complies with the C standard because the second definition is "effectively the same" as the first definition, it's best to avoid any redefinition.
The fir... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tniessen |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/48879#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48879 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48879 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/48879 |
| Reload | https://github.com/nodejs/node/pull/48879 |
| Reload | https://github.com/nodejs/node/pull/48879 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/48879 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/48879 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/48879#issue-comment-box |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| tniessen:src-remove-duplicate-macro-node-api | https://github.com/tniessen/node/tree/src-remove-duplicate-macro-node-api |
|
node-api: avoid macro redefinition
| https://github.com/nodejs/node/pull/48879#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| tniessen:src-remove-duplicate-macro-node-api | https://github.com/tniessen/node/tree/src-remove-duplicate-macro-node-api |
|
Conversation
6
| https://github.com/nodejs/node/pull/48879 |
|
Commits
1
| https://github.com/nodejs/node/pull/48879/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/48879/checks |
|
Files changed
| https://github.com/nodejs/node/pull/48879/files |
| Please reload this page | https://github.com/nodejs/node/pull/48879 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Jul 21, 2023 | https://github.com/nodejs/node/pull/48879#issue-1816308813 |
| node/src/js_native_api_v8.h | https://github.com/nodejs/node/blob/b68fa599607f69f2ce3b1a3104e0d5984f6bc0d8/src/js_native_api_v8.h#L183-L189 |
| b68fa59 | https://github.com/nodejs/node/commit/b68fa599607f69f2ce3b1a3104e0d5984f6bc0d8 |
| node/src/js_native_api_v8.h | https://github.com/nodejs/node/blob/b68fa599607f69f2ce3b1a3104e0d5984f6bc0d8/src/js_native_api_v8.h#L271-L277 |
| b68fa59 | https://github.com/nodejs/node/commit/b68fa599607f69f2ce3b1a3104e0d5984f6bc0d8 |
| #28237 | https://github.com/nodejs/node/pull/28237 |
| #30006 | https://github.com/nodejs/node/pull/30006 |
| Please reload this page | https://github.com/nodejs/node/pull/48879 |
|
| https://github.com/tniessen |
| node-api: avoid macro redefinition | https://github.com/nodejs/node/pull/48879/commits/9409def36845fe0d7312a3bcefe512842ca4f1de |
| 9409def | https://github.com/nodejs/node/pull/48879/commits/9409def36845fe0d7312a3bcefe512842ca4f1de |
| nodejs#28237 | https://github.com/nodejs/node/pull/28237 |
| nodejs#30006 | https://github.com/nodejs/node/pull/30006 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 21, 2023 | https://github.com/nodejs/node/pull/48879#issuecomment-1646168211 |
| Please reload this page | https://github.com/nodejs/node/pull/48879 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Jul 21, 2023 | https://github.com/nodejs/node/pull/48879#event-9888454451 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Jul 21, 2023
| https://github.com/nodejs/node/pull/48879#pullrequestreview-1541775506 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/48879/files/9409def36845fe0d7312a3bcefe512842ca4f1de |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/48879#pullrequestreview-1541775506 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/48879 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jul 21, 2023 | https://github.com/nodejs/node/pull/48879#event-9888645611 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jul 21, 2023 | https://github.com/nodejs/node/pull/48879#event-9888685470 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 21, 2023 | https://github.com/nodejs/node/pull/48879#issuecomment-1646204165 |
| https://ci.nodejs.org/job/node-test-pull-request/52897/ | https://ci.nodejs.org/job/node-test-pull-request/52897/ |
| Please reload this page | https://github.com/nodejs/node/pull/48879 |
| https://github.com/vmoroz |
| vmoroz | https://github.com/vmoroz |
|
Jul 21, 2023
| https://github.com/nodejs/node/pull/48879#pullrequestreview-1541821767 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/48879/files/9409def36845fe0d7312a3bcefe512842ca4f1de |
| vmoroz | https://github.com/vmoroz |
| https://github.com/nodejs/node/pull/48879#pullrequestreview-1541821767 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/48879 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Jul 22, 2023
| https://github.com/nodejs/node/pull/48879#ref-issue-1816499756 |
|
CI Reliability 2023-07-22
nodejs/reliability#620
| https://github.com/nodejs/reliability/issues/620 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jul 22, 2023
| https://github.com/nodejs/node/pull/48879#pullrequestreview-1542108628 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/48879/files/9409def36845fe0d7312a3bcefe512842ca4f1de |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 22, 2023 | https://github.com/nodejs/node/pull/48879#issuecomment-1646623911 |
| https://ci.nodejs.org/job/node-test-pull-request/52902/ | https://ci.nodejs.org/job/node-test-pull-request/52902/ |
| Please reload this page | https://github.com/nodejs/node/pull/48879 |
| https://github.com/debadree25 |
| debadree25 | https://github.com/debadree25 |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Jul 22, 2023 | https://github.com/nodejs/node/pull/48879#event-9891527343 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Jul 23, 2023
| https://github.com/nodejs/node/pull/48879#ref-issue-1816933443 |
|
CI Reliability 2023-07-23
nodejs/reliability#621
| https://github.com/nodejs/reliability/issues/621 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Jul 23, 2023 | https://github.com/nodejs/node/pull/48879#event-9893498509 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| 1ceb8c1 | https://github.com/nodejs/node/commit/1ceb8c113d5ecc1b3fa3bec280d050bc10d09f91 |
| Jul 23, 2023 | https://github.com/nodejs/node/pull/48879#event-9893498613 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 23, 2023 | https://github.com/nodejs/node/pull/48879#issuecomment-1646945346 |
| 1ceb8c1 | https://github.com/nodejs/node/commit/1ceb8c113d5ecc1b3fa3bec280d050bc10d09f91 |
| Please reload this page | https://github.com/nodejs/node/pull/48879 |
|
CI Reliability 2023-07-24
nodejs/reliability#622
| https://github.com/nodejs/reliability/issues/622 |
|
CI Reliability 2023-07-25
nodejs/reliability#623
| https://github.com/nodejs/reliability/issues/623 |
|
CI Reliability 2023-07-26
nodejs/reliability#624
| https://github.com/nodejs/reliability/issues/624 |
|
CI Reliability 2023-07-27
nodejs/reliability#625
| https://github.com/nodejs/reliability/issues/625 |
| Ceres6 | https://github.com/Ceres6 |
|
Jul 27, 2023
| https://github.com/nodejs/node/pull/48879#ref-commit-cb9f39a |
|
| https://github.com/tniessen |
|
| https://github.com/Ceres6 |
| node-api: avoid macro redefinition | https://github.com/Ceres6/node/commit/cb9f39a7e36bf170a9b85f7a92427bc6ec55d760 |
| cb9f39a | https://github.com/Ceres6/node/commit/cb9f39a7e36bf170a9b85f7a92427bc6ec55d760 |
| nodejs#28237 | https://github.com/nodejs/node/pull/28237 |
| nodejs#30006 | https://github.com/nodejs/node/pull/30006 |
| nodejs#48879 | https://github.com/nodejs/node/pull/48879 |
|
CI Reliability 2023-07-28
nodejs/reliability#626
| https://github.com/nodejs/reliability/issues/626 |
|
CI Reliability 2023-07-29
nodejs/reliability#627
| https://github.com/nodejs/reliability/issues/627 |
|
CI Reliability 2023-07-30
nodejs/reliability#628
| https://github.com/nodejs/reliability/issues/628 |
| pluris | https://github.com/pluris |
|
Aug 6, 2023
| https://github.com/nodejs/node/pull/48879#ref-commit-6f0085b |
|
| https://github.com/tniessen |
| node-api: avoid macro redefinition | https://github.com/pluris/node/commit/6f0085be20f32a7844cea1ca321744b9bfe67708 |
| 6f0085b | https://github.com/pluris/node/commit/6f0085be20f32a7844cea1ca321744b9bfe67708 |
| nodejs#28237 | https://github.com/nodejs/node/pull/28237 |
| nodejs#30006 | https://github.com/nodejs/node/pull/30006 |
| nodejs#48879 | https://github.com/nodejs/node/pull/48879 |
| pluris | https://github.com/pluris |
|
Aug 7, 2023
| https://github.com/nodejs/node/pull/48879#ref-commit-fbd169f |
|
| https://github.com/tniessen |
| node-api: avoid macro redefinition | https://github.com/pluris/node/commit/fbd169f4f8ea59e4677374a5663a22ff703d4485 |
| fbd169f | https://github.com/pluris/node/commit/fbd169f4f8ea59e4677374a5663a22ff703d4485 |
| nodejs#28237 | https://github.com/nodejs/node/pull/28237 |
| nodejs#30006 | https://github.com/nodejs/node/pull/30006 |
| nodejs#48879 | https://github.com/nodejs/node/pull/48879 |
| Ceres6 | https://github.com/Ceres6 |
|
Aug 14, 2023
| https://github.com/nodejs/node/pull/48879#ref-commit-b43a9cd |
|
| https://github.com/tniessen |
|
| https://github.com/Ceres6 |
| node-api: avoid macro redefinition | https://github.com/Ceres6/node/commit/b43a9cda596816f3c5c8690b6467cd3295e951b8 |
| b43a9cd | https://github.com/Ceres6/node/commit/b43a9cda596816f3c5c8690b6467cd3295e951b8 |
| nodejs#28237 | https://github.com/nodejs/node/pull/28237 |
| nodejs#30006 | https://github.com/nodejs/node/pull/30006 |
| nodejs#48879 | https://github.com/nodejs/node/pull/48879 |
| Ceres6 | https://github.com/Ceres6 |
|
Aug 14, 2023
| https://github.com/nodejs/node/pull/48879#ref-commit-6c7467c |
|
| https://github.com/tniessen |
|
| https://github.com/Ceres6 |
| node-api: avoid macro redefinition | https://github.com/Ceres6/node/commit/6c7467c96adfedbb802d0b7e2e86182e3a4602f4 |
| 6c7467c | https://github.com/Ceres6/node/commit/6c7467c96adfedbb802d0b7e2e86182e3a4602f4 |
| nodejs#28237 | https://github.com/nodejs/node/pull/28237 |
| nodejs#30006 | https://github.com/nodejs/node/pull/30006 |
| nodejs#48879 | https://github.com/nodejs/node/pull/48879 |
| UlisesGascon | https://github.com/UlisesGascon |
|
Aug 14, 2023
| https://github.com/nodejs/node/pull/48879#ref-commit-4c1e1ff |
|
| https://github.com/tniessen |
|
| https://github.com/UlisesGascon |
| node-api: avoid macro redefinition | https://github.com/UlisesGascon/node/commit/4c1e1ff0d4a072049a71fd24715ef4ebf9510beb |
| 4c1e1ff | https://github.com/UlisesGascon/node/commit/4c1e1ff0d4a072049a71fd24715ef4ebf9510beb |
| nodejs#28237 | https://github.com/nodejs/node/pull/28237 |
| nodejs#30006 | https://github.com/nodejs/node/pull/30006 |
| nodejs#48879 | https://github.com/nodejs/node/pull/48879 |
| RafaelGSS | https://github.com/RafaelGSS |
|
Aug 15, 2023
| https://github.com/nodejs/node/pull/48879#ref-commit-015c4f7 |
|
| https://github.com/tniessen |
|
| https://github.com/RafaelGSS |
| node-api: avoid macro redefinition | https://github.com/nodejs/node/commit/015c4f788d67a36ecb27fe698aa2d0e618a46db9 |
| 015c4f7 | https://github.com/nodejs/node/commit/015c4f788d67a36ecb27fe698aa2d0e618a46db9 |
| #28237 | https://github.com/nodejs/node/pull/28237 |
| #30006 | https://github.com/nodejs/node/pull/30006 |
| #48879 | https://github.com/nodejs/node/pull/48879 |
| https://github.com/UlisesGascon |
| UlisesGascon | https://github.com/UlisesGascon |
|
Aug 15, 2023
| https://github.com/nodejs/node/pull/48879#ref-pullrequest-1851901207 |
|
v20.6.0 proposal
#49185
| https://github.com/nodejs/node/pull/49185 |
| targos | https://github.com/targos |
|
Nov 27, 2023
| https://github.com/nodejs/node/pull/48879#ref-commit-5796631 |
|
| https://github.com/tniessen |
|
| https://github.com/targos |
| node-api: avoid macro redefinition | https://github.com/nodejs/node/commit/57966318fe7352d1cec1d1fa29ca307d849e8ea5 |
| 5796631 | https://github.com/nodejs/node/commit/57966318fe7352d1cec1d1fa29ca307d849e8ea5 |
| #28237 | https://github.com/nodejs/node/pull/28237 |
| #30006 | https://github.com/nodejs/node/pull/30006 |
| #48879 | https://github.com/nodejs/node/pull/48879 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Nov 28, 2023
| https://github.com/nodejs/node/pull/48879#ref-pullrequest-2014162105 |
|
v18.19.0 release proposal
#50953
| https://github.com/nodejs/node/pull/50953 |
| sercher | https://github.com/sercher |
|
Apr 25, 2024
| https://github.com/nodejs/node/pull/48879#ref-commit-935c497 |
|
| https://github.com/sercher |
| node-api: avoid macro redefinition | https://github.com/sercher/graaljs/commit/935c497161a0f167a59278531220c5144ea12666 |
| 935c497 | https://github.com/sercher/graaljs/commit/935c497161a0f167a59278531220c5144ea12666 |
| nodejs/node#28237 | https://github.com/nodejs/node/pull/28237 |
| nodejs/node#30006 | https://github.com/nodejs/node/pull/30006 |
| nodejs/node#48879 | https://github.com/nodejs/node/pull/48879 |
| sercher | https://github.com/sercher |
|
Apr 25, 2024
| https://github.com/nodejs/node/pull/48879#ref-commit-36f0e74 |
|
| https://github.com/sercher |
| node-api: avoid macro redefinition | https://github.com/sercher/graaljs/commit/36f0e74be17cc2613f7ef5bc5b56cfee3aee4532 |
| 36f0e74 | https://github.com/sercher/graaljs/commit/36f0e74be17cc2613f7ef5bc5b56cfee3aee4532 |
| nodejs/node#28237 | https://github.com/nodejs/node/pull/28237 |
| nodejs/node#30006 | https://github.com/nodejs/node/pull/30006 |
| nodejs/node#48879 | https://github.com/nodejs/node/pull/48879 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48879 |
|
| https://github.com/vmoroz |
|
vmoroz
| https://github.com/vmoroz |
|
| https://github.com/nodejs/node/pull/48879/files/9409def36845fe0d7312a3bcefe512842ca4f1de |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/48879/files/9409def36845fe0d7312a3bcefe512842ca4f1de |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/48879/files/9409def36845fe0d7312a3bcefe512842ca4f1de |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Please reload this page | https://github.com/nodejs/node/pull/48879 |
|
| https://github.com/tniessen |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/vmoroz |
|
| https://github.com/lpinca |
|
| https://github.com/mhdawson |
|
| https://github.com/debadree25 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |