| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1bd224b0-ae66-f7e9-d5f7-9e171a755a44 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E23A:291671:6D201:95F10:6969D16C |
| html-safe-nonce | fda32b293be1ca802a450c0e4b3fb7188c83d570c53918e07b703168aabd4b3d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjNBOjI5MTY3MTo2RDIwMTo5NUYxMDo2OTY5RDE2QyIsInZpc2l0b3JfaWQiOiIyNzgwNjgxMjM3ODc5NzA1OTY0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 5f7dbf69a8b0524d23ac3607f646e12f3acaff154536f653bf0fd157dda175db |
| hovercard-subject-tag | pull_request:1444787183 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/48878/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9aacb8acc9f90643e502054b9c329885f6da8c6fae476ccc510d30d8738a6a2e/nodejs/node/pull/48878 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9aacb8acc9f90643e502054b9c329885f6da8c6fae476ccc510d30d8738a6a2e/nodejs/node/pull/48878 |
| og:image:alt | Add missing test for url's with commas for url.parse and removes unnecessary parameter to toASCII
Ref: #48873
Ref: #48855
Ref: #48850
cc @nodejs/url @aduh95 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | anonrig |
| hostname | github.com |
| expected-hostname | github.com |
| None | acedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 83c08c21cdda978090dc44364b71aa5bc6dcea79 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/48878#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48878 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48878 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/48878 |
| Reload | https://github.com/nodejs/node/pull/48878 |
| Reload | https://github.com/nodejs/node/pull/48878 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/48878 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/48878 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/48878#issue-comment-box |
| anonrig | https://github.com/anonrig |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| anonrig:validate-url-parse-commas | https://github.com/anonrig/node/tree/validate-url-parse-commas |
|
test: validate host with commas on url.parse
| https://github.com/nodejs/node/pull/48878#top |
| anonrig | https://github.com/anonrig |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| anonrig:validate-url-parse-commas | https://github.com/anonrig/node/tree/validate-url-parse-commas |
|
Conversation
9
| https://github.com/nodejs/node/pull/48878 |
|
Commits
2
| https://github.com/nodejs/node/pull/48878/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/48878/checks |
|
Files changed
| https://github.com/nodejs/node/pull/48878/files |
| Please reload this page | https://github.com/nodejs/node/pull/48878 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| Jul 21, 2023 | https://github.com/nodejs/node/pull/48878#issue-1816140113 |
| Please reload this page | https://github.com/nodejs/node/pull/48878 |
| #48873 | https://github.com/nodejs/node/pull/48873 |
| #48855 | https://github.com/nodejs/node/issues/48855 |
| #48850 | https://github.com/nodejs/node/issues/48850 |
| @aduh95 | https://github.com/aduh95 |
| Please reload this page | https://github.com/nodejs/node/pull/48878 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 21, 2023 | https://github.com/nodejs/node/pull/48878#issuecomment-1646019812 |
| Please reload this page | https://github.com/nodejs/node/pull/48878 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
url
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aurl |
| Jul 21, 2023 | https://github.com/nodejs/node/pull/48878#event-9887449365 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
commit-queue-rebase
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-rebase |
| Jul 21, 2023 | https://github.com/nodejs/node/pull/48878#event-9887453090 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| aduh95 | https://github.com/aduh95 |
| lpinca | https://github.com/lpinca |
| July 21, 2023 17:26 | https://github.com/nodejs/node/pull/48878#event-9887484209 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jul 21, 2023
| https://github.com/nodejs/node/pull/48878#pullrequestreview-1541550333 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/48878/files |
| test/parallel/test-url-parse-format.js | https://github.com/nodejs/node/pull/48878/files#diff-9a2ff8dbab024dd7a2270cc6cc06170dbce2b4146b7ce31c9fdc432eed1c0fe3 |
| Please reload this page | https://github.com/nodejs/node/pull/48878 |
| anonrig | https://github.com/anonrig |
| July 21, 2023 14:36 | https://github.com/nodejs/node/pull/48878#commits-pushed-3fe0729 |
|
| https://github.com/anonrig |
| test: validate host with commas on url.parse | https://github.com/nodejs/node/pull/48878/commits/3fe07291b7ee992f7bd76aa18058f9fc0c90b4bd |
| 3fe0729 | https://github.com/nodejs/node/pull/48878/commits/3fe07291b7ee992f7bd76aa18058f9fc0c90b4bd |
|
| https://github.com/anonrig |
| lib: remove invalid parameter to toASCII | https://github.com/nodejs/node/pull/48878/commits/faafb4fcff009518f14654128b9dfbb0686bac24 |
| faafb4f | https://github.com/nodejs/node/pull/48878/commits/faafb4fcff009518f14654128b9dfbb0686bac24 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| force-pushed | https://github.com/nodejs/node/compare/c44e16f98a7272c02381dc2858701efa1d2fc4fc..faafb4fcff009518f14654128b9dfbb0686bac24 |
| c44e16f | https://github.com/nodejs/node/commit/c44e16f98a7272c02381dc2858701efa1d2fc4fc |
| faafb4f | https://github.com/nodejs/node/commit/faafb4fcff009518f14654128b9dfbb0686bac24 |
|
Compare
| https://github.com/nodejs/node/compare/c44e16f98a7272c02381dc2858701efa1d2fc4fc..faafb4fcff009518f14654128b9dfbb0686bac24 |
| July 21, 2023 18:36 | https://github.com/nodejs/node/pull/48878#event-9887984743 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jul 21, 2023 | https://github.com/nodejs/node/pull/48878#event-9887988912 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Jul 21, 2023 | https://github.com/nodejs/node/pull/48878#issuecomment-1646098368 |
| @anonrig | https://github.com/anonrig |
| Please reload this page | https://github.com/nodejs/node/pull/48878 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| lpinca | https://github.com/lpinca |
| July 21, 2023 18:38 | https://github.com/nodejs/node/pull/48878#event-9888000396 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jul 21, 2023 | https://github.com/nodejs/node/pull/48878#event-9888013654 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Jul 21, 2023
| https://github.com/nodejs/node/pull/48878#pullrequestreview-1541648871 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/48878/files/faafb4fcff009518f14654128b9dfbb0686bac24 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 21, 2023 | https://github.com/nodejs/node/pull/48878#issuecomment-1646102332 |
| https://ci.nodejs.org/job/node-test-pull-request/52894/ | https://ci.nodejs.org/job/node-test-pull-request/52894/ |
| Please reload this page | https://github.com/nodejs/node/pull/48878 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jul 21, 2023
| https://github.com/nodejs/node/pull/48878#pullrequestreview-1541649307 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/48878/files/faafb4fcff009518f14654128b9dfbb0686bac24 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jul 21, 2023
| https://github.com/nodejs/node/pull/48878#pullrequestreview-1541718130 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/48878/files/faafb4fcff009518f14654128b9dfbb0686bac24 |
| aduh95 | https://github.com/aduh95 |
| https://github.com/nodejs/node/pull/48878#pullrequestreview-1541718130 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/48878 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| Jul 21, 2023 | https://github.com/nodejs/node/pull/48878#issuecomment-1646155970 |
| Please reload this page | https://github.com/nodejs/node/pull/48878 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 21, 2023 | https://github.com/nodejs/node/pull/48878#issuecomment-1646256725 |
| https://ci.nodejs.org/job/node-test-pull-request/52898/ | https://ci.nodejs.org/job/node-test-pull-request/52898/ |
| Please reload this page | https://github.com/nodejs/node/pull/48878 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Jul 22, 2023
| https://github.com/nodejs/node/pull/48878#ref-issue-1816499756 |
|
CI Reliability 2023-07-22
nodejs/reliability#620
| https://github.com/nodejs/reliability/issues/620 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Jul 22, 2023 | https://github.com/nodejs/node/pull/48878#event-9889687089 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Jul 22, 2023 | https://github.com/nodejs/node/pull/48878#event-9889706419 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 22, 2023 | https://github.com/nodejs/node/pull/48878#issuecomment-1646362462 |
| b68fa59...9dd574c | https://github.com/nodejs/node/compare/b68fa599607f69f2ce3b1a3104e0d5984f6bc0d8...9dd574c9e232515aa894795b8a2522f53024b6f7 |
| Please reload this page | https://github.com/nodejs/node/pull/48878 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 22, 2023 | https://github.com/nodejs/node/pull/48878#event-9889706766 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Jul 22, 2023
| https://github.com/nodejs/node/pull/48878#ref-commit-f4863fa |
|
| https://github.com/anonrig |
|
| https://github.com/nodejs-github-bot |
| test: validate host with commas on url.parse | https://github.com/nodejs/node/commit/f4863fa8e0accf2f82f4c10f4e435d8b7d572942 |
| f4863fa | https://github.com/nodejs/node/commit/f4863fa8e0accf2f82f4c10f4e435d8b7d572942 |
| #48878 | https://github.com/nodejs/node/pull/48878 |
| #48873 | https://github.com/nodejs/node/pull/48873 |
| #48855 | https://github.com/nodejs/node/issues/48855 |
| #48850 | https://github.com/nodejs/node/issues/48850 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Jul 22, 2023
| https://github.com/nodejs/node/pull/48878#ref-commit-9dd574c |
|
| https://github.com/anonrig |
|
| https://github.com/nodejs-github-bot |
| lib: remove invalid parameter to toASCII | https://github.com/nodejs/node/commit/9dd574c9e232515aa894795b8a2522f53024b6f7 |
| 9dd574c | https://github.com/nodejs/node/commit/9dd574c9e232515aa894795b8a2522f53024b6f7 |
| #48878 | https://github.com/nodejs/node/pull/48878 |
| #48873 | https://github.com/nodejs/node/pull/48873 |
| #48855 | https://github.com/nodejs/node/issues/48855 |
| #48850 | https://github.com/nodejs/node/issues/48850 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Jul 22, 2023
| https://github.com/nodejs/node/pull/48878#ref-pullrequest-1815996688 |
|
[v18.x backport] src: replace idna functions with ada::idna
#48873
| https://github.com/nodejs/node/pull/48873 |
| anonrig | https://github.com/anonrig |
|
Jul 22, 2023
| https://github.com/nodejs/node/pull/48878#ref-commit-a0edb33 |
|
| https://github.com/anonrig |
| test: validate host with commas on url.parse | https://github.com/anonrig/node/commit/a0edb337d28808929d39fb7fe649a9eead7ad2af |
| a0edb33 | https://github.com/anonrig/node/commit/a0edb337d28808929d39fb7fe649a9eead7ad2af |
| nodejs#48878 | https://github.com/nodejs/node/pull/48878 |
| nodejs#48873 | https://github.com/nodejs/node/pull/48873 |
| nodejs#48855 | https://github.com/nodejs/node/issues/48855 |
| nodejs#48850 | https://github.com/nodejs/node/issues/48850 |
| anonrig | https://github.com/anonrig |
|
Jul 22, 2023
| https://github.com/nodejs/node/pull/48878#ref-commit-60f1bb5 |
|
| https://github.com/anonrig |
| lib: remove invalid parameter to toASCII | https://github.com/anonrig/node/commit/60f1bb5291fba48f7df4ac2e945cc41903581d50 |
| 60f1bb5 | https://github.com/anonrig/node/commit/60f1bb5291fba48f7df4ac2e945cc41903581d50 |
| nodejs#48878 | https://github.com/nodejs/node/pull/48878 |
| nodejs#48873 | https://github.com/nodejs/node/pull/48873 |
| nodejs#48855 | https://github.com/nodejs/node/issues/48855 |
| nodejs#48850 | https://github.com/nodejs/node/issues/48850 |
|
CI Reliability 2023-07-23
nodejs/reliability#621
| https://github.com/nodejs/reliability/issues/621 |
|
CI Reliability 2023-07-24
nodejs/reliability#622
| https://github.com/nodejs/reliability/issues/622 |
|
CI Reliability 2023-07-25
nodejs/reliability#623
| https://github.com/nodejs/reliability/issues/623 |
|
CI Reliability 2023-07-26
nodejs/reliability#624
| https://github.com/nodejs/reliability/issues/624 |
|
CI Reliability 2023-07-27
nodejs/reliability#625
| https://github.com/nodejs/reliability/issues/625 |
| Ceres6 | https://github.com/Ceres6 |
|
Jul 27, 2023
| https://github.com/nodejs/node/pull/48878#ref-commit-932d92e |
|
| https://github.com/anonrig |
|
| https://github.com/Ceres6 |
| test: validate host with commas on url.parse | https://github.com/Ceres6/node/commit/932d92ecdead01d93ffb8e46febfd0e2fd20730b |
| 932d92e | https://github.com/Ceres6/node/commit/932d92ecdead01d93ffb8e46febfd0e2fd20730b |
| nodejs#48878 | https://github.com/nodejs/node/pull/48878 |
| nodejs#48873 | https://github.com/nodejs/node/pull/48873 |
| nodejs#48855 | https://github.com/nodejs/node/issues/48855 |
| nodejs#48850 | https://github.com/nodejs/node/issues/48850 |
| Ceres6 | https://github.com/Ceres6 |
|
Jul 27, 2023
| https://github.com/nodejs/node/pull/48878#ref-commit-9923dd9 |
|
| https://github.com/anonrig |
|
| https://github.com/Ceres6 |
| lib: remove invalid parameter to toASCII | https://github.com/Ceres6/node/commit/9923dd9761115fff719d5c8001f59f99189a2186 |
| 9923dd9 | https://github.com/Ceres6/node/commit/9923dd9761115fff719d5c8001f59f99189a2186 |
| nodejs#48878 | https://github.com/nodejs/node/pull/48878 |
| nodejs#48873 | https://github.com/nodejs/node/pull/48873 |
| nodejs#48855 | https://github.com/nodejs/node/issues/48855 |
| nodejs#48850 | https://github.com/nodejs/node/issues/48850 |
|
CI Reliability 2023-07-28
nodejs/reliability#626
| https://github.com/nodejs/reliability/issues/626 |
|
CI Reliability 2023-07-29
nodejs/reliability#627
| https://github.com/nodejs/reliability/issues/627 |
|
CI Reliability 2023-07-30
nodejs/reliability#628
| https://github.com/nodejs/reliability/issues/628 |
| pluris | https://github.com/pluris |
|
Aug 6, 2023
| https://github.com/nodejs/node/pull/48878#ref-commit-f1d25bc |
|
| https://github.com/anonrig |
| test: validate host with commas on url.parse | https://github.com/pluris/node/commit/f1d25bc109953a5e5c26af10b9a517095f53428c |
| f1d25bc | https://github.com/pluris/node/commit/f1d25bc109953a5e5c26af10b9a517095f53428c |
| nodejs#48878 | https://github.com/nodejs/node/pull/48878 |
| nodejs#48873 | https://github.com/nodejs/node/pull/48873 |
| nodejs#48855 | https://github.com/nodejs/node/issues/48855 |
| nodejs#48850 | https://github.com/nodejs/node/issues/48850 |
| pluris | https://github.com/pluris |
|
Aug 6, 2023
| https://github.com/nodejs/node/pull/48878#ref-commit-c40e40a |
|
| https://github.com/anonrig |
| lib: remove invalid parameter to toASCII | https://github.com/pluris/node/commit/c40e40a45e39d7abd448934fef452d586b70d866 |
| c40e40a | https://github.com/pluris/node/commit/c40e40a45e39d7abd448934fef452d586b70d866 |
| nodejs#48878 | https://github.com/nodejs/node/pull/48878 |
| nodejs#48873 | https://github.com/nodejs/node/pull/48873 |
| nodejs#48855 | https://github.com/nodejs/node/issues/48855 |
| nodejs#48850 | https://github.com/nodejs/node/issues/48850 |
| pluris | https://github.com/pluris |
|
Aug 7, 2023
| https://github.com/nodejs/node/pull/48878#ref-commit-24e9fb4 |
|
| https://github.com/anonrig |
| test: validate host with commas on url.parse | https://github.com/pluris/node/commit/24e9fb4d569ca0edf965053ddd80ddea404b674e |
| 24e9fb4 | https://github.com/pluris/node/commit/24e9fb4d569ca0edf965053ddd80ddea404b674e |
| nodejs#48878 | https://github.com/nodejs/node/pull/48878 |
| nodejs#48873 | https://github.com/nodejs/node/pull/48873 |
| nodejs#48855 | https://github.com/nodejs/node/issues/48855 |
| nodejs#48850 | https://github.com/nodejs/node/issues/48850 |
| pluris | https://github.com/pluris |
|
Aug 7, 2023
| https://github.com/nodejs/node/pull/48878#ref-commit-161ff90 |
|
| https://github.com/anonrig |
| lib: remove invalid parameter to toASCII | https://github.com/pluris/node/commit/161ff90f6bec32cc2749db9728df16d17cc2dceb |
| 161ff90 | https://github.com/pluris/node/commit/161ff90f6bec32cc2749db9728df16d17cc2dceb |
| nodejs#48878 | https://github.com/nodejs/node/pull/48878 |
| nodejs#48873 | https://github.com/nodejs/node/pull/48873 |
| nodejs#48855 | https://github.com/nodejs/node/issues/48855 |
| nodejs#48850 | https://github.com/nodejs/node/issues/48850 |
| Ceres6 | https://github.com/Ceres6 |
|
Aug 14, 2023
| https://github.com/nodejs/node/pull/48878#ref-commit-ba96a46 |
|
| https://github.com/anonrig |
|
| https://github.com/Ceres6 |
| test: validate host with commas on url.parse | https://github.com/Ceres6/node/commit/ba96a4646a4b70256688a07ad74047073740261e |
| ba96a46 | https://github.com/Ceres6/node/commit/ba96a4646a4b70256688a07ad74047073740261e |
| nodejs#48878 | https://github.com/nodejs/node/pull/48878 |
| nodejs#48873 | https://github.com/nodejs/node/pull/48873 |
| nodejs#48855 | https://github.com/nodejs/node/issues/48855 |
| nodejs#48850 | https://github.com/nodejs/node/issues/48850 |
| Ceres6 | https://github.com/Ceres6 |
|
Aug 14, 2023
| https://github.com/nodejs/node/pull/48878#ref-commit-c433de3 |
|
| https://github.com/anonrig |
|
| https://github.com/Ceres6 |
| lib: remove invalid parameter to toASCII | https://github.com/Ceres6/node/commit/c433de3577be2c0cd1a8b5bee5cc780978cdb571 |
| c433de3 | https://github.com/Ceres6/node/commit/c433de3577be2c0cd1a8b5bee5cc780978cdb571 |
| nodejs#48878 | https://github.com/nodejs/node/pull/48878 |
| nodejs#48873 | https://github.com/nodejs/node/pull/48873 |
| nodejs#48855 | https://github.com/nodejs/node/issues/48855 |
| nodejs#48850 | https://github.com/nodejs/node/issues/48850 |
| Ceres6 | https://github.com/Ceres6 |
|
Aug 14, 2023
| https://github.com/nodejs/node/pull/48878#ref-commit-6c0c565 |
|
| https://github.com/anonrig |
|
| https://github.com/Ceres6 |
| test: validate host with commas on url.parse | https://github.com/Ceres6/node/commit/6c0c565725b0b694e556f367c4c779276a16a6ac |
| 6c0c565 | https://github.com/Ceres6/node/commit/6c0c565725b0b694e556f367c4c779276a16a6ac |
| nodejs#48878 | https://github.com/nodejs/node/pull/48878 |
| nodejs#48873 | https://github.com/nodejs/node/pull/48873 |
| nodejs#48855 | https://github.com/nodejs/node/issues/48855 |
| nodejs#48850 | https://github.com/nodejs/node/issues/48850 |
| Ceres6 | https://github.com/Ceres6 |
|
Aug 14, 2023
| https://github.com/nodejs/node/pull/48878#ref-commit-bb7ffa8 |
|
| https://github.com/anonrig |
|
| https://github.com/Ceres6 |
| lib: remove invalid parameter to toASCII | https://github.com/Ceres6/node/commit/bb7ffa8275800723bce1d28769f1ab193de2e587 |
| bb7ffa8 | https://github.com/Ceres6/node/commit/bb7ffa8275800723bce1d28769f1ab193de2e587 |
| nodejs#48878 | https://github.com/nodejs/node/pull/48878 |
| nodejs#48873 | https://github.com/nodejs/node/pull/48873 |
| nodejs#48855 | https://github.com/nodejs/node/issues/48855 |
| nodejs#48850 | https://github.com/nodejs/node/issues/48850 |
| UlisesGascon | https://github.com/UlisesGascon |
|
Aug 14, 2023
| https://github.com/nodejs/node/pull/48878#ref-commit-17a1be6 |
|
| https://github.com/anonrig |
|
| https://github.com/UlisesGascon |
| test: validate host with commas on url.parse | https://github.com/UlisesGascon/node/commit/17a1be6585a7c65bc50167a98f831ac51bb5d54f |
| 17a1be6 | https://github.com/UlisesGascon/node/commit/17a1be6585a7c65bc50167a98f831ac51bb5d54f |
| nodejs#48878 | https://github.com/nodejs/node/pull/48878 |
| nodejs#48873 | https://github.com/nodejs/node/pull/48873 |
| nodejs#48855 | https://github.com/nodejs/node/issues/48855 |
| nodejs#48850 | https://github.com/nodejs/node/issues/48850 |
| UlisesGascon | https://github.com/UlisesGascon |
|
Aug 14, 2023
| https://github.com/nodejs/node/pull/48878#ref-commit-5affce3 |
|
| https://github.com/anonrig |
|
| https://github.com/UlisesGascon |
| lib: remove invalid parameter to toASCII | https://github.com/UlisesGascon/node/commit/5affce344e367133c6800605c5ad8e33b9af4ac7 |
| 5affce3 | https://github.com/UlisesGascon/node/commit/5affce344e367133c6800605c5ad8e33b9af4ac7 |
| nodejs#48878 | https://github.com/nodejs/node/pull/48878 |
| nodejs#48873 | https://github.com/nodejs/node/pull/48873 |
| nodejs#48855 | https://github.com/nodejs/node/issues/48855 |
| nodejs#48850 | https://github.com/nodejs/node/issues/48850 |
| RafaelGSS | https://github.com/RafaelGSS |
|
Aug 15, 2023
| https://github.com/nodejs/node/pull/48878#ref-commit-3680a66 |
|
| https://github.com/anonrig |
|
| https://github.com/RafaelGSS |
| test: validate host with commas on url.parse | https://github.com/nodejs/node/commit/3680a66df430ba2f2b60763f06439e3b5a781233 |
| 3680a66 | https://github.com/nodejs/node/commit/3680a66df430ba2f2b60763f06439e3b5a781233 |
| #48878 | https://github.com/nodejs/node/pull/48878 |
| #48873 | https://github.com/nodejs/node/pull/48873 |
| #48855 | https://github.com/nodejs/node/issues/48855 |
| #48850 | https://github.com/nodejs/node/issues/48850 |
| RafaelGSS | https://github.com/RafaelGSS |
|
Aug 15, 2023
| https://github.com/nodejs/node/pull/48878#ref-commit-420b85c |
|
| https://github.com/anonrig |
|
| https://github.com/RafaelGSS |
| lib: remove invalid parameter to toASCII | https://github.com/nodejs/node/commit/420b85c00f1732151bce913b077f65a653531472 |
| 420b85c | https://github.com/nodejs/node/commit/420b85c00f1732151bce913b077f65a653531472 |
| #48878 | https://github.com/nodejs/node/pull/48878 |
| #48873 | https://github.com/nodejs/node/pull/48873 |
| #48855 | https://github.com/nodejs/node/issues/48855 |
| #48850 | https://github.com/nodejs/node/issues/48850 |
| https://github.com/UlisesGascon |
| UlisesGascon | https://github.com/UlisesGascon |
|
Aug 15, 2023
| https://github.com/nodejs/node/pull/48878#ref-pullrequest-1851901207 |
|
v20.6.0 proposal
#49185
| https://github.com/nodejs/node/pull/49185 |
| ruyadorno | https://github.com/ruyadorno |
|
Aug 16, 2023
| https://github.com/nodejs/node/pull/48878#ref-commit-2de9868 |
|
| https://github.com/anonrig |
|
| https://github.com/ruyadorno |
| test: validate host with commas on url.parse | https://github.com/nodejs/node/commit/2de98682927c1d0d95ef8ce8a5b42d42032f66f7 |
| 2de9868 | https://github.com/nodejs/node/commit/2de98682927c1d0d95ef8ce8a5b42d42032f66f7 |
| #48878 | https://github.com/nodejs/node/pull/48878 |
| #48873 | https://github.com/nodejs/node/pull/48873 |
| #48873 | https://github.com/nodejs/node/pull/48873 |
| #48855 | https://github.com/nodejs/node/issues/48855 |
| #48850 | https://github.com/nodejs/node/issues/48850 |
| ruyadorno | https://github.com/ruyadorno |
|
Aug 16, 2023
| https://github.com/nodejs/node/pull/48878#ref-commit-69aaf8b |
|
| https://github.com/anonrig |
|
| https://github.com/ruyadorno |
| lib: remove invalid parameter to toASCII | https://github.com/nodejs/node/commit/69aaf8b1d10ad861a94833b99fe302a8b3cc8242 |
| 69aaf8b | https://github.com/nodejs/node/commit/69aaf8b1d10ad861a94833b99fe302a8b3cc8242 |
| #48878 | https://github.com/nodejs/node/pull/48878 |
| #48873 | https://github.com/nodejs/node/pull/48873 |
| #48873 | https://github.com/nodejs/node/pull/48873 |
| #48855 | https://github.com/nodejs/node/issues/48855 |
| #48850 | https://github.com/nodejs/node/issues/48850 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
|
backported-to-v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v18.x |
| Aug 16, 2023 | https://github.com/nodejs/node/pull/48878#event-10102696407 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
|
Aug 17, 2023
| https://github.com/nodejs/node/pull/48878#ref-pullrequest-1855772061 |
|
v18.18.0 proposal
#49220
| https://github.com/nodejs/node/pull/49220 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48878 |
|
| https://github.com/benjamingr |
|
benjamingr
| https://github.com/benjamingr |
|
| https://github.com/nodejs/node/pull/48878/files/faafb4fcff009518f14654128b9dfbb0686bac24 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/48878/files/faafb4fcff009518f14654128b9dfbb0686bac24 |
|
| https://github.com/aduh95 |
|
aduh95
| https://github.com/aduh95 |
|
| https://github.com/nodejs/node/pull/48878/files/faafb4fcff009518f14654128b9dfbb0686bac24 |
|
commit-queue-rebase
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-rebase |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
url
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aurl |
| Please reload this page | https://github.com/nodejs/node/pull/48878 |
|
| https://github.com/anonrig |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/benjamingr |
|
| https://github.com/lpinca |
|
| https://github.com/aduh95 |
|
| https://github.com/ruyadorno |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |