René's URL Explorer Experiment


Title: [v18.x backport] src: replace idna functions with ada::idna by anonrig · Pull Request #48873 · nodejs/node · GitHub

Open Graph Title: [v18.x backport] src: replace idna functions with ada::idna by anonrig · Pull Request #48873 · nodejs/node

X Title: [v18.x backport] src: replace idna functions with ada::idna by anonrig · Pull Request #48873 · nodejs/node

Description: This PR includes a slightly modified backport which moves the function declarations to node_url.cc instead of encoding_binding.cc where Node.js v18 does not have. I've also added a new test to vali...

Open Graph Description: This PR includes a slightly modified backport which moves the function declarations to node_url.cc instead of encoding_binding.cc where Node.js v18 does not have. I've also added a new test to ...

X Description: This PR includes a slightly modified backport which moves the function declarations to node_url.cc instead of encoding_binding.cc where Node.js v18 does not have. I've also added a new test...

Opengraph URL: https://github.com/nodejs/node/pull/48873

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:248c23e3-895f-15dc-7a02-1f631b714bc7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id877A:1478A3:929013:CEB661:696A180A
html-safe-nonce983d4da3b6e354fa86643a62756a815efdc99cb7dece6fa2377cddf77b0f7572
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NzdBOjE0NzhBMzo5MjkwMTM6Q0VCNjYxOjY5NkExODBBIiwidmlzaXRvcl9pZCI6IjM0OTUwOTkzMzMzMjI4NzI4NDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacebaaabda92f3288e06d41944f28a507a024561e3ddd0c29f2c991af690dfc5ec
hovercard-subject-tagpull_request:1444660238
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/48873/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/922f166924eb7170213a6a0dda045a62a0ba84b6b8064ac515cdd1ddb40eb369/nodejs/node/pull/48873
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/922f166924eb7170213a6a0dda045a62a0ba84b6b8064ac515cdd1ddb40eb369/nodejs/node/pull/48873
og:image:altThis PR includes a slightly modified backport which moves the function declarations to node_url.cc instead of encoding_binding.cc where Node.js v18 does not have. I've also added a new test to ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameanonrig
hostnamegithub.com
expected-hostnamegithub.com
None34a52bd10bd674f68e5c1b6b74413b79bf2ca20c551055ace3f7cdd112803923
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee8bd37502700f365b18a4d39acf7cb7947e11b1a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/48873#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48873
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48873
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/48873
Reloadhttps://github.com/nodejs/node/pull/48873
Reloadhttps://github.com/nodejs/node/pull/48873
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/48873
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 698 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/48873
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/48873#issue-comment-box
anonrighttps://github.com/anonrig
nodejs:v18.x-staginghttps://github.com/nodejs/node/tree/v18.x-staging
anonrig:backport-47735https://github.com/anonrig/node/tree/backport-47735
[v18.x backport] src: replace idna functions with ada::idna https://github.com/nodejs/node/pull/48873#top
anonrighttps://github.com/anonrig
nodejs:v18.x-staginghttps://github.com/nodejs/node/tree/v18.x-staging
anonrig:backport-47735https://github.com/anonrig/node/tree/backport-47735
Conversation 13 https://github.com/nodejs/node/pull/48873
Commits 3 https://github.com/nodejs/node/pull/48873/commits
Checks 0 https://github.com/nodejs/node/pull/48873/checks
Files changed https://github.com/nodejs/node/pull/48873/files
Please reload this pagehttps://github.com/nodejs/node/pull/48873
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jul 21, 2023https://github.com/nodejs/node/pull/48873#issue-1815996688
Please reload this pagehttps://github.com/nodejs/node/pull/48873
#47735https://github.com/nodejs/node/pull/47735
#48878https://github.com/nodejs/node/pull/48878
#48855https://github.com/nodejs/node/issues/48855
#48850https://github.com/nodejs/node/issues/48850
Please reload this pagehttps://github.com/nodejs/node/pull/48873
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 21, 2023https://github.com/nodejs/node/pull/48873#issuecomment-1645758617
Please reload this pagehttps://github.com/nodejs/node/pull/48873
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
v18.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av18.x
Jul 21, 2023https://github.com/nodejs/node/pull/48873#event-9886536872
https://github.com/anonrig
anonrighttps://github.com/anonrig
aduh95https://github.com/aduh95
richardlauhttps://github.com/richardlau
July 21, 2023 15:26https://github.com/nodejs/node/pull/48873#event-9886551400
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jul 21, 2023 https://github.com/nodejs/node/pull/48873#ref-pullrequest-1815713579
[v18.x] Revert "url: drop ICU requirement for parsing hostnames" #48869 https://github.com/nodejs/node/pull/48869
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jul 21, 2023 https://github.com/nodejs/node/pull/48873#pullrequestreview-1541387576
View reviewed changes https://github.com/nodejs/node/pull/48873/files
https://github.com/lpinca
lpincahttps://github.com/lpinca
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 21, 2023https://github.com/nodejs/node/pull/48873#event-9886646596
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 21, 2023https://github.com/nodejs/node/pull/48873#event-9886701182
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 21, 2023https://github.com/nodejs/node/pull/48873#issuecomment-1645783409
https://ci.nodejs.org/job/node-test-pull-request/52889/https://ci.nodejs.org/job/node-test-pull-request/52889/
Please reload this pagehttps://github.com/nodejs/node/pull/48873
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jul 21, 2023https://github.com/nodejs/node/pull/48873#issuecomment-1645793511
Please reload this pagehttps://github.com/nodejs/node/pull/48873
#47735https://github.com/nodejs/node/pull/47735
Please reload this pagehttps://github.com/nodejs/node/pull/48873
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jul 21, 2023https://github.com/nodejs/node/pull/48873#issuecomment-1645795801
@lpincahttps://github.com/lpinca
Please reload this pagehttps://github.com/nodejs/node/pull/48873
https://github.com/aduh95
aduh95https://github.com/aduh95
Jul 21, 2023https://github.com/nodejs/node/pull/48873#event-9886799912
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jul 21, 2023https://github.com/nodejs/node/pull/48873#issuecomment-1645797947
Please reload this pagehttps://github.com/nodejs/node/pull/48873
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jul 21, 2023https://github.com/nodejs/node/pull/48873#issuecomment-1645800053
Please reload this pagehttps://github.com/nodejs/node/pull/48873
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jul 21, 2023https://github.com/nodejs/node/pull/48873#issuecomment-1645803360
Please reload this pagehttps://github.com/nodejs/node/pull/48873
https://github.com/aduh95
aduh95https://github.com/aduh95
Jul 21, 2023https://github.com/nodejs/node/pull/48873#issuecomment-1645804771
@lpincahttps://github.com/lpinca
Please reload this pagehttps://github.com/nodejs/node/pull/48873
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jul 21, 2023https://github.com/nodejs/node/pull/48873#issuecomment-1645806774
@lpincahttps://github.com/lpinca
Please reload this pagehttps://github.com/nodejs/node/pull/48873
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Jul 21, 2023 https://github.com/nodejs/node/pull/48873#pullrequestreview-1541530923
View reviewed changes https://github.com/nodejs/node/pull/48873/files
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jul 21, 2023 https://github.com/nodejs/node/pull/48873#ref-pullrequest-1816140113
test: validate host with commas on url.parse #48878 https://github.com/nodejs/node/pull/48878
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 22, 2023 https://github.com/nodejs/node/pull/48873#ref-commit-f4863fa
https://github.com/anonrig
https://github.com/nodejs-github-bot
test: validate host with commas on url.parsehttps://github.com/nodejs/node/commit/f4863fa8e0accf2f82f4c10f4e435d8b7d572942
f4863fahttps://github.com/nodejs/node/commit/f4863fa8e0accf2f82f4c10f4e435d8b7d572942
#48878https://github.com/nodejs/node/pull/48878
#48873https://github.com/nodejs/node/pull/48873
#48855https://github.com/nodejs/node/issues/48855
#48850https://github.com/nodejs/node/issues/48850
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 22, 2023 https://github.com/nodejs/node/pull/48873#ref-commit-9dd574c
https://github.com/anonrig
https://github.com/nodejs-github-bot
lib: remove invalid parameter to toASCIIhttps://github.com/nodejs/node/commit/9dd574c9e232515aa894795b8a2522f53024b6f7
9dd574chttps://github.com/nodejs/node/commit/9dd574c9e232515aa894795b8a2522f53024b6f7
#48878https://github.com/nodejs/node/pull/48878
#48873https://github.com/nodejs/node/pull/48873
#48855https://github.com/nodejs/node/issues/48855
#48850https://github.com/nodejs/node/issues/48850
anonrighttps://github.com/anonrig
July 21, 2023 21:34https://github.com/nodejs/node/pull/48873#commits-pushed-6c602b3
https://github.com/anonrig
https://github.com/lemire
src: replace idna functions with ada::idnahttps://github.com/nodejs/node/pull/48873/commits/6c602b3c095e217f94bca88dd2074a92802453a9
6c602b3https://github.com/nodejs/node/pull/48873/commits/6c602b3c095e217f94bca88dd2074a92802453a9
nodejs#47735https://github.com/nodejs/node/pull/47735
https://github.com/anonrig
test: validate host with commas on url.parsehttps://github.com/nodejs/node/pull/48873/commits/a0edb337d28808929d39fb7fe649a9eead7ad2af
a0edb33https://github.com/nodejs/node/pull/48873/commits/a0edb337d28808929d39fb7fe649a9eead7ad2af
nodejs#48878https://github.com/nodejs/node/pull/48878
nodejs#48873https://github.com/nodejs/node/pull/48873
nodejs#48855https://github.com/nodejs/node/issues/48855
nodejs#48850https://github.com/nodejs/node/issues/48850
https://github.com/anonrig
lib: remove invalid parameter to toASCIIhttps://github.com/nodejs/node/pull/48873/commits/60f1bb5291fba48f7df4ac2e945cc41903581d50
60f1bb5https://github.com/nodejs/node/pull/48873/commits/60f1bb5291fba48f7df4ac2e945cc41903581d50
nodejs#48878https://github.com/nodejs/node/pull/48878
nodejs#48873https://github.com/nodejs/node/pull/48873
nodejs#48855https://github.com/nodejs/node/issues/48855
nodejs#48850https://github.com/nodejs/node/issues/48850
https://github.com/anonrig
anonrighttps://github.com/anonrig
force-pushedhttps://github.com/nodejs/node/compare/17649f76b7d6a12a2dc5e0294c0575174598a313..60f1bb5291fba48f7df4ac2e945cc41903581d50
17649f7https://github.com/nodejs/node/commit/17649f76b7d6a12a2dc5e0294c0575174598a313
60f1bb5https://github.com/nodejs/node/commit/60f1bb5291fba48f7df4ac2e945cc41903581d50
Compare https://github.com/nodejs/node/compare/17649f76b7d6a12a2dc5e0294c0575174598a313..60f1bb5291fba48f7df4ac2e945cc41903581d50
July 22, 2023 01:35https://github.com/nodejs/node/pull/48873#event-9889771029
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jul 22, 2023https://github.com/nodejs/node/pull/48873#issuecomment-1646372140
@lpincahttps://github.com/lpinca
@aduh95https://github.com/aduh95
Please reload this pagehttps://github.com/nodejs/node/pull/48873
https://github.com/anonrig
anonrighttps://github.com/anonrig
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 22, 2023https://github.com/nodejs/node/pull/48873#event-9889798564
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 22, 2023https://github.com/nodejs/node/pull/48873#event-9889801402
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 22, 2023https://github.com/nodejs/node/pull/48873#issuecomment-1646377385
https://ci.nodejs.org/job/node-test-pull-request/52899/https://ci.nodejs.org/job/node-test-pull-request/52899/
Please reload this pagehttps://github.com/nodejs/node/pull/48873
https://github.com/aduh95
aduh95https://github.com/aduh95
Jul 22, 2023https://github.com/nodejs/node/pull/48873#issuecomment-1646523114
Please reload this pagehttps://github.com/nodejs/node/pull/48873
Ceres6https://github.com/Ceres6
Jul 27, 2023 https://github.com/nodejs/node/pull/48873#ref-commit-932d92e
https://github.com/anonrig
https://github.com/Ceres6
test: validate host with commas on url.parsehttps://github.com/Ceres6/node/commit/932d92ecdead01d93ffb8e46febfd0e2fd20730b
932d92ehttps://github.com/Ceres6/node/commit/932d92ecdead01d93ffb8e46febfd0e2fd20730b
nodejs#48878https://github.com/nodejs/node/pull/48878
nodejs#48873https://github.com/nodejs/node/pull/48873
nodejs#48855https://github.com/nodejs/node/issues/48855
nodejs#48850https://github.com/nodejs/node/issues/48850
Ceres6https://github.com/Ceres6
Jul 27, 2023 https://github.com/nodejs/node/pull/48873#ref-commit-9923dd9
https://github.com/anonrig
https://github.com/Ceres6
lib: remove invalid parameter to toASCIIhttps://github.com/Ceres6/node/commit/9923dd9761115fff719d5c8001f59f99189a2186
9923dd9https://github.com/Ceres6/node/commit/9923dd9761115fff719d5c8001f59f99189a2186
nodejs#48878https://github.com/nodejs/node/pull/48878
nodejs#48873https://github.com/nodejs/node/pull/48873
nodejs#48855https://github.com/nodejs/node/issues/48855
nodejs#48850https://github.com/nodejs/node/issues/48850
https://github.com/anonrig
anonrighttps://github.com/anonrig
Aug 2, 2023 https://github.com/nodejs/node/pull/48873#ref-issue-1814578231
yarn 1.x.x invalid url with node 18.17.0 VS 18.16.1 #48855 https://github.com/nodejs/node/issues/48855
plurishttps://github.com/pluris
Aug 6, 2023 https://github.com/nodejs/node/pull/48873#ref-commit-f1d25bc
https://github.com/anonrig
test: validate host with commas on url.parsehttps://github.com/pluris/node/commit/f1d25bc109953a5e5c26af10b9a517095f53428c
f1d25bchttps://github.com/pluris/node/commit/f1d25bc109953a5e5c26af10b9a517095f53428c
nodejs#48878https://github.com/nodejs/node/pull/48878
nodejs#48873https://github.com/nodejs/node/pull/48873
nodejs#48855https://github.com/nodejs/node/issues/48855
nodejs#48850https://github.com/nodejs/node/issues/48850
plurishttps://github.com/pluris
Aug 6, 2023 https://github.com/nodejs/node/pull/48873#ref-commit-c40e40a
https://github.com/anonrig
lib: remove invalid parameter to toASCIIhttps://github.com/pluris/node/commit/c40e40a45e39d7abd448934fef452d586b70d866
c40e40ahttps://github.com/pluris/node/commit/c40e40a45e39d7abd448934fef452d586b70d866
nodejs#48878https://github.com/nodejs/node/pull/48878
nodejs#48873https://github.com/nodejs/node/pull/48873
nodejs#48855https://github.com/nodejs/node/issues/48855
nodejs#48850https://github.com/nodejs/node/issues/48850
plurishttps://github.com/pluris
Aug 7, 2023 https://github.com/nodejs/node/pull/48873#ref-commit-24e9fb4
https://github.com/anonrig
test: validate host with commas on url.parsehttps://github.com/pluris/node/commit/24e9fb4d569ca0edf965053ddd80ddea404b674e
24e9fb4https://github.com/pluris/node/commit/24e9fb4d569ca0edf965053ddd80ddea404b674e
nodejs#48878https://github.com/nodejs/node/pull/48878
nodejs#48873https://github.com/nodejs/node/pull/48873
nodejs#48855https://github.com/nodejs/node/issues/48855
nodejs#48850https://github.com/nodejs/node/issues/48850
plurishttps://github.com/pluris
Aug 7, 2023 https://github.com/nodejs/node/pull/48873#ref-commit-161ff90
https://github.com/anonrig
lib: remove invalid parameter to toASCIIhttps://github.com/pluris/node/commit/161ff90f6bec32cc2749db9728df16d17cc2dceb
161ff90https://github.com/pluris/node/commit/161ff90f6bec32cc2749db9728df16d17cc2dceb
nodejs#48878https://github.com/nodejs/node/pull/48878
nodejs#48873https://github.com/nodejs/node/pull/48873
nodejs#48855https://github.com/nodejs/node/issues/48855
nodejs#48850https://github.com/nodejs/node/issues/48850
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 10, 2023 https://github.com/nodejs/node/pull/48873#ref-issue-1837678756
"URL.parse()" works differently in diff versions of Nodejs #49024 https://github.com/nodejs/node/issues/49024
https://github.com/styfle
styflehttps://github.com/styfle
Aug 14, 2023 https://github.com/nodejs/node/pull/48873#ref-pullrequest-1850135785
Test with latest node@18 vercel/next.js#54000 https://github.com/vercel/next.js/pull/54000
Ceres6https://github.com/Ceres6
Aug 14, 2023 https://github.com/nodejs/node/pull/48873#ref-commit-ba96a46
https://github.com/anonrig
https://github.com/Ceres6
test: validate host with commas on url.parsehttps://github.com/Ceres6/node/commit/ba96a4646a4b70256688a07ad74047073740261e
ba96a46https://github.com/Ceres6/node/commit/ba96a4646a4b70256688a07ad74047073740261e
nodejs#48878https://github.com/nodejs/node/pull/48878
nodejs#48873https://github.com/nodejs/node/pull/48873
nodejs#48855https://github.com/nodejs/node/issues/48855
nodejs#48850https://github.com/nodejs/node/issues/48850
Ceres6https://github.com/Ceres6
Aug 14, 2023 https://github.com/nodejs/node/pull/48873#ref-commit-c433de3
https://github.com/anonrig
https://github.com/Ceres6
lib: remove invalid parameter to toASCIIhttps://github.com/Ceres6/node/commit/c433de3577be2c0cd1a8b5bee5cc780978cdb571
c433de3https://github.com/Ceres6/node/commit/c433de3577be2c0cd1a8b5bee5cc780978cdb571
nodejs#48878https://github.com/nodejs/node/pull/48878
nodejs#48873https://github.com/nodejs/node/pull/48873
nodejs#48855https://github.com/nodejs/node/issues/48855
nodejs#48850https://github.com/nodejs/node/issues/48850
Ceres6https://github.com/Ceres6
Aug 14, 2023 https://github.com/nodejs/node/pull/48873#ref-commit-6c0c565
https://github.com/anonrig
https://github.com/Ceres6
test: validate host with commas on url.parsehttps://github.com/Ceres6/node/commit/6c0c565725b0b694e556f367c4c779276a16a6ac
6c0c565https://github.com/Ceres6/node/commit/6c0c565725b0b694e556f367c4c779276a16a6ac
nodejs#48878https://github.com/nodejs/node/pull/48878
nodejs#48873https://github.com/nodejs/node/pull/48873
nodejs#48855https://github.com/nodejs/node/issues/48855
nodejs#48850https://github.com/nodejs/node/issues/48850
Ceres6https://github.com/Ceres6
Aug 14, 2023 https://github.com/nodejs/node/pull/48873#ref-commit-bb7ffa8
https://github.com/anonrig
https://github.com/Ceres6
lib: remove invalid parameter to toASCIIhttps://github.com/Ceres6/node/commit/bb7ffa8275800723bce1d28769f1ab193de2e587
bb7ffa8https://github.com/Ceres6/node/commit/bb7ffa8275800723bce1d28769f1ab193de2e587
nodejs#48878https://github.com/nodejs/node/pull/48878
nodejs#48873https://github.com/nodejs/node/pull/48873
nodejs#48855https://github.com/nodejs/node/issues/48855
nodejs#48850https://github.com/nodejs/node/issues/48850
UlisesGasconhttps://github.com/UlisesGascon
Aug 14, 2023 https://github.com/nodejs/node/pull/48873#ref-commit-17a1be6
https://github.com/anonrig
https://github.com/UlisesGascon
test: validate host with commas on url.parsehttps://github.com/UlisesGascon/node/commit/17a1be6585a7c65bc50167a98f831ac51bb5d54f
17a1be6https://github.com/UlisesGascon/node/commit/17a1be6585a7c65bc50167a98f831ac51bb5d54f
nodejs#48878https://github.com/nodejs/node/pull/48878
nodejs#48873https://github.com/nodejs/node/pull/48873
nodejs#48855https://github.com/nodejs/node/issues/48855
nodejs#48850https://github.com/nodejs/node/issues/48850
UlisesGasconhttps://github.com/UlisesGascon
Aug 14, 2023 https://github.com/nodejs/node/pull/48873#ref-commit-5affce3
https://github.com/anonrig
https://github.com/UlisesGascon
lib: remove invalid parameter to toASCIIhttps://github.com/UlisesGascon/node/commit/5affce344e367133c6800605c5ad8e33b9af4ac7
5affce3https://github.com/UlisesGascon/node/commit/5affce344e367133c6800605c5ad8e33b9af4ac7
nodejs#48878https://github.com/nodejs/node/pull/48878
nodejs#48873https://github.com/nodejs/node/pull/48873
nodejs#48855https://github.com/nodejs/node/issues/48855
nodejs#48850https://github.com/nodejs/node/issues/48850
RafaelGSShttps://github.com/RafaelGSS
Aug 15, 2023 https://github.com/nodejs/node/pull/48873#ref-commit-3680a66
https://github.com/anonrig
https://github.com/RafaelGSS
test: validate host with commas on url.parsehttps://github.com/nodejs/node/commit/3680a66df430ba2f2b60763f06439e3b5a781233
3680a66https://github.com/nodejs/node/commit/3680a66df430ba2f2b60763f06439e3b5a781233
#48878https://github.com/nodejs/node/pull/48878
#48873https://github.com/nodejs/node/pull/48873
#48855https://github.com/nodejs/node/issues/48855
#48850https://github.com/nodejs/node/issues/48850
RafaelGSShttps://github.com/RafaelGSS
Aug 15, 2023 https://github.com/nodejs/node/pull/48873#ref-commit-420b85c
https://github.com/anonrig
https://github.com/RafaelGSS
lib: remove invalid parameter to toASCIIhttps://github.com/nodejs/node/commit/420b85c00f1732151bce913b077f65a653531472
420b85chttps://github.com/nodejs/node/commit/420b85c00f1732151bce913b077f65a653531472
#48878https://github.com/nodejs/node/pull/48878
#48873https://github.com/nodejs/node/pull/48873
#48855https://github.com/nodejs/node/issues/48855
#48850https://github.com/nodejs/node/issues/48850
ruyadornohttps://github.com/ruyadorno
Aug 16, 2023 https://github.com/nodejs/node/pull/48873#ref-commit-e426180
https://github.com/anonrig
https://github.com/lemire
https://github.com/ruyadorno
src: replace idna functions with ada::idnahttps://github.com/nodejs/node/commit/e4261809b0b5336dab2fe42093a9a0071641aada
e426180https://github.com/nodejs/node/commit/e4261809b0b5336dab2fe42093a9a0071641aada
#47735https://github.com/nodejs/node/pull/47735
#48873https://github.com/nodejs/node/pull/48873
ruyadornohttps://github.com/ruyadorno
Aug 16, 2023 https://github.com/nodejs/node/pull/48873#ref-commit-2de9868
https://github.com/anonrig
https://github.com/ruyadorno
test: validate host with commas on url.parsehttps://github.com/nodejs/node/commit/2de98682927c1d0d95ef8ce8a5b42d42032f66f7
2de9868https://github.com/nodejs/node/commit/2de98682927c1d0d95ef8ce8a5b42d42032f66f7
#48878https://github.com/nodejs/node/pull/48878
#48873https://github.com/nodejs/node/pull/48873
#48873https://github.com/nodejs/node/pull/48873
#48855https://github.com/nodejs/node/issues/48855
#48850https://github.com/nodejs/node/issues/48850
ruyadornohttps://github.com/ruyadorno
Aug 16, 2023 https://github.com/nodejs/node/pull/48873#ref-commit-69aaf8b
https://github.com/anonrig
https://github.com/ruyadorno
lib: remove invalid parameter to toASCIIhttps://github.com/nodejs/node/commit/69aaf8b1d10ad861a94833b99fe302a8b3cc8242
69aaf8bhttps://github.com/nodejs/node/commit/69aaf8b1d10ad861a94833b99fe302a8b3cc8242
#48878https://github.com/nodejs/node/pull/48878
#48873https://github.com/nodejs/node/pull/48873
#48873https://github.com/nodejs/node/pull/48873
#48855https://github.com/nodejs/node/issues/48855
#48850https://github.com/nodejs/node/issues/48850
https://github.com/ruyadorno
ruyadornohttps://github.com/ruyadorno
Aug 16, 2023https://github.com/nodejs/node/pull/48873#issuecomment-1679806367
f4617a4...69aaf8bhttps://github.com/nodejs/node/compare/f4617a4f810cc18e1e448827c89055cbfb7c1570...69aaf8b1d10ad861a94833b99fe302a8b3cc8242
Please reload this pagehttps://github.com/nodejs/node/pull/48873
https://github.com/ruyadorno
ruyadornohttps://github.com/ruyadorno
Aug 16, 2023https://github.com/nodejs/node/pull/48873#event-10102694732
Can't resolve names of containers in the same docker network if their names contain dots #49223 https://github.com/nodejs/node/issues/49223
url.parse regression in 18.17+ #49330 https://github.com/nodejs/node/issues/49330
URL.parse fails on URLs with comma separated hosts #48850 https://github.com/nodejs/node/issues/48850
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48873
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/48873/files/17649f76b7d6a12a2dc5e0294c0575174598a313
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/48873/files/17649f76b7d6a12a2dc5e0294c0575174598a313
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/aduh95
aduh95 https://github.com/aduh95
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
v18.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av18.x
Please reload this pagehttps://github.com/nodejs/node/pull/48873
https://github.com/anonrig
https://github.com/nodejs-github-bot
https://github.com/lpinca
https://github.com/aduh95
https://github.com/ruyadorno
https://github.com/benjamingr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.