René's URL Explorer Experiment


Title: [v18.x] Revert "url: drop ICU requirement for parsing hostnames" by aduh95 · Pull Request #48869 · nodejs/node · GitHub

Open Graph Title: [v18.x] Revert "url: drop ICU requirement for parsing hostnames" by aduh95 · Pull Request #48869 · nodejs/node

X Title: [v18.x] Revert "url: drop ICU requirement for parsing hostnames" by aduh95 · Pull Request #48869 · nodejs/node

Description: This reverts commit 0dc485e. Fixes: #48850 Fixes: #48855

Open Graph Description: This reverts commit 0dc485e. Fixes: #48850 Fixes: #48855

X Description: This reverts commit 0dc485e. Fixes: #48850 Fixes: #48855

Opengraph URL: https://github.com/nodejs/node/pull/48869

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:40180f62-b532-2e79-8b8b-a6cc09cde79a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9234:23CB5E:61E0C2:8A7837:696A53CE
html-safe-noncef39cf681e64aa9ab8b255eb3d246bc034fed4645ff1d044e1d0e509ef028ed18
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjM0OjIzQ0I1RTo2MUUwQzI6OEE3ODM3OjY5NkE1M0NFIiwidmlzaXRvcl9pZCI6IjU1MzA2NDM3MDgyNDg3NDA4MTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac21905a3b95a69a8a58364e26e702dccac0db882c0cbbfdb86221686499ddfff7
hovercard-subject-tagpull_request:1444412606
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/48869/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/453e0ddebb54e362ba603d181d6320244d5629913dfaccd51baafd586b58c88f/nodejs/node/pull/48869
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/453e0ddebb54e362ba603d181d6320244d5629913dfaccd51baafd586b58c88f/nodejs/node/pull/48869
og:image:altThis reverts commit 0dc485e. Fixes: #48850 Fixes: #48855
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaduh95
hostnamegithub.com
expected-hostnamegithub.com
None3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release63c426b30d262aba269ef14c40e3c817b384cd61
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/48869#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48869
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48869
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/48869
Reloadhttps://github.com/nodejs/node/pull/48869
Reloadhttps://github.com/nodejs/node/pull/48869
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/48869
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/48869
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/48869#issue-comment-box
aduh95https://github.com/aduh95
nodejs:v18.x-staginghttps://github.com/nodejs/node/tree/v18.x-staging
aduh95:revert-v18-breaking-changehttps://github.com/aduh95/node/tree/revert-v18-breaking-change
[v18.x] Revert "url: drop ICU requirement for parsing hostnames" https://github.com/nodejs/node/pull/48869#top
aduh95https://github.com/aduh95
nodejs:v18.x-staginghttps://github.com/nodejs/node/tree/v18.x-staging
aduh95:revert-v18-breaking-changehttps://github.com/aduh95/node/tree/revert-v18-breaking-change
Conversation 10 https://github.com/nodejs/node/pull/48869
Commits 4 https://github.com/nodejs/node/pull/48869/commits
Checks 0 https://github.com/nodejs/node/pull/48869/checks
Files changed https://github.com/nodejs/node/pull/48869/files
Please reload this pagehttps://github.com/nodejs/node/pull/48869
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/aduh95
aduh95https://github.com/aduh95
Jul 21, 2023https://github.com/nodejs/node/pull/48869#issue-1815713579
0dc485ehttps://github.com/nodejs/node/commit/0dc485eb28fb05eafad4dc78c646d917d8d4024a
#48850https://github.com/nodejs/node/issues/48850
#48855https://github.com/nodejs/node/issues/48855
Please reload this pagehttps://github.com/nodejs/node/pull/48869
https://github.com/aduh95
Revert "url: drop ICU requirement for parsing hostnames"https://github.com/nodejs/node/pull/48869/commits/0560f54fe044bbb3e6c0b3914bc6dbbc3e534fff
0560f54https://github.com/nodejs/node/pull/48869/commits/0560f54fe044bbb3e6c0b3914bc6dbbc3e534fff
0dc485ehttps://github.com/aduh95/node/commit/0dc485eb28fb05eafad4dc78c646d917d8d4024a
https://github.com/aduh95
aduh95https://github.com/aduh95
anonrighttps://github.com/anonrig
July 21, 2023 12:19https://github.com/nodejs/node/pull/48869#event-9884757084
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 21, 2023https://github.com/nodejs/node/pull/48869#issuecomment-1645495007
Please reload this pagehttps://github.com/nodejs/node/pull/48869
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
dependencies https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adependencies
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
v18.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av18.x
Jul 21, 2023https://github.com/nodejs/node/pull/48869#event-9884758693
https://github.com/aduh95
fixup! Revert "url: drop ICU requirement for parsing hostnames"https://github.com/nodejs/node/pull/48869/commits/f3d70d4d840224804d8a4d3c470b2f9dccc6144a
f3d70d4https://github.com/nodejs/node/pull/48869/commits/f3d70d4d840224804d8a4d3c470b2f9dccc6144a
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jul 21, 2023 https://github.com/nodejs/node/pull/48869#pullrequestreview-1541164190
View reviewed changes https://github.com/nodejs/node/pull/48869/files/f3d70d4d840224804d8a4d3c470b2f9dccc6144a
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jul 21, 2023 https://github.com/nodejs/node/pull/48869#pullrequestreview-1541191772
View reviewed changes https://github.com/nodejs/node/pull/48869/files/f3d70d4d840224804d8a4d3c470b2f9dccc6144a
deps/ada/ada.gyphttps://github.com/nodejs/node/pull/48869/files/f3d70d4d840224804d8a4d3c470b2f9dccc6144a#diff-e61a3e4f33a49c131cb7cc396b0cf2552488aa824c732dcc0042bcd2f97b918c
anonrighttps://github.com/anonrig
Jul 21, 2023https://github.com/nodejs/node/pull/48869#discussion_r1270698015
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/48869
aduh95https://github.com/aduh95
Jul 21, 2023https://github.com/nodejs/node/pull/48869#discussion_r1270780260
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/48869
test/benchmark/test-benchmark-url.jshttps://github.com/nodejs/node/pull/48869/files/f3d70d4d840224804d8a4d3c470b2f9dccc6144a#diff-792822b17b744f8cc26e21bdb056c687e7c615e769208a3dc4ecbc79588847be
anonrighttps://github.com/anonrig
Jul 21, 2023https://github.com/nodejs/node/pull/48869#discussion_r1270698636
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/48869
aduh95https://github.com/aduh95
Jul 21, 2023https://github.com/nodejs/node/pull/48869#discussion_r1270784500
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/48869
test/wpt/status/url.jsonhttps://github.com/nodejs/node/pull/48869/files/f3d70d4d840224804d8a4d3c470b2f9dccc6144a#diff-2b4d990de2cb3e013c5f0203a8f07c1350ad0732d18d1afb5fe52984cb70ed72
anonrighttps://github.com/anonrig
Jul 21, 2023https://github.com/nodejs/node/pull/48869#discussion_r1270698954
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/48869
https://github.com/lemire
lemirehttps://github.com/lemire
Jul 21, 2023https://github.com/nodejs/node/pull/48869#issuecomment-1645641085
Please reload this pagehttps://github.com/nodejs/node/pull/48869
https://github.com/lpinca
lpincahttps://github.com/lpinca
stale reviewhttps://github.com/nodejs/node/pull/48869#pullrequestreview-1541164190
July 21, 2023 14:55https://github.com/nodejs/node/pull/48869#event-9886253430
#48850 (comment)https://github.com/nodejs/node/issues/48850#issuecomment-1645719768
aduh95https://github.com/aduh95
July 21, 2023 17:01https://github.com/nodejs/node/pull/48869#commits-pushed-b3b5367
https://github.com/aduh95
fixup! Revert "url: drop ICU requirement for parsing hostnames"https://github.com/nodejs/node/pull/48869/commits/b3b53675d8e5a53175bedc0104e23a0907a4891b
b3b5367https://github.com/nodejs/node/pull/48869/commits/b3b53675d8e5a53175bedc0104e23a0907a4891b
https://github.com/aduh95
url: drop ICU requirement for parsing hostnames in URLhttps://github.com/nodejs/node/pull/48869/commits/474979ecc44c9de20a52145eb91ed265063b3c66
474979ehttps://github.com/nodejs/node/pull/48869/commits/474979ecc44c9de20a52145eb91ed265063b3c66
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jul 21, 2023https://github.com/nodejs/node/pull/48869#issuecomment-1645737442
@lemirehttps://github.com/lemire
ada-url/idna#32https://github.com/ada-url/idna/pull/32
Please reload this pagehttps://github.com/nodejs/node/pull/48869
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jul 21, 2023https://github.com/nodejs/node/pull/48869#issuecomment-1645764880
@aduh95https://github.com/aduh95
#48873https://github.com/nodejs/node/pull/48873
Please reload this pagehttps://github.com/nodejs/node/pull/48869
https://github.com/aduh95
aduh95https://github.com/aduh95
Jul 22, 2023https://github.com/nodejs/node/pull/48869#issuecomment-1646523259
#48873https://github.com/nodejs/node/pull/48873
Please reload this pagehttps://github.com/nodejs/node/pull/48869
https://github.com/aduh95
aduh95https://github.com/aduh95
Jul 22, 2023https://github.com/nodejs/node/pull/48869#event-9890736453
https://github.com/aduh95
aduh95https://github.com/aduh95
July 22, 2023 08:11https://github.com/nodejs/node/pull/48869#event-9890736533
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48869
https://github.com/anonrig
anonrig https://github.com/anonrig
https://github.com/nodejs/node/pull/48869/files/f3d70d4d840224804d8a4d3c470b2f9dccc6144a
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/48869/files/f3d70d4d840224804d8a4d3c470b2f9dccc6144a
dependencies https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adependencies
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
v18.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av18.x
Please reload this pagehttps://github.com/nodejs/node/pull/48869
https://github.com/aduh95
https://github.com/nodejs-github-bot
https://github.com/lemire
https://github.com/anonrig
https://github.com/lpinca
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.