René's URL Explorer Experiment


Title: fs: remove redundant `nullCheck` by LiviaMedeiros · Pull Request #48826 · nodejs/node · GitHub

Open Graph Title: fs: remove redundant `nullCheck` by LiviaMedeiros · Pull Request #48826 · nodejs/node

X Title: fs: remove redundant `nullCheck` by LiviaMedeiros · Pull Request #48826 · nodejs/node

Description: The basePath is validated with getValidatedPath before calling readdirSyncRecursive so there's no need to doublecheck it. The check might make sense for each iteration, but AFAIK there's no way to ...

Open Graph Description: The basePath is validated with getValidatedPath before calling readdirSyncRecursive so there's no need to doublecheck it. The check might make sense for each iteration, but AFAIK there's no...

X Description: The basePath is validated with getValidatedPath before calling readdirSyncRecursive so there's no need to doublecheck it. The check might make sense for each iteration, but AFAIK there&...

Opengraph URL: https://github.com/nodejs/node/pull/48826

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/*id(.:format)
route-controllerpull_requests
route-actionshow
fetch-noncev2:8d8ef390-dd70-7caa-da37-7600b60a8c73
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA554:3A6082:8DB580:B75E4E:696AF3B0
html-safe-nonce67c40cf22d39e5eb46041af4f52c33c13300097bd0e57671e1948ee753524586
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTU0OjNBNjA4Mjo4REI1ODA6Qjc1RTRFOjY5NkFGM0IwIiwidmlzaXRvcl9pZCI6IjU0NzEzOTE0MzQ2NDk4MjYyMjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacbab41a342fb6daacb91ebf250ee8b78a14ce8f23649a20a2fae56a5a681e3ada
hovercard-subject-tagpull_request:1439261915
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/48826
twitter:imagehttps://opengraph.githubassets.com/7bea508083e7424d8163264c8d2acfe3feb72f5a2db0dbd0facbfed0698efb8c/nodejs/node/pull/48826
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7bea508083e7424d8163264c8d2acfe3feb72f5a2db0dbd0facbfed0698efb8c/nodejs/node/pull/48826
og:image:altThe basePath is validated with getValidatedPath before calling readdirSyncRecursive so there's no need to doublecheck it. The check might make sense for each iteration, but AFAIK there's no...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameLiviaMedeiros
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/48826#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48826
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48826
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/48826
Reloadhttps://github.com/nodejs/node/pull/48826
Reloadhttps://github.com/nodejs/node/pull/48826
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/48826
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 692 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/48826
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/48826#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
LiviaMedeiros:fs-readdirsyncrecursive-nullcheckhttps://github.com/LiviaMedeiros/node/tree/fs-readdirsyncrecursive-nullcheck
fs: remove redundant nullCheck https://github.com/nodejs/node/pull/48826#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
LiviaMedeiros:fs-readdirsyncrecursive-nullcheckhttps://github.com/LiviaMedeiros/node/tree/fs-readdirsyncrecursive-nullcheck
Conversation 3 https://github.com/nodejs/node/pull/48826
Commits 1 https://github.com/nodejs/node/pull/48826/commits
Checks 0 https://github.com/nodejs/node/pull/48826/checks
Files changed https://github.com/nodejs/node/pull/48826/files
Please reload this pagehttps://github.com/nodejs/node/pull/48826
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
Jul 18, 2023https://github.com/nodejs/node/pull/48826#issue-1809942337
Please reload this pagehttps://github.com/nodejs/node/pull/48826
https://github.com/LiviaMedeiros
fs: remove redundant nullCheckhttps://github.com/nodejs/node/pull/48826/commits/deaf759c4bf2ea77de2c99c17005f0b337145195
deaf759https://github.com/nodejs/node/pull/48826/commits/deaf759c4bf2ea77de2c99c17005f0b337145195
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jul 18, 2023https://github.com/nodejs/node/pull/48826#event-9850478313
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 18, 2023https://github.com/nodejs/node/pull/48826#event-9852574319
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 18, 2023https://github.com/nodejs/node/pull/48826#event-9852679614
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 18, 2023https://github.com/nodejs/node/pull/48826#issuecomment-1640549923
https://ci.nodejs.org/job/node-test-pull-request/52831/https://ci.nodejs.org/job/node-test-pull-request/52831/
Please reload this pagehttps://github.com/nodejs/node/pull/48826
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jul 18, 2023 https://github.com/nodejs/node/pull/48826#pullrequestreview-1535518578
View reviewed changes https://github.com/nodejs/node/pull/48826/files/deaf759c4bf2ea77de2c99c17005f0b337145195
https://github.com/VoltrexKeyva
VoltrexKeyvahttps://github.com/VoltrexKeyva
Jul 18, 2023 https://github.com/nodejs/node/pull/48826#pullrequestreview-1535644115
View reviewed changes https://github.com/nodejs/node/pull/48826/files/deaf759c4bf2ea77de2c99c17005f0b337145195
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 18, 2023https://github.com/nodejs/node/pull/48826#issuecomment-1640850957
https://ci.nodejs.org/job/node-test-pull-request/52835/https://ci.nodejs.org/job/node-test-pull-request/52835/
Please reload this pagehttps://github.com/nodejs/node/pull/48826
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 19, 2023 https://github.com/nodejs/node/pull/48826#ref-issue-1810919555
CI Reliability 2023-07-19 nodejs/reliability#617 https://github.com/nodejs/reliability/issues/617
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jul 19, 2023 https://github.com/nodejs/node/pull/48826#pullrequestreview-1536121982
View reviewed changes https://github.com/nodejs/node/pull/48826/files/deaf759c4bf2ea77de2c99c17005f0b337145195
https://github.com/anonrig
anonrighttps://github.com/anonrig
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jul 19, 2023https://github.com/nodejs/node/pull/48826#event-9856980920
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 20, 2023 https://github.com/nodejs/node/pull/48826#ref-issue-1812920317
CI Reliability 2023-07-20 nodejs/reliability#618 https://github.com/nodejs/reliability/issues/618
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jul 20, 2023https://github.com/nodejs/node/pull/48826#event-9874627287
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
e7c3977https://github.com/nodejs/node/commit/e7c397739ff935e8b0f54505a4e37ca711e69d94
Jul 20, 2023https://github.com/nodejs/node/pull/48826#event-9874628122
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 20, 2023https://github.com/nodejs/node/pull/48826#issuecomment-1643935899
e7c3977https://github.com/nodejs/node/commit/e7c397739ff935e8b0f54505a4e37ca711e69d94
Please reload this pagehttps://github.com/nodejs/node/pull/48826
CI Reliability 2023-07-21 nodejs/reliability#619 https://github.com/nodejs/reliability/issues/619
CI Reliability 2023-07-22 nodejs/reliability#620 https://github.com/nodejs/reliability/issues/620
CI Reliability 2023-07-23 nodejs/reliability#621 https://github.com/nodejs/reliability/issues/621
CI Reliability 2023-07-24 nodejs/reliability#622 https://github.com/nodejs/reliability/issues/622
CI Reliability 2023-07-25 nodejs/reliability#623 https://github.com/nodejs/reliability/issues/623
CI Reliability 2023-07-26 nodejs/reliability#624 https://github.com/nodejs/reliability/issues/624
plurishttps://github.com/pluris
Aug 6, 2023 https://github.com/nodejs/node/pull/48826#ref-commit-ab46033
https://github.com/LiviaMedeiros
fs: remove redundant nullCheckhttps://github.com/pluris/node/commit/ab460336a7dfaf413bcfff0089c970f2bbc15640
ab46033https://github.com/pluris/node/commit/ab460336a7dfaf413bcfff0089c970f2bbc15640
nodejs#48826https://github.com/nodejs/node/pull/48826
plurishttps://github.com/pluris
Aug 7, 2023 https://github.com/nodejs/node/pull/48826#ref-commit-f76b600
https://github.com/LiviaMedeiros
fs: remove redundant nullCheckhttps://github.com/pluris/node/commit/f76b600196791e60bd0728ab7fce7755f511d063
f76b600https://github.com/pluris/node/commit/f76b600196791e60bd0728ab7fce7755f511d063
nodejs#48826https://github.com/nodejs/node/pull/48826
Ceres6https://github.com/Ceres6
Aug 14, 2023 https://github.com/nodejs/node/pull/48826#ref-commit-0c2866f
https://github.com/LiviaMedeiros
https://github.com/Ceres6
fs: remove redundant nullCheckhttps://github.com/Ceres6/node/commit/0c2866f597692b695f35cb1517a4d801aa7a5f04
0c2866fhttps://github.com/Ceres6/node/commit/0c2866f597692b695f35cb1517a4d801aa7a5f04
nodejs#48826https://github.com/nodejs/node/pull/48826
Ceres6https://github.com/Ceres6
Aug 14, 2023 https://github.com/nodejs/node/pull/48826#ref-commit-3f58cb3
https://github.com/LiviaMedeiros
https://github.com/Ceres6
fs: remove redundant nullCheckhttps://github.com/Ceres6/node/commit/3f58cb3daaeeb96b05475d26da79589d0a87ba54
3f58cb3https://github.com/Ceres6/node/commit/3f58cb3daaeeb96b05475d26da79589d0a87ba54
nodejs#48826https://github.com/nodejs/node/pull/48826
UlisesGasconhttps://github.com/UlisesGascon
Aug 14, 2023 https://github.com/nodejs/node/pull/48826#ref-commit-b6856cf
https://github.com/LiviaMedeiros
https://github.com/UlisesGascon
fs: remove redundant nullCheckhttps://github.com/UlisesGascon/node/commit/b6856cfe84fc52cd114e542f692940a069e8ad1b
b6856cfhttps://github.com/UlisesGascon/node/commit/b6856cfe84fc52cd114e542f692940a069e8ad1b
nodejs#48826https://github.com/nodejs/node/pull/48826
RafaelGSShttps://github.com/RafaelGSS
Aug 15, 2023 https://github.com/nodejs/node/pull/48826#ref-commit-4515a28
https://github.com/LiviaMedeiros
https://github.com/RafaelGSS
fs: remove redundant nullCheckhttps://github.com/nodejs/node/commit/4515a285a495528fb99262ceaaafa56d139e9ea0
4515a28https://github.com/nodejs/node/commit/4515a285a495528fb99262ceaaafa56d139e9ea0
#48826https://github.com/nodejs/node/pull/48826
https://github.com/UlisesGascon
UlisesGasconhttps://github.com/UlisesGascon
Aug 15, 2023 https://github.com/nodejs/node/pull/48826#ref-pullrequest-1851901207
v20.6.0 proposal #49185 https://github.com/nodejs/node/pull/49185
targoshttps://github.com/targos
Nov 27, 2023 https://github.com/nodejs/node/pull/48826#ref-commit-ae8bb16
https://github.com/LiviaMedeiros
https://github.com/targos
fs: remove redundant nullCheckhttps://github.com/nodejs/node/commit/ae8bb162b407b4704cc9f946820ccfea51a94c8c
ae8bb16https://github.com/nodejs/node/commit/ae8bb162b407b4704cc9f946820ccfea51a94c8c
#48826https://github.com/nodejs/node/pull/48826
https://github.com/targos
targoshttps://github.com/targos
Nov 28, 2023 https://github.com/nodejs/node/pull/48826#ref-pullrequest-2014162105
v18.19.0 release proposal #50953 https://github.com/nodejs/node/pull/50953
sercherhttps://github.com/sercher
Apr 25, 2024 https://github.com/nodejs/node/pull/48826#ref-commit-27ad80a
https://github.com/sercher
fs: remove redundant nullCheckhttps://github.com/sercher/graaljs/commit/27ad80a1ce944d6cefd8b3ef4941f65701d0c1e8
27ad80ahttps://github.com/sercher/graaljs/commit/27ad80a1ce944d6cefd8b3ef4941f65701d0c1e8
nodejs/node#48826https://github.com/nodejs/node/pull/48826
sercherhttps://github.com/sercher
Apr 25, 2024 https://github.com/nodejs/node/pull/48826#ref-commit-ed01c5a
https://github.com/sercher
fs: remove redundant nullCheckhttps://github.com/sercher/graaljs/commit/ed01c5a23ea558d647894e8bae9347c6139daa82
ed01c5ahttps://github.com/sercher/graaljs/commit/ed01c5a23ea558d647894e8bae9347c6139daa82
nodejs/node#48826https://github.com/nodejs/node/pull/48826
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48826
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/48826/files/deaf759c4bf2ea77de2c99c17005f0b337145195
https://github.com/anonrig
anonrig https://github.com/anonrig
https://github.com/nodejs/node/pull/48826/files/deaf759c4bf2ea77de2c99c17005f0b337145195
https://github.com/VoltrexKeyva
VoltrexKeyva https://github.com/VoltrexKeyva
https://github.com/nodejs/node/pull/48826/files/deaf759c4bf2ea77de2c99c17005f0b337145195
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/48826
https://github.com/LiviaMedeiros
https://github.com/nodejs-github-bot
https://github.com/lpinca
https://github.com/anonrig
https://github.com/VoltrexKeyva
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.