René's URL Explorer Experiment


Title: src: make BaseObject iteration order deterministic by joyeecheung · Pull Request #48702 · nodejs/node · GitHub

Open Graph Title: src: make BaseObject iteration order deterministic by joyeecheung · Pull Request #48702 · nodejs/node

X Title: src: make BaseObject iteration order deterministic by joyeecheung · Pull Request #48702 · nodejs/node

Description: Previously we just rely on the unordered_set order to iterate over the BaseObjects, which is not deterministic. The iteration is only used in printing, verification, and snapshot generation. In the first two cases the performance overhead of sorting does not matter because they are only used for debugging. In the last case the determinism is more important than the trivial overhead of sorting. So this patch makes the iteration deterministic by sorting the set first, as what is already being done when we drain the queue. Refs: nodejs/build#3043

Open Graph Description: Previously we just rely on the unordered_set order to iterate over the BaseObjects, which is not deterministic. The iteration is only used in printing, verification, and snapshot generation. In the...

X Description: Previously we just rely on the unordered_set order to iterate over the BaseObjects, which is not deterministic. The iteration is only used in printing, verification, and snapshot generation. In the...

Opengraph URL: https://github.com/nodejs/node/pull/48702

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:70c9b35b-12aa-dc6a-5a58-3bf121bf0d68
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9B16:3B94BF:1D4521:292F3A:69974519
html-safe-noncecc40f5ce5070b5b198ce04165067f8df60a8431e17b41a16158c77dcc318c803
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjE2OjNCOTRCRjoxRDQ1MjE6MjkyRjNBOjY5OTc0NTE5IiwidmlzaXRvcl9pZCI6IjE1OTE0NjU1Mjg3NTI4MTc0MzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca6123a10a070b8773f8b440dd1225d0ff205681f35681810d2aac880fb1df90e
hovercard-subject-tagpull_request:1425941081
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524
twitter:imagehttps://avatars.githubusercontent.com/u/4299420?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4299420?s=400&v=4
og:image:altPreviously we just rely on the unordered_set order to iterate over the BaseObjects, which is not deterministic. The iteration is only used in printing, verification, and snapshot generation. In the...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonec2f6b9675e9141deef3eda21e5cb896d461bd4d25aeaeeba804502ef0e8d01f2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release06ceed63f0d4941788d6c52a00d38ad77b6eaf89
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48702%2Fcommits%2F07fdbd562e6328566796a20aa873ce371a604524
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48702%2Fcommits%2F07fdbd562e6328566796a20aa873ce371a604524
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524
Reloadhttps://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524
Reloadhttps://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.8k https://github.com/nodejs/node/issues
Pull requests 713 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
joyeecheung:cleanup-queue-orderhttps://github.com/joyeecheung/node/tree/cleanup-queue-order
Conversation 3 https://github.com/nodejs/node/pull/48702
Commits 1 https://github.com/nodejs/node/pull/48702/commits
Checks 0 https://github.com/nodejs/node/pull/48702/checks
Files changed https://github.com/nodejs/node/pull/48702/files
Please reload this pagehttps://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524
src: make BaseObject iteration order deterministic https://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524#top
Show all changes 1 commit https://github.com/nodejs/node/pull/48702/files
07fdbd5 src: make BaseObject iteration order deterministic joyeecheung Jul 8, 2023 https://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524
Clear filters https://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524
Please reload this pagehttps://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524
Please reload this pagehttps://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524
cleanup_queue-inl.h https://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524#diff-7113322f2c385cd6ed48cb647e43178f1ae1b182bc5c77da9e985932d9600635
cleanup_queue.cc https://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524#diff-b16cf82f49f47a8223df551183351acd94d8312006032aef5a65c19351677d93
cleanup_queue.h https://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524#diff-89f2856fb5e7dc6c6fdc35a624bf19a0f49b8bc8279fc1011eefd80c76dd2f25
Please reload this pagehttps://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524
https://github.com/joyeecheung
joyeecheunghttps://github.com/nodejs/node/commits?author=joyeecheung
src/cleanup_queue-inl.hhttps://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524#diff-7113322f2c385cd6ed48cb647e43178f1ae1b182bc5c77da9e985932d9600635
View file https://github.com/joyeecheung/node/blob/07fdbd562e6328566796a20aa873ce371a604524/src/cleanup_queue-inl.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/48702/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524#diff-7113322f2c385cd6ed48cb647e43178f1ae1b182bc5c77da9e985932d9600635
https://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524#diff-7113322f2c385cd6ed48cb647e43178f1ae1b182bc5c77da9e985932d9600635
src/cleanup_queue.cchttps://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524#diff-b16cf82f49f47a8223df551183351acd94d8312006032aef5a65c19351677d93
View file https://github.com/joyeecheung/node/blob/07fdbd562e6328566796a20aa873ce371a604524/src/cleanup_queue.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/48702/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524#diff-b16cf82f49f47a8223df551183351acd94d8312006032aef5a65c19351677d93
https://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524#diff-b16cf82f49f47a8223df551183351acd94d8312006032aef5a65c19351677d93
https://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524#diff-b16cf82f49f47a8223df551183351acd94d8312006032aef5a65c19351677d93
src/cleanup_queue.hhttps://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524#diff-89f2856fb5e7dc6c6fdc35a624bf19a0f49b8bc8279fc1011eefd80c76dd2f25
View file https://github.com/joyeecheung/node/blob/07fdbd562e6328566796a20aa873ce371a604524/src/cleanup_queue.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/48702/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524#diff-89f2856fb5e7dc6c6fdc35a624bf19a0f49b8bc8279fc1011eefd80c76dd2f25
https://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524#diff-89f2856fb5e7dc6c6fdc35a624bf19a0f49b8bc8279fc1011eefd80c76dd2f25
https://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524#diff-89f2856fb5e7dc6c6fdc35a624bf19a0f49b8bc8279fc1011eefd80c76dd2f25
https://github.com/nodejs/node/pull/48702/commits/07fdbd562e6328566796a20aa873ce371a604524#diff-89f2856fb5e7dc6c6fdc35a624bf19a0f49b8bc8279fc1011eefd80c76dd2f25
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.