René's URL Explorer Experiment


Title: fs: fix readdir recursive sync & callback by Ethan-Arrowood · Pull Request #48698 · nodejs/node · GitHub

Open Graph Title: fs: fix readdir recursive sync & callback by Ethan-Arrowood · Pull Request #48698 · nodejs/node

X Title: fs: fix readdir recursive sync & callback by Ethan-Arrowood · Pull Request #48698 · nodejs/node

Description: This PR fixes the broken behavior for readdir recursive sync and callback. It updates the test assertions to catch the issue in the old code, and then adds the necessary fix in the implementation. ...

Open Graph Description: This PR fixes the broken behavior for readdir recursive sync and callback. It updates the test assertions to catch the issue in the old code, and then adds the necessary fix in the implementation. ...

X Description: This PR fixes the broken behavior for readdir recursive sync and callback. It updates the test assertions to catch the issue in the old code, and then adds the necessary fix in the implementation. ...

Opengraph URL: https://github.com/nodejs/node/pull/48698

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6293a82a-447b-7eaa-fc53-f5b477922d18
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9E6C:366DBA:1A3D1AB:2316779:6969B199
html-safe-nonce5dad7d9d2be864272e30c944d5c50811cb69e4cd6355bfd5d463a9973538145c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTZDOjM2NkRCQToxQTNEMUFCOjIzMTY3Nzk6Njk2OUIxOTkiLCJ2aXNpdG9yX2lkIjoiNTk5OTYyODMyODUxMzQxNzYyNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf423af75c4600a1c7dd44d6dc014cce5bbde927015dd8bb1f6e47fb8316c3e96
hovercard-subject-tagpull_request:1425175567
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/48698/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5a0d815b63a0751d707bbf803f2bfc7d7e0ba2d2cc86f90b15c3f4fcb84499d6/nodejs/node/pull/48698
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5a0d815b63a0751d707bbf803f2bfc7d7e0ba2d2cc86f90b15c3f4fcb84499d6/nodejs/node/pull/48698
og:image:altThis PR fixes the broken behavior for readdir recursive sync and callback. It updates the test assertions to catch the issue in the old code, and then adds the necessary fix in the implementation. ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameEthan-Arrowood
hostnamegithub.com
expected-hostnamegithub.com
Noneb23b8fcc855cd29bb04d6c94aafa62d336bf44eefa8229444eecc968cad03aee
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release0672399d88424758731ec07fe24509e23bb17fb5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/48698#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48698
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48698
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/48698
Reloadhttps://github.com/nodejs/node/pull/48698
Reloadhttps://github.com/nodejs/node/pull/48698
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/48698
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/48698
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/48698#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
Ethan-Arrowood:fix/readdir-recursive-sync-and-callbackhttps://github.com/Ethan-Arrowood/node/tree/fix/readdir-recursive-sync-and-callback
fs: fix readdir recursive sync & callback https://github.com/nodejs/node/pull/48698#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
Ethan-Arrowood:fix/readdir-recursive-sync-and-callbackhttps://github.com/Ethan-Arrowood/node/tree/fix/readdir-recursive-sync-and-callback
Conversation 21 https://github.com/nodejs/node/pull/48698
Commits 1 https://github.com/nodejs/node/pull/48698/commits
Checks 0 https://github.com/nodejs/node/pull/48698/checks
Files changed https://github.com/nodejs/node/pull/48698/files
Please reload this pagehttps://github.com/nodejs/node/pull/48698
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/Ethan-Arrowood
Ethan-Arrowoodhttps://github.com/Ethan-Arrowood
Jul 7, 2023https://github.com/nodejs/node/pull/48698#issue-1794098177
Please reload this pagehttps://github.com/nodejs/node/pull/48698
#48640https://github.com/nodejs/node/issues/48640
#48858https://github.com/nodejs/node/issues/48858
Please reload this pagehttps://github.com/nodejs/node/pull/48698
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jul 7, 2023https://github.com/nodejs/node/pull/48698#event-9758311647
https://github.com/Ethan-Arrowood
Ethan-Arrowoodhttps://github.com/Ethan-Arrowood
Jul 7, 2023https://github.com/nodejs/node/pull/48698#issuecomment-1625938196
Please reload this pagehttps://github.com/nodejs/node/pull/48698
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jul 7, 2023 https://github.com/nodejs/node/pull/48698#pullrequestreview-1519754838
View reviewed changes https://github.com/nodejs/node/pull/48698/files
test/sequential/test-fs-readdir-recursive.jshttps://github.com/nodejs/node/pull/48698/files#diff-1eb009ee5a6980e5b9694098bd6dabdff0e2083f59fb603c6347e413b7c32369
Please reload this pagehttps://github.com/nodejs/node/pull/48698
lib/fs.jshttps://github.com/nodejs/node/pull/48698/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
Please reload this pagehttps://github.com/nodejs/node/pull/48698
https://github.com/chris-sophos
chris-sophoshttps://github.com/chris-sophos
Jul 8, 2023https://github.com/nodejs/node/pull/48698#issuecomment-1626740998
Please reload this pagehttps://github.com/nodejs/node/pull/48698
https://github.com/Ethan-Arrowood
Ethan-Arrowoodhttps://github.com/Ethan-Arrowood
Jul 18, 2023 https://github.com/nodejs/node/pull/48698#ref-issue-1808540009
fs#opendir does not return all files in subdirectories when bufferSize is less than the directory size #48820 https://github.com/nodejs/node/issues/48820
fs: fix readdir recursive sync & callbackhttps://github.com/nodejs/node/pull/48698/commits/d6363033aaf7d653e6f168de2a26e7fe2e8e2903
d636303https://github.com/nodejs/node/pull/48698/commits/d6363033aaf7d653e6f168de2a26e7fe2e8e2903
nodejs#48640https://github.com/nodejs/node/issues/48640
https://github.com/Ethan-Arrowood
Ethan-Arrowoodhttps://github.com/Ethan-Arrowood
force-pushedhttps://github.com/nodejs/node/compare/7bcf27f20576077f37f15730ab9c33df744be743..d6363033aaf7d653e6f168de2a26e7fe2e8e2903
7bcf27fhttps://github.com/nodejs/node/commit/7bcf27f20576077f37f15730ab9c33df744be743
d636303https://github.com/nodejs/node/commit/d6363033aaf7d653e6f168de2a26e7fe2e8e2903
Compare https://github.com/nodejs/node/compare/7bcf27f20576077f37f15730ab9c33df744be743..d6363033aaf7d653e6f168de2a26e7fe2e8e2903
July 19, 2023 16:45https://github.com/nodejs/node/pull/48698#event-9864848453
https://github.com/Ethan-Arrowood
Ethan-Arrowoodhttps://github.com/Ethan-Arrowood
Jul 19, 2023https://github.com/nodejs/node/pull/48698#issuecomment-1642422287
Please reload this pagehttps://github.com/nodejs/node/pull/48698
https://github.com/Ethan-Arrowood
Ethan-Arrowoodhttps://github.com/Ethan-Arrowood
anonrighttps://github.com/anonrig
July 19, 2023 16:46https://github.com/nodejs/node/pull/48698#event-9864856206
https://github.com/MattIPv4
MattIPv4https://github.com/MattIPv4
Jul 20, 2023 https://github.com/nodejs/node/pull/48698#ref-issue-1814714689
fs#readdir(Sync) breaks when recursive + withFileTypes combined #48858 https://github.com/nodejs/node/issues/48858
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jul 26, 2023 https://github.com/nodejs/node/pull/48698#pullrequestreview-1546929120
View reviewed changes https://github.com/nodejs/node/pull/48698/files/d6363033aaf7d653e6f168de2a26e7fe2e8e2903
BridgeARhttps://github.com/BridgeAR
https://github.com/nodejs/node/pull/48698#pullrequestreview-1546929120
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/48698
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 26, 2023https://github.com/nodejs/node/pull/48698#event-9919797021
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 26, 2023https://github.com/nodejs/node/pull/48698#event-9919848736
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 26, 2023https://github.com/nodejs/node/pull/48698#issuecomment-1651076054
https://ci.nodejs.org/job/node-test-pull-request/52933/https://ci.nodejs.org/job/node-test-pull-request/52933/
Please reload this pagehttps://github.com/nodejs/node/pull/48698
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Jul 26, 2023 https://github.com/nodejs/node/pull/48698#pullrequestreview-1546991504
View reviewed changes https://github.com/nodejs/node/pull/48698/files/d6363033aaf7d653e6f168de2a26e7fe2e8e2903
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 26, 2023https://github.com/nodejs/node/pull/48698#issuecomment-1651507888
https://ci.nodejs.org/job/node-test-pull-request/52934/https://ci.nodejs.org/job/node-test-pull-request/52934/
Please reload this pagehttps://github.com/nodejs/node/pull/48698
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Jul 26, 2023 https://github.com/nodejs/node/pull/48698#pullrequestreview-1547523812
View reviewed changes https://github.com/nodejs/node/pull/48698/files/d6363033aaf7d653e6f168de2a26e7fe2e8e2903
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 26, 2023https://github.com/nodejs/node/pull/48698#issuecomment-1651694401
https://ci.nodejs.org/job/node-test-pull-request/52935/https://ci.nodejs.org/job/node-test-pull-request/52935/
Please reload this pagehttps://github.com/nodejs/node/pull/48698
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 26, 2023https://github.com/nodejs/node/pull/48698#issuecomment-1651814858
https://ci.nodejs.org/job/node-test-pull-request/52937/https://ci.nodejs.org/job/node-test-pull-request/52937/
Please reload this pagehttps://github.com/nodejs/node/pull/48698
CI Reliability 2023-07-27 nodejs/reliability#625 https://github.com/nodejs/reliability/issues/625
CI Reliability 2023-07-28 nodejs/reliability#626 https://github.com/nodejs/reliability/issues/626
CI Reliability 2023-07-29 nodejs/reliability#627 https://github.com/nodejs/reliability/issues/627
CI Reliability 2023-07-30 nodejs/reliability#628 https://github.com/nodejs/reliability/issues/628
https://github.com/debadree25
debadree25https://github.com/debadree25
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 30, 2023https://github.com/nodejs/node/pull/48698#event-9956270123
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 30, 2023https://github.com/nodejs/node/pull/48698#issuecomment-1657063801
https://ci.nodejs.org/job/node-test-pull-request/52991/https://ci.nodejs.org/job/node-test-pull-request/52991/
Please reload this pagehttps://github.com/nodejs/node/pull/48698
CI Reliability 2023-07-31 nodejs/reliability#629 https://github.com/nodejs/reliability/issues/629
CI Reliability 2023-08-01 nodejs/reliability#630 https://github.com/nodejs/reliability/issues/630
CI Reliability 2023-08-02 nodejs/reliability#631 https://github.com/nodejs/reliability/issues/631
CI Reliability 2023-08-03 nodejs/reliability#632 https://github.com/nodejs/reliability/issues/632
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 11, 2023https://github.com/nodejs/node/pull/48698#issuecomment-1674262751
https://ci.nodejs.org/job/node-test-pull-request/53175/https://ci.nodejs.org/job/node-test-pull-request/53175/
Please reload this pagehttps://github.com/nodejs/node/pull/48698
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 11, 2023https://github.com/nodejs/node/pull/48698#issuecomment-1674369632
https://ci.nodejs.org/job/node-test-pull-request/53180/https://ci.nodejs.org/job/node-test-pull-request/53180/
Please reload this pagehttps://github.com/nodejs/node/pull/48698
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 11, 2023https://github.com/nodejs/node/pull/48698#issuecomment-1674717315
https://ci.nodejs.org/job/node-test-pull-request/53188/https://ci.nodejs.org/job/node-test-pull-request/53188/
Please reload this pagehttps://github.com/nodejs/node/pull/48698
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 12, 2023https://github.com/nodejs/node/pull/48698#issuecomment-1675834125
https://ci.nodejs.org/job/node-test-pull-request/53228/https://ci.nodejs.org/job/node-test-pull-request/53228/
Please reload this pagehttps://github.com/nodejs/node/pull/48698
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 12, 2023https://github.com/nodejs/node/pull/48698#issuecomment-1676072911
https://ci.nodejs.org/job/node-test-pull-request/53247/https://ci.nodejs.org/job/node-test-pull-request/53247/
Please reload this pagehttps://github.com/nodejs/node/pull/48698
https://github.com/MoLow
MoLowhttps://github.com/MoLow
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 12, 2023https://github.com/nodejs/node/pull/48698#event-10078083296
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 12, 2023https://github.com/nodejs/node/pull/48698#event-10078089794
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
27cadf5https://github.com/nodejs/node/commit/27cadf5e933913ab5505211bef4ac589348dab26
Aug 12, 2023https://github.com/nodejs/node/pull/48698#event-10078089839
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 12, 2023https://github.com/nodejs/node/pull/48698#issuecomment-1676096828
27cadf5https://github.com/nodejs/node/commit/27cadf5e933913ab5505211bef4ac589348dab26
Please reload this pagehttps://github.com/nodejs/node/pull/48698
CI Reliability 2023-08-13 nodejs/reliability#635 https://github.com/nodejs/reliability/issues/635
CI Reliability 2023-08-14 nodejs/reliability#636 https://github.com/nodejs/reliability/issues/636
Ceres6https://github.com/Ceres6
Aug 14, 2023 https://github.com/nodejs/node/pull/48698#ref-commit-292b9c2
https://github.com/Ceres6
fs: fix readdir recursive sync & callbackhttps://github.com/Ceres6/node/commit/292b9c206befecb79336a5b6a1c02b5c76b89eb9
292b9c2https://github.com/Ceres6/node/commit/292b9c206befecb79336a5b6a1c02b5c76b89eb9
nodejs#48640https://github.com/nodejs/node/issues/48640
nodejs#48698https://github.com/nodejs/node/pull/48698
nodejs#48858https://github.com/nodejs/node/issues/48858
RafaelGSShttps://github.com/RafaelGSS
Aug 15, 2023 https://github.com/nodejs/node/pull/48698#ref-commit-acb6da3
https://github.com/RafaelGSS
fs: fix readdir recursive sync & callbackhttps://github.com/nodejs/node/commit/acb6da35e4966090770f3b08a8624eb0f7012dbd
acb6da3https://github.com/nodejs/node/commit/acb6da35e4966090770f3b08a8624eb0f7012dbd
#48640https://github.com/nodejs/node/issues/48640
#48698https://github.com/nodejs/node/pull/48698
#48858https://github.com/nodejs/node/issues/48858
https://github.com/UlisesGascon
UlisesGasconhttps://github.com/UlisesGascon
Aug 15, 2023 https://github.com/nodejs/node/pull/48698#ref-pullrequest-1851901207
v20.6.0 proposal #49185 https://github.com/nodejs/node/pull/49185
RafaelGSShttps://github.com/RafaelGSS
Aug 15, 2023 https://github.com/nodejs/node/pull/48698#ref-commit-036e9fa
https://github.com/RafaelGSS
fs: fix readdir recursive sync & callbackhttps://github.com/RafaelGSS/node/commit/036e9fa23212b9fcdcdc6515227a2c5e688579d1
036e9fahttps://github.com/RafaelGSS/node/commit/036e9fa23212b9fcdcdc6515227a2c5e688579d1
nodejs#48640https://github.com/nodejs/node/issues/48640
nodejs#48698https://github.com/nodejs/node/pull/48698
nodejs#48858https://github.com/nodejs/node/issues/48858
rluvatonhttps://github.com/rluvaton
Aug 15, 2023 https://github.com/nodejs/node/pull/48698#ref-commit-62d36d9
https://github.com/rluvaton
fs: fix readdir recursive sync & callbackhttps://github.com/rluvaton/node/commit/62d36d9a738197eddbefed00ebeb19bf63d40bf8
62d36d9https://github.com/rluvaton/node/commit/62d36d9a738197eddbefed00ebeb19bf63d40bf8
nodejs#48640https://github.com/nodejs/node/issues/48640
nodejs#48698https://github.com/nodejs/node/pull/48698
nodejs#48858https://github.com/nodejs/node/issues/48858
RafaelGSShttps://github.com/RafaelGSS
Aug 16, 2023 https://github.com/nodejs/node/pull/48698#ref-commit-d7269a3
https://github.com/RafaelGSS
fs: fix readdir recursive sync & callbackhttps://github.com/nodejs/node/commit/d7269a35e66fde93960da078f96b69710c17c569
d7269a3https://github.com/nodejs/node/commit/d7269a35e66fde93960da078f96b69710c17c569
#48640https://github.com/nodejs/node/issues/48640
#48698https://github.com/nodejs/node/pull/48698
#48858https://github.com/nodejs/node/issues/48858
RafaelGSShttps://github.com/RafaelGSS
Aug 17, 2023 https://github.com/nodejs/node/pull/48698#ref-commit-3d942d9
https://github.com/RafaelGSS
fs: fix readdir recursive sync & callbackhttps://github.com/nodejs/node/commit/3d942d98420be7a6a0b9e73b6944904b702af9c0
3d942d9https://github.com/nodejs/node/commit/3d942d98420be7a6a0b9e73b6944904b702af9c0
#48640https://github.com/nodejs/node/issues/48640
#48698https://github.com/nodejs/node/pull/48698
#48858https://github.com/nodejs/node/issues/48858
https://github.com/kachick
kachickhttps://github.com/kachick
Aug 28, 2023 https://github.com/nodejs/node/pull/48698#ref-issue-1869755840
2023-08-28 - Node.js の fs.readdir と fs.readdirSync にバグがあって、recursive と withFileTypes オプションを両方有効にすると戻りのdirent一覧が大幅に欠落する kachick/times_kachick#244 https://github.com/kachick/times_kachick/issues/244
https://github.com/lux01
lux01https://github.com/lux01
Sep 11, 2023 https://github.com/nodejs/node/pull/48698#ref-pullrequest-1890141405
fs: fix readdir and opendir recursive with unknown file types #49603 https://github.com/nodejs/node/pull/49603
https://github.com/MattIPv4
MattIPv4https://github.com/MattIPv4
Oct 12, 2023https://github.com/nodejs/node/pull/48698#issuecomment-1759631631
#48858https://github.com/nodejs/node/issues/48858
Please reload this pagehttps://github.com/nodejs/node/pull/48698
https://github.com/richardlau
richardlauhttps://github.com/richardlau
lts-watch-v18.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v18.x
Oct 12, 2023https://github.com/nodejs/node/pull/48698#event-10632135089
https://github.com/targos
targoshttps://github.com/targos
backported-to-v18.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v18.x
lts-watch-v18.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v18.x
Oct 28, 2023https://github.com/nodejs/node/pull/48698#event-10797416431
targoshttps://github.com/targos
Oct 28, 2023 https://github.com/nodejs/node/pull/48698#ref-commit-7c758f6
https://github.com/targos
fs: fix readdir recursive sync & callbackhttps://github.com/nodejs/node/commit/7c758f60abe52808fc0f3c7e1a38756cb86be8ae
7c758f6https://github.com/nodejs/node/commit/7c758f60abe52808fc0f3c7e1a38756cb86be8ae
#48640https://github.com/nodejs/node/issues/48640
#48698https://github.com/nodejs/node/pull/48698
#48858https://github.com/nodejs/node/issues/48858
https://github.com/targos
targoshttps://github.com/targos
Nov 28, 2023 https://github.com/nodejs/node/pull/48698#ref-pullrequest-2014162105
v18.19.0 release proposal #50953 https://github.com/nodejs/node/pull/50953
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Feb 15, 2024 https://github.com/nodejs/node/pull/48698#ref-issue-2137062162
readdirSync cannot read files properly when using { recursive: true, withFileTypes: true } #51773 https://github.com/nodejs/node/issues/51773
sercherhttps://github.com/sercher
Apr 25, 2024 https://github.com/nodejs/node/pull/48698#ref-commit-c6dca02
https://github.com/sercher
fs: fix readdir recursive sync & callbackhttps://github.com/sercher/graaljs/commit/c6dca022befed34ba2adda9316b931d7c11d1ffd
c6dca02https://github.com/sercher/graaljs/commit/c6dca022befed34ba2adda9316b931d7c11d1ffd
nodejs/node#48640https://github.com/nodejs/node/issues/48640
nodejs/node#48698https://github.com/nodejs/node/pull/48698
nodejs/node#48858https://github.com/nodejs/node/issues/48858
sercherhttps://github.com/sercher
Apr 25, 2024 https://github.com/nodejs/node/pull/48698#ref-commit-a45f06b
https://github.com/sercher
fs: fix readdir recursive sync & callbackhttps://github.com/sercher/graaljs/commit/a45f06b9b973c8489f01fbcf28dda2a226073a99
a45f06bhttps://github.com/sercher/graaljs/commit/a45f06b9b973c8489f01fbcf28dda2a226073a99
nodejs/node#48640https://github.com/nodejs/node/issues/48640
nodejs/node#48698https://github.com/nodejs/node/pull/48698
nodejs/node#48858https://github.com/nodejs/node/issues/48858
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Nov 4, 2024 https://github.com/nodejs/node/pull/48698#ref-issue-2260904071
withFileTypes has different behavior in fs.readdir when reading symbolic directories #52663 https://github.com/nodejs/node/issues/52663
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48698
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/48698/files/d6363033aaf7d653e6f168de2a26e7fe2e8e2903
https://github.com/anonrig
anonrig https://github.com/anonrig
https://github.com/nodejs/node/pull/48698/files/d6363033aaf7d653e6f168de2a26e7fe2e8e2903
https://github.com/MoLow
MoLow https://github.com/MoLow
https://github.com/nodejs/node/pull/48698/files/d6363033aaf7d653e6f168de2a26e7fe2e8e2903
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/48698/files/d6363033aaf7d653e6f168de2a26e7fe2e8e2903
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
fs#readdir(Sync) breaks when recursive + withFileTypes combined https://github.com/nodejs/node/issues/48858
Please reload this pagehttps://github.com/nodejs/node/pull/48698
https://github.com/Ethan-Arrowood
https://github.com/chris-sophos
https://github.com/nodejs-github-bot
https://github.com/MattIPv4
https://github.com/benjamingr
https://github.com/anonrig
https://github.com/MoLow
https://github.com/BridgeAR
https://github.com/targos
https://github.com/richardlau
https://github.com/debadree25
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.