| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c7007a22-4400-4736-0e58-7c7ca4ebc454 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D130:1419DF:225C68:307C17:696A06E8 |
| html-safe-nonce | deb186325709cc7b5e73ec0923cebc639f09c4507d64b718989c2bf2af06d576 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTMwOjE0MTlERjoyMjVDNjg6MzA3QzE3OjY5NkEwNkU4IiwidmlzaXRvcl9pZCI6IjU3OTU2MTk5OTc1ODg1MjI3MjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ce87e8e511c190668023c6e738b9909ef476ce93a9c540dc47bc55fc6d3786c5 |
| hovercard-subject-tag | pull_request:1423422245 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/48680/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5bb311c2d7109703f21b1dfc2301d7d748b0504be9902e67ac6ebba459094d96/nodejs/node/pull/48680 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5bb311c2d7109703f21b1dfc2301d7d748b0504be9902e67ac6ebba459094d96/nodejs/node/pull/48680 |
| og:image:alt | Edited / fixed version of #48653
Clarified that stream.Transform callback second argument is passed only if the first argument is null, i.e. no error occured processing the chunk.
From the way the ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | rafasofizada |
| hostname | github.com |
| expected-hostname | github.com |
| None | 578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 671c2f67171dbced24284331f3133a613d08c366 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/48680#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48680 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48680 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/48680 |
| Reload | https://github.com/nodejs/node/pull/48680 |
| Reload | https://github.com/nodejs/node/pull/48680 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/48680 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/48680 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/48680#issue-comment-box |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| rafasofizada:main | https://github.com/rafasofizada/node_doc_contrib_transform_cb/tree/main |
|
doc: clarify transform._transform() callback argument logic
| https://github.com/nodejs/node/pull/48680#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| rafasofizada:main | https://github.com/rafasofizada/node_doc_contrib_transform_cb/tree/main |
|
Conversation
1
| https://github.com/nodejs/node/pull/48680 |
|
Commits
1
| https://github.com/nodejs/node/pull/48680/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/48680/checks |
|
Files changed
| https://github.com/nodejs/node/pull/48680/files |
| Please reload this page | https://github.com/nodejs/node/pull/48680 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/rafasofizada |
| rafasofizada | https://github.com/rafasofizada |
| Jul 6, 2023 | https://github.com/nodejs/node/pull/48680#issue-1792153617 |
| #48653 | https://github.com/nodejs/node/pull/48653 |
| the relevant implementaton | https://github.com/nodejs/node/blob/b40f0c30743aaecd57071f7be305df43e1083817/lib/internal/streams/transform.js#L176 |
| Please reload this page | https://github.com/nodejs/node/pull/48680 |
|
| https://github.com/rafasofizada |
| doc: clarify transform._transform() callback argument logic | https://github.com/nodejs/node/pull/48680/commits/a7700157f71e5d5d7d1aa407ab68fb9ec3534cef |
| a770015 | https://github.com/nodejs/node/pull/48680/commits/a7700157f71e5d5d7d1aa407ab68fb9ec3534cef |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Jul 6, 2023 | https://github.com/nodejs/node/pull/48680#event-9747565070 |
| https://github.com/rafasofizada |
| rafasofizada | https://github.com/rafasofizada |
|
Jul 6, 2023
| https://github.com/nodejs/node/pull/48680#ref-pullrequest-1788586063 |
|
doc: clarified stream.Transform callback argument logic
#48653
| https://github.com/nodejs/node/pull/48653 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jul 7, 2023
| https://github.com/nodejs/node/pull/48680#pullrequestreview-1518158889 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/48680/files/a7700157f71e5d5d7d1aa407ab68fb9ec3534cef |
| https://github.com/marsonya |
| marsonya | https://github.com/marsonya |
|
Jul 7, 2023
| https://github.com/nodejs/node/pull/48680#pullrequestreview-1518552283 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/48680/files/a7700157f71e5d5d7d1aa407ab68fb9ec3534cef |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Jul 8, 2023 | https://github.com/nodejs/node/pull/48680#event-9765410603 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Jul 8, 2023 | https://github.com/nodejs/node/pull/48680#event-9765721922 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| eece8d7 | https://github.com/nodejs/node/commit/eece8d755c69d393a7bcc14f9c9454020d91ed1d |
| Jul 8, 2023 | https://github.com/nodejs/node/pull/48680#event-9765722114 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 8, 2023 | https://github.com/nodejs/node/pull/48680#issuecomment-1627480625 |
| eece8d7 | https://github.com/nodejs/node/commit/eece8d755c69d393a7bcc14f9c9454020d91ed1d |
| Please reload this page | https://github.com/nodejs/node/pull/48680 |
| juanarbol | https://github.com/juanarbol |
|
Jul 13, 2023
| https://github.com/nodejs/node/pull/48680#ref-commit-caccb05 |
|
| https://github.com/rafasofizada |
|
| https://github.com/juanarbol |
| doc: clarify transform._transform() callback argument logic | https://github.com/nodejs/node/commit/caccb051c795d0ef5b61b49fd4e03a0352bd259e |
| caccb05 | https://github.com/nodejs/node/commit/caccb051c795d0ef5b61b49fd4e03a0352bd259e |
| #48680 | https://github.com/nodejs/node/pull/48680 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
|
Jul 13, 2023
| https://github.com/nodejs/node/pull/48680#ref-pullrequest-1803862153 |
|
V20.5.0 proposal
#48761
| https://github.com/nodejs/node/pull/48761 |
| Ceres6 | https://github.com/Ceres6 |
|
Aug 14, 2023
| https://github.com/nodejs/node/pull/48680#ref-commit-5579c69 |
|
| https://github.com/rafasofizada |
|
| https://github.com/Ceres6 |
| doc: clarify transform._transform() callback argument logic | https://github.com/Ceres6/node/commit/5579c69e4706ed34acf5e1d8432b5a8147661748 |
| 5579c69 | https://github.com/Ceres6/node/commit/5579c69e4706ed34acf5e1d8432b5a8147661748 |
| nodejs#48680 | https://github.com/nodejs/node/pull/48680 |
| Ceres6 | https://github.com/Ceres6 |
|
Aug 14, 2023
| https://github.com/nodejs/node/pull/48680#ref-commit-95c7722 |
|
| https://github.com/rafasofizada |
|
| https://github.com/Ceres6 |
| doc: clarify transform._transform() callback argument logic | https://github.com/Ceres6/node/commit/95c7722ea57ddc3c75bd02506f7507ba97907567 |
| 95c7722 | https://github.com/Ceres6/node/commit/95c7722ea57ddc3c75bd02506f7507ba97907567 |
| nodejs#48680 | https://github.com/nodejs/node/pull/48680 |
| ruyadorno | https://github.com/ruyadorno |
|
Sep 11, 2023
| https://github.com/nodejs/node/pull/48680#ref-commit-cb2e22c |
|
| https://github.com/rafasofizada |
|
| https://github.com/ruyadorno |
| doc: clarify transform._transform() callback argument logic | https://github.com/nodejs/node/commit/cb2e22c2b16130326cf4d87aca532368f3cd3204 |
| cb2e22c | https://github.com/nodejs/node/commit/cb2e22c2b16130326cf4d87aca532368f3cd3204 |
| #48680 | https://github.com/nodejs/node/pull/48680 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
|
Sep 11, 2023
| https://github.com/nodejs/node/pull/48680#ref-pullrequest-1855772061 |
|
v18.18.0 proposal
#49220
| https://github.com/nodejs/node/pull/49220 |
| ruyadorno | https://github.com/ruyadorno |
|
Sep 13, 2023
| https://github.com/nodejs/node/pull/48680#ref-commit-616ecf0 |
|
| https://github.com/rafasofizada |
|
| https://github.com/ruyadorno |
| doc: clarify transform._transform() callback argument logic | https://github.com/nodejs/node/commit/616ecf026eb6d0dfa21bd212b32d53c294235fae |
| 616ecf0 | https://github.com/nodejs/node/commit/616ecf026eb6d0dfa21bd212b32d53c294235fae |
| #48680 | https://github.com/nodejs/node/pull/48680 |
| ruyadorno | https://github.com/ruyadorno |
|
Sep 17, 2023
| https://github.com/nodejs/node/pull/48680#ref-commit-1aa798d |
|
| https://github.com/rafasofizada |
|
| https://github.com/ruyadorno |
| doc: clarify transform._transform() callback argument logic | https://github.com/nodejs/node/commit/1aa798d69f826a912a76eb0e68ae2200af3ec7df |
| 1aa798d | https://github.com/nodejs/node/commit/1aa798d69f826a912a76eb0e68ae2200af3ec7df |
| #48680 | https://github.com/nodejs/node/pull/48680 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48680 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/48680/files/a7700157f71e5d5d7d1aa407ab68fb9ec3534cef |
|
| https://github.com/marsonya |
|
marsonya
| https://github.com/marsonya |
|
| https://github.com/nodejs/node/pull/48680/files/a7700157f71e5d5d7d1aa407ab68fb9ec3534cef |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Please reload this page | https://github.com/nodejs/node/pull/48680 |
|
| https://github.com/rafasofizada |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/lpinca |
|
| https://github.com/marsonya |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |