René's URL Explorer Experiment


Title: test: make IsolateData per-isolate in cctest by joyeecheung · Pull Request #48450 · nodejs/node · GitHub

Open Graph Title: test: make IsolateData per-isolate in cctest by joyeecheung · Pull Request #48450 · nodejs/node

X Title: test: make IsolateData per-isolate in cctest by joyeecheung · Pull Request #48450 · nodejs/node

Description: This ensures that we only create one IsolateData for each isolate inthe cctest, since IsolateData are meant to be per-isolate. We need to make the isolate and isolate_data static in the test fixtur...

Open Graph Description: This ensures that we only create one IsolateData for each isolate inthe cctest, since IsolateData are meant to be per-isolate. We need to make the isolate and isolate_data static in the test fixtur...

X Description: This ensures that we only create one IsolateData for each isolate inthe cctest, since IsolateData are meant to be per-isolate. We need to make the isolate and isolate_data static in the test fixtur...

Opengraph URL: https://github.com/nodejs/node/pull/48450

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:20d3a8bc-84be-d3ab-f164-f9e632232177
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB624:1AB621:A80909:E60DF6:6969EFA0
html-safe-nonce1f1f3e481fc34dcefec318bece11852f668e4e11dc417dcac527eaa3c8b29f3e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjI0OjFBQjYyMTpBODA5MDk6RTYwREY2OjY5NjlFRkEwIiwidmlzaXRvcl9pZCI6IjkxMTQ1MzI0MzA1NjE4MDAwOTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca606d07ec01fef0e046a9d6e6337786eb5ff5d7abadef7c12ba5f770f7ca707a
hovercard-subject-tagpull_request:1391085856
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/48450/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/32d4b826c03d2b1d5eb259dbf4ebc9514b99e1ec700ad27eaebb27ddf86c6cfe/nodejs/node/pull/48450
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/32d4b826c03d2b1d5eb259dbf4ebc9514b99e1ec700ad27eaebb27ddf86c6cfe/nodejs/node/pull/48450
og:image:altThis ensures that we only create one IsolateData for each isolate inthe cctest, since IsolateData are meant to be per-isolate. We need to make the isolate and isolate_data static in the test fixtur...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoyeecheung
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/48450#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48450
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48450
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/48450
Reloadhttps://github.com/nodejs/node/pull/48450
Reloadhttps://github.com/nodejs/node/pull/48450
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/48450
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/48450
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/48450#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
joyeecheung:isolatedata-cctesthttps://github.com/joyeecheung/node/tree/isolatedata-cctest
test: make IsolateData per-isolate in cctest https://github.com/nodejs/node/pull/48450#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
joyeecheung:isolatedata-cctesthttps://github.com/joyeecheung/node/tree/isolatedata-cctest
Conversation 3 https://github.com/nodejs/node/pull/48450
Commits 1 https://github.com/nodejs/node/pull/48450/commits
Checks 0 https://github.com/nodejs/node/pull/48450/checks
Files changed https://github.com/nodejs/node/pull/48450/files
Please reload this pagehttps://github.com/nodejs/node/pull/48450
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jun 13, 2023https://github.com/nodejs/node/pull/48450#issue-1755407218
Please reload this pagehttps://github.com/nodejs/node/pull/48450
https://github.com/joyeecheung
test: make IsolateData per-isolate in cctesthttps://github.com/nodejs/node/pull/48450/commits/a5554434cbf070117d5b31a338ab30bf5daed84b
a555443https://github.com/nodejs/node/pull/48450/commits/a5554434cbf070117d5b31a338ab30bf5daed84b
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Jun 13, 2023https://github.com/nodejs/node/pull/48450#event-9519492548
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
addaleaxhttps://github.com/addaleax
June 13, 2023 18:02https://github.com/nodejs/node/pull/48450#event-9519494613
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jun 13, 2023 https://github.com/nodejs/node/pull/48450#ref-pullrequest-1471719091
src,tools: initialize cppgc #45704 https://github.com/nodejs/node/pull/45704
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jun 19, 2023https://github.com/nodejs/node/pull/48450#issuecomment-1597135798
Please reload this pagehttps://github.com/nodejs/node/pull/48450
https://github.com/legendecas
legendecashttps://github.com/legendecas
Jun 20, 2023 https://github.com/nodejs/node/pull/48450#pullrequestreview-1487891742
View reviewed changes https://github.com/nodejs/node/pull/48450/files/a5554434cbf070117d5b31a338ab30bf5daed84b
https://github.com/legendecas
legendecashttps://github.com/legendecas
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 25, 2023https://github.com/nodejs/node/pull/48450#event-9628474770
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 25, 2023https://github.com/nodejs/node/pull/48450#event-9628508242
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 25, 2023https://github.com/nodejs/node/pull/48450#issuecomment-1605845683
https://ci.nodejs.org/job/node-test-pull-request/52444/https://ci.nodejs.org/job/node-test-pull-request/52444/
Please reload this pagehttps://github.com/nodejs/node/pull/48450
https://github.com/legendecas
legendecashttps://github.com/legendecas
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jun 25, 2023https://github.com/nodejs/node/pull/48450#event-9628726782
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jun 25, 2023https://github.com/nodejs/node/pull/48450#event-9628751843
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
42d8143https://github.com/nodejs/node/commit/42d8143ce5baf5153a7a8d1bffa077209558a15d
Jun 25, 2023https://github.com/nodejs/node/pull/48450#event-9628751887
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 25, 2023https://github.com/nodejs/node/pull/48450#issuecomment-1605882461
42d8143https://github.com/nodejs/node/commit/42d8143ce5baf5153a7a8d1bffa077209558a15d
Please reload this pagehttps://github.com/nodejs/node/pull/48450
RafaelGSShttps://github.com/RafaelGSS
Jul 3, 2023 https://github.com/nodejs/node/pull/48450#ref-commit-30f4bc4
https://github.com/joyeecheung
https://github.com/RafaelGSS
test: make IsolateData per-isolate in cctesthttps://github.com/nodejs/node/commit/30f4bc49851718a42a7c75876fdb1d905ea76307
30f4bc4https://github.com/nodejs/node/commit/30f4bc49851718a42a7c75876fdb1d905ea76307
#48450https://github.com/nodejs/node/pull/48450
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Jul 3, 2023 https://github.com/nodejs/node/pull/48450#ref-pullrequest-1786245704
v20.4.0 proposal #48643 https://github.com/nodejs/node/pull/48643
Ceres6https://github.com/Ceres6
Aug 14, 2023 https://github.com/nodejs/node/pull/48450#ref-commit-57558d3
https://github.com/joyeecheung
https://github.com/Ceres6
test: make IsolateData per-isolate in cctesthttps://github.com/Ceres6/node/commit/57558d3f45b0f22f6b6c324bca08f2f4763d16b3
57558d3https://github.com/Ceres6/node/commit/57558d3f45b0f22f6b6c324bca08f2f4763d16b3
nodejs#48450https://github.com/nodejs/node/pull/48450
Ceres6https://github.com/Ceres6
Aug 14, 2023 https://github.com/nodejs/node/pull/48450#ref-commit-d40859a
https://github.com/joyeecheung
https://github.com/Ceres6
test: make IsolateData per-isolate in cctesthttps://github.com/Ceres6/node/commit/d40859a4523edc8bf500b2cc5bdf76e8320de662
d40859ahttps://github.com/Ceres6/node/commit/d40859a4523edc8bf500b2cc5bdf76e8320de662
nodejs#48450https://github.com/nodejs/node/pull/48450
ruyadornohttps://github.com/ruyadorno
Sep 10, 2023 https://github.com/nodejs/node/pull/48450#ref-commit-acd104d
https://github.com/joyeecheung
https://github.com/ruyadorno
test: make IsolateData per-isolate in cctesthttps://github.com/nodejs/node/commit/acd104d91101ee0b198af47b831641fc556e2292
acd104dhttps://github.com/nodejs/node/commit/acd104d91101ee0b198af47b831641fc556e2292
#48450https://github.com/nodejs/node/pull/48450
https://github.com/ruyadorno
ruyadornohttps://github.com/ruyadorno
Sep 10, 2023 https://github.com/nodejs/node/pull/48450#ref-pullrequest-1855772061
v18.18.0 proposal #49220 https://github.com/nodejs/node/pull/49220
ruyadornohttps://github.com/ruyadorno
Sep 13, 2023 https://github.com/nodejs/node/pull/48450#ref-commit-3ae96ae
https://github.com/joyeecheung
https://github.com/ruyadorno
test: make IsolateData per-isolate in cctesthttps://github.com/nodejs/node/commit/3ae96ae38082fcdbb915a0f2b548f68e2c627e14
3ae96aehttps://github.com/nodejs/node/commit/3ae96ae38082fcdbb915a0f2b548f68e2c627e14
#48450https://github.com/nodejs/node/pull/48450
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48450
https://github.com/legendecas
legendecas https://github.com/legendecas
https://github.com/nodejs/node/pull/48450/files/a5554434cbf070117d5b31a338ab30bf5daed84b
https://github.com/addaleax
addaleax https://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/48450
https://github.com/joyeecheung
https://github.com/nodejs-github-bot
https://github.com/legendecas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.