| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:49a159b1-2b6e-132b-79e1-360ef9a84fcd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B1A4:F40F2:B1E4D1:F25B20:6969E652 |
| html-safe-nonce | eccd2363d6fca6b0183932f0195e39019293359dab905b9b6b59d31bb4f2eb38 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMUE0OkY0MEYyOkIxRTREMTpGMjVCMjA6Njk2OUU2NTIiLCJ2aXNpdG9yX2lkIjoiMzQ3NDk1OTQ3NTc1NzY3MjAxOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a0515c57f4db5caee24f70c0b4fd3349521529ca3319d30d26eea6218531a56b |
| hovercard-subject-tag | pull_request:1383257551 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/48383/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c6f656695c71042af4ae19d004627e1734b7d4adfe8c295f5fcc05c91e6435c1/nodejs/node/pull/48383 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c6f656695c71042af4ae19d004627e1734b7d4adfe8c295f5fcc05c91e6435c1/nodejs/node/pull/48383 |
| og:image:alt | The connection checking interval should get cleared when https.Server.close is called similarly to how it gets cleared when http.Server.close is called. Note that this also adds a call to closeIdle... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Linkgoron |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/48383#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48383 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48383 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/48383 |
| Reload | https://github.com/nodejs/node/pull/48383 |
| Reload | https://github.com/nodejs/node/pull/48383 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/48383#issue-comment-box |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| Linkgoron:https-fix-uncleared-interval | https://github.com/Linkgoron/node/tree/https-fix-uncleared-interval |
|
https: fix connection checking interval not clearing on server close
| https://github.com/nodejs/node/pull/48383#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| Linkgoron:https-fix-uncleared-interval | https://github.com/Linkgoron/node/tree/https-fix-uncleared-interval |
|
Conversation
24
| https://github.com/nodejs/node/pull/48383 |
|
Commits
2
| https://github.com/nodejs/node/pull/48383/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/48383/checks |
|
Files changed
| https://github.com/nodejs/node/pull/48383/files |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Linkgoron |
| Linkgoron | https://github.com/Linkgoron |
| Jun 7, 2023 | https://github.com/nodejs/node/pull/48383#issue-1746548471 |
| #48373 | https://github.com/nodejs/node/issues/48373 |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
|
| https://github.com/Linkgoron |
| https: fix connection checking interval not clearing on server close | https://github.com/nodejs/node/pull/48383/commits/af60e03ece64156c89f0de6e50ef03fa6bd2ad5f |
| af60e03 | https://github.com/nodejs/node/pull/48383/commits/af60e03ece64156c89f0de6e50ef03fa6bd2ad5f |
| nodejs#48373 | https://github.com/nodejs/node/issues/48373 |
| https://github.com/Linkgoron |
| Linkgoron | https://github.com/Linkgoron |
| ShogunPanda | https://github.com/ShogunPanda |
| June 7, 2023 19:35 | https://github.com/nodejs/node/pull/48383#event-9463429019 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 7, 2023 | https://github.com/nodejs/node/pull/48383#issuecomment-1581400057 |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
https
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttps |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Jun 7, 2023 | https://github.com/nodejs/node/pull/48383#event-9463430827 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
|
Jun 7, 2023
| https://github.com/nodejs/node/pull/48383#pullrequestreview-1468441072 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/48383/files/af60e03ece64156c89f0de6e50ef03fa6bd2ad5f |
| marco-ippolito | https://github.com/marco-ippolito |
| https://github.com/nodejs/node/pull/48383#pullrequestreview-1468441072 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
| https://github.com/Linkgoron |
| Linkgoron | https://github.com/Linkgoron |
| Jun 7, 2023 | https://github.com/nodejs/node/pull/48383#issuecomment-1581438727 |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
| here | https://github.com/nodejs/node/pull/43522 |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Jun 7, 2023 | https://github.com/nodejs/node/pull/48383#issuecomment-1581466975 |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
| https://github.com/Linkgoron |
| Linkgoron | https://github.com/Linkgoron |
| Jun 7, 2023 | https://github.com/nodejs/node/pull/48383#issuecomment-1581489690 |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
| Jun 8, 2023 | https://github.com/nodejs/node/pull/48383#issuecomment-1582194196 |
| @marco-ippolito | https://github.com/marco-ippolito |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
|
| https://github.com/Linkgoron |
| fixup! https: fix connection checking interval not clearing on server… | https://github.com/nodejs/node/pull/48383/commits/d54d2aa7adfc94678faafec911d2222a6eed7990 |
| d54d2aa | https://github.com/nodejs/node/pull/48383/commits/d54d2aa7adfc94678faafec911d2222a6eed7990 |
| https://github.com/Linkgoron |
| Linkgoron | https://github.com/Linkgoron |
| Jun 8, 2023 | https://github.com/nodejs/node/pull/48383#issuecomment-1582281422 |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
| https://github.com/MoLow |
| MoLow | https://github.com/MoLow |
|
Jun 8, 2023
| https://github.com/nodejs/node/pull/48383#pullrequestreview-1469619852 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/48383/files/d54d2aa7adfc94678faafec911d2222a6eed7990 |
| MoLow | https://github.com/MoLow |
| https://github.com/nodejs/node/pull/48383#pullrequestreview-1469619852 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jun 8, 2023 | https://github.com/nodejs/node/pull/48383#event-9471029279 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jun 8, 2023 | https://github.com/nodejs/node/pull/48383#event-9471096321 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 8, 2023 | https://github.com/nodejs/node/pull/48383#issuecomment-1582367314 |
| https://ci.nodejs.org/job/node-test-pull-request/52162/ | https://ci.nodejs.org/job/node-test-pull-request/52162/ |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
|
Jun 8, 2023
| https://github.com/nodejs/node/pull/48383#pullrequestreview-1469669580 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/48383/files/d54d2aa7adfc94678faafec911d2222a6eed7990 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jun 8, 2023
| https://github.com/nodejs/node/pull/48383#pullrequestreview-1469673151 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/48383/files/d54d2aa7adfc94678faafec911d2222a6eed7990 |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/48383#pullrequestreview-1469673151 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jun 8, 2023 | https://github.com/nodejs/node/pull/48383#event-9471244522 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jun 8, 2023 | https://github.com/nodejs/node/pull/48383#event-9471289922 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 8, 2023 | https://github.com/nodejs/node/pull/48383#issuecomment-1582396228 |
| https://ci.nodejs.org/job/node-test-pull-request/52163/ | https://ci.nodejs.org/job/node-test-pull-request/52163/ |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jun 8, 2023
| https://github.com/nodejs/node/pull/48383#pullrequestreview-1470592717 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/48383/files/d54d2aa7adfc94678faafec911d2222a6eed7990 |
| test/parallel/test-http-server-close-destroy-timeout.js | https://github.com/nodejs/node/pull/48383/files/d54d2aa7adfc94678faafec911d2222a6eed7990#diff-47707645cefcf903a9c59457b4e820ede3d3e8d2f3332952fb84dfe955d3ae87 |
| lpinca | https://github.com/lpinca |
| Jun 8, 2023 | https://github.com/nodejs/node/pull/48383#discussion_r1223441791 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
| test/parallel/test-https-server-close-destroy-timeout.js | https://github.com/nodejs/node/pull/48383/files/d54d2aa7adfc94678faafec911d2222a6eed7990#diff-6be7c57e2462b8df959757644979f9753ff0b22f6b42e0a7f2f3a8a731b5095d |
| lpinca | https://github.com/lpinca |
| Jun 8, 2023 | https://github.com/nodejs/node/pull/48383#discussion_r1223441996 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jun 10, 2023
| https://github.com/nodejs/node/pull/48383#pullrequestreview-1473455226 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/48383/files/d54d2aa7adfc94678faafec911d2222a6eed7990 |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/48383#pullrequestreview-1473455226 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jun 10, 2023 | https://github.com/nodejs/node/pull/48383#event-9491631368 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jun 10, 2023 | https://github.com/nodejs/node/pull/48383#event-9491633997 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 10, 2023 | https://github.com/nodejs/node/pull/48383#issuecomment-1585805984 |
| https://ci.nodejs.org/job/node-test-pull-request/52195/ | https://ci.nodejs.org/job/node-test-pull-request/52195/ |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
|
commit-queue-squash
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Jun 10, 2023 | https://github.com/nodejs/node/pull/48383#event-9491700229 |
| RafaelGSS | https://github.com/RafaelGSS |
|
Jul 3, 2023
| https://github.com/nodejs/node/pull/48383#ref-commit-40ae6eb |
|
| https://github.com/Linkgoron |
|
| https://github.com/RafaelGSS |
| https: fix connection checking interval not clearing on server close | https://github.com/nodejs/node/commit/40ae6eb6aaa7c131ed5eb1f09e5080d15aa25f61 |
| 40ae6eb | https://github.com/nodejs/node/commit/40ae6eb6aaa7c131ed5eb1f09e5080d15aa25f61 |
| #48373 | https://github.com/nodejs/node/issues/48373 |
| #48383 | https://github.com/nodejs/node/pull/48383 |
| https://github.com/RafaelGSS |
| RafaelGSS | https://github.com/RafaelGSS |
|
Jul 3, 2023
| https://github.com/nodejs/node/pull/48383#ref-pullrequest-1786245704 |
|
v20.4.0 proposal
#48643
| https://github.com/nodejs/node/pull/48643 |
| https://github.com/trevor-scheer |
| trevor-scheer | https://github.com/trevor-scheer |
|
Jul 21, 2023
| https://github.com/nodejs/node/pull/48383#ref-pullrequest-1797660755 |
|
Test against Node 20, update tests for compatibility
apollographql/apollo-server#7636
| https://github.com/apollographql/apollo-server/pull/7636 |
| Ceres6 | https://github.com/Ceres6 |
|
Aug 14, 2023
| https://github.com/nodejs/node/pull/48383#ref-commit-8481c13 |
|
| https://github.com/Linkgoron |
|
| https://github.com/Ceres6 |
| https: fix connection checking interval not clearing on server close | https://github.com/Ceres6/node/commit/8481c13e69c7f17f3519cf78257161b427538953 |
| 8481c13 | https://github.com/Ceres6/node/commit/8481c13e69c7f17f3519cf78257161b427538953 |
| nodejs#48373 | https://github.com/nodejs/node/issues/48373 |
| nodejs#48383 | https://github.com/nodejs/node/pull/48383 |
| Ceres6 | https://github.com/Ceres6 |
|
Aug 14, 2023
| https://github.com/nodejs/node/pull/48383#ref-commit-8e59d48 |
|
| https://github.com/Linkgoron |
|
| https://github.com/Ceres6 |
| https: fix connection checking interval not clearing on server close | https://github.com/Ceres6/node/commit/8e59d48bf828c7b9aef12a26e061f0b7d31d7f02 |
| 8e59d48 | https://github.com/Ceres6/node/commit/8e59d48bf828c7b9aef12a26e061f0b7d31d7f02 |
| nodejs#48373 | https://github.com/nodejs/node/issues/48373 |
| nodejs#48383 | https://github.com/nodejs/node/pull/48383 |
| ruyadorno | https://github.com/ruyadorno |
|
Sep 7, 2023
| https://github.com/nodejs/node/pull/48383#ref-commit-2fd05a0 |
|
| https://github.com/Linkgoron |
|
| https://github.com/ruyadorno |
| https: fix connection checking interval not clearing on server close | https://github.com/nodejs/node/commit/2fd05a045aa8d09948d391eb0b9397a4aad44a25 |
| 2fd05a0 | https://github.com/nodejs/node/commit/2fd05a045aa8d09948d391eb0b9397a4aad44a25 |
| #48373 | https://github.com/nodejs/node/issues/48373 |
| #48383 | https://github.com/nodejs/node/pull/48383 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
|
Sep 8, 2023
| https://github.com/nodejs/node/pull/48383#ref-pullrequest-1855772061 |
|
v18.18.0 proposal
#49220
| https://github.com/nodejs/node/pull/49220 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
| Sep 12, 2023 | https://github.com/nodejs/node/pull/48383#issuecomment-1715904501 |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
|
backport-requested-v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v18.x |
| Sep 12, 2023 | https://github.com/nodejs/node/pull/48383#event-10348175752 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Sep 12, 2023 | https://github.com/nodejs/node/pull/48383#issuecomment-1715906313 |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
|
Sep 12, 2023
| https://github.com/nodejs/node/pull/48383#ref-pullrequest-1773410937 |
|
http, https, http2: Server add Symbol.asyncDispose
#48548
| https://github.com/nodejs/node/pull/48548 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
| Sep 12, 2023 | https://github.com/nodejs/node/pull/48383#issuecomment-1716191991 |
| @mcollina | https://github.com/mcollina |
| https://ci.nodejs.org/job/citgm-smoker/3229/ | https://ci.nodejs.org/job/citgm-smoker/3229/ |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
| Sep 13, 2023 | https://github.com/nodejs/node/pull/48383#issuecomment-1716797388 |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
| https://ci.nodejs.org/job/citgm-smoker/3237/ | https://ci.nodejs.org/job/citgm-smoker/3237/ |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
| sparist | https://github.com/sparist |
|
Sep 13, 2023
| https://github.com/nodejs/node/pull/48383#ref-commit-98d83ce |
|
| https://github.com/Linkgoron |
|
| https://github.com/sparist |
| https: fix connection checking interval not clearing on server close | https://github.com/Distributive-Network/node/commit/98d83ce972c45c0e4cba3d0c8d9da469b4f66b14 |
| 98d83ce | https://github.com/Distributive-Network/node/commit/98d83ce972c45c0e4cba3d0c8d9da469b4f66b14 |
| nodejs#48373 | https://github.com/nodejs/node/issues/48373 |
| nodejs#48383 | https://github.com/nodejs/node/pull/48383 |
| sparist | https://github.com/sparist |
|
Sep 13, 2023
| https://github.com/nodejs/node/pull/48383#ref-commit-4fd8cd6 |
|
| https://github.com/Linkgoron |
|
| https://github.com/sparist |
| https: fix connection checking interval not clearing on server close | https://github.com/Distributive-Network/node/commit/4fd8cd69c0f4e050c8d466b60f319640fa6398e5 |
| 4fd8cd6 | https://github.com/Distributive-Network/node/commit/4fd8cd69c0f4e050c8d466b60f319640fa6398e5 |
| nodejs#48373 | https://github.com/nodejs/node/issues/48373 |
| nodejs#48383 | https://github.com/nodejs/node/pull/48383 |
| H4ad | https://github.com/H4ad |
|
Sep 14, 2023
| https://github.com/nodejs/node/pull/48383#ref-commit-5cc90db |
|
| https://github.com/Linkgoron |
|
| https://github.com/H4ad |
| https: fix connection checking interval not clearing on server close | https://github.com/H4ad/node/commit/5cc90db3560a28469b6df6f3ab4cfebbccbfa744 |
| 5cc90db | https://github.com/H4ad/node/commit/5cc90db3560a28469b6df6f3ab4cfebbccbfa744 |
| nodejs#48373 | https://github.com/nodejs/node/issues/48373 |
| nodejs#48383 | https://github.com/nodejs/node/pull/48383 |
|
HTTP Server close is taking up to 5 seconds in node 18
#50188
| https://github.com/nodejs/node/issues/50188 |
|
fetch will always hang up about 4s
nodejs/undici#2348
| https://github.com/nodejs/undici/issues/2348 |
| https://github.com/H4ad |
| H4ad | https://github.com/H4ad |
|
Oct 16, 2023
| https://github.com/nodejs/node/pull/48383#ref-pullrequest-1944205468 |
|
[v18.x backport] https: fix connection checking interval not clearing on server close
#50194
| https://github.com/nodejs/node/pull/50194 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
backported-to-v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v18.x |
|
backport-requested-v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v18.x |
| Nov 27, 2023 | https://github.com/nodejs/node/pull/48383#event-11069577654 |
| targos | https://github.com/targos |
|
Nov 27, 2023
| https://github.com/nodejs/node/pull/48383#ref-commit-2969722 |
|
| https://github.com/Linkgoron |
|
| https://github.com/targos |
| https: fix connection checking interval not clearing on server close | https://github.com/nodejs/node/commit/29697229b61a8cbdf12e6abe0cbaa9fecc9a5102 |
| 2969722 | https://github.com/nodejs/node/commit/29697229b61a8cbdf12e6abe0cbaa9fecc9a5102 |
| #48373 | https://github.com/nodejs/node/issues/48373 |
| #48383 | https://github.com/nodejs/node/pull/48383 |
| #50194 | https://github.com/nodejs/node/pull/50194 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Nov 28, 2023
| https://github.com/nodejs/node/pull/48383#ref-pullrequest-2014162105 |
|
v18.19.0 release proposal
#50953
| https://github.com/nodejs/node/pull/50953 |
| https://github.com/jsumners |
| jsumners | https://github.com/jsumners |
|
Dec 9, 2023
| https://github.com/nodejs/node/pull/48383#ref-issue-2033300771 |
|
CI failure with v18.19.0
fastify/fastify#5198
| https://github.com/fastify/fastify/issues/5198 |
| https://github.com/kumarrishav |
| kumarrishav | https://github.com/kumarrishav |
| Apr 2, 2024 | https://github.com/nodejs/node/pull/48383#issuecomment-2032828502 |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
| #52330 | https://github.com/nodejs/node/issues/52330 |
| @mcollina | https://github.com/mcollina |
| @ShogunPanda | https://github.com/ShogunPanda |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
| https://github.com/Linkgoron |
| Linkgoron | https://github.com/Linkgoron |
| Apr 2, 2024 | https://github.com/nodejs/node/pull/48383#issuecomment-2033094128 |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
| #52330 | https://github.com/nodejs/node/issues/52330 |
| @mcollina | https://github.com/mcollina |
| @ShogunPanda | https://github.com/ShogunPanda |
| here | https://github.com/nodejs/node/pull/43522 |
| #50194 | https://github.com/nodejs/node/pull/50194 |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
| https://github.com/kumarrishav |
| kumarrishav | https://github.com/kumarrishav |
|
Apr 2, 2024
| https://github.com/nodejs/node/pull/48383#ref-pullrequest-2221497685 |
|
[v18.x] http: remove closeIdleConnections function while calling server close
#52334
| https://github.com/nodejs/node/pull/52334 |
| sercher | https://github.com/sercher |
|
Apr 25, 2024
| https://github.com/nodejs/node/pull/48383#ref-commit-332ad91 |
|
| https://github.com/sercher |
| https: fix connection checking interval not clearing on | https://github.com/sercher/graaljs/commit/332ad917a8b05068cda1177c15d05d644543d5ed |
| 332ad91 | https://github.com/sercher/graaljs/commit/332ad917a8b05068cda1177c15d05d644543d5ed |
| nodejs/node#48373 | https://github.com/nodejs/node/issues/48373 |
| nodejs/node#48383 | https://github.com/nodejs/node/pull/48383 |
| nodejs/node#50194 | https://github.com/nodejs/node/pull/50194 |
| sercher | https://github.com/sercher |
|
Apr 25, 2024
| https://github.com/nodejs/node/pull/48383#ref-commit-f12e1c1 |
|
| https://github.com/sercher |
| https: fix connection checking interval not clearing on | https://github.com/sercher/graaljs/commit/f12e1c16f11c6fe03f13295feb75341eeecdb346 |
| f12e1c1 | https://github.com/sercher/graaljs/commit/f12e1c16f11c6fe03f13295feb75341eeecdb346 |
| nodejs/node#48373 | https://github.com/nodejs/node/issues/48373 |
| nodejs/node#48383 | https://github.com/nodejs/node/pull/48383 |
| nodejs/node#50194 | https://github.com/nodejs/node/pull/50194 |
| https://github.com/michael42 |
| michael42 | https://github.com/michael42 |
|
Apr 26, 2024
| https://github.com/nodejs/node/pull/48383#ref-issue-2120296339 |
|
http.server.close() closes idle connections since 18.19.0
#51677
| https://github.com/nodejs/node/issues/51677 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48383 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/48383/files/d54d2aa7adfc94678faafec911d2222a6eed7990 |
|
| https://github.com/ShogunPanda |
|
ShogunPanda
| https://github.com/ShogunPanda |
|
| https://github.com/nodejs/node/pull/48383/files/d54d2aa7adfc94678faafec911d2222a6eed7990 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/48383/files/d54d2aa7adfc94678faafec911d2222a6eed7990 |
|
| https://github.com/JungMinu |
|
JungMinu
| https://github.com/JungMinu |
|
| https://github.com/nodejs/node/pull/48383/files/d54d2aa7adfc94678faafec911d2222a6eed7990 |
|
| https://github.com/MoLow |
|
MoLow
| https://github.com/MoLow |
|
| https://github.com/nodejs/node/pull/48383/files/d54d2aa7adfc94678faafec911d2222a6eed7990 |
|
| https://github.com/marco-ippolito |
|
marco-ippolito
| https://github.com/marco-ippolito |
|
| https://github.com/nodejs/node/pull/48383/files/d54d2aa7adfc94678faafec911d2222a6eed7990 |
|
commit-queue-squash
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
https
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttps |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
https.Server does not call http.close
| https://github.com/nodejs/node/issues/48373 |
| Please reload this page | https://github.com/nodejs/node/pull/48383 |
|
| https://github.com/Linkgoron |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mscdex |
|
| https://github.com/ShogunPanda |
|
| https://github.com/ruyadorno |
|
| https://github.com/mcollina |
|
| https://github.com/kumarrishav |
|
| https://github.com/lpinca |
|
| https://github.com/JungMinu |
|
| https://github.com/MoLow |
|
| https://github.com/marco-ippolito |
|
| https://github.com/targos |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |