René's URL Explorer Experiment


Title: test: define NAPI_VERSION before including node_api.h by legendecas · Pull Request #48376 · nodejs/node · GitHub

Open Graph Title: test: define NAPI_VERSION before including node_api.h by legendecas · Pull Request #48376 · nodejs/node

X Title: test: define NAPI_VERSION before including node_api.h by legendecas · Pull Request #48376 · nodejs/node

Description: Include node.h first to define NAPI_VERSION that node binary is built with. The node.h should also be included first in embedder's use case since it is the primary header file. Fixes #48310

Open Graph Description: Include node.h first to define NAPI_VERSION that node binary is built with. The node.h should also be included first in embedder's use case since it is the primary header file. Fixes #48310

X Description: Include node.h first to define NAPI_VERSION that node binary is built with. The node.h should also be included first in embedder's use case since it is the primary header file. Fixes #48310

Opengraph URL: https://github.com/nodejs/node/pull/48376

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9d498227-eaf8-a7ff-4c15-343aae5237e1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC512:2D0964:8F213A:C51121:6969EA9F
html-safe-nonce51b5ae67d1d18dd29c55886b67ceb26622624d78c2dadda68f3b2e5935bae02d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTEyOjJEMDk2NDo4RjIxM0E6QzUxMTIxOjY5NjlFQTlGIiwidmlzaXRvcl9pZCI6IjMyMzc0MzgxNDIwODcyOTM2MDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6a4a7980fd6683d3acad7aae1a6b48337fd9a3b7f27bb7047cd3246137ba9031
hovercard-subject-tagpull_request:1382567293
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/48376/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c6eab6f2a0ca3314280f75af9385d491a6fc0bc7d1e754f83e3791eae59880da/nodejs/node/pull/48376
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c6eab6f2a0ca3314280f75af9385d491a6fc0bc7d1e754f83e3791eae59880da/nodejs/node/pull/48376
og:image:altInclude node.h first to define NAPI_VERSION that node binary is built with. The node.h should also be included first in embedder's use case since it is the primary header file. Fixes #48310
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelegendecas
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/48376#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48376
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48376
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/48376
Reloadhttps://github.com/nodejs/node/pull/48376
Reloadhttps://github.com/nodejs/node/pull/48376
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/48376
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/48376
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/48376#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
legendecas:node-api/include-orderhttps://github.com/legendecas/node/tree/node-api/include-order
test: define NAPI_VERSION before including node_api.h https://github.com/nodejs/node/pull/48376#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
legendecas:node-api/include-orderhttps://github.com/legendecas/node/tree/node-api/include-order
Conversation 6 https://github.com/nodejs/node/pull/48376
Commits 1 https://github.com/nodejs/node/pull/48376/commits
Checks 0 https://github.com/nodejs/node/pull/48376/checks
Files changed https://github.com/nodejs/node/pull/48376/files
Please reload this pagehttps://github.com/nodejs/node/pull/48376
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/legendecas
legendecashttps://github.com/legendecas
Jun 7, 2023https://github.com/nodejs/node/pull/48376#issue-1745775888
#48310https://github.com/nodejs/node/issues/48310
Please reload this pagehttps://github.com/nodejs/node/pull/48376
https://github.com/legendecas
test: define NAPI_VERSION before including node_api.hhttps://github.com/nodejs/node/pull/48376/commits/d86ec94d65da815a8b90257620602b4c5ba00b09
d86ec94https://github.com/nodejs/node/pull/48376/commits/d86ec94d65da815a8b90257620602b4c5ba00b09
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Jun 7, 2023https://github.com/nodejs/node/pull/48376#event-9458423393
https://github.com/legendecas
legendecashttps://github.com/legendecas
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Jun 7, 2023https://github.com/nodejs/node/pull/48376#event-9458425688
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jun 10, 2023 https://github.com/nodejs/node/pull/48376#pullrequestreview-1473493171
View reviewed changes https://github.com/nodejs/node/pull/48376/files/d86ec94d65da815a8b90257620602b4c5ba00b09
https://github.com/legendecas
legendecashttps://github.com/legendecas
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 12, 2023https://github.com/nodejs/node/pull/48376#event-9498128915
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 12, 2023https://github.com/nodejs/node/pull/48376#event-9498185710
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 12, 2023https://github.com/nodejs/node/pull/48376#issuecomment-1586690006
https://ci.nodejs.org/job/node-test-pull-request/52219/https://ci.nodejs.org/job/node-test-pull-request/52219/
Please reload this pagehttps://github.com/nodejs/node/pull/48376
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jun 16, 2023 https://github.com/nodejs/node/pull/48376#pullrequestreview-1483806369
View reviewed changes https://github.com/nodejs/node/pull/48376/files/d86ec94d65da815a8b90257620602b4c5ba00b09
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/48376#pullrequestreview-1483806369
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/48376
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 23, 2023https://github.com/nodejs/node/pull/48376#event-9618875323
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 23, 2023https://github.com/nodejs/node/pull/48376#event-9618975224
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 23, 2023https://github.com/nodejs/node/pull/48376#issuecomment-1604438230
https://ci.nodejs.org/job/node-test-pull-request/52399/https://ci.nodejs.org/job/node-test-pull-request/52399/
Please reload this pagehttps://github.com/nodejs/node/pull/48376
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jun 24, 2023 https://github.com/nodejs/node/pull/48376#ref-issue-1772339022
CI Reliability 2023-06-24 nodejs/reliability#597 https://github.com/nodejs/reliability/issues/597
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 24, 2023https://github.com/nodejs/node/pull/48376#issuecomment-1605297784
https://ci.nodejs.org/job/node-test-pull-request/52416/https://ci.nodejs.org/job/node-test-pull-request/52416/
Please reload this pagehttps://github.com/nodejs/node/pull/48376
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 24, 2023https://github.com/nodejs/node/pull/48376#issuecomment-1605366601
https://ci.nodejs.org/job/node-test-pull-request/52422/https://ci.nodejs.org/job/node-test-pull-request/52422/
Please reload this pagehttps://github.com/nodejs/node/pull/48376
https://github.com/legendecas
legendecashttps://github.com/legendecas
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jun 24, 2023https://github.com/nodejs/node/pull/48376#event-9627370697
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jun 24, 2023https://github.com/nodejs/node/pull/48376#event-9627396976
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
e7a1fabhttps://github.com/nodejs/node/commit/e7a1fab25f7be9fc470aae4927b910d2b75e37dc
Jun 24, 2023https://github.com/nodejs/node/pull/48376#event-9627397117
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 24, 2023https://github.com/nodejs/node/pull/48376#issuecomment-1605653127
e7a1fabhttps://github.com/nodejs/node/commit/e7a1fab25f7be9fc470aae4927b910d2b75e37dc
Please reload this pagehttps://github.com/nodejs/node/pull/48376
https://github.com/legendecas
legendecashttps://github.com/legendecas
June 24, 2023 17:55https://github.com/nodejs/node/pull/48376#event-9627488522
CI Reliability 2023-06-25 nodejs/reliability#598 https://github.com/nodejs/reliability/issues/598
CI Reliability 2023-06-26 nodejs/reliability#599 https://github.com/nodejs/reliability/issues/599
CI Reliability 2023-06-27 nodejs/reliability#600 https://github.com/nodejs/reliability/issues/600
RafaelGSShttps://github.com/RafaelGSS
Jul 3, 2023 https://github.com/nodejs/node/pull/48376#ref-commit-407ce3f
https://github.com/legendecas
https://github.com/RafaelGSS
test: define NAPI_VERSION before including node_api.hhttps://github.com/nodejs/node/commit/407ce3fdcb17eee98fc4f22f5dbddd7302a6d055
407ce3fhttps://github.com/nodejs/node/commit/407ce3fdcb17eee98fc4f22f5dbddd7302a6d055
#48376https://github.com/nodejs/node/pull/48376
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Jul 3, 2023 https://github.com/nodejs/node/pull/48376#ref-pullrequest-1786245704
v20.4.0 proposal #48643 https://github.com/nodejs/node/pull/48643
Ceres6https://github.com/Ceres6
Aug 14, 2023 https://github.com/nodejs/node/pull/48376#ref-commit-abe8d1c
https://github.com/legendecas
https://github.com/Ceres6
test: define NAPI_VERSION before including node_api.hhttps://github.com/Ceres6/node/commit/abe8d1c9b2d1f2db9be94b3c7887bb279c32873b
abe8d1chttps://github.com/Ceres6/node/commit/abe8d1c9b2d1f2db9be94b3c7887bb279c32873b
nodejs#48376https://github.com/nodejs/node/pull/48376
Ceres6https://github.com/Ceres6
Aug 14, 2023 https://github.com/nodejs/node/pull/48376#ref-commit-45e7ba4
https://github.com/legendecas
https://github.com/Ceres6
test: define NAPI_VERSION before including node_api.hhttps://github.com/Ceres6/node/commit/45e7ba447294e75299ca96184adfff315856a85d
45e7ba4https://github.com/Ceres6/node/commit/45e7ba447294e75299ca96184adfff315856a85d
nodejs#48376https://github.com/nodejs/node/pull/48376
ruyadornohttps://github.com/ruyadorno
Sep 10, 2023 https://github.com/nodejs/node/pull/48376#ref-commit-73fdd37
https://github.com/legendecas
https://github.com/ruyadorno
test: define NAPI_VERSION before including node_api.hhttps://github.com/nodejs/node/commit/73fdd374eeffa150972271e0de91b822cd26b324
73fdd37https://github.com/nodejs/node/commit/73fdd374eeffa150972271e0de91b822cd26b324
#48376https://github.com/nodejs/node/pull/48376
https://github.com/ruyadorno
ruyadornohttps://github.com/ruyadorno
Sep 10, 2023 https://github.com/nodejs/node/pull/48376#ref-pullrequest-1855772061
v18.18.0 proposal #49220 https://github.com/nodejs/node/pull/49220
ruyadornohttps://github.com/ruyadorno
Sep 13, 2023 https://github.com/nodejs/node/pull/48376#ref-commit-f2ce8e0
https://github.com/legendecas
https://github.com/ruyadorno
test: define NAPI_VERSION before including node_api.hhttps://github.com/nodejs/node/commit/f2ce8e0c06f675ab1155142d5bac9a8b378b24a2
f2ce8e0https://github.com/nodejs/node/commit/f2ce8e0c06f675ab1155142d5bac9a8b378b24a2
#48376https://github.com/nodejs/node/pull/48376
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48376
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/48376/files/d86ec94d65da815a8b90257620602b4c5ba00b09
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/48376/files/d86ec94d65da815a8b90257620602b4c5ba00b09
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
NAPI_VERSION redefined https://github.com/nodejs/node/issues/48310
Please reload this pagehttps://github.com/nodejs/node/pull/48376
https://github.com/legendecas
https://github.com/nodejs-github-bot
https://github.com/lpinca
https://github.com/mhdawson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.