| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:9ab717e2-7934-c7a9-ddd0-24035b7bbd24 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8D6A:2786B7:E29673:1357952:6969EF29 |
| html-safe-nonce | 09f2b93c5bcb8fcd430dfae3fa39c264785ecd53655b32d8b81c7fc0aad2bee9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDZBOjI3ODZCNzpFMjk2NzM6MTM1Nzk1Mjo2OTY5RUYyOSIsInZpc2l0b3JfaWQiOiI3NzYxMDc3NDQyNjE1ODMyMzYxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c828763ffb2d286d3ea0b0a8ba2db4d321856dac3230ced2fa6efd7a419d10d3 |
| hovercard-subject-tag | pull_request:1379043962 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/48345/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0e0f2eb3a396423ad6568f36e65e2ac4c2a083573e539d1879ebd854d7d5ffd0/nodejs/node/pull/48345 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0e0f2eb3a396423ad6568f36e65e2ac4c2a083573e539d1879ebd854d7d5ffd0/nodejs/node/pull/48345 |
| og:image:alt | All of the backports below are somehow related to each other and that's why it resulted into a huge back port
Fixes #48343
Fixes #48117
Fixes #48621
Backports
test: update web-platform tests ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | anonrig |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/48345#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48345 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48345 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/48345 |
| Reload | https://github.com/nodejs/node/pull/48345 |
| Reload | https://github.com/nodejs/node/pull/48345 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/48345 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/48345 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/48345#issue-comment-box |
| anonrig | https://github.com/anonrig |
| nodejs:v18.x-staging | https://github.com/nodejs/node/tree/v18.x-staging |
| anonrig:backport-ada-v2-to-v18.x | https://github.com/anonrig/node/tree/backport-ada-v2-to-v18.x |
|
[v18.x] backport Ada v2.x to Node.js v18
| https://github.com/nodejs/node/pull/48345#top |
| anonrig | https://github.com/anonrig |
| nodejs:v18.x-staging | https://github.com/nodejs/node/tree/v18.x-staging |
| anonrig:backport-ada-v2-to-v18.x | https://github.com/anonrig/node/tree/backport-ada-v2-to-v18.x |
|
Conversation
28
| https://github.com/nodejs/node/pull/48345 |
|
Commits
20
| https://github.com/nodejs/node/pull/48345/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/48345/checks |
|
Files changed
| https://github.com/nodejs/node/pull/48345/files |
| Please reload this page | https://github.com/nodejs/node/pull/48345 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| Jun 5, 2023 | https://github.com/nodejs/node/pull/48345#issue-1741827032 |
| Please reload this page | https://github.com/nodejs/node/pull/48345 |
| #48343 | https://github.com/nodejs/node/issues/48343 |
| #48117 | https://github.com/nodejs/node/issues/48117 |
| #48621 | https://github.com/nodejs/node/issues/48621 |
| test: update web-platform tests for url #46860 | https://github.com/nodejs/node/pull/46860 |
| url: offload URLSearchParams initialization #46867 | https://github.com/nodejs/node/pull/46867 |
| url: set formatUrl method as no side effect #46884 | https://github.com/nodejs/node/pull/46884 |
| url: use private properties for brand check #46904 | https://github.com/nodejs/node/pull/46904 |
| url: allow extension of user provided URL objects #46989 | https://github.com/nodejs/node/pull/46989 |
| url: fix array overrun in node:url::SetArgs() #47001 | https://github.com/nodejs/node/pull/47001 |
| src: use std::array for passing argv in node::url #47035 | https://github.com/nodejs/node/pull/47035 |
| test: update URL web-platform-tests #47135 | https://github.com/nodejs/node/pull/47135 |
| url: implement URL.canParse #47179 | https://github.com/nodejs/node/pull/47179 |
| url: use ada::url_aggregator for parsing urls #47339 | https://github.com/nodejs/node/pull/47339 |
| url: handle URL.canParse without base parameter #47547 | https://github.com/nodejs/node/pull/47547 |
| deps: update ada to 2.1.0 #47598 | https://github.com/nodejs/node/pull/47598 |
| deps: update ada to 2.2.0 #47678 | https://github.com/nodejs/node/pull/47678 |
| deps: update ada to 2.3.0 #47737 | https://github.com/nodejs/node/pull/47737 |
| deps: update ada to 2.3.1 #47893 | https://github.com/nodejs/node/pull/47893 |
| deps: update ada to 2.4.0 #47922 | https://github.com/nodejs/node/pull/47922 |
| deps: update ada to 2.4.1 #48036 | https://github.com/nodejs/node/pull/48036 |
| deps: update ada to 2.4.2 #48092 | https://github.com/nodejs/node/pull/48092 |
| deps: update ada to 2.5.0 #48223 | https://github.com/nodejs/node/pull/48223 |
| Please reload this page | https://github.com/nodejs/node/pull/48345 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 5, 2023 | https://github.com/nodejs/node/pull/48345#issuecomment-1576838688 |
| Please reload this page | https://github.com/nodejs/node/pull/48345 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av18.x |
|
whatwg-url
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awhatwg-url |
| Jun 5, 2023 | https://github.com/nodejs/node/pull/48345#event-9433685463 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| June 5, 2023 14:43 | https://github.com/nodejs/node/pull/48345#event-9434506184 |
| https://github.com/anonrig |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48345 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| RafaelGSS | https://github.com/RafaelGSS |
| danielleadams | https://github.com/danielleadams |
| ruyadorno | https://github.com/ruyadorno |
| targos | https://github.com/targos |
| June 5, 2023 14:46 | https://github.com/nodejs/node/pull/48345#event-9434539978 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| force-pushed | https://github.com/nodejs/node/compare/0015d4625988d501694ef9683d0717ed3d203797..8e1fe703caf885dff323712b60ec39dfd31624a0 |
| 0015d46 | https://github.com/nodejs/node/commit/0015d4625988d501694ef9683d0717ed3d203797 |
| 8e1fe70 | https://github.com/nodejs/node/commit/8e1fe703caf885dff323712b60ec39dfd31624a0 |
|
Compare
| https://github.com/nodejs/node/compare/0015d4625988d501694ef9683d0717ed3d203797..8e1fe703caf885dff323712b60ec39dfd31624a0 |
| June 5, 2023 14:55 | https://github.com/nodejs/node/pull/48345#event-9434668919 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Jun 5, 2023 | https://github.com/nodejs/node/pull/48345#issuecomment-1576970904 |
| #48036 | https://github.com/nodejs/node/pull/48036 |
| #48092 | https://github.com/nodejs/node/pull/48092 |
| #48223 | https://github.com/nodejs/node/pull/48223 |
| Please reload this page | https://github.com/nodejs/node/pull/48345 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| Jun 5, 2023 | https://github.com/nodejs/node/pull/48345#issuecomment-1576975931 |
| Please reload this page | https://github.com/nodejs/node/pull/48345 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| force-pushed | https://github.com/nodejs/node/compare/8e1fe703caf885dff323712b60ec39dfd31624a0..82221be2e522759b41e36db13e8006bfa4b7e127 |
| 8e1fe70 | https://github.com/nodejs/node/commit/8e1fe703caf885dff323712b60ec39dfd31624a0 |
| 82221be | https://github.com/nodejs/node/commit/82221be2e522759b41e36db13e8006bfa4b7e127 |
|
Compare
| https://github.com/nodejs/node/compare/8e1fe703caf885dff323712b60ec39dfd31624a0..82221be2e522759b41e36db13e8006bfa4b7e127 |
| June 5, 2023 15:48 | https://github.com/nodejs/node/pull/48345#event-9435402390 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jun 5, 2023 | https://github.com/nodejs/node/pull/48345#event-9435457385 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jun 5, 2023 | https://github.com/nodejs/node/pull/48345#event-9435566835 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 5, 2023 | https://github.com/nodejs/node/pull/48345#issuecomment-1577075188 |
| https://ci.nodejs.org/job/node-test-pull-request/52105/ | https://ci.nodejs.org/job/node-test-pull-request/52105/ |
| Please reload this page | https://github.com/nodejs/node/pull/48345 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Jun 6, 2023
| https://github.com/nodejs/node/pull/48345#ref-issue-1742848711 |
|
CI Reliability 2023-06-06
nodejs/reliability#587
| https://github.com/nodejs/reliability/issues/587 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Jun 6, 2023 | https://github.com/nodejs/node/pull/48345#issuecomment-1578828508 |
| @anonrig | https://github.com/anonrig |
| Please reload this page | https://github.com/nodejs/node/pull/48345 |
|
CI Reliability 2023-06-09
nodejs/reliability#588
| https://github.com/nodejs/reliability/issues/588 |
|
CI Reliability 2023-06-10
nodejs/reliability#589
| https://github.com/nodejs/reliability/issues/589 |
|
CI Reliability 2023-06-11
nodejs/reliability#590
| https://github.com/nodejs/reliability/issues/590 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| force-pushed | https://github.com/nodejs/node/compare/e51bc6c4d9d0f21d0b3e44e39cef58b85cc78b75..c335b741112717937b008989f439db54fb179e4e |
| e51bc6c | https://github.com/nodejs/node/commit/e51bc6c4d9d0f21d0b3e44e39cef58b85cc78b75 |
| c335b74 | https://github.com/nodejs/node/commit/c335b741112717937b008989f439db54fb179e4e |
|
Compare
| https://github.com/nodejs/node/compare/e51bc6c4d9d0f21d0b3e44e39cef58b85cc78b75..c335b741112717937b008989f439db54fb179e4e |
| June 17, 2023 02:35 | https://github.com/nodejs/node/pull/48345#event-9557464554 |
| https://github.com/RafaelGSS |
| RafaelGSS | https://github.com/RafaelGSS |
| force-pushed | https://github.com/nodejs/node/compare/b7493231e6827d41810b52235ced47a6fce29633..e5e385d2b234c21be642444c3397735b3a167dcb |
| b749323 | https://github.com/nodejs/node/commit/b7493231e6827d41810b52235ced47a6fce29633 |
| e5e385d | https://github.com/nodejs/node/commit/e5e385d2b234c21be642444c3397735b3a167dcb |
|
Compare
| https://github.com/nodejs/node/compare/b7493231e6827d41810b52235ced47a6fce29633..e5e385d2b234c21be642444c3397735b3a167dcb |
| June 20, 2023 20:25 | https://github.com/nodejs/node/pull/48345#event-9583957432 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| force-pushed | https://github.com/nodejs/node/compare/0f267b0c07875e4f97e3595375af9c371c6a48f2..2c34b15c25f9f2c5e427b4743f547e548805503c |
| 0f267b0 | https://github.com/nodejs/node/commit/0f267b0c07875e4f97e3595375af9c371c6a48f2 |
| 2c34b15 | https://github.com/nodejs/node/commit/2c34b15c25f9f2c5e427b4743f547e548805503c |
|
Compare
| https://github.com/nodejs/node/compare/0f267b0c07875e4f97e3595375af9c371c6a48f2..2c34b15c25f9f2c5e427b4743f547e548805503c |
| June 23, 2023 23:33 | https://github.com/nodejs/node/pull/48345#event-9623606552 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| Jun 24, 2023 | https://github.com/nodejs/node/pull/48345#issuecomment-1605181692 |
| https://ci.nodejs.org/job/node-test-pull-request/52413/ | https://ci.nodejs.org/job/node-test-pull-request/52413/ |
| Please reload this page | https://github.com/nodejs/node/pull/48345 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 11, 2023 | https://github.com/nodejs/node/pull/48345#issuecomment-1629920628 |
| https://ci.nodejs.org/job/node-test-pull-request/52688/ | https://ci.nodejs.org/job/node-test-pull-request/52688/ |
| Please reload this page | https://github.com/nodejs/node/pull/48345 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 11, 2023 | https://github.com/nodejs/node/pull/48345#issuecomment-1629920768 |
| https://ci.nodejs.org/job/node-test-pull-request/52689/ | https://ci.nodejs.org/job/node-test-pull-request/52689/ |
| Please reload this page | https://github.com/nodejs/node/pull/48345 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 11, 2023 | https://github.com/nodejs/node/pull/48345#issuecomment-1630583460 |
| https://ci.nodejs.org/job/node-test-pull-request/52694/ | https://ci.nodejs.org/job/node-test-pull-request/52694/ |
| Please reload this page | https://github.com/nodejs/node/pull/48345 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 12, 2023 | https://github.com/nodejs/node/pull/48345#issuecomment-1632401500 |
| https://ci.nodejs.org/job/node-test-pull-request/52722/ | https://ci.nodejs.org/job/node-test-pull-request/52722/ |
| Please reload this page | https://github.com/nodejs/node/pull/48345 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 12, 2023 | https://github.com/nodejs/node/pull/48345#issuecomment-1632512365 |
| https://ci.nodejs.org/job/node-test-pull-request/52728/ | https://ci.nodejs.org/job/node-test-pull-request/52728/ |
| Please reload this page | https://github.com/nodejs/node/pull/48345 |
| danielleadams | https://github.com/danielleadams |
|
Jul 12, 2023
| https://github.com/nodejs/node/pull/48345#ref-commit-3db235b |
|
| https://github.com/anonrig |
|
| https://github.com/danielleadams |
| url: remove unused kFormat from url | https://github.com/nodejs/node/commit/3db235b822294c3341bd563248867c136488f020 |
| 3db235b | https://github.com/nodejs/node/commit/3db235b822294c3341bd563248867c136488f020 |
| #46867 | https://github.com/nodejs/node/pull/46867 |
| #48345 | https://github.com/nodejs/node/pull/48345 |
| danielleadams | https://github.com/danielleadams |
|
Jul 12, 2023
| https://github.com/nodejs/node/pull/48345#ref-commit-c79e1b7 |
|
| https://github.com/anonrig |
|
| https://github.com/danielleadams |
| url: offload URLSearchParams initialization | https://github.com/nodejs/node/commit/c79e1b72f2e8e1634a403bc02c473d3c744caeda |
| c79e1b7 | https://github.com/nodejs/node/commit/c79e1b72f2e8e1634a403bc02c473d3c744caeda |
| #46867 | https://github.com/nodejs/node/pull/46867 |
| #48345 | https://github.com/nodejs/node/pull/48345 |
| danielleadams | https://github.com/danielleadams |
|
Jul 12, 2023
| https://github.com/nodejs/node/pull/48345#ref-commit-aa4f485 |
|
| https://github.com/anonrig |
|
| https://github.com/danielleadams |
| url: set formatUrl method as no side effect | https://github.com/nodejs/node/commit/aa4f485388f3ebd67693f4b76964afd588194dd1 |
| aa4f485 | https://github.com/nodejs/node/commit/aa4f485388f3ebd67693f4b76964afd588194dd1 |
| #46884 | https://github.com/nodejs/node/pull/46884 |
| #48345 | https://github.com/nodejs/node/pull/48345 |
| danielleadams | https://github.com/danielleadams |
|
Jul 12, 2023
| https://github.com/nodejs/node/pull/48345#ref-commit-f495cb6 |
|
| https://github.com/anonrig |
|
| https://github.com/danielleadams |
| url: backport non-major changes from | https://github.com/nodejs/node/commit/f495cb6bf48ba78c386c35e0a58e644e9c9a8048 |
| #46904 | https://github.com/nodejs/node/pull/46904 |
| f495cb6 | https://github.com/nodejs/node/commit/f495cb6bf48ba78c386c35e0a58e644e9c9a8048 |
| #46904 | https://github.com/nodejs/node/pull/46904 |
| #48345 | https://github.com/nodejs/node/pull/48345 |
| danielleadams | https://github.com/danielleadams |
|
Jul 12, 2023
| https://github.com/nodejs/node/pull/48345#ref-commit-4784e64 |
|
| https://github.com/aduh95 |
|
| https://github.com/danielleadams |
| url: allow extension of user provided URL objects | https://github.com/nodejs/node/commit/4784e648503fa99d3fcf0be6ab6684d5843496ff |
| 4784e64 | https://github.com/nodejs/node/commit/4784e648503fa99d3fcf0be6ab6684d5843496ff |
| #46989 | https://github.com/nodejs/node/pull/46989 |
| #48345 | https://github.com/nodejs/node/pull/48345 |
| #46981 | https://github.com/nodejs/node/issues/46981 |
| danielleadams | https://github.com/danielleadams |
|
Jul 12, 2023
| https://github.com/nodejs/node/pull/48345#ref-commit-977a8ba |
|
| https://github.com/anonrig |
|
| https://github.com/danielleadams |
| url: fix array overrun in node:url::SetArgs() | https://github.com/nodejs/node/commit/977a8bad35ef0969593210afe0446717be6e3b7b |
| 977a8ba | https://github.com/nodejs/node/commit/977a8bad35ef0969593210afe0446717be6e3b7b |
| #47001 | https://github.com/nodejs/node/pull/47001 |
| #48345 | https://github.com/nodejs/node/pull/48345 |
| danielleadams | https://github.com/danielleadams |
|
Jul 12, 2023
| https://github.com/nodejs/node/pull/48345#ref-commit-1f2c91f |
|
| https://github.com/addaleax |
|
| https://github.com/danielleadams |
| src: use std::array for passing argv in node::url | https://github.com/nodejs/node/commit/1f2c91f98a884a86747b52827fe09e860f2347ab |
| 1f2c91f | https://github.com/nodejs/node/commit/1f2c91f98a884a86747b52827fe09e860f2347ab |
| 72e971e | https://github.com/nodejs/node/commit/72e971ee2e7d1c974d69825c40bc9f29cdb4b1f9 |
| #47001 (comment) | https://github.com/nodejs/node/pull/47001#issuecomment-1462999332 |
| #47035 | https://github.com/nodejs/node/pull/47035 |
| #48345 | https://github.com/nodejs/node/pull/48345 |
| danielleadams | https://github.com/danielleadams |
|
Jul 12, 2023
| https://github.com/nodejs/node/pull/48345#ref-commit-11f48e0 |
|
| https://github.com/KhafraDev |
|
| https://github.com/danielleadams |
| url: implement URL.canParse | https://github.com/nodejs/node/commit/11f48e02a873d2067b10e4e9ce2e67debbbe29bb |
| 11f48e0 | https://github.com/nodejs/node/commit/11f48e02a873d2067b10e4e9ce2e67debbbe29bb |
| #47179 | https://github.com/nodejs/node/pull/47179 |
| #48345 | https://github.com/nodejs/node/pull/48345 |
| danielleadams | https://github.com/danielleadams |
|
Jul 12, 2023
| https://github.com/nodejs/node/pull/48345#ref-commit-96c50ba |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/danielleadams |
| deps: update ada to 2.0.0 | https://github.com/nodejs/node/commit/96c50ba71f24390a3367963d4d1a4ff94b2c340a |
| 96c50ba | https://github.com/nodejs/node/commit/96c50ba71f24390a3367963d4d1a4ff94b2c340a |
| #47339 | https://github.com/nodejs/node/pull/47339 |
| #48345 | https://github.com/nodejs/node/pull/48345 |
| danielleadams | https://github.com/danielleadams |
|
Jul 12, 2023
| https://github.com/nodejs/node/pull/48345#ref-commit-b395b16 |
|
| https://github.com/anonrig |
|
| https://github.com/danielleadams |
| url: use ada::url_aggregator for parsing urls | https://github.com/nodejs/node/commit/b395b16c40a87562d7c27e60b4e808f417cd2ffc |
| b395b16 | https://github.com/nodejs/node/commit/b395b16c40a87562d7c27e60b4e808f417cd2ffc |
| #47339 | https://github.com/nodejs/node/pull/47339 |
| #48345 | https://github.com/nodejs/node/pull/48345 |
| danielleadams | https://github.com/danielleadams |
|
Jul 12, 2023
| https://github.com/nodejs/node/pull/48345#ref-commit-0dc485e |
|
| https://github.com/anonrig |
|
| https://github.com/danielleadams |
| url: drop ICU requirement for parsing hostnames | https://github.com/nodejs/node/commit/0dc485eb28fb05eafad4dc78c646d917d8d4024a |
| 0dc485e | https://github.com/nodejs/node/commit/0dc485eb28fb05eafad4dc78c646d917d8d4024a |
| #47339 | https://github.com/nodejs/node/pull/47339 |
| #48345 | https://github.com/nodejs/node/pull/48345 |
| danielleadams | https://github.com/danielleadams |
|
Jul 12, 2023
| https://github.com/nodejs/node/pull/48345#ref-commit-8897305 |
|
| https://github.com/anonrig |
|
| https://github.com/danielleadams |
| url: handle URL.canParse without base parameter | https://github.com/nodejs/node/commit/889730512c2ccd8c28a2cb63465c3f59d9004f86 |
| 8897305 | https://github.com/nodejs/node/commit/889730512c2ccd8c28a2cb63465c3f59d9004f86 |
| #47547 | https://github.com/nodejs/node/pull/47547 |
| #48345 | https://github.com/nodejs/node/pull/48345 |
| danielleadams | https://github.com/danielleadams |
|
Jul 12, 2023
| https://github.com/nodejs/node/pull/48345#ref-commit-08dd271 |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/danielleadams |
| deps: update ada to 2.1.0 | https://github.com/nodejs/node/commit/08dd2715213b4885741019149946d4ccddb24d02 |
| 08dd271 | https://github.com/nodejs/node/commit/08dd2715213b4885741019149946d4ccddb24d02 |
| #47598 | https://github.com/nodejs/node/pull/47598 |
| #48345 | https://github.com/nodejs/node/pull/48345 |
| danielleadams | https://github.com/danielleadams |
|
Jul 12, 2023
| https://github.com/nodejs/node/pull/48345#ref-commit-42e690f |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/danielleadams |
| deps: update ada to 2.2.0 | https://github.com/nodejs/node/commit/42e690f2d5b91af0702fe23b380a0dd0dcfd11f7 |
| 42e690f | https://github.com/nodejs/node/commit/42e690f2d5b91af0702fe23b380a0dd0dcfd11f7 |
| #47678 | https://github.com/nodejs/node/pull/47678 |
| #48345 | https://github.com/nodejs/node/pull/48345 |
| danielleadams | https://github.com/danielleadams |
|
Jul 12, 2023
| https://github.com/nodejs/node/pull/48345#ref-commit-2d03d5f |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/danielleadams |
| deps: update ada to 2.3.0 | https://github.com/nodejs/node/commit/2d03d5f45803ba5cc4c7cd74db66f76fcc624657 |
| 2d03d5f | https://github.com/nodejs/node/commit/2d03d5f45803ba5cc4c7cd74db66f76fcc624657 |
| #47737 | https://github.com/nodejs/node/pull/47737 |
| #48345 | https://github.com/nodejs/node/pull/48345 |
| danielleadams | https://github.com/danielleadams |
|
Jul 12, 2023
| https://github.com/nodejs/node/pull/48345#ref-commit-575ddf6 |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/danielleadams |
| deps: update ada to 2.3.1 | https://github.com/nodejs/node/commit/575ddf694f8ff0f9941c1095afec6f2efec33bf6 |
| 575ddf6 | https://github.com/nodejs/node/commit/575ddf694f8ff0f9941c1095afec6f2efec33bf6 |
| #47893 | https://github.com/nodejs/node/pull/47893 |
| #48345 | https://github.com/nodejs/node/pull/48345 |
| danielleadams | https://github.com/danielleadams |
|
Jul 12, 2023
| https://github.com/nodejs/node/pull/48345#ref-commit-81b514d |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/danielleadams |
| deps: update ada to 2.4.0 | https://github.com/nodejs/node/commit/81b514d3f01de739cb3aed2ea6b862a68cf51aac |
| 81b514d | https://github.com/nodejs/node/commit/81b514d3f01de739cb3aed2ea6b862a68cf51aac |
| #47922 | https://github.com/nodejs/node/pull/47922 |
| #48345 | https://github.com/nodejs/node/pull/48345 |
| danielleadams | https://github.com/danielleadams |
|
Jul 12, 2023
| https://github.com/nodejs/node/pull/48345#ref-commit-a4ee1f6 |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/danielleadams |
| deps: update ada to 2.4.1 | https://github.com/nodejs/node/commit/a4ee1f652c701434da2fa3e3afe2290d0f60dffc |
| a4ee1f6 | https://github.com/nodejs/node/commit/a4ee1f652c701434da2fa3e3afe2290d0f60dffc |
| #48036 | https://github.com/nodejs/node/pull/48036 |
| #48345 | https://github.com/nodejs/node/pull/48345 |
| danielleadams | https://github.com/danielleadams |
|
Jul 12, 2023
| https://github.com/nodejs/node/pull/48345#ref-commit-075b6db |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/danielleadams |
| deps: update ada to 2.4.2 | https://github.com/nodejs/node/commit/075b6db919dfd62e7f8bfa32bbb0d6694c7abd79 |
| 075b6db | https://github.com/nodejs/node/commit/075b6db919dfd62e7f8bfa32bbb0d6694c7abd79 |
| #48092 | https://github.com/nodejs/node/pull/48092 |
| #48345 | https://github.com/nodejs/node/pull/48345 |
| danielleadams | https://github.com/danielleadams |
|
Jul 12, 2023
| https://github.com/nodejs/node/pull/48345#ref-commit-6f3a8b4 |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/danielleadams |
| deps: update ada to 2.5.0 | https://github.com/nodejs/node/commit/6f3a8b45a5f02aa87987a0a2ea48c74fefa9fcc6 |
| 6f3a8b4 | https://github.com/nodejs/node/commit/6f3a8b45a5f02aa87987a0a2ea48c74fefa9fcc6 |
| #48223 | https://github.com/nodejs/node/pull/48223 |
| #48345 | https://github.com/nodejs/node/pull/48345 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
| Jul 12, 2023 | https://github.com/nodejs/node/pull/48345#issuecomment-1632734978 |
| 5d910ca...6f3a8b4 | https://github.com/nodejs/node/compare/5d910ca389b3e1b956a3e888a710dff81b524958...6f3a8b45a5f02aa87987a0a2ea48c74fefa9fcc6 |
| Please reload this page | https://github.com/nodejs/node/pull/48345 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
| Jul 12, 2023 | https://github.com/nodejs/node/pull/48345#event-9800844879 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Jul 16, 2023
| https://github.com/nodejs/node/pull/48345#ref-issue-1806565710 |
|
CI Reliability 2023-07-16
nodejs/reliability#614
| https://github.com/nodejs/reliability/issues/614 |
| https://github.com/ckerr |
| ckerr | https://github.com/ckerr |
|
Jul 20, 2023
| https://github.com/nodejs/node/pull/48345#ref-pullrequest-1811897409 |
|
chore: bump node to v18.17.0 (main)
electron/electron#39154
| https://github.com/electron/electron/pull/39154 |
| https://github.com/MattIPv4 |
| MattIPv4 | https://github.com/MattIPv4 |
|
Aug 25, 2023
| https://github.com/nodejs/node/pull/48345#ref-issue-1867508611 |
|
url.parse regression in 18.17+
#49330
| https://github.com/nodejs/node/issues/49330 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48345 |
|
| https://github.com/RafaelGSS |
|
RafaelGSS
| https://github.com/RafaelGSS |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/ruyadorno |
|
ruyadorno
| https://github.com/ruyadorno |
|
| https://github.com/juanarbol |
|
juanarbol
| https://github.com/juanarbol |
|
| https://github.com/danielleadams |
|
danielleadams
| https://github.com/danielleadams |
|
| https://github.com/nodejs/node/pull/48345/files/054f9676f7a0a821ffd7ff5ae749082829e6f12c |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av18.x |
|
whatwg-url
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awhatwg-url |
| Please reload this page | https://github.com/nodejs/node/pull/48345 |
|
| https://github.com/anonrig |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/richardlau |
|
| https://github.com/juanarbol |
|
| https://github.com/targos |
|
| https://github.com/StefanStojanovic |
|
| https://github.com/danielleadams |
|
| https://github.com/aduh95 |
|
| https://github.com/addaleax |
|
| https://github.com/KhafraDev |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |