René's URL Explorer Experiment


Title: 48198 node api external strings by gabrielschulhof · Pull Request #48339 · nodejs/node · GitHub

Open Graph Title: 48198 node api external strings by gabrielschulhof · Pull Request #48339 · nodejs/node

X Title: 48198 node api external strings by gabrielschulhof · Pull Request #48339 · nodejs/node

Opengraph URL: https://github.com/nodejs/node/pull/48339

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:928026ce-b03f-f84e-08f2-a5427cca31f3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCB78:2DB2A9:A5A2E6:E44F1D:6969EF58
html-safe-nonce73792bc7cbb8f2fb8f8ca0185b061291611412100167186fc8ab443703dbddf5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjc4OjJEQjJBOTpBNUEyRTY6RTQ0RjFEOjY5NjlFRjU4IiwidmlzaXRvcl9pZCI6IjM5NDMyNjcxNzQ4MTY4MDQ2OTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca0b35220bf9fb56920ca54170b4377115b5f369424400868fdaff8bd44b121e4
hovercard-subject-tagpull_request:1378093564
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/48339/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/185170c8fb8e3f34f60a9676a71d44a124d6e539379f32c399250777d9ad157c/nodejs/node/pull/48339
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/185170c8fb8e3f34f60a9676a71d44a124d6e539379f32c399250777d9ad157c/nodejs/node/pull/48339
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegabrielschulhof
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/48339#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48339
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48339
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/48339
Reloadhttps://github.com/nodejs/node/pull/48339
Reloadhttps://github.com/nodejs/node/pull/48339
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/48339
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/48339
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/48339#issue-comment-box
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:mainhttps://github.com/nodejs/node/tree/main
gabrielschulhof:48198-node-api-external-stringshttps://github.com/gabrielschulhof/node/tree/48198-node-api-external-strings
48198 node api external strings https://github.com/nodejs/node/pull/48339#top
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:mainhttps://github.com/nodejs/node/tree/main
gabrielschulhof:48198-node-api-external-stringshttps://github.com/gabrielschulhof/node/tree/48198-node-api-external-strings
Conversation 34 https://github.com/nodejs/node/pull/48339
Commits 31 https://github.com/nodejs/node/pull/48339/commits
Checks 0 https://github.com/nodejs/node/pull/48339/checks
Files changed https://github.com/nodejs/node/pull/48339/files
Please reload this pagehttps://github.com/nodejs/node/pull/48339
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jun 5, 2023https://github.com/nodejs/node/pull/48339#issue-1740773919
Please reload this pagehttps://github.com/nodejs/node/pull/48339
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 5, 2023https://github.com/nodejs/node/pull/48339#issuecomment-1575945349
Please reload this pagehttps://github.com/nodejs/node/pull/48339
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jun 5, 2023https://github.com/nodejs/node/pull/48339#event-9426915682
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jun 5, 2023https://github.com/nodejs/node/pull/48339#event-9426915773
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Jun 5, 2023https://github.com/nodejs/node/pull/48339#event-9426916729
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jun 5, 2023 https://github.com/nodejs/node/pull/48339#pullrequestreview-1461849628
View reviewed changes https://github.com/nodejs/node/pull/48339/files
src/js_native_api_v8.cchttps://github.com/nodejs/node/pull/48339/files#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1
gabrielschulhofhttps://github.com/gabrielschulhof
Jun 5, 2023https://github.com/nodejs/node/pull/48339#discussion_r1217621721
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/48339
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jun 5, 2023 https://github.com/nodejs/node/pull/48339#pullrequestreview-1461850852
View reviewed changes https://github.com/nodejs/node/pull/48339/files
src/js_native_api_v8.cchttps://github.com/nodejs/node/pull/48339/files#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1
gabrielschulhofhttps://github.com/gabrielschulhof
Jun 5, 2023https://github.com/nodejs/node/pull/48339#discussion_r1217622454
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/48339
gabrielschulhofhttps://github.com/gabrielschulhof
Jun 7, 2023https://github.com/nodejs/node/pull/48339#discussion_r1221849386
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/48339
https://github.com/daeyeon
daeyeonhttps://github.com/daeyeon
Jun 5, 2023 https://github.com/nodejs/node/pull/48339#pullrequestreview-1462260137
View reviewed changes https://github.com/nodejs/node/pull/48339/files
src/js_native_api_v8.cchttps://github.com/nodejs/node/pull/48339/files#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1
Please reload this pagehttps://github.com/nodejs/node/pull/48339
src/js_native_api_v8.cchttps://github.com/nodejs/node/pull/48339/files#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1
Please reload this pagehttps://github.com/nodejs/node/pull/48339
src/js_native_api_v8.cchttps://github.com/nodejs/node/pull/48339/files#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1
Please reload this pagehttps://github.com/nodejs/node/pull/48339
src/js_native_api_v8.cchttps://github.com/nodejs/node/pull/48339/files#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1
Please reload this pagehttps://github.com/nodejs/node/pull/48339
gabrielschulhofhttps://github.com/gabrielschulhof
June 7, 2023 07:21https://github.com/nodejs/node/pull/48339#commits-pushed-bd8045b
https://github.com/gabrielschulhof
node-api: unify string creationhttps://github.com/nodejs/node/pull/48339/commits/bd8045b2e2ef77d5f7486dc5d3d6e5f640397a27
bd8045bhttps://github.com/nodejs/node/pull/48339/commits/bd8045b2e2ef77d5f7486dc5d3d6e5f640397a27
https://github.com/gabrielschulhof
node-api: add string creation benchmarkhttps://github.com/nodejs/node/pull/48339/commits/50a210976fd1cbb88cc6b250e9a17dcaec9e9b24
50a2109https://github.com/nodejs/node/pull/48339/commits/50a210976fd1cbb88cc6b250e9a17dcaec9e9b24
https://github.com/gabrielschulhof
node-api: implement external stringshttps://github.com/nodejs/node/pull/48339/commits/136487284d97ec86d3a2730f0ebc3d99dd72b12e
1364872https://github.com/nodejs/node/pull/48339/commits/136487284d97ec86d3a2730f0ebc3d99dd72b12e
https://github.com/gabrielschulhof
add testhttps://github.com/nodejs/node/pull/48339/commits/a9e24b987310bab0278d7ef8c3874c07fcbe3f4a
a9e24b9https://github.com/nodejs/node/pull/48339/commits/a9e24b987310bab0278d7ef8c3874c07fcbe3f4a
https://github.com/gabrielschulhof
rename to node_api_*https://github.com/nodejs/node/pull/48339/commits/e1127d16ab7c6eb9384cf6d23e9a79490d5330da
e1127d1https://github.com/nodejs/node/pull/48339/commits/e1127d16ab7c6eb9384cf6d23e9a79490d5330da
https://github.com/gabrielschulhof
put back build typehttps://github.com/nodejs/node/pull/48339/commits/953304c4df66e2dcf8d4bfde783397133ca328e2
953304chttps://github.com/nodejs/node/pull/48339/commits/953304c4df66e2dcf8d4bfde783397133ca328e2
https://github.com/gabrielschulhof
make linter workhttps://github.com/nodejs/node/pull/48339/commits/09f7cdf79e96faecfeca4c451b8185373c1e2db8
09f7cdfhttps://github.com/nodejs/node/pull/48339/commits/09f7cdf79e96faecfeca4c451b8185373c1e2db8
https://github.com/gabrielschulhof
rename as requestedhttps://github.com/nodejs/node/pull/48339/commits/902cb33307f6c15408782fb0673142ba8d9be5bd
902cb33https://github.com/nodejs/node/pull/48339/commits/902cb33307f6c15408782fb0673142ba8d9be5bd
https://github.com/gabrielschulhof
use std::basic_string_view to calc length in case of NAPI_AUTO_LENGTHhttps://github.com/nodejs/node/pull/48339/commits/754864eefa47edae6b1be308ff6bc04d839f35d4
754864ehttps://github.com/nodejs/node/pull/48339/commits/754864eefa47edae6b1be308ff6bc04d839f35d4
https://github.com/gabrielschulhof
test for auto-lengthhttps://github.com/nodejs/node/pull/48339/commits/95a9971ab80378d9dec3c6b28bb5232bd9882466
95a9971https://github.com/nodejs/node/pull/48339/commits/95a9971ab80378d9dec3c6b28bb5232bd9882466
https://github.com/gabrielschulhof
formathttps://github.com/nodejs/node/pull/48339/commits/b4f383b846a571fe93d9adb0141e24c462fcc5a3
b4f383bhttps://github.com/nodejs/node/pull/48339/commits/b4f383b846a571fe93d9adb0141e24c462fcc5a3
https://github.com/gabrielschulhof
correct lengthhttps://github.com/nodejs/node/pull/48339/commits/05317ac024683aafad10e8057a2602926a62c4bd
05317achttps://github.com/nodejs/node/pull/48339/commits/05317ac024683aafad10e8057a2602926a62c4bd
https://github.com/gabrielschulhof
dochttps://github.com/nodejs/node/pull/48339/commits/20ab0fbae61552b22c6ba7fb0e38e4a56db265b3
20ab0fbhttps://github.com/nodejs/node/pull/48339/commits/20ab0fbae61552b22c6ba7fb0e38e4a56db265b3
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
force-pushedhttps://github.com/nodejs/node/compare/cf6e9592d987d4ace1da96387b6e6ba8efa905e8..20ab0fbae61552b22c6ba7fb0e38e4a56db265b3
cf6e959https://github.com/nodejs/node/commit/cf6e9592d987d4ace1da96387b6e6ba8efa905e8
20ab0fbhttps://github.com/nodejs/node/commit/20ab0fbae61552b22c6ba7fb0e38e4a56db265b3
Compare https://github.com/nodejs/node/compare/cf6e9592d987d4ace1da96387b6e6ba8efa905e8..20ab0fbae61552b22c6ba7fb0e38e4a56db265b3
June 7, 2023 15:25https://github.com/nodejs/node/pull/48339#event-9460878164
gabrielschulhofhttps://github.com/gabrielschulhof
June 7, 2023 17:53https://github.com/nodejs/node/pull/48339#commits-pushed-ca4c08c
https://github.com/gabrielschulhof
use right length indicatorhttps://github.com/nodejs/node/pull/48339/commits/ca4c08c5c5bd0770224f8be13910690e16f0aad4
ca4c08chttps://github.com/nodejs/node/pull/48339/commits/ca4c08c5c5bd0770224f8be13910690e16f0aad4
https://github.com/gabrielschulhof
final adjustmenthttps://github.com/nodejs/node/pull/48339/commits/5de34d450685180eec537078fd445efd55c41e91
5de34d4https://github.com/nodejs/node/pull/48339/commits/5de34d450685180eec537078fd445efd55c41e91
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jun 8, 2023 https://github.com/nodejs/node/pull/48339#pullrequestreview-1468835823
View reviewed changes https://github.com/nodejs/node/pull/48339/files/5de34d450685180eec537078fd445efd55c41e91
test/js-native-api/test_string/test_string.chttps://github.com/nodejs/node/pull/48339/files/5de34d450685180eec537078fd445efd55c41e91#diff-d1a86fd46d37d89cfe11d51263e297286650db4b94f68e435d0b6b521912e9f1
Please reload this pagehttps://github.com/nodejs/node/pull/48339
test/js-native-api/test_string/test_string.chttps://github.com/nodejs/node/pull/48339/files/5de34d450685180eec537078fd445efd55c41e91#diff-d1a86fd46d37d89cfe11d51263e297286650db4b94f68e435d0b6b521912e9f1
Please reload this pagehttps://github.com/nodejs/node/pull/48339
test/js-native-api/test_string/test_string.chttps://github.com/nodejs/node/pull/48339/files/5de34d450685180eec537078fd445efd55c41e91#diff-d1a86fd46d37d89cfe11d51263e297286650db4b94f68e435d0b6b521912e9f1
Please reload this pagehttps://github.com/nodejs/node/pull/48339
https://github.com/gabrielschulhof
Apply suggestions from code reviewhttps://github.com/nodejs/node/pull/48339/commits/64f24984267826e2b8c6baf2506be27ac9e17bd5
64f2498https://github.com/nodejs/node/pull/48339/commits/64f24984267826e2b8c6baf2506be27ac9e17bd5
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jun 8, 2023https://github.com/nodejs/node/pull/48339#event-9467450385
https://github.com/daeyeon
daeyeonhttps://github.com/daeyeon
Jun 8, 2023 https://github.com/nodejs/node/pull/48339#pullrequestreview-1468893728
View reviewed changes https://github.com/nodejs/node/pull/48339/files/64f24984267826e2b8c6baf2506be27ac9e17bd5
doc/api/n-api.mdhttps://github.com/nodejs/node/pull/48339/files/5de34d450685180eec537078fd445efd55c41e91#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d
Please reload this pagehttps://github.com/nodejs/node/pull/48339
doc/api/n-api.mdhttps://github.com/nodejs/node/pull/48339/files/5de34d450685180eec537078fd445efd55c41e91#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d
Please reload this pagehttps://github.com/nodejs/node/pull/48339
doc/api/n-api.mdhttps://github.com/nodejs/node/pull/48339/files/5de34d450685180eec537078fd445efd55c41e91#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d
Please reload this pagehttps://github.com/nodejs/node/pull/48339
doc/api/n-api.mdhttps://github.com/nodejs/node/pull/48339/files/5de34d450685180eec537078fd445efd55c41e91#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d
Please reload this pagehttps://github.com/nodejs/node/pull/48339
https://github.com/gabrielschulhof
https://github.com/daeyeon
Apply suggestions from code reviewhttps://github.com/nodejs/node/pull/48339/commits/cb9d95a752bbfd88a28f69dbb7e64e594ff0e71f
cb9d95ahttps://github.com/nodejs/node/pull/48339/commits/cb9d95a752bbfd88a28f69dbb7e64e594ff0e71f
https://github.com/gabrielschulhof
Apply suggestions from code reviewhttps://github.com/nodejs/node/pull/48339/commits/caccb8ecf85c4a78459e7d2dfa623e3700a6878b
caccb8ehttps://github.com/nodejs/node/pull/48339/commits/caccb8ecf85c4a78459e7d2dfa623e3700a6878b
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jun 11, 2023 https://github.com/nodejs/node/pull/48339#pullrequestreview-1473846123
View reviewed changes https://github.com/nodejs/node/pull/48339/files/caccb8ecf85c4a78459e7d2dfa623e3700a6878b
src/js_native_api_v8.cchttps://github.com/nodejs/node/pull/48339/files/caccb8ecf85c4a78459e7d2dfa623e3700a6878b#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1
Please reload this pagehttps://github.com/nodejs/node/pull/48339
src/js_native_api_v8.cchttps://github.com/nodejs/node/pull/48339/files/caccb8ecf85c4a78459e7d2dfa623e3700a6878b#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1
Please reload this pagehttps://github.com/nodejs/node/pull/48339
gabrielschulhofhttps://github.com/gabrielschulhof
June 11, 2023 15:35https://github.com/nodejs/node/pull/48339#commits-pushed-5c11c81
https://github.com/gabrielschulhof
Apply suggestions from code reviewhttps://github.com/nodejs/node/pull/48339/commits/5c11c819861b30014586790cead8cca8bd3c1d6c
5c11c81https://github.com/nodejs/node/pull/48339/commits/5c11c819861b30014586790cead8cca8bd3c1d6c
https://github.com/gabrielschulhof
use common distructorhttps://github.com/nodejs/node/pull/48339/commits/b651fca80444e4d6e1111d40b6212ae80178b5b8
b651fcahttps://github.com/nodejs/node/pull/48339/commits/b651fca80444e4d6e1111d40b6212ae80178b5b8
https://github.com/gabrielschulhof
formathttps://github.com/nodejs/node/pull/48339/commits/668fd4d6d619ba8daaf3bfe18e88eef4ccf532a3
668fd4dhttps://github.com/nodejs/node/pull/48339/commits/668fd4d6d619ba8daaf3bfe18e88eef4ccf532a3
https://github.com/daeyeon
daeyeonhttps://github.com/daeyeon
Jun 12, 2023 https://github.com/nodejs/node/pull/48339#pullrequestreview-1473646949
View reviewed changes https://github.com/nodejs/node/pull/48339/files/668fd4d6d619ba8daaf3bfe18e88eef4ccf532a3
doc/api/n-api.mdhttps://github.com/nodejs/node/pull/48339/files/b651fca80444e4d6e1111d40b6212ae80178b5b8#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d
Please reload this pagehttps://github.com/nodejs/node/pull/48339
doc/api/n-api.mdhttps://github.com/nodejs/node/pull/48339/files/b651fca80444e4d6e1111d40b6212ae80178b5b8#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d
Please reload this pagehttps://github.com/nodejs/node/pull/48339
gabrielschulhofhttps://github.com/gabrielschulhof
June 11, 2023 20:36https://github.com/nodejs/node/pull/48339#commits-pushed-c721439
https://github.com/gabrielschulhof
https://github.com/daeyeon
Apply suggestions from code reviewhttps://github.com/nodejs/node/pull/48339/commits/c721439976bffa2ffa27859aa576f308f70718eb
c721439https://github.com/nodejs/node/pull/48339/commits/c721439976bffa2ffa27859aa576f308f70718eb
https://github.com/gabrielschulhof
md linthttps://github.com/nodejs/node/pull/48339/commits/7f67a2f05775cd79201e290c149857743a714196
7f67a2fhttps://github.com/nodejs/node/pull/48339/commits/7f67a2f05775cd79201e290c149857743a714196
https://github.com/daeyeon
daeyeonhttps://github.com/daeyeon
Jun 12, 2023 https://github.com/nodejs/node/pull/48339#pullrequestreview-1474210274
View reviewed changes https://github.com/nodejs/node/pull/48339/files/7f67a2f05775cd79201e290c149857743a714196
https://github.com/daeyeon
daeyeonhttps://github.com/daeyeon
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
Jun 12, 2023https://github.com/nodejs/node/pull/48339#event-9498564813
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 12, 2023https://github.com/nodejs/node/pull/48339#event-9498618000
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 12, 2023https://github.com/nodejs/node/pull/48339#issuecomment-1586746033
https://ci.nodejs.org/job/node-test-pull-request/52220/https://ci.nodejs.org/job/node-test-pull-request/52220/
Please reload this pagehttps://github.com/nodejs/node/pull/48339
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 12, 2023https://github.com/nodejs/node/pull/48339#issuecomment-1587445683
https://ci.nodejs.org/job/node-test-pull-request/52224/https://ci.nodejs.org/job/node-test-pull-request/52224/
Please reload this pagehttps://github.com/nodejs/node/pull/48339
CI Reliability 2023-06-13 nodejs/reliability#592 https://github.com/nodejs/reliability/issues/592
CI Reliability 2023-06-14 nodejs/reliability#593 https://github.com/nodejs/reliability/issues/593
gabrielschulhofhttps://github.com/gabrielschulhof
Jun 14, 2023 https://github.com/nodejs/node/pull/48339#ref-commit-60d9aed
https://github.com/gabrielschulhof
node-api: implement external stringshttps://github.com/nodejs/node/commit/60d9aed30754edc752815024bb194d3707255331
60d9aedhttps://github.com/nodejs/node/commit/60d9aed30754edc752815024bb194d3707255331
#48339https://github.com/nodejs/node/pull/48339
#48198https://github.com/nodejs/node/issues/48198
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jun 14, 2023https://github.com/nodejs/node/pull/48339#issuecomment-1590475399
60d9aedhttps://github.com/nodejs/node/commit/60d9aed30754edc752815024bb194d3707255331
Please reload this pagehttps://github.com/nodejs/node/pull/48339
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Jun 14, 2023https://github.com/nodejs/node/pull/48339#event-9523596611
https://github.com/toyobayashi
toyobayashihttps://github.com/toyobayashi
Jun 14, 2023 https://github.com/nodejs/node/pull/48339#ref-pullrequest-1756460546
external strings toyobayashi/emnapi#68 https://github.com/toyobayashi/emnapi/pull/68
CI Reliability 2023-06-15 nodejs/reliability#594 https://github.com/nodejs/reliability/issues/594
CI Reliability 2023-06-21 nodejs/reliability#595 https://github.com/nodejs/reliability/issues/595
RafaelGSShttps://github.com/RafaelGSS
Jul 3, 2023 https://github.com/nodejs/node/pull/48339#ref-commit-87ad657
https://github.com/gabrielschulhof
https://github.com/RafaelGSS
node-api: implement external stringshttps://github.com/nodejs/node/commit/87ad65777707135ab9606c0896f0877b1341f16f
87ad657https://github.com/nodejs/node/commit/87ad65777707135ab9606c0896f0877b1341f16f
#48339https://github.com/nodejs/node/pull/48339
#48198https://github.com/nodejs/node/issues/48198
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Jul 3, 2023 https://github.com/nodejs/node/pull/48339#ref-pullrequest-1786245704
v20.4.0 proposal #48643 https://github.com/nodejs/node/pull/48643
Ceres6https://github.com/Ceres6
Aug 14, 2023 https://github.com/nodejs/node/pull/48339#ref-commit-0133a82
https://github.com/gabrielschulhof
https://github.com/Ceres6
node-api: implement external stringshttps://github.com/Ceres6/node/commit/0133a82b6cf301df56fec2c0e03b1f59dd21ca1b
0133a82https://github.com/Ceres6/node/commit/0133a82b6cf301df56fec2c0e03b1f59dd21ca1b
nodejs#48339https://github.com/nodejs/node/pull/48339
nodejs#48198https://github.com/nodejs/node/issues/48198
Ceres6https://github.com/Ceres6
Aug 14, 2023 https://github.com/nodejs/node/pull/48339#ref-commit-98f97dc
https://github.com/gabrielschulhof
https://github.com/Ceres6
node-api: implement external stringshttps://github.com/Ceres6/node/commit/98f97dc3e6c9620b6b7cc98bc9c2225a112860cd
98f97dchttps://github.com/Ceres6/node/commit/98f97dc3e6c9620b6b7cc98bc9c2225a112860cd
nodejs#48339https://github.com/nodejs/node/pull/48339
nodejs#48198https://github.com/nodejs/node/issues/48198
ruyadornohttps://github.com/ruyadorno
Sep 8, 2023 https://github.com/nodejs/node/pull/48339#ref-commit-f93102c
https://github.com/gabrielschulhof
https://github.com/ruyadorno
node-api: implement external stringshttps://github.com/nodejs/node/commit/f93102cd01df3ba0d1eb475e519c2b244627472c
f93102chttps://github.com/nodejs/node/commit/f93102cd01df3ba0d1eb475e519c2b244627472c
#48339https://github.com/nodejs/node/pull/48339
#48198https://github.com/nodejs/node/issues/48198
https://github.com/ruyadorno
ruyadornohttps://github.com/ruyadorno
Sep 8, 2023 https://github.com/nodejs/node/pull/48339#ref-pullrequest-1855772061
v18.18.0 proposal #49220 https://github.com/nodejs/node/pull/49220
ruyadornohttps://github.com/ruyadorno
Sep 13, 2023 https://github.com/nodejs/node/pull/48339#ref-commit-feb6a54
https://github.com/gabrielschulhof
https://github.com/ruyadorno
node-api: implement external stringshttps://github.com/nodejs/node/commit/feb6a54dc358c580f42665632bb4393da6947571
feb6a54https://github.com/nodejs/node/commit/feb6a54dc358c580f42665632bb4393da6947571
#48339https://github.com/nodejs/node/pull/48339
#48198https://github.com/nodejs/node/issues/48198
https://github.com/vmoroz
vmorozhttps://github.com/vmoroz
Nov 6, 2023 https://github.com/nodejs/node/pull/48339#ref-pullrequest-1952190925
node-api: refactor napi_set_property function for improved performance #50282 https://github.com/nodejs/node/pull/50282
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48339
https://github.com/daeyeon
daeyeon https://github.com/daeyeon
https://github.com/nodejs/node/pull/48339/files/7f67a2f05775cd79201e290c149857743a714196
https://github.com/legendecas
legendecas https://github.com/legendecas
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Expose v8::String::NewExternalOneByte and v8::String::NewExternalTwoByte to Node-API https://github.com/nodejs/node/issues/48198
Please reload this pagehttps://github.com/nodejs/node/pull/48339
https://github.com/gabrielschulhof
https://github.com/nodejs-github-bot
https://github.com/daeyeon
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.