René's URL Explorer Experiment


Title: vm: support negative number lineOffset and columnOffset by sinkhaha · Pull Request #48169 · nodejs/node · GitHub

Open Graph Title: vm: support negative number lineOffset and columnOffset by sinkhaha · Pull Request #48169 · nodejs/node

X Title: vm: support negative number lineOffset and columnOffset by sinkhaha · Pull Request #48169 · nodejs/node

Description: Fixes: #43207 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Open Graph Description: Fixes: #43207 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: Fixes: #43207 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/48169

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9284b32b-9dee-4485-fc4f-5fd30289f5db
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8810:97651:B711D8:F9439A:6969E82F
html-safe-nonce645c56d73023d88314d7be8b3f83e17c9b9a585ed46d2c0532ae9a0029ae9bfd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODEwOjk3NjUxOkI3MTFEODpGOTQzOUE6Njk2OUU4MkYiLCJ2aXNpdG9yX2lkIjoiMjAzNTA0Nzg0NDExNTI0NTEwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd211de8de38aaea002dfabf483d581ef5c72b3c3b917c90252ccb19a1358cad2
hovercard-subject-tagpull_request:1364235705
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/48169/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9267aab9f7c20c2ad8b3135a09399c3c4f637e3eede51c35d4374b25431fbac2/nodejs/node/pull/48169
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9267aab9f7c20c2ad8b3135a09399c3c4f637e3eede51c35d4374b25431fbac2/nodejs/node/pull/48169
og:image:altFixes: #43207 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesinkhaha
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/48169#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48169
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48169
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/48169
Reloadhttps://github.com/nodejs/node/pull/48169
Reloadhttps://github.com/nodejs/node/pull/48169
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/48169
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/48169
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/48169#issue-comment-box
sinkhahahttps://github.com/sinkhaha
nodejs:mainhttps://github.com/nodejs/node/tree/main
sinkhaha:vm-compilefunction-lineoffsethttps://github.com/sinkhaha/node/tree/vm-compilefunction-lineoffset
vm: support negative number lineOffset and columnOffset https://github.com/nodejs/node/pull/48169#top
sinkhahahttps://github.com/sinkhaha
nodejs:mainhttps://github.com/nodejs/node/tree/main
sinkhaha:vm-compilefunction-lineoffsethttps://github.com/sinkhaha/node/tree/vm-compilefunction-lineoffset
Conversation 3 https://github.com/nodejs/node/pull/48169
Commits 4 https://github.com/nodejs/node/pull/48169/commits
Checks 0 https://github.com/nodejs/node/pull/48169/checks
Files changed https://github.com/nodejs/node/pull/48169/files
Please reload this pagehttps://github.com/nodejs/node/pull/48169
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/sinkhaha
sinkhahahttps://github.com/sinkhaha
May 25, 2023https://github.com/nodejs/node/pull/48169#issue-1725253768
#43207https://github.com/nodejs/node/issues/43207
commit guidelineshttps://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/48169
sinkhahahttps://github.com/sinkhaha
May 25, 2023 11:08https://github.com/nodejs/node/pull/48169#commits-pushed-2bca32a
https://github.com/sinkhaha
vm: refactor to use 'validateInt32' to verify lineOffsethttps://github.com/nodejs/node/pull/48169/commits/2bca32ad8a586e0c7901010798ac8a1fb0ed6a4c
2bca32ahttps://github.com/nodejs/node/pull/48169/commits/2bca32ad8a586e0c7901010798ac8a1fb0ed6a4c
https://github.com/sinkhaha
vm: add lineOffset testhttps://github.com/nodejs/node/pull/48169/commits/88bca653b06aed4d571855c62150fef3937a71d0
88bca65https://github.com/nodejs/node/pull/48169/commits/88bca653b06aed4d571855c62150fef3937a71d0
https://github.com/sinkhaha
vm: refactor to use 'validateInt32' to verify columnOffsethttps://github.com/nodejs/node/pull/48169/commits/8703f4a5539f0931a6631105b87aa534e56c527b
8703f4ahttps://github.com/nodejs/node/pull/48169/commits/8703f4a5539f0931a6631105b87aa534e56c527b
https://github.com/sinkhaha
Merge branch 'nodejs:main' into vm-compilefunction-lineoffsethttps://github.com/nodejs/node/pull/48169/commits/0682305a468bb17bf7255d98bf0dc3ee06f314a0
0682305https://github.com/nodejs/node/pull/48169/commits/0682305a468bb17bf7255d98bf0dc3ee06f314a0
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
May 25, 2023https://github.com/nodejs/node/pull/48169#event-9336437677
https://github.com/sinkhaha
sinkhahahttps://github.com/sinkhaha
May 26, 2023https://github.com/nodejs/node/pull/48169#issuecomment-1564126388
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/48169
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 29, 2023 https://github.com/nodejs/node/pull/48169#pullrequestreview-1449806813
View reviewed changes https://github.com/nodejs/node/pull/48169/files/0682305a468bb17bf7255d98bf0dc3ee06f314a0
https://github.com/JungMinu
JungMinuhttps://github.com/JungMinu
Jun 16, 2023 https://github.com/nodejs/node/pull/48169#pullrequestreview-1482911718
View reviewed changes https://github.com/nodejs/node/pull/48169/files/0682305a468bb17bf7255d98bf0dc3ee06f314a0
https://github.com/sinkhaha
sinkhahahttps://github.com/sinkhaha
Jul 11, 2023https://github.com/nodejs/node/pull/48169#issuecomment-1630863993
Please reload this pagehttps://github.com/nodejs/node/pull/48169
https://github.com/sinkhaha
sinkhahahttps://github.com/sinkhaha
Jan 8, 2024https://github.com/nodejs/node/pull/48169#event-11415773599
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Jan 28, 2024https://github.com/nodejs/node/pull/48169#issuecomment-1913640481
Please reload this pagehttps://github.com/nodejs/node/pull/48169
@sinkhahahttps://github.com/sinkhaha
#49855https://github.com/nodejs/node/pull/49855
Please reload this pagehttps://github.com/nodejs/node/pull/48169
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F48169
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/48169/files/0682305a468bb17bf7255d98bf0dc3ee06f314a0
https://github.com/JungMinu
JungMinu https://github.com/JungMinu
https://github.com/nodejs/node/pull/48169/files/0682305a468bb17bf7255d98bf0dc3ee06f314a0
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
vm.compileFunction throws an RangeError when invoked with options.lineOffset < 0 https://github.com/nodejs/node/issues/43207
Please reload this pagehttps://github.com/nodejs/node/pull/48169
https://github.com/sinkhaha
https://github.com/fhinkel
https://github.com/jasnell
https://github.com/JungMinu
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.