René's URL Explorer Experiment


Title: doc: clarify when writable.end callback is called by kevinoid · Pull Request #4810 · nodejs/node · GitHub

Open Graph Title: doc: clarify when writable.end callback is called by kevinoid · Pull Request #4810 · nodejs/node

X Title: doc: clarify when writable.end callback is called by kevinoid · Pull Request #4810 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: The current documentation for writable.end only specifies that the callback is called "once the data has been fully handled". It is ambiguous whether this means "successfully handle...

X Description: The current documentation for writable.end only specifies that the callback is called "once the data has been fully handled". It is ambiguous whether this means "success...

Opengraph URL: https://github.com/nodejs/node/pull/4810

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fd24218d-2275-738d-c6f1-08094b7e97fb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE81E:35FB06:147B5E8:1C6E285:6A4DECCE
html-safe-noncee4ebb9cbf8009d40a47b52d7deeb0573eede8415764391aa32cf78c8ed92b64b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODFFOjM1RkIwNjoxNDdCNUU4OjFDNkUyODU6NkE0REVDQ0UiLCJ2aXNpdG9yX2lkIjoiNDYyMjYxODU4MDI4OTk3MzQ1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3860b94e0968c7f7d0b66f36b146f23f0b17c5edfc640846f4e9adc8e4d76bb8
hovercard-subject-tagpull_request:56833558
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/4810/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/126c5a02a1992298ca7b8498ef4090c78291ab6574a91c31fc1b91b6ed63ff6a/nodejs/node/pull/4810
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/126c5a02a1992298ca7b8498ef4090c78291ab6574a91c31fc1b91b6ed63ff6a/nodejs/node/pull/4810
og:image:altThe current documentation for writable.end only specifies that the callback is called "once the data has been fully handled". It is ambiguous whether this means "successfully handle...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekevinoid
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/4810#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F4810
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F4810
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/4810
Reloadhttps://github.com/nodejs/node/pull/4810
Reloadhttps://github.com/nodejs/node/pull/4810
Please reload this pagehttps://github.com/nodejs/node/pull/4810
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/4810
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
kevinoidhttps://github.com/kevinoid
nodejs:masterhttps://github.com/nodejs/node/tree/master
kevinoid:for-upstream/doc-stream-end-cbhttps://github.com/kevinoid/node/tree/for-upstream/doc-stream-end-cb
Conversationhttps://github.com/nodejs/node/pull/4810
Commits1 (1)https://github.com/nodejs/node/pull/4810/commits
Checkshttps://github.com/nodejs/node/pull/4810/checks
Files changedhttps://github.com/nodejs/node/pull/4810/files
doc: clarify when writable.end callback is calledhttps://github.com/nodejs/node/pull/4810#top
kevinoidhttps://github.com/kevinoid
nodejs:masterhttps://github.com/nodejs/node/tree/master
kevinoid:for-upstream/doc-stream-end-cbhttps://github.com/kevinoid/node/tree/for-upstream/doc-stream-end-cb
https://github.com/kevinoid
kevinoidhttps://github.com/kevinoid
Jan 22, 2016https://github.com/nodejs/node/pull/4810#issue-128058036
#1746https://github.com/nodejs/node/issues/1746
Please reload this pagehttps://github.com/nodejs/node/pull/4810
https://github.com/kevinoid
doc: clarify when writable.end callback is calledhttps://github.com/nodejs/node/pull/4810/commits/e5c71a71cba4dbc8166ff2f1a5a6dd25edf79ae0
e5c71a7https://github.com/nodejs/node/pull/4810/commits/e5c71a71cba4dbc8166ff2f1a5a6dd25edf79ae0
nodejs#1746https://github.com/nodejs/node/issues/1746
https://github.com/mscdex
mscdexhttps://github.com/mscdex
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Jan 22, 2016https://github.com/nodejs/node/pull/4810#event-522480572
https://github.com/jasnell
jasnellhttps://github.com/jasnell
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Jan 22, 2016https://github.com/nodejs/node/pull/4810#event-522542627
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 22, 2016https://github.com/nodejs/node/pull/4810#issuecomment-173802953
Please reload this pagehttps://github.com/nodejs/node/pull/4810
https://github.com/kevinoid
kevinoidhttps://github.com/kevinoid
Jan 22, 2016https://github.com/nodejs/node/pull/4810#issuecomment-173808955
Please reload this pagehttps://github.com/nodejs/node/pull/4810
https://github.com/kevinoid
kevinoidhttps://github.com/kevinoid
Jan 24, 2016https://github.com/nodejs/node/pull/4810#issuecomment-174239339
Please reload this pagehttps://github.com/nodejs/node/pull/4810
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Mar 14, 2016https://github.com/nodejs/node/pull/4810#issuecomment-196410120
Please reload this pagehttps://github.com/nodejs/node/pull/4810
https://github.com/kevinoid
kevinoidhttps://github.com/kevinoid
Mar 14, 2016https://github.com/nodejs/node/pull/4810#issuecomment-196414156
@benjamingrhttps://github.com/benjamingr
Please reload this pagehttps://github.com/nodejs/node/pull/4810
https://github.com/whitlockjc
whitlockjchttps://github.com/whitlockjc
Mar 14, 2016https://github.com/nodejs/node/pull/4810#issuecomment-196418236
Please reload this pagehttps://github.com/nodejs/node/pull/4810
benjamingrhttps://github.com/benjamingr
Mar 14, 2016 https://github.com/nodejs/node/pull/4810#ref-commit-d955243
https://github.com/kevinoid
https://github.com/benjamingr
doc: clarify when writable.write callback is calledhttps://github.com/nodejs/node/commit/d955243827231fda7339293dfe74adde44961525
d955243https://github.com/nodejs/node/commit/d955243827231fda7339293dfe74adde44961525
#1746https://github.com/nodejs/node/issues/1746
#4810https://github.com/nodejs/node/pull/4810
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Mar 14, 2016https://github.com/nodejs/node/pull/4810#issuecomment-196429315
d955243https://github.com/nodejs/node/commit/d955243827231fda7339293dfe74adde44961525
Please reload this pagehttps://github.com/nodejs/node/pull/4810
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Mar 14, 2016https://github.com/nodejs/node/pull/4810#event-589090962
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Mar 14, 2016https://github.com/nodejs/node/pull/4810#issuecomment-196429824
Please reload this pagehttps://github.com/nodejs/node/pull/4810
https://github.com/whitlockjc
whitlockjchttps://github.com/whitlockjc
Mar 14, 2016https://github.com/nodejs/node/pull/4810#issuecomment-196430781
@benjamingrhttps://github.com/benjamingr
Please reload this pagehttps://github.com/nodejs/node/pull/4810
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Mar 14, 2016https://github.com/nodejs/node/pull/4810#issuecomment-196431521
Please reload this pagehttps://github.com/nodejs/node/pull/4810
benjamingrhttps://github.com/benjamingr
Mar 14, 2016 https://github.com/nodejs/node/pull/4810#ref-commit-b801e39
https://github.com/kevinoid
https://github.com/benjamingr
doc: clarify when writable.write callback is calledhttps://github.com/nodejs/node/commit/b801e39266b815baaf264167753bdc0bb7394489
b801e39https://github.com/nodejs/node/commit/b801e39266b815baaf264167753bdc0bb7394489
#1746https://github.com/nodejs/node/issues/1746
#4810https://github.com/nodejs/node/pull/4810
https://github.com/kevinoid
kevinoidhttps://github.com/kevinoid
Mar 14, 2016https://github.com/nodejs/node/pull/4810#issuecomment-196434556
Please reload this pagehttps://github.com/nodejs/node/pull/4810
evanlucashttps://github.com/evanlucas
Mar 14, 2016 https://github.com/nodejs/node/pull/4810#ref-commit-be55939
https://github.com/kevinoid
https://github.com/evanlucas
doc: clarify when writable.write callback is calledhttps://github.com/nodejs/node/commit/be55939e1d533f98bed1bb0bf443146ba83e15de
be55939https://github.com/nodejs/node/commit/be55939e1d533f98bed1bb0bf443146ba83e15de
#1746https://github.com/nodejs/node/issues/1746
#4810https://github.com/nodejs/node/pull/4810
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Mar 14, 2016 https://github.com/nodejs/node/pull/4810#ref-pullrequest-140754096
v5.9.0 proposal #5702 https://github.com/nodejs/node/pull/5702
rvagghttps://github.com/rvagg
Mar 16, 2016 https://github.com/nodejs/node/pull/4810#ref-commit-eb73574
https://github.com/kevinoid
https://github.com/rvagg
doc: clarify when writable.write callback is calledhttps://github.com/nodejs/node/commit/eb735743494ece4c5c707cf0aae7d02a7108968c
eb73574https://github.com/nodejs/node/commit/eb735743494ece4c5c707cf0aae7d02a7108968c
#1746https://github.com/nodejs/node/issues/1746
#4810https://github.com/nodejs/node/pull/4810
MylesBorinshttps://github.com/MylesBorins
Mar 17, 2016 https://github.com/nodejs/node/pull/4810#ref-commit-fd268fd
https://github.com/kevinoid
doc: clarify when writable.write callback is calledhttps://github.com/nodejs/node/commit/fd268fda15cca6237c4f46f3bd937fe00455d071
fd268fdhttps://github.com/nodejs/node/commit/fd268fda15cca6237c4f46f3bd937fe00455d071
#1746https://github.com/nodejs/node/issues/1746
#4810https://github.com/nodejs/node/pull/4810
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Mar 17, 2016https://github.com/nodejs/node/pull/4810#event-593783934
MylesBorinshttps://github.com/MylesBorins
Mar 21, 2016 https://github.com/nodejs/node/pull/4810#ref-commit-0830bb4
https://github.com/kevinoid
doc: clarify when writable.write callback is calledhttps://github.com/nodejs/node/commit/0830bb4950a7624efa7c4c370d6e4d687f490871
0830bb4https://github.com/nodejs/node/commit/0830bb4950a7624efa7c4c370d6e4d687f490871
#1746https://github.com/nodejs/node/issues/1746
#4810https://github.com/nodejs/node/pull/4810
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F4810
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/4810
https://github.com/kevinoid
https://github.com/jasnell
https://github.com/benjamingr
https://github.com/whitlockjc
https://github.com/mscdex
https://github.com/MylesBorins
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.