René's URL Explorer Experiment


Title: dns: call `ada::idna::to_ascii` directly from c++ by anonrig · Pull Request #47920 · nodejs/node · GitHub

Open Graph Title: dns: call `ada::idna::to_ascii` directly from c++ by anonrig · Pull Request #47920 · nodejs/node

X Title: dns: call `ada::idna::to_ascii` directly from c++ by anonrig · Pull Request #47920 · nodejs/node

Description: Reduces the C++/JS bridge crosses by calling toASCII directly from C++. Fixes: nodejs/performance#77 Benchmark CI: https://ci.nodejs.org/view/Node.js benchmark/job/benchmark-node-micro-benchmarks...

Open Graph Description: Reduces the C++/JS bridge crosses by calling toASCII directly from C++. Fixes: nodejs/performance#77 Benchmark CI: https://ci.nodejs.org/view/Node.js benchmark/job/benchmark-node-micro-benchmarks...

X Description: Reduces the C++/JS bridge crosses by calling toASCII directly from C++. Fixes: nodejs/performance#77 Benchmark CI: https://ci.nodejs.org/view/Node.js benchmark/job/benchmark-node-micro-benchmarks...

Opengraph URL: https://github.com/nodejs/node/pull/47920

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:24a92830-5fe9-337d-7ddf-ed731672a399
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8D64:12917D:C263A:102E57:6969B620
html-safe-nonced00fa8346935f9b94af7930bd6d5078530bd7411b22bd93666e216603e871686
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDY0OjEyOTE3RDpDMjYzQToxMDJFNTc6Njk2OUI2MjAiLCJ2aXNpdG9yX2lkIjoiMzE1NDU0MjYyMzI3OTY1ODUyOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8667c229f4e411bc0376acfec0467cac77779cb13a640295d673500c36f2c864
hovercard-subject-tagpull_request:1342416894
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/47920/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/79fa6f3a3effd0a8b3e34a6394965da46e2dad21c6293a2ade6947e2871bc914/nodejs/node/pull/47920
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/79fa6f3a3effd0a8b3e34a6394965da46e2dad21c6293a2ade6947e2871bc914/nodejs/node/pull/47920
og:image:altReduces the C++/JS bridge crosses by calling toASCII directly from C++. Fixes: nodejs/performance#77 Benchmark CI: https://ci.nodejs.org/view/Node.js benchmark/job/benchmark-node-micro-benchmarks...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameanonrig
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/47920#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47920
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47920
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/47920
Reloadhttps://github.com/nodejs/node/pull/47920
Reloadhttps://github.com/nodejs/node/pull/47920
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/47920
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/47920
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/47920#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
mainhttps://github.com/nodejs/node/tree/main
improve-dnshttps://github.com/nodejs/node/tree/improve-dns
dns: call ada::idna::to_ascii directly from c++ https://github.com/nodejs/node/pull/47920#top
nodejs-github-bothttps://github.com/nodejs-github-bot
mainhttps://github.com/nodejs/node/tree/main
improve-dnshttps://github.com/nodejs/node/tree/improve-dns
Conversation 7 https://github.com/nodejs/node/pull/47920
Commits 1 https://github.com/nodejs/node/pull/47920/commits
Checks 0 https://github.com/nodejs/node/pull/47920/checks
Files changed https://github.com/nodejs/node/pull/47920/files
Please reload this pagehttps://github.com/nodejs/node/pull/47920
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/anonrig
anonrighttps://github.com/anonrig
May 8, 2023https://github.com/nodejs/node/pull/47920#issue-1700516184
Please reload this pagehttps://github.com/nodejs/node/pull/47920
nodejs/performance#77https://github.com/nodejs/performance/issues/77
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1335/https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1335/
Please reload this pagehttps://github.com/nodejs/node/pull/47920
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 8, 2023https://github.com/nodejs/node/pull/47920#issuecomment-1538646456
Please reload this pagehttps://github.com/nodejs/node/pull/47920
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
May 8, 2023https://github.com/nodejs/node/pull/47920#event-9191954459
https://github.com/anonrig
dns: call ada::idna::to_ascii directly from c++https://github.com/nodejs/node/pull/47920/commits/82c8149897eefc9bf4987bfef48519ac290931c7
82c8149https://github.com/nodejs/node/pull/47920/commits/82c8149897eefc9bf4987bfef48519ac290931c7
https://github.com/anonrig
anonrighttps://github.com/anonrig
force-pushedhttps://github.com/nodejs/node/compare/dc6c607a8bca2c9daa24357bba366fe156ee0407..82c8149897eefc9bf4987bfef48519ac290931c7
dc6c607https://github.com/nodejs/node/commit/dc6c607a8bca2c9daa24357bba366fe156ee0407
82c8149https://github.com/nodejs/node/commit/82c8149897eefc9bf4987bfef48519ac290931c7
Compare https://github.com/nodejs/node/compare/dc6c607a8bca2c9daa24357bba366fe156ee0407..82c8149897eefc9bf4987bfef48519ac290931c7
May 8, 2023 16:05https://github.com/nodejs/node/pull/47920#event-9192026948
https://github.com/anonrig
anonrighttps://github.com/anonrig
May 8, 2023https://github.com/nodejs/node/pull/47920#issuecomment-1538690252
Please reload this pagehttps://github.com/nodejs/node/pull/47920
Please reload this pagehttps://github.com/nodejs/node/pull/47920
https://github.com/anonrig
anonrighttps://github.com/anonrig
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 8, 2023https://github.com/nodejs/node/pull/47920#event-9192244825
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 8, 2023https://github.com/nodejs/node/pull/47920#event-9192324179
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 8, 2023https://github.com/nodejs/node/pull/47920#issuecomment-1538703589
https://ci.nodejs.org/job/node-test-pull-request/51700/https://ci.nodejs.org/job/node-test-pull-request/51700/
Please reload this pagehttps://github.com/nodejs/node/pull/47920
https://github.com/tony-go
tony-gohttps://github.com/tony-go
May 9, 2023 https://github.com/nodejs/node/pull/47920#pullrequestreview-1418012893
View reviewed changes https://github.com/nodejs/node/pull/47920/files/82c8149897eefc9bf4987bfef48519ac290931c7
tony-gohttps://github.com/tony-go
https://github.com/nodejs/node/pull/47920#pullrequestreview-1418012893
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/47920
https://github.com/anonrig
anonrighttps://github.com/anonrig
May 9, 2023https://github.com/nodejs/node/pull/47920#issuecomment-1540500151
Please reload this pagehttps://github.com/nodejs/node/pull/47920
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 10, 2023 https://github.com/nodejs/node/pull/47920#pullrequestreview-1419750626
View reviewed changes https://github.com/nodejs/node/pull/47920/files/82c8149897eefc9bf4987bfef48519ac290931c7
https://github.com/anonrig
anonrighttps://github.com/anonrig
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
review wanted https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22
May 10, 2023https://github.com/nodejs/node/pull/47920#event-9207000869
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 10, 2023 https://github.com/nodejs/node/pull/47920#pullrequestreview-1420810594
View reviewed changes https://github.com/nodejs/node/pull/47920/files/82c8149897eefc9bf4987bfef48519ac290931c7
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/47920#pullrequestreview-1420810594
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/47920
https://github.com/anonrig
anonrighttps://github.com/anonrig
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 10, 2023https://github.com/nodejs/node/pull/47920#event-9212626820
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 10, 2023https://github.com/nodejs/node/pull/47920#event-9213405955
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
8b5cd32https://github.com/nodejs/node/commit/8b5cd3248dbf00de3e23644739e5c89c1a6a9ff4
May 10, 2023https://github.com/nodejs/node/pull/47920#event-9213406647
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 10, 2023https://github.com/nodejs/node/pull/47920#issuecomment-1542460846
8b5cd32https://github.com/nodejs/node/commit/8b5cd3248dbf00de3e23644739e5c89c1a6a9ff4
Please reload this pagehttps://github.com/nodejs/node/pull/47920
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 10, 2023 16:04https://github.com/nodejs/node/pull/47920#event-9213406850
targoshttps://github.com/targos
May 12, 2023 https://github.com/nodejs/node/pull/47920#ref-commit-9be9228
https://github.com/anonrig
https://github.com/targos
dns: call ada::idna::to_ascii directly from c++https://github.com/nodejs/node/commit/9be922892fcf6790bc1c69378f799a5e2f4abb24
9be9228https://github.com/nodejs/node/commit/9be922892fcf6790bc1c69378f799a5e2f4abb24
#47920https://github.com/nodejs/node/pull/47920
nodejs/performance#77https://github.com/nodejs/performance/issues/77
https://github.com/targos
targoshttps://github.com/targos
May 15, 2023 https://github.com/nodejs/node/pull/47920#ref-pullrequest-1710289834
v20.2.0 release proposal #48020 https://github.com/nodejs/node/pull/48020
https://github.com/ShogunPanda
ShogunPandahttps://github.com/ShogunPanda
May 31, 2023 https://github.com/nodejs/node/pull/47920#ref-issue-1734367750
test/internet/test-dns-idna2008.js fails #48262 https://github.com/nodejs/node/issues/48262
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
backport-requested-v18.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v18.x
Jul 4, 2023https://github.com/nodejs/node/pull/47920#event-9718954950
https://github.com/anonrig
anonrighttps://github.com/anonrig
Aug 16, 2023 https://github.com/nodejs/node/pull/47920#ref-issue-1853669941
v18.x - test-dns-ipv6 fails in 18.17.0 and later #49203 https://github.com/nodejs/node/issues/49203
https://github.com/ruyadorno
ruyadornohttps://github.com/ruyadorno
Aug 30, 2023 https://github.com/nodejs/node/pull/47920#ref-pullrequest-1742802436
src: add missing to_ascii method in dns queries #48354 https://github.com/nodejs/node/pull/48354
targoshttps://github.com/targos
Nov 10, 2023 https://github.com/nodejs/node/pull/47920#ref-commit-284a869
https://github.com/anonrig
https://github.com/targos
dns: call ada::idna::to_ascii directly from c++https://github.com/nodejs/node/commit/284a8695405e1582bf3e0018229caec6523dae4f
284a869https://github.com/nodejs/node/commit/284a8695405e1582bf3e0018229caec6523dae4f
#47920https://github.com/nodejs/node/pull/47920
nodejs/performance#77https://github.com/nodejs/performance/issues/77
https://github.com/targos
targoshttps://github.com/targos
Nov 28, 2023 https://github.com/nodejs/node/pull/47920#ref-pullrequest-2014162105
v18.19.0 release proposal #50953 https://github.com/nodejs/node/pull/50953
sercherhttps://github.com/sercher
Apr 25, 2024 https://github.com/nodejs/node/pull/47920#ref-commit-162081d
https://github.com/sercher
dns: call ada::idna::to_ascii directly from c++https://github.com/sercher/graaljs/commit/162081d3a3458cf659723144aa98f3c0d9036744
162081dhttps://github.com/sercher/graaljs/commit/162081d3a3458cf659723144aa98f3c0d9036744
nodejs/node#47920https://github.com/nodejs/node/pull/47920
nodejs/performance#77https://github.com/nodejs/performance/issues/77
sercherhttps://github.com/sercher
Apr 25, 2024 https://github.com/nodejs/node/pull/47920#ref-commit-3e323da
https://github.com/sercher
dns: call ada::idna::to_ascii directly from c++https://github.com/sercher/graaljs/commit/3e323da3d863ac62cab9d5462d629ac47f6b7809
3e323dahttps://github.com/sercher/graaljs/commit/3e323da3d863ac62cab9d5462d629ac47f6b7809
nodejs/node#47920https://github.com/nodejs/node/pull/47920
nodejs/performance#77https://github.com/nodejs/performance/issues/77
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47920
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/47920/files/82c8149897eefc9bf4987bfef48519ac290931c7
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/47920/files/82c8149897eefc9bf4987bfef48519ac290931c7
https://github.com/tony-go
tony-go https://github.com/tony-go
https://github.com/nodejs/node/pull/47920/files/82c8149897eefc9bf4987bfef48519ac290931c7
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
review wanted https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22
dns.lookup performance https://github.com/nodejs/performance/issues/77
Please reload this pagehttps://github.com/nodejs/node/pull/47920
https://github.com/anonrig
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/jasnell
https://github.com/tony-go
https://github.com/danielleadams
https://github.com/apps/copilot-swe-agent
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.