René's URL Explorer Experiment


Title: url: improve `isURL` detection by anonrig · Pull Request #47886 · nodejs/node · GitHub

Open Graph Title: url: improve `isURL` detection by anonrig · Pull Request #47886 · nodejs/node

X Title: url: improve `isURL` detection by anonrig · Pull Request #47886 · nodejs/node

Description: Previously we were checking for protocol and origin attributes, but due to the lazy-loading nature of Ada 2.0 with url_aggregator we shifted from checking for origin. This was also breaking the det...

Open Graph Description: Previously we were checking for protocol and origin attributes, but due to the lazy-loading nature of Ada 2.0 with url_aggregator we shifted from checking for origin. This was also breaking the det...

X Description: Previously we were checking for protocol and origin attributes, but due to the lazy-loading nature of Ada 2.0 with url_aggregator we shifted from checking for origin. This was also breaking the det...

Opengraph URL: https://github.com/nodejs/node/pull/47886

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ffc8cd60-4fa1-8c61-e85f-13ac87658dfc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id83E4:124678:3F51BA:53FAB4:6969D23F
html-safe-nonce5be2b6c999853099cdf2858a722da992c37ad1a3b7aff27f41f2affcd30bd193
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4M0U0OjEyNDY3ODozRjUxQkE6NTNGQUI0OjY5NjlEMjNGIiwidmlzaXRvcl9pZCI6IjMyNzQ3MDY2MDQxMDY4MzAzOTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5783809c4cb64171fc86c0ea73ff214220d8006b728be3099db32812c048265c
hovercard-subject-tagpull_request:1340318516
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/47886/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/41c399c198855cfad0f17ad575bb70e3f03eb06004704d0290db48fcf884a5d7/nodejs/node/pull/47886
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/41c399c198855cfad0f17ad575bb70e3f03eb06004704d0290db48fcf884a5d7/nodejs/node/pull/47886
og:image:altPreviously we were checking for protocol and origin attributes, but due to the lazy-loading nature of Ada 2.0 with url_aggregator we shifted from checking for origin. This was also breaking the det...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameanonrig
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/47886#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47886
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47886
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/47886
Reloadhttps://github.com/nodejs/node/pull/47886
Reloadhttps://github.com/nodejs/node/pull/47886
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/47886
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/47886
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/47886#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
mainhttps://github.com/nodejs/node/tree/main
url-fix-detectionhttps://github.com/nodejs/node/tree/url-fix-detection
url: improve isURL detection https://github.com/nodejs/node/pull/47886#top
nodejs-github-bothttps://github.com/nodejs-github-bot
mainhttps://github.com/nodejs/node/tree/main
url-fix-detectionhttps://github.com/nodejs/node/tree/url-fix-detection
Conversation 15 https://github.com/nodejs/node/pull/47886
Commits 1 https://github.com/nodejs/node/pull/47886/commits
Checks 0 https://github.com/nodejs/node/pull/47886/checks
Files changed https://github.com/nodejs/node/pull/47886/files
Please reload this pagehttps://github.com/nodejs/node/pull/47886
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/anonrig
anonrighttps://github.com/anonrig
May 5, 2023https://github.com/nodejs/node/pull/47886#issue-1698104172
#47624https://github.com/nodejs/node/issues/47624
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/47886
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 5, 2023https://github.com/nodejs/node/pull/47886#issuecomment-1536694786
Please reload this pagehttps://github.com/nodejs/node/pull/47886
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
whatwg-url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awhatwg-url
May 5, 2023https://github.com/nodejs/node/pull/47886#event-9179937462
https://github.com/anonrig
anonrighttps://github.com/anonrig
May 5, 2023 https://github.com/nodejs/node/pull/47886#pullrequestreview-1415363127
View reviewed changes https://github.com/nodejs/node/pull/47886/files
lib/internal/url.jshttps://github.com/nodejs/node/pull/47886/files#diff-26e6b1e2a90040b1ce20e7f305b2ff3140b483f863ee2573b4c6af9b696ad31e
Please reload this pagehttps://github.com/nodejs/node/pull/47886
https://github.com/anonrig
anonrighttps://github.com/anonrig
TimothyGuhttps://github.com/TimothyGu
May 5, 2023 19:51https://github.com/nodejs/node/pull/47886#event-9180012593
https://github.com/Trott
Trotthttps://github.com/Trott
May 5, 2023 https://github.com/nodejs/node/pull/47886#pullrequestreview-1415404495
View reviewed changes https://github.com/nodejs/node/pull/47886/files
https://github.com/anonrig
anonrighttps://github.com/anonrig
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 5, 2023https://github.com/nodejs/node/pull/47886#event-9180221015
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 5, 2023https://github.com/nodejs/node/pull/47886#event-9180274560
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 5, 2023https://github.com/nodejs/node/pull/47886#issuecomment-1536750668
https://ci.nodejs.org/job/node-test-pull-request/51671/https://ci.nodejs.org/job/node-test-pull-request/51671/
Please reload this pagehttps://github.com/nodejs/node/pull/47886
https://github.com/anonrig
url: improve isURL detectionhttps://github.com/nodejs/node/pull/47886/commits/c5725a114506a9259ee72f6500119b9b2a3ce6fb
c5725a1https://github.com/nodejs/node/pull/47886/commits/c5725a114506a9259ee72f6500119b9b2a3ce6fb
https://github.com/anonrig
anonrighttps://github.com/anonrig
force-pushedhttps://github.com/nodejs/node/compare/4a0b18382cc0d08ea157207dcef1aab9e0a277dc..c5725a114506a9259ee72f6500119b9b2a3ce6fb
4a0b183https://github.com/nodejs/node/commit/4a0b18382cc0d08ea157207dcef1aab9e0a277dc
c5725a1https://github.com/nodejs/node/commit/c5725a114506a9259ee72f6500119b9b2a3ce6fb
Compare https://github.com/nodejs/node/compare/4a0b18382cc0d08ea157207dcef1aab9e0a277dc..c5725a114506a9259ee72f6500119b9b2a3ce6fb
May 5, 2023 20:52https://github.com/nodejs/node/pull/47886#event-9180389068
https://github.com/KhafraDev
KhafraDevhttps://github.com/KhafraDev
May 5, 2023 https://github.com/nodejs/node/pull/47886#pullrequestreview-1415505771
View reviewed changes https://github.com/nodejs/node/pull/47886/files/c5725a114506a9259ee72f6500119b9b2a3ce6fb
https://github.com/anonrig
anonrighttps://github.com/anonrig
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 5, 2023https://github.com/nodejs/node/pull/47886#event-9181005690
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 5, 2023https://github.com/nodejs/node/pull/47886#event-9181030312
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 5, 2023https://github.com/nodejs/node/pull/47886#issuecomment-1536900107
https://ci.nodejs.org/job/node-test-pull-request/51672/https://ci.nodejs.org/job/node-test-pull-request/51672/
Please reload this pagehttps://github.com/nodejs/node/pull/47886
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
May 6, 2023 https://github.com/nodejs/node/pull/47886#ref-issue-1698324742
CI Reliability 2023-05-06 nodejs/reliability#557 https://github.com/nodejs/reliability/issues/557
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 6, 2023https://github.com/nodejs/node/pull/47886#issuecomment-1536933304
https://ci.nodejs.org/job/node-test-pull-request/51673/https://ci.nodejs.org/job/node-test-pull-request/51673/
Please reload this pagehttps://github.com/nodejs/node/pull/47886
https://github.com/anonrig
anonrighttps://github.com/anonrig
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 6, 2023https://github.com/nodejs/node/pull/47886#event-9181292112
https://github.com/Trott
Trotthttps://github.com/Trott
May 6, 2023https://github.com/nodejs/node/pull/47886#issuecomment-1537033320
Please reload this pagehttps://github.com/nodejs/node/pull/47886
https://github.com/anonrig
anonrighttps://github.com/anonrig
May 6, 2023https://github.com/nodejs/node/pull/47886#issuecomment-1537034238
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/47886
https://github.com/Trott
Trotthttps://github.com/Trott
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 6, 2023https://github.com/nodejs/node/pull/47886#event-9181606935
https://github.com/Trott
Trotthttps://github.com/Trott
May 6, 2023https://github.com/nodejs/node/pull/47886#issuecomment-1537034414
Please reload this pagehttps://github.com/nodejs/node/pull/47886
https://github.com/Trott
Trotthttps://github.com/Trott
May 6, 2023https://github.com/nodejs/node/pull/47886#issuecomment-1537034476
Please reload this pagehttps://github.com/nodejs/node/pull/47886
https://github.com/Trott
Trotthttps://github.com/Trott
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 6, 2023https://github.com/nodejs/node/pull/47886#event-9181608054
https://github.com/VoltrexKeyva
VoltrexKeyvahttps://github.com/VoltrexKeyva
May 6, 2023 https://github.com/nodejs/node/pull/47886#pullrequestreview-1415689258
View reviewed changes https://github.com/nodejs/node/pull/47886/files/c5725a114506a9259ee72f6500119b9b2a3ce6fb
lib/internal/url.jshttps://github.com/nodejs/node/pull/47886/files/c5725a114506a9259ee72f6500119b9b2a3ce6fb#diff-26e6b1e2a90040b1ce20e7f305b2ff3140b483f863ee2573b4c6af9b696ad31e
VoltrexKeyvahttps://github.com/VoltrexKeyva
May 6, 2023https://github.com/nodejs/node/pull/47886#discussion_r1186625418
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/47886
Trotthttps://github.com/Trott
May 6, 2023https://github.com/nodejs/node/pull/47886#discussion_r1186700849
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://nodejs.org/dist/latest-v20.x/docs/api/url.html#legacy-urlobjecthttps://nodejs.org/dist/latest-v20.x/docs/api/url.html#legacy-urlobject
Please reload this pagehttps://github.com/nodejs/node/pull/47886
https://github.com/Trott
Trotthttps://github.com/Trott
May 6, 2023 https://github.com/nodejs/node/pull/47886#pullrequestreview-1415779502
View reviewed changes https://github.com/nodejs/node/pull/47886/files/c5725a114506a9259ee72f6500119b9b2a3ce6fb
Trotthttps://github.com/Trott
https://github.com/nodejs/node/pull/47886#pullrequestreview-1415779502
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/47886
https://github.com/Trott
Trotthttps://github.com/Trott
May 6, 2023https://github.com/nodejs/node/pull/47886#issuecomment-1537146881
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/47886
https://github.com/Trott
Trotthttps://github.com/Trott
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 6, 2023https://github.com/nodejs/node/pull/47886#event-9182663017
https://github.com/Trott
Trotthttps://github.com/Trott
May 6, 2023https://github.com/nodejs/node/pull/47886#issuecomment-1537151004
Please reload this pagehttps://github.com/nodejs/node/pull/47886
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 7, 2023https://github.com/nodejs/node/pull/47886#event-9184843255
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
528aacahttps://github.com/nodejs/node/commit/528aacab8def0d8c57ae05d96f0cf73d6f976f28
May 7, 2023https://github.com/nodejs/node/pull/47886#event-9184843343
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 7, 2023https://github.com/nodejs/node/pull/47886#issuecomment-1537525097
528aacahttps://github.com/nodejs/node/commit/528aacab8def0d8c57ae05d96f0cf73d6f976f28
Please reload this pagehttps://github.com/nodejs/node/pull/47886
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 7, 2023 19:41https://github.com/nodejs/node/pull/47886#event-9184843373
CI Reliability 2023-05-08 nodejs/reliability#559 https://github.com/nodejs/reliability/issues/559
CI Reliability 2023-05-09 nodejs/reliability#560 https://github.com/nodejs/reliability/issues/560
CI Reliability 2023-05-10 nodejs/reliability#561 https://github.com/nodejs/reliability/issues/561
CI Reliability 2023-05-11 nodejs/reliability#562 https://github.com/nodejs/reliability/issues/562
CI Reliability 2023-05-12 nodejs/reliability#563 https://github.com/nodejs/reliability/issues/563
targoshttps://github.com/targos
May 12, 2023 https://github.com/nodejs/node/pull/47886#ref-commit-1b06c1e
https://github.com/anonrig
https://github.com/targos
url: improve isURL detectionhttps://github.com/nodejs/node/commit/1b06c1e003ac811630c95c10cd46d887e7b08796
1b06c1ehttps://github.com/nodejs/node/commit/1b06c1e003ac811630c95c10cd46d887e7b08796
#47886https://github.com/nodejs/node/pull/47886
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
May 13, 2023 https://github.com/nodejs/node/pull/47886#ref-issue-1708358026
CI Reliability 2023-05-13 nodejs/reliability#564 https://github.com/nodejs/reliability/issues/564
https://github.com/targos
targoshttps://github.com/targos
May 15, 2023 https://github.com/nodejs/node/pull/47886#ref-pullrequest-1710289834
v20.2.0 release proposal #48020 https://github.com/nodejs/node/pull/48020
anonrighttps://github.com/anonrig
Jun 5, 2023 https://github.com/nodejs/node/pull/47886#ref-commit-23ee223
https://github.com/anonrig
url: improve isURL detectionhttps://github.com/anonrig/node/commit/23ee22364a37017e1285c03e2b5ab9a4c9d4c15c
23ee223https://github.com/anonrig/node/commit/23ee22364a37017e1285c03e2b5ab9a4c9d4c15c
nodejs#47886https://github.com/nodejs/node/pull/47886
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jun 5, 2023 https://github.com/nodejs/node/pull/47886#ref-pullrequest-1741827032
[v18.x] backport Ada v2.x to Node.js v18 #48345 https://github.com/nodejs/node/pull/48345
anonrighttps://github.com/anonrig
Jun 5, 2023 https://github.com/nodejs/node/pull/47886#ref-commit-f1eaa85
https://github.com/anonrig
url: improve isURL detectionhttps://github.com/anonrig/node/commit/f1eaa851dfd94d3d27e42f5cea4f1140a373ea9f
f1eaa85https://github.com/anonrig/node/commit/f1eaa851dfd94d3d27e42f5cea4f1140a373ea9f
nodejs#47886https://github.com/nodejs/node/pull/47886
anonrighttps://github.com/anonrig
Jun 5, 2023 https://github.com/nodejs/node/pull/47886#ref-commit-9654ce5
https://github.com/anonrig
url: improve isURL detectionhttps://github.com/anonrig/node/commit/9654ce58361361392f85306750b9eac0b530c173
9654ce5https://github.com/anonrig/node/commit/9654ce58361361392f85306750b9eac0b530c173
nodejs#47886https://github.com/nodejs/node/pull/47886
https://github.com/anonrig
anonrighttps://github.com/anonrig
backport-open-v18.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-open-v18.x
Jun 5, 2023https://github.com/nodejs/node/pull/47886#event-9434700501
anonrighttps://github.com/anonrig
Jun 17, 2023 https://github.com/nodejs/node/pull/47886#ref-commit-b629d63
https://github.com/anonrig
url: improve isURL detectionhttps://github.com/anonrig/node/commit/b629d638d5d73891b0031626003689d3a508de11
b629d63https://github.com/anonrig/node/commit/b629d638d5d73891b0031626003689d3a508de11
nodejs#47886https://github.com/nodejs/node/pull/47886
anonrighttps://github.com/anonrig
Jun 23, 2023 https://github.com/nodejs/node/pull/47886#ref-commit-3a3ba27
https://github.com/anonrig
url: improve isURL detectionhttps://github.com/anonrig/node/commit/3a3ba271b5e3195fa94cae633fe1e772b0911d8e
3a3ba27https://github.com/anonrig/node/commit/3a3ba271b5e3195fa94cae633fe1e772b0911d8e
nodejs#47886https://github.com/nodejs/node/pull/47886
anonrighttps://github.com/anonrig
Jun 24, 2023 https://github.com/nodejs/node/pull/47886#ref-commit-145a7ad
https://github.com/anonrig
url: improve isURL detectionhttps://github.com/anonrig/node/commit/145a7ad80394de70cd7a28f77097c6230538a20d
145a7adhttps://github.com/anonrig/node/commit/145a7ad80394de70cd7a28f77097c6230538a20d
nodejs#47886https://github.com/nodejs/node/pull/47886
anonrighttps://github.com/anonrig
Jun 24, 2023 https://github.com/nodejs/node/pull/47886#ref-commit-8be4fbc
https://github.com/anonrig
url: improve isURL detectionhttps://github.com/anonrig/node/commit/8be4fbc5a2d7d5fec33f18bf77fa685760c84e05
8be4fbchttps://github.com/anonrig/node/commit/8be4fbc5a2d7d5fec33f18bf77fa685760c84e05
nodejs#47886https://github.com/nodejs/node/pull/47886
https://github.com/Zhangdroid
Zhangdroidhttps://github.com/Zhangdroid
Jul 26, 2023 https://github.com/nodejs/node/pull/47886#ref-pullrequest-1821535343
url: fix isURL detection by checking path #48928 https://github.com/nodejs/node/pull/48928
aduh95https://github.com/aduh95
Oct 9, 2023 https://github.com/nodejs/node/pull/47886#ref-commit-1ea10db
https://github.com/anonrig
https://github.com/aduh95
url: improve isURL detectionhttps://github.com/aduh95/node/commit/1ea10dbc9e8c37533d8bc3cbe6f08b2a02cc33d2
1ea10dbhttps://github.com/aduh95/node/commit/1ea10dbc9e8c37533d8bc3cbe6f08b2a02cc33d2
nodejs#47886https://github.com/nodejs/node/pull/47886
https://github.com/aduh95
aduh95https://github.com/aduh95
Oct 9, 2023 https://github.com/nodejs/node/pull/47886#ref-pullrequest-1933777806
[v18.x backport] url test #50105 https://github.com/nodejs/node/pull/50105
targoshttps://github.com/targos
Nov 27, 2023 https://github.com/nodejs/node/pull/47886#ref-commit-916a63b
https://github.com/anonrig
https://github.com/targos
url: improve isURL detectionhttps://github.com/nodejs/node/commit/916a63b124d34c94c6ac02f5b6fc26fa6a65206b
916a63bhttps://github.com/nodejs/node/commit/916a63b124d34c94c6ac02f5b6fc26fa6a65206b
#47886https://github.com/nodejs/node/pull/47886
#50105https://github.com/nodejs/node/pull/50105
https://github.com/targos
targoshttps://github.com/targos
Nov 28, 2023 https://github.com/nodejs/node/pull/47886#ref-pullrequest-2014162105
v18.19.0 release proposal #50953 https://github.com/nodejs/node/pull/50953
https://github.com/richardlau
richardlauhttps://github.com/richardlau
backported-to-v18.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v18.x
backport-open-v18.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-open-v18.x
Mar 18, 2024https://github.com/nodejs/node/pull/47886#event-12152617316
sercherhttps://github.com/sercher
Apr 25, 2024 https://github.com/nodejs/node/pull/47886#ref-commit-b3e3823
https://github.com/sercher
url: improve isURL detectionhttps://github.com/sercher/graaljs/commit/b3e3823a926c97fde1a98e1e26bb10d4590a62ea
b3e3823https://github.com/sercher/graaljs/commit/b3e3823a926c97fde1a98e1e26bb10d4590a62ea
nodejs/node#47886https://github.com/nodejs/node/pull/47886
nodejs/node#50105https://github.com/nodejs/node/pull/50105
sercherhttps://github.com/sercher
Apr 25, 2024 https://github.com/nodejs/node/pull/47886#ref-commit-be42fed
https://github.com/sercher
url: improve isURL detectionhttps://github.com/sercher/graaljs/commit/be42fed379ee77842cef2a2b72b6ac84f8a419cd
be42fedhttps://github.com/sercher/graaljs/commit/be42fed379ee77842cef2a2b72b6ac84f8a419cd
nodejs/node#47886https://github.com/nodejs/node/pull/47886
nodejs/node#50105https://github.com/nodejs/node/pull/50105
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47886
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/47886/files/c5725a114506a9259ee72f6500119b9b2a3ce6fb
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/47886/files/c5725a114506a9259ee72f6500119b9b2a3ce6fb
https://github.com/KhafraDev
KhafraDev https://github.com/KhafraDev
https://github.com/nodejs/node/pull/47886/files/c5725a114506a9259ee72f6500119b9b2a3ce6fb
https://github.com/VoltrexKeyva
VoltrexKeyva https://github.com/VoltrexKeyva
https://github.com/nodejs/node/pull/47886/files/c5725a114506a9259ee72f6500119b9b2a3ce6fb
https://github.com/TimothyGu
TimothyGu https://github.com/TimothyGu
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
whatwg-url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awhatwg-url
Undocumented behavior for handling options of http.request https://github.com/nodejs/node/issues/47624
Please reload this pagehttps://github.com/nodejs/node/pull/47886
https://github.com/anonrig
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/lpinca
https://github.com/KhafraDev
https://github.com/VoltrexKeyva
https://github.com/richardlau
https://github.com/apps/copilot-swe-agent
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.