| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3bf44058-6028-ef3a-4a47-7ad90cd764d4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E83C:A981C:DF502B:13910DE:696A2892 |
| html-safe-nonce | 16da054df3e515fc0c787718b75a767882e3eacdd4f0b0c8b040ddb043a5d764 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODNDOkE5ODFDOkRGNTAyQjoxMzkxMERFOjY5NkEyODkyIiwidmlzaXRvcl9pZCI6IjQ5NTY3NTkxNTAzNDM4OTEwOTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 311ad70cc54956e727fddabf905052d6242d7720aa0b9ac181890f68c7ef1c5e |
| hovercard-subject-tag | pull_request:1339693673 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/47876/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7ed88d8b6d6b22db34122d26e05f411e942f39b00147086bea876b1b67dae8a9/nodejs/node/pull/47876 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7ed88d8b6d6b22db34122d26e05f411e942f39b00147086bea876b1b67dae8a9/nodejs/node/pull/47876 |
| og:image:alt | The wrap/unwrap promises are now properly handled.
Refs: #47864
cc @tniessen @fhanau |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | panva |
| hostname | github.com |
| expected-hostname | github.com |
| None | a1022f03e4f0d91ea173e4e5dac892c982e0588c62f1ce56121d755a320a3569 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f472b8e6c7b3fdd5d0354972a3f4c516289bf0be |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/47876#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47876 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47876 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/47876 |
| Reload | https://github.com/nodejs/node/pull/47876 |
| Reload | https://github.com/nodejs/node/pull/47876 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/47876 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/47876 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/47876#issue-comment-box |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| panva:webcrypto-wrap-unwrap-tests | https://github.com/panva/node/tree/webcrypto-wrap-unwrap-tests |
|
test: fix webcrypto wrap unwrap tests
| https://github.com/nodejs/node/pull/47876#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| panva:webcrypto-wrap-unwrap-tests | https://github.com/panva/node/tree/webcrypto-wrap-unwrap-tests |
|
Conversation
5
| https://github.com/nodejs/node/pull/47876 |
|
Commits
1
| https://github.com/nodejs/node/pull/47876/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/47876/checks |
|
Files changed
| https://github.com/nodejs/node/pull/47876/files |
| Please reload this page | https://github.com/nodejs/node/pull/47876 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/panva |
| panva | https://github.com/panva |
| May 5, 2023 | https://github.com/nodejs/node/pull/47876#issue-1697403702 |
| Please reload this page | https://github.com/nodejs/node/pull/47876 |
| #47864 | https://github.com/nodejs/node/issues/47864 |
| @tniessen | https://github.com/tniessen |
| @fhanau | https://github.com/fhanau |
| Please reload this page | https://github.com/nodejs/node/pull/47876 |
|
| https://github.com/panva |
| test: fix webcrypto wrap unwrap tests | https://github.com/nodejs/node/pull/47876/commits/aa92e115366197c008e2ad84e55a2cae3f0b799e |
| aa92e11 | https://github.com/nodejs/node/pull/47876/commits/aa92e115366197c008e2ad84e55a2cae3f0b799e |
| nodejs#47864 | https://github.com/nodejs/node/issues/47864 |
| https://github.com/panva |
| panva | https://github.com/panva |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
webcrypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awebcrypto |
| May 5, 2023 | https://github.com/nodejs/node/pull/47876#event-9175661901 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| May 5, 2023 | https://github.com/nodejs/node/pull/47876#event-9175663978 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
May 5, 2023
| https://github.com/nodejs/node/pull/47876#pullrequestreview-1414563573 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/47876/files/aa92e115366197c008e2ad84e55a2cae3f0b799e |
| https://github.com/panva |
| panva | https://github.com/panva |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| May 5, 2023 | https://github.com/nodejs/node/pull/47876#event-9175699149 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| May 5, 2023 | https://github.com/nodejs/node/pull/47876#event-9175725300 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 5, 2023 | https://github.com/nodejs/node/pull/47876#issuecomment-1536079452 |
| https://ci.nodejs.org/job/node-test-pull-request/51654/ | https://ci.nodejs.org/job/node-test-pull-request/51654/ |
| Please reload this page | https://github.com/nodejs/node/pull/47876 |
| https://github.com/panva |
| panva | https://github.com/panva |
| May 5, 2023 | https://github.com/nodejs/node/pull/47876#issuecomment-1536079546 |
| Please reload this page | https://github.com/nodejs/node/pull/47876 |
| https://github.com/panva |
| panva | https://github.com/panva |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| May 5, 2023 | https://github.com/nodejs/node/pull/47876#event-9177284763 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| May 5, 2023 | https://github.com/nodejs/node/pull/47876#event-9177334368 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 5, 2023 | https://github.com/nodejs/node/pull/47876#issuecomment-1536318192 |
| https://ci.nodejs.org/job/node-test-pull-request/51662/ | https://ci.nodejs.org/job/node-test-pull-request/51662/ |
| Please reload this page | https://github.com/nodejs/node/pull/47876 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 5, 2023 | https://github.com/nodejs/node/pull/47876#issuecomment-1536442519 |
| https://ci.nodejs.org/job/node-test-pull-request/51664/ | https://ci.nodejs.org/job/node-test-pull-request/51664/ |
| Please reload this page | https://github.com/nodejs/node/pull/47876 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
May 5, 2023
| https://github.com/nodejs/node/pull/47876#pullrequestreview-1415149885 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/47876/files/aa92e115366197c008e2ad84e55a2cae3f0b799e |
| https://github.com/panva |
| panva | https://github.com/panva |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| May 5, 2023 | https://github.com/nodejs/node/pull/47876#event-9178970776 |
|
CI Reliability 2023-05-06
nodejs/reliability#557
| https://github.com/nodejs/reliability/issues/557 |
|
CI Reliability 2023-05-07
nodejs/reliability#558
| https://github.com/nodejs/reliability/issues/558 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| May 7, 2023 | https://github.com/nodejs/node/pull/47876#event-9184078205 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| ecf1427 | https://github.com/nodejs/node/commit/ecf1427df3b17dc77541c7def32dc7f672fa64d3 |
| May 7, 2023 | https://github.com/nodejs/node/pull/47876#event-9184078305 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 7, 2023 | https://github.com/nodejs/node/pull/47876#issuecomment-1537390506 |
| ecf1427 | https://github.com/nodejs/node/commit/ecf1427df3b17dc77541c7def32dc7f672fa64d3 |
| Please reload this page | https://github.com/nodejs/node/pull/47876 |
| https://github.com/panva |
| panva | https://github.com/panva |
| May 7, 2023 11:31 | https://github.com/nodejs/node/pull/47876#event-9184132465 |
|
CI Reliability 2023-05-08
nodejs/reliability#559
| https://github.com/nodejs/reliability/issues/559 |
|
CI Reliability 2023-05-09
nodejs/reliability#560
| https://github.com/nodejs/reliability/issues/560 |
|
CI Reliability 2023-05-10
nodejs/reliability#561
| https://github.com/nodejs/reliability/issues/561 |
|
CI Reliability 2023-05-11
nodejs/reliability#562
| https://github.com/nodejs/reliability/issues/562 |
|
CI Reliability 2023-05-12
nodejs/reliability#563
| https://github.com/nodejs/reliability/issues/563 |
| targos | https://github.com/targos |
|
May 12, 2023
| https://github.com/nodejs/node/pull/47876#ref-commit-7e34f77 |
|
| https://github.com/panva |
|
| https://github.com/targos |
| test: fix webcrypto wrap unwrap tests | https://github.com/nodejs/node/commit/7e34f7751874764623d6be54d2f42fe903e86997 |
| 7e34f77 | https://github.com/nodejs/node/commit/7e34f7751874764623d6be54d2f42fe903e86997 |
| #47864 | https://github.com/nodejs/node/issues/47864 |
| #47876 | https://github.com/nodejs/node/pull/47876 |
| #47864 | https://github.com/nodejs/node/issues/47864 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
May 15, 2023
| https://github.com/nodejs/node/pull/47876#ref-pullrequest-1710289834 |
|
v20.2.0 release proposal
#48020
| https://github.com/nodejs/node/pull/48020 |
| danielleadams | https://github.com/danielleadams |
|
Jul 6, 2023
| https://github.com/nodejs/node/pull/47876#ref-commit-43c967e |
|
| https://github.com/panva |
|
| https://github.com/danielleadams |
| test: fix webcrypto wrap unwrap tests | https://github.com/nodejs/node/commit/43c967ed501a9ebffe0b9db7b6b27a2b26ddeda0 |
| 43c967e | https://github.com/nodejs/node/commit/43c967ed501a9ebffe0b9db7b6b27a2b26ddeda0 |
| #47864 | https://github.com/nodejs/node/issues/47864 |
| #47876 | https://github.com/nodejs/node/pull/47876 |
| #47864 | https://github.com/nodejs/node/issues/47864 |
| MoLow | https://github.com/MoLow |
|
Jul 6, 2023
| https://github.com/nodejs/node/pull/47876#ref-commit-81d8d95 |
|
| https://github.com/panva |
|
| https://github.com/MoLow |
| test: fix webcrypto wrap unwrap tests | https://github.com/MoLow/node/commit/81d8d95ba03d6e81d91681fe7a1dbbb6442bf593 |
| 81d8d95 | https://github.com/MoLow/node/commit/81d8d95ba03d6e81d91681fe7a1dbbb6442bf593 |
| nodejs#47864 | https://github.com/nodejs/node/issues/47864 |
| nodejs#47876 | https://github.com/nodejs/node/pull/47876 |
| nodejs#47864 | https://github.com/nodejs/node/issues/47864 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Jul 10, 2023
| https://github.com/nodejs/node/pull/47876#ref-pullrequest-1793607989 |
|
v18.17.0 release proposal
#48694
| https://github.com/nodejs/node/pull/48694 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47876 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/47876/files/aa92e115366197c008e2ad84e55a2cae3f0b799e |
|
| https://github.com/tniessen |
|
tniessen
| https://github.com/tniessen |
|
| https://github.com/nodejs/node/pull/47876/files/aa92e115366197c008e2ad84e55a2cae3f0b799e |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
webcrypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awebcrypto |
| Please reload this page | https://github.com/nodejs/node/pull/47876 |
|
| https://github.com/panva |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/lpinca |
|
| https://github.com/tniessen |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |